Re: Test Failure in Ruby - AVRO-1.7

2017-04-11 Thread Sean Busbey 
the Ruby library is now passing tests on Ruby 1.9 - 2.4 for branch-1.7. I ended 
up backporting several things that were fixed in branch-1.8:

* 835bcba - (HEAD -> branch-1.7, apache/branch-1.7) AVRO-1775. Ruby: Use 
test-unit gem for running tests. (3 minutes ago)
* c235b4c - AVRO-1782. Ruby: Fix unit test failures in new versions of Ruby. (3 
minutes ago)
* ff2c83f - AVRO-1688. Ruby test_union(TestIO) is failing. (4 minutes ago)

Probably worth a different thread, but I think we have a different problem on 
branch-1.7. AVRO-1722 was a 1.8.0+ fix. A preliminary look at branch-1.7 
suggests its licensing info was never fixed (and there is atleast one rat 
failure).

On 2017-03-28 09:45 (-0500), Sean Busbey  wrote: 
> Okay, I filed AVRO-2013 and I upgraded AVRO-1516 to critical.
> 
> On Tue, Mar 28, 2017 at 9:42 AM, Sean Busbey  wrote:
> > Okay, I tried over the weekend to get a Ruby 1.8 install on my OS X
> > 10.11 laptop and failed. So I'm definitely not going to try to get
> > Ruby 1.8 support working in 1.7 again for this release cycle.
> >
> > With Ruby 1.9.3 I get 4 errors, three of which look like your
> > JSON::GeneratorError. I don't have one that looks like your last
> > issue, which is AVRO-1516.
> >
> > I'll file a jira for the 1.9.3 problems. What do folks think is a
> > reasonable amount of time for us to hold the 1.7.8 RCs while trying to
> > get these issues closed out?
> >
> > On Thu, Mar 23, 2017 at 3:05 PM, Sean Busbey  wrote:
> >> Ruby 1.8 not working on branch-1.7 might be something I want to fix,
> >> since I think that's the version we rely on in HBase (and we rely on
> >> Ruby 1.8).
> >>
> >> On Thu, Mar 23, 2017 at 3:04 PM, Sean Busbey  wrote:
> >>> Short version: we don't sufficiently document what version(s) of Ruby
> >>> we expect to work.
> >>>
> >>> We have AVRO-1559 for dropping Ruby 1.8 support, but it's open. There
> >>> are several tickets referenced from there that mention not working
> >>> with Ruby 1.8. (AVRO-1694, AVRO-1783). AVRO-1775 mentions having Ruby
> >>> 2.2 working for branch-1.8, but AVRO-1516 shows 2.0+ broken on 1.7+.
> >>>
> >>> So I think we want to work for Ruby 1.9 - 2.2, but 2.0+ is broken. Can
> >>> you test in Ruby 1.9?
> >>>
> >>>
> >>>
> >>> On Thu, Mar 23, 2017 at 11:32 AM, Sean Busbey  wrote:
>  Hurm. I didn't think our Avro stuff in the 1.7 branch worked with Ruby 
>  2.1.
>  lemme see if we doc this anywhere.
> 
>  On Thu, Mar 23, 2017 at 11:20 AM, suraj acharya  
>  wrote:
> > This is what I am using.
> > ruby 2.1.5p273 (2014-11-13) [x86_64-linux-gnu]
> >
> > Hope that helps.
> >
> > S
> >
> > -Suraj Acharya
> >
> > On Thu, Mar 23, 2017 at 8:51 AM, Sean Busbey  
> > wrote:
> >
> >> What's your Ruby environment?
> >>
> >> On Wed, Mar 22, 2017 at 5:34 PM, suraj acharya 
> >> wrote:
> >> > Hi,
> >> >
> >> > I was trying to make a release for 1.7 and I am seeing 3 tests fail 
> >> > in
> >> ruby.
> >> > I was wondering if someone in the community can help resolve these 
> >> > issues
> >> > so we can go ahead and work on getting a release.
> >> >
> >> > I have attached a sample of the error.
> >> >
> >> >   1) Error:
> >> > TestFingerprints#test_md5_fingerprint:
> >> > JSON::GeneratorError: only generation of JSON objects or arrays 
> >> > allowed
> >> >
> >> > /home/sacharya/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/
> >> json/common.rb:224:in
> >> > `generate'
> >> >
> >> > /home/sacharya/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/
> >> json/common.rb:224:in
> >> > `generate'
> >> >
> >> > /home/sacharya/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/
> >> json/common.rb:394:in
> >> > `dump'
> >> > 
> >> > /home/sacharya/avro/lang/ruby/lib/avro/schema_normalization.rb:28:in
> >> > `to_parsing_form'
> >> > 
> >> > /home/sacharya/avro/lang/ruby/lib/avro/schema_normalization.rb:20:in
> >> > `to_parsing_form'
> >> > /home/sacharya/avro/lang/ruby/lib/avro/schema.rb:143:in
> >> > `md5_fingerprint'
> >> > /home/sacharya/avro/lang/ruby/test/test_fingerprints.rb:26:in
> >> > `test_md5_fingerprint'
> >> > /usr/lib/ruby/2.1.0/minitest/unit.rb:1265:in `run'
> >> > /usr/lib/ruby/2.1.0/test/unit/testcase.rb:17:in `run'
> >> > /usr/lib/ruby/2.1.0/minitest/unit.rb:940:in `block in _run_suite'
> >> > /usr/lib/ruby/2.1.0/minitest/unit.rb:933:in `map'
> >> > /usr/lib/ruby/2.1.0/minitest/unit.rb:933:in `_run_suite'
> >> > /usr/lib/ruby/2.1.0/test/unit.rb:663:in `block in _run_suites'
> >> > /usr/lib/ruby/2.1.0/test/unit.rb:661:in `each'
> >> > /usr/lib/ruby/2.1.0/test/unit.rb:661:in

[jira] [Updated] (AVRO-1688) Ruby test_union(TestIO) is failing

2017-04-11 Thread Sean Busbey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated AVRO-1688:
--
Fix Version/s: 1.7.8

> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.7.8, 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
>   1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (AVRO-1782) Test failures in Ruby 2.1/2.2

2017-04-11 Thread Sean Busbey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey updated AVRO-1782:
--
Fix Version/s: 1.7.8

> Test failures in Ruby 2.1/2.2
> -
>
> Key: AVRO-1782
> URL: https://issues.apache.org/jira/browse/AVRO-1782
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.7.7
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.7.8, 1.8.0
>
> Attachments: AVRO-1782.patch
>
>
> When running the Avro Ruby implementation's test suite in Ruby 2.1 or 2.2, I 
> get several test failures. The distinct errors are:
> {code}
> NameError: uninitialized constant Avro::SchemaNormalization::JSON
> avro/lang/ruby/lib/avro/schema_normalization.rb:28:in `to_parsing_form'
> {code}
> and
> {code}
> TestSchemaNormalization#test_shared_dataset:
> NameError: uninitialized constant CaseFinder::StringScanner
> /Users/martin/Applications/avro/lang/ruby/test/case_finder.rb:30:in 
> `initialize'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1688) Ruby test_union(TestIO) is failing

2017-04-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-1688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965321#comment-15965321
 ] 

ASF subversion and git services commented on AVRO-1688:
---

Commit ff2c83f4406a8c00f9848d6897aec58cfd9e9851 in avro's branch 
refs/heads/branch-1.7 from [~twhite]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=ff2c83f ]

AVRO-1688. Ruby test_union(TestIO) is failing.

git-svn-id: https://svn.apache.org/repos/asf/avro/trunk@1690745 
13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 74b444929bfdbdd0bcdf45a80dec7b507f805428)


> Ruby test_union(TestIO) is failing
> --
>
> Key: AVRO-1688
> URL: https://issues.apache.org/jira/browse/AVRO-1688
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Reporter: Tom White
>Assignee: Tom White
>Priority: Blocker
> Fix For: 1.8.0
>
> Attachments: AVRO-1688.patch, AVRO-1688.patch
>
>
> The failure message is
> {noformat}
>   1) Failure:
> test_union(TestIO) [/Users/tom/workspace/avro/lang/ruby/test/test_io.rb:340]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (AVRO-1775) Running unit tests on Ruby 2.2

2017-04-11 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/AVRO-1775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15965322#comment-15965322
 ] 

ASF subversion and git services commented on AVRO-1775:
---

Commit 835bcbacbdf17593dff51318d685938b07468907 in avro's branch 
refs/heads/branch-1.7 from [~martinkl]
[ https://git-wip-us.apache.org/repos/asf?p=avro.git;h=835bcba ]

AVRO-1775. Ruby: Use test-unit gem for running tests.

git-svn-id: https://svn.apache.org/repos/asf/avro/branches/branch-1.8@1725904 
13f79535-47bb-0310-9956-ffa450edef68
(cherry picked from commit 162aa95c11c935a43f2e2130ca3e28279b3ce6fa)


> Running unit tests on Ruby 2.2
> --
>
> Key: AVRO-1775
> URL: https://issues.apache.org/jira/browse/AVRO-1775
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.8.0
>
> Attachments: AVRO-1775-1.patch
>
>
> Ruby 2.2 [removed the test/unit framework from the standard 
> library|https://bugs.ruby-lang.org/issues/9711#note-12]. As the Avro Ruby 
> implementation uses it for its tests, we need to add a dependency on the 
> {{test-unit}} gem in order to run the tests in Ruby 2.2.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (AVRO-2013) Unit test failure in Ruby 1.9

2017-04-11 Thread Sean Busbey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved AVRO-2013.
---
   Resolution: Duplicate
 Assignee: (was: Sean Busbey)
Fix Version/s: (was: 1.7.8)

this isn't a problem in master or branch-1.8 due to AVRO-1782, so switch to 
backporting that for branch-1.7

> Unit test failure in Ruby 1.9
> -
>
> Key: AVRO-2013
> URL: https://issues.apache.org/jira/browse/AVRO-2013
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.7.8
>Reporter: Sean Busbey
>Priority: Critical
> Attachments: AVRO-2013.0.patch, AVRO-2013-branch-1.8.v0.patch
>
>
> {code}
>   1) Error:
> test_md5_fingerprint(TestFingerprints):
> JSON::GeneratorError: only generation of JSON objects or arrays allowed
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:394:in
>  `dump'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:28:in 
> `to_parsing_form'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:20:in 
> `to_parsing_form'
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema.rb:143:in 
> `md5_fingerprint'
> /Users/busbey/projects/avro/lang/ruby/test/test_fingerprints.rb:26:in 
> `test_md5_fingerprint'
>   2) Error:
> test_sha256_fingerprint(TestFingerprints):
> JSON::GeneratorError: only generation of JSON objects or arrays allowed
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:394:in
>  `dump'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:28:in 
> `to_parsing_form'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:20:in 
> `to_parsing_form'
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema.rb:149:in 
> `sha256_fingerprint'
> /Users/busbey/projects/avro/lang/ruby/test/test_fingerprints.rb:35:in 
> `test_sha256_fingerprint'
>   3) Error:
> test_primitives(TestSchemaNormalization):
> JSON::GeneratorError: only generation of JSON objects or arrays allowed
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:224:in
>  `generate'
> 
> /Users/busbey/projects/avro/lang/ruby/.gem/gems/json_pure-2.0.3/lib/json/common.rb:394:in
>  `dump'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:28:in 
> `to_parsing_form'
> 
> /Users/busbey/projects/avro/lang/ruby/lib/avro/schema_normalization.rb:20:in 
> `to_parsing_form'
> 
> /Users/busbey/projects/avro/lang/ruby/test/test_schema_normalization.rb:28:in 
> `block in test_primitives'
> 
> /Users/busbey/projects/avro/lang/ruby/test/test_schema_normalization.rb:23:in 
> `each'
> 
> /Users/busbey/projects/avro/lang/ruby/test/test_schema_normalization.rb:23:in 
> `test_primitives'
>   4) Error:
> test_shared_dataset(TestSchemaNormalization):
> NameError: uninitialized constant CaseFinder::StringScanner
> /Users/busbey/projects/avro/lang/ruby/test/case_finder.rb:11:in 
> `initialize'
> /Users/busbey/projects/avro/lang/ruby/test/case_finder.rb:7:in `new'
> /Users/busbey/projects/avro/lang/ruby/test/case_finder.rb:7:in `cases'
> 
> /Users/busbey/projects/avro/lang/ruby/test/test_schema_normalization.rb:166:in
>  `test_shared_dataset'
> 52 tests, 799 assertions, 0 failures, 4 errors, 0 skips
> {code}
> I'm using 1.9.3 installed via RVM.
> {code}
> Busbey-MBA:ruby busbey$ rvm version
> rvm 1.29.1 (latest) by Michal Papis, Piotr Kuczynski, Wayne E. Seguin 
> [https://rvm.io/]
> Busbey-MBA:ruby busbey$ rvm list
> rvm rubies
> => ruby-1.9.3-p551 [ x86_64 ]
>  * ruby-2.2.1 [ x86_64 ]
> # => - current
> # =* - current && default
> #  * - default
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Resolved] (AVRO-1516) Unit test failure in Ruby 2.0 and above

2017-04-11 Thread Sean Busbey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-1516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey resolved AVRO-1516.
---
   Resolution: Duplicate
 Assignee: (was: Sean Busbey)
Fix Version/s: (was: 1.7.8)

found it! this is fixed in 1.8+ by AVRO-1688 so switch to a backport of that.

> Unit test failure in Ruby 2.0 and above
> ---
>
> Key: AVRO-1516
> URL: https://issues.apache.org/jira/browse/AVRO-1516
> Project: Avro
>  Issue Type: Test
>  Components: ruby
>Affects Versions: 1.7.6
>Reporter: Martin Kleppmann
>
> The following unit test fails when run with Ruby 2.0 and above:
> {noformat}
> $ bundle exec rake test
> /Users/mkleppma/.rubies/ruby-2.0.0-p195/bin/ruby -I"lib:ext:bin:test" 
> -I"/Users/mkleppma/.gem/ruby/2.0.0/gems/rake-10.3.1/lib" 
> "/Users/mkleppma/.gem/ruby/2.0.0/gems/rake-10.3.1/lib/rake/rake_test_loader.rb"
>  "test/test_datafile.rb" "test/test_help.rb" "test/test_io.rb" 
> "test/test_protocol.rb" "test/test_schema.rb" "test/test_socket_transport.rb"
> Run options:
> # Running tests:
> [30/41] TestIO#test_union = 0.00 s
>   1) Failure:
> test_union(TestIO) 
> [/Users/mkleppma/Applications/avro/lang/ruby/test/test_io.rb:339]:
> <-3372032630846393039> expected but was
> <-3.372032630846393e+18>.
> Finished tests in 0.346139s, 118.4495 tests/s, 2207.2058 assertions/s.
> 41 tests, 764 assertions, 1 failures, 0 errors, 0 skips
> ruby -v: ruby 2.0.0p195 (2013-05-14 revision 40734) [x86_64-darwin12.3.0]
> rake aborted!
> Command failed with status (1): [ruby -I"lib:ext:bin:test" 
> -I"/Users/mkleppma/.gem/ruby/2.0.0/gems/rake-10.3.1/lib" 
> "/Users/mkleppma/.gem/ruby/2.0.0/gems/rake-10.3.1/lib/rake/rake_test_loader.rb"
>  "test/test_datafile.rb" "test/test_help.rb" "test/test_io.rb" 
> "test/test_protocol.rb" "test/test_schema.rb" "test/test_socket_transport.rb" 
> ]
> /Users/mkleppma/.gem/ruby/2.0.0/gems/echoe-4.6.5/lib/echoe.rb:749:in `block 
> in define_tasks'
> Tasks: TOP => test_inner
> (See full trace by running task with --trace)
> {noformat}
> Brief investigation suggests that this isn't a bug in Avro, but just a badly 
> written test. The test is comparing -3372032630846393039 and 
> -3372032630846393000.0, which Ruby 1.9 and below consider to be equal, but 
> Ruby 2.0 and above consider to be non-equal.
> Our tests shouldn't be relying on such edge cases of type coercion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Assigned] (AVRO-1782) Test failures in Ruby 2.1/2.2

2017-04-11 Thread Sean Busbey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sean Busbey reassigned AVRO-1782:
-

Assignee: Martin Kleppmann

> Test failures in Ruby 2.1/2.2
> -
>
> Key: AVRO-1782
> URL: https://issues.apache.org/jira/browse/AVRO-1782
> Project: Avro
>  Issue Type: Bug
>  Components: ruby
>Affects Versions: 1.7.7
>Reporter: Martin Kleppmann
>Assignee: Martin Kleppmann
> Fix For: 1.8.0
>
> Attachments: AVRO-1782.patch
>
>
> When running the Avro Ruby implementation's test suite in Ruby 2.1 or 2.2, I 
> get several test failures. The distinct errors are:
> {code}
> NameError: uninitialized constant Avro::SchemaNormalization::JSON
> avro/lang/ruby/lib/avro/schema_normalization.rb:28:in `to_parsing_form'
> {code}
> and
> {code}
> TestSchemaNormalization#test_shared_dataset:
> NameError: uninitialized constant CaseFinder::StringScanner
> /Users/martin/Applications/avro/lang/ruby/test/case_finder.rb:30:in 
> `initialize'
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (AVRO-2022) IDL does not allow `schema` as identifier

2017-04-11 Thread Erik van Oosten (JIRA) 

 [ 
https://issues.apache.org/jira/browse/AVRO-2022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erik van Oosten updated AVRO-2022:
--
Description: 
The keyword {{schema}} is now allowed as escaped identifier in IDL. E.g. the 
following does not compile:

{noformat}
record {
   string `schema`;
}
{noformat}

Patches are available for the master branch: 
https://github.com/apache/avro/pull/209 and 1.7 branch: 
https://github.com/apache/avro/pull/211

  was:
The keyword {{schema}} is now allowed as escaped identifier in IDL. E.g. the 
following does not compile:

{noformat}
record {
   string `schema`;
}
{noformat}

Patches are available for the master and 1.7 branches here: (todo)


> IDL does not allow `schema` as identifier
> -
>
> Key: AVRO-2022
> URL: https://issues.apache.org/jira/browse/AVRO-2022
> Project: Avro
>  Issue Type: Bug
>  Components: java
>Affects Versions: 1.7.7, 1.8.1
>Reporter: Erik van Oosten
>
> The keyword {{schema}} is now allowed as escaped identifier in IDL. E.g. the 
> following does not compile:
> {noformat}
> record {
>string `schema`;
> }
> {noformat}
> Patches are available for the master branch: 
> https://github.com/apache/avro/pull/209 and 1.7 branch: 
> https://github.com/apache/avro/pull/211



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (AVRO-2022) IDL does not allow `schema` as identifier

2017-04-11 Thread Erik van Oosten (JIRA) 
Erik van Oosten created AVRO-2022:
-

 Summary: IDL does not allow `schema` as identifier
 Key: AVRO-2022
 URL: https://issues.apache.org/jira/browse/AVRO-2022
 Project: Avro
  Issue Type: Bug
  Components: java
Affects Versions: 1.8.1, 1.7.7
Reporter: Erik van Oosten


The keyword {{schema}} is now allowed as escaped identifier in IDL. E.g. the 
following does not compile:

{noformat}
record {
   string `schema`;
}
{noformat}

Patches are available for the master and 1.7 branches here: (todo)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] avro pull request #211: Allow `schema` as identifier (1.7)

2017-04-11 Thread erikvanoosten 
GitHub user erikvanoosten opened a pull request:

https://github.com/apache/avro/pull/211

Allow `schema` as identifier (1.7)

Currently the word `schema` is not allowed as identifier, even not when it 
is escaped in backticks. This patch fixed that for the 1.7 branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erikvanoosten/avro idl-identifier-schema

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit d15c7da9be4ad16fff140e2dda7ee794d922d138
Author: Erik van Oosten 
Date:   2017-04-11T12:25:39Z

Allow `schema` as identifier.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] avro pull request #210: Idl identifier `schema` (1.7)

2017-04-11 Thread erikvanoosten 
Github user erikvanoosten closed the pull request at:

https://github.com/apache/avro/pull/210


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] avro pull request #210: Idl identifier `schema` (1.7)

2017-04-11 Thread erikvanoosten 
GitHub user erikvanoosten opened a pull request:

https://github.com/apache/avro/pull/210

Idl identifier `schema` (1.7)

Currently the word `schema` is not allowed as identifier, even not when it 
is escaped in backticks. This patch fixed that for the 1.7 branch.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erikvanoosten/avro idl-identifier-schema

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/210.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #210


commit 39913ad72b89261d17bf528bf688259671a70832
Author: Doug Cutting 
Date:   2014-09-02T22:20:08Z

Copy trunk to branch-1.7.

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1622143 
13f79535-47bb-0310-9956-ffa450edef68

commit e99ccae22601a8106327e660217af2ab012c88d5
Author: Thomas White 
Date:   2014-10-27T14:14:33Z

Merge -r 1634541:1634542 from trunk to branch. Fixes: AVRO-1489

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1634543 
13f79535-47bb-0310-9956-ffa450edef68

commit 82dc795200b56f3846b12c67c36e723df768a450
Author: Thomas White 
Date:   2014-11-17T15:33:47Z

Merge -r 1640170:1640171 from trunk to branch. Fixes: AVRO-1596. Java: 
Cannot read past corrupted block in Avro data file.

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1640173 
13f79535-47bb-0310-9956-ffa450edef68

commit 49d2cbe3fdd5ecff86e0a57f98021b0856a18f72
Author: Thomas White 
Date:   2014-11-17T16:08:43Z

Merge -r 1640178:1640179 from trunk to branch. Fixes: AVRO-1596. AVRO-834. 
Java: Data File corruption recovery tool. Contributed by scottcarey and 
tomwhite.

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1640181 
13f79535-47bb-0310-9956-ffa450edef68

commit b4aa494e581eb3a78ff2b2efa5a932a91d7449e4
Author: Thomas White 
Date:   2014-11-18T10:10:55Z

Merge -r 1640292:1640293 from trunk to branch. Fixes: AVRO-1585. Java: 
Deprecate Jackson classes in public API.

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1640294 
13f79535-47bb-0310-9956-ffa450edef68

commit 8e06aea34b8a5a779a29896102f89f738aa2f6c1
Author: Thomas White 
Date:   2015-06-26T14:40:47Z

AVRO-1681. Improve generated JavaDocs. Contributed by Charles 
Gariépy-Ikeson.

git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1687779 
13f79535-47bb-0310-9956-ffa450edef68

commit 113f61d6ad570a37281dffc5771c2c11a7cd3d62
Author: Sean Busbey 
Date:   2015-09-12T07:28:03Z

AVRO-1709. Ruby: Ignore generated files. Contributed by Daniel Schierbeck.

The data.avr file is generated every times the tests are run;
Gemfile.lock is generated every time `bundle install` is run.

This closes #45



git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1702596 
13f79535-47bb-0310-9956-ffa450edef68

commit a0506d472cea021d064e702670a83490dd69fb35
Author: Sean Busbey 
Date:   2015-09-14T00:16:22Z

AVRO-1694. Ruby: Schema normaliation and fingerprints. Contributed by 
Daniel Schierbeck.

* Avro::SchemaNormalization.to_parsing_form converts a schema to Parsing
Canonical Form
* support for MD5 and SHA256 fingerprints

This closes #40



git-svn-id: 
https://svn.apache.org/repos/asf/avro/branches/branch-1.7@1702841 
13f79535-47bb-0310-9956-ffa450edef68

commit 49f3bf03df80c74c82416618639efbc81f81b7a0
Author: radai-rosenblatt 
Date:   2016-10-04T22:36:18Z

AVRO-1988 Make 1.7 branch actually build. Contributed by Radai Rosenblatt.

Seems like AVRO-1681 was only partially applied to the 1.7 branch. 
Specifically, the expected test output was not updated to reflect changes in 
javadoc.
This commit fixes the tests and makes the build pass

Also ignores IDEA files.

Closes #139.

Signed-off-by: Suraj Acharya 
Signed-off-by: Sean Busbey 

commit 3345e13238d1d0278a4e1da5a9df60356892193c
Author: radai-rosenblatt 
Date:   2017-01-13T23:22:57Z

AVRO-1901: Record named Exception generated bad code

Amending-Author: Ben McCann 

backport to branch-1.7.

Exception record for share/test/schemas/specialtypes.avdl skipped since 
branch-1.7 doesn't have AVRO-1614.

Closes #188.

Signed-off-by: Sean Busbey 

commit 646dee5e9196ff0784776b55eba9d9ed9ba2a805
Author: Al B 
Date:   2017-01-30T21:56:53Z

[GitHub] avro pull request #209: Allow `schema` as identifier.

2017-04-11 Thread erikvanoosten 
GitHub user erikvanoosten opened a pull request:

https://github.com/apache/avro/pull/209

Allow `schema` as identifier.

Currently the word `schema` is not allowed as identifier, even not when it 
is escaped in backticks. This patch fixed that.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/erikvanoosten/avro idl-schema-identifier2

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/avro/pull/209.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #209


commit e18ac2f55ea6728f3db6a7a32c3a8ef242adf612
Author: Erik van Oosten 
Date:   2017-04-11T12:33:08Z

Allow `schema` as identifier.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---