Re: [VOTE] Release Apache Calcite 1.28.0 (release candidate 0)

2021-10-15 Thread Julian Hyde
Since this vote overlaps a weekend, I'll give you all some extra time.
The vote will last for 96 hours (or until there is a majority of 3).
It will end at 12 noon pacific (1900 UTC) on Tuesday 19th October.
Still, early votes are appreciated.

Julian


On Fri, Oct 15, 2021 at 11:01 AM Julian Hyde  wrote:
>
> Hi all,
>
> I have created a build for Apache Calcite 1.28.0, release
> candidate 0.
>
> Thanks to everyone who has contributed to this release.
>
> You can read the release notes here:
> https://github.com/apache/calcite/blob/calcite-1.28.0-rc0/site/_docs/history.md
>
> The commit to be voted upon:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=dec167ac18272c0cd8be477d6b162d7a31a62114
>
> Its hash is dec167ac18272c0cd8be477d6b162d7a31a62114
>
> Tag:
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.28.0-rc0
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.28.0-rc0
> (revision 50450)
>
> The hashes of the artifacts are as follows:
> d61c4935d7d3b66425ff6e0c5e6e506b56f734d562f0fc6e69dc1d484da1d92d7d922930fd7b545abe0dc7b0178f6847ff4239ad52c52c8fa155668aa3d3fc38
> *apache-calcite-1.28.0-src.tar.gz
>
> A staged Maven repository is available for review at:
> https://repository.apache.org/content/repositories/orgapachecalcite-1121/org/apache/calcite/
>
> Release artifacts are signed with the following key:
> https://people.apache.org/keys/committer/jhyde.asc
> https://www.apache.org/dist/calcite/KEYS
>
> Please vote on releasing this package as Apache Calcite 1.28.0.
>
> The vote is open for the next 72 hours and passes if a majority of at
> least three +1 PMC votes are cast.
>
> [ ] +1 Release this package as Apache Calcite 1.28.0
> [ ]  0 I don't feel strongly about it, but I'm okay with the release
> [ ] -1 Do not release this package because...
>
> Here is my vote:
>
> +1 (binding)


[VOTE] Release Apache Calcite 1.28.0 (release candidate 0)

2021-10-15 Thread Julian Hyde
Hi all,

I have created a build for Apache Calcite 1.28.0, release
candidate 0.

Thanks to everyone who has contributed to this release.

You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.28.0-rc0/site/_docs/history.md

The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=dec167ac18272c0cd8be477d6b162d7a31a62114

Its hash is dec167ac18272c0cd8be477d6b162d7a31a62114

Tag:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.28.0-rc0

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.28.0-rc0
(revision 50450)

The hashes of the artifacts are as follows:
d61c4935d7d3b66425ff6e0c5e6e506b56f734d562f0fc6e69dc1d484da1d92d7d922930fd7b545abe0dc7b0178f6847ff4239ad52c52c8fa155668aa3d3fc38
*apache-calcite-1.28.0-src.tar.gz

A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1121/org/apache/calcite/

Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/jhyde.asc
https://www.apache.org/dist/calcite/KEYS

Please vote on releasing this package as Apache Calcite 1.28.0.

The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.

[ ] +1 Release this package as Apache Calcite 1.28.0
[ ]  0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...

Here is my vote:

+1 (binding)


[jira] [Created] (CALCITE-4856) Gradle prepareVote fails with 'not authorized'

2021-10-15 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-4856:


 Summary: Gradle prepareVote fails with 'not authorized'
 Key: CALCITE-4856
 URL: https://issues.apache.org/jira/browse/CALCITE-4856
 Project: Calcite
  Issue Type: Bug
Reporter: Julian Hyde


Gradle {{prepareVote}} fails with 'not authorized' error.

{noformat}
$ ./gradlew prepareVote -Prc=0 -Pasf

> Configure project :
Building Apache Calcite 1.28.0

> Task :gitProps
Execution optimizations have been disabled for task ':gitProps' to ensure 
correctness due to the following reasons:
  - Gradle detected a problem with the following location: 
'/home/jhyde/dev/release/calcite'. Reason: Task ':gitProps' uses this output of 
task ':babel:fmppMain' without declaring an explicit or implicit dependency. 
This can lead to incorrect results being produced, depending on what order the 
tasks are executed. Please refer to 
https://docs.gradle.org/7.2/userguide/validation_problems.html#implicit_dependency
 for more details about this problem.
...
> Task :pushRcTag
Pushing tag to Git remote release-origin: https://github.com/apache/calcite.git

> Task :pushRcTag FAILED

Build calcite FAILURE reason:
Execution failed for task ':pushRcTag':
Caused by: org.eclipse.jgit.api.errors.TransportException: 
https://github.com/apache/calcite.git: not authorized
at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:180)
at 
com.github.vlsi.gradle.release.jgit.dsl.GitExtensionsKt.push(GitExtensions.kt:132)
at 
com.github.vlsi.gradle.release.GitPushTask$pushTag$1.invoke(GitPushTask.kt:54)
at 
com.github.vlsi.gradle.release.GitPushTask$pushTag$1.invoke(GitPushTask.kt:30)
at 
com.github.vlsi.gradle.release.DefaultGitTask.jgit(DefaultGitTask.kt:45)
at 
com.github.vlsi.gradle.release.GitPushTask.pushTag(GitPushTask.kt:50)
at 
org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:104)
at 
org.gradle.api.internal.project.taskfactory.StandardTaskAction.doExecute(StandardTaskAction.java:58)
...
at 
org.eclipse.jgit.transport.Transport.push(Transport.java:1368)
at org.eclipse.jgit.api.PushCommand.call(PushCommand.java:170)
... 89 more


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':pushRcTag'.
> org.eclipse.jgit.api.errors.TransportException: 
> https://github.com/apache/calcite.git: not authorized

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with 
Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings 
and determine if they come from your own scripts or plugins.

See 
https://docs.gradle.org/7.2/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 29 invalid unit(s) of work 
during this build to ensure correctness.
Please consult deprecation warnings for more details.

BUILD FAILED in 2m 32s
268 actionable tasks: 187 executed, 20 from cache, 61 up-to-date
S3 cache 5s wasted (3s wasted on hits, 2s wasted on misses), reads: 43, hits: 
20, elapsed: 5s, received: 8 KiB

{noformat}

I had tried previously without the {{-Pasf}} flag but that ran into other 
errors, sooner in the process, that seemed to be about my environment. I 
concluded that the dry-run was a waste of time.

I'm not sure why the command is trying to push to github rather than gitbox.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review request: CALCITE-4818 (AggregateExpandDistinctAggregatesRule must infer correct data type for top aggregate calls)

2021-10-15 Thread Taras Ledkov

Hi,

Gently reminder about review.

On 04.10.2021 20:30, Taras Ledkov wrote:

Hi,

Please review the patch for the issue CALCITE-4818 [1], see PR#2560 [2].

Looks like the rule 'AggregateExpandDistinctAggregatesRule' contains 
another bug with inferring result type of the top aggregate calls.


e.g.

If the type system expand sum type like postgress:
SUM(TINYINT | SMALLINT | INTEGER) ->  BIGINT
SUM(BIGINT) -> DECIMAL

The query:
SELECT SUM(i), SUM(DISTINCT i) FROM TBL;
where i - INTEGER field.

produces the plan:
LogicalProject(EXPR$0=[CAST($0):BIGINT], EXPR$1=[$1])
 LogicalAggregate(group=[{}], EXPR$0=[SUM($1)], EXPR$1=[SUM($0)]) -->  
RowType[DECIMAL, BIGINT]
    LogicalAggregate(group=[{0}], 
EXPR$0=[SUM($0)]) --> RowType[INTEGER, 
BIGINT]

  LogicalProject(COMM=[$6])
    LogicalTableScan(table=[[CATALOG, SALES, EMP]])

But the rule ignores the change row type in the bottom aggregate.

I propose the simple fix: pass 'null' type to the 
'AggregateCall.create' call to infer aggregate type from the input.


[1]. https://issues.apache.org/jira/browse/CALCITE-4818
[2]. https://github.com/apache/calcite/pull/2560


--
Taras Ledkov
Mail-To: tled...@gridgain.com



[jira] [Created] (CALCITE-4855) SQLFeatureNotSupported with avatica-remote and MariaDB

2021-10-15 Thread Alexander Falb (Jira)
Alexander Falb created CALCITE-4855:
---

 Summary: SQLFeatureNotSupported with avatica-remote and MariaDB
 Key: CALCITE-4855
 URL: https://issues.apache.org/jira/browse/CALCITE-4855
 Project: Calcite
  Issue Type: Bug
  Components: avatica
Affects Versions: avatica-1.19.0, 1.27.0
Reporter: Alexander Falb


I'm currently experimenting with a Calcite/Avatica-Remote Javaapplicatioin and 
MariaDB server. 

When connecting directly to the MariaDB (without Calcite) 
"jdbc:mariadb://localhost..." my PreparedStatement prepares and executes just 
fine, the same holds true when using only Calcite 
"jdbc:calcite:schemaType=JDBC;schema.jdbcUrl=jdbc:mariadb://localhost..."

But as soon as I start the standalone Avatica server (same MariaDB server, same 
MariaDB JDBC driver version) and connect through it 
"jdbc:avatica:remote:url=..." I get the following exception on my 
clientapplication when preparing my PreparedStatement:
{code:java}
 org.apache.calcite.avatica.AvaticaSqlException: Error -1 (0) : while 
preparing SQL: SELECT id FROM ent WHERE col = ?
at org.apache.calcite.avatica.Helper.createException(Helper.java:54)
at org.apache.calcite.avatica.Helper.createException(Helper.java:41)
at 
org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:358)
at 
org.apache.calcite.avatica.AvaticaConnection.prepareStatement(AvaticaConnection.java:175)
{code}
I started debugging the avatica server and found the cause:
{code:java}
java.sql.SQLFeatureNotSupportedException: Getting parameter type metadata are 
not supported
at 
org.mariadb.jdbc.internal.util.exceptions.ExceptionFactory.createException(ExceptionFactory.java:54)
at 
org.mariadb.jdbc.internal.util.exceptions.ExceptionFactory.notSupported(ExceptionFactory.java:172)
at 
org.mariadb.jdbc.MariaDbParameterMetaData.getParameterType(MariaDbParameterMetaData.java:133)
at 
org.apache.calcite.avatica.jdbc.JdbcMeta.parameters(JdbcMeta.java:277)
at org.apache.calcite.avatica.jdbc.JdbcMeta.signature(JdbcMeta.java:288)
at org.apache.calcite.avatica.jdbc.JdbcMeta.prepare(JdbcMeta.java:721)
at 
org.apache.calcite.avatica.remote.LocalService.apply(LocalService.java:201)
{code}
It looks like MariaDB does not support getParameterType(int param): 
[https://jira.mariadb.org/browse/CONJ-568] and 
[https://jira.mariadb.org/browse/MDEV-15031].

Is there a way to prevent avatica-server from calling this method?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [ANNOUNCE] New committer: Zhaohui Xu

2021-10-15 Thread XING JIN
Congratulations !

Jin

Michael Mior  于2021年10月15日周五 上午12:56写道:

> Welcome Zhaohui!
> --
> Michael Mior
> mm...@apache.org
>
> Le mer. 6 oct. 2021 à 16:48, Stamatis Zampetakis  a
> écrit :
> >
> > Apache Calcite's Project Management Committee (PMC) has invited Zhaohui
> Xu
> > to
> > become a committer, and we are pleased to announce that they have
> accepted.
> >
> > Numbers speak for themselves and Zhaohui has over 30 commits already in
> > master
> > and more than 20 open pull requests waiting to get in. Great record so
> far
> > including
> > (but not limited to) improvements and fixes in the view based
> > rewriting modules,
> > JSON serialization, metadata, and field trimming.
> >
> > Zhaohui, welcome, thank you for your contributions, and we look forward
> to
> > your
> > further interactions with the community! If you wish, please feel free to
> > tell
> > us more about yourself and what you are working on.
> >
> > Stamatis (on behalf of the Apache Calcite PMC)
>