[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... CASCADE/RESTRICT

2011-04-21 Thread Carl Steinbach (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022625#comment-13022625
 ] 

Carl Steinbach commented on HIVE-2090:
--

+1. Will commit if tests pass.

 Add DROP DATABASE ... CASCADE/RESTRICT
 

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch, HIVE-2090.5.patch, HIVE-2090.6.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... CASCADE/RESTRICT

2011-04-21 Thread Carl Steinbach (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13022880#comment-13022880
 ] 

Carl Steinbach commented on HIVE-2090:
--

I'm running tests now.

 Add DROP DATABASE ... CASCADE/RESTRICT
 

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch, HIVE-2090.5.patch, HIVE-2090.6.patch, HIVE-2090.7.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (HIVE-2090) Add DROP DATABASE ... CASCADE/RESTRICT

2011-04-18 Thread jirapos...@reviews.apache.org (JIRA)

[ 
https://issues.apache.org/jira/browse/HIVE-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13021189#comment-13021189
 ] 

jirapos...@reviews.apache.org commented on HIVE-2090:
-


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/551/
---

(Updated 2011-04-18 19:30:43.636903)


Review request for hive.


Summary (updated)
---

https://issues.apache.org/jira/secure/attachment/12476401/HIVE-2090.6.patch


This addresses bug HIVE-2090.
https://issues.apache.org/jira/browse/HIVE-2090


Diffs (updated)
-

  trunk/metastore/if/hive_metastore.thrift 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.h 1091617 
  trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp 1091617 
  
trunk/metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore_server.skeleton.cpp 
1091617 
  
trunk/metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ThriftHiveMetastore.java
 1091617 
  trunk/metastore/src/gen/thrift/gen-php/hive_metastore/ThriftHiveMetastore.php 
1091617 
  
trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore-remote 
1091617 
  trunk/metastore/src/gen/thrift/gen-py/hive_metastore/ThriftHiveMetastore.py 
1091617 
  trunk/metastore/src/gen/thrift/gen-rb/thrift_hive_metastore.rb 1091617 
  trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 
1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
 1091617 
  
trunk/metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1091617 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DropDatabaseDesc.java 
1091617 
  trunk/ql/src/test/queries/clientnegative/database_drop_not_empty_restrict.q 
PRE-CREATION 
  trunk/ql/src/test/queries/clientpositive/database.q 1091617 
  
trunk/ql/src/test/results/clientnegative/database_drop_not_empty_restrict.q.out 
PRE-CREATION 
  trunk/ql/src/test/results/clientpositive/database.q.out 1091617 

Diff: https://reviews.apache.org/r/551/diff


Testing
---


Thanks,

Carl



 Add DROP DATABASE ... CASCADE/RESTRICT
 

 Key: HIVE-2090
 URL: https://issues.apache.org/jira/browse/HIVE-2090
 Project: Hive
  Issue Type: New Feature
  Components: Metastore
Reporter: Siying Dong
Assignee: Siying Dong
Priority: Minor
 Attachments: HIVE-2090.1.patch, HIVE-2090.2.patch, HIVE-2090.3.patch, 
 HIVE-2090.4.patch, HIVE-2090.5.patch, HIVE-2090.6.patch


 A DROP DATABASE ... FORCE will be useful, when we use a database for 
 isolation when doing some tests. Being able to force cleaning up the database 
 will make test cleaning up easier.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira