Re: IGNITE-1144

2016-02-22 Thread Dood 

Val,

All the test passed on TC - you can look at the PR at any time. Thanks!

On 2/22/2016 8:13 PM, Valentin Kulichenko wrote:

Hi,

Thanks for the pull request! I will take a look as soon as possible.

-Val

On Mon, Feb 22, 2016 at 9:14 AM, Dood@ODDO  wrote:


Hello all,

I was wondering if anyone can take a look at the PR I submitted for
IGNITE-1144 [1]. It compiles and I think the code is good but the tests I
submitted are failing - specifically, one test: I am using assertThrows()
to make sure that an exception is thrown if affinityRun() is invoked on a
queue that is not collocated. In the tests I basically set up a queue that
has a configuration that invokes setCollocated(false) and then I invoke an
affinityRun() with an "empty" job. For some reason the tests are failing
with an error that the exception wasn't thrown. However, in this case I
actually think that my test is bad and the PR code is good ;-). Can someone
with more Java experience take a quick look?

Thanks!

[1] https://issues.apache.org/jira/browse/IGNITE-1144

[jira] [Created] (IGNITE-2710) Session not unbind from current request after invoke request.getSession().invalidate()

2016-02-22 Thread YuxuanWang (JIRA) 
YuxuanWang created IGNITE-2710:
--

 Summary: Session not unbind from current request after invoke 
request.getSession().invalidate()
 Key: IGNITE-2710
 URL: https://issues.apache.org/jira/browse/IGNITE-2710
 Project: Ignite
  Issue Type: Bug
  Components: cache
Affects Versions: 1.5.0.final
 Environment: java8, tomcat8

Reporter: YuxuanWang


System.out.println(request.getSession().getId());
request.getSession().invalidate();
System.out.println(request.getSession().getId());

getSession() although return the same session after the invalidation.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (IGNITE-2708) Need to validate that SPIs are started only once

2016-02-22 Thread Valentin Kulichenko (JIRA) 
Valentin Kulichenko created IGNITE-2708:
---

 Summary: Need to validate that SPIs are started only once
 Key: IGNITE-2708
 URL: https://issues.apache.org/jira/browse/IGNITE-2708
 Project: Ignite
  Issue Type: Improvement
  Components: general
Reporter: Valentin Kulichenko


User forum discussion: 
http://apache-ignite-users.70518.x6.nabble.com/Ignite-instance-hangs-during-restart-in-client-mode-td3101.html

If one uses the same instance of {{IgniteConfiguration}} more than once, it 
doesn't work because SPIs have lifecycle and can be started only once. 
Currently this causes hang on start which is counterintuitive.

We should add a validation step to {{GridSpiAdapter}} that will check that the 
SPI was never started before. Its {{spiStart()}} method should set some flag 
there or throw exception if it has already been set. All internal SPI 
implementations should be changed to call {{super.spiStart()}} as first 
statement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (IGNITE-2707) SkipStore flag is not overridden for a transaction entry

2016-02-22 Thread Alexey Goncharuk (JIRA) 
Alexey Goncharuk created IGNITE-2707:


 Summary: SkipStore flag is not overridden for a transaction entry
 Key: IGNITE-2707
 URL: https://issues.apache.org/jira/browse/IGNITE-2707
 Project: Ignite
  Issue Type: Bug
  Components: cache
Affects Versions: ignite-1.4
Reporter: Alexey Goncharuk
 Fix For: 1.6


Consider the following code snippet: 
{code}
try (Transaction tx = ignite.transactions().txStart()) {
cache.withSkipStore().get(key);

cache.put(key, value);

tx.commit();
}
{code}

Transaction commit will not trigger store write because {{skipStore}} flag is 
set to {{true}} for the transaction entry and is not overridden on put() 
operation (see IgniteTxLocalAdapter:3780).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

IGNITE-1144

2016-02-22 Thread Dood 

Hello all,

I was wondering if anyone can take a look at the PR I submitted for 
IGNITE-1144 [1]. It compiles and I think the code is good but the tests 
I submitted are failing - specifically, one test: I am using 
assertThrows() to make sure that an exception is thrown if affinityRun() 
is invoked on a queue that is not collocated. In the tests I basically 
set up a queue that has a configuration that invokes 
setCollocated(false) and then I invoke an affinityRun() with an "empty" 
job. For some reason the tests are failing with an error that the 
exception wasn't thrown. However, in this case I actually think that my 
test is bad and the PR code is good ;-). Can someone with more Java 
experience take a quick look?


Thanks!

[1] https://issues.apache.org/jira/browse/IGNITE-1144