[PR] Fix spelling [openoffice]
jbampton opened a new pull request, #218: URL: https://github.com/apache/openoffice/pull/218 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling [openoffice]
Pilot-Pirx merged PR #217: URL: https://github.com/apache/openoffice/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling [openoffice]
jbampton opened a new pull request, #217: URL: https://github.com/apache/openoffice/pull/217 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling [openoffice]
Pilot-Pirx merged PR #216: URL: https://github.com/apache/openoffice/pull/216 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling [openoffice]
jbampton opened a new pull request, #216: URL: https://github.com/apache/openoffice/pull/216 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] docs: fix spelling [openoffice-project]
sebbASF merged PR #14: URL: https://github.com/apache/openoffice-project/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] docs: fix spelling [openoffice-project]
jbampton opened a new pull request, #14: URL: https://github.com/apache/openoffice-project/pull/14 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] blog: fix spelling [openoffice-project]
sebbASF commented on PR #13: URL: https://github.com/apache/openoffice-project/pull/13#issuecomment-2143908436 Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] blog: fix spelling [openoffice-project]
sebbASF merged PR #13: URL: https://github.com/apache/openoffice-project/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] blog: fix spelling [openoffice-project]
jbampton opened a new pull request, #13: URL: https://github.com/apache/openoffice-project/pull/13 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling [openoffice]
Pilot-Pirx merged PR #215: URL: https://github.com/apache/openoffice/pull/215 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix grammar and spelling [openoffice-project]
sebbASF merged PR #12: URL: https://github.com/apache/openoffice-project/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix grammar and spelling [openoffice-project]
jbampton opened a new pull request, #12: URL: https://github.com/apache/openoffice-project/pull/12 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling [openoffice]
jbampton opened a new pull request, #215: URL: https://github.com/apache/openoffice/pull/215 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add new icon set [openoffice]
Pilot-Pirx commented on PR #214: URL: https://github.com/apache/openoffice/pull/214#issuecomment-2131116502  Windows build can be found here: https://www.dropbox.com/scl/fi/n6m4h4ayjejhsm0e4ludl/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_iconset.exe?rlkey=9rbcw1ln2t0un1v41jbid00be=waz0atrb=0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add new icon set [openoffice]
Pilot-Pirx commented on PR #214: URL: https://github.com/apache/openoffice/pull/214#issuecomment-2129948002 Hi Pedro, technically it is good. But there are still a lot of icons missing. I will do a build for Windows soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Add new icon set [openoffice]
Pilot-Pirx commented on PR #214: URL: https://github.com/apache/openoffice/pull/214#issuecomment-2129810868  The complete Remix iconset can be found here: https://remixicon.com/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Add new icon set [openoffice]
Pilot-Pirx opened a new pull request, #214: URL: https://github.com/apache/openoffice/pull/214 This is a proof of concept how to add a new icon set. I am not sure if we should go with "Remix" but that needs to be discussed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Remove Urchin Tracker - a use of google analytics [openoffice-org]
DiGro commented on PR #92: URL: https://github.com/apache/openoffice-org/pull/92#issuecomment-2112377203 @dave2wave feel free to dump it. It is a relic from the past -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] misc: fix spelling [openoffice]
Pilot-Pirx merged PR #213: URL: https://github.com/apache/openoffice/pull/213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Remove Urchin Tracker - a use of google analytics [openoffice-org]
dave2wave commented on PR #92: URL: https://github.com/apache/openoffice-org/pull/92#issuecomment-2111040621 @DiGro Does this very old page have any use? http://www.openoffice.org/nl/thankyoupage/. It has a tracker on it and seems to exist from Sun -> Oracle times. I would like to rip it out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Remove Urchin Tracker - a use of google analytics [openoffice-org]
dave2wave opened a new pull request, #92: URL: https://github.com/apache/openoffice-org/pull/92 Accumulating changes here first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] misc: fix spelling [openoffice]
jbampton opened a new pull request, #213: URL: https://github.com/apache/openoffice/pull/213 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #212: URL: https://github.com/apache/openoffice/pull/212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in code comments [openoffice]
jbampton opened a new pull request, #212: URL: https://github.com/apache/openoffice/pull/212 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #211: URL: https://github.com/apache/openoffice/pull/211 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in code comments [openoffice]
jbampton opened a new pull request, #211: URL: https://github.com/apache/openoffice/pull/211 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Blog post about development on trunk branch [openoffice-project]
ardovm merged PR #11: URL: https://github.com/apache/openoffice-project/pull/11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
ardovm merged PR #200: URL: https://github.com/apache/openoffice/pull/200 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #210: URL: https://github.com/apache/openoffice/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Link pthread library when using OpenSSL on Linux [openoffice]
ardovm merged PR #206: URL: https://github.com/apache/openoffice/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
pedlino commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-2030108118 Windows build tested. Bug is fixed in trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in code comments [openoffice]
jbampton opened a new pull request, #210: URL: https://github.com/apache/openoffice/pull/210 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in comments [openoffice]
Pilot-Pirx merged PR #209: URL: https://github.com/apache/openoffice/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in comments [openoffice]
jbampton opened a new pull request, #209: URL: https://github.com/apache/openoffice/pull/209 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments [openoffice]
Pilot-Pirx commented on PR #208: URL: https://github.com/apache/openoffice/pull/208#issuecomment-2029737332 Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #208: URL: https://github.com/apache/openoffice/pull/208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in code comments [openoffice]
jbampton opened a new pull request, #208: URL: https://github.com/apache/openoffice/pull/208 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix spelling in code comments and descriptions only [openoffice]
Pilot-Pirx merged PR #207: URL: https://github.com/apache/openoffice/pull/207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix spelling in code comments and descriptions only [openoffice]
jbampton opened a new pull request, #207: URL: https://github.com/apache/openoffice/pull/207 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Blog post about development on trunk branch [openoffice-project]
ardovm opened a new pull request, #11: URL: https://github.com/apache/openoffice-project/pull/11 Proposal for blog post about our latest development on the trunk branch. **Note**: The post is dated 2 April. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Pilot-Pirx commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-2028644068 It did build fine and I have no crashes anymore. The behavior now is logical for me. Maybe this is something we would want to backport for AOO41X? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Link pthread library when using OpenSSL on Linux [openoffice]
DamjanJovanovic commented on PR #206: URL: https://github.com/apache/openoffice/pull/206#issuecomment-2027757168 Oh right, on Linux pthreads is in a separate library, and internal OpenSSL is linked statically, so the binary linking to OpenSSL has to link to pthreads as well. Forgot about that case. Sorry. Your patch looks good. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
ardovm commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-2027708940 The logic had to be a little more complex than that. If there is a visible slides after the selection, then it has to be selected. Otherwise, we have to search for a visible slide backward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Allow compilation of AOO41X under Ubuntu Jammy (GCC 11) [openoffice]
ardovm commented on PR #198: URL: https://github.com/apache/openoffice/pull/198#issuecomment-1987694519 It was better to start from trunk. Trunk now builds on Jammy and we will be able to cherry-pick the relevant commits into AOO41X. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Allow compilation of AOO41X under Ubuntu Jammy (GCC 11) [openoffice]
ardovm closed pull request #198: Allow compilation of AOO41X under Ubuntu Jammy (GCC 11) URL: https://github.com/apache/openoffice/pull/198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx merged PR #199: URL: https://github.com/apache/openoffice/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] docs: fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #205: URL: https://github.com/apache/openoffice/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Update boost - Part 1 [openoffice]
Pilot-Pirx commented on PR #202: URL: https://github.com/apache/openoffice/pull/202#issuecomment-1959880734 **Let boost promote to double the sinc_pi() operation.** Modern processors should handle this without any trouble. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Update boost - Part 1 [openoffice]
Pilot-Pirx commented on PR #202: URL: https://github.com/apache/openoffice/pull/202#issuecomment-1959879198 Original comments from Pedro: Minor cleanup to internal boost header packaging We normally don't install all the headers available in boost. There is an interesting set of functionalities like multiprecision and odeint that while we are not using, but would be interesting to have available. This is done to ease future boost updates but also in the hopes of making it possible to use this functionality in a near future. No functional change expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] docs: fix spelling in code comments [openoffice]
jbampton opened a new pull request, #205: URL: https://github.com/apache/openoffice/pull/205 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] docs: fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #204: URL: https://github.com/apache/openoffice/pull/204 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] docs: fix spelling in code comments [openoffice]
jbampton opened a new pull request, #204: URL: https://github.com/apache/openoffice/pull/204 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] docs: fix spelling in code comments [openoffice]
Pilot-Pirx merged PR #203: URL: https://github.com/apache/openoffice/pull/203 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] docs: fix spelling in code comments [openoffice]
Pilot-Pirx commented on PR #203: URL: https://github.com/apache/openoffice/pull/203#issuecomment-1957180180 Looks good to me! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] docs: fix spelling in code comments [openoffice]
jbampton opened a new pull request, #203: URL: https://github.com/apache/openoffice/pull/203 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Update base.html [openoffice-project]
dave2wave merged PR #10: URL: https://github.com/apache/openoffice-project/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Update boost - Part 1 [openoffice]
Pilot-Pirx opened a new pull request, #202: URL: https://github.com/apache/openoffice/pull/202 This is a remake of the first part of Pedro Giffuni's original PR: https://github.com/apache/openoffice/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Remove code for unused bmpmaker [openoffice]
Pilot-Pirx merged PR #201: URL: https://github.com/apache/openoffice/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Remove code for unused bmpmaker [openoffice]
Pilot-Pirx commented on PR #201: URL: https://github.com/apache/openoffice/pull/201#issuecomment-1937060815 My Windows build was successful. I would like to merge this PR to trunk now and let the Linux buildbot do its job. ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Remove code for unused bmpmaker [openoffice]
Pilot-Pirx commented on PR #201: URL: https://github.com/apache/openoffice/pull/201#issuecomment-1936993392 And I like the idea of preserving useful code... Could we keep it in some sort of "internal attic" maybe in https://svn.apache.org/repos/asf/openoffice/devtools/ ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Remove code for unused bmpmaker [openoffice]
Pilot-Pirx opened a new pull request, #201: URL: https://github.com/apache/openoffice/pull/201 See: https://bz.apache.org/ooo/show_bug.cgi?id=83198 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Pilot-Pirx commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-1932700934 I updated my build now with the above changes, but unfortunately it still crashes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
ardovm commented on PR #199: URL: https://github.com/apache/openoffice/pull/199#issuecomment-1930679444 This PR looks good to me. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx commented on PR #199: URL: https://github.com/apache/openoffice/pull/199#issuecomment-1930610843 > Did you try signing and verifying signatures with this build? That should be a good check that everything works. I could successfully sign a document with my recent build. [Signed document.odt](https://github.com/apache/openoffice/files/14185138/Signed.document.odt) An older (signed) document can be opened without warning and the signature can be validated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
ardovm commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-1930585461 > After some testing I have found a problem: I get a crash when I hide the last slide, select it and start a presentation (by pressing F5). This does not happen when there is only one slide. It may crash due to those `>`. @Pilot-Pirx if you can: 1. reproduce the problem on your build, 2. change `>` into `>=` and rebuild, 3. demonstrate on your own computer that it does not crash any more, then you are good to merge with the above edit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] first implementation of datedif [openoffice]
DamjanJovanovic commented on PR #178: URL: https://github.com/apache/openoffice/pull/178#issuecomment-1930389666 Great work, thank you! Can you also please add a description of this function to our help system, probably under main/helpcontent2/source/text/scalc/01/? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] first implementation of datedif [openoffice]
oooforum commented on PR #178: URL: https://github.com/apache/openoffice/pull/178#issuecomment-1929618537 Thanks for this patch. Can it be pushed for the next build? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Update boost to version 1.64 + minor enhancements [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1928222573 Unfortunately GitHub does not seem to allow to re-open a PR once it was merged... If you don't mind (and my time permits) I would like to do "remakes" of your original PR. I think the sinc_pi change can be merged quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx commented on PR #199: URL: https://github.com/apache/openoffice/pull/199#issuecomment-1927863520 Please find a Windows build here: https://www.dropbox.com/scl/fi/8kx1kwcet1ldnb5ckpiax/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_nss.exe?rlkey=o4qh04sd805weh62h8iycdcsd=0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Pilot-Pirx commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-1927852752 After some testing I have found a problem: I get a crash when I hide the last slide, select it and start a presentation (by pressing F5). This does not happen when there is only one slide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Possible fix for issue 60859 [openoffice]
Pilot-Pirx commented on PR #200: URL: https://github.com/apache/openoffice/pull/200#issuecomment-1925915743 Please find a Windows build here: https://www.dropbox.com/scl/fi/ph0fogxba7wkbvxlfsr96/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_Slide.exe?rlkey=vaxkxtaq9ix6vqms9q5d1uf15=0 I cannot comment on the code itself but it does seem to fix the issue. If first slide is hidden, presentation now starts with the second slide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx commented on code in PR #199: URL: https://github.com/apache/openoffice/pull/199#discussion_r1477352624 ## main/libxmlsec/xmlsec1-configure.patch: ## @@ -759,7 +759,7 @@ XMLSEC_OPENSSL_ALIBS= libeay32.lib wsock32.lib kernel32.lib user32.lib gdi32.lib -XMLSEC_NSS_SOLIBS = smime3.lib ssl3.lib nss3.lib libnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib -+XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib nspr4.lib kernel32.lib user32.lib gdi32.lib ++XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib licnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib Review Comment: Fixed! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx commented on code in PR #199: URL: https://github.com/apache/openoffice/pull/199#discussion_r1477351327 ## main/libxmlsec/xmlsec1-configure.patch: ## @@ -759,7 +759,7 @@ XMLSEC_OPENSSL_ALIBS= libeay32.lib wsock32.lib kernel32.lib user32.lib gdi32.lib -XMLSEC_NSS_SOLIBS = smime3.lib ssl3.lib nss3.lib libnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib -+XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib nspr4.lib kernel32.lib user32.lib gdi32.lib ++XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib licnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib Review Comment: That's definitely a typo, but it did build anyway... ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Build nss with OS_TARGET=WINNT [openoffice]
ardovm commented on code in PR #199: URL: https://github.com/apache/openoffice/pull/199#discussion_r1477351087 ## main/libxmlsec/xmlsec1-configure.patch: ## @@ -759,7 +759,7 @@ XMLSEC_OPENSSL_ALIBS= libeay32.lib wsock32.lib kernel32.lib user32.lib gdi32.lib -XMLSEC_NSS_SOLIBS = smime3.lib ssl3.lib nss3.lib libnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib -+XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib nspr4.lib kernel32.lib user32.lib gdi32.lib ++XMLSEC_NSS_SOLIBS = smime3.lib nss3.lib licnspr4.lib libplds4.lib libplc4.lib kernel32.lib user32.lib gdi32.lib Review Comment: This li*c*nspr4.lib looks like a typo...? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Pilot-Pirx commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1468106347
##
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController(
Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) )
nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
This is a draft now until the code was successfully compiled by someone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
Pilot-Pirx commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1466304570
##
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController(
Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) )
nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
If this PR was never tested, then you should convert it to a "draft".
This way it cannot be merged accidentally and we can continue to work on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
oooforum commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1464537713
##
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController(
Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) )
nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
I don't know because I have no idea what maSlideVisible.size is supposed to
return.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Fix for issue 60859 [openoffice]
ardovm commented on code in PR #200:
URL: https://github.com/apache/openoffice/pull/200#discussion_r1463061431
##
main/sd/source/ui/slideshow/slideshowimpl.cxx:
##
@@ -236,6 +236,17 @@ AnimationSlideController::AnimationSlideController(
Reference< XIndexAccess > xS
mnSlideCount = xSlides->getCount();
}
+void AnimationSlideController::setStartSlideNumber( sal_Int32 nSlideNumber )
+{
+ while( ( !maSlideVisible[nSlideNumber] )
+ || ( nSlideNumber > maSlideVisible.size() ) )
nSlideNumber++;
+
+ if(nSlideNumber > maSlideVisible.size())
+ mnStartSlideNumber = 0;
Review Comment:
Should all these checks: `(nSlideNumber > maSlideVisible.size())` be `>=`
instead of `>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org
For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Fix for issue 60859 [openoffice]
oooforum opened a new pull request, #200: URL: https://github.com/apache/openoffice/pull/200 If 1st slide is hidden and selected, show presentation does start after this. Thanks to iammisc for this patch https://bz.apache.org/ooo/show_bug.cgi?id=60859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Update boost to version 1.64 + minor enhancements [openoffice]
pgiffuni commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1905206856 I wish the 1.55 changes had been merged separately. The sinc_pi change was useful despite the version. In any case it appears that the boost build per-se didn't fail but that the built left missing headers unistalled that are required by the linux port. I can't really follow up at this time as I don't have a linux box available to test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Build nss with OS_TARGET=WINNT [openoffice]
Pilot-Pirx opened a new pull request, #199: URL: https://github.com/apache/openoffice/pull/199 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Allow compilation of AOO41X under Ubuntu Jammy (GCC 11) [openoffice]
ardovm opened a new pull request, #198: URL: https://github.com/apache/openoffice/pull/198 The AOO41X branch does not seem to build on Ubuntu 22.04 "Jammy". The purpose of this pull request is to gather and review the modifications that make AOO41X build again. The edits mostly consist of: 1. disabling -Werror compilation flags, because newer GCC versions find more warning than previous ones; 2. fixing compilation where necessary as per [this thread of the dev@ mailing list](https://lists.apache.org/thread/gbfm2djykqk9ksqw22vobklf6d4lm0ly) The edit to the boost module was cherry-picked from trunk. This branch shall be tested on Ubuntu Jammy, but also on other platforms, in order to make sure that we are not breaking anything. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Revert "Enhance a bit our current boost usage" [openoffice]
Pilot-Pirx commented on PR #197: URL: https://github.com/apache/openoffice/pull/197#issuecomment-1891101395 This is already reverted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Revert "Enhance a bit our current boost usage" [openoffice]
Pilot-Pirx closed pull request #197: Revert "Enhance a bit our current boost usage" URL: https://github.com/apache/openoffice/pull/197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1891100904 Not being a developer I will now step back and let others take over... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1891100756 Buildbot does not build: 1 module(s): sal need(s) to be rebuilt Reason(s): ERROR: error 65280 occurred while making /home/buildslave/slave/openoffice-linux64-nightly/build/main/sal/rtl/source When you have fixed the errors in that module you can resume the build by running: build --from sal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] Revert "Enhance a bit our current boost usage" [openoffice]
Pilot-Pirx opened a new pull request, #197: URL: https://github.com/apache/openoffice/pull/197 Reverts apache/openoffice#194 Buildbot does not build: 1 module(s): sal need(s) to be rebuilt Reason(s): ERROR: error 65280 occurred while making /home/buildslave/slave/openoffice-linux64-nightly/build/main/sal/rtl/source When you have fixed the errors in that module you can resume the build by running: build --from sal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx merged PR #194: URL: https://github.com/apache/openoffice/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1891036420 Yes, I can "Squash and merge" it to trunk. In fact I will do it now. If something goes wrong it is just one commit to revert... If the Linux buildbot is successful, I will cherry-pick it to AOO42X tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
pgiffuni commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1891020126 Can you cheerypick the 1.55 updates and squash the 1.64 update in one commit? I did try to make it easier for you guys to revert in case something went really wrong although it seems it won't be the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1890902258 Thanks for the info! I can merge it, although it still is a "shot in the dark" for me. For Linux I can see the results from our buildbot (trunk): https://nightlies.apache.org/openoffice/install/linux64/?C=M;O=D If successful, I would cherry-pick for AOO42X. @jimjag What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
pgiffuni commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1890822397 > > Since it builds on BSD how high is the probability that it also builds on macOS? Very high .. FreeBSD and macOS share most of libc and FreeBSD adopted natively LLVM as well, but there are sufficient differences that one can't be 100% sure. The one thing that gives us relative confidence is that upstream tested all the OS/compiler combinations we are [interested](https://www.boost.org/users/history/version_1_64_0.html) in: Linux: - Clang: 3.0, 3.8.1, 3.9.1 - Clang, C++11: 3.0, 3.1, 3.2, 3.3, 3.4, 3.8.1, 3.9.1 - Clang, C++14: 3.5, 3.6, 3.7.1, 3.8.1, 3.9.1 - Clang, C++1z: 3.9.1 - GCC: 4.4.7, 4.5.3, 4.6.3, 4.7.2, 6.2.0 - GCC, C++11: 4.4.7, 4.7.2, 4.7.3, 4.8.5, 4.9.4, 6.2.0 - GCC, C++14: 5.4.1, 6.2.0, 6.3.0 - GCC, C++1z: 6.2.0 - Intel: 16.0, 17.0 - Intel, C++11: 16.0, 17.0 - Intel, C++14: 16.0, 17.0 OS X: - Apple Clang: 7.0.2 - Apple Clang, C++11: 7.0.2 Windows: - GCC, C++03, mingw: 3.4.5, 4.1.2, 4.2.4, 4.3.3, 4.4.0 - GCC, C++11, mingw: 4.6.4, 4.7.3, 4.8.1 - GCC, C++14, mingw: 4.9.3, 5.1.0, 5.2.0, 5.3.0, 6.1.0 - Visual C++: 7.1, 8.0, 9.0, 10.0, 11.0, 12.0, 14.0 FreeBSD: - Clang: 3.8 - Clang, C++11: 3.8 - Clang, C++14: 3.8 - Clang, C++1z: 3.8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1890775948 Hi Pedro, I am highly motivated to merge this PR but I didn't want to do it without being sure that it builds on macOS and Linux. We definitely want to have this in AOO 4.2.0 Developer Release 5 (hopefully end of the month). Since it builds on BSD how high is the probability that it also builds on macOS? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
pgiffuni commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1890767770 @Pilot-Pirx Thanks so much for finishing the bits for Windows. Since it's getting so long to merge(!), let me provide some motivation: We currently make [limited use](https://wiki.openoffice.org/wiki/Boost) of boost, so the boost update will provide some fixes and performance enhancements, but perhaps more important is that it provides functionality that modern languages would regularly provide and that are currently unavailable in our older C++ environment. AOO is about 80% C++ code and it's currently stuck in an older version of that language supported by a MSVC 2008. Keeping a too old version of boost will make it increasingly difficult to compile AOO on newer compilers; putting up a too recent version of boost will make it imposible to build AOO with the older compilers. The 1.64 version from 2017 seems to be in the right place for all the supported platforms/compilers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1879941167 @jimjag Can you please try to build on macOS/Linux? I think this would be nice for AOO 4.2.0-Dev5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Enhance a bit our current boost usage [openoffice]
Pilot-Pirx commented on PR #194: URL: https://github.com/apache/openoffice/pull/194#issuecomment-1879940017 Builds on Windows now: https://www.dropbox.com/scl/fi/5ooqaxvdec34l30v99xmo/Apache_OpenOffice_4.5.0_Win_x86_install_en-US_boost.exe?rlkey=k5r4bwmxrvzlzraypu42jod2c=0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
[PR] CVE in MarkDown format [openoffice-org]
ardovm opened a new pull request, #91: URL: https://github.com/apache/openoffice-org/pull/91 This is a proposal for a template that allows to prepare CVE pages in MarkDown format. The purpose is making our life easier when publishing new security bulletins. As an example, the data for CVE-2012-5639 is converted to the new format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Removed whitespace between tags and other superfluous whitespace (branch Latest) [openoffice]
Pilot-Pirx commented on PR #74: URL: https://github.com/apache/openoffice/pull/74#issuecomment-1874009640 I think I have done the major part in cleaning up the Help files. There are certainly a lot of small errors left but that can be fixed with normal maintenance. The resulting en-US.sdf found here should be cleaner now: https://nightlies.apache.org/openoffice/install/linsnap-42x/?C=M;O=D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
Re: [PR] Removed whitespace between tags and other superfluous whitespace (branch Latest) [openoffice]
Pilot-Pirx closed pull request #74: Removed whitespace between tags and other superfluous whitespace (branch Latest) URL: https://github.com/apache/openoffice/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@openoffice.apache.org For additional commands, e-mail: dev-h...@openoffice.apache.org
