Re: [Question] LimitedInputStream license issue in Spark source.
Thank you. Here is the PR to fix that. https://github.com/apache/spark/pull/40249 [SPARK-42649][CORE] Remove the standard Apache License header from the top of third-party source files Dongjoon. On Wed, Mar 1, 2023 at 11:53 PM wrote: > Hi, > > See https://www.apache.org/legal/src-headers.html#3party - "Do not add > the standard Apache License header to the top of third-party source files.” > and "Minor modifications/additions to third-party source files should > typically be licensed under the same terms as the rest of the third-party > source for convenience.” > > Kind Regards, > Justin
Re: [Question] LimitedInputStream license issue in Spark source.
Hi, See https://www.apache.org/legal/src-headers.html#3party - "Do not add the standard Apache License header to the top of third-party source files.” and "Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience.” Kind Regards, Justin - To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
Re: [Question] LimitedInputStream license issue in Spark source.
Right, it contains ALv2 licensed code attributed to two authors - some is from Guava, some is from Apache Spark contributors. I thought this is how we should handle this. It's not feasible to go line by line and say what came from where. On Wed, Mar 1, 2023 at 1:33 AM Dongjoon Hyun wrote: > May I ask why do you thinkn in that way? Could you elaborate a little more > about your concerns if you mean it from a legal perspective? > > > The ASF header states "Licensed to the Apache Software Foundation (ASF) > under one or more contributor license agreements.” > > I ‘m not sure this is true with this file even though both Spark and > this file are under the ALv2 license. > > On Tue, Feb 28, 2023 at 11:26 PM Justin Mclean > wrote: > >> Hi, >> >> The issue is not the original header it is the addition of the ASF >> header. The ASF header states "Licensed to the Apache Software Foundation >> (ASF) under one or more contributor license agreements.” I ‘m not sure this >> is true with this file even though both Spark and this file are under the >> ALv2 license. >> >> Kind Regards, >> Justin > >
Re: [Question] LimitedInputStream license issue in Spark source.
May I ask why do you thinkn in that way? Could you elaborate a little more about your concerns if you mean it from a legal perspective? > The ASF header states "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.” > I ‘m not sure this is true with this file even though both Spark and this file are under the ALv2 license. On Tue, Feb 28, 2023 at 11:26 PM Justin Mclean wrote: > Hi, > > The issue is not the original header it is the addition of the ASF header. > The ASF header states "Licensed to the Apache Software Foundation (ASF) > under one or more contributor license agreements.” I ‘m not sure this is > true with this file even though both Spark and this file are under the ALv2 > license. > > Kind Regards, > Justin
Re: [Question] LimitedInputStream license issue in Spark source.
Hi, The issue is not the original header it is the addition of the ASF header. The ASF header states "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements.” I ‘m not sure this is true with this file even though both Spark and this file are under the ALv2 license. Kind Regards, Justin - To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
Re: [Question] LimitedInputStream license issue in Spark source.
+CC @Justin Mclean, and @Willem Jiang since you left the concerns It looks like Spark may have incorrectly added that header. You could ask > them why it was added perhaps or just leave it as is. > Kind Regards, > Justin > I have the same question as Justin asked, do we need to add the ASF License > header to this file[1]? [1] > ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java Willem Jiang Thanks, Cheng Pan On Mar 1, 2023 at 15:04:52, Dongjoon Hyun wrote: > Since both license headers are Apache License 2.0, we don't see any issue > there. They are compatible. > > The first line of the second license header means the file was copied from > Google Guava project originally. > > Apache Spark community keeps the original header because it has > `Authorship` part, `Copyright (C) 2007 The Guava Authors`. > > /* > * Based on LimitedInputStream.java from Google Guava > * > * Copyright (C) 2007 The Guava Authors > * > *Licensed under the Apache License, Version 2.0 (the "License"); > *you may not use this file except in compliance with the License. > *You may obtain a copy of the License at > * > *http://www.apache.org/licenses/LICENSE-2.0 > * > *Unless required by applicable law or agreed to in writing, software > *distributed under the License is distributed on an "AS IS" BASIS, > *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or > implied. > *See the License for the specific language governing permissions and > *limitations under the License. > */ > > Dongjoon. > > > > On Tue, Feb 28, 2023 at 10:27 PM Ethan Feng wrote: > >> Hi developers, >> I have been running a release in project celeborn(incubating) >> recently and the incubator PPMCs have arguments[2] about the headers >> in source file[1] that we copied from the Spark source. >> We don't understand why the source file[1] has two headers with >> different copyright disclaimers. Could you explain why the source >> file[1] needs two headers? >> >> Regards, >> Ethan Feng >> >> - >> 1. org/apache/spark/network/util/LimitedInputStream.java >> 2. https://lists.apache.org/thread/q8hchs4n2twhjl0qf3rn0ln0hyrvrnnp >> >> - >> To unsubscribe e-mail: dev-unsubscr...@spark.apache.org >> >>
Re: [Question] LimitedInputStream license issue in Spark source.
Since both license headers are Apache License 2.0, we don't see any issue there. They are compatible. The first line of the second license header means the file was copied from Google Guava project originally. Apache Spark community keeps the original header because it has `Authorship` part, `Copyright (C) 2007 The Guava Authors`. /* * Based on LimitedInputStream.java from Google Guava * * Copyright (C) 2007 The Guava Authors * *Licensed under the Apache License, Version 2.0 (the "License"); *you may not use this file except in compliance with the License. *You may obtain a copy of the License at * *http://www.apache.org/licenses/LICENSE-2.0 * *Unless required by applicable law or agreed to in writing, software *distributed under the License is distributed on an "AS IS" BASIS, *WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. *See the License for the specific language governing permissions and *limitations under the License. */ Dongjoon. On Tue, Feb 28, 2023 at 10:27 PM Ethan Feng wrote: > Hi developers, > I have been running a release in project celeborn(incubating) > recently and the incubator PPMCs have arguments[2] about the headers > in source file[1] that we copied from the Spark source. > We don't understand why the source file[1] has two headers with > different copyright disclaimers. Could you explain why the source > file[1] needs two headers? > > Regards, > Ethan Feng > > - > 1. org/apache/spark/network/util/LimitedInputStream.java > 2. https://lists.apache.org/thread/q8hchs4n2twhjl0qf3rn0ln0hyrvrnnp > > - > To unsubscribe e-mail: dev-unsubscr...@spark.apache.org > >
[Question] LimitedInputStream license issue in Spark source.
Hi developers, I have been running a release in project celeborn(incubating) recently and the incubator PPMCs have arguments[2] about the headers in source file[1] that we copied from the Spark source. We don't understand why the source file[1] has two headers with different copyright disclaimers. Could you explain why the source file[1] needs two headers? Regards, Ethan Feng - 1. org/apache/spark/network/util/LimitedInputStream.java 2. https://lists.apache.org/thread/q8hchs4n2twhjl0qf3rn0ln0hyrvrnnp - To unsubscribe e-mail: dev-unsubscr...@spark.apache.org
