Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
Here is a list of all Milestones https://cwiki.apache.org/confluence/display/WW/Migration+Guide#MigrationGuide-VersionNotes7.x śr., 28 lut 2024 o 09:15 Greg Huber napisał(a): > > selecting "Maven > Disable Workspace Resolution" > > I need eclipse to build the target/classes folder otherwise I cannot run > tomcat. > > Hopefully this will be fixed once the *-jakarta.jars are released as they are > not snapshot? > > > > On 28/02/2024 00:01, James Dyer wrote: > > I agree the best long-term solution to this problem is to move the > > "*-jakarta" subprojects so they are not children of the parent pom. That > > way, when you import your projects into your IDE, these projects will not > > be automatically imported with everything else. Having them in a separate > > repo completely isolates them and is the most complete solution of all. > > With the projects isolated, the IDE will get the artifacts from the maven > > repository and not look for the missing code in these projects. > > > > In Eclipse anyhow, you can work around the issue immediately by right > > clicking on the projects having the errors and selecting "Maven > Disable > > Workspace Resolution". Then you can run the unit tests within Eclipse. > > > > On 2024/02/25 10:57:34 Greg Huber wrote: > >> Also building in eclipse I get these strange errors > >> > >> Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > >> > >> Missing artifact > >> org.apache.struts:struts2-velocity-tools-jsp-jakarta:jar:7.0.0-M3 > >> > >> Missing artifact > >> org.apache.struts:struts2-velocity-tools-view-jakarta:jar:7.0.0-M3 > >> > >> [ERROR] Failed to execute goal on project [36mstruts2-core [m: > >> [1;31mCould not resolve dependencies for project > >> org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts > >> could not be resolved: > >> org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but > >> unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > >> was not found in https://repo.maven.apache.org/maven2 during a previous > >> attempt. This failure was cached in the local repository and resolution > >> is not reattempted until the update interval of central has elapsed or > >> updates are forced [m-> [1m[Help 1] [m > >> > >> Caused by: org.apache.maven.lifecycle.LifecycleExecutionException: > >> Failed to execute goal on project [36mstruts2-core [m: [1;31mCould not > >> resolve dependencies for project > >> org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts > >> could not be resolved: > >> org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but > >> unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > >> was not found in https://repo.maven.apache.org/maven2 during a previous > >> attempt. This failure was cached in the local repository and resolution > >> is not reattempted until the update interval of central has elapsed or > >> updates are forced > >> > >> I have deleted my ~.m2 and it makes no difference. > >> > >> > >> On 24/02/2024 08:46, Lukasz Lenart wrote: > >>> Hello, > >>> > >>> This is a third milestone of Struts 7.x series, which is based on > >>> JakartaEE 6. Please take the time and test the bits - any help is > >>> appreciated. Please report any problems you will spot. > >>> > >>> Here are the changes from the previous version: > >>> https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 > >>> > >>> Staging Maven repo > >>> https://repository.apache.org/content/groups/staging/ > >>> > >>> * please read our guideline how to setup your Maven build to include > >>> the Staging repository > >>> https://struts.apache.org/builds.html#test-builds > >>> > >>> Standalone artifacts > >>> https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ > >>> > >>> Release notes > >>> https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 > >>> > >>> > >>> Have fun! > >>> Łukasz > >>> > >>> - > >>> To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org > >>> For additional commands, e-mail:dev-h...@struts.apache.org > >>> > > - > > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > > For additional commands, e-mail: dev-h...@struts.apache.org > > > > - > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
selecting "Maven > Disable Workspace Resolution" I need eclipse to build the target/classes folder otherwise I cannot run tomcat. Hopefully this will be fixed once the *-jakarta.jars are released as they are not snapshot? On 28/02/2024 00:01, James Dyer wrote: I agree the best long-term solution to this problem is to move the "*-jakarta" subprojects so they are not children of the parent pom. That way, when you import your projects into your IDE, these projects will not be automatically imported with everything else. Having them in a separate repo completely isolates them and is the most complete solution of all. With the projects isolated, the IDE will get the artifacts from the maven repository and not look for the missing code in these projects. In Eclipse anyhow, you can work around the issue immediately by right clicking on the projects having the errors and selecting "Maven > Disable Workspace Resolution". Then you can run the unit tests within Eclipse. On 2024/02/25 10:57:34 Greg Huber wrote: Also building in eclipse I get these strange errors Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 Missing artifact org.apache.struts:struts2-velocity-tools-jsp-jakarta:jar:7.0.0-M3 Missing artifact org.apache.struts:struts2-velocity-tools-view-jakarta:jar:7.0.0-M3 [ERROR] Failed to execute goal on project [36mstruts2-core[m: [1;31mCould not resolve dependencies for project org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts could not be resolved: org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced[m-> [1m[Help 1][m Caused by: org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project [36mstruts2-core[m: [1;31mCould not resolve dependencies for project org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts could not be resolved: org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced I have deleted my ~.m2 and it makes no difference. On 24/02/2024 08:46, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time and test the bits - any help is appreciated. Please report any problems you will spot. Here are the changes from the previous version: https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 Staging Maven repo https://repository.apache.org/content/groups/staging/ * please read our guideline how to setup your Maven build to include the Staging repository https://struts.apache.org/builds.html#test-builds Standalone artifacts https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ Release notes https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 Have fun! Łukasz - To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org For additional commands, e-mail:dev-h...@struts.apache.org - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
Just as a clarification, Struts 7.x is targeting Jakarta EE 9/10. On 2024/02/24 08:46:41 Lukasz Lenart wrote: > Hello, > > This is a third milestone of Struts 7.x series, which is based on > JakartaEE 6. Please take the time and test the bits - any help is > appreciated. Please report any problems you will spot. > > Here are the changes from the previous version: > https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 > > Staging Maven repo > https://repository.apache.org/content/groups/staging/ > > * please read our guideline how to setup your Maven build to include > the Staging repository > https://struts.apache.org/builds.html#test-builds > > Standalone artifacts > https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ > > Release notes > https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 > > > Have fun! > Łukasz > > - > To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org > For additional commands, e-mail: dev-h...@struts.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
I agree the best long-term solution to this problem is to move the "*-jakarta" subprojects so they are not children of the parent pom. That way, when you import your projects into your IDE, these projects will not be automatically imported with everything else. Having them in a separate repo completely isolates them and is the most complete solution of all. With the projects isolated, the IDE will get the artifacts from the maven repository and not look for the missing code in these projects. In Eclipse anyhow, you can work around the issue immediately by right clicking on the projects having the errors and selecting "Maven > Disable Workspace Resolution". Then you can run the unit tests within Eclipse. On 2024/02/25 10:57:34 Greg Huber wrote: > Also building in eclipse I get these strange errors > > Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > > Missing artifact > org.apache.struts:struts2-velocity-tools-jsp-jakarta:jar:7.0.0-M3 > > Missing artifact > org.apache.struts:struts2-velocity-tools-view-jakarta:jar:7.0.0-M3 > > [ERROR] Failed to execute goal on project [36mstruts2-core[m: > [1;31mCould not resolve dependencies for project > org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts > could not be resolved: > org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but > unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > was not found in https://repo.maven.apache.org/maven2 during a previous > attempt. This failure was cached in the local repository and resolution > is not reattempted until the update interval of central has elapsed or > updates are forced[m-> [1m[Help 1][m > > Caused by: org.apache.maven.lifecycle.LifecycleExecutionException: > Failed to execute goal on project [36mstruts2-core[m: [1;31mCould not > resolve dependencies for project > org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts > could not be resolved: > org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but > unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 > was not found in https://repo.maven.apache.org/maven2 during a previous > attempt. This failure was cached in the local repository and resolution > is not reattempted until the update interval of central has elapsed or > updates are forced > > I have deleted my ~.m2 and it makes no difference. > > > On 24/02/2024 08:46, Lukasz Lenart wrote: > > Hello, > > > > This is a third milestone of Struts 7.x series, which is based on > > JakartaEE 6. Please take the time and test the bits - any help is > > appreciated. Please report any problems you will spot. > > > > Here are the changes from the previous version: > > https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 > > > > Staging Maven repo > > https://repository.apache.org/content/groups/staging/ > > > > * please read our guideline how to setup your Maven build to include > > the Staging repository > >https://struts.apache.org/builds.html#test-builds > > > > Standalone artifacts > > https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ > > > > Release notes > > https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 > > > > > > Have fun! > > Łukasz > > > > - > > To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org > > For additional commands, e-mail:dev-h...@struts.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
This fixes it, seems it needs the getOriginalName() rather than getName()?
org.apache.struts2.dispatcher.multipart.AbstractMultiPartRequest
original
public String[] getFileNames(String fieldName) {
return uploadedFiles.getOrDefault(fieldName,
Collections.emptyList()).stream()
.map(file -> getCanonicalName(file.getName()))
.toArray(String[]::new);
}
fixed
public String[] getFileNames(String fieldName) {
return uploadedFiles.getOrDefault(fieldName,
Collections.emptyList()).stream()
.map(file -> getCanonicalName(file.getOriginalName()))
.toArray(String[]::new);
}
This .map stuff is not good for debugging.
On 26/02/2024 06:26, Łukasz Lenart wrote:
niedz., 25 lut 2024 o 09:42 Greg Huber napisał(a):
Testing the file upload and it now does not work.
I get an error where its using the wrong file name ie
upload5549a568d9794ef5b654da83d07961350045.tmp rather than the
actual file name.
Which file upload do you use? Old FileuploadInterceptor or
ActionFileuploadInterceptor?
Do you mean the error message is wrong and it displays the wrong file name?
I put back the mods I did, and it still does not work.
Were there any other changes?
Herehttps://github.com/apache/struts/pull/873
Regards
Łukasz
-
To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org
For additional commands, e-mail:dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
pon., 26 lut 2024 o 08:50 Greg Huber napisał(a):
>
> Why does it work then for the other artifacts?
>
>
> org.apache.struts
> struts2-freemarker-jakarta
> ${project.version}
>
>
> org.apache.struts
> struts2-core
> ${project.version}
>
>
> org.apache.struts
> struts2-spring-plugin
> ${project.version}
>
>
> Seems to be the newer jars, are the maven details correct?
As far as I understand it's correct, it's a problem with how IDE
resolves dependencies which is a bit different than Maven does this.
That's why I wanted to move the Jakarta transformed artifacts out of
the main project and keep them in a separate repository as they do not
change too often and can be then threatened by IDE and Maven in the
same way.
The link to the PR is the only solution I found to launch tests from
IDE - make the transformed artifacts an external dependency.
Regards
Lukasz
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
The old version. The pom change to snapshot worked so I will have a look now. On 26/02/2024 06:26, Łukasz Lenart wrote: niedz., 25 lut 2024 o 09:42 Greg Huber napisał(a): Testing the file upload and it now does not work. I get an error where its using the wrong file name ie upload5549a568d9794ef5b654da83d07961350045.tmp rather than the actual file name. Which file upload do you use? Old FileuploadInterceptor or ActionFileuploadInterceptor? Do you mean the error message is wrong and it displays the wrong file name? I put back the mods I did, and it still does not work. Were there any other changes? Herehttps://github.com/apache/struts/pull/873 Regards Łukasz - To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org For additional commands, e-mail:dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
Why does it work then for the other artifacts?
org.apache.struts
struts2-freemarker-jakarta
${project.version}
org.apache.struts
struts2-core
${project.version}
org.apache.struts
struts2-spring-plugin
${project.version}
Seems to be the newer jars, are the maven details correct?
On 26/02/2024 06:28, Lukasz Lenart wrote:
niedz., 25 lut 2024 o 11:57 Greg Huber napisał(a):
Also building in eclipse I get these strange errors
Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3
It's because the artifacts are transformed during build and the IDE
doesn't see them. Here is an example how to overcome this problem to
run unit tests from within the IDE
https://github.com/apache/struts/pull/871
Regards
Łukasz
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
niedz., 25 lut 2024 o 11:57 Greg Huber napisał(a): > > Also building in eclipse I get these strange errors > > Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 It's because the artifacts are transformed during build and the IDE doesn't see them. Here is an example how to overcome this problem to run unit tests from within the IDE https://github.com/apache/struts/pull/871 Regards Łukasz - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
niedz., 25 lut 2024 o 09:42 Greg Huber napisał(a): > > Testing the file upload and it now does not work. > > I get an error where its using the wrong file name ie > upload5549a568d9794ef5b654da83d07961350045.tmp rather than the > actual file name. Which file upload do you use? Old FileuploadInterceptor or ActionFileuploadInterceptor? Do you mean the error message is wrong and it displays the wrong file name? > I put back the mods I did, and it still does not work. > > Were there any other changes? Here https://github.com/apache/struts/pull/873 Regards Łukasz - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
Also building in eclipse I get these strange errors Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 Missing artifact org.apache.struts:struts2-velocity-tools-jsp-jakarta:jar:7.0.0-M3 Missing artifact org.apache.struts:struts2-velocity-tools-view-jakarta:jar:7.0.0-M3 [ERROR] Failed to execute goal on project [36mstruts2-core[m: [1;31mCould not resolve dependencies for project org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts could not be resolved: org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced[m-> [1m[Help 1][m Caused by: org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal on project [36mstruts2-core[m: [1;31mCould not resolve dependencies for project org.apache.struts:struts2-core:jar:7.0.0-M3: The following artifacts could not be resolved: org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 (present, but unavailable): org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 was not found in https://repo.maven.apache.org/maven2 during a previous attempt. This failure was cached in the local repository and resolution is not reattempted until the update interval of central has elapsed or updates are forced I have deleted my ~.m2 and it makes no difference. On 24/02/2024 08:46, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time and test the bits - any help is appreciated. Please report any problems you will spot. Here are the changes from the previous version: https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 Staging Maven repo https://repository.apache.org/content/groups/staging/ * please read our guideline how to setup your Maven build to include the Staging repository https://struts.apache.org/builds.html#test-builds Standalone artifacts https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ Release notes https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 Have fun! Łukasz - To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org For additional commands, e-mail:dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
May be related to this issue in Struts 1: https://github.com/weblegacy/struts1/issues/28 Best regards Markus Am 25.02.24 um 09:41 schrieb Greg Huber: Testing the file upload and it now does not work. I get an error where its using the wrong file name ie upload5549a568d9794ef5b654da83d07961350045.tmp rather than the actual file name. I put back the mods I did, and it still does not work. Were there any other changes? I did not test M2 so maybe there was something in that. Everything else works, so I think I have got everything setup correctly in my ide. On 24/02/2024 08:46, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time and test the bits - any help is appreciated. Please report any problems you will spot. Here are the changes from the previous version: https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 Staging Maven repo https://repository.apache.org/content/groups/staging/ * please read our guideline how to setup your Maven build to include the Staging repository https://struts.apache.org/builds.html#test-builds Standalone artifacts https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ Release notes https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 Have fun! Łukasz - To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org For additional commands, e-mail:dev-h...@struts.apache.org - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org
Re: [TEST] Apache Struts 7.0.0-M3 test build is ready
Testing the file upload and it now does not work. I get an error where its using the wrong file name ie upload5549a568d9794ef5b654da83d07961350045.tmp rather than the actual file name. I put back the mods I did, and it still does not work. Were there any other changes? I did not test M2 so maybe there was something in that. Everything else works, so I think I have got everything setup correctly in my ide. On 24/02/2024 08:46, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time and test the bits - any help is appreciated. Please report any problems you will spot. Here are the changes from the previous version: https://github.com/apache/struts/releases/tag/STRUTS_7_0_0_M3 Staging Maven repo https://repository.apache.org/content/groups/staging/ * please read our guideline how to setup your Maven build to include the Staging repository https://struts.apache.org/builds.html#test-builds Standalone artifacts https://dist.apache.org/repos/dist/dev/struts/7.0.0-M3/ Release notes https://cwiki.apache.org/confluence/display/WW/Version+Notes+7.0.0-M3 Have fun! Łukasz - To unsubscribe, e-mail:dev-unsubscr...@struts.apache.org For additional commands, e-mail:dev-h...@struts.apache.org
