[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-12-04 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Thanks @HyukjinKwon  feel free to take over this


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-12-04 Thread HyukjinKwon
Github user HyukjinKwon commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Hey @zjffdu, busy? I can take this over - looks there's only minor conflict.


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-10-11 Thread dongjoon-hyun
Github user dongjoon-hyun commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Hi, @zjffdu , @felixcheung , @Leemoonsoo .

Since Spark 2.1.3/2.2.2/2.3.2 is out and Spark 2.4.0 RC3 is started, can we 
restart this?


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-28 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Anyway, this PR is just for the next release of spark that supports scala 
2.11.12, I can hold it if you have any concern


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-28 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
well, ok. though might be hard to tell - we are juggling multiple releases 
2.1.3, 2.2.2, 2.3.2 - might take some time to get to 2.4.0.



---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
This is for the next release of zeppelin which I suppose should supported 
the latest spark 2.4.0 which would use scala 2.11.12. Just want to catch up 
with spark. 




---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Perhaps you could elaborate on why we should do this now since Spark 
doesn’t actually support it? Is there a reason that I have missed?






---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
It is to fine to compile with spark 2.2, the main change is on 
SparkScala211Interpreter.scala which is due to scala repl api changes in scala 
2.11.12. 


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
? it looks like spark.version is 2.2.0.
as far as I know SPARK-24418 is fixed only in (unreleased) master branch


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-26 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Thanks @felixcheung , I will revert the change in the root pom file and 
only update scala version in spark module. 


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-26 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
something in SparkILoop. given that I don't think we can/should upgrade 
scala broadly - it might only work for Spark 2.4.0 (unreleased) but not 
older/current releases


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-26 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
I tested it against spark master branch, and it works. What kind of 
problems does spark have on 2.11.12 ?  I notice SPARK-24418 is already merged. 


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-26 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
specifically in SPARK-24418 - there code changes needed but not release yet 
(2.4?)


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-25 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
LGTM


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-25 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
Will merge it if no more comments 


---


[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12

2018-06-21 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3033
  
@Leemoonsoo @felixcheung Could you help review it ? Thanks


---