Re: Why does anaconda-core runtime depend on python3-coverage?
The coverage dependency was removed (F31 and Rawhide): https://github.com/rhinstaller/anaconda/pull/2086 The main reason for the removal was that this wasn't really used in the past and the recent Anaconda changes needs other solution to get the correct coverage. Jirka On Wed, 2019-08-14 at 11:47 -0700, Adam Williamson wrote: > On Wed, 2019-08-14 at 11:29 -0700, Brian C. Lane wrote: > > On Mon, Aug 12, 2019 at 08:44:24PM +0200, Igor Gnatenko wrote: > > > What is the point of this? I am probably missing something > > > obvious.. > > > > I think this was because getting good coverage data from anaconda > > without actually booting the installer iso wasn't possible. > > atodorov may > > be able to provide more context. > > was this possibly to do with the kickstart-tests effort - an attempt > to > figure out the code coverage of those tests? > -- > Adam Williamson > Fedora QA Community Monkey > IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . > net > http://www.happyassassin.net > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why does anaconda-core runtime depend on python3-coverage?
On Wed, 2019-08-14 at 11:29 -0700, Brian C. Lane wrote: > On Mon, Aug 12, 2019 at 08:44:24PM +0200, Igor Gnatenko wrote: > > What is the point of this? I am probably missing something obvious.. > > I think this was because getting good coverage data from anaconda > without actually booting the installer iso wasn't possible. atodorov may > be able to provide more context. was this possibly to do with the kickstart-tests effort - an attempt to figure out the code coverage of those tests? -- Adam Williamson Fedora QA Community Monkey IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net http://www.happyassassin.net ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why does anaconda-core runtime depend on python3-coverage?
On Mon, Aug 12, 2019 at 08:44:24PM +0200, Igor Gnatenko wrote: > What is the point of this? I am probably missing something obvious.. I think this was because getting good coverage data from anaconda without actually booting the installer iso wasn't possible. atodorov may be able to provide more context. -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why does anaconda-core runtime depend on python3-coverage?
What is the point of this? I am probably missing something obvious.. On Mon, Aug 12, 2019, 18:46 Brian C. Lane wrote: > On Sun, Aug 11, 2019 at 11:39:34AM +0200, Miro Hrončok wrote: > > Hey, I have noticed that anaconda-core has a runtime dependency on > python3-coverage. > > > > Is it some weird error, or does anaconda actually need a test coverage > > measuring tool at runtime? > > Yes. If you pass inst.debug=1 it will generate a coverage report. > > https://github.com/rhinstaller/anaconda/blob/master/anaconda.py#L35 > > -- > Brian C. Lane (PST8PDT) - weldr.io - lorax - parted > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why does anaconda-core runtime depend on python3-coverage?
On Sun, Aug 11, 2019 at 11:39:34AM +0200, Miro Hrončok wrote: > Hey, I have noticed that anaconda-core has a runtime dependency on > python3-coverage. > > Is it some weird error, or does anaconda actually need a test coverage > measuring tool at runtime? Yes. If you pass inst.debug=1 it will generate a coverage report. https://github.com/rhinstaller/anaconda/blob/master/anaconda.py#L35 -- Brian C. Lane (PST8PDT) - weldr.io - lorax - parted ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Re: Why does anaconda-core runtime depend on python3-coverage?
- Original Message - > From: "Miro Hrončok" > To: "Development discussions related to Fedora" > > Cc: anaconda-maint-l...@redhat.com > Sent: Sunday, August 11, 2019 11:39:34 AM > Subject: Why does anaconda-core runtime depend on python3-coverage? > > Hey, I have noticed that anaconda-core has a runtime dependency on > python3-coverage. > > Is it some weird error, or does anaconda actually need a test coverage > measuring > tool at runtime? This is working as intended - Anaconda supports recording code coverage information at runtime, so it is possible to check code coverage during real installation runs, not just when running unit tests. > > Thanks, > -- > Miro Hrončok > -- > Phone: +420777974800 > IRC: mhroncok > ___ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: > https://docs.fedoraproject.org/en-US/project/code-of-conduct/ > List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org > ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Why does anaconda-core runtime depend on python3-coverage?
Hey, I have noticed that anaconda-core has a runtime dependency on python3-coverage. Is it some weird error, or does anaconda actually need a test coverage measuring tool at runtime? Thanks, -- Miro Hrončok -- Phone: +420777974800 IRC: mhroncok ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
