Hi Kazuo, It's a gnu extension, equivalent to
chansess->original_command = chansess->cmd ? chansess->cmd : m_strdup(""); I've pushed a fix now, I prefer a plain "if" statement. Cheers, Matt > On Thu 8/10/2020, at 8:59 am, Kazuo Kuroi <kaz...@projectkitsune.com> wrote: > > Hi folks, > > MIPSPro 7.4.4m on IRIX doesn't like svr-chansession.c again: > > cc-1029 c99: ERROR File = svr-chansession.c, Line = 696 > An expression is expected at this point. > > chansess->original_command = chansess->cmd ? : m_strdup(""); > ^ > > cc-1053 c99: ERROR File = svr-chansession.c, Line = 696 > A colon is expected at this point. > > chansess->original_command = chansess->cmd ? : m_strdup(""); > ^ > > 2 errors detected in the compilation of "svr-chansession.c". > make: *** [svr-chansession.o] Error 2 > make: *** Waiting for unfinished jobs.... > > I'm not sure how to exactly fix that, if anyone has any suggestions I can try > that would be helpful, otherwise I can give access to a box if needed! > > Thanks as always for keeping these changes upstream. > > There's also a minor issue of the build system setting inappropriate flags > for MIPSPro, such as -Wextra and -Wsystem-headers and such. I can work with > someone to add a definition for MIPSPro to set the CFLAGS properly, I have a > complete list around here somewhere. For now I just deleted those CFLAGS. > > Best Regards, > > Kazuo Kuroi > >