Public bug reported:
When building accountsservice we apply patches, among of which is
`0010-set-language.patch` which raises concerns.
It will not compile without warnings: At the very least contains
misleading indentation.
```
[92/99] Compiling C object src/accounts-daemon.p/user.c.o
../src/user.c: In function ‘user_HOME_available’:
../src/user.c:1753:27: warning: this ‘else’ clause does not guard...
[-Wmisleading-indentation]
1753 | } else
| ^~~~
../src/user.c:1755:33: note: ...this statement, but the latter is misleadingly
indented as if it were guarded by the ‘else’
1755 | break;
| ^~~~~
```
The code:
```
} else
g_free (path_to_entry);
break;
```
** Affects: accountsservice (Ubuntu)
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of DX
Packages, which is subscribed to accountsservice in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1999698
Title:
Dodgy looking patch applied to our build.
Status in accountsservice package in Ubuntu:
New
Bug description:
When building accountsservice we apply patches, among of which is
`0010-set-language.patch` which raises concerns.
It will not compile without warnings: At the very least contains
misleading indentation.
```
[92/99] Compiling C object src/accounts-daemon.p/user.c.o
../src/user.c: In function ‘user_HOME_available’:
../src/user.c:1753:27: warning: this ‘else’ clause does not guard...
[-Wmisleading-indentation]
1753 | } else
| ^~~~
../src/user.c:1755:33: note: ...this statement, but the latter is
misleadingly indented as if it were guarded by the ‘else’
1755 | break;
| ^~~~~
```
The code:
```
} else
g_free (path_to_entry);
break;
```
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/accountsservice/+bug/1999698/+subscriptions
--
Mailing list: https://launchpad.net/~dx-packages
Post to : dx-packages@lists.launchpad.net
Unsubscribe : https://launchpad.net/~dx-packages
More help : https://help.launchpad.net/ListHelp
