Re: HELP needed by experienced porter for simple review
- Respect the CC, CFLAGS and LOCALBASE. See in post-patch. - Add kissdx.in in 'files' directory. - Remove that add_to_conf stuff in Makefile, use pkg-message. Thank you Mezz, for going through my makefiles and making it conform to the principals of the ports system. That was a very big help to me and an effort beyond expectation. It gave me a new understanding of /files that I will pass on to the doc team and hopefully into the next version of porters handbook. rc.conf It's a shame that I can't use a script placed in /files to change rc.conf during install/ deinstall. I really liked that. But i guess I will settle with a dull pkg-message at the end, like the rest of you... Source Makefile Since I made the (simple) source Makefile, I would have liked to take advantage of the many predefined macros/variables i the port Makefile. It seems strange to me, to pass them as a patch (like this: s|CC?= gcc|CC?= ${CC}|g ) How many of them if any, are passed on to the source makefile? Are there a way to turn them all on? if that: any documentation? (except the bsd.ports.mk file) BR, Simon ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
--On Thursday, December 06, 2007 13:34:05 +0100 GP [EMAIL PROTECTED] wrote: rc.conf It's a shame that I can't use a script placed in /files to change rc.conf during install/ deinstall. I really liked that. But i guess I will settle with a dull pkg-message at the end, like the rest of you... Well, no, it's not a shame. The last thing we want to do as a community is enable all sorts of daemons that users don't know they have enabled. It's up to the owner of a box to enable a daemon **in the way** that they want it enabled. For example, *none* of the daemons on my workstation listen for connections on its IP address - only on localhost. If you enabled the daemon by default while installing the script, and I didn't have time to config it the way I wanted, and it got started (either by accident or by reboot) I would be pissed (not to mention possibly hacked.) As porters our job is to make the software available for install *not* decide how or when it will be used. -- Paul Schmehl ([EMAIL PROTECTED]) Senior Information Security Analyst The University of Texas at Dallas http://www.utdallas.edu/ir/security/ ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
rc.conf It's a shame that I can't use a script placed in /files to change rc.conf during install/ deinstall. I really liked that. But i guess I will settle with a dull pkg-message at the end, like the rest of you... Well, no, it's not a shame. The last thing we want to do as a community is enable all sorts of daemons that users don't know they have enabled. It's up to the owner of a box to enable a daemon **in the way** that they want it enabled. For example, *none* of the daemons on my workstation listen for connections on its IP address - only on localhost. If you enabled the daemon by default while installing the script, and I didn't have time to config it the way I wanted, and it got started (either by accident or by reboot) I would be pissed (not to mention possibly hacked.) As porters our job is to make the software available for install *not* decide how or when it will be used. I principal I agree. My script asked if you wanted the lines added to rc.conf or not. That can ofcause be a problem i you want to make install world or something... But the current way is not very userfrendly - especially for non tech desktop users. /Simon R. ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
On Thu, Dec 06, 2007 at 10:22:06PM +0100, GP wrote: rc.conf It's a shame that I can't use a script placed in /files to change rc.conf during install/ deinstall. I really liked that. But i guess I will settle with a dull pkg-message at the end, like the rest of you... Well, no, it's not a shame. The last thing we want to do as a community is enable all sorts of daemons that users don't know they have enabled. It's up to the owner of a box to enable a daemon **in the way** that they want it enabled. For example, *none* of the daemons on my workstation listen for connections on its IP address - only on localhost. If you enabled the daemon by default while installing the script, and I didn't have time to config it the way I wanted, and it got started (either by accident or by reboot) I would be pissed (not to mention possibly hacked.) As porters our job is to make the software available for install *not* decide how or when it will be used. I principal I agree. My script asked if you wanted the lines added to rc.conf or not. That can ofcause be a problem i you want to make install world or something... But the current way is not very userfrendly - especially for non tech desktop users. If you really want to change this it would need to be done in a way that all ports can use central infrastructure. I'd probably be opposed to having the prompting be part of the ports makefiles and propose putting it in the various ports managment tools. If we changed things so we installed per-port defaults files those could serve as a template for general tools to do automatic editing. -- Brooks pgpGO8dHlSD3g.pgp Description: PGP signature
Re: HELP needed by experienced porter for simple review
On Tue, 04 Dec 2007 06:36:20 -0600, GP [EMAIL PROTECTED] wrote: $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} I don't really like to create FILESDIR and move from WRKSRC to FILESDIR. The WRKDIR/WRKSRC are the place where you work anything inside. However, move from WRKSRC to FILESDIR might create problem in future so avoid that. When I leve it out I get this error: === Installing for kissdx-0.13.10a ** Missing /usr/ports/distfiles/files/kissdx.in for kissdx-0.13.10a. *** Error code 1 Ummm... I went back to see your first orignal thread. I noticed that you put Makefile and others in /usr/ports/distfiles/? You should create 'kissdx' and 'kissdx/files' (mkdir -p kissdx/files) directories. You should make your port looks like this: OK its all moved to a handmade subdir. Probably nicer that way, but I still have to make the files dir in the Makefile and put the script in it! or am I missing something? Maybe I don't understand the files dir!!? could it mean that the startup script can not come from the tarball? (I've done some work for including FreeBSD stuff into the original package. So that would be a capitulation to Linux then wouldnt it?: all is writen for Linux and then adapted for FreeBSD :o) Send me tarball of your update kissdx port and I will taking a peek. Cheers, Mezz You should follow this below: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html You put your 'kissdx.in' in kissdx/files/ and it will doing every thing for you as explained in rc-scripts.html. I'm sorry to say that i doesn't explain this for me. Porters handbook still requires a lot of implicit knowledge. (But I'm getting there by small increments :O) Thanks and BR /Simon -- [EMAIL PROTECTED] - [EMAIL PROTECTED] FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - [EMAIL PROTECTED] http://wiki.freebsd.org/multimedia - [EMAIL PROTECTED] ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
Thanks a lot! I have as you sugested, but have a problems: $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} I don't really like to create FILESDIR and move from WRKSRC to FILESDIR. The WRKDIR/WRKSRC are the place where you work anything inside. However, move from WRKSRC to FILESDIR might create problem in future so avoid that. When I leve it out I get this error: === Installing for kissdx-0.13.10a ** Missing /usr/ports/distfiles/files/kissdx.in for kissdx-0.13.10a. *** Error code 1 I think that's all for now. Most of answers are in the porter handbook. You are probably right. I read it first of cause. But its not very easy to understand, if you havent worked with porting before. (The are almost no examples in it.) BR Simon ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
On Mon, 03 Dec 2007 15:50:21 -0600, GP [EMAIL PROTECTED] wrote: Thanks a lot! I have as you sugested, but have a problems: $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} I don't really like to create FILESDIR and move from WRKSRC to FILESDIR. The WRKDIR/WRKSRC are the place where you work anything inside. However, move from WRKSRC to FILESDIR might create problem in future so avoid that. When I leve it out I get this error: === Installing for kissdx-0.13.10a ** Missing /usr/ports/distfiles/files/kissdx.in for kissdx-0.13.10a. *** Error code 1 Ummm... I went back to see your first orignal thread. I noticed that you put Makefile and others in /usr/ports/distfiles/? You should create 'kissdx' and 'kissdx/files' (mkdir -p kissdx/files) directories. You should make your port looks like this: == kissdx/ kissdx/Makefile kissdx/distinfo kissdx/pkg-descr kissdx/pkg-message kissdx/files/ kissdx/files/kissdx.in kissdx/files/patch files == You should follow this below: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/rc-scripts.html You put your 'kissdx.in' in kissdx/files/ and it will doing every thing for you as explained in rc-scripts.html. I think that's all for now. Most of answers are in the porter handbook. You are probably right. I read it first of cause. But its not very easy to understand, if you havent worked with porting before. (The are almost no examples in it.) That's ok, you can check in other ports to get good examples. One more that I have noticed. The 'do-install: all' should be change to 'do-install:' without have 'all' in it. Hope it helps. Cheers, Mezz BR Simon -- [EMAIL PROTECTED] - [EMAIL PROTECTED] FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - [EMAIL PROTECTED] http://wiki.freebsd.org/multimedia - [EMAIL PROTECTED] ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
HELP needed by experienced porter for simple review
Any body? I'm new to porting for FreeBSD and make files aren't my strongest suit. So I would be greatful if I could get an experienced porter to review my make files, for at very simple deamon. I've read the porter handbook and the port seems to be working fine. But I'm uncertain as to what is best practise and since this will hopefully be the first of many ports, I would like to get i right. If you want to help, please drop me a note and I will send you the two small makefiles to review. Hi and welcome! First of all you should install ports-mgmt/portlint and run it against your port (if you haven't done it already). Be sure to use the switch to enable additional checks (I got bitten once because I forgot it). Then you could perhaps put your work online somewhere and provide a link, so everybody can take a look at it and test. Best regards, Jona Ok. thanks. Its simple so I will just put in in this mail. I hope to have the ability to make changes in the source, so I've included the proposed application Makefile as well. Its all working, but I would like to know if the concepts are sound? Portlint throws a warning, but I don't se any reasonable way arrount that: /usr/ports/distfilesportlint WARN: Makefile: possible use of absolute pathname /etc/rc.conf.bak. 0 fatal errors and 1 warning found. Root Makefile: -- # New ports collection makefile for: kissdx # Date created:20. November 2007 # Whom:Simon I. Rigét # # $FreeBSD$ PORTNAME= kissdx PORTVERSION= 0.13.10a CATEGORIES= multimedia net MASTER_SITES= http://freebsd.paragi.dk/kissdx/ \ http://kissdx.vidartysse.net/ DISTNAME= ${PORTNAME}-${PORTVERSION} MAINTAINER= [EMAIL PROTECTED] COMMENT= A multimedia streaming server for KiSS/Linksys player USE_ICONV= yes # Dependencies of other packeges LIB_DEPENDS= libdvdread:${PORTSDIR}/multimedia/libdvdread \ libiconv:${PORTSDIR}/converters/libiconv \ gd-2:${PORTSDIR}/graphics/gd jpeg-6b_4:${PORTSDIR}/graphics/jpeg # Man pages MAN1= kissdx.1 MANCOMPRESSED= yes # RC start and stop service USE_RC_SUBR= kissdx # set enviroment variables for port makefile MAKE_ENV= FreeBSD=defined # Convert CR/LF to LF in source files USE_DOS2UNIX= yes post-patch: ${REINPLACE_CMD} -e 's|Linux|Unix|g' ${WRKSRC}/kissdx.1 ${REINPLACE_CMD} -e 's|/etc/|/usr/local/etc/|' ${WRKSRC}/kissdx.1 $(GZIP_CMD) -c ${INSTALL_WRKSRC}/kissdx.1 ${INSTALL_WRKSRC}/kissdx.1.gz $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} do-install: all $(INSTALL_PROGRAM) ${INSTALL_WRKSRC}/kissdx ${TARGETDIR}/sbin/kissdx $(INSTALL_DATA) ${INSTALL_WRKSRC}/kissdx.conf ${TARGETDIR}/etc/kissdx.conf $(INSTALL_MAN) ${INSTALL_WRKSRC}/kissdx.1.gz ${TARGETDIR}/man/man1/kissdx.1.gz echo kissdx_enabled=\YES\ /etc/rc.conf do-deinstall: $(RM) ${TARGETDIR}/sbin/kissdx $(RM) ${TARGETDIR}/etc/kissdx.conf $(RM) ${TARGETDIR}/man/man1/kissdx.* $(RM) ${TARGETDIR}/etc/rc.d/kissdx $(CP) ${/etc/rc.conf} ${/etc/rc.conf}.bak ${GREP} -v kissdx_ /etc/rc.conf.bak /etc/rc.conf .include bsd.port.mk pkg-plist: sbin/kissdx etc/kissdx.conf etc/rc.d/kissdx Application Makefile: # KiSS DX multi OS Makefile# By SR. 2007-11-30 # Operating system# Uncomment for onr of the desired OS (Execpt FreeBSD which will be definedby# the master makefile) #env= Environment(**ARGUMENTS)#NSLU2= defined#CYGWIN= definedLinux= defined # Generic settings## In some UNIX systems build options that affect all ports can be setglobally.# this makefile should not override the existing value.CC?= gcc# compiler directives (defines)# Sendfile# -DUSE_INTERNAL_SENDFILE (less performance) if you cannot use the sendfilesyscall on your# target platform with 64-bit file access. Needed for Unslung 5.5 on NSLU2.# -DUSE_INTERNAL_SENDFILE_MMAP (better performance)# with -DUSE_INTERNAL_SENDFILE if your target platform supports memorymapped# files with 64-bit file access and you want to use it. Not possible with# 2GB files on Unslung 5.5 on NSLU2.CFLAGS+= -DUSE_INTERNAL_SENDFILE # Support for lage file sizes 2GbCFLAGS+= -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64CFLAGS+= -D_GNU_SOURCE# Compile optionsCFLAGS+= -Wall -Wstrict-prototypes# LiberariesLIBS+= -ldvdread# remove -liconv below if your
Re: HELP needed by experienced porter for simple review
GP wrote: Hi and welcome! First of all you should install ports-mgmt/portlint and run it against your port (if you haven't done it already). Be sure to use the switch to enable additional checks (I got bitten once because I forgot it). Then you could perhaps put your work online somewhere and provide a link, so everybody can take a look at it and test. You should not make changes to /etc/rc.conf at all from a port. Please remove that before submitting. Thanks, Doug -- This .signature sanitized for your protection ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
You should not make changes to /etc/rc.conf at all from a port. Please remove that before submitting. Thanks, Doug Thanks I will, but how should it be done? I must be there for it to work? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
GP wrote: You should not make changes to /etc/rc.conf at all from a port. Please remove that before submitting. Thanks, Doug Thanks I will, but how should it be done? I must be there for it to work? ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED] Many ports need this to work, sadly it is often not mentioned at the end of make install or the pkg_add. I would love for it to say something like this. We need to make this easier to use when possible. In order for the install of port name to work, it should be activated via /etc.rc.conf, would you like for this modification to be made for you? If you type y, /etc/rconf will have the following line added. portname_enable=YES [y n] ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
Many ports need this to work, sadly it is often not mentioned at the end of make install or the pkg_add. I would love for it to say something like this. We need to make this easier to use when possible. In order for the install of port name to work, it should be activated via /etc.rc.conf, would you like for this modification to be made for you? If you type y, /etc/rconf will have the following line added. portname_enable=YES [y n] Good ideer! I will work that in. Thanks ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
On Sun, 02 Dec 2007 15:37:57 -0600, GP [EMAIL PROTECTED] wrote: snip Ok. thanks. Its simple so I will just put in in this mail. I hope to have the ability to make changes in the source, so I've included the proposed application Makefile as well. Its all working, but I would like to know if the concepts are sound? Portlint throws a warning, but I don't se any reasonable way arrount that: /usr/ports/distfilesportlint WARN: Makefile: possible use of absolute pathname /etc/rc.conf.bak. 0 fatal errors and 1 warning found. Follow Doug's suggest, this will disappear. I agree with him about never edit rc.conf without our knowledge. You can see in x11/gdm/Makefile for PKGMESSAGE and x11/gdm/pkg-message to get idea for how to warn users to add in rc.conf. See below for more feedbacks: Root Makefile: -- # New ports collection makefile for: kissdx # Date created:20. November 2007 # Whom:Simon I. Rigét # # $FreeBSD$ PORTNAME= kissdx PORTVERSION= 0.13.10a CATEGORIES= multimedia net MASTER_SITES= http://freebsd.paragi.dk/kissdx/ \ http://kissdx.vidartysse.net/ DISTNAME= ${PORTNAME}-${PORTVERSION} You can remove DISTNAME; it's not need and it is on what you want by default. MAINTAINER= [EMAIL PROTECTED] COMMENT= A multimedia streaming server for KiSS/Linksys player USE_ICONV= yes # Dependencies of other packeges LIB_DEPENDS= libdvdread:${PORTSDIR}/multimedia/libdvdread \ libiconv:${PORTSDIR}/converters/libiconv \ Remove libiconv, since the USE_ICONV=yes takes care of that. gd-2:${PORTSDIR}/graphics/gd It should be 'gd.4' or just 'gd'. jpeg-6b_4:${PORTSDIR}/graphics/jpeg It should be 'jpeg.9' or just 'jpeg'. See here: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html#AEN2056 # Man pages MAN1= kissdx.1 MANCOMPRESSED= yes Remove MANCOMPRESSED; it is turn on by default. # RC start and stop service USE_RC_SUBR= kissdx # set enviroment variables for port makefile MAKE_ENV= FreeBSD=defined # Convert CR/LF to LF in source files USE_DOS2UNIX= yes post-patch: ${REINPLACE_CMD} -e 's|Linux|Unix|g' ${WRKSRC}/kissdx.1 ${REINPLACE_CMD} -e 's|/etc/|/usr/local/etc/|' ${WRKSRC}/kissdx.1 $(GZIP_CMD) -c ${INSTALL_WRKSRC}/kissdx.1 ${INSTALL_WRKSRC}/kissdx.1.gz Remove this GZIP_CMD line, it will compressing manpage by default unless user has MANCOMPRESSED sets to no or set to bzip2 rather than gzip. $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} I don't really like to create FILESDIR and move from WRKSRC to FILESDIR. The WRKDIR/WRKSRC are the place where you work anything inside. However, move from WRKSRC to FILESDIR might create problem in future so avoid that. do-install: all $(INSTALL_PROGRAM) ${INSTALL_WRKSRC}/kissdx ${TARGETDIR}/sbin/kissdx $(INSTALL_DATA) ${INSTALL_WRKSRC}/kissdx.conf ${TARGETDIR}/etc/kissdx.conf $(INSTALL_MAN) ${INSTALL_WRKSRC}/kissdx.1.gz ${TARGETDIR}/man/man1/kissdx.1.gz s/kissdx.1.gz/kissdx.1/g after you modify above, then change from TARGETDIR to MANPREFIX. echo kissdx_enabled=\YES\ /etc/rc.conf do-deinstall: $(RM) ${TARGETDIR}/sbin/kissdx $(RM) ${TARGETDIR}/etc/kissdx.conf $(RM) ${TARGETDIR}/man/man1/kissdx.* $(RM) ${TARGETDIR}/etc/rc.d/kissdx $(CP) ${/etc/rc.conf} ${/etc/rc.conf}.bak ${GREP} -v kissdx_ /etc/rc.conf.bak /etc/rc.conf We don't need the do-deinstall target, so remove all of that. We have 'pkg_delete' and 'make deinstall'. .include bsd.port.mk pkg-plist: sbin/kissdx etc/kissdx.conf etc/rc.d/kissdx Remove 'etc/rc.d/kissdx' since that USE_RC_SUBR takes care of it. So it will be two lines in pkg-plist, so I suggest you to remove pkg-plist and use PLIST_FILES in Makefile to take care of these files. I think that's all for now. Most of answers are in the porter handbook. http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/ Cheers, Mezz Application Makefile: snip -- [EMAIL PROTECTED] - [EMAIL PROTECTED] FreeBSD GNOME Team - FreeBSD Multimedia Hat (ports, not src) http://www.FreeBSD.org/gnome/ - [EMAIL PROTECTED] http://wiki.freebsd.org/multimedia - [EMAIL PROTECTED] ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
Re: HELP needed by experienced porter for simple review
I'm new to porting for FreeBSD and make files aren't my strongest suit. So I would be greatful if I could get an experienced porter to review my make files, for at very simple deamon. I've read the porter handbook and the port seems to be working fine. But I'm uncertain as to what is best practise and since this will hopefully be the first of many ports, I would like to get i right. If you want to help, please drop me a note and I will send you the two small makefiles to review. Hi and welcome! First of all you should install ports-mgmt/portlint and run it against your port (if you haven't done it already). Be sure to use the switch to enable additional checks (I got bitten once because I forgot it). Then you could perhaps put your work online somewhere and provide a link, so everybody can take a look at it and test. Best regards, Jona Ok. thanks. Its simple so I will just put in in this mail. I hope to have the ability to make changes in the source, so I've included the proposed application Makefile as well. Its all working, but I would like to know if the concepts are sound? Portlint throws a warning, but I don't se any reasonable way arrount that: /usr/ports/distfilesportlint WARN: Makefile: possible use of absolute pathname /etc/rc.conf.bak. 0 fatal errors and 1 warning found. Root Makefile: -- # New ports collection makefile for: kissdx # Date created:20. November 2007 # Whom:Simon I. Rigét # # $FreeBSD$ PORTNAME= kissdx PORTVERSION= 0.13.10a CATEGORIES= multimedia net MASTER_SITES= http://freebsd.paragi.dk/kissdx/ \ http://kissdx.vidartysse.net/ DISTNAME= ${PORTNAME}-${PORTVERSION} MAINTAINER= [EMAIL PROTECTED] COMMENT= A multimedia streaming server for KiSS/Linksys player USE_ICONV= yes # Dependencies of other packeges LIB_DEPENDS= libdvdread:${PORTSDIR}/multimedia/libdvdread \ libiconv:${PORTSDIR}/converters/libiconv \ gd-2:${PORTSDIR}/graphics/gd jpeg-6b_4:${PORTSDIR}/graphics/jpeg # Man pages MAN1= kissdx.1 MANCOMPRESSED= yes # RC start and stop service USE_RC_SUBR= kissdx # set enviroment variables for port makefile MAKE_ENV= FreeBSD=defined # Convert CR/LF to LF in source files USE_DOS2UNIX= yes post-patch: ${REINPLACE_CMD} -e 's|Linux|Unix|g' ${WRKSRC}/kissdx.1 ${REINPLACE_CMD} -e 's|/etc/|/usr/local/etc/|' ${WRKSRC}/kissdx.1 $(GZIP_CMD) -c ${INSTALL_WRKSRC}/kissdx.1 ${INSTALL_WRKSRC}/kissdx.1.gz $(MKDIR) $(FILESDIR) $(CP) ${WRKSRC}/kissdx.in ${FILESDIR} do-install: all $(INSTALL_PROGRAM) ${INSTALL_WRKSRC}/kissdx ${TARGETDIR}/sbin/kissdx $(INSTALL_DATA) ${INSTALL_WRKSRC}/kissdx.conf ${TARGETDIR}/etc/kissdx.conf $(INSTALL_MAN) ${INSTALL_WRKSRC}/kissdx.1.gz ${TARGETDIR}/man/man1/kissdx.1.gz echo kissdx_enabled=\YES\ /etc/rc.conf do-deinstall: $(RM) ${TARGETDIR}/sbin/kissdx $(RM) ${TARGETDIR}/etc/kissdx.conf $(RM) ${TARGETDIR}/man/man1/kissdx.* $(RM) ${TARGETDIR}/etc/rc.d/kissdx $(CP) ${/etc/rc.conf} ${/etc/rc.conf}.bak ${GREP} -v kissdx_ /etc/rc.conf.bak /etc/rc.conf .include bsd.port.mk pkg-plist: sbin/kissdx etc/kissdx.conf etc/rc.d/kissdx Application Makefile: # KiSS DX multi OS Makefile # By SR. 2007-11-30 # Operating system # Uncomment for onr of the desired OS (Execpt FreeBSD which will be defined by # the master makefile) #env= Environment(**ARGUMENTS) #NSLU2= defined #CYGWIN= defined Linux= defined # Generic settings # # In some UNIX systems build options that affect all ports can be set globally. # this makefile should not override the existing value. CC?= gcc # compiler directives (defines) # Sendfile # -DUSE_INTERNAL_SENDFILE (less performance) if you cannot use the sendfile syscall on your target platform with 64-bit file access. Needed for Unslung 5.5 on NSLU2. # -DUSE_INTERNAL_SENDFILE_MMAP (better performance) with -DUSE_INTERNAL_SENDFILE if your target platform supports memory mapped files with 64-bit file access and you want to use it. Not possible with 2GB files on Unslung 5.5 on NSLU2. CFLAGS+= -DUSE_INTERNAL_SENDFILE # Support for lage file sizes 2Gb CFLAGS+= -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 CFLAGS+= -D_GNU_SOURCE # Compile options CFLAGS+= -Wall -Wstrict-prototypes # Liberaries LIBS+= -ldvdread # remove -liconv
Re: HELP needed by experienced porter for simple review
On Sat, 01 Dec 2007 00:38:16 +0100, GP wrote: - Original Message - From: GP [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, December 01, 2007 12:37 AM Subject: HELP needed by experienced porter for simple review I'm new to porting for FreeBSD and make files aren't my strongest suit. So I would be greatful if I could get an experienced porter to review my make files, for at very simple deamon. I've read the porter handbook and the port seems to be working fine. But I'm uncertain as to what is best practise and since this will hopefully be the first of many ports, I would like to get i right. If you want to help, please drop me a note and I will send you the two small makefiles to review. Hi and welcome! First of all you should install ports-mgmt/portlint and run it against your port (if you haven't done it already). Be sure to use the switch to enable additional checks (I got bitten once because I forgot it). Then you could perhaps put your work online somewhere and provide a link, so everybody can take a look at it and test. Best regards, Jona -- I am chaos. I am the substance from which your artists and scientists build rhythms. I am the spirit with which your children and clowns laugh in happy anarchy. I am chaos. I am alive, and tell you that you are free. Eris, Goddess Of Chaos, Discord Confusion ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]
HELP needed by experienced porter for simple review
- Original Message - From: GP [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Saturday, December 01, 2007 12:37 AM Subject: HELP needed by experienced porter for simple review I'm new to porting for FreeBSD and make files aren't my strongest suit. So I would be greatful if I could get an experienced porter to review my make files, for at very simple deamon. I've read the porter handbook and the port seems to be working fine. But I'm uncertain as to what is best practise and since this will hopefully be the first of many ports, I would like to get i right. If you want to help, please drop me a note and I will send you the two small makefiles to review. /SR ___ freebsd-ports@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to [EMAIL PROTECTED]