Re: editors/atom: build error on 13.0-CURRENT
Hi Vidar, Thanks for trying. It passes the configure phase with that change to the regex, but it fails later. (snip) It builds fine when I give it --openssl-no-asm, and I also noticed that www/node10 also does exactly this. Are you referring to the lines 82-84 of Makefile? In this case, amd64 and i386 are both excluded. So I guess it should be buildable without --openssl-no-asm on amd64. I will dig into the error a little deeper. Thanks, Hiroki ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: editors/atom: build error on 13.0-CURRENT
On 4/17/20 7:24 AM, Hiroki Tagato wrote: Can you apply a patch at https://github.com/nodejs/node/pull/29541 and try to build again? If it goes well, I will update the port to include the patch. Thanks, Hiroki It passes the configure phase with that change to the regex, but it fails later. Running 'make' in /usr/ports/editors/atom: [...] c++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.8"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I../deps/v8 -I../deps/v8/include -pthread -Wall -Wextra -Wno-unused-parameter -m64 -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -fno-strict-aliasing -I/usr/local/include -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /usr/ports/editors/atom/work/node-v10.2.1/out/Release/.deps//usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o.d.raw -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -c -o /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_init/deps/v8/src/setup-isolate-full.o ../deps/v8/src/setup-isolate-full.cc In file included from ../deps/v8/src/setup-isolate-full.cc:7: In file included from ../deps/v8/src/base/logging.h:8: In file included from /usr/include/c++/v1/cstring:59: /usr/include/c++/v1/__config:122:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported.use _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead #error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \ ^ c++ '-DV8_GYP_BUILD' '-DV8_TYPED_ARRAY_MAX_SIZE_IN_HEAP=0' '-DV8_TARGET_ARCH_X64' '-DV8_EMBEDDER_STRING="-node.8"' '-DENABLE_DISASSEMBLER' '-DV8_PROMISE_INTERNAL_FIELD_COUNT' '-Dv8_promise_internal_field_count' '-DV8_INTL_SUPPORT' '-DV8_CONCURRENT_MARKING' '-DDISABLE_UNTRUSTED_CODE_MITIGATIONS' -I../deps/v8 -pthread -Wall -Wextra -Wno-unused-parameter -m64 -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 -fno-strict-aliasing -I/usr/local/include -fdata-sections -ffunction-sections -O3 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++1y -MMD -MF /usr/ports/editors/atom/work/node-v10.2.1/out/Release/.deps//usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o.d.raw -isystem /usr/local/include -O2 -pipe -fstack-protector-strong -isystem /usr/local/include -fno-strict-aliasing -isystem /usr/local/include -c -o /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o ../deps/v8/src/base/bits.cc In file included from ../deps/v8/src/base/bits.cc:5: In file included from ../deps/v8/src/base/bits.h:8: In file included from /usr/include/c++/v1/stdint.h:106: /usr/include/c++/v1/__config:122:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported.use _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead #error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \ ^ 1 error generated. gmake[3]: *** [deps/v8/gypfiles/v8_libbase.target.mk:131: /usr/ports/editors/atom/work/node-v10.2.1/out/Release/obj.target/v8_libbase/deps/v8/src/base/bits.o] Error 1 gmake[3]: *** Waiting for unfinished jobs [...] I have uploaded the full output to https://bsd.to/oh4e It builds fine when I give it --openssl-no-asm, and I also noticed that www/node10 also does exactly this. -- Vidar ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: editors/atom: build error on 13.0-CURRENT
On 4/16/20 6:49 AM, Dimitry Andric wrote: On 15 Apr 2020, at 22:14, Vidar Karlsen wrote: BUILDING.md says it needs llvm 3.3 or higher, and I have clang 10.0.0. Is this simply a version check gone wrong in node? Very likely. When FreeBSD went to version 10, lots of sloppy configure scripts then started to assume they were dealing with FreeBSD 1.x, and did *strange* things. I would look for an expression "1*" in the script. :) You are right, Dimitri. I found that there is already an issue for this upstream: https://github.com/nodejs/node/issues/29536 -- Vidar Karlsen ___ freebsd-ports@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-ports To unsubscribe, send any mail to "freebsd-ports-unsubscr...@freebsd.org"
Re: editors/atom: build error on 13.0-CURRENT
On 15 Apr 2020, at 22:14, Vidar Karlsen wrote: > > I'm getting an error building editors/atom on 13.0-CURRENT: >> ===> Building for atom-ide-1.45.0 >> cd /usr/ports/editors/atom/work/node-v10.2.1 [...] >> WARNING: C++ compiler too old, need g++ 4.9.4 or clang++ 3.4.2 (CXX=c++) >> ERROR: Did not find a new enough assembler, install one or build with >> --openssl-no-asm. >> Please refer to BUILDING.md > > Adding --openssl-no-asm to the ./configure line (Makefile line 115) seems to > bypass the problem, and it builds, runs and works fine as far as I can see, > but I don't know if this can affect some of the functionality. > > BUILDING.md says it needs llvm 3.3 or higher, and I have clang 10.0.0. Is > this simply a version check gone wrong in node? Very likely. When FreeBSD went to version 10, lots of sloppy configure scripts then started to assume they were dealing with FreeBSD 1.x, and did *strange* things. I would look for an expression "1*" in the script. :) -Dimitry signature.asc Description: Message signed with OpenPGP
