Re: Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
Thanks Dim.
We noticed there is regression in aarch64 CI.
We will fix it with following your comments and regression in aarch64 CI.
juzhe.zh...@rivai.ai
From: Dimitar Dimitrov
Date: 2024-05-08 23:57
To: 陈硕
CC: 丁乐华; gcc-patches; 钟居哲; 夏晋; vmakarov; richard.sandiford
Subject: Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
On Wed, May 08, 2024 at 11:34:48AM +0800, 陈硕 wrote:
> Hi Dimitar
>
>
> I send a patch just now, modifies accordingly
>
>
> some comments:
>
>
> Nit: Should have two spaces after the dot, per GNU coding style.
> I'd suggest
> to run the contrib/check_GNU_style.py script on your patches.
> Do you mean "star" by "dot", i.e. "/*" should be "/* "?
No, I was referring to the following paragraph from
https://www.gnu.org/prep/standards/standards.html :
"Please put two spaces after the end of a sentence in your comments, ..."
To fix, simply add a second space after the dot, e.g.:
- Like DF_LR, but include tracking subreg liveness. Currently used to
provide
+ Like DF_LR, but include tracking subreg liveness. Currently used to
provide
For reference, here is the output from the style checker:
$ git show | ./contrib/check_GNU_style.py -
=== ERROR type #4: dot, space, space, new sentence (24 error(s)) ===
...
gcc/df-problems.cc:1350:52: Like DF_LR, but include tracking subreg
liveness.█Currently used to provide
>
>
> These names seem a bit too short for global variables. Perhaps tuck
> them in a namespace?
>
> Also, since these must remain empty, shouldn't they be declared as const?
>
> namespace df {
> const bitmap_head empty_bitmap;
> const subregs_live empty_live;
> }
>
>
>
> May be better if "namespace df" contains all DF related code? as a minor
> modification, I add a prefix "df_" to the variables.
> Meanwhile, const seems inapropriate here, since it's returned as normal
> pointer rather than const pointer in some funtions,
>
> change to const would break this return value type check, and a const_cast
> would make the const meanlingless.
>
>
> more details see in the patch
Thanks for considering my suggestion.
Regards,
Dimitar
>
>
> regards
> Shuo
>
>
>
Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
On Wed, May 08, 2024 at 11:34:48AM +0800, 陈硕 wrote:
> Hi Dimitar
>
>
> I send a patch just now, modifies accordingly
>
>
> some comments:
>
>
> Nit: Should have two spaces after the dot, per GNU coding style.
> I'd suggest
> to run the contrib/check_GNU_style.py script on your patches.
> Do you mean "star" by "dot", i.e. "/*" should be "/* "?
No, I was referring to the following paragraph from
https://www.gnu.org/prep/standards/standards.html :
"Please put two spaces after the end of a sentence in your comments, ..."
To fix, simply add a second space after the dot, e.g.:
- Like DF_LR, but include tracking subreg liveness. Currently used to
provide
+ Like DF_LR, but include tracking subreg liveness. Currently used to
provide
For reference, here is the output from the style checker:
$ git show | ./contrib/check_GNU_style.py -
=== ERROR type #4: dot, space, space, new sentence (24 error(s)) ===
...
gcc/df-problems.cc:1350:52: Like DF_LR, but include tracking subreg
liveness.█Currently used to provide
>
>
> These names seem a bit too short for global variables. Perhaps tuck
> them in a namespace?
>
> Also, since these must remain empty, shouldn't they be declared as const?
>
> namespace df {
> const bitmap_head empty_bitmap;
> const subregs_live empty_live;
> }
>
>
>
> May be better if "namespace df" contains all DF related code? as a minor
> modification, I add a prefix "df_" to the variables.
> Meanwhile, const seems inapropriate here, since it's returned as normal
> pointer rather than const pointer in some funtions,
>
> change to const would break this return value type check, and a const_cast
> would make the const meanlingless.
>
>
> more details see in the patch
Thanks for considering my suggestion.
Regards,
Dimitar
>
>
> regards
> Shuo
>
>
>
Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
Hi Dimitar
I send a patch just now, modifies accordingly
some comments:
Nit: Should have two spaces after the dot, per GNU coding style. I'd
suggest
to run the contrib/check_GNU_style.py script on your patches.
Do you mean "star" by "dot", i.e. "/*" should be "/* "?
These names seem a bit too short for global variables. Perhaps tuck
them in a namespace?
Also, since these must remain empty, shouldn't they be declared as const?
namespace df {
const bitmap_head empty_bitmap;
const subregs_live empty_live;
}
May be better if "namespace df" contains all DF related code? as a minor
modification, I add a prefix "df_" to the variables.
Meanwhile, const seems inapropriate here, since it's returned as normal pointer
rather than const pointer in some funtions,
change to const would break this return value type check, and a const_cast
would make the const meanlingless.
more details see in the patch
regards
Shuo
--Original--
From: "DimitarDimitrov"
Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
Hi Dimitar, Thanks for helping to review the code! I will send V3 patch which address these comments. Best, Lehua On 2024/4/26 04:56, Dimitar Dimitrov wrote: On Wed, Apr 24, 2024 at 06:05:03PM +0800, Lehua Ding wrote: This patch add a new DF problem, named DF_LIVE_SUBREG. This problem is extended from the DF_LR problem and support track the subreg liveness of multireg pseudo if these pseudo satisfy the following conditions: 1. the mode size greater than it's REGMODE_NATURAL_SIZE. 2. the reg is used in insns via subreg pattern. The main methods are as follows: 1. split bitmap in/out/def/use fileds to full_in/out/def/use and partial_in/out/def/use. If a pseudo need to be tracked it's subreg liveness, then it is recorded in partial_in/out/def/use fileds. Meantimes, there are range_in/out/def/use fileds which records the live range of the tracked pseudo. 2. in the df_live_subreg_finalize function, we move the tracked pseudo from the partial_in/out/def/use to full_in/out/def/use if the pseudo's live range is full. Hi Lehua, I'm not familiar with LRA, so my comments bellow could be totally off point. Please treat them as mild suggestions. gcc/ChangeLog: * Makefile.in: Add subreg-live-range object file. * df-problems.cc (struct df_live_subreg_problem_data): Private struct for DF_LIVE_SUBREG problem. (df_live_subreg_get_bb_info): getting bb regs in/out data. (get_live_subreg_local_bb_info): getting bb regs use/def data. (multireg_p): checking is the regno a pseudo multireg. (need_track_subreg_p): checking is the regno need to be tracked. (init_range): getting the range of subreg rtx. (remove_subreg_range): removing use data for the reg/subreg rtx. (add_subreg_range): adding def/use data for the reg/subreg rtx. (df_live_subreg_free_bb_info): Free basic block df data. (df_live_subreg_alloc): Allocate and init df data. (df_live_subreg_reset): Reset the live in/out df data. (df_live_subreg_bb_local_compute): Compute basic block df data. (df_live_subreg_local_compute): Compute all basic blocks df data. (df_live_subreg_init): Init the in/out df data. (df_live_subreg_check_result): Assert the full and partial df data. (df_live_subreg_confluence_0): Confluence function for infinite loops. (df_live_subreg_confluence_n): Confluence function for normal edge. (df_live_subreg_transfer_function): Transfer function. (df_live_subreg_finalize): Finalize the all_in/all_out df data. (df_live_subreg_free): Free the df data. (df_live_subreg_top_dump): Dump top df data. (df_live_subreg_bottom_dump): Dump bottom df data. (df_live_subreg_add_problem): Add the DF_LIVE_SUBREG problem. * df.h (enum df_problem_id): Add DF_LIVE_SUBREG. (class subregs_live): Simple decalare. (class df_live_subreg_local_bb_info): New class for full/partial def/use df data. (class df_live_subreg_bb_info): New class for full/partial in/out df data. (df_live_subreg): getting the df_live_subreg data. (df_live_subreg_add_problem): Exported. (df_live_subreg_finalize): Ditto. (df_live_subreg_check_result): Ditto. (multireg_p): Ditto. (init_range): Ditto. (add_subreg_range): Ditto. (remove_subreg_range): Ditto. (df_get_subreg_live_in): Accessor the all_in df data. (df_get_subreg_live_out): Accessor the all_out df data. (df_get_subreg_live_full_in): Accessor the full_in df data. (df_get_subreg_live_full_out): Accessor the full_out df data. (df_get_subreg_live_partial_in): Accessor the partial_in df data. (df_get_subreg_live_partial_out): Accessor the partial_out df data. (df_get_subreg_live_range_in): Accessor the range_in df data. (df_get_subreg_live_range_out): Accessor the range_out df data. * regs.h (get_nblocks): Get the blocks of mode. * sbitmap.cc (bitmap_full_p): sbitmap predicator. (bitmap_same_p): sbitmap predicator. (test_full): test bitmap_full_p. (test_same): test bitmap_same_p. (sbitmap_cc_tests): Add test_full and test_same. * sbitmap.h (bitmap_full_p): Exported. (bitmap_same_p): Ditto. * timevar.def (TV_DF_LIVE_SUBREG): add DF_LIVE_SUBREG timevar. * subreg-live-range.cc: New file. * subreg-live-range.h: New file. --- gcc/Makefile.in | 1 + gcc/df-problems.cc | 855 ++- gcc/df.h | 155 +++ gcc/regs.h | 5 + gcc/sbitmap.cc | 98 + gcc/sbitmap.h| 2 + gcc/subreg-live-range.cc | 53 +++ gcc/subreg-live-range.h | 206 ++ gcc/timevar.def | 1 + 9 files changed, 1375 insertions(+), 1
Re: [PATCH 2/4] df: Add DF_LIVE_SUBREG problem
On Wed, Apr 24, 2024 at 06:05:03PM +0800, Lehua Ding wrote: > This patch add a new DF problem, named DF_LIVE_SUBREG. This problem > is extended from the DF_LR problem and support track the subreg liveness > of multireg pseudo if these pseudo satisfy the following conditions: > > 1. the mode size greater than it's REGMODE_NATURAL_SIZE. > 2. the reg is used in insns via subreg pattern. > > The main methods are as follows: > > 1. split bitmap in/out/def/use fileds to full_in/out/def/use and > partial_in/out/def/use. If a pseudo need to be tracked it's subreg > liveness, then it is recorded in partial_in/out/def/use fileds. > Meantimes, there are range_in/out/def/use fileds which records the live > range of the tracked pseudo. > 2. in the df_live_subreg_finalize function, we move the tracked pseudo from > the partial_in/out/def/use to full_in/out/def/use if the pseudo's live > range is full. Hi Lehua, I'm not familiar with LRA, so my comments bellow could be totally off point. Please treat them as mild suggestions. > > gcc/ChangeLog: > > * Makefile.in: Add subreg-live-range object file. > * df-problems.cc (struct df_live_subreg_problem_data): Private struct > for DF_LIVE_SUBREG problem. > (df_live_subreg_get_bb_info): getting bb regs in/out data. > (get_live_subreg_local_bb_info): getting bb regs use/def data. > (multireg_p): checking is the regno a pseudo multireg. > (need_track_subreg_p): checking is the regno need to be tracked. > (init_range): getting the range of subreg rtx. > (remove_subreg_range): removing use data for the reg/subreg rtx. > (add_subreg_range): adding def/use data for the reg/subreg rtx. > (df_live_subreg_free_bb_info): Free basic block df data. > (df_live_subreg_alloc): Allocate and init df data. > (df_live_subreg_reset): Reset the live in/out df data. > (df_live_subreg_bb_local_compute): Compute basic block df data. > (df_live_subreg_local_compute): Compute all basic blocks df data. > (df_live_subreg_init): Init the in/out df data. > (df_live_subreg_check_result): Assert the full and partial df data. > (df_live_subreg_confluence_0): Confluence function for infinite loops. > (df_live_subreg_confluence_n): Confluence function for normal edge. > (df_live_subreg_transfer_function): Transfer function. > (df_live_subreg_finalize): Finalize the all_in/all_out df data. > (df_live_subreg_free): Free the df data. > (df_live_subreg_top_dump): Dump top df data. > (df_live_subreg_bottom_dump): Dump bottom df data. > (df_live_subreg_add_problem): Add the DF_LIVE_SUBREG problem. > * df.h (enum df_problem_id): Add DF_LIVE_SUBREG. > (class subregs_live): Simple decalare. > (class df_live_subreg_local_bb_info): New class for full/partial def/use > df data. > (class df_live_subreg_bb_info): New class for full/partial in/out > df data. > (df_live_subreg): getting the df_live_subreg data. > (df_live_subreg_add_problem): Exported. > (df_live_subreg_finalize): Ditto. > (df_live_subreg_check_result): Ditto. > (multireg_p): Ditto. > (init_range): Ditto. > (add_subreg_range): Ditto. > (remove_subreg_range): Ditto. > (df_get_subreg_live_in): Accessor the all_in df data. > (df_get_subreg_live_out): Accessor the all_out df data. > (df_get_subreg_live_full_in): Accessor the full_in df data. > (df_get_subreg_live_full_out): Accessor the full_out df data. > (df_get_subreg_live_partial_in): Accessor the partial_in df data. > (df_get_subreg_live_partial_out): Accessor the partial_out df data. > (df_get_subreg_live_range_in): Accessor the range_in df data. > (df_get_subreg_live_range_out): Accessor the range_out df data. > * regs.h (get_nblocks): Get the blocks of mode. > * sbitmap.cc (bitmap_full_p): sbitmap predicator. > (bitmap_same_p): sbitmap predicator. > (test_full): test bitmap_full_p. > (test_same): test bitmap_same_p. > (sbitmap_cc_tests): Add test_full and test_same. > * sbitmap.h (bitmap_full_p): Exported. > (bitmap_same_p): Ditto. > * timevar.def (TV_DF_LIVE_SUBREG): add DF_LIVE_SUBREG timevar. > * subreg-live-range.cc: New file. > * subreg-live-range.h: New file. > --- > gcc/Makefile.in | 1 + > gcc/df-problems.cc | 855 ++- > gcc/df.h | 155 +++ > gcc/regs.h | 5 + > gcc/sbitmap.cc | 98 + > gcc/sbitmap.h| 2 + > gcc/subreg-live-range.cc | 53 +++ > gcc/subreg-live-range.h | 206 ++ > gcc/timevar.def | 1 + > 9 files changed, 1375 insertions(+), 1 deletion(-) > create mode 100644 gcc/subreg-live-range.cc > create mode 100644 gcc/subreg-live-range.h > > diff --git
[PATCH 2/4] df: Add DF_LIVE_SUBREG problem
This patch add a new DF problem, named DF_LIVE_SUBREG. This problem is extended from the DF_LR problem and support track the subreg liveness of multireg pseudo if these pseudo satisfy the following conditions: 1. the mode size greater than it's REGMODE_NATURAL_SIZE. 2. the reg is used in insns via subreg pattern. The main methods are as follows: 1. split bitmap in/out/def/use fileds to full_in/out/def/use and partial_in/out/def/use. If a pseudo need to be tracked it's subreg liveness, then it is recorded in partial_in/out/def/use fileds. Meantimes, there are range_in/out/def/use fileds which records the live range of the tracked pseudo. 2. in the df_live_subreg_finalize function, we move the tracked pseudo from the partial_in/out/def/use to full_in/out/def/use if the pseudo's live range is full. gcc/ChangeLog: * Makefile.in: Add subreg-live-range object file. * df-problems.cc (struct df_live_subreg_problem_data): Private struct for DF_LIVE_SUBREG problem. (df_live_subreg_get_bb_info): getting bb regs in/out data. (get_live_subreg_local_bb_info): getting bb regs use/def data. (multireg_p): checking is the regno a pseudo multireg. (need_track_subreg_p): checking is the regno need to be tracked. (init_range): getting the range of subreg rtx. (remove_subreg_range): removing use data for the reg/subreg rtx. (add_subreg_range): adding def/use data for the reg/subreg rtx. (df_live_subreg_free_bb_info): Free basic block df data. (df_live_subreg_alloc): Allocate and init df data. (df_live_subreg_reset): Reset the live in/out df data. (df_live_subreg_bb_local_compute): Compute basic block df data. (df_live_subreg_local_compute): Compute all basic blocks df data. (df_live_subreg_init): Init the in/out df data. (df_live_subreg_check_result): Assert the full and partial df data. (df_live_subreg_confluence_0): Confluence function for infinite loops. (df_live_subreg_confluence_n): Confluence function for normal edge. (df_live_subreg_transfer_function): Transfer function. (df_live_subreg_finalize): Finalize the all_in/all_out df data. (df_live_subreg_free): Free the df data. (df_live_subreg_top_dump): Dump top df data. (df_live_subreg_bottom_dump): Dump bottom df data. (df_live_subreg_add_problem): Add the DF_LIVE_SUBREG problem. * df.h (enum df_problem_id): Add DF_LIVE_SUBREG. (class subregs_live): Simple decalare. (class df_live_subreg_local_bb_info): New class for full/partial def/use df data. (class df_live_subreg_bb_info): New class for full/partial in/out df data. (df_live_subreg): getting the df_live_subreg data. (df_live_subreg_add_problem): Exported. (df_live_subreg_finalize): Ditto. (df_live_subreg_check_result): Ditto. (multireg_p): Ditto. (init_range): Ditto. (add_subreg_range): Ditto. (remove_subreg_range): Ditto. (df_get_subreg_live_in): Accessor the all_in df data. (df_get_subreg_live_out): Accessor the all_out df data. (df_get_subreg_live_full_in): Accessor the full_in df data. (df_get_subreg_live_full_out): Accessor the full_out df data. (df_get_subreg_live_partial_in): Accessor the partial_in df data. (df_get_subreg_live_partial_out): Accessor the partial_out df data. (df_get_subreg_live_range_in): Accessor the range_in df data. (df_get_subreg_live_range_out): Accessor the range_out df data. * regs.h (get_nblocks): Get the blocks of mode. * sbitmap.cc (bitmap_full_p): sbitmap predicator. (bitmap_same_p): sbitmap predicator. (test_full): test bitmap_full_p. (test_same): test bitmap_same_p. (sbitmap_cc_tests): Add test_full and test_same. * sbitmap.h (bitmap_full_p): Exported. (bitmap_same_p): Ditto. * timevar.def (TV_DF_LIVE_SUBREG): add DF_LIVE_SUBREG timevar. * subreg-live-range.cc: New file. * subreg-live-range.h: New file. --- gcc/Makefile.in | 1 + gcc/df-problems.cc | 855 ++- gcc/df.h | 155 +++ gcc/regs.h | 5 + gcc/sbitmap.cc | 98 + gcc/sbitmap.h| 2 + gcc/subreg-live-range.cc | 53 +++ gcc/subreg-live-range.h | 206 ++ gcc/timevar.def | 1 + 9 files changed, 1375 insertions(+), 1 deletion(-) create mode 100644 gcc/subreg-live-range.cc create mode 100644 gcc/subreg-live-range.h diff --git a/gcc/Makefile.in b/gcc/Makefile.in index a74761b7ab3..e195238f6ab 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -1684,6 +1684,7 @@ OBJS = \ store-motion.o \ streamer-hooks.o \ stringpool.o \ + subreg-live-range.o \
[PATCH 2/4] df: Add DF_LIVE_SUBREG problem
This patch add a new DF problem, named DF_LIVE_SUBREG. This problem is extended from the DF_LR problem and support track the subreg liveness of multireg pseudo if these pseudo satisfy the following conditions: 1. the mode size greater than it's REGMODE_NATURAL_SIZE. 2. the reg is used in insns via subreg pattern. The main methods are as follows: 1. split bitmap in/out/def/use fileds to full_in/out/def/use and partial_in/out/def/use. If a pseudo need to be tracked it's subreg liveness, then it is recorded in partial_in/out/def/use fileds. Meantimes, there are range_in/out/def/use fileds which records the live range of the tracked pseudo. 2. in the df_live_subreg_finalize function, we move the tracked pseudo from the partial_in/out/def/use to full_in/out/def/use if the pseudo's live range is full. gcc/ChangeLog: * Makefile.in: Add subreg-live-range object file. * df-problems.cc (struct df_live_subreg_problem_data): Private struct for DF_LIVE_SUBREG problem. (df_live_subreg_get_bb_info): getting bb regs in/out data. (get_live_subreg_local_bb_info): getting bb regs use/def data. (multireg_p): checking is the regno a pseudo multireg. (need_track_subreg_p): checking is the regno need to be tracked. (init_range): getting the range of subreg rtx. (remove_subreg_range): removing use data for the reg/subreg rtx. (add_subreg_range): adding def/use data for the reg/subreg rtx. (df_live_subreg_free_bb_info): Free basic block df data. (df_live_subreg_alloc): Allocate and init df data. (df_live_subreg_reset): Reset the live in/out df data. (df_live_subreg_bb_local_compute): Compute basic block df data. (df_live_subreg_local_compute): Compute all basic blocks df data. (df_live_subreg_init): Init the in/out df data. (df_live_subreg_check_result): Assert the full and partial df data. (df_live_subreg_confluence_0): Confluence function for infinite loops. (df_live_subreg_confluence_n): Confluence function for normal edge. (df_live_subreg_transfer_function): Transfer function. (df_live_subreg_finalize): Finalize the all_in/all_out df data. (df_live_subreg_free): Free the df data. (df_live_subreg_top_dump): Dump top df data. (df_live_subreg_bottom_dump): Dump bottom df data. (df_live_subreg_add_problem): Add the DF_LIVE_SUBREG problem. * df.h (enum df_problem_id): Add DF_LIVE_SUBREG. (class subregs_live): Simple decalare. (class df_live_subreg_local_bb_info): New class for full/partial def/use df data. (class df_live_subreg_bb_info): New class for full/partial in/out df data. (df_live_subreg): getting the df_live_subreg data. (df_live_subreg_add_problem): Exported. (df_live_subreg_finalize): Ditto. (df_live_subreg_check_result): Ditto. (multireg_p): Ditto. (init_range): Ditto. (add_subreg_range): Ditto. (remove_subreg_range): Ditto. (df_get_subreg_live_in): Accessor the all_in df data. (df_get_subreg_live_out): Accessor the all_out df data. (df_get_subreg_live_full_in): Accessor the full_in df data. (df_get_subreg_live_full_out): Accessor the full_out df data. (df_get_subreg_live_partial_in): Accessor the partial_in df data. (df_get_subreg_live_partial_out): Accessor the partial_out df data. (df_get_subreg_live_range_in): Accessor the range_in df data. (df_get_subreg_live_range_out): Accessor the range_out df data. * regs.h (get_nblocks): Get the blocks of mode. * sbitmap.cc (bitmap_full_p): sbitmap predicator. (bitmap_same_p): sbitmap predicator. (test_full): test bitmap_full_p. (test_same): test bitmap_same_p. (sbitmap_cc_tests): Add test_full and test_same. * sbitmap.h (bitmap_full_p): Exported. (bitmap_same_p): Ditto. * timevar.def (TV_DF_LIVE_SUBREG): add DF_LIVE_SUBREG timevar. * subreg-live-range.cc: New file. * subreg-live-range.h: New file. --- gcc/Makefile.in | 1 + gcc/df-problems.cc | 855 ++- gcc/df.h | 155 +++ gcc/regs.h | 5 + gcc/sbitmap.cc | 98 + gcc/sbitmap.h| 2 + gcc/subreg-live-range.cc | 53 +++ gcc/subreg-live-range.h | 206 ++ gcc/timevar.def | 1 + 9 files changed, 1375 insertions(+), 1 deletion(-) create mode 100644 gcc/subreg-live-range.cc create mode 100644 gcc/subreg-live-range.h diff --git a/gcc/Makefile.in b/gcc/Makefile.in index 95caa54a52b..c30ea333736 100644 --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -1684,6 +1684,7 @@ OBJS = \ store-motion.o \ streamer-hooks.o \ stringpool.o \ + subreg-live-range.o \
