Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-30 Thread Wenli Zhang
+1

I checked:

- Include the word incubating in the release file name.
- Include an ASF LICENSE and NOTICE file.
- Have valid checksums or signatures.
- Be placed in the correct place on the ASF’s infrastructure.
- Have a KEYS file to validate the release.



On 2023/05/25 06:00:20 He Sun wrote:
> Hi all,
> 
> I am pleased to be calling this vote for the release of
> Apache Teaclave (incubating) 0.5.1 (release candidate 2).
> 
> The Apache Teaclave (incubating) community has voted and approved the
> release. The result thread is 
> https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
> 
> The release candidate to be voted over is available at:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
> 
> The artifacts signed with PGP key [777A1FBA5762313CD86EC2727144C76533763CD9] 
> in the keys file:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
> 
> The Git commit for this release is:
> - 
> https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
> 
> The release note is available in:
> - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
> 
> Build guide and get started instructions can be found at:
> - 
> https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
> 
> The short version of building Teaclave from the source tarball:
> 
> ```
> $ wget 
> https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> apache-teaclave-0.5.1-rc.2-incubating
> $ # Instructions to verify the source tar:
> https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
> 
> $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> bash -c ". /root/.cargo/env && \
> . /opt/sgxsdk/environment && \
> mkdir -p build && cd build && \
> cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> make -j"
> ```
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> 
> Best,
> 
> He Sun
> Apache Teaclave (incubating)
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-30 Thread Wenli Zhang
+1

Checked:

- Include the word incubating in the release file name.
- Include an ASF LICENSE and NOTICE file.
- Have valid checksums or signatures.
- Be placed in the correct place on the ASF’s infrastructure.
- Have a KEYS file to validate the release.

On 2023/05/25 06:00:20 He Sun wrote:
> Hi all,
> 
> I am pleased to be calling this vote for the release of
> Apache Teaclave (incubating) 0.5.1 (release candidate 2).
> 
> The Apache Teaclave (incubating) community has voted and approved the
> release. The result thread is 
> https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
> 
> The release candidate to be voted over is available at:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
> 
> The artifacts signed with PGP key [777A1FBA5762313CD86EC2727144C76533763CD9] 
> in the keys file:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
> 
> The Git commit for this release is:
> - 
> https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
> 
> The release note is available in:
> - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
> 
> Build guide and get started instructions can be found at:
> - 
> https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
> 
> The short version of building Teaclave from the source tarball:
> 
> ```
> $ wget 
> https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> apache-teaclave-0.5.1-rc.2-incubating
> $ # Instructions to verify the source tar:
> https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
> 
> $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> bash -c ". /root/.cargo/env && \
> . /opt/sgxsdk/environment && \
> mkdir -p build && cd build && \
> cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> make -j"
> ```
> 
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
> 
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
> 
> 
> Best,
> 
> He Sun
> Apache Teaclave (incubating)
> 
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
> 
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-30 Thread He Sun
Hi Felix,

Besides, the `KEYS` conflict will be solved in the next release.

Regards,
He

On 2023/05/30 07:14:28 Felix Cheung wrote:
> +1
> 
> - incubating in name
> - signature and hash are fine
> 
> it looks like there is a conflict between KEYS (file) and keys (directory):
> $ tar xzf apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> apache-teaclave-0.5.1-rc.2-incubating/KEYS: Can't replace existing
> directory with non-directory
> tar: Error exit delayed from previous errors.
> 
> - DISCLAIMER is fine
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - source files have ASF headers?
> 
> it looks like a lot of files are "external"? they do not have ASF header
> /common/rusty_leveldb_sgx/*
> /third_party/wasm-micro-runtime/*
> /third_party/rust-sgx-sdk/*
> 
> what is the plan for those? do they have to be included in the source
> release?
> 
> did not compile from source
> 
> 
> 
> On Fri, May 26, 2023 at 10:26 PM Gordon  wrote:
> 
> > +1, thanks.
> >
> > On Wed, May 24, 2023 at 11:00 PM He Sun  wrote:
> >
> > > Hi all,
> > >
> > > I am pleased to be calling this vote for the release of
> > > Apache Teaclave (incubating) 0.5.1 (release candidate 2).
> > >
> > > The Apache Teaclave (incubating) community has voted and approved the
> > > release. The result thread is
> > > https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
> > >
> > > The release candidate to be voted over is available at:
> > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
> > >
> > > The artifacts signed with PGP key
> > > [777A1FBA5762313CD86EC2727144C76533763CD9] in the keys file:
> > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
> > >
> > > The Git commit for this release is:
> > > -
> > >
> > https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
> > >
> > > The release note is available in:
> > > - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
> > >
> > > Build guide and get started instructions can be found at:
> > > -
> > >
> > https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
> > >
> > > The short version of building Teaclave from the source tarball:
> > >
> > > ```
> > > $ wget
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> > > $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> > > apache-teaclave-0.5.1-rc.2-incubating
> > > $ # Instructions to verify the source tar:
> > > https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
> > >
> > > $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> > > -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> > > bash -c ". /root/.cargo/env && \
> > > . /opt/sgxsdk/environment && \
> > > mkdir -p build && cd build && \
> > > cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> > > make -j"
> > > ```
> > >
> > > The vote will be open for at least 72 hours or until the necessary number
> > > of votes are reached.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Best,
> > >
> > > He Sun
> > > Apache Teaclave (incubating)
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-30 Thread He Sun
Hi Felix,

First time to hear from you. Thank you.

Those "external"  files are actually from third-party and their licenses are 
included in the `LICENSE` file. Please check it.

Wait for more advice and comments from you in the future about all aspects of 
Teacalve. 

Thanks,
He

On 2023/05/30 07:14:28 Felix Cheung wrote:
> +1
> 
> - incubating in name
> - signature and hash are fine
> 
> it looks like there is a conflict between KEYS (file) and keys (directory):
> $ tar xzf apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> apache-teaclave-0.5.1-rc.2-incubating/KEYS: Can't replace existing
> directory with non-directory
> tar: Error exit delayed from previous errors.
> 
> - DISCLAIMER is fine
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - source files have ASF headers?
> 
> it looks like a lot of files are "external"? they do not have ASF header
> /common/rusty_leveldb_sgx/*
> /third_party/wasm-micro-runtime/*
> /third_party/rust-sgx-sdk/*
> 
> what is the plan for those? do they have to be included in the source
> release?
> 
> did not compile from source
> 
> 
> 
> On Fri, May 26, 2023 at 10:26 PM Gordon  wrote:
> 
> > +1, thanks.
> >
> > On Wed, May 24, 2023 at 11:00 PM He Sun  wrote:
> >
> > > Hi all,
> > >
> > > I am pleased to be calling this vote for the release of
> > > Apache Teaclave (incubating) 0.5.1 (release candidate 2).
> > >
> > > The Apache Teaclave (incubating) community has voted and approved the
> > > release. The result thread is
> > > https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
> > >
> > > The release candidate to be voted over is available at:
> > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
> > >
> > > The artifacts signed with PGP key
> > > [777A1FBA5762313CD86EC2727144C76533763CD9] in the keys file:
> > > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
> > >
> > > The Git commit for this release is:
> > > -
> > >
> > https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
> > >
> > > The release note is available in:
> > > - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
> > >
> > > Build guide and get started instructions can be found at:
> > > -
> > >
> > https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
> > >
> > > The short version of building Teaclave from the source tarball:
> > >
> > > ```
> > > $ wget
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> > > $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> > > apache-teaclave-0.5.1-rc.2-incubating
> > > $ # Instructions to verify the source tar:
> > > https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
> > >
> > > $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> > > -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> > > bash -c ". /root/.cargo/env && \
> > > . /opt/sgxsdk/environment && \
> > > mkdir -p build && cd build && \
> > > cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> > > make -j"
> > > ```
> > >
> > > The vote will be open for at least 72 hours or until the necessary number
> > > of votes are reached.
> > >
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > >
> > > Best,
> > >
> > > He Sun
> > > Apache Teaclave (incubating)
> > >
> > > -
> > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > > For additional commands, e-mail: general-h...@incubator.apache.org
> > >
> > >
> >
> 

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org



Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-30 Thread Felix Cheung
+1

- incubating in name
- signature and hash are fine

it looks like there is a conflict between KEYS (file) and keys (directory):
$ tar xzf apache-teaclave-0.5.1-rc.2-incubating.tar.gz
apache-teaclave-0.5.1-rc.2-incubating/KEYS: Can't replace existing
directory with non-directory
tar: Error exit delayed from previous errors.

- DISCLAIMER is fine
- LICENSE and NOTICE are fine
- No unexpected binary files
- source files have ASF headers?

it looks like a lot of files are "external"? they do not have ASF header
/common/rusty_leveldb_sgx/*
/third_party/wasm-micro-runtime/*
/third_party/rust-sgx-sdk/*

what is the plan for those? do they have to be included in the source
release?

did not compile from source



On Fri, May 26, 2023 at 10:26 PM Gordon  wrote:

> +1, thanks.
>
> On Wed, May 24, 2023 at 11:00 PM He Sun  wrote:
>
> > Hi all,
> >
> > I am pleased to be calling this vote for the release of
> > Apache Teaclave (incubating) 0.5.1 (release candidate 2).
> >
> > The Apache Teaclave (incubating) community has voted and approved the
> > release. The result thread is
> > https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
> >
> > The release candidate to be voted over is available at:
> > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
> >
> > The artifacts signed with PGP key
> > [777A1FBA5762313CD86EC2727144C76533763CD9] in the keys file:
> > - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
> >
> > The Git commit for this release is:
> > -
> >
> https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
> >
> > The release note is available in:
> > - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
> >
> > Build guide and get started instructions can be found at:
> > -
> >
> https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
> >
> > The short version of building Teaclave from the source tarball:
> >
> > ```
> > $ wget
> >
> https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> > $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> > apache-teaclave-0.5.1-rc.2-incubating
> > $ # Instructions to verify the source tar:
> > https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
> >
> > $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> > -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> > bash -c ". /root/.cargo/env && \
> > . /opt/sgxsdk/environment && \
> > mkdir -p build && cd build && \
> > cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> > make -j"
> > ```
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> >
> > Best,
> >
> > He Sun
> > Apache Teaclave (incubating)
> >
> > -
> > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> > For additional commands, e-mail: general-h...@incubator.apache.org
> >
> >
>


Re: [VOTE] Release Apache Teaclave (incubating) v0.5.1-rc.2

2023-05-26 Thread Gordon
+1, thanks.

On Wed, May 24, 2023 at 11:00 PM He Sun  wrote:

> Hi all,
>
> I am pleased to be calling this vote for the release of
> Apache Teaclave (incubating) 0.5.1 (release candidate 2).
>
> The Apache Teaclave (incubating) community has voted and approved the
> release. The result thread is
> https://lists.apache.org/thread/qt3z2m4yvghxtvw3gwyorj67px8okjqy
>
> The release candidate to be voted over is available at:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/
>
> The artifacts signed with PGP key
> [777A1FBA5762313CD86EC2727144C76533763CD9] in the keys file:
> - https://dist.apache.org/repos/dist/dev/incubator/teaclave/KEYS
>
> The Git commit for this release is:
> -
> https://github.com/apache/incubator-teaclave/commit/39d575adf291431f2f9656057676cdc55d89f96f
>
> The release note is available in:
> - https://github.com/apache/incubator-teaclave/releases/tag/v0.5.1-rc.2
>
> Build guide and get started instructions can be found at:
> -
> https://github.com/apache/incubator-teaclave/blob/v0.5.1-rc.2/docs/my-first-function.md
>
> The short version of building Teaclave from the source tarball:
>
> ```
> $ wget
> https://dist.apache.org/repos/dist/dev/incubator/teaclave/0.5.1-rc.2/apache-teaclave-0.5.1-rc.2-incubating.tar.gz
> $ tar zxvf apache-teaclave-0.5.1-rc.2-incubating.tar.gz && cd \
> apache-teaclave-0.5.1-rc.2-incubating
> $ # Instructions to verify the source tar:
> https://teaclave.apache.org/download/#verify-the-integrity-of-the-files
>
> $ docker run --rm -v $(pwd):/teaclave -w /teaclave \
> -it teaclave/teaclave-build-ubuntu-2004-sgx-2.17.1:0.2.0 \
> bash -c ". /root/.cargo/env && \
> . /opt/sgxsdk/environment && \
> mkdir -p build && cd build && \
> cmake -DTEST_MODE=ON -DSGX_SIM_MODE=ON -DGIT_SUBMODULE=OFF .. && \
> make -j"
> ```
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
>
> Best,
>
> He Sun
> Apache Teaclave (incubating)
>
> -
> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
> For additional commands, e-mail: general-h...@incubator.apache.org
>
>