Re: [Gluster-devel] Problem with smoke, regression ordering
On 05/07/2014, at 5:23 PM, Pranith Kumar Karampuri wrote: hi Justin, If the regression results complete before the smoke test then 'green-tick-mark' is over-written and people don't realize that the regression succeeded by a simple glance at the list of patches. Can we do anything about it? Yeah. At the moment, it's caused by people manually starting the old regression job on the build.gluster.org server. The build.gluster.org server can only run one thing at a time. Everything else queues up. When the old regression test job runs, everything else is blocked until it finishes. If there are a few regression tests lined up (or it hangs), then it can take hours until the smoke and rpm building jobs run. There are a few ways we could address this: * Adjust the smoke test job so it runs on the Rackspace slaves Hopefully not hard. But not sure. We can try it out. * Change the triggered regression test, so it doesn't start automatically like this. * We may be able to get a successful smoke test to automatically trigger the regression run. Ben Turner would probably know how to make that work. * Niels has suggested we might want to have the regression test run when a +1 or +2 vote is given instead. I'm not really sure about this, because I wonder if it's more useful to automatically test everything. eg catching breakage early, before reviews are done I'm not strongly against it either though. ;) Personally, I reckon we should have a discussion on gluster-devel about this. There might be really good + / - for each, so a clear decision can be made. And there may be other better ideas too. What're your thoughts on this stuff? Regards and best wishes, Justin Clift -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Problem with smoke, regression ordering
On 06/07/2014, at 8:03 AM, Justin Clift wrote: snip There are a few ways we could address this: * Adjust the smoke test job so it runs on the Rackspace slaves Hopefully not hard. But not sure. We can try it out. * Change the triggered regression test, so it doesn't start automatically like this. * We could also disable the old regression job, so it doesn't run on build.gluster.org. Would stop the queuing problems. ;) + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] Problem with smoke, regression ordering
On 06/07/2014, at 8:24 AM, Pranith Kumar Karampuri wrote: On 07/06/2014 12:36 PM, Justin Clift wrote: snip * We could also disable the old regression job, so it doesn't run on build.gluster.org. This only reduces the race window. Doesn't fix the problem ;-). But I see your point. It is definitely better to not use build.gluster.org for regressions. k, just disabled it. I can look into making the smoke jobs run in Rackspace too (during the week). :) + Justin -- GlusterFS - http://www.gluster.org An open source, distributed file system scaling to several petabytes, and handling thousands of clients. My personal twitter: twitter.com/realjustinclift ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
[Gluster-devel] regarding message for '-1' on gerrit
hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this message? Pranith ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] regarding message for '-1' on gerrit
On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote: hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this message? The message can be changed. What would everyone like to see as appropriate messages accompanying values '-1' and '-2'? -Vijay ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
Re: [Gluster-devel] regarding message for '-1' on gerrit
On 07/06/2014 11:05 PM, Vijay Bellur wrote: On 07/06/2014 07:47 PM, Pranith Kumar Karampuri wrote: hi Justin/Vijay, I always felt '-1' saying 'I prefer you didn't submit this' is a bit harsh. Most of the times all it means is 'Need some more changes' Do you think we can change this message? The message can be changed. What would everyone like to see as appropriate messages accompanying values '-1' and '-2'? For '-1' - 'Please address the comments and Resubmit.' I am not sure about '-2' Pranith -Vijay ___ Gluster-devel mailing list Gluster-devel@gluster.org http://supercolony.gluster.org/mailman/listinfo/gluster-devel
