[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #9 from Niels de Vos --- (In reply to Shyamsundar from comment #7) > This is more for fly-by and/or folks who want to add reviewers clearly to > call to attention the patch submitted. Ideally this should not be needed. However I agree that many maintainers/peers are not pro-active in reviewing changes that get posted. It helps a lot when adding people to review changes, and automating it might be useful. Is this only applicable to the glusterfs project in Gerrit? I wonder how/if the maintainers of the other projects watch out for new changes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f1rkx7zwlR=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #8 from Nigel Babu --- Alright, so let me put down Shyam's suggestion into a good infra action: Run a job in smoke which checks if the maintainers for the component are already added. If yes, do nothing. If not, add them. If a patch spans more than one component, we will have to do some magic. I'm going to try to do something that works for when it's a single component and then we can optimize further as we go along. Does this sound like a good plan of action? It's not a complete solution but helps drive by contributors. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y5wLCugIKH=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1636455] gluster bot is not changing the status of bug
https://bugzilla.redhat.com/show_bug.cgi?id=1636455 Nigel Babu changed: What|Removed |Added Status|NEW |ASSIGNED CC||nig...@redhat.com Assignee|b...@gluster.org|nig...@redhat.com --- Comment #1 from Nigel Babu --- Huh, I seemed to have missed this completely in the python script. I've reverted back to the old bash script. I'm going to add this and the external bug tracker review in one go. Tracking for sprint 5. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Mb0DGqH8S7=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1636455] New: gluster bot is not changing the status of bug
https://bugzilla.redhat.com/show_bug.cgi?id=1636455 Bug ID: 1636455 Summary: gluster bot is not changing the status of bug Product: GlusterFS Version: mainline Component: project-infrastructure Assignee: b...@gluster.org Reporter: srako...@redhat.com CC: b...@gluster.org, gluster-infra@gluster.org Description of problem: When we post a patch for review in gerrit, gluster bot will update the associate BZ with the details patch. But gluster bot is not changing the status of the bug. Even though the patch is posted, the bug is in assigned state only. After merging patch also, gluster bot is updating the BZ with a comment saying "this commit has merged", but status is not changed to Modified. Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. 2. 3. Actual results: status of bug is never changed Expected results: Bug status should be changed accordingly. Additional info: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=aWuUC8lxVB=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #7 from Shyamsundar --- (In reply to Nigel Babu from comment #5) > I'm going to be a bit skeptical here. If someone doesn't notice their first > email notification, would an additional email actually help? > > Our recommendation is that reviewers subscribe to their area of interest via > Gerrit directly. The system is built to be an opt-in rather than one that > does the whining for you. This is more for fly-by and/or folks who want to add reviewers clearly to call to attention the patch submitted. Often I read the MAINTAINERS file and add reviewers based on the area of ownership, if we had this auto addition it makes life easier for patch submitter. So in short, my thought is to have this not for the maintainers/owners, but for submitter as they now know in gerrit who should look at the patch or at least that it is passed onto someone's queue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1D1Geus5NP=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1564149] Agree upon a coding standard, and automate check for this in smoke
https://bugzilla.redhat.com/show_bug.cgi?id=1564149 --- Comment #43 from Worker Ant --- REVIEW: https://review.gluster.org/21193 (xlators/experimental: move template files to '.c.in' type) posted (#5) for review on master by Xavi Hernandez -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=srBiAHHbSB=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 Niels de Vos changed: What|Removed |Added CC||nde...@redhat.com --- Comment #6 from Niels de Vos --- (In reply to Nigel Babu from comment #5) > Our recommendation is that reviewers subscribe to their area of interest via > Gerrit directly. The system is built to be an opt-in rather than one that > does the whining for you. This is something that we really need to be following more closely. I suspect that some of the maintainers and peers are not very aware of the guidelines we decided on long ago. When we onboard new maintainers/peers, they should have a (ideally face-to-face) discussion with an active maintainer about it. This includes setting up notification for patches as described in the doc. https://docs.gluster.org/en/latest/Contributors-Guide/Guidelines-For-Maintainers/ And probably also https://github.com/gluster/glusterdocs/blob/master/docs/Developer-guide/Bugzilla%20Notifications.md (not sure why I can not find it on docs.gluster.org). Is there a similar doc for GitHub issues? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YM1iBSTdov=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1594857] Make smoke runs detect test cases added to patch
https://bugzilla.redhat.com/show_bug.cgi?id=1594857 Nigel Babu changed: What|Removed |Added Status|NEW |ASSIGNED CC||nig...@redhat.com Assignee|b...@gluster.org|nig...@redhat.com --- Comment #2 from Nigel Babu --- Getting smoke to fail if there's no .t file is not hard. But there are a lot of patches where we're fixing Coverity or static analysis failures where this will be more nuisance than useful. Should this be yet another flag like Spec Added? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Fij2eKzWwo=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1627718] freebsd-smoke jobs failing with nospace left error
https://bugzilla.redhat.com/show_bug.cgi?id=1627718 Nigel Babu changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2018-10-05 02:19:43 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=N0EoIrltJL=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1627611] bugzilla hook of status change misbehaved?
https://bugzilla.redhat.com/show_bug.cgi?id=1627611 Nigel Babu changed: What|Removed |Added Status|POST|CLOSED CC||nig...@redhat.com Resolution|--- |CURRENTRELEASE Last Closed||2018-10-05 02:19:22 --- Comment #2 from Nigel Babu --- Fixed in https://review.gluster.org/c/build-jobs/+/21323 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nWRnvX6dFl=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1600963] get the failed test details into gerrit output itself
https://bugzilla.redhat.com/show_bug.cgi?id=1600963 Nigel Babu changed: What|Removed |Added Status|POST|CLOSED CC||nig...@redhat.com Resolution|--- |CURRENTRELEASE Last Closed||2018-10-05 02:18:52 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U6NAXn35Ya=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1564115] need option 'run brick-mux-tests' in reviews
https://bugzilla.redhat.com/show_bug.cgi?id=1564115 Nigel Babu changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2018-10-05 02:18:41 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1XYdK37kLi=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
