[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Worker Ant changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |UPSTREAM Last Closed||2020-03-12 12:52:47 --- Comment #8 from Worker Ant --- This bug is moved to https://github.com/gluster/project-infrastructure/issues/29, and will be tracked there from now on. Visit GitHub issues URL for further details -- You are receiving this mail because: You are on the CC list for the bug. ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Amar Tumballi changed: What|Removed |Added Priority|unspecified |low Status|ASSIGNED|NEW Severity|high|low -- You are receiving this mail because: You are on the CC list for the bug. ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Nigel Babu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|b...@gluster.org|nig...@redhat.com --- Comment #6 from Nigel Babu --- Whoops, did not assign this to myself before changing status. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bNwPg32RWt=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Amar Tumballi changed: What|Removed |Added Status|ASSIGNED|NEW -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GerpiXGkLd=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 --- Comment #4 from Nigel Babu --- So re: python3 validation. I ran pylint --py3k across the codebase today and it showed me zero errors. However, running 2to3 for our python files shows me a lot of dict.iteritems() which should be dict.items() in python3 (Kaleb has a patch to fix them already). This still doesn't catch more subtler bugs like python's division operator changing behavior in python3 python2 5 / 2 = 2 python3 5 / 2 = 2.5 2to3 doesn't catch this change. In essence, we can add automation, but we warned that the automation passing does not actually mean that we're 100% in the clear with regard to python3 support. That will need some in-depth testing and there's no way around that. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MwYIvjZah6=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Aravinda VK changed: What|Removed |Added CC||avish...@redhat.com --- Comment #3 from Aravinda VK --- pep8 issues can be fixed by using `autopep8` tool, I will work on it and send patch. pylint gives lot of warnings related to variable naming style, we can ignore those errors. Also pylint errors are mostly about best practices and code suggestions. I feel we should defer pylint voting since it involves lot of code changes. We can use `flake8` for now to validate pep8, unused variables, imports etc. https://github.com/gluster/libgfapi-python/blob/master/tox.ini -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AWplgKEyLY=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 --- Comment #2 from Nigel Babu --- pep8 issues: 3K pylint issues: 12K pylint python3 issues: 370 It's not worth running a CI unless we can fix them or tweak the config so we care about the right things. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WF880BSPiI=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file
https://bugzilla.redhat.com/show_bug.cgi?id=1584992 Nigel Babu changed: What|Removed |Added CC||nig...@redhat.com --- Comment #1 from Nigel Babu --- Okay, so this can be split into multiple pieces * Making sure the code is pep8 compliant. * Making sure the code is pylint compliant. * Making sure the code is python3 complaint (pylint can do this). All of these tests can only be voting jobs if we can show that they pass now. Are the current maintainers of these modules willing to spend some time fixing up all the errors in the next few weeks? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qnNEwamdxf=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
