[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 Worker Ant changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |UPSTREAM Last Closed||2020-03-12 12:53:05 --- Comment #11 from Worker Ant --- This bug is moved to https://github.com/gluster/project-infrastructure/issues/30, and will be tracked there from now on. Visit GitHub issues URL for further details -- You are receiving this mail because: You are on the CC list for the bug. ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 Amar Tumballi changed: What|Removed |Added Priority|unspecified |low Status|ASSIGNED|NEW Severity|high|low -- You are receiving this mail because: You are on the CC list for the bug. ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 PnT Account Manager changed: What|Removed |Added Assignee|nig...@redhat.com |b...@gluster.org -- You are receiving this mail because: You are on the CC list for the bug. ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #9 from Niels de Vos --- (In reply to Shyamsundar from comment #7) > This is more for fly-by and/or folks who want to add reviewers clearly to > call to attention the patch submitted. Ideally this should not be needed. However I agree that many maintainers/peers are not pro-active in reviewing changes that get posted. It helps a lot when adding people to review changes, and automating it might be useful. Is this only applicable to the glusterfs project in Gerrit? I wonder how/if the maintainers of the other projects watch out for new changes. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=f1rkx7zwlR=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] Need automatic inclusion of few reviewers to a given patch
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #8 from Nigel Babu --- Alright, so let me put down Shyam's suggestion into a good infra action: Run a job in smoke which checks if the maintainers for the component are already added. If yes, do nothing. If not, add them. If a patch spans more than one component, we will have to do some magic. I'm going to try to do something that works for when it's a single component and then we can optimize further as we go along. Does this sound like a good plan of action? It's not a complete solution but helps drive by contributors. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=y5wLCugIKH=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #7 from Shyamsundar --- (In reply to Nigel Babu from comment #5) > I'm going to be a bit skeptical here. If someone doesn't notice their first > email notification, would an additional email actually help? > > Our recommendation is that reviewers subscribe to their area of interest via > Gerrit directly. The system is built to be an opt-in rather than one that > does the whining for you. This is more for fly-by and/or folks who want to add reviewers clearly to call to attention the patch submitted. Often I read the MAINTAINERS file and add reviewers based on the area of ownership, if we had this auto addition it makes life easier for patch submitter. So in short, my thought is to have this not for the maintainers/owners, but for submitter as they now know in gerrit who should look at the patch or at least that it is passed onto someone's queue. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1D1Geus5NP=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 Niels de Vos changed: What|Removed |Added CC||nde...@redhat.com --- Comment #6 from Niels de Vos --- (In reply to Nigel Babu from comment #5) > Our recommendation is that reviewers subscribe to their area of interest via > Gerrit directly. The system is built to be an opt-in rather than one that > does the whining for you. This is something that we really need to be following more closely. I suspect that some of the maintainers and peers are not very aware of the guidelines we decided on long ago. When we onboard new maintainers/peers, they should have a (ideally face-to-face) discussion with an active maintainer about it. This includes setting up notification for patches as described in the doc. https://docs.gluster.org/en/latest/Contributors-Guide/Guidelines-For-Maintainers/ And probably also https://github.com/gluster/glusterdocs/blob/master/docs/Developer-guide/Bugzilla%20Notifications.md (not sure why I can not find it on docs.gluster.org). Is there a similar doc for GitHub issues? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YM1iBSTdov=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org https://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #4 from Shyamsundar --- (In reply to Niels de Vos from comment #3) > If reviewers are added automatically, but still no action is taken after ~2 > weeks, it may make sense to send an email with some details about the > proposed change to the maintainers mailing list. Yes agree, the 2 week (or time based) reminder still applies. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c6pwCBSPwY=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #3 from Niels de Vos --- If reviewers are added automatically, but still no action is taken after ~2 weeks, it may make sense to send an email with some details about the proposed change to the maintainers mailing list. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=haUu6H7pNS=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #2 from Shyamsundar --- My thoughts: Let's not do it after 2 weeks, let it happen as the review is posted. Also, let's add MAINTAINERS as per their areas of responsibility, that way a patch does not get 20 reviewers, but rather 2-4 reviewers as the case maybe. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AUzZqSBlVM=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
[Gluster-infra] [Bug 1584998] need automatic inclusion of few reviewers to a given patch ( after 2 weeks)
https://bugzilla.redhat.com/show_bug.cgi?id=1584998 --- Comment #1 from Amar Tumballi --- Notice that this has a problem that we can get into infinite loop of warning people every 2weeks of inactivity, but never reaching 90days. Hence we need a mechanism to identify the patches only once, ie, for the first time. After that, it should wait for 90days, and get abandon'd. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=X2ggtzBQr5=cc_unsubscribe ___ Gluster-infra mailing list Gluster-infra@gluster.org http://lists.gluster.org/mailman/listinfo/gluster-infra
