Re: make fails on master
On Jun 7, 2015, at 12:38 PM, Derek Atkins de...@ihtfp.com wrote: On Sun, June 7, 2015 3:02 pm, John Ralls wrote: Alex, Turns out that for some flavors of GCC -std=gnu99 is required for strdup to be provided. I’d made the default c99, which in those cases doesn’t support it, hence the error. Fixed and pushed. Why are we using strdup() and not g_strdup()? Oversight? It’s used in several places. The earliest I found was a5d4c7cf from 2004. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: make fails on master
John, Thanks. I can confirm that both make and make-clean now work on both F20 F21. Regards, Alex On Sun, Jun 7, 2015 at 12:38 PM, Derek Atkins de...@ihtfp.com wrote: On Sun, June 7, 2015 3:02 pm, John Ralls wrote: Alex, Turns out that for some flavors of GCC -std=gnu99 is required for strdup to be provided. I’d made the default c99, which in those cases doesn’t support it, hence the error. Fixed and pushed. Why are we using strdup() and not g_strdup()? Regards, John Ralls -derek -- Derek Atkins 617-623-3745 de...@ihtfp.com www.ihtfp.com Computer and Internet Security Consultant ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: make fails on master
On Jun 6, 2015, at 5:41 PM, Alex Aycinena alex.aycin...@gmail.com wrote: Hello, I've been away for a couple of weeks and upon return, pulled many changes on the master branch. Make fails with: /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c: In function 'gfec_catcher': /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:60:9: error: implicit declaration of function 'strdup' [-Werror=implicit-function-declaration] *(char**)data = strdup(Guile error: Too many recursions in error catch handler.); ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:60:23: error: assignment makes pointer from integer without a cast [-Werror] *(char**)data = strdup(Guile error: Too many recursions in error catch handler.); ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:79:13: warning: 'scm_internal_stack_catch' is deprecated (declared at /usr/include/guile/2.0/libguile/deprecated.h:648) [-Wdeprecated-declarations] scm_internal_stack_catch(SCM_BOOL_T, ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:99:23: error: assignment makes pointer from integer without a cast [-Werror] *(char**)data = strdup(Error running guile function.); ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:103:23: error: assignment makes pointer from integer without a cast [-Werror] *(char**)data = strdup(msg); ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c: In function 'gfec_eval_string': /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:135:5: warning: 'scm_internal_stack_catch' is deprecated (declared at /usr/include/guile/2.0/libguile/deprecated.h:648) [-Wdeprecated-declarations] result = scm_internal_stack_catch(SCM_BOOL_T, ^ /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c: In function 'gfec_apply': /home/gnucash-dev/gitcheckouts/gnucash-clean/src/app-utils/gfec.c:203:5: warning: 'scm_internal_stack_catch' is deprecated (declared at /usr/include/guile/2.0/libguile/deprecated.h:648) [-Wdeprecated-declarations] result = scm_internal_stack_catch(SCM_BOOL_T, ^ cc1: all warnings being treated as errors Makefile:850: recipe for target 'gfec.lo' failed make[4]: *** [gfec.lo] Error 1 make[4]: Leaving directory '/home/gnucash-dev/gitcheckouts/gnucash-clean-build/src/app-utils' Any suggestions? I'm on Fedora 21. I think Geert uses that too. Alex, Turns out that for some flavors of GCC -std=gnu99 is required for strdup to be provided. I’d made the default c99, which in those cases doesn’t support it, hence the error. Fixed and pushed. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: make fails on master
On Sun, June 7, 2015 3:02 pm, John Ralls wrote: Alex, Turns out that for some flavors of GCC -std=gnu99 is required for strdup to be provided. I’d made the default c99, which in those cases doesn’t support it, hence the error. Fixed and pushed. Why are we using strdup() and not g_strdup()? Regards, John Ralls -derek -- Derek Atkins 617-623-3745 de...@ihtfp.com www.ihtfp.com Computer and Internet Security Consultant ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
