gnucash-docs build failure

2016-12-12 Thread Derek Atkins
Hi,
The gnucash-docs build has failed the past two nights.
Here's the current error

-derek

make[2]: Entering directory `/home/gnucash-docs/gnucash-docs/guide/it'
/bin/sh /home/gnucash-docs/gnucash-docs/install-sh -d "gnucash-guide"; \
for file in gnucash-guide.xml; do \
/usr/bin/xsltproc   \
  -o "gnucash-guide/" \
  --param use.id.as.filename "1" \
  --stringparam chunker.output.encoding UTF-8  \
  "../../xsl/general-customization.xsl" "./$file"; \
done
./gnucash-guide.xml:7614: element screenshot: validity error : ID 
tool-lotsInAcct already defined
  
  ^
./gnucash-guide.xml:7634: parser error : Opening and ending tag mismatch: sect2 
line 7587 and sect1
  
  ^
./gnucash-guide.xml:7845: parser error : Opening and ending tag mismatch: 
listitem line 7838 and itemizedlist
  
 ^
./gnucash-guide.xml:7878: parser error : Opening and ending tag mismatch: 
orderedlist line 7815 and listitem
  
 ^
./gnucash-guide.xml:7888: parser error : Opening and ending tag mismatch: sect3 
line 7808 and orderedlist

  ^
./gnucash-guide.xml:7889: parser error : Opening and ending tag mismatch: sect1 
line 7636 and sect3
  
  ^
./gnucash-guide.xml:8074: parser error : Opening and ending tag mismatch: 
orderedlist line 8065 and itemizedlist
  
 ^
./gnucash-guide.xml:8122: parser error : Opening and ending tag mismatch: sect3 
line 8058 and orderedlist

  ^
./gnucash-guide.xml:8123: parser error : Opening and ending tag mismatch: sect1 
line 7546 and sect3
  
  ^
./gnucash-guide.xml:8877: parser error : Opening and ending tag mismatch: 
chapter line 8866 and mediaobject

  ^
./gnucash-guide.xml:8878: parser error : Opening and ending tag mismatch: 
listitem line 8232 and screenshot
  
   ^
./gnucash-guide.xml:8879: parser error : Opening and ending tag mismatch: 
orderedlist line 8160 and figure

 ^
./gnucash-guide.xml:: parser error : Opening and ending tag mismatch: sect3 
line 8125 and listitem
  
 ^
./gnucash-guide.xml:8894: parser error : Opening and ending tag mismatch: 
chapter line 5214 and orderedlist

  ^
./gnucash-guide.xml:8895: parser error : Opening and ending tag mismatch: part 
line 3388 and sect3
  
  ^
./gnucash-guide.xml:9023: parser error : Opening and ending tag mismatch: sect3 
line 8897 and sect1
  
  ^
./gnucash-guide.xml:9080: parser error : Opening and ending tag mismatch: book 
line 78 and sect2

^
./gnucash-guide.xml:9081: parser error : Extra content at the end of the 
document
  
  ^
unable to parse ./gnucash-guide.xml
make[2]: *** [convert-html] Error 6
make[2]: Leaving directory `/home/gnucash-docs/gnucash-docs/guide/it'
make[1]: *** [html-recursive] Error 1
make[1]: Leaving directory `/home/gnucash-docs/gnucash-docs/guide'
make: *** [html-recursive] Error 1

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   warl...@mit.eduPGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Wrong Import date format selection crashes Gnucash

2016-12-12 Thread Derek Atkins
Hi,

John Ralls  writes:

>> On Dec 11, 2016, at 11:32 AM, Robert Fewell <14ubo...@gmail.com> wrote:
>> 
>> #15 0x76c2431f in gnc_dmy2timespec_neutral (day=day@entry=2016,
>> month=month@entry=12, year=year@entry=2001)
>
> The problem seems pretty obvious...
>
>>at gnc-date.cpp:1251
>> ---Type  to continue, or q  to quit---
>> #16 0x7fffe038564d in parse_date_with_year (format=,
>> date_str=0x11f1220 "2016/12/01") at gnc-csv-model.c:212
>> #17 parse_date (date_str=0x11f1220 "2016/12/01", format=1) at
>> gnc-csv-model.c:304
>
> Here you're telling parse_date_with_year to use "d-m-y" with a y-m-d
> format, and so passing an invalid day to gnc_dmy2rimespec_neutral.

This begs the question -- why is the UI allowing an invalid choice for
the date format?

The QIF importer tests the dates to attempt to determine the format and
presents the user with possible choices in the event of any ambiguity.
Has that functionality still not been ported to the C code before added
the format selector?

> I suspect that this is what led Geert to ask about invalid date values
> a few weeks ago. We don't want exceptions to leak out of C++ modules,
> so gnc_dmy2timespec_neutral (and every other call to a constructor in
> gnu-date.cpp) should be inside a try-catch block and catch should
> return an invalid result; callers should test for that result. C++
> code should use GncDateTime directly and handle the exception.
>
> Aaron, are you still working on replacing Timespec with time64?
>
> Regards,
> John Ralls

-derek

-- 
   Derek Atkins, SB '93 MIT EE, SM '95 MIT Media Laboratory
   Member, MIT Student Information Processing Board  (SIPB)
   URL: http://web.mit.edu/warlord/PP-ASEL-IA N1NWH
   warl...@mit.eduPGP key available
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Recommended Change to Author LIsting in Documentation

2016-12-12 Thread John Ralls

> On Dec 12, 2016, at 4:17 AM, David T. via gnucash-devel 
>  wrote:
> 
> I see that John has already removed the email addresses of individuals listed 
> in gnu cash-guide.xml.
> 
> Looking at the other two aspects, I see putting a combined note for both 2 & 
> 3 attached to the releaseinfo tag, which currently says: “This Guide contains 
> a tutorial for using GnuCash and describes the concepts behind GnuCash." 
> 
> Looking more at what John did and didn’t do, I see that he left the 
> individual copyright statements in the document, but it seems to me that 
> there is a cross up here that could cause problems. Specifically, the 
> copyright is assigned to named individuals and also to the GnuCash 
> Documentation Team, but some of the individual copyright holders are also 
> later identified as members of the GDT, which could lead to questions about 
> who actually holds the copyright. Does Yawar Amin hold copyright, or does the 
> GDT, of which Yawar is a member? 
> 
> I don’t know what the proper answer to this question is; perhaps someone else 
> does?
> 

Copyright belongs to the author unless he legally assigns it to another person 
(natural or corporate). The GnuCash Documentation Team isn't a corporation and 
so isn't a person and so can't be assigned copyright. Copyright statements 
assert copyright, they don't assign it. While protected speech, the assertion 
of copyright by the GnuCash Documentation Team is legally meaningless since 
there's no legal entity behind the assertion.

There's a nice general discussion of copyright in open source at 
http://producingoss.com/en/copyright-assignment.html 
, and the FSF (which 
requires copyright assignment on its core projects) has quite a lot on their 
website as well.

Regards,
John Ralls
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Recommended Change to Author LIsting in Documentation

2016-12-12 Thread David T. via gnucash-devel
I see that John has already removed the email addresses of individuals listed 
in gnu cash-guide.xml.

Looking at the other two aspects, I see putting a combined note for both 2 & 3 
attached to the releaseinfo tag, which currently says: “This Guide contains a 
tutorial for using GnuCash and describes the concepts behind GnuCash." 

Looking more at what John did and didn’t do, I see that he left the individual 
copyright statements in the document, but it seems to me that there is a cross 
up here that could cause problems. Specifically, the copyright is assigned to 
named individuals and also to the GnuCash Documentation Team, but some of the 
individual copyright holders are also later identified as members of the GDT, 
which could lead to questions about who actually holds the copyright. Does 
Yawar Amin hold copyright, or does the GDT, of which Yawar is a member? 

I don’t know what the proper answer to this question is; perhaps someone else 
does?

Cheers,
David T.

> On Dec 12, 2016, at 10:48 AM, Chris Good  wrote:
> 
>> Message: 2
>> Date: Sat, 10 Dec 2016 23:49:38 +0500
>> From: "David T." 
>> To: "David T. via gnucash-devel" 
>> Subject: Recommended Change to Author LIsting in Documentation
>> Message-ID: <648ed8ff-7d36-4d18-8331-90d9e11e0...@yahoo.com>
>> Content-Type: text/plain;charset=utf-8
>> 
>> Hi,
>> 
>> In response to seeing yet another new user sending a support request
>> directly to one of the people mentioned in the documentation, I created
> Bug
>> 775919 (https://bugzilla.gnome.org/show_bug.cgi?id=775919
>> ) as a proposed
>> change to the way that the docs present the author attributions. In that 
>> bug,
>> I state:
>> 
>> I recommend the following:
>> 
>> 1) Remove all individual names and email addresses from the documentation
>> title page, and replace them with a general attribution to "The GnuCash
>> Documentation Team." Since the current copyright is to this entity, I
> think
>> this is not only convenient, but also more accurate than the current list.
>> 
>> 2) Place a large note on the title page identifying gnucash-users as the 
>> proper
>> location to which to direct help requests. Section 2.4.2 is clearly not
>> prominent enough for new users.
>> 
>> 3) Retain the list of contributors that show on the title page verso. I
> will 
>> note
>> that this list omits email addresses. In addition, add a note there about 
>> who
>> and what the GnuCash Documentation Team is.
>> 
>> I propose: "The GnuCash Documentation Team is a self-designated group of
>> GnuCash users and developers who have volunteered to write this
>> documentation for the benefit of the broader user base. People who are
>> interested in joining this group are encouraged to express their interest
> on
>> the GnuCash lists (gnucash-users and gnucash-devel) for further
> direction.?
>> John Ralls thought that this change should be run past the Devel list, and
> 
>> so
>> here I am, giving it a run. As one of the named contributors, I personally
>> would prefer that my email not be included in the documentation, but I
>> defer to the general interest of the group.
>> 
>> Cheers,
>> David T.
> 
> Hi David,
> 
> Sounds good to me.
> A link to https://wiki.gnucash.org/wiki/Mailing_Lists would be good.
> 
> Regards,
> Chris Good
> 

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Wrong Import date format selection crashes Gnucash

2016-12-12 Thread Geert Janssens
Op zondag 11 december 2016 23:33:39 CET schreef Robert Fewell:
> Bad choice of words I guess, I knew I was passing the wrong date
> information deliberately to prove I would get an error but wasn't sure how
> to stop the crash when that happens. Any way Geert has advised that I
> should look at his work for a new date parser which I will do.
> 
> Bob
> 
Perhaps this is a good time to do an interim merge of my work on the csv 
importer. It's mostly functional as I intended (the major exception being the 
preset handling). And I have to add more tests.

Both can be added after the merge as well IMO.

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel