Re: build after last update
> On Jul 8, 2017, at 5:38 PM, Alex Aycinenawrote: > > After the last update, my Fedora 25 system won't build with the following > output: > > [gnucash-dev@HPdv5Fedora gnucash-working-build]$ make > -- Checking for modules 'OPTIONAL;webkit2gtk-4.0' > -- No package 'OPTIONAL' found > -- No package 'webkit2gtk-4.0' found > -- Checking for module 'webkit2gtk-3.0' > -- No package 'webkit2gtk-3.0' found > CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:416 (message): > A required package was not found > > I installed webkitgtk3-devel but it didn't solve the problem and I couldn't > find any package for webkit2gtk-4.0' or webkit2gtk-3.0. Can anyone help me > out. I believe Geert develops on Fedora 25 as well. Alex, What webkit*.pc do you have? There’s apparently a webkitgtk4-devel that’s supposed to provide webkit2gtk-4.0.pc, but webkitgtk3-devel is supposed to provide webkit2gtk-3.0.pc. Regards, John Ralls ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
build after last update
After the last update, my Fedora 25 system won't build with the following output: [gnucash-dev@HPdv5Fedora gnucash-working-build]$ make -- Checking for modules 'OPTIONAL;webkit2gtk-4.0' -- No package 'OPTIONAL' found -- No package 'webkit2gtk-4.0' found -- Checking for module 'webkit2gtk-3.0' -- No package 'webkit2gtk-3.0' found CMake Error at /usr/share/cmake/Modules/FindPkgConfig.cmake:416 (message): A required package was not found I installed webkitgtk3-devel but it didn't solve the problem and I couldn't find any package for webkit2gtk-4.0' or webkit2gtk-3.0. Can anyone help me out. I believe Geert develops on Fedora 25 as well. thanks, Alex ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
I will have a think about this after I complete all the other required changes. Bob On 8 July 2017 at 17:46, Geert Janssenswrote: > On zaterdag 8 juli 2017 17:25:19 CEST Robert Fewell wrote: > > > The file name can be as you stated, I was thinking about the widget style > > > contexts, maybe along the lines of GncDenseCal_font_size > > > > > > Bob > > > > Right. I actually have no idea what is common. The whole css thing is > pretty new to me. Did you find any examples in other applications ? > > > > I believe though there should be a combination of two things: a widget > type specifier (like gncdensecal) and style properties for that widget. > > > > So a widget of type gncdensecal can have a property called "font-size" > (note dashes are usually used in css rather than underscores). > > > > With that you could write css like: > > gncdensecal > > { > > font-size: 10pt; > > } > > > > If you want to alter a property of one particular Dense Calendar, you > could use the style context name you have set in your code, something like > this > > #DensCalX > > { > > font-size: 10pt; > > } > > > > That's only highlevel code, not fully verified :) More details > explanations and examples can be found here: > > https://developer.gnome.org/gtk3/unstable/chap-css-overview.html > > > > For default gtk widgets this is all available by default. And usually we'd > want to use the second form (altering css properties of one particular > widget instead of a complete widget class). > > For our custom widgets we'd have to define these widget types and style > properties ourselves. > > > > Geert > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
OK, I will have a go at this on Sunday before I try and make the changes you have mentioned in your feedback. Bob On 8 July 2017 at 17:31, Geert Janssenswrote: > Bob, > > I had a few merge conflicts to resolve during merge. There was one that > wasn't > trivial: > src/import-export/dialog-import.glade > > To be able to continue with the merge I have reverted it to the state on > master, except for the name changes for the primary dialogs. That way it > still > builds fine, but your deprecated widgets changes are lost. There is > unfortunately no way to sanely resolve merge conflicts in a glade file. > > So this file has to be converted again. > > What I did is pull in your branch (which also includes my and John's work) > and > merged it locally in the current master branch, after resolving the > conflicts. > I then pushed this result back to my github repo (gjanssens). So the master > branch in that repo is now running gtk3. > > Note that this branch currently doesn't install if you enable building with > aqbanking. This is also the case for our central master branch though. It > looks like there are a few issues with the dist/distcheck/uninstall > commit. I > fixed one of them on my local branch but I have no idea how to fix the > aqbanking one. > > Anyway to avoid we have to do this merge again in the future, can you > (re)base > your local commits you haven't pushed yet on my master branch ? > > I'm holding off on pushing the whole thing to master on code.gnucash.org > until > I heard from John. > > Regards, > > Geert > > On zaterdag 8 juli 2017 16:02:01 CEST Geert Janssens wrote: > > I'm done with reviewing your work. You'll find mi comments directly on > the > > github commits. > > > > In general - well done! This really brings us much closer to a real gtk3 > > gnucash. > > > > As far as I'm concerned your branch is ready for merging: > > - the tree builds fine > > - the build executable seems to work barring a few visual details > > > > So IMO this is ready to be tested by a bigger audience. > > > > Regards, > > > > Geert > > > > On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: > > > Bob, > > > > > > While reading through your changes I note we have lots of places where > we > > > make some small tweaks to the default gui style. It shows in your > commits > > > because we have to change from GtkStyle api to > > > GtkStyleContext/GtkCssProvider api. > > > > > > This got me thinking about a future streamlining we should consider: > > > instead of adding code snippets that insert custom CSS, can't we > collect > > > all of these snippets in one big CSS file we ship with gnucash, to be > > > stored in /etc/ gnucash/gnucash.css and which we read at load time ? > Much > > > like we now load a custom .gtk3.0-gnucash.css file. > > > > > > Both can co-exist IMO, with the latter taking precedence over the > former. > > > The one in etc should be "Application" priority the one in the homedir > > > "User" priority. > > > > > > This would keep the code cleaner and separate function from > presentation. > > > Especially your initial work of adding style context to most widgets > is a > > > big step in the right direction. > > > > > > What do you think ? > > > > > > Regards, > > > > > > Geert > > > > ___ > > gnucash-devel mailing list > > gnucash-devel@gnucash.org > > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > > > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
Geert, Great, thanks! That was what I was planning to do today, so it moves me up to merging in my mingw64 branch and converting the mingw64 branch of gnucash-on-windows to Gtk3. That blocks windows nightlies so I had it in mind that we’d hold off on merging into the official master until then. OTOH we really shouldn’t do any further work on the gtk2 master, it will just make more work later. As for AQBanking, I thought I’d gotten that fixed in the distcheck merge commit. One does have to turn it on explicitly when building with Cmake. Regards, John Ralls > On Jul 8, 2017, at 9:31 AM, Geert Janssenswrote: > > Bob, > > I had a few merge conflicts to resolve during merge. There was one that > wasn't > trivial: > src/import-export/dialog-import.glade > > To be able to continue with the merge I have reverted it to the state on > master, except for the name changes for the primary dialogs. That way it > still > builds fine, but your deprecated widgets changes are lost. There is > unfortunately no way to sanely resolve merge conflicts in a glade file. > > So this file has to be converted again. > > What I did is pull in your branch (which also includes my and John's work) > and > merged it locally in the current master branch, after resolving the > conflicts. > I then pushed this result back to my github repo (gjanssens). So the master > branch in that repo is now running gtk3. > > Note that this branch currently doesn't install if you enable building with > aqbanking. This is also the case for our central master branch though. It > looks like there are a few issues with the dist/distcheck/uninstall commit. I > fixed one of them on my local branch but I have no idea how to fix the > aqbanking one. > > Anyway to avoid we have to do this merge again in the future, can you > (re)base > your local commits you haven't pushed yet on my master branch ? > > I'm holding off on pushing the whole thing to master on code.gnucash.org > until > I heard from John. > > Regards, > > Geert > > On zaterdag 8 juli 2017 16:02:01 CEST Geert Janssens wrote: >> I'm done with reviewing your work. You'll find mi comments directly on the >> github commits. >> >> In general - well done! This really brings us much closer to a real gtk3 >> gnucash. >> >> As far as I'm concerned your branch is ready for merging: >> - the tree builds fine >> - the build executable seems to work barring a few visual details >> >> So IMO this is ready to be tested by a bigger audience. >> >> Regards, >> >> Geert >> >> On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: >>> Bob, >>> >>> While reading through your changes I note we have lots of places where we >>> make some small tweaks to the default gui style. It shows in your commits >>> because we have to change from GtkStyle api to >>> GtkStyleContext/GtkCssProvider api. >>> >>> This got me thinking about a future streamlining we should consider: >>> instead of adding code snippets that insert custom CSS, can't we collect >>> all of these snippets in one big CSS file we ship with gnucash, to be >>> stored in /etc/ gnucash/gnucash.css and which we read at load time ? Much >>> like we now load a custom .gtk3.0-gnucash.css file. >>> >>> Both can co-exist IMO, with the latter taking precedence over the former. >>> The one in etc should be "Application" priority the one in the homedir >>> "User" priority. >>> >>> This would keep the code cleaner and separate function from presentation. >>> Especially your initial work of adding style context to most widgets is a >>> big step in the right direction. >>> >>> What do you think ? >>> >>> Regards, >>> >>> Geert >> >> ___ >> gnucash-devel mailing list >> gnucash-devel@gnucash.org >> https://lists.gnucash.org/mailman/listinfo/gnucash-devel > > > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
On zaterdag 8 juli 2017 17:25:19 CEST Robert Fewell wrote: > The file name can be as you stated, I was thinking about the widget style > contexts, maybe along the lines of GncDenseCal_font_size > > Bob Right. I actually have no idea what is common. The whole css thing is pretty new to me. Did you find any examples in other applications ? I believe though there should be a combination of two things: a widget type specifier (like gncdensecal) and style properties for that widget. So a widget of type gncdensecal can have a property called "font-size" (note dashes are usually used in css rather than underscores). With that you could write css like: gncdensecal { font-size: 10pt; } If you want to alter a property of one particular Dense Calendar, you could use the style context name you have set in your code, something like this #DensCalX { font-size: 10pt; } That's only highlevel code, not fully verified :) More details explanations and examples can be found here: https://developer.gnome.org/gtk3/unstable/chap-css-overview.html For default gtk widgets this is all available by default. And usually we'd want to use the second form (altering css properties of one particular widget instead of a complete widget class). For our custom widgets we'd have to define these widget types and style properties ourselves. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
Bob, I had a few merge conflicts to resolve during merge. There was one that wasn't trivial: src/import-export/dialog-import.glade To be able to continue with the merge I have reverted it to the state on master, except for the name changes for the primary dialogs. That way it still builds fine, but your deprecated widgets changes are lost. There is unfortunately no way to sanely resolve merge conflicts in a glade file. So this file has to be converted again. What I did is pull in your branch (which also includes my and John's work) and merged it locally in the current master branch, after resolving the conflicts. I then pushed this result back to my github repo (gjanssens). So the master branch in that repo is now running gtk3. Note that this branch currently doesn't install if you enable building with aqbanking. This is also the case for our central master branch though. It looks like there are a few issues with the dist/distcheck/uninstall commit. I fixed one of them on my local branch but I have no idea how to fix the aqbanking one. Anyway to avoid we have to do this merge again in the future, can you (re)base your local commits you haven't pushed yet on my master branch ? I'm holding off on pushing the whole thing to master on code.gnucash.org until I heard from John. Regards, Geert On zaterdag 8 juli 2017 16:02:01 CEST Geert Janssens wrote: > I'm done with reviewing your work. You'll find mi comments directly on the > github commits. > > In general - well done! This really brings us much closer to a real gtk3 > gnucash. > > As far as I'm concerned your branch is ready for merging: > - the tree builds fine > - the build executable seems to work barring a few visual details > > So IMO this is ready to be tested by a bigger audience. > > Regards, > > Geert > > On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: > > Bob, > > > > While reading through your changes I note we have lots of places where we > > make some small tweaks to the default gui style. It shows in your commits > > because we have to change from GtkStyle api to > > GtkStyleContext/GtkCssProvider api. > > > > This got me thinking about a future streamlining we should consider: > > instead of adding code snippets that insert custom CSS, can't we collect > > all of these snippets in one big CSS file we ship with gnucash, to be > > stored in /etc/ gnucash/gnucash.css and which we read at load time ? Much > > like we now load a custom .gtk3.0-gnucash.css file. > > > > Both can co-exist IMO, with the latter taking precedence over the former. > > The one in etc should be "Application" priority the one in the homedir > > "User" priority. > > > > This would keep the code cleaner and separate function from presentation. > > Especially your initial work of adding style context to most widgets is a > > big step in the right direction. > > > > What do you think ? > > > > Regards, > > > > Geert > > ___ > gnucash-devel mailing list > gnucash-devel@gnucash.org > https://lists.gnucash.org/mailman/listinfo/gnucash-devel ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
The file name can be as you stated, I was thinking about the widget style contexts, maybe along the lines of GncDenseCal_font_size Bob On 8 July 2017 at 14:39, Geert Janssenswrote: > On zaterdag 8 juli 2017 15:17:45 CEST Robert Fewell wrote: > > Geert, > > > > That sounds like a good idea, not sure about the location, may be in > > share/gnucash/gnucash.css > > Doh... Indeed share/gnucash/ would be much better than /etc. It's > application > data, not system configuration. > > > Some kind of naming format will need to be decided that makes sense. > > > Do you mean for the file name or for the widget style contexts ? > > > I can have a look at that after all your initial thoughts !! > > That would be great. > > Geert > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
Thanks for your comments, I have a few more changes to make and then I will try and get your recomendations done next week. Bob On 8 July 2017 at 15:02, Geert Janssenswrote: > I'm done with reviewing your work. You'll find mi comments directly on the > github commits. > > In general - well done! This really brings us much closer to a real gtk3 > gnucash. > > As far as I'm concerned your branch is ready for merging: > - the tree builds fine > - the build executable seems to work barring a few visual details > > So IMO this is ready to be tested by a bigger audience. > > Regards, > > Geert > > On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: > > Bob, > > > > While reading through your changes I note we have lots of places where we > > make some small tweaks to the default gui style. It shows in your commits > > because we have to change from GtkStyle api to > > GtkStyleContext/GtkCssProvider api. > > > > This got me thinking about a future streamlining we should consider: > instead > > of adding code snippets that insert custom CSS, can't we collect all of > > these snippets in one big CSS file we ship with gnucash, to be stored in > > /etc/ gnucash/gnucash.css and which we read at load time ? Much like we > now > > load a custom .gtk3.0-gnucash.css file. > > > > Both can co-exist IMO, with the latter taking precedence over the former. > > The one in etc should be "Application" priority the one in the homedir > > "User" priority. > > > > This would keep the code cleaner and separate function from presentation. > > Especially your initial work of adding style context to most widgets is a > > big step in the right direction. > > > > What do you think ? > > > > Regards, > > > > Geert > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
I'm done with reviewing your work. You'll find mi comments directly on the github commits. In general - well done! This really brings us much closer to a real gtk3 gnucash. As far as I'm concerned your branch is ready for merging: - the tree builds fine - the build executable seems to work barring a few visual details So IMO this is ready to be tested by a bigger audience. Regards, Geert On zaterdag 8 juli 2017 15:01:38 CEST Geert Janssens wrote: > Bob, > > While reading through your changes I note we have lots of places where we > make some small tweaks to the default gui style. It shows in your commits > because we have to change from GtkStyle api to > GtkStyleContext/GtkCssProvider api. > > This got me thinking about a future streamlining we should consider: instead > of adding code snippets that insert custom CSS, can't we collect all of > these snippets in one big CSS file we ship with gnucash, to be stored in > /etc/ gnucash/gnucash.css and which we read at load time ? Much like we now > load a custom .gtk3.0-gnucash.css file. > > Both can co-exist IMO, with the latter taking precedence over the former. > The one in etc should be "Application" priority the one in the homedir > "User" priority. > > This would keep the code cleaner and separate function from presentation. > Especially your initial work of adding style context to most widgets is a > big step in the right direction. > > What do you think ? > > Regards, > > Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
On zaterdag 8 juli 2017 15:17:45 CEST Robert Fewell wrote: > Geert, > > That sounds like a good idea, not sure about the location, may be in > share/gnucash/gnucash.css Doh... Indeed share/gnucash/ would be much better than /etc. It's application data, not system configuration. > Some kind of naming format will need to be decided that makes sense. > Do you mean for the file name or for the widget style contexts ? > I can have a look at that after all your initial thoughts !! That would be great. Geert ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
Geert, That sounds like a good idea, not sure about the location, may be in share/gnucash/gnucash.css Some kind of naming format will need to be decided that makes sense. I can have a look at that after all your initial thoughts !! Bob On 8 July 2017 at 14:01, Geert Janssenswrote: > Bob, > > While reading through your changes I note we have lots of places where we > make > some small tweaks to the default gui style. It shows in your commits > because > we have to change from GtkStyle api to GtkStyleContext/GtkCssProvider api. > > This got me thinking about a future streamlining we should consider: > instead > of adding code snippets that insert custom CSS, can't we collect all of > these > snippets in one big CSS file we ship with gnucash, to be stored in /etc/ > gnucash/gnucash.css and which we read at load time ? Much like we now load > a > custom .gtk3.0-gnucash.css file. > > Both can co-exist IMO, with the latter taking precedence over the former. > The > one in etc should be "Application" priority the one in the homedir "User" > priority. > > This would keep the code cleaner and separate function from presentation. > Especially your initial work of adding style context to most widgets is a > big > step in the right direction. > > What do you think ? > > Regards, > > Geert > > On donderdag 29 juni 2017 11:16:04 CEST Robert Fewell wrote: > > This is what I have done so far, may of gone too far but every thing > still > > appears to be working. > > I have not touched any Aquabanking stuff, not sure what needs to be done > to > > get that enabled but probably would not take long to convert. > > > > All glade files are now verified against 3.10 and deprecated widgets > > changed. > > Stock buttons changed to the equivalent labels and images changed to > icons > > including the GNC_ ones. > > > > All deprecated widgets have been changed to 3.10 equivalents apart from > > GtkUiManager, GtkAction and GtkActionMenu. These are mostly to do with > > toolbars, menus, accelerator keys and there are no easy real equivalents > so > > propose to leave them deprecated to the end and then maybe a decision can > > be made. > > > > I have tried to stay away from the register but some of the commits have > > replaced some deprecated widgets. > > > > I have experimented with some CSS by adding style context classes of the > > nature "GncImapDialog" to various dialogues and this seems to work quite > > well down to changing the background colour of different tree views. May > > continue to add more. > > > > There are no doubt some tweaks to be made to align with current version > but > > maybe that should wait till the gtk3 branch is updated from master. > > > > With version 3.22, I am getting warnings on the console about transient > > windows not having a parent so may have a look at that next. There are > > other warnings but they seem to be concerned with GTK itself, may need > > looking at, not sure. Also with this version we get a whole new set of > > deprecated widgets that may be an idea to get replaced. Will need to do a > > complete rebuild on this version to get an updated log file. > > > > > > Bob > ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel
Re: Gtk3
Bob, While reading through your changes I note we have lots of places where we make some small tweaks to the default gui style. It shows in your commits because we have to change from GtkStyle api to GtkStyleContext/GtkCssProvider api. This got me thinking about a future streamlining we should consider: instead of adding code snippets that insert custom CSS, can't we collect all of these snippets in one big CSS file we ship with gnucash, to be stored in /etc/ gnucash/gnucash.css and which we read at load time ? Much like we now load a custom .gtk3.0-gnucash.css file. Both can co-exist IMO, with the latter taking precedence over the former. The one in etc should be "Application" priority the one in the homedir "User" priority. This would keep the code cleaner and separate function from presentation. Especially your initial work of adding style context to most widgets is a big step in the right direction. What do you think ? Regards, Geert On donderdag 29 juni 2017 11:16:04 CEST Robert Fewell wrote: > This is what I have done so far, may of gone too far but every thing still > appears to be working. > I have not touched any Aquabanking stuff, not sure what needs to be done to > get that enabled but probably would not take long to convert. > > All glade files are now verified against 3.10 and deprecated widgets > changed. > Stock buttons changed to the equivalent labels and images changed to icons > including the GNC_ ones. > > All deprecated widgets have been changed to 3.10 equivalents apart from > GtkUiManager, GtkAction and GtkActionMenu. These are mostly to do with > toolbars, menus, accelerator keys and there are no easy real equivalents so > propose to leave them deprecated to the end and then maybe a decision can > be made. > > I have tried to stay away from the register but some of the commits have > replaced some deprecated widgets. > > I have experimented with some CSS by adding style context classes of the > nature "GncImapDialog" to various dialogues and this seems to work quite > well down to changing the background colour of different tree views. May > continue to add more. > > There are no doubt some tweaks to be made to align with current version but > maybe that should wait till the gtk3 branch is updated from master. > > With version 3.22, I am getting warnings on the console about transient > windows not having a parent so may have a look at that next. There are > other warnings but they seem to be concerned with GTK itself, may need > looking at, not sure. Also with this version we get a whole new set of > deprecated widgets that may be an idea to get replaced. Will need to do a > complete rebuild on this version to get an updated log file. > > > Bob ___ gnucash-devel mailing list gnucash-devel@gnucash.org https://lists.gnucash.org/mailman/listinfo/gnucash-devel