Re: Problem building master with autotools

[Sumit Bhardwaj]

Just did a fresh pull from gnucash/master (not a rebase).

Using autotools (./autogen.sh && ./configure --enable-compile-warnings &&
make) succeeded.

Make check failed. Fail message is below. I will try to look at it if I
have some time tonight.

-Sumit

./../../test-driver: line 107:  8259 Trace/breakpoint trap   (core dumped)
"$@" > $log_file 2>&1
FAIL: test-app-utils

Testsuite summary for GnuCash 2.6.99

# TOTAL: 7
# PASS:  6
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

See src/app-utils/test/test-suite.log
Please report to gnucash-devel@gnucash.org

Makefile:1051: recipe for target 'test-suite.log' failed
make[5]: *** [test-suite.log] Error 1
make[5]: Leaving directory
'/home/bhardwajs/ac/devel/gnucash/src/app-utils/test'
Makefile:1157: recipe for target 'check-TESTS' failed
make[4]: *** [check-TESTS] Error 2
make[4]: Leaving directory
'/home/bhardwajs/ac/devel/gnucash/src/app-utils/test'
Makefile:1272: recipe for target 'check-am' failed
make[3]: *** [check-am] Error 2
make[3]: Leaving directory
'/home/bhardwajs/ac/devel/gnucash/src/app-utils/test'
Makefile:1026: recipe for target 'check-recursive' failed
make[2]: *** [check-recursive] Error 1
make[2]: Leaving directory '/home/bhardwajs/ac/devel/gnucash/src/app-utils'
Makefile:596: recipe for target 'check-recursive' failed
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory '/home/bhardwajs/ac/devel/gnucash/src'
Makefile:825: recipe for target 'check-recursive' failed
make: *** [check-recursive] Error 1


On Mon, Jul 10, 2017 at 7:15 PM, Alex Aycinena 
wrote:

>
>
> On Jul 10, 2017 6:58 PM, "Sumit Bhardwaj"  wrote:
>
> I checked out master in the AM today and had a clean build (make and make
> install) on Fedora 25 using autotools. I can try again once I get to my
> personal machine.
>
> Are you doing make test here? I can try and report.
>
> Thanks,
> Sumit
>
> On Mon, Jul 10, 2017 at 6:38 PM, Alex Aycinena 
> wrote:
>
>> With a fresh checkout of master, I try to build with the autotools but I
>> get an error in linking test-import-pending-matches with test-engine-stuff
>> during make as follows:
>>
>> /usr/bin/ld:
>> ../../../src/engine/test-core/.libs/libgncmod-test-engine.a(
>> test-engine-stuff.o):
>> undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3'
>> /usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command
>> line
>> collect2: error: ld returned 1 exit status
>> Makefile:837: recipe for target 'test-import-pending-matches' failed
>>
>> I can build with cmake but I would like to run make check after an
>> autotools make because I think it runs different checks.
>>
>> Can anyone give me an idea of how to get this to work? This is Fedora 25.
>>
>> Thanks,
>>
>> Alex
>> ___
>> gnucash-devel mailing list
>> gnucash-devel@gnucash.org
>> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>>
>
> No - I have a new check out and an empty build directory. I run autogen.sh
> then change to the build directory. I run config with a bunch of switches
> referring back to the main directory for source. Then I run make and get
> the error.
>
> Can't figure out why it stopped working suddenly a few weeks ago.
>
> Thanks.
>
> Alex
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: Problem building master with autotools

[Alex Aycinena]

On Jul 10, 2017 6:58 PM, "Sumit Bhardwaj"  wrote:

I checked out master in the AM today and had a clean build (make and make
install) on Fedora 25 using autotools. I can try again once I get to my
personal machine.

Are you doing make test here? I can try and report.

Thanks,
Sumit

On Mon, Jul 10, 2017 at 6:38 PM, Alex Aycinena 
wrote:

> With a fresh checkout of master, I try to build with the autotools but I
> get an error in linking test-import-pending-matches with test-engine-stuff
> during make as follows:
>
> /usr/bin/ld:
> ../../../src/engine/test-core/.libs/libgncmod-test-engine.a(
> test-engine-stuff.o):
> undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3'
> /usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command
> line
> collect2: error: ld returned 1 exit status
> Makefile:837: recipe for target 'test-import-pending-matches' failed
>
> I can build with cmake but I would like to run make check after an
> autotools make because I think it runs different checks.
>
> Can anyone give me an idea of how to get this to work? This is Fedora 25.
>
> Thanks,
>
> Alex
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>

No - I have a new check out and an empty build directory. I run autogen.sh
then change to the build directory. I run config with a bunch of switches
referring back to the main directory for source. Then I run make and get
the error.

Can't figure out why it stopped working suddenly a few weeks ago.

Thanks.

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: Problem building master with autotools

[Sumit Bhardwaj]

I checked out master in the AM today and had a clean build (make and make
install) on Fedora 25 using autotools. I can try again once I get to my
personal machine.

Are you doing make test here? I can try and report.

Thanks,
Sumit

On Mon, Jul 10, 2017 at 6:38 PM, Alex Aycinena 
wrote:

> With a fresh checkout of master, I try to build with the autotools but I
> get an error in linking test-import-pending-matches with test-engine-stuff
> during make as follows:
>
> /usr/bin/ld:
> ../../../src/engine/test-core/.libs/libgncmod-test-engine.a(
> test-engine-stuff.o):
> undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3'
> /usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command
> line
> collect2: error: ld returned 1 exit status
> Makefile:837: recipe for target 'test-import-pending-matches' failed
>
> I can build with cmake but I would like to run make check after an
> autotools make because I think it runs different checks.
>
> Can anyone give me an idea of how to get this to work? This is Fedora 25.
>
> Thanks,
>
> Alex
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Problem building master with autotools

[Alex Aycinena]

With a fresh checkout of master, I try to build with the autotools but I
get an error in linking test-import-pending-matches with test-engine-stuff
during make as follows:

/usr/bin/ld:
../../../src/engine/test-core/.libs/libgncmod-test-engine.a(test-engine-stuff.o):
undefined reference to symbol '__gxx_personality_v0@@CXXABI_1.3'
/usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command
line
collect2: error: ld returned 1 exit status
Makefile:837: recipe for target 'test-import-pending-matches' failed

I can build with cmake but I would like to run make check after an
autotools make because I think it runs different checks.

Can anyone give me an idea of how to get this to work? This is Fedora 25.

Thanks,

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: build after last update

[Geert Janssens]

Alex,

I wonder did you run ninja-build install or are you running gnucash from the 
build directory ?

I didn't consider the latter when making my changes. Perhaps I should.

Geert

On maandag 10 juli 2017 22:42:56 CEST Alex Aycinena wrote:
> > -- Forwarded message --
> > From: Geert Janssens 
> > To: Alex Aycinena 
> > Cc: gnucash-devel , John Ralls <
> > jra...@ceridwen.us>
> > Bcc:
> > Date: Mon, 10 Jul 2017 12:28:09 +0200
> > Subject: Re: build after last update
> > 
> > On zondag 9 juli 2017 22:33:34 CEST Alex Aycinena wrote:
> > > Spoke too soon. When I tried to start gnucash with 'bin/gnucash --debug
> > > --log gnc.scm=debug --nofile', got:
> > > 
> > > gnc.gui:ERROR:/home/gnucash-dev/gitcheckouts/gnucash-
> > 
> > clean-new/src/gnome-uti
> > 
> > > ls/gnc-icons.c:103:gnc_load_app_icons: assertion failed:
> > > (gtk_icon_theme_has_icon (icon_theme, file->icon_name)) Aborted (core
> > > dumped)
> > 
> > Alex,
> > 
> > I have rewritten this function to avoid the assert. It wasn't really
> > required.
> > That doesn't explain though why you hit it and I don't.
> > 
> > So I have added some debug output (to be enabled by setting gnc.gui=info).
> > This will print out all paths where gtk will search for our icons.
> > 
> > Can you check whether the icons the new function will complain about are
> > available in any subdirectory of these directories ?
> > 
> > Geert
> 
> Geert,
> 
> Gnucash.trace shows (with answer to your question):
> 
> * 11:57:55  INFO  [gnc_load_app_icons] The icon theme search path
> has 16 elements.
> * 11:57:55  INFO  [gnc_load_app_icons] Path 0:
> /home/gnucash-dev/.local/share/icons
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 1:
> /home/gnucash-dev/.icons
> 
> This directory is empty
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 2:
> /home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/icons
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 3:
> /opt/gnucash-git/gnucash-clean/share/icons
> 
> This directory has 1 subdirectory, called hicolor, which in turn has 9
> subdirectories (16x16, 22x22, etc.), one callled scalable and a file
> callled icon-theme.cache
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 4:
> /usr/local/share/icons
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 5: /usr/share/icons
> 
> 14 subdirectories, each with many subdirectories
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 6:
> /usr/local/share/icons
> 
> Same as path 4
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 7: /usr/share/icons
> 
> Same as path 5
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 8:
> /home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/pixmaps
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 9:
> /opt/gnucash-git/gnucash-clean/share/pixmaps
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 10:
> /usr/local/share/pixmaps
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 11: /usr/share/pixmaps
> 
> Many subdirectories
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 12:
> /usr/local/share/pixmaps
> 
> Same as path 10
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 13: /usr/share/pixmaps
> 
> Same as path 11
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 14:
> /home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/gnucash/icons
> 
> This directory doesn't exist
> 
> * 11:57:55  INFO  [gnc_load_app_icons] Path 15:
> /home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/icons
> 
> This directory doesn't exist
> 
> * 11:57:55  WARN  [gnc_load_app_icons()] No icon named
> 'gnc-account' found. Some gui elements may be missing their icons
> 
> found in 4 general locations
> 
> "/usr/share/gnucash/pixmaps" - from the fedora package installed on the
> system?
> 
> "/opt/installation-location/share/gnucash/pixmaps" - there are several of
> these where I have installed several different earlier builds with make
> install but I have not yet installed for this checkout so this location
> does not exist for this checkout (i've only run gnucash from the build
> directory for this checkout)
> 
> "/home/checkout-location/src/pixmaps" - there are several of these where I
> have earlier checked-out gnucash source; the icons seem to have been pushed
> down the directory tree for this checkout (see next comment)
> 
> "/home/this-checkout-location/src/pixmaps/hicolor/16x16/actions" - this is
> in the source tree, not the build tree; only "16x16/actions" and
> "24x24/actions" have the 'gnc-account' icons
> 
> * 11:57:55  WARN  [gnc_load_app_icons()] No icon named
> 'gnc-account-report' found. Some gui elements may be missing their icons
> 
> same as for gnc-account
> 
> * 11:57:55  WARN  [gnc_load_app_icons()] No icon named
> 'gnc-account-delete' found. Some gui 

Re: build after last update

[Alex Aycinena]

> -- Forwarded message --
> From: Geert Janssens 
> To: Alex Aycinena 
> Cc: gnucash-devel , John Ralls <
> jra...@ceridwen.us>
> Bcc:
> Date: Mon, 10 Jul 2017 12:28:09 +0200
> Subject: Re: build after last update
> On zondag 9 juli 2017 22:33:34 CEST Alex Aycinena wrote:
> > Spoke too soon. When I tried to start gnucash with 'bin/gnucash --debug
> > --log gnc.scm=debug --nofile', got:
> >
> > gnc.gui:ERROR:/home/gnucash-dev/gitcheckouts/gnucash-
> clean-new/src/gnome-uti
> > ls/gnc-icons.c:103:gnc_load_app_icons: assertion failed:
> > (gtk_icon_theme_has_icon (icon_theme, file->icon_name)) Aborted (core
> > dumped)
>
> Alex,
>
> I have rewritten this function to avoid the assert. It wasn't really
> required.
> That doesn't explain though why you hit it and I don't.
>
> So I have added some debug output (to be enabled by setting gnc.gui=info).
> This will print out all paths where gtk will search for our icons.
>
> Can you check whether the icons the new function will complain about are
> available in any subdirectory of these directories ?
>
> Geert
>
>
Geert,

Gnucash.trace shows (with answer to your question):

* 11:57:55  INFO  [gnc_load_app_icons] The icon theme search path
has 16 elements.
* 11:57:55  INFO  [gnc_load_app_icons] Path 0:
/home/gnucash-dev/.local/share/icons

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 1:
/home/gnucash-dev/.icons

This directory is empty

* 11:57:55  INFO  [gnc_load_app_icons] Path 2:
/home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/icons

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 3:
/opt/gnucash-git/gnucash-clean/share/icons

This directory has 1 subdirectory, called hicolor, which in turn has 9
subdirectories (16x16, 22x22, etc.), one callled scalable and a file
callled icon-theme.cache

* 11:57:55  INFO  [gnc_load_app_icons] Path 4:
/usr/local/share/icons

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 5: /usr/share/icons

14 subdirectories, each with many subdirectories

* 11:57:55  INFO  [gnc_load_app_icons] Path 6:
/usr/local/share/icons

Same as path 4

* 11:57:55  INFO  [gnc_load_app_icons] Path 7: /usr/share/icons

Same as path 5

* 11:57:55  INFO  [gnc_load_app_icons] Path 8:
/home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/pixmaps

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 9:
/opt/gnucash-git/gnucash-clean/share/pixmaps

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 10:
/usr/local/share/pixmaps

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 11: /usr/share/pixmaps

Many subdirectories

* 11:57:55  INFO  [gnc_load_app_icons] Path 12:
/usr/local/share/pixmaps

Same as path 10

* 11:57:55  INFO  [gnc_load_app_icons] Path 13: /usr/share/pixmaps

Same as path 11

* 11:57:55  INFO  [gnc_load_app_icons] Path 14:
/home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/gnucash/icons

This directory doesn't exist

* 11:57:55  INFO  [gnc_load_app_icons] Path 15:
/home/gnucash-dev/gitcheckouts/gnucash-clean-new-build/share/icons

This directory doesn't exist

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account' found. Some gui elements may be missing their icons

found in 4 general locations

"/usr/share/gnucash/pixmaps" - from the fedora package installed on the
system?

"/opt/installation-location/share/gnucash/pixmaps" - there are several of
these where I have installed several different earlier builds with make
install but I have not yet installed for this checkout so this location
does not exist for this checkout (i've only run gnucash from the build
directory for this checkout)

"/home/checkout-location/src/pixmaps" - there are several of these where I
have earlier checked-out gnucash source; the icons seem to have been pushed
down the directory tree for this checkout (see next comment)

"/home/this-checkout-location/src/pixmaps/hicolor/16x16/actions" - this is
in the source tree, not the build tree; only "16x16/actions" and
"24x24/actions" have the 'gnc-account' icons

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account-report' found. Some gui elements may be missing their icons

same as for gnc-account

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account-delete' found. Some gui elements may be missing their icons

same as for gnc-account

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account-edit' found. Some gui elements may be missing their icons

same as for gnc-account

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account-new' found. Some gui elements may be missing their icons

same as for gnc-account

* 11:57:55  WARN  [gnc_load_app_icons()] No icon named
'gnc-account-open' found. Some gui elements may be missing their icons

same as for gnc-account

* 11:57:55  WARN  

Re: gnucash master: Book-Currency Feature step 6

[Geert Janssens]

On maandag 10 juli 2017 18:31:25 CEST Robert Fewell wrote:
> I did not realise that this content was so new, it showed up in my last
> build log and I thought it was stuff from master that needed the deprecated
> widgets converted, mainly table to grid and a vbox.
> 
> Shall I leave this for Alex to convert or wait for this to be fixed ?
> 
> Bob

The problem is fixed so feel free to convert all that is still deprecated.

Note that the my gtk3 branch branched off of master around March 31st and 
wasn't rebased since. So everything that happened on master affecting gtk2 
would have been missed when working on my gtk3 branch. So it's to be expected 
you would discover new deprecated stuff after the merge.

Regards,

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: gnucash master: Book-Currency Feature step 6

[Geert Janssens]

On maandag 10 juli 2017 20:54:23 CEST Alex Aycinena wrote:
> > -- Forwarded message --
> > From: Geert Janssens 
> > To: gnucash-devel@gnucash.org
> > Cc:
> > Bcc:
> > Date: Mon, 10 Jul 2017 15:45:57 +0200
> > Subject: Re: gnucash master: Book-Currency Feature step 6
> > Alex,
> > 
> > This commit has broken make check on travis:
> > https://travis-ci.org/Gnucash/gnucash/builds/251783000
> > 
> > Can you check the error ?
> > 
> > Regards,
> > 
> > Geert
> 
> Geert,
> 
> I have pushed a fix for this.
> 
Thanks.

> By the way, this points out to me that if I run make check (or ninja-build
> check) with cmake, it doesn't run all the same tests as those with building
> with autotools because I had incorrectly assumed that this test had run and
> run correctly.

This is something we should check. By aligning the dist tarballs I also bumped 
into a missing test in app-utils via cmake.

> I haven't built with autotools for quite some time and last
> time I tried it didn't work. If this is being used on travis, I assume it
> is now working so I will try to build with it.
It should work indeed.

> 
> Also, the tests with cmake failed:  86 - sqlite3test (SEGFAULT)

Yes, I have run into this as well before. This seems to happen if the test is 
run more than once. The first time works, later runs fail. I suspect this has 
to do with sqlite refusing to overwrite an existing (temporary) file, but I 
never found time to hunt it down.

Regards,

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: gnucash master: Book-Currency Feature step 6

[Alex Aycinena]

>
> -- Forwarded message --
> From: Geert Janssens 
> To: gnucash-devel@gnucash.org
> Cc:
> Bcc:
> Date: Mon, 10 Jul 2017 15:45:57 +0200
> Subject: Re: gnucash master: Book-Currency Feature step 6
> Alex,
>
> This commit has broken make check on travis:
> https://travis-ci.org/Gnucash/gnucash/builds/251783000
>
> Can you check the error ?
>
> Regards,
>
> Geert
>

Geert,

I have pushed a fix for this.

By the way, this points out to me that if I run make check (or ninja-build
check) with cmake, it doesn't run all the same tests as those with building
with autotools because I had incorrectly assumed that this test had run and
run correctly. I haven't built with autotools for quite some time and last
time I tried it didn't work. If this is being used on travis, I assume it
is now working so I will try to build with it.

Also, the tests with cmake failed:  86 - sqlite3test (SEGFAULT)

Regards,

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: gnucash master: Book-Currency Feature step 6

[Robert Fewell]

I did not realise that this content was so new, it showed up in my last
build log and I thought it was stuff from master that needed the deprecated
widgets converted, mainly table to grid and a vbox.

Shall I leave this for Alex to convert or wait for this to be fixed ?

Bob

On 10 July 2017 at 14:45, Geert Janssens  wrote:

> Alex,
>
> This commit has broken make check on travis:
> https://travis-ci.org/Gnucash/gnucash/builds/251783000
>
> Can you check the error ?
>
> Regards,
>
> Geert
>
> On zondag 9 juli 2017 21:25:09 CEST J. Alex Aycinena wrote:
> > Updatedvia  https://github.com/Gnucash/gnucash/commit/2020bee0
> (commit)
> >   from  https://github.com/Gnucash/gnucash/commit/a7f1f9cd (commit)
> >
> >
> >
> > commit 2020bee03b5e92529f0f8377c487e2b163124561
> > Author: Alex Aycinena 
> > Date:   Sun Jul 9 12:19:36 2017 -0700
> >
> > Book-Currency Feature step 6
> >
> > Modify File->Properties dialog to maintain a default gain/loss
> account
> > in a book KVP.
> >
> > The changes made are:
> >
> >   app-utils/app-utils.scm - define items related to book default
> > gain/loss acct
> >   app-utils/business-prefs.scm - define items related to book default
> > gain/loss acct;re-arrange sequence of options to make default
> > (neither) first
> > app-utils/gnc-ui-util.c - refine gnc_book_get_default_gains_
> policy
> > to check for hidden and/or placeholder status
> >   app-utils/option-util.c & h - define items related to book default
> > gain/loss acct
> >   app-utils/options.scm - add functionality related to book default
> > gain/loss acct
> > app-utils/test/test-gnc-ui-util.c - for
> > gnc_book_get_default_gains_policy, add tests to check for hidden and/or
> > placeholder status app-utils/test/test-option-util.cpp - add tests
> related
> > to book default gain/loss acct
> >   engine/engine.i - define item related to book default gain/loss
> acct
> >   gnome-utils/dialog-options.c & h - add functionality related to
> book
> > default gain/loss acct and rearrange dialog layout; make gain/loss acct
> > widget refresh on account maintenance
> > gnome-utils/gnc-main-window.c - only allow one book-option
> dialog if
> > called from file->properties
> >   gnome-utils/gtkbuilder/dialog-options.glade - increase dialog
> height to
> > accomodate book default gain/loss acct widget; add tooltip text for
> dialog
> > buttons
> > gnome/assistant-hierarchy.c - change sequence of pages: book
> options
> > before currency selection; if book currency selected, currency also
> > selected gnome/gtkbuilder/assistant-hierarchy.glade - increase dialog
> > height to accomodate book default gain/loss acct widget
> >
> >
> >
> > Summary of changes:
> >  src/app-utils/app-utils.scm |8 +-
> >  src/app-utils/business-prefs.scm|   14 +-
> >  src/app-utils/gnc-ui-util.c |   18 +-
> >  src/app-utils/option-util.c |   45 +
> >  src/app-utils/option-util.h |2 +
> >  src/app-utils/options.scm   |  116 ++-
> >  src/app-utils/test/test-gnc-ui-util.c   |  130 ++-
> >  src/app-utils/test/test-option-util.cpp |   46 +-
> >  src/engine/engine.i |1 +
> >  src/gnome-utils/dialog-options.c| 1100
> > --- src/gnome-utils/dialog-options.h
> |
> >  3 +-
> >  src/gnome-utils/gnc-main-window.c   |   22 +-
> >  src/gnome-utils/gtkbuilder/dialog-options.glade |5 +-
> >  src/gnome/assistant-hierarchy.c |   62 +-
> >  src/gnome/gtkbuilder/assistant-hierarchy.glade  |2 +-
> >  15 files changed, 1198 insertions(+), 376 deletions(-)
> >
> > ___
> > gnucash-patches mailing list
> > gnucash-patc...@gnucash.org
> > https://lists.gnucash.org/mailman/listinfo/gnucash-patches
>
>
> ___
> gnucash-devel mailing list
> gnucash-devel@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-devel
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: gnucash master: Book-Currency Feature step 6

[Geert Janssens]

Alex,

This commit has broken make check on travis:
https://travis-ci.org/Gnucash/gnucash/builds/251783000

Can you check the error ?

Regards,

Geert

On zondag 9 juli 2017 21:25:09 CEST J. Alex Aycinena wrote:
> Updatedvia  https://github.com/Gnucash/gnucash/commit/2020bee0 
> (commit)
>   from  https://github.com/Gnucash/gnucash/commit/a7f1f9cd (commit)
> 
> 
> 
> commit 2020bee03b5e92529f0f8377c487e2b163124561
> Author: Alex Aycinena 
> Date:   Sun Jul 9 12:19:36 2017 -0700
> 
> Book-Currency Feature step 6
> 
> Modify File->Properties dialog to maintain a default gain/loss account
> in a book KVP.
> 
> The changes made are:
> 
>   app-utils/app-utils.scm - define items related to book default
> gain/loss acct
>   app-utils/business-prefs.scm - define items related to book default
> gain/loss acct;re-arrange sequence of options to make default
> (neither) first
> app-utils/gnc-ui-util.c - refine gnc_book_get_default_gains_policy
> to check for hidden and/or placeholder status
>   app-utils/option-util.c & h - define items related to book default
> gain/loss acct
>   app-utils/options.scm - add functionality related to book default
> gain/loss acct
> app-utils/test/test-gnc-ui-util.c - for
> gnc_book_get_default_gains_policy, add tests to check for hidden and/or
> placeholder status app-utils/test/test-option-util.cpp - add tests related
> to book default gain/loss acct
>   engine/engine.i - define item related to book default gain/loss acct
>   gnome-utils/dialog-options.c & h - add functionality related to book
> default gain/loss acct and rearrange dialog layout; make gain/loss acct
> widget refresh on account maintenance
> gnome-utils/gnc-main-window.c - only allow one book-option dialog if
> called from file->properties
>   gnome-utils/gtkbuilder/dialog-options.glade - increase dialog height to
> accomodate book default gain/loss acct widget; add tooltip text for dialog
> buttons
> gnome/assistant-hierarchy.c - change sequence of pages: book options
> before currency selection; if book currency selected, currency also
> selected gnome/gtkbuilder/assistant-hierarchy.glade - increase dialog
> height to accomodate book default gain/loss acct widget
> 
> 
> 
> Summary of changes:
>  src/app-utils/app-utils.scm |8 +-
>  src/app-utils/business-prefs.scm|   14 +-
>  src/app-utils/gnc-ui-util.c |   18 +-
>  src/app-utils/option-util.c |   45 +
>  src/app-utils/option-util.h |2 +
>  src/app-utils/options.scm   |  116 ++-
>  src/app-utils/test/test-gnc-ui-util.c   |  130 ++-
>  src/app-utils/test/test-option-util.cpp |   46 +-
>  src/engine/engine.i |1 +
>  src/gnome-utils/dialog-options.c| 1100
> --- src/gnome-utils/dialog-options.h|  
>  3 +-
>  src/gnome-utils/gnc-main-window.c   |   22 +-
>  src/gnome-utils/gtkbuilder/dialog-options.glade |5 +-
>  src/gnome/assistant-hierarchy.c |   62 +-
>  src/gnome/gtkbuilder/assistant-hierarchy.glade  |2 +-
>  15 files changed, 1198 insertions(+), 376 deletions(-)
> 
> ___
> gnucash-patches mailing list
> gnucash-patc...@gnucash.org
> https://lists.gnucash.org/mailman/listinfo/gnucash-patches


___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Re: build after last update

[Geert Janssens]

On zondag 9 juli 2017 22:33:34 CEST Alex Aycinena wrote:
> Spoke too soon. When I tried to start gnucash with 'bin/gnucash --debug
> --log gnc.scm=debug --nofile', got:
> 
> gnc.gui:ERROR:/home/gnucash-dev/gitcheckouts/gnucash-clean-new/src/gnome-uti
> ls/gnc-icons.c:103:gnc_load_app_icons: assertion failed:
> (gtk_icon_theme_has_icon (icon_theme, file->icon_name)) Aborted (core
> dumped)

Alex,

I have rewritten this function to avoid the assert. It wasn't really required. 
That doesn't explain though why you hit it and I don't.

So I have added some debug output (to be enabled by setting gnc.gui=info). 
This will print out all paths where gtk will search for our icons.

Can you check whether the icons the new function will complain about are 
available in any subdirectory of these directories ?

Geert
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel