Re: gnucash master: Book-Currency Feature step 6

2017-07-16 Thread Alex Aycinena
Fix subject on email

On Sun, Jul 16, 2017 at 6:49 PM, Alex Aycinena 
wrote:

> John,
>
>
>
>> -- Forwarded message --
>> From: John Ralls 
>> To: Robert Fewell <14ubo...@gmail.com>
>> Cc: Geert Janssens , "
>> gnucash-devel@gnucash.org" 
>> Bcc:
>> Date: Sat, 15 Jul 2017 13:59:32 -0700
>> Subject: Re: gnucash master: Book-Currency Feature step 6
>> Alex,
>>
>> How many more steps do you have in mind for this feature
>
>
> many
>
>
>> and how long do you think it will take?
>
>
> a long time, because I have spent less time on it than I thought initially
> I could due to other commitments
>
>
>> I ask because it's time to start thinking about setting feature, string,
>> and code freeze dates for 2.8.
>>
>> Regards,
>> John Ralls
>>
>>
> I can easily comment out the changes to File->Properties and then it will
> look like nothing has changed. I can make further changes on a separate
> branch going forward.
>
> Alex
>
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gnucash-devel Digest, Vol 172, Issue 15

2017-07-16 Thread Alex Aycinena
John,



> -- Forwarded message --
> From: John Ralls 
> To: Robert Fewell <14ubo...@gmail.com>
> Cc: Geert Janssens , "
> gnucash-devel@gnucash.org" 
> Bcc:
> Date: Sat, 15 Jul 2017 13:59:32 -0700
> Subject: Re: gnucash master: Book-Currency Feature step 6
> Alex,
>
> How many more steps do you have in mind for this feature


many


> and how long do you think it will take?


a long time, because I have spent less time on it than I thought initially
I could due to other commitments


> I ask because it's time to start thinking about setting feature, string,
> and code freeze dates for 2.8.
>
> Regards,
> John Ralls
>
>
I can easily comment out the changes to File->Properties and then it will
look like nothing has changed. I can make further changes on a separate
branch going forward.

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: gnucash master: Book-Currency Feature step 6

2017-07-16 Thread Alex Aycinena
Bob,


> -- Forwarded message --
> From: Robert Fewell <14ubo...@gmail.com>
> To: Geert Janssens 
> Cc: "gnucash-devel@gnucash.org" 
> Bcc:
> Date: Sat, 15 Jul 2017 18:18:25 +0100
> Subject: Re: gnucash master: Book-Currency Feature step 6
> I have changed the widgets mainly from GtkTable to GtkGrid in my latest
> pull request. As part of this I have added a function to blank the currency
> edit widget instead of having to destroy the widget and create a new one as
> this was creating errors in my trace file. I am not realy sure how this
> book-currency feature should work but visually it looks the same, Alex can
> you check it after it is merged to master and correct any thing I have got
> wrong.
>
> Bob
>
> On 10 July 2017 at 21:08, Geert Janssens 
> wrote:
>
> > On maandag 10 juli 2017 18:31:25 CEST Robert Fewell wrote:
> > > I did not realise that this content was so new, it showed up in my last
> > > build log and I thought it was stuff from master that needed the
> > deprecated
> > > widgets converted, mainly table to grid and a vbox.
> > >
> > > Shall I leave this for Alex to convert or wait for this to be fixed ?
> > >
> > > Bob
> >
> > The problem is fixed so feel free to convert all that is still
> deprecated.
> >
>

< snip >


> >
> > Geert
> >
>

Thanks for doing this. I looked it over pretty carefully and it all looks
good to me. I will use it as a guide in future work.

I will next be dealing with account maintenance. Have you already converted
that area?

Alex
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Master Build problem

2017-07-16 Thread John Ralls

> On Jul 16, 2017, at 8:42 AM, Geert Janssens  
> wrote:
> 
> That is the same error I was having last week when building with aqbanking.
> 
> John recently made building with aqbanking the default. But clearly there is 
> something missing for it.
> 
> Until this is fixed you can disable building with aqbanking by setting an 
> option to cmake
> 
> Regards
> 
> Geert
> 
> Robert Fewell <14ubo...@gmail.com> schreef op 16 juli 2017 13:27:31 CEST:
>> I having trouble with the latest master, it will not build for the
>> following reason...
>> 
>> I the build directory _build/src/import-export/aqb/gschemas there
>> should be
>> three gschema files but they are missing. One file is in the source
>> directory and I think the other two are created but I can not see why
>> they
>> are not.
>> I assume there is some cmake stuff that is missing but can not see it
>> at
>> the moment.

Yeah, I don't see the problem either after staring at it for a bit. The cmake 
option to bypass it is -DWITH_AQBANKING=No .

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Webkit-gtk version

2017-07-16 Thread John Ralls

> On Jul 16, 2017, at 4:19 AM, Robert Fewell <14ubo...@gmail.com> wrote:
> 
> Just want to clarify what versions of webkit-gtk is now required. My test
> VM that has gtk3.10 and webkit2gtk-4.0, version 2.6.6 which does not have
> "allow-file-access-from-file-urls", 2.10 has this and so end up with error
> in trace file and there is also a critical error when I close gnucash with
> a report page open. My other test VM has gtk3.22 and webkit2gtk-4.0,
> version 2.16.3 and so I do not see this problem.
> 
> I suppose if it tested for version 2.10 and was not found it could fallback
> to webkit1gtk which I think is also installed.

Bob,

Fixed and pushed. That property and allow-universal-access-from-file-urls just 
needed to be version-checked.

Regards,
John Ralls

___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Re: Master Build problem

2017-07-16 Thread Geert Janssens
That is the same error I was having last week when building with aqbanking.

John recently made building with aqbanking the default. But clearly there is 
something missing for it.

Until this is fixed you can disable building with aqbanking by setting an 
option to cmake

Regards

Geert

Robert Fewell <14ubo...@gmail.com> schreef op 16 juli 2017 13:27:31 CEST:
>I having trouble with the latest master, it will not build for the
>following reason...
>
>I the build directory _build/src/import-export/aqb/gschemas there
>should be
>three gschema files but they are missing. One file is in the source
>directory and I think the other two are created but I can not see why
>they
>are not.
>I assume there is some cmake stuff that is missing but can not see it
>at
>the moment.
>
>Bob
>___
>gnucash-devel mailing list
>gnucash-devel@gnucash.org
>https://lists.gnucash.org/mailman/listinfo/gnucash-devel

Sent from my smartphone. Please excuse my brevity.
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Master Build problem

2017-07-16 Thread Robert Fewell
I having trouble with the latest master, it will not build for the
following reason...

I the build directory _build/src/import-export/aqb/gschemas there should be
three gschema files but they are missing. One file is in the source
directory and I think the other two are created but I can not see why they
are not.
I assume there is some cmake stuff that is missing but can not see it at
the moment.

Bob
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel


Webkit-gtk version

2017-07-16 Thread Robert Fewell
Just want to clarify what versions of webkit-gtk is now required. My test
VM that has gtk3.10 and webkit2gtk-4.0, version 2.6.6 which does not have
"allow-file-access-from-file-urls", 2.10 has this and so end up with error
in trace file and there is also a critical error when I close gnucash with
a report page open. My other test VM has gtk3.22 and webkit2gtk-4.0,
version 2.16.3 and so I do not see this problem.

I suppose if it tested for version 2.10 and was not found it could fallback
to webkit1gtk which I think is also installed.

Bob
___
gnucash-devel mailing list
gnucash-devel@gnucash.org
https://lists.gnucash.org/mailman/listinfo/gnucash-devel