Re: [GNUnet-developers] gnunet-nim bug on "removed cadet option"

2019-08-02 Thread dvn
I've bumped the version accordingly. Thanks Marcos.

Marcos Marado transcribed 7.4K bytes:
> Hi,
> 
> It was indeed an issue with me still being on an older GNUnet version.
> I was trying groupchat's HEAD, and since I build using its Makefile, I am
> also using an updated gnunet-nim (which now works only against the latest
> GNUnet version).
> 
> Please consider the small patch in attachment, as this simple change would
> have spared me the wasted time, and all of us this e-mail thread :-)
> 
> Thanks for your quick support,
> 
> On Tue, Jul 30, 2019 at 5:43 AM t3sserakt  wrote:
> 
> > Hey Marcos,
> >
> > did you update GNUnet?
> >
> > Which revisions of groupchat, gnunet-nim and GNUnet do you use?
> >
> > Happy hacking!
> >
> > t3sserakt
> >
> > On 30.07.2019 00:22, Marcos Marado wrote:
> >
> > Hi,
> >
> > I haven't had time to debug this too much, but either gunet-nim's latest
> > commit,
> > "removed cadet option"[1], is buggy, or at least the only good example I
> > know
> > of it (groupchat) needs to be updated to work with it.
> >
> > With that commit on gnunet-nim, groupchat's client will get a server
> > message
> > without data, and enter this 'if not' clause:
> >
> > proc processServerMessages(channel: ref CadetChannel, tui: Tui) {.async.} =
> >   while true:
> > let (hasData, message) = await channel.messages.read()
> > if not hasData:
> >   shutdownGnunetApplication()
> >
> > [1]
> > https://git.gnunet.org/gnunet-nim.git/commit/?id=38c51715cfe0b2c6cdc662cffcc8de2eec8d28a9
> >
> > Best regards,
> > --
> > Marcos Marado
> >
> >
> > ___
> > GNUnet-developers mailing 
> > listGNUnet-developers@gnu.orghttps://lists.gnu.org/mailman/listinfo/gnunet-developers
> >
> >
> > ___
> > GNUnet-developers mailing list
> > GNUnet-developers@gnu.org
> > https://lists.gnu.org/mailman/listinfo/gnunet-developers
> >


> ___
> GNUnet-developers mailing list
> GNUnet-developers@gnu.org
> https://lists.gnu.org/mailman/listinfo/gnunet-developers



signature.asc
Description: PGP signature
___
GNUnet-developers mailing list
GNUnet-developers@gnu.org
https://lists.gnu.org/mailman/listinfo/gnunet-developers


Re: [GNUnet-developers] gnunet-nim bug on "removed cadet option"

2019-08-02 Thread Marcos Marado
Hi,

It was indeed an issue with me still being on an older GNUnet version.
I was trying groupchat's HEAD, and since I build using its Makefile, I am
also using an updated gnunet-nim (which now works only against the latest
GNUnet version).

Please consider the small patch in attachment, as this simple change would
have spared me the wasted time, and all of us this e-mail thread :-)

Thanks for your quick support,

On Tue, Jul 30, 2019 at 5:43 AM t3sserakt  wrote:

> Hey Marcos,
>
> did you update GNUnet?
>
> Which revisions of groupchat, gnunet-nim and GNUnet do you use?
>
> Happy hacking!
>
> t3sserakt
>
> On 30.07.2019 00:22, Marcos Marado wrote:
>
> Hi,
>
> I haven't had time to debug this too much, but either gunet-nim's latest
> commit,
> "removed cadet option"[1], is buggy, or at least the only good example I
> know
> of it (groupchat) needs to be updated to work with it.
>
> With that commit on gnunet-nim, groupchat's client will get a server
> message
> without data, and enter this 'if not' clause:
>
> proc processServerMessages(channel: ref CadetChannel, tui: Tui) {.async.} =
>   while true:
> let (hasData, message) = await channel.messages.read()
> if not hasData:
>   shutdownGnunetApplication()
>
> [1]
> https://git.gnunet.org/gnunet-nim.git/commit/?id=38c51715cfe0b2c6cdc662cffcc8de2eec8d28a9
>
> Best regards,
> --
> Marcos Marado
>
>
> ___
> GNUnet-developers mailing 
> listGNUnet-developers@gnu.orghttps://lists.gnu.org/mailman/listinfo/gnunet-developers
>
>
> ___
> GNUnet-developers mailing list
> GNUnet-developers@gnu.org
> https://lists.gnu.org/mailman/listinfo/gnunet-developers
>
From a80dc8bc90026b1a935dcde602657831d5d75de6 Mon Sep 17 00:00:00 2001
From: Marcos Marado 
Date: Fri, 2 Aug 2019 23:47:00 +0100
Subject: [PATCH] Raised dependency on GNUnet to 0.11.6

Since groupchat always builds against the latest gnunet_nim, and gnunet_nim now
depends on GNUnet 0.11.6, let's adjust the version of the dependency here.
---
 README.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/README.rst b/README.rst
index 0df5502..ab0e332 100644
--- a/README.rst
+++ b/README.rst
@@ -10,7 +10,7 @@ Installation
 Requirements
 
 
-* GNUnet >= 0.11.0 (https://gnunet.org)
+* GNUnet >= 0.11.6 (https://gnunet.org)
 * Nim >= 0.18.0(https://nim-lang.org)
 
 Install
-- 
2.20.1

___
GNUnet-developers mailing list
GNUnet-developers@gnu.org
https://lists.gnu.org/mailman/listinfo/gnunet-developers