Re: [groupchat] [PATCH] beautify quitting message

[lurchi]

Hello Marcos,

thank you for the patch. I will apply it as soon as I get the groupchat
working again on my machine (there are issues with current Nim and
GNUnet).

lurchi.


On Fri, 17 Apr 2020 13:21:01 +0100
Marcos Marado  wrote:

> When running as a client, and the application ends but not caused by
> user input (C-c), the there is no carriage return after the exit
> message, and so the 'quitting' message will drag the terminal prompt
> forward.
> 
> This patch fixes that cosmetic bug by adding a carriage return to the
> quitting message.
> ---
>  src/groupchat.nim | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/groupchat.nim b/src/groupchat.nim
> index d35816b..323f422 100644
> --- a/src/groupchat.nim
> +++ b/src/groupchat.nim
> @@ -235,7 +235,7 @@ proc main() =
>  gnunetApp.doWork()
>  stdout.flushFile()
> 
> -  echo "quitting"
> +  echo "quitting\r"
>stdout.flushFile()
>stdin.flushFile()
> 



pgpdnpAmmXqAI.pgp
Description: OpenPGP digital signature

[groupchat] [PATCH] beautify quitting message

[Marcos Marado]

When running as a client, and the application ends but not caused by
user input (C-c), the there is no carriage return after the exit
message, and so the 'quitting' message will drag the terminal prompt
forward.

This patch fixes that cosmetic bug by adding a carriage return to the
quitting message.
---
 src/groupchat.nim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/groupchat.nim b/src/groupchat.nim
index d35816b..323f422 100644
--- a/src/groupchat.nim
+++ b/src/groupchat.nim
@@ -235,7 +235,7 @@ proc main() =
 gnunetApp.doWork()
 stdout.flushFile()

-  echo "quitting"
+  echo "quitting\r"
   stdout.flushFile()
   stdin.flushFile()

-- 
2.20.1
From cacd40a614a7d1cc757d9109fb7aaf15e40c75a7 Mon Sep 17 00:00:00 2001
From: Marcos Marado 
Date: Fri, 17 Apr 2020 12:51:16 +0100
Subject: [PATCH] beautify quitting message

When running as a client, and the application ends but not caused by
user input (C-c), the there is no carriage return after the exit
message, and so the 'quitting' message will drag the terminal prompt
forward.

This patch fixes that cosmetic bug by adding a carriage return to the
quitting message.
---
 src/groupchat.nim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/groupchat.nim b/src/groupchat.nim
index d35816b..323f422 100644
--- a/src/groupchat.nim
+++ b/src/groupchat.nim
@@ -235,7 +235,7 @@ proc main() =
 gnunetApp.doWork()
 stdout.flushFile()
 
-  echo "quitting"
+  echo "quitting\r"
   stdout.flushFile()
   stdin.flushFile()
 
-- 
2.20.1