Re: Question about PoolingHttpClientConnectionManager#timeToLive

2016-03-09 Thread Oleg Kalnichevski 
On Wed, 2016-03-09 at 13:07 +0100, Philippe Mouawad wrote:
> Hi Oleg,
> Thanks for clarification.
> Regards
> 
> On Wed, Mar 9, 2016 at 10:40 AM, Oleg Kalnichevski  wrote:
> 
> > On Wed, 2016-03-09 at 08:40 +0100, Philippe Mouawad wrote:
> > > Hello,
> > > I would like a clarification on the
> > > PoolingHttpClientConnectionManager#timeToLive that is used to construct
> > the
> > > PoolingHttpClientConnectionManager.
> > >
> > > In my understanding this value should not exceed the Keep Alive timeout
> > > sent by a server.
> > > Am I right or am I misunderstanding it ?
> > >
> >
> > TTL represent an absolute value. No matter what the connection will not
> > be re-used beyond its TTL. Keep-alive value is relative and gets updated
> > every time connection is re-used.
> >
> 
> Do you want me to open a JIRA  +PR to add this to documentation ?
> 

Sure. Please do so.

Oleg


-
To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org
For additional commands, e-mail: httpclient-users-h...@hc.apache.org

Re: Question about PoolingHttpClientConnectionManager#timeToLive

2016-03-09 Thread Philippe Mouawad 
Hi Oleg,
Thanks for clarification.
Regards

On Wed, Mar 9, 2016 at 10:40 AM, Oleg Kalnichevski  wrote:

> On Wed, 2016-03-09 at 08:40 +0100, Philippe Mouawad wrote:
> > Hello,
> > I would like a clarification on the
> > PoolingHttpClientConnectionManager#timeToLive that is used to construct
> the
> > PoolingHttpClientConnectionManager.
> >
> > In my understanding this value should not exceed the Keep Alive timeout
> > sent by a server.
> > Am I right or am I misunderstanding it ?
> >
>
> TTL represent an absolute value. No matter what the connection will not
> be re-used beyond its TTL. Keep-alive value is relative and gets updated
> every time connection is re-used.
>

Do you want me to open a JIRA  +PR to add this to documentation ?

>
> > I think it should be better documented
> >
> >
> > Also another question about the call of this in the constructor:
> > this.pool.setValidateAfterInactivity(2000);
> >
> > Why isn't this value exposed to configuration ?
> > Am I wrong to think that it should be < Time to live in millis ?
> >
>
> No you are not. If the stale check time is greater than TTL it will
> simply have no effect.
>

Ok. clear

>
> Oleg
>
>
> -
> To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org
> For additional commands, e-mail: httpclient-users-h...@hc.apache.org
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: Question about PoolingHttpClientConnectionManager#timeToLive

2016-03-09 Thread Oleg Kalnichevski 
On Wed, 2016-03-09 at 08:40 +0100, Philippe Mouawad wrote:
> Hello,
> I would like a clarification on the
> PoolingHttpClientConnectionManager#timeToLive that is used to construct the
> PoolingHttpClientConnectionManager.
> 
> In my understanding this value should not exceed the Keep Alive timeout
> sent by a server.
> Am I right or am I misunderstanding it ?
> 

TTL represent an absolute value. No matter what the connection will not
be re-used beyond its TTL. Keep-alive value is relative and gets updated
every time connection is re-used.

> I think it should be better documented
> 
> 
> Also another question about the call of this in the constructor:
> this.pool.setValidateAfterInactivity(2000);
> 
> Why isn't this value exposed to configuration ?
> Am I wrong to think that it should be < Time to live in millis ?
> 

No you are not. If the stale check time is greater than TTL it will
simply have no effect.

Oleg


-
To unsubscribe, e-mail: httpclient-users-unsubscr...@hc.apache.org
For additional commands, e-mail: httpclient-users-h...@hc.apache.org