date:20180301

[GitHub] carbondata issue #2021: [CARBONDATA-2221] Throw exception when dropTable fai...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2021
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4027/



---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1812
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4026/



---

[GitHub] carbondata issue #2020: [CARBONDATA-2220] Reduce unnecessary audit log

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2020
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4025/



---

[GitHub] carbondata pull request #2021: [CARBONDATA-2221] Throw exception when dropTa...

2018-03-01 Thread jackylk

GitHub user jackylk opened a pull request:

https://github.com/apache/carbondata/pull/2021

[CARBONDATA-2221] Throw exception when dropTable failed in metastore

When dropping table, exception should be not ignored if dropTable failed in 
metastore. This PR throws the exception to the user.

 - [X] Any interfaces changed?
 No
 - [X] Any backward compatibility impacted?
 No
 - [X] Document update required?
No
 - [X] Testing done
Re-run all test
 - [X] For large changes, please consider breaking it into sub-tasks under 
an umbrella JIRA. 
NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jackylk/incubator-carbondata 
droptable-throwexception

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/carbondata/pull/2021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2021


commit 309a94b6fb2bf88cbb7827c9dd5a296a6fe5304a
Author: Jacky Li 
Date:   2018-03-02T07:46:27Z

throw exception




---

[jira] [Created] (CARBONDATA-2221) Drop table should throw exception when metastore operation failed

2018-03-01 Thread Jacky Li (JIRA)

Jacky Li created CARBONDATA-2221:


 Summary: Drop table should throw exception when metastore 
operation failed
 Key: CARBONDATA-2221
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2221
 Project: CarbonData
  Issue Type: Bug
Reporter: Jacky Li
 Fix For: 1.3.1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #1812: [CARBONDATA-2033]Support user specified segments in ...

2018-03-01 Thread Xaprice

Github user Xaprice commented on the issue:

https://github.com/apache/carbondata/pull/1812
  
retest this please


---

[GitHub] carbondata issue #2019: [CARBONDATA-2172][Lucene] Add text_columns property ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2019
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2777/



---

[GitHub] carbondata issue #2019: [CARBONDATA-2172][Lucene] Add text_columns property ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2019
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4021/



---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]support user specified segments in ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1812
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2778/



---

[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1999
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2776/



---

[GitHub] carbondata issue #1812: [CARBONDATA-2033]support user specified segments in ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1812
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4022/



---

[GitHub] carbondata issue #1999: [CARBONDATA-2204] Optimized number of reads of table...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1999
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4020/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2775/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4019/



---

[GitHub] carbondata issue #2006: [CARBONDATA-2209] Fixed rename table with partitions...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2006
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2774/



---

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

2018-03-01 Thread kunal642

Github user kunal642 commented on the issue:

https://github.com/apache/carbondata/pull/2017
  
LGTM


---

[jira] [Created] (CARBONDATA-2219) Add validation for external partition location to use same schema

2018-03-01 Thread Ravindra Pesala (JIRA)

Ravindra Pesala created CARBONDATA-2219:
---

 Summary: Add validation for external partition location to use 
same schema
 Key: CARBONDATA-2219
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2219
 Project: CarbonData
  Issue Type: Bug
Reporter: Ravindra Pesala






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2019: [CARBONDATA-2172][Lucene] Add text_columns property ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2019
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2773/



---

[jira] [Created] (CARBONDATA-2218) AlluxioCarbonFile while trying to force rename causes a FileSytem error and is not a DistributionFileSystem.

2018-03-01 Thread ChandraSekhar Saripaka (JIRA)

ChandraSekhar Saripaka created CARBONDATA-2218:
--

 Summary: AlluxioCarbonFile while trying to force rename causes a 
FileSytem error and is not a DistributionFileSystem.
 Key: CARBONDATA-2218
 URL: https://issues.apache.org/jira/browse/CARBONDATA-2218
 Project: CarbonData
  Issue Type: Bug
  Components: core
Affects Versions: 1.4.0
Reporter: ChandraSekhar Saripaka
 Attachments: spark2-shell_carbondata_2.11-1.4.0-SNAPSHOT.log

AlluxioCarbonFile appears to rely on a DistributedFileSystem, but this always 
returns a o.a.hadoop.fs.FileSystem. So, kindly provide a way to make it work 
with Alluxio as the file system they have is a AbstractFileSystem. Also, please 
add more tests to the Alluxio.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2772/



---

[jira] [Resolved] (CARBONDATA-2211) Alter Table Streaming DDL should blocking DDL like other DDL ( All DDL are blocking DDL)

2018-03-01 Thread QiangCai (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai resolved CARBONDATA-2211.
--
   Resolution: Fixed
Fix Version/s: 1.3.1

> Alter Table Streaming DDL should blocking DDL like other DDL ( All DDL are 
> blocking DDL)
> 
>
> Key: CARBONDATA-2211
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2211
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Rahul Kumar
>Assignee: Rahul Kumar
>Priority: Major
> Fix For: 1.3.1
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> DDL displayed output immediately.  But compaction took more time.
> it should be Blocking so that if any issue comes in the Alter (compaction ) 
> result of DDL can be error (exception) so that use can check ERROR why  
> compaction is failed. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #2008: [CARBONDATA-2211] in case of DDL HandOff shou...

2018-03-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2008


---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...

2018-03-01 Thread QiangCai

Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
LGTM


---

[GitHub] carbondata issue #1995: [WIP] File Format Reader

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1995
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4014/



---

[GitHub] carbondata issue #1995: [WIP] File Format Reader

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1995
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2770/



---

[GitHub] carbondata pull request #2019: [CARBONDATA-2172][Lucene] Add text_columns pr...

2018-03-01 Thread jackylk

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2019#discussion_r171568299
  
--- Diff: 
datamap/lucene/src/main/java/org/apache/carbondata/datamap/lucene/LuceneDataMapFactoryBase.java
 ---
@@ -133,6 +120,44 @@ public void init(AbsoluteTableIdentifier identifier, 
DataMapSchema dataMapSchema
 analyzer = new StandardAnalyzer();
   }
 
+  private List validateAndGetIndexedColumns(DataMapSchema 
dataMapSchema,
--- End diff --

add comment, what is validated


---

[GitHub] carbondata pull request #2019: [CARBONDATA-2172][Lucene] Add text_columns pr...

2018-03-01 Thread jackylk

Github user jackylk commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/2019#discussion_r171568091
  
--- Diff: datamap/lucene/pom.xml ---
@@ -96,6 +96,11 @@
   scalatest_${scala.binary.version}
   test
 
+
+  commons-lang
+  commons-lang
+  2.6
--- End diff --

move this version definition to parent


---

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2017
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4013/



---

[GitHub] carbondata issue #2017: [CARBONDATA-2217]fix drop partition for non existing...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2017
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2769/



---

[GitHub] carbondata issue #1956: [HOTFIX] Add partition usage code

2018-03-01 Thread ravipesala

Github user ravipesala commented on the issue:

https://github.com/apache/carbondata/pull/1956
  
@chenliang613 Please fix checkstyle issues


---

[GitHub] carbondata issue #1995: [WIP] File Format Reader

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1995
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2768/



---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2766/



---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HandOff should not ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4010/



---

[GitHub] carbondata issue #1995: [WIP] File Format Reader

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1995
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2767/



---

[GitHub] carbondata issue #1995: [WIP] File Format Reader

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1995
  
Build Failed  with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4011/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread QiangCai

Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
LGTM


---

[jira] [Resolved] (CARBONDATA-2055) Support integrating Streaming table with Spark Streaming

2018-03-01 Thread QiangCai (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai resolved CARBONDATA-2055.
--
   Resolution: Fixed
Fix Version/s: 1.3.1

> Support integrating Streaming table with Spark Streaming
> 
>
> Key: CARBONDATA-2055
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2055
> Project: CarbonData
>  Issue Type: New Feature
>  Components: spark-integration
>Reporter: Zhichao  Zhang
>Assignee: Zhichao  Zhang
>Priority: Minor
> Fix For: 1.3.1
>
>  Time Spent: 15h 40m
>  Remaining Estimate: 0h
>
> Currently CarbonData just support integrating 
> with Spark Structured Streaming which requires Kafka's version must be >= 
> 0.10. But there are still many users  integrating Spark Streaming with 
> kafka 0.8, the cost of upgrading kafka is too 
> much. So CarbonData need to integrate with Spark Streaming too.
> Please see the discussion in mailing list:
> [http://apache-carbondata-dev-mailing-list-archive.1130556.n5.nabble.com/Should-CarbonData-need-to-integrate-with-Spark-Streaming-too-td35341.html]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata issue #2006: [CARBONDATA-2209] Fixed rename table with partitions...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2006
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4009/



---

[GitHub] carbondata issue #2006: [CARBONDATA-2209] Fixed rename table with partitions...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2006
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2765/



---

[GitHub] carbondata issue #1867: [CARBONDATA-2055][Streaming]Support integrating Stre...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1867
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4008/



---

[GitHub] carbondata issue #1867: [CARBONDATA-2055][Streaming]Support integrating Stre...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1867
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2764/



---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
Build Failed with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2763/



---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4007/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4006/



---

[GitHub] carbondata issue #1991: [CARBONDATA-2196]carbontable should be taken from lo...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1991
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2762/



---

[GitHub] carbondata issue #1930: [CARBONDATA-2130] Find some spelling error in Carbon...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1930
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2761/



---

[GitHub] carbondata issue #1930: [CARBONDATA-2130] Find some spelling error in Carbon...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/1930
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4005/



---

[jira] [Resolved] (CARBONDATA-2212) Event should be fired from Stream before and after updating the status

2018-03-01 Thread QiangCai (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai resolved CARBONDATA-2212.
--
Resolution: Fixed

> Event should be fired from Stream before and after updating the status
> --
>
> Key: CARBONDATA-2212
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2212
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Rahul Kumar
>Assignee: Rahul Kumar
>Priority: Major
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (CARBONDATA-2212) Event should be fired from Stream before and after updating the status

2018-03-01 Thread QiangCai (JIRA)


 [ 
https://issues.apache.org/jira/browse/CARBONDATA-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

QiangCai updated CARBONDATA-2212:
-
Fix Version/s: 1.3.1

> Event should be fired from Stream before and after updating the status
> --
>
> Key: CARBONDATA-2212
> URL: https://issues.apache.org/jira/browse/CARBONDATA-2212
> Project: CarbonData
>  Issue Type: Bug
>Reporter: Rahul Kumar
>Assignee: Rahul Kumar
>Priority: Major
> Fix For: 1.3.1
>
>  Time Spent: 1.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] carbondata pull request #2009: [CARBONDATA-2212] event fired while updating ...

2018-03-01 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/carbondata/pull/2009


---

[GitHub] carbondata issue #2008: [CARBONDATA-2211] in case of DDL HndOff should not b...

2018-03-01 Thread zzcclp

Github user zzcclp commented on the issue:

https://github.com/apache/carbondata/pull/2008
  
please modify 'HndOff' to 'HandOff' in title. 


---

[GitHub] carbondata issue #2009: [CARBONDATA-2212] event fired while updating the sta...

2018-03-01 Thread QiangCai

Github user QiangCai commented on the issue:

https://github.com/apache/carbondata/pull/2009
  
LGTM


---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

2018-03-01 Thread rahulforallp

Github user rahulforallp commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r171489212
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable, String tableName,
--- End diff --

 in case of Pre aggregate table, table name can be of child even though 
carbonTable object is for main table.


---

[GitHub] carbondata issue #2019: [CARBONDATA-2172][Lucene] Add text_columns property ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2019
  
Build Success with Spark 2.2.1, Please check CI 
http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2760/



---

[GitHub] carbondata issue #2019: [CARBONDATA-2172][Lucene] Add text_columns property ...

2018-03-01 Thread CarbonDataQA

Github user CarbonDataQA commented on the issue:

https://github.com/apache/carbondata/pull/2019
  
Build Success with Spark 2.1.0, Please check CI 
http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4004/



---

[GitHub] carbondata pull request #1991: [CARBONDATA-2196]carbontable should be taken ...

2018-03-01 Thread QiangCai

Github user QiangCai commented on a diff in the pull request:

https://github.com/apache/carbondata/pull/1991#discussion_r171487297
  
--- Diff: 
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
 ---
@@ -117,22 +117,25 @@ public static void createLocations(String[] 
locations) {
   }
 }
   }
+
   /**
+   *
* This method will form the local data folder store location
*
-   * @param databaseName
-   * @param tableName
+   * @param carbonTable
* @param taskId
* @param partitionId
* @param segmentId
+   * @param isCompactionFlow
+   * @param isAltPartitionFlow
* @return
*/
-  public static String[] getLocalDataFolderLocation(String databaseName, 
String tableName,
+  public static String[] getLocalDataFolderLocation(CarbonTable 
carbonTable, String tableName,
--- End diff --

not require tableName


---

56 matches

Mail list logo