[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-20 Thread bowenli86 
Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/4945
  
Sounds good. Thanks, @zentol !


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-20 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4945
  
@bowenli86 I've merged the PR to 1.4, could you close the PR? Note that i 
have filed FLINK-8082 to bump the api check on master once 1.4 is released.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-15 Thread bowenli86 
Github user bowenli86 commented on the issue:

https://github.com/apache/flink/pull/4945
  
Sounds good. Thanks @zentol  !   👍 


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-15 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4945
  
Merging on hold until FLINK-8083 is resolved.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-15 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4945
  
Will set the version to compare against to 1.3.2 and merge it.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-09 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4945
  
@greghogan That's a great point.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-09 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4945
  
@greghogan That makes sense, I didn't think about added APIs. 


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-08 Thread greghogan 
Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4945
  
@zentol but we need a check against additions to the API since 1.0. 
Enabling `breakBuildOnModifications` in bugfix releases which don't add the API 
wouldn't require updating compatibility versions in other branches.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-08 Thread zentol 
Github user zentol commented on the issue:

https://github.com/apache/flink/pull/4945
  
Ultimately it shouldn't make a difference, but comparing against 1.0.X 
would require less maintenance as we no longer have to update it with every 
release.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-07 Thread aljoscha 
Github user aljoscha commented on the issue:

https://github.com/apache/flink/pull/4945
  
@greghogan I commented on the issue. Yes this is the API compatibility 
check and the API should actually stay stable for all of the 1.x series. That's 
also why I'm wondering why we're comparing against 1.1.4.


---

[GitHub] flink issue #4945: [FLINK-7977][build] bump version of compatibility check f...

2017-11-07 Thread greghogan 
Github user greghogan commented on the issue:

https://github.com/apache/flink/pull/4945
  
Isn't this API compatibility rather than checkpoint/savepoint 
compatibility? And if the former should not 1.4 be checked against 1.3 (which 
should be checked against 1.2, etc.)?


---