[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[
https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17083699#comment-17083699
]
Nick Dimiduk commented on HBASE-24137:
--
It is already configurable. Try it out for yourself by editing hbase-site.xml
By default:
{noformat}
$ cat conf/hbase-site.xml
$ bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool
hbase.master.metafixer.max.merge.count
null
{noformat}
Here, "null" means the default will be read from code, as you can see, a value
of 10.
Now edit the config file, override the value.
{noformat}
$ cat conf/hbase-site.xml
hbase.master.metafixer.max.merge.count100
$ bin/hbase org.apache.hadoop.hbase.util.HBaseConfTool
hbase.master.metafixer.max.merge.count
100
{noformat}
To [~stack]'s point in the PR, we could do a better job advertising this
configuration point in the book or hbase-default.xml or the like.
> The max merge count of metafixer should be configurable in MetaFixer
>
>
> Key: HBASE-24137
> URL: https://issues.apache.org/jira/browse/HBASE-24137
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Yu Wang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 24137_master_1.patch
>
>
> The max merge count of metafixer should be configurable in MetaFixer
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081104#comment-17081104 ] Yu Wang commented on HBASE-24137: - [~ndimiduk]sorry, I don't understand about "but it's still a configuration parameter of HBase". could you kindly help to advise? what I mean if I want to change the value of hbase.master.metafixer.max.merge.count to 11, i wouldn't have anywhere to change it. > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080955#comment-17080955 ] Nick Dimiduk commented on HBASE-24137: -- What do you mean "exposed to configuration"? The existing code looks up a value using the string "hbase.master.metafixer.max.merge.count". Thus it will find it if it's set in the configuration file. It's not in hbase-defaults.xml or defined as a constant in HConstants, but it's still a configuration parameter of HBase. That's what I mean when I say the patch you've attached doesn't change anything in this regard. > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080177#comment-17080177 ] Yu Wang commented on HBASE-24137: - [~ndimiduk] Thanks for your suggestion. I have opened the githup PR, but i don't find the configuration hbase.master.metafixer.max.merge.count that has exposed to configuration. > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[
https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079571#comment-17079571
]
Nick Dimiduk commented on HBASE-24137:
--
Hi [~yuwang0...@gmail.com] -- we no longer accept contributions at patches on
Jira. Please open a GitHub PR.
This configuration, {{hbase.master.metafixer.max.merge.count}}, is already
exposed to configuration. This patch doesn't change that. You can try it for
yourself on existing released code by adding to your {{conf/hbase-site.xml}}
something like
{noformat}
+
+hbase.master.metafixer.max.merge.count
+100
+
{noformat}
With this change, you can go to {{/conf}} on the webui and see that this
configuration value is upped to 100.
> The max merge count of metafixer should be configurable in MetaFixer
>
>
> Key: HBASE-24137
> URL: https://issues.apache.org/jira/browse/HBASE-24137
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: Yu Wang
>Priority: Minor
> Fix For: 3.0.0
>
> Attachments: 24137_master_1.patch
>
>
> The max merge count of metafixer should be configurable in MetaFixer
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078856#comment-17078856 ] Yu Wang commented on HBASE-24137: - [~ndimiduk] Please review it , Thanks > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078854#comment-17078854 ] Ted Yu commented on HBASE-24137: Please find people who have touched this class to review. I may not have time to review. > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24137) The max merge count of metafixer should be configurable in MetaFixer
[ https://issues.apache.org/jira/browse/HBASE-24137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078852#comment-17078852 ] Yu Wang commented on HBASE-24137: - [~yuzhih...@gmail.com] Please review it , Thanks > The max merge count of metafixer should be configurable in MetaFixer > > > Key: HBASE-24137 > URL: https://issues.apache.org/jira/browse/HBASE-24137 > Project: HBase > Issue Type: Improvement >Affects Versions: 3.0.0 >Reporter: Yu Wang >Priority: Minor > Fix For: 3.0.0 > > Attachments: 24137_master_1.patch > > > The max merge count of metafixer should be configurable in MetaFixer -- This message was sent by Atlassian Jira (v8.3.4#803005)
