[jira] [Updated] (NIFI-13262) Could not create Processor of type org.apache.nifi.processors.attributes.UpdateAttribute, upgrading from 2.0-M2
[
https://issues.apache.org/jira/browse/NIFI-13262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
macdoor615 updated NIFI-13262:
--
Description:
upgrade from 2.0-M2, Some updateattribute processors give the following
exception, some work fine
{code:java}
2024-05-17 17:12:51,894 INFO [main]
o.a.n.f.s.StandardVersionedComponentSynchronizer Added
GhostProcessor[id=575f3a5b-75f0-1c3d-8375-b2086496fe63] to
StandardProcessGroup[identifier=8dd1667a-1cb1-1dba--79bf1185,name=JWT验证]
2024-05-17 17:12:51,894 ERROR [main] o.a.nifi.controller.ExtensionBuilder Could
not create Processor of type
org.apache.nifi.processors.attributes.UpdateAttribute for ID
7fa83bb1-daf3-145c-b578-a50906497151 due to:
org.apache.nifi.processors.attributes.UpdateAttribute; creating "Ghost"
implementation
org.apache.nifi.controller.exception.ProcessorInstantiationException:
org.apache.nifi.processors.attributes.UpdateAttribute
at
org.apache.nifi.controller.ExtensionBuilder.createLoggableProcessor(ExtensionBuilder.java:780)
at
org.apache.nifi.controller.ExtensionBuilder.buildProcessor(ExtensionBuilder.java:251)
at
org.apache.nifi.controller.flow.StandardFlowManager.createProcessor(StandardFlowManager.java:359)
at
org.apache.nifi.controller.flow.AbstractFlowManager.createProcessor(AbstractFlowManager.java:401)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessor(StandardVersionedComponentSynchronizer.java:2435)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeProcessors(StandardVersionedComponentSynchronizer.java:1042)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:453)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.lambda$synchronize$0(StandardVersionedComponentSynchronizer.java:248)
at
org.apache.nifi.controller.flow.AbstractFlowManager.withParameterContextResolution(AbstractFlowManager.java:638)
at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:243)
at
org.apache.nifi.groups.StandardProcessGroup.synchronizeFlow(StandardProcessGroup.java:3868)
at
org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:464)
at
org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.sync(VersionedFlowSynchronizer.java:223)
at
org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1743)
at
org.apache.nifi.persistence.StandardFlowConfigurationDAO.load(StandardFlowConfigurationDAO.java:91)
at
org.apache.nifi.controller.StandardFlowService.loadFromBytes(StandardFlowService.java:805)
at
org.apache.nifi.controller.StandardFlowService.loadFromConnectionResponse(StandardFlowService.java:954)
at
org.apache.nifi.controller.StandardFlowService.load(StandardFlowService.java:508)
at org.apache.nifi.web.server.JettyServer.start(JettyServer.java:871)
at org.apache.nifi.NiFi.(NiFi.java:172)
at org.apache.nifi.NiFi.(NiFi.java:83)
at org.apache.nifi.NiFi.main(NiFi.java:332)
Caused by: java.lang.IllegalStateException: Unable to find bundle for
coordinate org.apache.nifi:nifi-update-attribute-nar:2.0.0-M2
at
[jira] [Created] (NIFI-13262) Could not create Processor of type org.apache.nifi.processors.attributes.UpdateAttribute, upgrading from 2.0-M2
macdoor615 created NIFI-13262:
-
Summary: Could not create Processor of type
org.apache.nifi.processors.attributes.UpdateAttribute, upgrading from 2.0-M2
Key: NIFI-13262
URL: https://issues.apache.org/jira/browse/NIFI-13262
Project: Apache NiFi
Issue Type: Bug
Components: Extensions
Affects Versions: 2.0.0-M3
Environment: NiFi 2.0-M3
Java version "21.0.2" 2024-01-16 LTS
Java(TM) SE Runtime Environment Oracle GraalVM 21.0.2+13.1 (build
21.0.2+13-LTS-jvmci-23.1-b30)
Java HotSpot(TM) 64-Bit Server VM Oracle GraalVM 21.0.2+13.1 (build
21.0.2+13-LTS-jvmci-23.1-b30, mixed mode, sharing)
Linux hb3-prod-hadoop-003 4.18.0-477.27.2.el8_8.x86_64 #1 SMP Fri Sep 29
08:21:01 EDT 2023 x86_64 x86_64 x86_64 GNU/Linux
Reporter: macdoor615
upgrade from 2.0-M2, Some updateattribute processors give the following
exception, some work fine
{{2024-05-17 17:12:51,894 INFO [main]
o.a.n.f.s.StandardVersionedComponentSynchronizer Added
GhostProcessor[id=575f3a5b-75f0-1c3d-8375-b2086496fe63] to
StandardProcessGroup[identifier=8dd1667a-1cb1-1dba--79bf1185,name=JWT验证]}}
{{2024-05-17 17:12:51,894 ERROR [main] o.a.nifi.controller.ExtensionBuilder
Could not create Processor of type
org.apache.nifi.processors.attributes.UpdateAttribute for ID
7fa83bb1-daf3-145c-b578-a50906497151 due to:
org.apache.nifi.processors.attributes.UpdateAttribute; creating "Ghost"
implementation}}
{{org.apache.nifi.controller.exception.ProcessorInstantiationException:
org.apache.nifi.processors.attributes.UpdateAttribute}}
{{ at
org.apache.nifi.controller.ExtensionBuilder.createLoggableProcessor(ExtensionBuilder.java:780)}}
{{ at
org.apache.nifi.controller.ExtensionBuilder.buildProcessor(ExtensionBuilder.java:251)}}
{{ at
org.apache.nifi.controller.flow.StandardFlowManager.createProcessor(StandardFlowManager.java:359)}}
{{ at
org.apache.nifi.controller.flow.AbstractFlowManager.createProcessor(AbstractFlowManager.java:401)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessor(StandardVersionedComponentSynchronizer.java:2435)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeProcessors(StandardVersionedComponentSynchronizer.java:1042)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:453)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.addProcessGroup(StandardVersionedComponentSynchronizer.java:1212)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronizeChildGroups(StandardVersionedComponentSynchronizer.java:545)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:447)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.lambda$synchronize$0(StandardVersionedComponentSynchronizer.java:248)}}
{{ at
org.apache.nifi.controller.flow.AbstractFlowManager.withParameterContextResolution(AbstractFlowManager.java:638)}}
{{ at
org.apache.nifi.flow.synchronization.StandardVersionedComponentSynchronizer.synchronize(StandardVersionedComponentSynchronizer.java:243)}}
{{ at
org.apache.nifi.groups.StandardProcessGroup.synchronizeFlow(StandardProcessGroup.java:3868)}}
{{ at
org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.synchronizeFlow(VersionedFlowSynchronizer.java:464)}}
{{ at
org.apache.nifi.controller.serialization.VersionedFlowSynchronizer.sync(VersionedFlowSynchronizer.java:223)}}
{{ at
org.apache.nifi.controller.FlowController.synchronize(FlowController.java:1743)}}
{{ at
[jira] [Updated] (NIFI-13252) Replace deprecated software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder argument for attributeNames with API suggestion
[
https://issues.apache.org/jira/browse/NIFI-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13252:
Status: Patch Available (was: In Progress)
> Replace deprecated
> software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder
> argument for attributeNames with API suggestion
> --
>
> Key: NIFI-13252
> URL: https://issues.apache.org/jira/browse/NIFI-13252
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Change must be made in file
> {code:java}
> nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/a
> ws/sqs/GetSQS.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13252 Replaced deprecated method attributeNames software.amazonaws.sdk.services.sqs.model.ReceiveMessageRequest.Builder attributeNames with API suggested method messageSystemAttributeNames.
dan-s1 opened a new pull request, #8850: URL: https://github.com/apache/nifi/pull/8850 # Summary [NIFI-13252](https://issues.apache.org/jira/browse/NIFI-13252) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13232) Add REST API Resource for Authentication Configuration
[ https://issues.apache.org/jira/browse/NIFI-13232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847449#comment-17847449 ] ASF subversion and git services commented on NIFI-13232: Commit 226ac9671f3f1d75bc54422f56ab984a53c4550d in nifi's branch refs/heads/main from David Handermann [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=226ac9671f ] NIFI-13232 Add Authentication Configuration REST API method (#8834) * NIFI-13232 Added Authentication Configuration REST API method * NIFI-13236 Moved logoutSupported from Configuration to Current User * NIFI-13232 Added externalLoginRequired field This closes #8834 > Add REST API Resource for Authentication Configuration > -- > > Key: NIFI-13232 > URL: https://issues.apache.org/jira/browse/NIFI-13232 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > The NiFi user interface applications include Servlet Filters to handle Login > and Logout redirection based on the configured authentication strategy. > Rather than continuing to maintain these filters, a new REST API resource > should be created to provide login and logout URLs based on application > configuration. The response should also indicate whether the system supports > login and logout operations so that the user interface can present the > appropriate forms and links according to the current system configuration. > Implementing this new REST API should support the removal of the Login and > Logout filters from the new user interface, simplifying the build and > deployment process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (NIFI-13236) Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
[
https://issues.apache.org/jira/browse/NIFI-13236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847450#comment-17847450
]
ASF subversion and git services commented on NIFI-13236:
Commit 226ac9671f3f1d75bc54422f56ab984a53c4550d in nifi's branch
refs/heads/main from David Handermann
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=226ac9671f ]
NIFI-13232 Add Authentication Configuration REST API method (#8834)
* NIFI-13232 Added Authentication Configuration REST API method
* NIFI-13236 Moved logoutSupported from Configuration to Current User
* NIFI-13232 Added externalLoginRequired field
This closes #8834
> Downloading Content with Non-ASCII Filenames Cause Exceptions with HTTP/2
> -
>
> Key: NIFI-13236
> URL: https://issues.apache.org/jira/browse/NIFI-13236
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Affects Versions: 2.0.0-M2
>Reporter: Matt Gilman
>Assignee: David Handermann
>Priority: Major
> Fix For: 2.0.0-M4
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When attempting to view or download content the flowfile's filename (from the
> filename attribute) is used as the proposed downloaded filename. These
> endpoints support gzip encoding. If the filename contains characters are
> invalid VCHAR based on RFC9110, the endpoint fails with a connection error.
> The log contains the following exception.
>
> {noformat}
> 2024-05-14 14:52:40,290 ERROR [NiFi Web Server-138]
> o.g.j.server.ServerRuntime$Responder An I/O error has occurred while writing
> a response message entity to the container output stream.
> org.glassfish.jersey.server.internal.process.MappableException:
> java.io.IOException:
> org.eclipse.jetty.http2.hpack.HpackException$SessionException: Could not
> hpack encode HTTP/2.0{s=200,h=11,cl=-1}
> at
> org.glassfish.jersey.server.internal.MappableExceptionWrapperInterceptor.aroundWriteTo(MappableExceptionWrapperInterceptor.java:67)
> at
> org.glassfish.jersey.message.internal.WriterInterceptorExecutor.proceed(WriterInterceptorExecutor.java:139)
> at
> org.glassfish.jersey.message.internal.MessageBodyFactory.writeTo(MessageBodyFactory.java:1116)
> at
> org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:678)
> at
> org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:387)
> at
> org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:377)
> at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:266)
> at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
> at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
> at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
> at
> org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266)
> at
> org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:242)
> at
> org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:697)
> at
> org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:394)
> at
> org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346)
> at
> org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:358)
> at
> org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:312)
> at
> org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
> at
> org.eclipse.jetty.ee10.servlet.ServletHolder$NotAsync.service(ServletHolder.java:1379)
> at
> org.eclipse.jetty.ee10.servlet.ServletHolder.handle(ServletHolder.java:736)
> at
> org.eclipse.jetty.ee10.servlet.ServletHandler$ChainEnd.doFilter(ServletHandler.java:1614)
> at
> org.springframework.security.web.FilterChainProxy.lambda$doFilterInternal$3(FilterChainProxy.java:231)
> at
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:365)
> at
> org.springframework.security.web.access.intercept.AuthorizationFilter.doFilter(AuthorizationFilter.java:100)
> at
> org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:374)
> at
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:126)
> at
> org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:120)
> at
>
[jira] [Updated] (NIFI-13232) Add REST API Resource for Authentication Configuration
[ https://issues.apache.org/jira/browse/NIFI-13232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Gilman updated NIFI-13232: --- Fix Version/s: 2.0.0-M4 Resolution: Fixed Status: Resolved (was: Patch Available) > Add REST API Resource for Authentication Configuration > -- > > Key: NIFI-13232 > URL: https://issues.apache.org/jira/browse/NIFI-13232 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Reporter: David Handermann >Assignee: David Handermann >Priority: Major > Fix For: 2.0.0-M4 > > Time Spent: 1h > Remaining Estimate: 0h > > The NiFi user interface applications include Servlet Filters to handle Login > and Logout redirection based on the configured authentication strategy. > Rather than continuing to maintain these filters, a new REST API resource > should be created to provide login and logout URLs based on application > configuration. The response should also indicate whether the system supports > login and logout operations so that the user interface can present the > appropriate forms and links according to the current system configuration. > Implementing this new REST API should support the removal of the Login and > Logout filters from the new user interface, simplifying the build and > deployment process. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
mcgilman merged PR #8834: URL: https://github.com/apache/nifi/pull/8834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] NIFI-13227 updating various dependencies [nifi]
joewitt opened a new pull request, #8849: URL: https://github.com/apache/nifi/pull/8849 aspectj 1.9.22.1 (1.9.22) mockito 5.12.0 (5.11.0) software.amazon.awssdk 2.25.54 (2.25.49) com.amazonaws 1.12.724 (719) com.slack.api 1.39.2 (from 1.39.0) swagger-annotations 2.2.22 (2.2.21) mockftpserver 3.2.0 (from 3.1.0) org.springframework 6.1.6 6.1.7 subethasmtp 7.1.1 (from 7.0.2) reactor-core/test 3.6.6 (from 3.6.5) spring-retry 2.0.6 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-0) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13252) Replace deprecated software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder argument for attributeNames with API suggestion
[
https://issues.apache.org/jira/browse/NIFI-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13252:
Status: Open (was: Patch Available)
> Replace deprecated
> software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder
> argument for attributeNames with API suggestion
> --
>
> Key: NIFI-13252
> URL: https://issues.apache.org/jira/browse/NIFI-13252
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>
> Change must be made in file
> {code:java}
> nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/a
> ws/sqs/GetSQS.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13252) Replace deprecated software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder argument for attributeNames with API suggestion
[
https://issues.apache.org/jira/browse/NIFI-13252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13252:
Status: Patch Available (was: In Progress)
> Replace deprecated
> software.amazon.awssdk.services.sqs.model.ReceiveMessageRequest.Builder
> argument for attributeNames with API suggestion
> --
>
> Key: NIFI-13252
> URL: https://issues.apache.org/jira/browse/NIFI-13252
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
>
> Change must be made in file
> {code:java}
> nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/a
> ws/sqs/GetSQS.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (NIFI-13251) Replace deprecated method fromName of com.amazonaws.regions.Regions with API suggestion
[ https://issues.apache.org/jira/browse/NIFI-13251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Stieglitz updated NIFI-13251: Status: Patch Available (was: In Progress) > Replace deprecated method fromName of com.amazonaws.regions.Regions with API > suggestion > --- > > Key: NIFI-13251 > URL: https://issues.apache.org/jira/browse/NIFI-13251 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Daniel Stieglitz >Assignee: Daniel Stieglitz >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > Changes need to be made in files > # > nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/util/RegionUtilV1.java > # > nifi-extension-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/AbstractAWSCredentialsProviderProcessor.java > # > nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/encryption/ClientSideKMSEncryptionStrategy.java -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13251 Replaced deprecated method fromName of com.amazonaws.regions.Regions with API suggestion [nifi]
dan-s1 opened a new pull request, #8848: URL: https://github.com/apache/nifi/pull/8848 # Summary [NIFI-13251](https://issues.apache.org/jira/browse/NIFI-13251) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13260] enforce selected border even when component has color ap… [nifi]
mcgilman commented on PR #8846: URL: https://github.com/apache/nifi/pull/8846#issuecomment-2118324826 Reviewing... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13227) Bump aspectj and mockito and various dependencies
[ https://issues.apache.org/jira/browse/NIFI-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13227: Description: aspectj 1.9.22.1 (1.9.22) mockito 5.12.0 (5.11.0) software.amazon.awssdk 2.25.54 (2.25.49) com.amazonaws 1.12.724 (719) com.slack.api 1.39.2 (from 1.39.0) swagger-annotations 2.2.22 (2.2.21) mockftpserver 3.2.0 (from 3.1.0) org.springframework 6.1.6 6.1.7 subethasmtp 7.1.1 (from 7.0.2) reactor-core/test 3.6.6 (from 3.6.5) spring-retry 2.0.6 reactor-netty-http 1.1.19 (18) was: aspectj 1.9.22.1 (1.9.22) mockito 5.12.0 (5.11.0) software.amazon.awssdk 2.25.54 (2.25.49) com.amazonaws 1.12.724 (719) com.slack.api 1.39.2 (from 1.39.0) swagger-annotations 2.2.22 (2.2.21) mockftpserver 3.2.0 (from 3.1.0) org.springframework 6.1.6 6.1.7 subethasmtp 7.1.1 (from 7.0.2) reactor-core/test 3.6.6 (from 3.6.5) spring-retry 2.0.6 > Bump aspectj and mockito and various dependencies > - > > Key: NIFI-13227 > URL: https://issues.apache.org/jira/browse/NIFI-13227 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > > aspectj 1.9.22.1 (1.9.22) > mockito 5.12.0 (5.11.0) > software.amazon.awssdk 2.25.54 (2.25.49) > com.amazonaws 1.12.724 (719) > com.slack.api 1.39.2 (from 1.39.0) > swagger-annotations 2.2.22 (2.2.21) > mockftpserver 3.2.0 (from 3.1.0) > org.springframework 6.1.6 6.1.7 > subethasmtp 7.1.1 (from 7.0.2) > reactor-core/test 3.6.6 (from 3.6.5) > spring-retry 2.0.6 > reactor-netty-http 1.1.19 (18) -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] MINIFICPP-2354 Fix previous release binary link [nifi-site]
szaszm merged PR #87: URL: https://github.com/apache/nifi-site/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13245] address component name overflow in provenance details di… [nifi]
mcgilman commented on PR #8845: URL: https://github.com/apache/nifi/pull/8845#issuecomment-2118310157 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13207] page headers and refresh containers are consistently pos… [nifi]
mcgilman commented on code in PR #8804:
URL: https://github.com/apache/nifi/pull/8804#discussion_r1605475961
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##
@@ -83,6 +55,37 @@
+
+
+@switch (accessPolicyState.policyStatus) {
+@case (PolicyStatus.NotFound) {
+No policy for the specified
resource.
+@if
(flowConfiguration.supportsConfigurableAuthorizer) {
+Create a new policy.
+}
+}
+@case (PolicyStatus.Inherited) {
+@if
(accessPolicyState.accessPolicy) {
+
+}
+}
+@case (PolicyStatus.Forbidden) {
+Not authorized to access the
policy for the specified resource.
+}
+@default {
+Displaying all authorized
Users/Groups
+}
Review Comment:
I don't think we should be rendering anything in this condition. When the
authorized user listing is rendered it is never filtered, so I don't think we
need to indicate that all authorized Users/Groups are being displayed.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-list.component.html:
##
@@ -37,6 +37,7 @@
+
Review Comment:
Rather than needing an empty element with `` can we just add some
equivalently sized spacing between the elements?
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/component-access-policies/component-access-policies.component.html:
##
@@ -83,6 +55,37 @@
+
+
+@switch (accessPolicyState.policyStatus) {
+@case (PolicyStatus.NotFound) {
+No policy for the specified
resource.
+@if
(flowConfiguration.supportsConfigurableAuthorizer) {
+Create a new policy.
+}
+}
+@case (PolicyStatus.Inherited) {
+@if
(accessPolicyState.accessPolicy) {
+
+}
+}
+@case (PolicyStatus.Forbidden) {
+Not authorized to access the
policy for the specified resource.
+}
+@default {
+Displaying all authorized
Users/Groups
+}
Review Comment:
This comment applies to both the Global and Component policy page.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/settings/feature/settings.component.html:
##
@@ -35,7 +35,7 @@ NiFi Settings
}
-
+
Review Comment:
This looks ok for the General tab but appears to be too much padding for
tabs that include tables.
##
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-configuration-history/ui/flow-configuration-history-listing/flow-configuration-history-listing.component.html:
##
@@ -89,6 +89,7 @@
Clear
Filter
+
Review Comment:
Rather than needing an empty element with `` can we just add some
equivalently sized spacing between the elements?
##
[jira] [Updated] (NIFI-13227) Bump aspectj and mockito and various dependencies
[ https://issues.apache.org/jira/browse/NIFI-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13227: Description: aspectj 1.9.22.1 (1.9.22) mockito 5.12.0 (5.11.0) software.amazon.awssdk 2.25.54 (2.25.49) com.amazonaws 1.12.724 (719) com.slack.api 1.39.2 (from 1.39.0) swagger-annotations 2.2.22 (2.2.21) mockftpserver 3.2.0 (from 3.1.0) org.springframework 6.1.6 6.1.7 subethasmtp 7.1.1 (from 7.0.2) reactor-core/test 3.6.6 (from 3.6.5) spring-retry 2.0.6 was: aspectj 1.9.22.1 mockito 5.12.0 software.amazon.awssdk 2.25.51 com.amazonaws 1.12.724 com.slack.api 1.39.2 swagger-annotations 2.2.22 > Bump aspectj and mockito and various dependencies > - > > Key: NIFI-13227 > URL: https://issues.apache.org/jira/browse/NIFI-13227 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > > aspectj 1.9.22.1 (1.9.22) > mockito 5.12.0 (5.11.0) > software.amazon.awssdk 2.25.54 (2.25.49) > com.amazonaws 1.12.724 (719) > com.slack.api 1.39.2 (from 1.39.0) > swagger-annotations 2.2.22 (2.2.21) > mockftpserver 3.2.0 (from 3.1.0) > org.springframework 6.1.6 6.1.7 > subethasmtp 7.1.1 (from 7.0.2) > reactor-core/test 3.6.6 (from 3.6.5) > spring-retry 2.0.6 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] MINIFICPP-2354 Fix previous release binary link [nifi-site]
lordgamez opened a new pull request, #87: URL: https://github.com/apache/nifi-site/pull/87 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13227) Bump aspectj and mockito and various dependencies
[ https://issues.apache.org/jira/browse/NIFI-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13227: Description: aspectj 1.9.22.1 mockito 5.12.0 software.amazon.awssdk 2.25.51 com.amazonaws 1.12.724 com.slack.api 1.39.2 swagger-annotations 2.2.22 was: aspectj 1.9.22.1 mockito 5.12.0 software.amazon.awssdk 2.25.51 com.amazonaws 1.12.724 com.slack.api 1.39.2 > Bump aspectj and mockito and various dependencies > - > > Key: NIFI-13227 > URL: https://issues.apache.org/jira/browse/NIFI-13227 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > > aspectj 1.9.22.1 > mockito 5.12.0 > software.amazon.awssdk 2.25.51 > com.amazonaws 1.12.724 > com.slack.api 1.39.2 > swagger-annotations 2.2.22 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13227) Bump aspectj and mockito and various dependencies
[ https://issues.apache.org/jira/browse/NIFI-13227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-13227: Description: aspectj 1.9.22.1 mockito 5.12.0 software.amazon.awssdk 2.25.51 com.amazonaws 1.12.724 com.slack.api 1.39.2 was: aspectj 1.9.22.1 mockito 5.12.0 software.amazon.awssdk 2.25.51 com.amazonaws 1.12.721 com.slack.api 1.39.2 > Bump aspectj and mockito and various dependencies > - > > Key: NIFI-13227 > URL: https://issues.apache.org/jira/browse/NIFI-13227 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > > aspectj 1.9.22.1 > mockito 5.12.0 > software.amazon.awssdk 2.25.51 > com.amazonaws 1.12.724 > com.slack.api 1.39.2 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on PR #8839: URL: https://github.com/apache/nifi/pull/8839#issuecomment-2118253612 @mattyb149 Ok thanks for offering a PR that returns Couchbase components to the codebase. However, given the rapid (perhaps record setting) pace by which you received feedback from 3 different PMC members you can see there is a lot of emphasis on increasing the quality of such contributions. It was deprecated in 1.x and removed in 2.x for what amounts of lack of maintenance and this new PR does not change that nature. There is clearly much of this which is simply copy and paste from the previous state. While there are a lot of comments all of them look actually very easily addressed. They do however call into question the level of consideration that went into creating the newly offered couchbase components in the first place. L is important to get right and review. Avoiding duplicative dependencies in the chain is important for maintenance, behavior, and build size. Bumping from the older clients to the newer clients implies these components were considered for new compability implications with Couchbase server/etc.. By re-introducing these components to the codebase the presumption is that you as the author considered these things. If not, it is best to avoid re-introducing until such time that can be done because otherwise we're at the previous position again in terms of lack of maintenance. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13261) Add abilities to table menu
Julien G. created NIFI-13261: Summary: Add abilities to table menu Key: NIFI-13261 URL: https://issues.apache.org/jira/browse/NIFI-13261 Project: Apache NiFi Issue Type: Improvement Components: Core UI Affects Versions: 2.0.0-M3 Reporter: Julien G. In different menus there is table that contains a lot of items like for example the Controller Services table, the Parameter Context table, the Parameter Context values table, etc. And often we need to look into to find a specific item but to do it we need to do our best CTRL+F or scroll until we find it. It could be a great idea to add a search/filter input as it is done to search a component in the canvas but to search/filter a table. The search/filter should at least focus the item name but I guess that it could also be used on parameter value / description or controller service type, depending the item type. And some other feature like column sorting or column hidding could be great to. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605453096 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services-api-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,21 @@ +nifi-couchbase-services-api-nar +Copyright 2014-2024 The Apache Software Foundation + Review Comment: there is also reactive-streams in the build but not referenced. It is MIT licensed which means it needs to be copied into a LICENSE file and carried forward as appropriate to the assembly LICENSE too if not already. https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.4/LICENSE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13250) Replace deprecated method withRelyingPartyRegistration of org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration with API suggestion
[
https://issues.apache.org/jira/browse/NIFI-13250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Stieglitz updated NIFI-13250:
Status: Patch Available (was: In Progress)
> Replace deprecated method withRelyingPartyRegistration of
> org.springframework.security.saml2.provider.service.registration.RelyingPartyRegistration
> with API suggestion
> ---
>
> Key: NIFI-13250
> URL: https://issues.apache.org/jira/browse/NIFI-13250
> Project: Apache NiFi
> Issue Type: Improvement
>Reporter: Daniel Stieglitz
>Assignee: Daniel Stieglitz
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This needs to be changed in
> {code:java}
> nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/sec
> urity/saml2/service/web/StandardRelyingPartyRegistrationResolver.java
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] NIFI-13250 Replaced deprecated method withRelyingPartyRegistration with API suggested replacement. [nifi]
dan-s1 opened a new pull request, #8847: URL: https://github.com/apache/nifi/pull/8847 # Summary [NIFI-13250](https://issues.apache.org/jira/browse/NIFI-13250) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605449443 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/pom.xml: ## @@ -0,0 +1,71 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-couchbase-bundle +2.0.0-SNAPSHOT + + +nifi-couchbase-processors +jar + + + +org.apache.nifi +nifi-api + + +org.apache.nifi +nifi-utils +2.0.0-SNAPSHOT + + +org.apache.nifi +nifi-couchbase-services-api +2.0.0-SNAPSHOT +provided + + +org.apache.nifi +nifi-distributed-cache-client-service-api + + +org.apache.commons Review Comment: since this depends on commons-lang3 and that is already part of the nifi-standard-shared-bundle you could switch to that instead of standard services as the parent for these bundles and avoid having to carry another copy of commons-lang3. That would be a change in the parent pom reference currently set in this modules bundle and there is one less dependency but most importantly not risking getting them out of sync -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-11259 - Kafka processor refactor [nifi]
greyp9 commented on code in PR #8463:
URL: https://github.com/apache/nifi/pull/8463#discussion_r1605446151
##
nifi-extension-bundles/nifi-kafka-bundle/nifi-kafka-processors/src/main/java/org/apache/nifi/kafka/processors/producer/config/DeliveryGuarantee.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.kafka.processors.producer.config;
+
+import org.apache.nifi.components.AllowableValue;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+
+public class DeliveryGuarantee {
+
+public static final String ACKS_CONFIG = "acks";
+
+public static final AllowableValue DELIVERY_REPLICATED = new
AllowableValue("all", "Guarantee Replicated Delivery",
+"FlowFile will be routed to failure unless the message is
replicated to the appropriate "
++ "number of Kafka Nodes according to the Topic
configuration");
+public static final AllowableValue DELIVERY_ONE_NODE = new
AllowableValue("1", "Guarantee Single Node Delivery",
+"FlowFile will be routed to success if the message is received by
a single Kafka node, "
++ "whether or not it is replicated. This is faster than
"
++ "but can result in data loss if a Kafka node crashes");
+public static final AllowableValue DELIVERY_BEST_EFFORT = new
AllowableValue("0", "Best Effort",
+"FlowFile will be routed to success after successfully sending the
content to a Kafka node, "
++ "without waiting for any acknowledgment from the node at
all. This provides the best performance but may result in data loss.");
+
+public static final PropertyDescriptor DELIVERY_GUARANTEE = new
PropertyDescriptor.Builder()
+.name(ACKS_CONFIG)
Review Comment:
This label is brought in from the Kafka source. Added a link comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
exceptionfactory commented on code in PR #8834:
URL: https://github.com/apache/nifi/pull/8834#discussion_r1605433940
##
nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/AuthenticationConfigurationDTO.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.api.dto;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+import jakarta.xml.bind.annotation.XmlType;
+
+/**
+ * Authentication Configuration endpoint and status information
+ */
+@XmlType(name = "authenticationConfiguration")
+public class AuthenticationConfigurationDTO {
+
+private boolean loginSupported;
+
+private String loginUri;
+
+private String logoutUri;
Review Comment:
Thanks for the feedback @mcgilman, I added an `externalLoginRequired` field
indicating the status of the configured login URI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605433216 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/pom.xml: ## @@ -0,0 +1,71 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-couchbase-bundle +2.0.0-SNAPSHOT + + +nifi-couchbase-processors +jar + + + +org.apache.nifi +nifi-api + + +org.apache.nifi +nifi-utils +2.0.0-SNAPSHOT + + +org.apache.nifi +nifi-couchbase-services-api +2.0.0-SNAPSHOT +provided + + +org.apache.nifi +nifi-distributed-cache-client-service-api + + +org.apache.commons +commons-lang3 + + +org.apache.nifi +nifi-lookup-service-api + + +org.apache.nifi +nifi-record + + +org.apache.nifi +nifi-record-serialization-service-api + + +org.apache.nifi +nifi-mock +2.0.0-SNAPSHOT +test + + Review Comment: This POM does not declare the couchbase client yet the couchbase processors have a direct dependency on the couchbase client code. It should be explicitly declared and not simply relied upon to carry through from the transitive depedency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605432302 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/pom.xml: ## @@ -0,0 +1,71 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-couchbase-bundle +2.0.0-SNAPSHOT + + +nifi-couchbase-processors +jar + + + +org.apache.nifi +nifi-api + + +org.apache.nifi +nifi-utils +2.0.0-SNAPSHOT + + +org.apache.nifi +nifi-couchbase-services-api +2.0.0-SNAPSHOT +provided + + +org.apache.nifi +nifi-distributed-cache-client-service-api + + +org.apache.commons +commons-lang3 + + +org.apache.nifi +nifi-lookup-service-api + + +org.apache.nifi +nifi-record + + +org.apache.nifi +nifi-record-serialization-service-api + + +org.apache.nifi +nifi-mock Review Comment: this dependency is already provided by the parentage. It should not be declared. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605425797 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services-api-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,21 @@ +nifi-couchbase-services-api-nar +Copyright 2014-2024 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + +(ASLv2) Couchbase Java SDK + The following NOTICE information applies: +Couchbase Java SDK +Copyright 2014 Couchbase, Inc. + +(ASLv2) RxJava Review Comment: I dont see any evidence to support RxJava being referred to here. We do have reactor-core but it is ASLv2 with no apparent copyright claim we need to carry. https://github.com/reactor/reactor-core ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services-api-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,21 @@ +nifi-couchbase-services-api-nar +Copyright 2014-2024 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + +(ASLv2) Couchbase Java SDK + The following NOTICE information applies: +Couchbase Java SDK +Copyright 2014 Couchbase, Inc. + +(ASLv2) RxJava Review Comment: I dont see any evidence to support RxJava being referred to here. We do have reactor-core but it is ASLv2 with no apparent copyright claim we need to carry. https://github.com/reactor/reactor-core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605425797 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services-api-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,21 @@ +nifi-couchbase-services-api-nar +Copyright 2014-2024 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + +(ASLv2) Couchbase Java SDK + The following NOTICE information applies: +Couchbase Java SDK +Copyright 2014 Couchbase, Inc. + +(ASLv2) RxJava Review Comment: I dont see any evidence to support RxJava being referred to here. We do have reactor-core but it is ASLv2 with no apparent copyright claim we need to carry. https://github.com/reactor/reactor-core -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
exceptionfactory commented on code in PR #8839:
URL: https://github.com/apache/nifi/pull/8839#discussion_r1605415077
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/AbstractCouchbaseLookupService.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.controller.ControllerServiceInitializationContext;
+import org.apache.nifi.reporting.InitializationException;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.BUCKET_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COLLECTION_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COUCHBASE_CLUSTER_SERVICE;
+
+public class AbstractCouchbaseLookupService extends AbstractControllerService {
+
+protected static final String KEY = "key";
+protected static final Set REQUIRED_KEYS =
Collections.unmodifiableSet(Stream.of(KEY).collect(Collectors.toSet()));
Review Comment:
It looks like this can be simplified to `Set.of(KEY)`
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/CouchbaseClusterService.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import com.couchbase.client.core.error.CouchbaseException;
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.DeprecationNotice;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Cluster;
+
+/**
+ * Provides a centralized Couchbase connection and bucket passwords management.
+ */
+@CapabilityDescription("Provides a centralized Couchbase connection and bucket
passwords management."
++ " Bucket passwords can be specified via dynamic properties.")
+@Tags({ "nosql", "couchbase", "database", "connection" })
+@DynamicProperty(name = "Bucket Password for BUCKET_NAME", value = "bucket
password",
+description = "Specify bucket password if necessary." +
+
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605421667 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/resources/docs/org.apache.nifi.couchbase.CouchbaseMapCacheClient/additionalDetails.html: ## @@ -0,0 +1,35 @@ + + + + + +CouchbaseMapCacheClient + + + + +CouchbaseMapCacheClient + +Requirements + +Couchbase Server 4.0 or higher is required for some operation using N1QL Review Comment: This whole section does not look correct/true from my read of https://docs.couchbase.com/java-sdk/current/project-docs/compatibility.html#couchbase-versionsdk-version-matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] MINIFICPP-2354 Add MiNiFi C++ 0.99.0 to the downloads page [nifi-site]
lordgamez merged PR #86: URL: https://github.com/apache/nifi-site/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839:
URL: https://github.com/apache/nifi/pull/8839#discussion_r1605419322
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/CouchbaseClusterService.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import com.couchbase.client.core.error.CouchbaseException;
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.DeprecationNotice;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Cluster;
+
+/**
+ * Provides a centralized Couchbase connection and bucket passwords management.
+ */
+@CapabilityDescription("Provides a centralized Couchbase connection and bucket
passwords management."
++ " Bucket passwords can be specified via dynamic properties.")
+@Tags({ "nosql", "couchbase", "database", "connection" })
+@DynamicProperty(name = "Bucket Password for BUCKET_NAME", value = "bucket
password",
+description = "Specify bucket password if necessary." +
+" Couchbase Server 5.0 or later should use 'User Name' and
'User Password' instead.")
+@DeprecationNotice(reason = "This component is deprecated and will be removed
in NiFi 2.x.")
+public class CouchbaseClusterService extends AbstractControllerService
implements CouchbaseClusterControllerService {
+
+public static final PropertyDescriptor CONNECTION_STRING = new
PropertyDescriptor
+.Builder()
+.name("Connection String")
+.description("The hostnames or ip addresses of the bootstraping
nodes and optional parameters."
++ " Syntax)
couchbase://node1,node2,nodeN?param1=value1=value2=valueN")
+.required(true)
+.expressionLanguageSupported(ExpressionLanguageScope.ENVIRONMENT)
+.addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+.build();
+
+public static final PropertyDescriptor USER_NAME = new PropertyDescriptor
+.Builder()
+.name("user-name")
+.displayName("User Name")
+.description("The user name to authenticate NiFi as a Couchbase
client." +
+" This configuration can be used against Couchbase Server
5.0 or later" +
Review Comment:
We're using the couchbase client 3 which appears to be for Couchbase 7 or
later. So this comment should be changed. And that compatibility detail
should be shared elsewhere.
https://docs.couchbase.com/java-sdk/current/project-docs/compatibility.html#couchbase-versionsdk-version-matrix
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/CouchbaseClusterService.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+
Re: [PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
mcgilman commented on code in PR #8834:
URL: https://github.com/apache/nifi/pull/8834#discussion_r1605418511
##
nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/AuthenticationConfigurationDTO.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.api.dto;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+import jakarta.xml.bind.annotation.XmlType;
+
+/**
+ * Authentication Configuration endpoint and status information
+ */
+@XmlType(name = "authenticationConfiguration")
+public class AuthenticationConfigurationDTO {
+
+private boolean loginSupported;
+
+private String loginUri;
+
+private String logoutUri;
Review Comment:
It would be helpful to additionally know when the `loginUri` is our own
local hosted UI or an external log in (like SSO). This would allow the front
end to more gracefully handle the routing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
mcgilman commented on code in PR #8834:
URL: https://github.com/apache/nifi/pull/8834#discussion_r1605418511
##
nifi-framework-bundle/nifi-framework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/dto/AuthenticationConfigurationDTO.java:
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.web.api.dto;
+
+import io.swagger.v3.oas.annotations.media.Schema;
+import jakarta.xml.bind.annotation.XmlType;
+
+/**
+ * Authentication Configuration endpoint and status information
+ */
+@XmlType(name = "authenticationConfiguration")
+public class AuthenticationConfigurationDTO {
+
+private boolean loginSupported;
+
+private String loginUri;
+
+private String logoutUri;
Review Comment:
It would be helpful to additional know when the `loginUri` is our own local
hosted UI or an external log in (like SSO). This would allow the front end to
more gracefully handle the routing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605415600 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,30 @@ +nifi-couchbase-nar +Copyright 2014-2024 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + +(ASLv2) Couchbase Java SDK Review Comment: This is not accurate. It is not included. ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-nar/src/main/resources/META-INF/NOTICE: ## @@ -0,0 +1,30 @@ +nifi-couchbase-nar +Copyright 2014-2024 The Apache Software Foundation + +This product includes software developed at +The Apache Software Foundation (http://www.apache.org/). + +** +Apache Software License v2 +** + +The following binary components are provided under the Apache Software License v2 + +(ASLv2) Couchbase Java SDK + The following NOTICE information applies: +Couchbase Java SDK +Copyright 2014 Couchbase, Inc. + +(ASLv2) RxJava Review Comment: This is not accurate. It is not included. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
exceptionfactory commented on code in PR #8839:
URL: https://github.com/apache/nifi/pull/8839#discussion_r1605410606
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/processors/couchbase/AbstractCouchbaseProcessor.java:
##
@@ -0,0 +1,197 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.couchbase;
+
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+
+import com.couchbase.client.core.error.CouchbaseException;
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Collection;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.couchbase.CouchbaseClusterControllerService;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.ProcessorInitializationContext;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.BUCKET_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COLLECTION_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COUCHBASE_CLUSTER_SERVICE;
+
+/**
+ * Provides common functionality for Couchbase processors.
+ */
+public abstract class AbstractCouchbaseProcessor extends AbstractProcessor {
+
+static final PropertyDescriptor DOC_ID = new PropertyDescriptor.Builder()
+.name("document-id")
+.displayName("Document Id")
Review Comment:
Agreed, all properties should be changed to use the `name()` without a
different displayName().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605403316 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/pom.xml: ## @@ -0,0 +1,71 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-couchbase-bundle +2.0.0-SNAPSHOT + + +nifi-couchbase-processors +jar + + + +org.apache.nifi +nifi-api Review Comment: this should not be declared. The parentage already has a dependency on nifi-api and it is provided. See nifi-bom for things which no matter what are already 'dependencies' of any nifi extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839:
URL: https://github.com/apache/nifi/pull/8839#discussion_r1605401985
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/test/java/org/apache/nifi/couchbase/TestCouchbaseMapCacheClient.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Collection;
+import com.couchbase.client.java.kv.GetResult;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.distributed.cache.client.Deserializer;
+import org.apache.nifi.distributed.cache.client.Serializer;
+import org.apache.nifi.util.MockConfigurationContext;
+import org.apache.nifi.util.MockControllerServiceInitializationContext;
+import org.junit.jupiter.api.Test;
+
+import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
+import java.util.Map;
+
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.BUCKET_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COLLECTION_NAME;
+import static
org.apache.nifi.couchbase.CouchbaseConfigurationProperties.COUCHBASE_CLUSTER_SERVICE;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.ArgumentMatchers.anyString;
+import static org.mockito.ArgumentMatchers.eq;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+public class TestCouchbaseMapCacheClient {
+
+private final Serializer stringSerializer = (value, output) ->
output.write(value.getBytes(StandardCharsets.UTF_8));
+private final Deserializer stringDeserializer = input -> new
String(input, StandardCharsets.UTF_8);
+
+// TODO: Add more tests
Review Comment:
Let's either add them or get rid of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
joewitt commented on code in PR #8839: URL: https://github.com/apache/nifi/pull/8839#discussion_r1605401283 ## nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-services-api/pom.xml: ## @@ -0,0 +1,38 @@ + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + + +org.apache.nifi +nifi-couchbase-bundle +2.0.0-SNAPSHOT + + +nifi-couchbase-services-api +jar + + + +org.apache.nifi +nifi-api Review Comment: this should not be declared. The parentage already has a dependency on nifi-api and it is provided. See nifi-bom for things which no matter what are already 'dependencies' of any nifi extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-10752: Add Couchbase 3.x components [nifi]
pvillard31 commented on code in PR #8839:
URL: https://github.com/apache/nifi/pull/8839#discussion_r1605372503
##
nifi-assembly/pom.xml:
##
@@ -1072,6 +1072,30 @@ language governing permissions and limitations under the
License. -->
+
+include-couchbase
+
Review Comment:
```suggestion
```
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/CouchbaseClusterService.java:
##
@@ -0,0 +1,204 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+
+import com.couchbase.client.core.error.CouchbaseException;
+import org.apache.nifi.annotation.behavior.DynamicProperty;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.DeprecationNotice;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnDisabled;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.controller.AbstractControllerService;
+import org.apache.nifi.controller.ConfigurationContext;
+import org.apache.nifi.expression.ExpressionLanguageScope;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.reporting.InitializationException;
+
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Cluster;
+
+/**
+ * Provides a centralized Couchbase connection and bucket passwords management.
+ */
+@CapabilityDescription("Provides a centralized Couchbase connection and bucket
passwords management."
++ " Bucket passwords can be specified via dynamic properties.")
+@Tags({ "nosql", "couchbase", "database", "connection" })
+@DynamicProperty(name = "Bucket Password for BUCKET_NAME", value = "bucket
password",
+description = "Specify bucket password if necessary." +
+" Couchbase Server 5.0 or later should use 'User Name' and
'User Password' instead.")
+@DeprecationNotice(reason = "This component is deprecated and will be removed
in NiFi 2.x.")
Review Comment:
```suggestion
```
##
nifi-extension-bundles/nifi-couchbase-bundle/nifi-couchbase-processors/src/main/java/org/apache/nifi/couchbase/CouchbaseKeyValueLookupService.java:
##
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.couchbase;
+
+import com.couchbase.client.core.error.CouchbaseException;
+import com.couchbase.client.core.error.DocumentNotFoundException;
+import com.couchbase.client.java.Bucket;
+import com.couchbase.client.java.Collection;
+import com.couchbase.client.java.kv.LookupInSpec;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.DeprecationNotice;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.annotation.lifecycle.OnEnabled;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.controller.ConfigurationContext;
+import
[PR] MINIFICPP-2354 Add MiNiFi C++ 0.99.0 to the downloads page [nifi-site]
lordgamez opened a new pull request, #86: URL: https://github.com/apache/nifi-site/pull/86 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2118096628 @JackHintonSmartDCSIT I think we are getting real close. I just have a few more points as seen above to address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13260) Selected canvas component which has color applied does not show the correct border
[ https://issues.apache.org/jira/browse/NIFI-13260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13260: --- Status: Patch Available (was: In Progress) > Selected canvas component which has color applied does not show the correct > border > -- > > Key: NIFI-13260 > URL: https://issues.apache.org/jira/browse/NIFI-13260 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: image (4).png, image (5).png > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [NIFI-13260] enforce selected border even when component has color ap… [nifi]
scottyaslan opened a new pull request, #8846: URL: https://github.com/apache/nifi/pull/8846 …plied https://github.com/apache/nifi/assets/6797571/8d197b23-841f-49a2-8c8e-369a6f1a9be6;> https://github.com/apache/nifi/assets/6797571/7a29dc88-6bf2-43c1-b655-ec8349dae196;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (NIFI-13260) Selected canvas component which has color applied does not show the correct border
Scott Aslan created NIFI-13260: -- Summary: Selected canvas component which has color applied does not show the correct border Key: NIFI-13260 URL: https://issues.apache.org/jira/browse/NIFI-13260 Project: Apache NiFi Issue Type: Sub-task Reporter: Scott Aslan Assignee: Scott Aslan Attachments: image (4).png, image (5).png -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117905357 I've implemented those changes, hopefully there shouldn't be any more hidden whitespace issues now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117858721 > > Ah good to know, thanks. I'll do that now > > Thanks for making adjustments @JackHintonSmartDCSIT, part of the challenge of continual adjustments and improvements, I appreciate the responsiveness! > > > Ah good to know, thanks. I'll do that now > > > > > > Thanks for making adjustments @JackHintonSmartDCSIT, part of the challenge of continual adjustments and improvements, I appreciate the responsiveness! > > Me too :) Thank you both! It ended up taking me 45 minutes to rebase (windows had issues with path length and then I had to reauthenticate git in WSL) but now that adventure's over I'll implement the rest of your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605171797
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT = new
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605163620
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT = new
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605163620
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT = new
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605171797
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT = new
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605105309
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,224 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.POSITIVE_INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT = new
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117764485 > > Ah good to know, thanks. I'll do that now > > Thanks for making adjustments @JackHintonSmartDCSIT, part of the challenge of continual adjustments and improvements, I appreciate the responsiveness! Me too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117761490 > Ah good to know, thanks. I'll do that now Thanks for making adjustments @JackHintonSmartDCSIT, part of the challenge of continual adjustments and improvements, I appreciate the responsiveness! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117760076 > @exceptionfactory Is it okay to have the `PCAP` class named in all caps (pardon the pun) or should it be camel cased `Pcap`? Yes, I had originally recommend naming the Processor SplitPCAP, so it seems reasonable to carry that name over. However, it might be better to name it more specifically to something like `PcapUtils`. I'm fine as it is for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117753365 Ah good to know, thanks. I'll do that now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117747897 @JackHintonSmartDCSIT I believe @exceptionfactory just had a comment on another PR indicating there are new Checkstyle rules . I assume you would have to rebase in order to pick them up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117740399 I've noticed it's got checkstyle violations again - the same ones as before - but when I run it using `mvn clean install -P contrib-check` it doesn't flag them up. Is there some config item I'm missing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117705315 @exceptionfactory Is it okay to have the `PCAP` class named in all caps (pardon the pun) or should it be camel cased `Pcap`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117703776 I've recently determined that the linkstyle enum is unnecessary for the use case of splitting PCAP files - it would only be useful if further processing was done after parsing. I'll move the other bits into a new package now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13245) Provenance Event dialog overflow issues
[ https://issues.apache.org/jira/browse/NIFI-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan updated NIFI-13245: --- Status: Patch Available (was: In Progress) > Provenance Event dialog overflow issues > --- > > Key: NIFI-13245 > URL: https://issues.apache.org/jira/browse/NIFI-13245 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-15 at 10.18.51 AM.png > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13259 - Enable publishing of Nifi Stateless to Maven Repo. [nifi]
bobpaulin opened a new pull request, #8844: URL: https://github.com/apache/nifi/pull/8844 # Summary [NIFI-13259](https://issues.apache.org/jira/browse/NIFI-13259) # Tracking Please complete the following tracking steps prior to pull request creation. ### Issue Tracking - [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created ### Pull Request Tracking - [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-0` - [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-0` ### Pull Request Formatting - [ ] Pull Request based on current revision of the `main` branch - [ ] Pull Request refers to a feature branch with one commit containing changes # Verification Please indicate the verification steps performed prior to pull request creation. ### Build - [ ] Build completed using `mvn clean install -P contrib-check` - [ ] JDK 21 ### UI Contributions - [ ] NiFi is modernizing its UI. Any contributions that update the [current UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui) also need to be implemented in the [new UI](https://github.com/apache/nifi/tree/main/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi). ### Licensing - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html) - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files ### Documentation - [ ] Documentation formatting appears as expected in rendered files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [NIFI-13245] address component name overflow in provenance details di… [nifi]
scottyaslan opened a new pull request, #8845: URL: https://github.com/apache/nifi/pull/8845 …alog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1605072721
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/util/Linktype.java:
##
@@ -0,0 +1,259 @@
+// MIT License
+
+// Copyright (c) 2015-2023 Kaitai Project
+
+// Permission is hereby granted, free of charge, to any person obtaining a copy
+// of this software and associated documentation files (the "Software"), to
deal
+// in the Software without restriction, including without limitation the rights
+// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+// copies of the Software, and to permit persons to whom the Software is
+// furnished to do so, subject to the following conditions:
+
+// The above copyright notice and this permission notice shall be included in
all
+// copies or substantial portions of the Software.
+
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
THE
+// SOFTWARE.
+
+package org.apache.nifi.processors.network.util;
+
+import java.util.Map;
+import java.util.HashMap;
+
+public enum Linktype {
+NULL_LINKTYPE(0),
+ETHERNET(1),
+EXP_ETHERNET(2),
+AX25(3),
+PRONET(4),
+CHAOS(5),
+IEEE802_5(6),
+ARCNET_BSD(7),
+SLIP(8),
+PPP(9),
+FDDI(10),
+REDBACK_SMARTEDGE(32),
+PPP_HDLC(50),
+PPP_ETHER(51),
+SYMANTEC_FIREWALL(99),
+ATM_RFC1483(100),
+RAW(101),
+C_HDLC(104),
+IEEE802_11(105),
+ATM_CLIP(106),
+FRELAY(107),
+LOOP(108),
+ENC(109),
+NETBSD_HDLC(112),
+LINUX_SLL(113),
+LTALK(114),
+ECONET(115),
+IPFILTER(116),
+PFLOG(117),
+CISCO_IOS(118),
+IEEE802_11_PRISM(119),
+AIRONET_HEADER(120),
+IP_OVER_FC(122),
+SUNATM(123),
+RIO(124),
+PCI_EXP(125),
+AURORA(126),
+IEEE802_11_RADIOTAP(127),
+TZSP(128),
+ARCNET_LINUX(129),
+JUNIPER_MLPPP(130),
+JUNIPER_MLFR(131),
+JUNIPER_ES(132),
+JUNIPER_GGSN(133),
+JUNIPER_MFR(134),
+JUNIPER_ATM2(135),
+JUNIPER_SERVICES(136),
+JUNIPER_ATM1(137),
+APPLE_IP_OVER_IEEE1394(138),
+MTP2_WITH_PHDR(139),
+MTP2(140),
+MTP3(141),
+SCCP(142),
+DOCSIS(143),
+LINUX_IRDA(144),
+IBM_SP(145),
+IBM_SN(146),
+USER0(147),
+USER1(148),
+USER2(149),
+USER3(150),
+USER4(151),
+USER5(152),
+USER6(153),
+USER7(154),
+USER8(155),
+USER9(156),
+USER10(157),
+USER11(158),
+USER12(159),
+USER13(160),
+USER14(161),
+USER15(162),
Review Comment:
I had another look and as the enum is only used to determine whether the
body of a packet should be held in an ethernetFrame or not in the original (and
I don't use an ethernetframe regardless) it seemed more sensible just to remove
it entirely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (NIFI-13259) Publish NiFi Stateless to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13259: Summary: Publish NiFi Stateless to Maven (was: Publish Nifi Stateless to Maven) > Publish NiFi Stateless to Maven > --- > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Bob Paulin >Priority: Minor > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (NIFI-13259) Publish Nifi Stateless to Maven
[ https://issues.apache.org/jira/browse/NIFI-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Handermann updated NIFI-13259: Fix Version/s: (was: 2.0.0-M4) > Publish Nifi Stateless to Maven > --- > > Key: NIFI-13259 > URL: https://issues.apache.org/jira/browse/NIFI-13259 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 2.0.0-M3 >Reporter: Bob Paulin >Priority: Minor > > I'd like to do some integration test work with flow files using the nifi > stateless assembly zip. Would like this published to maven to allow this to > work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
exceptionfactory commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117696590 > @exceptionfactory Please advise whether the `SplitPcap` processor should remain in package `org.apache.nifi.processors.network` and classes `LinkType` and `PCAP` remain in `org.apache.nifi.processors.network.util`. I was thinking they should all go under a new package named `org.apache.nifi.processors.network.pcap`. Moving the new classes under a `pcap` package sounds like the best way forward. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (NIFI-13245) Provenance Event dialog overflow issues
[ https://issues.apache.org/jira/browse/NIFI-13245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Aslan reassigned NIFI-13245: -- Assignee: Scott Aslan > Provenance Event dialog overflow issues > --- > > Key: NIFI-13245 > URL: https://issues.apache.org/jira/browse/NIFI-13245 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: Scott Aslan >Assignee: Scott Aslan >Priority: Major > Attachments: Screenshot 2024-05-15 at 10.18.51 AM.png > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13259) Publish Nifi Stateless to Maven
Bob Paulin created NIFI-13259: - Summary: Publish Nifi Stateless to Maven Key: NIFI-13259 URL: https://issues.apache.org/jira/browse/NIFI-13259 Project: Apache NiFi Issue Type: Improvement Affects Versions: 2.0.0-M3 Reporter: Bob Paulin Fix For: 2.0.0-M4 I'd like to do some integration test work with flow files using the nifi stateless assembly zip. Would like this published to maven to allow this to work using unit tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-12411: Update PublishAMQP to read AMQP headers value from FlowFile attributes and `amq$headers` string [nifi]
umarhussain15 commented on PR #8105: URL: https://github.com/apache/nifi/pull/8105#issuecomment-2117684394 Reverted the AbstractAMQPProcessor change to support expression language in password field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12670) JoltTransform processors incorrectly encode/decode text in the Jolt Specification
[
https://issues.apache.org/jira/browse/NIFI-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Handermann resolved NIFI-12670.
-
Fix Version/s: 2.0.0-M4
Resolution: Fixed
> JoltTransform processors incorrectly encode/decode text in the Jolt
> Specification
> -
>
> Key: NIFI-12670
> URL: https://issues.apache.org/jira/browse/NIFI-12670
> Project: Apache NiFi
> Issue Type: Bug
> Components: Configuration, Extensions
>Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2, 1.26.0, 2.0.0-M3
> Environment: JVM with non-UTF-8 default encoding (e.g. default
> Windows installation)
>Reporter: René Zeidler
>Assignee: Jim Steinebrey
>Priority: Minor
> Labels: encoding, jolt, json, utf8, windows
> Fix For: 2.0.0-M4
>
> Attachments: Jolt_Transform_Encoding_Bug.json,
> Jolt_Transform_Encoding_Bug_M2.json, image-2024-01-25-11-01-15-405.png,
> image-2024-01-25-11-59-56-662.png, image-2024-01-25-12-00-09-544.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> h2. Environment
> This issue affects environments where the JVM default encoding is not
> {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they
> usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue
> on Linux, change the default encoding to {{windows-1252}} by adding the
> following line to your {{{}bootstrap.conf{}}}:
> {quote}{{java.arg.21=-Dfile.encoding=windows-1252}}
> {quote}
> h2. Summary
> The Jolt Specification of both the JoltTransformJSON and JoltTransformRecord
> processors is read interally using the system default encoding, even though
> it is always stored in UTF-8. This causes non-ASCII characters to be garbled
> in the Jolt Specification, resulting in incorrect transformations (missing
> data or garbled keys).
> h2. Steps to reproduce
> # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment"
> # Create a GenerateFlowFile processor with the following content:
> {quote}{
> "regularString": "string with only ASCII characters",
> "umlautString": "string with non-ASCII characters: ÄÖÜäöüßéèóò",
> "keyWithÜmlaut": "any string"
> }
> {quote}
> # Connect the processor to a JoltTransformJSON and/or JoltTransformRecord
> processor.
> (If using the record based processor, use a default JsonTreeReader and
> JsonRecordSetWriter. The record reader/writer don't affect this bug.)
> Set the Jolt Specification to:
> {quote}[
> {
> "operation": "shift",
> "spec": {
> "regularString": "Remapped to Umlaut ÄÖÜ",
> "umlautString": "Umlaut String",
> "keyWithÜmlaut": "Key with Umlaut"
> }
> }
> ]
> {quote}
> # Connect the outputs of the Jolt processor(s) to funnels to be able to
> observe the result in the queue.
> # Start the Jolt processor(s) and run the GenerateFlowFile processor once.
> The flow should look similar to this:
> !image-2024-01-25-11-01-15-405.png!
> I also attached a JSON export of the example flow.
> # Observe the content of the resulting FlowFile(s) in the queue.
> h3. Expected Result
> !image-2024-01-25-12-00-09-544.png!
> h3. Actual Result
> !image-2024-01-25-11-59-56-662.png!
> * Remapped key containing non-ASCII characters is garbled, since the key
> value originated from the Jolt Specification.
> * The key "{{{}keyWithÜmlaut{}}}" could not be matched at all, since it
> contains non-ASCII characters, resulting in missing data in the output.
> h2. Root Cause Analysis
> Both processors use the
> {{[readTransform|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/main/java/org/apache/nifi/processors/jolt/AbstractJoltTransform.java#L242-L249]}}
> method of {{AbstractJoltTransform}} to read the Jolt Specification property.
> This method uses an
> [{{InputStreamReader}}|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/InputStreamReader.html]
> without specifying an encoding, which then defaults to the default charset
> of the environment. Text properties are [always encoded in
> UTF-8|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-api/src/main/java/org/apache/nifi/components/resource/StandardResourceReferenceFactory.java#L111].
> When the default charset is not UTF-8, this results in UTF-8 bytes to be
> interpreted in a different encoding when converting to a string, resulting in
> a garbled Jolt Specification being used.
> h2. Workaround
> This issue is not present when any attribute expression language is present
> in the Jolt Specification. Simply adding {{${literal('')}}} anywhere in the
> Jolt Specification works around this issue.
> This happens because [a
[jira] [Commented] (NIFI-12670) JoltTransform processors incorrectly encode/decode text in the Jolt Specification
[
https://issues.apache.org/jira/browse/NIFI-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847320#comment-17847320
]
ASF subversion and git services commented on NIFI-12670:
Commit b27fc46b60cea8ef47420254596bf3fdb15754f5 in nifi's branch
refs/heads/main from Jim Steinebrey
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=b27fc46b60 ]
NIFI-12670 Read Jolt Transform with UTF-8 Encoding
- Specified UTF-8 encoding for reading Jolt Transform to avoid decoding issues
on Windows or platforms with different default character sets
This closes #8842
Signed-off-by: David Handermann
> JoltTransform processors incorrectly encode/decode text in the Jolt
> Specification
> -
>
> Key: NIFI-12670
> URL: https://issues.apache.org/jira/browse/NIFI-12670
> Project: Apache NiFi
> Issue Type: Bug
> Components: Configuration, Extensions
>Affects Versions: 2.0.0-M1, 1.24.0, 1.25.0, 2.0.0-M2, 1.26.0, 2.0.0-M3
> Environment: JVM with non-UTF-8 default encoding (e.g. default
> Windows installation)
>Reporter: René Zeidler
>Assignee: Jim Steinebrey
>Priority: Minor
> Labels: encoding, jolt, json, utf8, windows
> Attachments: Jolt_Transform_Encoding_Bug.json,
> Jolt_Transform_Encoding_Bug_M2.json, image-2024-01-25-11-01-15-405.png,
> image-2024-01-25-11-59-56-662.png, image-2024-01-25-12-00-09-544.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> h2. Environment
> This issue affects environments where the JVM default encoding is not
> {{{}UTF-8{}}}. Standard Java installations on Windows are affected, as they
> usually use the default encoding {{{}windows-1252{}}}. To reproduce the issue
> on Linux, change the default encoding to {{windows-1252}} by adding the
> following line to your {{{}bootstrap.conf{}}}:
> {quote}{{java.arg.21=-Dfile.encoding=windows-1252}}
> {quote}
> h2. Summary
> The Jolt Specification of both the JoltTransformJSON and JoltTransformRecord
> processors is read interally using the system default encoding, even though
> it is always stored in UTF-8. This causes non-ASCII characters to be garbled
> in the Jolt Specification, resulting in incorrect transformations (missing
> data or garbled keys).
> h2. Steps to reproduce
> # Make sure NiFi runs with a non-UTF-8 default encoding, see "Environment"
> # Create a GenerateFlowFile processor with the following content:
> {quote}{
> "regularString": "string with only ASCII characters",
> "umlautString": "string with non-ASCII characters: ÄÖÜäöüßéèóò",
> "keyWithÜmlaut": "any string"
> }
> {quote}
> # Connect the processor to a JoltTransformJSON and/or JoltTransformRecord
> processor.
> (If using the record based processor, use a default JsonTreeReader and
> JsonRecordSetWriter. The record reader/writer don't affect this bug.)
> Set the Jolt Specification to:
> {quote}[
> {
> "operation": "shift",
> "spec": {
> "regularString": "Remapped to Umlaut ÄÖÜ",
> "umlautString": "Umlaut String",
> "keyWithÜmlaut": "Key with Umlaut"
> }
> }
> ]
> {quote}
> # Connect the outputs of the Jolt processor(s) to funnels to be able to
> observe the result in the queue.
> # Start the Jolt processor(s) and run the GenerateFlowFile processor once.
> The flow should look similar to this:
> !image-2024-01-25-11-01-15-405.png!
> I also attached a JSON export of the example flow.
> # Observe the content of the resulting FlowFile(s) in the queue.
> h3. Expected Result
> !image-2024-01-25-12-00-09-544.png!
> h3. Actual Result
> !image-2024-01-25-11-59-56-662.png!
> * Remapped key containing non-ASCII characters is garbled, since the key
> value originated from the Jolt Specification.
> * The key "{{{}keyWithÜmlaut{}}}" could not be matched at all, since it
> contains non-ASCII characters, resulting in missing data in the output.
> h2. Root Cause Analysis
> Both processors use the
> {{[readTransform|https://github.com/apache/nifi/blob/2e3f83eb54cbc040b5a1da5bce9a74a558f08ea4/nifi-nar-bundles/nifi-jolt-bundle/nifi-jolt-processors/src/main/java/org/apache/nifi/processors/jolt/AbstractJoltTransform.java#L242-L249]}}
> method of {{AbstractJoltTransform}} to read the Jolt Specification property.
> This method uses an
> [{{InputStreamReader}}|https://docs.oracle.com/en/java/javase/21/docs/api/java.base/java/io/InputStreamReader.html]
> without specifying an encoding, which then defaults to the default charset
> of the environment. Text properties are [always encoded in
> UTF-8|https://github.com/apache/nifi/blob/89836f32d017d77972a4de09c4e864b0e11899a8/nifi-api/src/main/java/org/apache/nifi/components/resource/StandardResourceReferenceFactory.java#L111].
> When the default charset is not UTF-8, this
Re: [PR] NIFI-12670 JoltTransform processors incorrectly encode/decode text on Windows [nifi]
exceptionfactory closed pull request #8842: NIFI-12670 JoltTransform processors incorrectly encode/decode text on Windows URL: https://github.com/apache/nifi/pull/8842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MINIFICPP-2376) Add support for parameter context inheritance
[
https://issues.apache.org/jira/browse/MINIFICPP-2376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-2376:
-
Description:
Add support for inherited parameter contexts as per NiFi's implementation:
{code:json}
{
"parameterContexts": [
{
"identifier": "1f1556db-035e-3083-adb5-009c9f7287ba",
"instanceIdentifier": "80a71d11-018f-1000-8e24-059bcc16c923",
"name": "con2",
"parameters": [
{
"name": "b1",
"description": "",
"sensitive": false,
"provided": false,
"value": "v2"
}
],
"inheritedParameterContexts": [
"con1"
],
"description": "",
"componentType": "PARAMETER_CONTEXT"
},
{
"identifier": "e1261f34-ae35-38aa-9f45-6c5bd2d9490b",
"instanceIdentifier": "80a6c6d5-018f-1000-df87-9110bc342b99",
"name": "con1",
"parameters": [
{
"name": "a1",
"description": "",
"sensitive": false,
"provided": false,
"value": "v1"
}
],
"inheritedParameterContexts": [],
"description": "",
"componentType": "PARAMETER_CONTEXT"
}
]
}
{code}
was:
Add support for inherited parameter contexts as per NiFi's implementation:
{code:java}
"parameterContexts": [{"identifier":
"1f1556db-035e-3083-adb5-009c9f7287ba","instanceIdentifier":
"80a71d11-018f-1000-8e24-059bcc16c923","name": "con2",
"parameters": [{"name": "b1",
"description": "","sensitive": false,
"provided": false,"value": "v2"}
],"inheritedParameterContexts": ["con1"
],"description": "","componentType":
"PARAMETER_CONTEXT"},{"identifier":
"e1261f34-ae35-38aa-9f45-6c5bd2d9490b","instanceIdentifier":
"80a6c6d5-018f-1000-df87-9110bc342b99","name": "con1",
"parameters": [{"name": "a1",
"description": "","sensitive": false,
"provided": false,"value": "v1"}
],"inheritedParameterContexts": [],"description": "",
"componentType": "PARAMETER_CONTEXT"}], {code}
> Add support for parameter context inheritance
> -
>
> Key: MINIFICPP-2376
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2376
> Project: Apache NiFi MiNiFi C++
> Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Priority: Major
>
> Add support for inherited parameter contexts as per NiFi's implementation:
> {code:json}
> {
> "parameterContexts": [
> {
> "identifier": "1f1556db-035e-3083-adb5-009c9f7287ba",
> "instanceIdentifier": "80a71d11-018f-1000-8e24-059bcc16c923",
> "name": "con2",
> "parameters": [
> {
> "name": "b1",
> "description": "",
> "sensitive": false,
> "provided": false,
> "value": "v2"
> }
> ],
> "inheritedParameterContexts": [
> "con1"
> ],
> "description": "",
> "componentType": "PARAMETER_CONTEXT"
> },
> {
> "identifier": "e1261f34-ae35-38aa-9f45-6c5bd2d9490b",
> "instanceIdentifier": "80a6c6d5-018f-1000-df87-9110bc342b99",
> "name": "con1",
> "parameters": [
> {
> "name": "a1",
> "description": "",
> "sensitive": false,
> "provided": false,
> "value": "v1"
> }
> ],
> "inheritedParameterContexts": [],
> "description": "",
> "componentType": "PARAMETER_CONTEXT"
> }
> ]
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847309#comment-17847309 ] Chien commented on NIFI-13191: -- [~exceptionfactory] Thank you for replying. There are two main reasons we are currently using InvokeAWSGatewayApi with IAM credentials: # To work around bug in the DynamoDB and SQS processors, we are forwarding via an API Gateway instead: [NIFI-12836] Connection pool shut down and SocketException for many AWS processors - ASF JIRA (apache.org) # We need to call the AWS SES service, for which there is not a NiFi processor available. > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2369) Support parameters inside expression language
[
https://issues.apache.org/jira/browse/MINIFICPP-2369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi updated MINIFICPP-2369:
-
Description:
Add support for referencing parameters in expression language expressions in a
similarly to NiFi's implementation
{code:java}
${ #{abc}:replace('xxx', 'zzz') }{code}
[https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#parameters-and-el]
was:
Add support for referencing parameters in expression language expressions in a
similarly to NiFi's implementation
{{}}
{code:java}
${ #{abc}:replace('xxx', 'zzz') }{code}
https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#parameters-and-el
> Support parameters inside expression language
> -
>
> Key: MINIFICPP-2369
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2369
> Project: Apache NiFi MiNiFi C++
> Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Priority: Major
>
> Add support for referencing parameters in expression language expressions in
> a similarly to NiFi's implementation
> {code:java}
> ${ #{abc}:replace('xxx', 'zzz') }{code}
> [https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#parameters-and-el]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MINIFICPP-2352) Investigate ways to avoid reading full flow files into memory with RocksDB content repository
[ https://issues.apache.org/jira/browse/MINIFICPP-2352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi updated MINIFICPP-2352: - Summary: Investigate ways to avoid reading full flow files into memory with RocksDB content repository (was: Investivate ways to avoid reading full flow files into memory with RocksDB content repository) > Investigate ways to avoid reading full flow files into memory with RocksDB > content repository > - > > Key: MINIFICPP-2352 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2352 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Marton Szasz >Priority: Major > > RocksDB seems to inherently read the full value into memory, which is fine > for most usages, but not when large flow files contents are used in minifi. > We should see if there are any options that lets us keep the contents on disk > while working with them, like with FilesystemContentRepository. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2367) Add non-sensitive parameter support in flow config
[
https://issues.apache.org/jira/browse/MINIFICPP-2367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gábor Gyimesi reassigned MINIFICPP-2367:
Assignee: Gábor Gyimesi
> Add non-sensitive parameter support in flow config
> --
>
> Key: MINIFICPP-2367
> URL: https://issues.apache.org/jira/browse/MINIFICPP-2367
> Project: Apache NiFi MiNiFi C++
> Issue Type: New Feature
>Reporter: Gábor Gyimesi
>Assignee: Gábor Gyimesi
>Priority: Major
>
> Implement non-sensitive parameters with parameter contexts that can be used
> in flow configs and referenced by properties. Sensitive parameters are not
> part of this implementation. Parameters should be referenced with the
> #\{variable} syntax and should be able to be escaped with the ##\{variable}
> syntax as per the documentation in NiFi:
> [https://nifi.apache.org/docs/nifi-docs/html/user-guide.html#referencing-parameters]
> Non-sensitive parameters should only be referenced by non-sensitive
> properties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MINIFICPP-2350) Implement parameter context, parameter substitution in flow definition, properties
[ https://issues.apache.org/jira/browse/MINIFICPP-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gábor Gyimesi reassigned MINIFICPP-2350: Assignee: Gábor Gyimesi > Implement parameter context, parameter substitution in flow definition, > properties > -- > > Key: MINIFICPP-2350 > URL: https://issues.apache.org/jira/browse/MINIFICPP-2350 > Project: Apache NiFi MiNiFi C++ > Issue Type: Epic >Reporter: Marton Szasz >Assignee: Gábor Gyimesi >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117636496 @exceptionfactory Please advise whether the `SplitPcap` processor should remain in package `org.apache.nifi.processors.network` and classes `LinkType` and `PCAP` remain in `org.apache.nifi.processors.network.util`. I was thinking they should all go under a new package named `org.apache.nifi.processors.network.pcap`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (NIFI-12226) Maven plugin: Add flag to skip doc generation
[ https://issues.apache.org/jira/browse/NIFI-12226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-12226. --- Fix Version/s: nifi-nar-maven-plugin-1.5.2 Resolution: Fixed > Maven plugin: Add flag to skip doc generation > - > > Key: NIFI-12226 > URL: https://issues.apache.org/jira/browse/NIFI-12226 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Nicolò Boschi >Priority: Minor > Fix For: nifi-nar-maven-plugin-1.5.2 > > Time Spent: 1h > Remaining Estimate: 0h > > In [LangStream/langstream|https://github.com/LangStream/langstream] we use > this plugin for producing NAR files. The NAR are then ingested by the > LangStream runtime and the documentation is not needed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
dan-s1 commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2117629574 @JackHintonSmartDCSIT Please run `mvn clean install -Pcontrib-check` locally which will run the checkstyle checks which you can then fix. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (NIFI-13258) NAR Plugin - add parameter providers and flow analysis rules extension types
[ https://issues.apache.org/jira/browse/NIFI-13258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-13258: -- Status: Patch Available (was: Open) > NAR Plugin - add parameter providers and flow analysis rules extension types > > > Key: NIFI-13258 > URL: https://issues.apache.org/jira/browse/NIFI-13258 > Project: Apache NiFi > Issue Type: Improvement > Components: Tools and Build >Reporter: Pierre Villard >Assignee: Pierre Villard >Priority: Major > Fix For: nifi-nar-maven-plugin-1.5.2 > > Time Spent: 10m > Remaining Estimate: 0h > > Improve the NiFi NAR Maven plugin to add Parameter Providers and Flow > Analysis Rules in the extension types. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] NIFI-13258 - NAR Plugin - add parameter providers and flow analysis rules extension types [nifi-maven]
pvillard31 opened a new pull request, #36: URL: https://github.com/apache/nifi-maven/pull/36 Improve the NiFi NAR Maven plugin to add Parameter Providers and Flow Analysis Rules in the extension types. We can confirm that in extension-manifest.xml we now have the expected data. Below examples: xml org.apache.nifi.parameter.aws.AwsSecretsManagerParameterProvider PARAMETER_PROVIDER Fetches parameters from AWS SecretsManager. Each secret becomes a Parameter group, which can map to a Parameter Context, with key/value pairs in the secret mapping to Parameters in the group. aws secretsmanager secrets manager secret-name-pattern Secret Name Pattern A Regular Expression matching on Secret Name that identifies Secrets whose parameters should be fetched. Any secrets whose names do not match this pattern will not be fetched. .* true false false NONE false false aws-region Region us-west-2 AWS GovCloud (US) us-gov-west-1 AWS Region Code : us-gov-west-1 ... true false false NONE false false aws-credentials-provider-service AWS Credentials Provider Service Service used to obtain an Amazon Web Services Credentials Provider org.apache.nifi.processors.aws.credentials.provider.service.AWSCredentialsProviderService org.apache.nifi nifi-aws-service-api-nar 2.0.0-SNAPSHOT true false false NONE false false aws-communications-timeout Communications Timeout 30 secs true false false NONE false false aws-ssl-context-service SSL Context Service Specifies an optional SSL Context Service that, if provided, will be used to create connections org.apache.nifi.ssl.SSLContextService org.apache.nifi nifi-standard-services-api-nar 2.0.0-SNAPSHOT false false false NONE false false xml org.apache.nifi.flowanalysis.rules.DisallowComponentType FLOW_ANALYSIS_RULE Produces rule violations for each component (i.e. processors or controller services) of a given type. component processor controller service type component-type Component Type Components of the given type will produce a rule violation (i.e. they shouldn't exist). Either the simple or the fully qualified name of the type should be provided. true false false NONE false false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847293#comment-17847293 ] David Handermann commented on NIFI-13191: - [~chien] Can you provide some additional background on how you are using the InvokeAWSGatewayApi Processor, particularly in terms of which AWS service or services you are calling? Based on those details, it may be worth opening a new issue to implement a Processor supporting the particular services. > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (NIFI-13258) NAR Plugin - add parameter providers and flow analysis rules extension types
Pierre Villard created NIFI-13258: - Summary: NAR Plugin - add parameter providers and flow analysis rules extension types Key: NIFI-13258 URL: https://issues.apache.org/jira/browse/NIFI-13258 Project: Apache NiFi Issue Type: Improvement Components: Tools and Build Reporter: Pierre Villard Assignee: Pierre Villard Fix For: nifi-nar-maven-plugin-1.5.2 Improve the NiFi NAR Maven plugin to add Parameter Providers and Flow Analysis Rules in the extension types. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] NIFI-13232 Add Authentication Configuration REST API method [nifi]
mcgilman commented on PR #8834: URL: https://github.com/apache/nifi/pull/8834#issuecomment-2117525887 Will review... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] NIFI-12411: Update PublishAMQP to read AMQP headers value from FlowFile attributes and `amq$headers` string [nifi]
umarhussain15 commented on PR #8105: URL: https://github.com/apache/nifi/pull/8105#issuecomment-2117511390 Thanks for the explanation, @exceptionfactory. I will revert the change here then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] MINIFICPP-2381 Update inquirer package for python 3.12 support [nifi-minifi-cpp]
lordgamez opened a new pull request, #1790: URL: https://github.com/apache/nifi-minifi-cpp/pull/1790 https://issues.apache.org/jira/browse/MINIFICPP-2381 -- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with MINIFICPP- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically main)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file? - [ ] If applicable, have you updated the NOTICE file? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINIFICPP-2381) Python bootstrap fails to start with python 3.12
Gábor Gyimesi created MINIFICPP-2381:
Summary: Python bootstrap fails to start with python 3.12
Key: MINIFICPP-2381
URL: https://issues.apache.org/jira/browse/MINIFICPP-2381
Project: Apache NiFi MiNiFi C++
Issue Type: Bug
Reporter: Gábor Gyimesi
Assignee: Gábor Gyimesi
This results in a CI failure on MacOS:
{code:java}
Traceback (most recent call last):
50 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/main.py", line
20, in
51from cli import main_menu, do_one_click_build
52 File "/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/cli.py",
line 18, in
53import inquirer
54 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/__init__.py",
line 1, in
55from inquirer.prompt import prompt
56 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/prompt.py",
line 2, in
57from inquirer.render.console import ConsoleRender
58 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/__init__.py",
line 1, in
59from inquirer.render.console import ConsoleRender
60 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/console/__init__.py",
line 10, in
61from inquirer.render.console._editor import Editor
62 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/inquirer/render/console/_editor.py",
line 1, in
63import editor
64 File
"/Users/runner/work/nifi-minifi-cpp/nifi-minifi-cpp/bootstrap/venv/lib/python3.12/site-packages/editor.py",
line 11, in
65from distutils.spawn import find_executable
66ModuleNotFoundError: No module named 'distutils' {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] MINIFICPP-2341 Include custom relationships in C2 manifest for NiFi python processors [nifi-minifi-cpp]
lordgamez commented on code in PR #1770: URL: https://github.com/apache/nifi-minifi-cpp/pull/1770#discussion_r1604690548 ## extensions/python/pythonprocessors/nifiapi/properties.py: ## @@ -281,3 +284,21 @@ def getProperty(self, descriptor) -> PythonPropertyValue: expression_language_support = descriptor.expressionLanguageScope != ExpressionLanguageScope.NONE property_value = self.cpp_context.getProperty(property_name) return PythonPropertyValue(self.cpp_context, property_name, property_value, expression_language_support) + +def getStateManager(self) -> StateManager: +return self.cpp_context.getStateManager() + +def getName(self) -> str: +return self.cpp_context.getName() + +def getProperties(self) -> Dict[PropertyDescriptor, str]: +properties = dict() +cpp_properties = self.cpp_context.getProperties() + +for property_name in cpp_properties: +for property_descriptor in self.processor.getPropertyDescriptors(): +if property_descriptor.name == property_name: +properties[property_descriptor] = cpp_properties[property_name] +break Review Comment: I updated the test and the implementation of getProperties in 9eec8f9b0a61264578330919ed9e16fa2c5007fd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (NIFI-13191) Deprecate InvokeAWSGatewayApi Processor
[ https://issues.apache.org/jira/browse/NIFI-13191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847218#comment-17847218 ] Chien commented on NIFI-13191: -- Hello [~jgresock] [~otto] We are currently using the InvokeAWSGatewayApi processor. What is the replacement/recommended way to invoke an AWS API Gateway with AWS credential provider (for IAM credentials) in the new version? > Deprecate InvokeAWSGatewayApi Processor > --- > > Key: NIFI-13191 > URL: https://issues.apache.org/jira/browse/NIFI-13191 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Minor > Fix For: 1.27.0 > > Time Spent: 20m > Remaining Estimate: 0h > > Similar to the other AWS client library upgrade issues, this targets the > InvokeAWSGatewayApi processor. > Note: After discussing with [~exceptionfactory] and [~otto], we agree that > this processor can be deprecated, and removed in NiFi 2.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on code in PR #8691:
URL: https://github.com/apache/nifi/pull/8691#discussion_r1604543540
##
nifi-extension-bundles/nifi-network-bundle/nifi-network-processors/src/main/java/org/apache/nifi/processors/network/SplitPCAP.java:
##
@@ -0,0 +1,223 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.network;
+
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.flowfile.FlowFile;
+import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
+import org.apache.nifi.annotation.behavior.SideEffectFree;
+import org.apache.nifi.annotation.behavior.WritesAttribute;
+import org.apache.nifi.annotation.behavior.WritesAttributes;
+import org.apache.nifi.annotation.documentation.CapabilityDescription;
+import org.apache.nifi.annotation.documentation.Tags;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.ProcessSession;
+import org.apache.nifi.processor.Relationship;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.flowfile.attributes.FragmentAttributes;
+import org.apache.nifi.processors.network.util.PCAP;
+import org.apache.nifi.processors.network.util.PCAP.ByteBufferInterface;
+import org.apache.nifi.processors.network.util.PCAP.Packet;
+
+import java.io.ByteArrayOutputStream;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+import java.util.UUID;
+
+@SideEffectFree
+@InputRequirement(Requirement.INPUT_REQUIRED)
+@Tags({"PCAP", "Splitter", "Network", "Packet", "Capture", "Wireshark",
"TShark"})
+@CapabilityDescription("Splits a pcap file into multiple pcap files based on a
maximum size.")
+@WritesAttributes({
+@WritesAttribute(attribute = SplitPCAP.ERROR_REASON, description = "The
reason the flowfile was sent to the failure relationship."),
+@WritesAttribute(attribute = "fragment.identifier", description = "All
split FlowFiles produced from the same parent FlowFile will have the same
randomly generated UUID added for this attribute"),
+@WritesAttribute(attribute = "fragment.index", description = "A one-up
number that indicates the ordering of the split FlowFiles that were created
from a single parent FlowFile"),
+@WritesAttribute(attribute = "fragment.count", description = "The number
of split FlowFiles generated from the parent FlowFile"),
+@WritesAttribute(attribute = "segment.original.filename ", description =
"The filename of the parent FlowFile")
+})
+
+public class SplitPCAP extends AbstractProcessor {
+
+protected static final String ERROR_REASON = "ERROR_REASON";
+public static final String FRAGMENT_ID =
FragmentAttributes.FRAGMENT_ID.key();
+public static final String FRAGMENT_INDEX =
FragmentAttributes.FRAGMENT_INDEX.key();
+public static final String FRAGMENT_COUNT =
FragmentAttributes.FRAGMENT_COUNT.key();
+public static final String SEGMENT_ORIGINAL_FILENAME =
FragmentAttributes.SEGMENT_ORIGINAL_FILENAME.key();
+
+public static final PropertyDescriptor PCAP_MAX_SIZE = new
PropertyDescriptor
+.Builder().name("PCAP_MAX_SIZE")
+.displayName("PCAP max size (bytes)")
+.description("Maximum size of the output pcap file in bytes.")
+.required(true)
+.addValidator(StandardValidators.INTEGER_VALIDATOR)
+.build();
+
+public static final Relationship REL_ORIGINAL = new Relationship.Builder()
+.name("original")
+.description("The original FlowFile that was split into segments.
If the FlowFile fails processing, nothing will be sent to "
++ "this relationship")
+.build();
+public static final Relationship REL_FAILURE = new Relationship.Builder()
+.name("failure")
+.description("If a FlowFile cannot be transformed from the
configured input format to the configured output format, "
++ "the unchanged FlowFile will be routed to this relationship.")
+.build();
+public static final Relationship REL_SPLIT =
Re: [PR] [NIFI-13082] Created SplitPcap processor, Pcap supporting class, and … [nifi]
JackHintonSmartDCSIT commented on PR #8691: URL: https://github.com/apache/nifi/pull/8691#issuecomment-2116979138 > @JackHintonSmartDCSIT Looks like you have Checkstyle violations. Please fix them and then I will restart the build. Forgot to add the file prior to committing, oops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
