[jira] [Assigned] (SPARK-6647) Make trait StringComparison as BinaryPredicate and throw error when Predicate can't translate to data source Filter
[
https://issues.apache.org/jira/browse/SPARK-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apache Spark reassigned SPARK-6647:
---
Assignee: (was: Apache Spark)
Make trait StringComparison as BinaryPredicate and throw error when Predicate
can't translate to data source Filter
---
Key: SPARK-6647
URL: https://issues.apache.org/jira/browse/SPARK-6647
Project: Spark
Issue Type: Bug
Components: SQL
Reporter: Liang-Chi Hsieh
Now trait {{StringComparison}} is a {{BinaryExpression}}. In fact, it should
be a {{BinaryPredicate}}.
By making {{StringComparison}} as {{BinaryPredicate}}, we can throw error
when a {{expressions.Predicate}} can't translate to a data source {{Filter}}
in function {{selectFilters}}.
Without this modification, because we will wrap a {{Filter}} outside the
scanned results in {{pruneFilterProjectRaw}}, we can't detect about something
is wrong in translating predicates to filters in {{selectFilters}}.
The unit test of SPARK-6625 demonstrates such problem. In that pr, even
{{expressions.Contains}} is not properly translated to
{{sources.StringContains}}, the filtering is still performed by the
{{Filter}} and so the test passes.
Of course, by doing this modification, all {{expressions.Predicate}} classes
need to have its data source {{Filter}} correspondingly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-6647) Make trait StringComparison as BinaryPredicate and throw error when Predicate can't translate to data source Filter
[
https://issues.apache.org/jira/browse/SPARK-6647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Apache Spark reassigned SPARK-6647:
---
Assignee: Apache Spark
Make trait StringComparison as BinaryPredicate and throw error when Predicate
can't translate to data source Filter
---
Key: SPARK-6647
URL: https://issues.apache.org/jira/browse/SPARK-6647
Project: Spark
Issue Type: Bug
Components: SQL
Reporter: Liang-Chi Hsieh
Assignee: Apache Spark
Now trait {{StringComparison}} is a {{BinaryExpression}}. In fact, it should
be a {{BinaryPredicate}}.
By making {{StringComparison}} as {{BinaryPredicate}}, we can throw error
when a {{expressions.Predicate}} can't translate to a data source {{Filter}}
in function {{selectFilters}}.
Without this modification, because we will wrap a {{Filter}} outside the
scanned results in {{pruneFilterProjectRaw}}, we can't detect about something
is wrong in translating predicates to filters in {{selectFilters}}.
The unit test of SPARK-6625 demonstrates such problem. In that pr, even
{{expressions.Contains}} is not properly translated to
{{sources.StringContains}}, the filtering is still performed by the
{{Filter}} and so the test passes.
Of course, by doing this modification, all {{expressions.Predicate}} classes
need to have its data source {{Filter}} correspondingly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
