[jira] [Commented] (SPARK-14875) OutputWriterFactory.newInstance shouldn't be private[sql]

2016-04-24 Thread Apache Spark (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255633#comment-15255633
 ] 

Apache Spark commented on SPARK-14875:
--

User 'liancheng' has created a pull request for this issue:
https://github.com/apache/spark/pull/12652

> OutputWriterFactory.newInstance shouldn't be private[sql]
> -
>
> Key: SPARK-14875
> URL: https://issues.apache.org/jira/browse/SPARK-14875
> Project: Spark
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Assignee: Cheng Lian
>
> Existing packages like spark-avro need to access 
> {{OutputFactoryWriter.newInstance}}, but it's marked as {{private\[sql\]}} in 
> Spark 2.0. Should make it public again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-14875) OutputWriterFactory.newInstance shouldn't be private[sql]

2016-04-23 Thread Cheng Lian (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255249#comment-15255249
 ] 

Cheng Lian commented on SPARK-14875:


Checked with [~cloud_fan], it was accidentally made private while adding 
bucketing feature. I'm removing this qualifier.

> OutputWriterFactory.newInstance shouldn't be private[sql]
> -
>
> Key: SPARK-14875
> URL: https://issues.apache.org/jira/browse/SPARK-14875
> Project: Spark
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Assignee: Cheng Lian
>
> Existing packages like spark-avro need to access 
> {{OutputFactoryWriter.newInstance}}, but it's marked as {{private\[sql\]}} in 
> Spark 2.0. Should make it public again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

[jira] [Commented] (SPARK-14875) OutputWriterFactory.newInstance shouldn't be private[sql]

2016-04-23 Thread Cheng Lian (JIRA) 

[ 
https://issues.apache.org/jira/browse/SPARK-14875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15255248#comment-15255248
 ] 

Cheng Lian commented on SPARK-14875:


[~marmbrus] Is there any reason why we made it private in Spark 2.0?

> OutputWriterFactory.newInstance shouldn't be private[sql]
> -
>
> Key: SPARK-14875
> URL: https://issues.apache.org/jira/browse/SPARK-14875
> Project: Spark
>  Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Cheng Lian
>Assignee: Cheng Lian
>
> Existing packages like spark-avro need to access 
> {{OutputFactoryWriter.newInstance}}, but it's marked as {{private\[sql\]}} in 
> Spark 2.0. Should make it public again.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org