Re: [PR] Fix incorrect Java equals comparison of Uuid by reference [kafka]

2024-04-13 Thread via GitHub 


chia7712 merged PR #15707:
URL: https://github.com/apache/kafka/pull/15707


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] Fix incorrect Java equals comparison of Uuid by reference [kafka]

2024-04-12 Thread via GitHub 


alok123t commented on code in PR #15707:
URL: https://github.com/apache/kafka/pull/15707#discussion_r1563676834


##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -270,7 +270,7 @@ class DefaultAlterPartitionManager(
 
 inflightAlterPartitionItems.groupBy(_.topicIdPartition.topic).foreach { 
case (topicName, items) =>
   val topicId = items.head.topicIdPartition.topicId
-  canUseTopicIds &= topicId != Uuid.ZERO_UUID
+  canUseTopicIds &= !topicId.equals(Uuid.ZERO_UUID)

Review Comment:
   right, we don't need to do this for Scala files, reverted change in 
https://github.com/apache/kafka/pull/15707/commits/e206a2cfdfa955b3ab004b5644e28e6fa23999b9



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org