Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

[via GitHub]

showuon merged PR #15801:
URL: https://github.com/apache/kafka/pull/15801


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

[via GitHub]

showuon commented on PR #15801:
URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076455539

   The thread leaking failed tests disappeared now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

[via GitHub]

showuon commented on code in PR #15801:
URL: https://github.com/apache/kafka/pull/15801#discussion_r1578771823


##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -171,8 +162,8 @@ private String[] getArgs(String group, String topic) {
 };
 }
 
-private void setupConsumerGroupService(String[] args) {
-consumerGroupService = new ConsumerGroupCommand.ConsumerGroupService(
+private static ConsumerGroupCommand.ConsumerGroupService 
consumerGroupService(String[] args) {

Review Comment:
   Why should we use static method here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

[via GitHub]

FrankYang0529 commented on PR #15801:
URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076141433

   @chia7712, thanks for the hotfix. I'm very sorry for the inconvenient. The 
fix LGTM. It's better to use try-with-resource to close resource. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[PR] HOTFIX: make sure all ConsumerGroupServices get closed [kafka]

[via GitHub]

chia7712 opened a new pull request, #15801:
URL: https://github.com/apache/kafka/pull/15801

   Some services are not closed, so our CI print following error.
   ```
   org.opentest4j.AssertionFailedError: Found 16 unexpected threads during 
@BeforeAll: `kafka-admin-client-thread | 
adminclient-287,kafka-admin-client-thread | 
adminclient-276,kafka-admin-client-thread | 
adminclient-271,kafka-admin-client-thread | 
adminclient-293,kafka-admin-client-thread | 
adminclient-281,kafka-admin-client-thread | 
adminclient-302,kafka-admin-client-thread | 
adminclient-334,kafka-admin-client-thread | 
adminclient-323,kafka-admin-client-thread | 
adminclient-257,kafka-admin-client-thread | 
adminclient-336,kafka-admin-client-thread | 
adminclient-308,kafka-admin-client-thread | 
adminclient-263,kafka-admin-client-thread | 
adminclient-273,kafka-admin-client-thread | 
adminclient-278,kafka-admin-client-thread | 
adminclient-283,kafka-admin-client-thread | adminclient-317` ==> expected: 
 but was: 
   ```
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org