Re: [PR] KAFKA-16613: remove TestUtils#subscribeAndWaitForRecords [kafka]

2024-04-24 Thread via GitHub


chia7712 merged PR #15794:
URL: https://github.com/apache/kafka/pull/15794


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] KAFKA-16613: remove TestUtils#subscribeAndWaitForRecords [kafka]

2024-04-24 Thread via GitHub


FrankYang0529 opened a new pull request, #15794:
URL: https://github.com/apache/kafka/pull/15794

   After https://github.com/apache/kafka/pull/15679, we remove most of usage of 
`TestUtils#subscribeAndWaitForRecords`. The only remaining case uses it is 
`PlaintextAdminIntegrationTest#testDeleteConsumerGroupOffsets`. We can also 
remove it because `Consumer#poll` already has timeout input. We don't need 
`TestUtils#subscribeAndWaitForRecords` to give another waiting wrapper.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org