[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831704#comment-17831704
]
Matthias J. Sax commented on KAFKA-10409:
-
I don't think anybody worked on this ticket (not sure why status actually says
"in progress" – seems to be wrong).
> Refactor Kafka Streams RocksDb iterators
> -
>
> Key: KAFKA-10409
> URL: https://issues.apache.org/jira/browse/KAFKA-10409
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Jorge Esteban Quilcate Otoya
>Priority: Minor
> Labels: newbie
>
> From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
> [~ableegoldman] :
> > Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> > {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> > iterators could be cleaned up a bit in general to be more understandable –
> > for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> > {{all()}} method but for range queries we do the seeking inside the
> > iterator constructor.
> and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> > Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> > follow even before the reverse iteration, so it would be nice to have some
> > tests specifically covering reverse iterators over multi-column-family
> > timestamped stores
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828250#comment-17828250
]
Jorge Esteban Quilcate Otoya commented on KAFKA-10409:
--
[~dhawalkapil] thanks for reaching out, and sorry for the late reply.
I haven't follow the developments here unfortunately. Though the PR you
mentioned is a reference, not actually implementing this ticket.
> Refactor Kafka Streams RocksDb iterators
> -
>
> Key: KAFKA-10409
> URL: https://issues.apache.org/jira/browse/KAFKA-10409
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Jorge Esteban Quilcate Otoya
>Priority: Minor
> Labels: newbie
>
> From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
> [~ableegoldman] :
> > Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> > {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> > iterators could be cleaned up a bit in general to be more understandable –
> > for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> > {{all()}} method but for range queries we do the seeking inside the
> > iterator constructor.
> and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> > Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> > follow even before the reverse iteration, so it would be nice to have some
> > tests specifically covering reverse iterators over multi-column-family
> > timestamped stores
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796564#comment-17796564
]
Dhawal Kapil commented on KAFKA-10409:
--
Hi [~jeqo]
A newbie here :)
Can this Jira be marked closed as I can see the mentioned PR has been merged or
is there some work still left?
> Refactor Kafka Streams RocksDb iterators
> -
>
> Key: KAFKA-10409
> URL: https://issues.apache.org/jira/browse/KAFKA-10409
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Jorge Esteban Quilcate Otoya
>Priority: Minor
> Labels: newbie
>
> From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
> [~ableegoldman] :
> > Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> > {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> > iterators could be cleaned up a bit in general to be more understandable –
> > for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> > {{all()}} method but for range queries we do the seeking inside the
> > iterator constructor.
> and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> > Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> > follow even before the reverse iteration, so it would be nice to have some
> > tests specifically covering reverse iterators over multi-column-family
> > timestamped stores
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators
[
https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635338#comment-17635338
]
Ahmed Sobeh commented on KAFKA-10409:
-
WIll pick this up and take a look if it's ok with everyone watching
> Refactor Kafka Streams RocksDb iterators
> -
>
> Key: KAFKA-10409
> URL: https://issues.apache.org/jira/browse/KAFKA-10409
> Project: Kafka
> Issue Type: Improvement
> Components: streams
>Reporter: Jorge Esteban Quilcate Otoya
>Priority: Minor
> Labels: newbie
>
> From [https://github.com/apache/kafka/pull/9137#discussion_r470345513] :
> [~ableegoldman] :
> > Kind of unrelated, but WDYT about renaming {{RocksDBDualCFIterator}} to
> > {{RocksDBDualCFAllIterator}} or something on the side? I feel like these
> > iterators could be cleaned up a bit in general to be more understandable –
> > for example, it's weird that we do the {{iterator#seek}}-ing in the actual
> > {{all()}} method but for range queries we do the seeking inside the
> > iterator constructor.
> and [https://github.com/apache/kafka/pull/9137#discussion_r470361726] :
> > Personally I found the {{RocksDBDualCFIterator}} logic a bit difficult to
> > follow even before the reverse iteration, so it would be nice to have some
> > tests specifically covering reverse iterators over multi-column-family
> > timestamped stores
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
