[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 CC||michal.dybc...@gmail.com

--- Comment #17 from Nate Graham  ---
*** Bug 393755 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

   Version Fixed In||5.16.0
 Status|CONFIRMED   |RESOLVED
  Latest Commit||https://commits.kde.org/pla
   ||sma-desktop/ce84d6ab4babc80
   ||707f4e4c1deb02cfe3ac5b7bb
 Resolution|--- |FIXED

--- Comment #16 from Nate Graham  ---
Git commit ce84d6ab4babc80707f4e4c1deb02cfe3ac5b7bb by Nate Graham, on behalf
of Atul Bisht.
Committed on 14/05/2019 at 15:02.
Pushed by ngraham into branch 'master'.

[libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is
used on X11

Summary:
Earlier when libinput was used on X11, XInput specific UI was shown, due to
which most of the options were grayed out.
Now we show libinput specific UI that is already used on wayland if libinput
driver is used on X11.

- loaded all libinput properties that are available on X11.
- exposed all Q_PROPERTY to Libinput specific UI.
Related: bug 392709
FIXED-IN: 5.16.0

Reviewers: ngraham, romangg, davidedmundson, #plasma

Reviewed By: ngraham, romangg, #plasma

Subscribers: GB_2, jriddell, knambiar, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D20186

M  +1-0kcms/touchpad/src/backends/kwin_wayland.cmake
M  +2-0kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
M  +6-27   kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
M  +27   -385  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
C  +4-8kcms/touchpad/src/backends/libinputcommon.cpp [from:
kcms/touchpad/src/kcm/touchpadconfigplugin.cpp - 072% similarity]
C  +130  -142  kcms/touchpad/src/backends/libinputcommon.h [from:
kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h - 084%
similarity]
M  +1-0kcms/touchpad/src/backends/x11.cmake
M  +370  -27   kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
M  +102  -2kcms/touchpad/src/backends/x11/libinputtouchpad.h
M  +3-1kcms/touchpad/src/backends/x11/synapticstouchpad.h
M  +67   -0kcms/touchpad/src/backends/x11/xlibbackend.cpp
M  +9-0kcms/touchpad/src/backends/x11/xlibbackend.h
M  +7-1kcms/touchpad/src/backends/x11/xlibtouchpad.h
M  +27   -0kcms/touchpad/src/kcm/libinput/main.qml
M  +2-3kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
M  +1-0kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.h
M  +9-2kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
M  +3-2kcms/touchpad/src/kcm/touchpadconfigplugin.cpp
M  +1-1kcms/touchpad/src/kcm/touchpadconfigplugin.h
M  +2-4kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.cpp
M  +1-0kcms/touchpad/src/kcm/xlib/touchpadconfigxlib.h
M  +5-0kcms/touchpad/src/touchpadbackend.cpp
M  +13   -1kcms/touchpad/src/touchpadbackend.h

https://commits.kde.org/plasma-desktop/ce84d6ab4babc80707f4e4c1deb02cfe3ac5b7bb

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 CC||nicolam...@aol.com

--- Comment #15 from Nate Graham  ---
*** Bug 406778 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[atulbi]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #14 from atulbi  ---
Welcome, Nate :D

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #13 from Nate Graham  ---
We have a new patch to fix this, courtesy of the touchpad KCM's new maintainer
Atul Bisht: https://phabricator.kde.org/D20186

Thanks Atul!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Rajeesh K V]

https://bugs.kde.org/show_bug.cgi?id=387153

Rajeesh K V  changed:

   What|Removed |Added

 CC||rajeeshknamb...@gmail.com
   Assignee|rajeeshknamb...@gmail.com   |atulbish...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Gabriel B]

https://bugs.kde.org/show_bug.cgi?id=387153

Gabriel B  changed:

   What|Removed |Added

 CC||juangabo+kdeBugtracking@gma
   ||il.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Harry ten Berge]

https://bugs.kde.org/show_bug.cgi?id=387153

Harry ten Berge  changed:

   What|Removed |Added

 CC||htenbe...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Valorie Zimmerman]

https://bugs.kde.org/show_bug.cgi?id=387153

Valorie Zimmerman  changed:

   What|Removed |Added

 CC||valorie.zimmer...@gmail.com

--- Comment #12 from Valorie Zimmerman  ---
This is affecting at least some of us on the latest Kubuntu (Cosmic). I have
nvidia so it will be awhile until Wayland is possible on this box.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=387153

andydecle...@gmail.com changed:

   What|Removed |Added

 CC||andydecle...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

   Assignee|furkantoka...@gmail.com |rajeeshknamb...@gmail.com
   Severity|normal  |major
 Status|ASSIGNED|CONFIRMED

--- Comment #11 from Nate Graham  ---
Doesn't seem like Furkan will be fixing this, darn. It's probably up to Roman
at this point!

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 CC||jari...@hotmail.com

--- Comment #10 from Nate Graham  ---
*** Bug 398893 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=387153

ree...@gmail.com changed:

   What|Removed |Added

 CC||ree...@gmail.com

--- Comment #9 from ree...@gmail.com ---
Is it possible to just turn off KDM's pointer handling altogether? Or at least
make it possible to run a script when configuring a device.

My problem is that I have three pointing devices: touchpad, trackpoint and
intermittent USB mouse. Every time I plug the mouse in, kcminit screws up the
settings for both touchpad and trackpoint.

Prior to recent updates my /etc configuration worked fine with no interference,
but now KDE cannot be persuaded to just let things alone. 

Here's the config I have in /etc. This works just fine without kdminit's
meddling:

# Match on all pointing devices but joysticks

Section "InputClass"
Identifier "cfr libinput pointer catchall"
MatchIsPointer "on"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
EndSection

# llaw chwith : llygod = pointers *heb* touchpads & trackpoints

Section "InputClass"
Identifier "cfr libinput llygod"
MatchIsPointer "on"
MatchIsTouchpad "off"
NoMatchProduct "TrackPoint"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
Option "Left Handed Enabled" "1"
EndSection


# dim ond trackpoint
# addaswyd o https://bbs.archlinux.org/viewtopic.php?pid=1747203#p1747203

Section "InputClass"
Identifier "cfr libinput trackpoint" 
MatchIsPointer "on"
MatchIsTouchpad "off"
MatchProduct "TrackPoint"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
Option "Accel Speed" "1"
Option "Accel Profile" "flat"
Option "Left Handed Enabled" "0"
EndSection

# dim ond touchpads

Section "InputClass"
Identifier "cfr libinput touchpad catchall"
MatchIsTouchpad "on"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
Option "Tapping" "1"
Option "TappingDragLock" "1"
Option "Accel Speed" "1"
Option "Left Handed Enabled" "0"
EndSection

And here is kcminit-undo, which I must run shortly after I plug a mouse in:

#!/bin/bash -
#set -x
PATH=/usr/bin
export PATH

allan=0

usage="Usage: $0 
Ceisio dadwneud kdminit sy'n torri config llygoden, touchpad a trackpoint."
error () {
echo "$@" 1>&2
((allan++))
usage_and_exit $allan
}
warning () {
echo "$@" 1>&2
((allan++))
return 1
}
usage () {
printf %b "$usage\n"
}
usage_and_exit () {
usage
exit $1
}
try () {
xinput set-prop $1 "$2" $3 || warning "Gwall: na allaf gosod  "$2" $3
am $4."
}

tempargs=$(getopt -o h --long help -- "$@")
if [ $? != 0 ];
then
usage_and_exit
fi
eval set -- "$tempargs"

while true
do
case "$1"
in
-h | --help)
usage;
exit $allan;;
--)
shift;
break;;
*)
error Unrecognised option "$1".
esac
done


touch=$(xinput list --id-only "SynPS/2 Synaptics TouchPad")
track=$(xinput list --id-only "TPPS/2 IBM TrackPoint")
mouse=$(xinput list  | grep "Mouse" | sed
's/^.*id=\([0-9][0-9]*\)[^0-9].*$/\1/')

[[ "$mouse" != "" ]] && xinput set-prop $mouse "libinput Left Handed Enabled" 1

try $track "libinput Left Handed Enabled" 0  TrackPoint
try $track "libinput Accel Speed" 1 TrackPoint
try $track "libinput Accel Profile Enabled" "0, 1" TrackPoint
try $touch "libinput Accel Speed" 1 TouchPad
try $touch "libinput Tapping Enabled" 1 TouchPad
try $touch "libinput Tapping Drag Lock Enabled" 1 TouchPad
try $touch "libinput Left Handed Enabled" 0 TouchPad


exit $allan
# vim: set nospell: 

The module seems to have no discretion at all. It sets everything left-handed,
whereas I only want the mouse that way - not the trackpoint. And it drastically
slows pointer speed for the touchpad and, to a lesser extent, the trackpoint.

Please provide an option to disable this functionality in KDE without
uninstalling KDE altogether. I know I have a somewhat specific setup. I don't
expect a GUI to accommodate it. But the GUI needs an off switch so KDE keeps
out of the way again.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

   Priority|NOR |VHI

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 Status|UNCONFIRMED |ASSIGNED
   Assignee|rajeeshknamb...@gmail.com   |furkantoka...@gmail.com
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Roman Gilg]

https://bugs.kde.org/show_bug.cgi?id=387153

Roman Gilg  changed:

   What|Removed |Added

 CC||subd...@gmail.com

--- Comment #8 from Roman Gilg  ---
The Mouse KCM now has a special libinput X11 backend and uses similar GUI as
with libinput Wayland backend.

There is currently a GSoC project under way to do something similar for the
Touchpad KCM.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Rex Dieter]

https://bugs.kde.org/show_bug.cgi?id=387153

Rex Dieter  changed:

   What|Removed |Added

 CC||rdie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Ben Creasy]

https://bugs.kde.org/show_bug.cgi?id=387153

Ben Creasy  changed:

   What|Removed |Added

 CC||b...@bencreasy.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Simon Andric]

https://bugs.kde.org/show_bug.cgi?id=387153

Simon Andric  changed:

   What|Removed |Added

 CC||simonandr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #7 from Nate Graham  ---
*** Bug 391693 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Mads]

https://bugs.kde.org/show_bug.cgi?id=387153

Mads  changed:

   What|Removed |Added

 CC||m...@ab3.no

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

   Keywords||usability

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Arthur Țițeică]

https://bugs.kde.org/show_bug.cgi?id=387153

Arthur Țițeică  changed:

   What|Removed |Added

 CC||arthur+...@cloud.titeica.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #6 from Nate Graham  ---
At least on Ubuntu-based distros, if you have xserver-xorg-input-synaptics and
xserver-xorg-input-libinput installed at the same time, libinput takes
precedence. So if libinput is installed, we would always want to use that as
the backend, regardless of whether or not synaptics was also installed. And
newer Ubuntu releases like 17.10 don't even install the synaptics one at all by
default.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Weng Xuetian]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #5 from Weng Xuetian  ---
(In reply to Nate Graham from comment #4)
> The old XInput-based touchpad KCM does indeed *sort of* work with
> libinput-on-xorg, but 90% of the UI is grayed out, since those options
> aren't supported on libinput. *Everything* on the Sensitivity tab is
> disabled! And libinput-specific settings aren't exposed (e.g. left handed
> mode, click method).
> 
> The result is a poor user experience. It seems like it might be possible to
> fix those problems, but why bother when we already have a better
> libinput-specific UI that's used on Wayland? When libinput is being used on
> X11, couldn't we show the nice UI but use the XInput backend?

Emm, the problem is, xinput may use different driver at the same time so I
assume it's not an easy issue to resolve.

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

--- Comment #4 from Nate Graham  ---
The old XInput-based touchpad KCM does indeed *sort of* work with
libinput-on-xorg, but 90% of the UI is grayed out, since those options aren't
supported on libinput. *Everything* on the Sensitivity tab is disabled! And
libinput-specific settings aren't exposed (e.g. left handed mode, click
method).

The result is a poor user experience. It seems like it might be possible to fix
those problems, but why bother when we already have a better libinput-specific
UI that's used on Wayland? When libinput is being used on X11, couldn't we show
the nice UI but use the XInput backend?

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Weng Xuetian]

https://bugs.kde.org/show_bug.cgi?id=387153

Weng Xuetian  changed:

   What|Removed |Added

 CC||wen...@gmail.com

--- Comment #3 from Weng Xuetian  ---
Is it really a bug?

On X11, even if you're using libinput driver, libinput is configured via
XInput.
Even it's all "libinput" they will need to use different code path. You can
configure touchpad with old UI for libinput X11 driver.

On the new UI side, I assume that the new UI is only designed for libinput
because it don't want to carry the burden from X11 (on X11 we support synaptics
and libinput), so it's only used on wayland.

FYI X11+Libinput: kcms/touchpad/src/backends/x11/libinputtouchpad.{h,cpp}

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 CC||jeremy9...@gmail.com

--- Comment #2 from Nate Graham  ---
*** Bug 384518 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 CC||kdeb...@fratti.ch

--- Comment #1 from Nate Graham  ---
*** Bug 374214 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Dr . Chapatin]

https://bugs.kde.org/show_bug.cgi?id=387153

Dr. Chapatin  changed:

   What|Removed |Added

 CC||bugsefor...@gmx.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

Summary|libinput-backend touchpad   |libinput-backend touchpad
   |KCM only used on Wayland|KCM only used on Wayland
   |despite appearing to have   |
   |support under X11   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland despite appearing to have support under X11

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

 Blocks||383379


Referenced Bugs:

https://bugs.kde.org/show_bug.cgi?id=383379
[Bug 383379] Modernize Input Devices section to work with Libinput
-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland despite appearing to have support under X11

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

  Alias|KCM, libinput, on,  |libinput-touchpad-kcm-on-x1
   |touchpad, X11   |1

-- 
You are receiving this mail because:
You are watching all bug changes.

[Touchpad-KCM] [Bug 387153] libinput-backend touchpad KCM only used on Wayland despite appearing to have support under X11

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=387153

Nate Graham  changed:

   What|Removed |Added

  Alias||libinput, touchpad, KCM,
   ||on, X11

-- 
You are receiving this mail because:
You are watching all bug changes.