[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Walter Rudametkin]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #38 from Walter Rudametkin  ---
You're right, I forgot to set the new shortcut! I think what got me is that
your patch made it work for split terminals without any new shortcuts.

Works perfectly now in all cases. Any chance of getting the patch into Yakuake?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #37 from Mathias Panzenböck  ---
Do you use the shortcut for "New Session (Same Working Directory)"? Because my
patch does not change the "New Session" shortcut, but instead adds a new
shortcut. This way you can have both behaviors with different shortcuts.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Walter Rudametkin]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #36 from Walter Rudametkin  ---
Matías, I updated git and applied your second patch, nothing changed on my
side, behavior is the same.

To check if it had something to do with my environment (XFCE, .bashrc,
yakuakerc), I installed plasma-desktop and created a new user. Exactly the same
behavior as before, the $PWD is properly set for split terminals, but not for
new tabs.

It's still an improvement for me :)

As I side-note, with split terminals I don't remember seeing the issue you
noticed where you need to hit enter after changing directories.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #35 from Kurt Hindenburg  ---
I see that this bug was originally set to yakuake and then moved to Konsole.

Since these patches are for yakuake, I would suggest either moving this back
over to yakuake or creating a new bug report (which might be cleaner ATM).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #34 from Mathias Panzenböck  ---
Comment on attachment 107788
  --> https://bugs.kde.org/attachment.cgi?id=107788
Don't use TerminalInterface::currentWorkingDirectory() under Linux

This only changes Terminal::currentWorkingDirectory() and doesn't the the rest
of my patch. I use this personally because the erratic behavior was too
annoying for me.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #33 from Mathias Panzenböck  ---
Created attachment 107788
  --> https://bugs.kde.org/attachment.cgi?id=107788=edit
Don't use TerminalInterface::currentWorkingDirectory() under Linux

Workaround for erratic TerminalInterface::currentWorkingDirectory() behavior by
reading /proc/$PID/cwd directly (which is Linux-only).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #32 from Mathias Panzenböck  ---
For me it opens the new tab in the $PWD the current tab had _before the last
command_. That means if you e.g. do `cd ~/images` and then open a new tab it
will open in ~. But if you just do an extra enter after the cd the new tab WILL
be in ~/images. Weird. It wasn't like that before I updated (before I rebased
to current master).

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Walter Rudametkin]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #31 from Walter Rudametkin  ---
By "remembers" I means that it opens the terminal at the same $PWD as the last
selected terminal.

For me, when I open a new terminal in a new tab by pressing ctrl+shift+t, the
terminal opens in ~ every time, so the patch doesn't seem to work.

When I open a new terminal in a split, e.g., ctrl+( or ctrl+) or
right-clicking, the new terminal opens in the same $PWD as the previously
selected terminal.

So it doesn't seem to work for me as it does for you, but it's still better
than what I had.

I might mention that I'm running Yakuake in XFCE in Arch, not in KDE, maybe
that has something to do with it? I'll try again tomorrow with a clean config
too.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #30 from Mathias Panzenböck  ---
What do you mean by remembers? Also personally I only use tabs, not splitting
sessions. The buggy behavior it has now annoys me. How did that happen? :/

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=214547

flex...@gmail.com changed:

   What|Removed |Added

 CC|flex...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Walter Rudametkin]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #29 from Walter Rudametkin  ---
I applied your patch, it's working on my end.

Just to be clear, the patch remembers the $PWD in the current session (e.g.,
when splitting terminals horizontally/vertically), but not for new sessions
(e.g., opening a new tab with ctrl+shift+t). I'm not sure if that's the desired
behavior, I'd prefer it to always remember the $PWD, but it's still a lot
better than before.

Thanks Mathias!

Regards,
Walter

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #28 from Mathias Panzenböck  ---
Created attachment 107784
  --> https://bugs.kde.org/attachment.cgi?id=107784=edit
Rebased patch to master

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Mathias Panzenböck]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #27 from Mathias Panzenböck  ---
I updated Yakuake for the first time in a long while and rebased my patch on
top of master: Now it seems to be buggy for the first time you try to open a
new tab in the same directory for some reason. Didn't had that behavior before.
Konsole doesn't behave that way.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Walter Rudametkin]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #26 from Walter Rudametkin  ---
Good to see some new comments. I really like Yakuake but this bug drives me
crazy.

Any one know if Mathias' patch still works?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Egmont Koblinger]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #25 from Egmont Koblinger  ---
Haha, cool... sorry I've missed out on this :)

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=214547

--- Comment #24 from Kurt Hindenburg  ---
OSC 7 supoort was committed over a year ago - I'd have to check how the KPart
handles it.  I assume from the recent reports, it is not working as people
expects it to.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Egmont Koblinger]

https://bugs.kde.org/show_bug.cgi?id=214547

Egmont Koblinger  changed:

   What|Removed |Added

 CC||egm...@gmail.com

--- Comment #23 from Egmont Koblinger  ---
On a side note, have you guys thought about replacing whatever konsole is doing
now (digging under /proc) with what gnome-terminal and other vte derivatives,
macOS's Terminal.app and perhaps iTerm2 do, namely using the OSC 7 escape
sequence by the shell to explicitly tell the current working directory to the
terminal?

I'm not aware of the API and whether this change would have any implications
there, but...

> This is kind of fixed but seems to only work if the current tab isn't running
> anything in the foreground. Otherwise a new tab lands me in my home directory.

... I guess it would (among others) have the benefit that these kinds of
problems could no longer occur.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Arthur Țițeică]

https://bugs.kde.org/show_bug.cgi?id=214547

Arthur Țițeică  changed:

   What|Removed |Added

 CC||arthur+...@cloud.titeica.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 214547] Kosole KPart needs an API to retrieve $PWD

[Dmitry Vinokurov]

https://bugs.kde.org/show_bug.cgi?id=214547

Dmitry Vinokurov  changed:

   What|Removed |Added

 CC||gim6...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.