[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Ricardo J. Barberis]

https://bugs.kde.org/show_bug.cgi?id=305162

--- Comment #13 from Ricardo J. Barberis  ---
This is really cool!

Does anybody know if this will work for yakuake also, or only konsole?
X11, Wayland or both?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=305162

tcanabr...@kde.org changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/util
   ||ities/konsole/commit/8fb689
   ||93891996dfcb1dee0d3ddc97870
   ||b19d430

--- Comment #12 from tcanabr...@kde.org ---
Git commit 8fb68993891996dfcb1dee0d3ddc97870b19d430 by Tomaz  Canabrava, on
behalf of Luis Javier Merino Morán.
Committed on 05/07/2022 at 09:04.
Pushed by tcanabrava into branch 'master'.

Focus session from notification

Adds a "Show session" button to notifications, which, when clicked, will
focus the originating session.

Original patch by Kasper Laudrup at bug 305162, then updated by Martin
T. H. Sandsmark.

Now updated and extended to silence/activity/process termination
notifications, adding support for focusing a TerminalDisplay inside a
hierarchy of ViewSplitters inside a TabbedViewContainer, and using
KWindowSystem::forceActiveWindow() instead of ::activateWindow().
Related: bug 344208

M  +6-0src/MainWindow.cpp
M  +3-0src/MainWindow.h
M  +1-0src/ViewManager.cpp
M  +2-0src/ViewManager.h
M  +14   -10   src/session/Session.cpp
M  +8-5src/session/SessionController.cpp
M  +9-4src/terminalDisplay/TerminalBell.cpp
M  +3-1src/terminalDisplay/TerminalBell.h
M  +5-0src/terminalDisplay/TerminalDisplay.cpp
M  +3-0src/terminalDisplay/TerminalDisplay.h
M  +14   -0src/widgets/ViewContainer.cpp
M  +1-0src/widgets/ViewContainer.h

https://invent.kde.org/utilities/konsole/commit/8fb68993891996dfcb1dee0d3ddc97870b19d430

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Bug Janitor Service]

https://bugs.kde.org/show_bug.cgi?id=305162

Bug Janitor Service  changed:

   What|Removed |Added

 Status|CONFIRMED   |ASSIGNED

--- Comment #11 from Bug Janitor Service  ---
A possibly relevant merge request was started @
https://invent.kde.org/utilities/konsole/-/merge_requests/581

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Ricardo J. Barberis]

https://bugs.kde.org/show_bug.cgi?id=305162

--- Comment #10 from Ricardo J. Barberis  ---
A few months ago I noticed that if I click on a Slack notification it not only
focuses the rigth tab in my browser (Opera), it also takes me to the channel
where the notificacion originated.

So, theoretically this should be possible to implement in Konsole and other
apps.

In fact, I thought this may actually be working right now.

But how to test it? Is there a simple way to reproduce a bell in Konsole?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[fire f.]

https://bugs.kde.org/show_bug.cgi?id=305162

--- Comment #9 from fire f.  ---
does systemd journal learn of BELL events ?

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Kurt Hindenburg]

https://bugs.kde.org/show_bug.cgi?id=305162

--- Comment #8 from Kurt Hindenburg  ---
Yes, I don't recall this report at all - I'll try to look at it sometime.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[mathew]

https://bugs.kde.org/show_bug.cgi?id=305162

mathew  changed:

   What|Removed |Added

 CC||m...@pobox.com

--- Comment #7 from mathew  ---
So, what happened to this patch? Did it get forgotten?

I'm getting notifications saying "Bell in session 'Default'", which is pretty
useless since all my tabs are using the default terminal configuration, and
there's no way to find out which one is belling and no button.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Arthur Țițeică]

https://bugs.kde.org/show_bug.cgi?id=305162

Arthur Țițeică  changed:

   What|Removed |Added

 CC||arthur+...@cloud.titeica.ro

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Ricardo J . Barberis]

https://bugs.kde.org/show_bug.cgi?id=305162

Ricardo J. Barberis  changed:

   What|Removed |Added

 CC||ricardo.barbe...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Martin Sandsmark via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=305162

Martin Sandsmark  changed:

   What|Removed |Added

  Attachment #75789|0   |1
is obsolete||
 CC||martin.sandsm...@kde.org

--- Comment #6 from Martin Sandsmark  ---
Created attachment 99815
  --> https://bugs.kde.org/attachment.cgi?id=99815=edit
Updated patch

I updated the patch to build with the latest konsole master branch.

I don't need this myself, so if someone else wants to feel free to continue on
it on reviewboard.kde.org.

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[cpon via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=305162

cpon  changed:

   What|Removed |Added

 CC||cpigat...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.

[konsole] [Bug 305162] Konsole notification "Bell in session" should have button to bring up that session

[Piotr Dobrogost via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=305162

Piotr Dobrogost  changed:

   What|Removed |Added

 CC||p...@bugs.kde.dobrogost.net

-- 
You are receiving this mail because:
You are watching all bug changes.