[Koha-bugs] [Bug 36854] Add search index mappings for preceding and succeeding entry of serial ISSNs to Elasticsearch MARC21 indexes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36854 --- Comment #13 from Aleisha Amohia --- (In reply to Caroline Cyr La Rose from comment #11) > > What is the exact use case Aleisha? They want to use the index drop-down, > choose ISSN, type in an ISSN and find all related periodicals? Or is it for > an integration with another tool? Originally they had been interested in both the 'standard number' and 'ISSN' advanced search dropdowns also searching the 780$x and 785$x In saying that they have decided this is no longer a priority for them, so if there isn't agreement on the best way to make these tags searchable then we can probably close this report for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36766] Add command-line utility to SFTP a file to a remote server
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36766 --- Comment #7 from Alex Buckley --- Created attachment 166859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166859=edit Bug 36766: Only list the file basename as the SFTP put destination Sponsored-by: Horowhenua Libraries, Toi Ohomai Institute of Technology, Plant and Food Research Limited, Waitaki District Council, South Taranaki District Council New Zealand -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32722] Mandatory subfields from UNIMARC framework shouldn't block the creation of a bib record when field itself is optional
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32722 --- Comment #13 from Phil Ringnalda --- FWIW, my suggestion would be three bugs: 1. Major: Revert the mandatory changes to the UNIMARC frameworks we ship, since they should be a "Mandatory if tag is used" which doesn't currently exist. 2. Enh: Add a third checkbox for subfields (in both UNIMARC and MARC21) for "Mandatory if tag is used". 3. Normal, dependent on 2: Change the UNIMARC frameworks we ship to check *that* box for the things reverted in 1. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 24424] Advanced editor - interface hangs as "Loading" when given an invalid bib number
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 --- Comment #5 from Phil Ringnalda --- First step toward a warning is bug 36891. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Phil Ringnalda changed: What|Removed |Added Assignee|p...@chetcolibrary.org |koha-b...@lists.koha-commun ||ity.org --- Comment #2 from Phil Ringnalda --- The nice part is that it works, http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 returns a bib, http://127.0.0.1:8081/cgi-bin/koha/svc/bib/9 returns a 404. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 --- Comment #1 from Phil Ringnalda --- Created attachment 166858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166858=edit Bug 36891: Naive attempt to fix svc/bib to return 404 when bib number not found But of course it can't be simple. After just adding if ( defined $biblio ) and reindenting and tidying what I indented, I'm told that I made two more untidy lines. And there's a bad smell around the "if ( defined $record )" since I don't see how it could be false, because $biblio->metadata->record doesn't return undef. But maybe I'm missing something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36085] Protected Status should come with a permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36085 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #2 from David Cook --- Mmm that's an interesting one. My original vision for this was to have it manageable only be superlibrarians (or no web users at all even). It looks like Magnus thought about a permission for changing the protected flag in comment 14 of bug 26170. The hard part about adding a permission is then who is allowed to set that permission? (Sort of a "who watches the watcher" scenario.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] New: Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Bug ID: 36891 Summary: Restore returning 404 from svc/bib when the bib number doesn't exist Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: p...@chetcolibrary.org Reporter: p...@chetcolibrary.org QA Contact: testo...@bugs.koha-community.org CC: m.de.r...@rijksmuseum.nl Prior to bug 29697, svc/bib used GetMarcBiblio which returned undef if the requested bib number didn't exist, and returned a 404 if the record was undefined. That was switched to using Koha::Biblios->find, which returns undef if the bib number doesn't exist, and then calling undef->metadata->record, which doesn't go well. The if (defined $record) just needs to move up a line and be if (defined $biblio) on the return from the call that actually does return undef. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #2 from Lucas Gass --- This patch sets the 'Pickup location' according to the DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was unsure how you'd set that to the item's home/holding branch when there are more than 1 holds being placed. I was thinking it would be nice that if you changed 'Pickup at' al the lower 'Pickup location' would also change to what you choose? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Lucas Gass changed: What|Removed |Added Patch complexity|--- |Trivial patch Severity|enhancement |normal CC||lu...@bywatersolutions.com Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 --- Comment #1 from Lucas Gass --- Created attachment 166857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166857=edit Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple items at once To test: 0. Make sure the DefaultHoldPickupLocation system preference is set to logged in library. 1. In the staff interface, search the catalog with a term that will return a couple of items (e.g. Shakespeare) 2. In the search results, select two or more results 3. Click Place hold 4. Search for a patron (e.g. Acevedo) --> "Pickup location" is empty and the staff member must select the library 5. APPLY PATCH and restart_all 6. Try again, the default should be set according to the DefaultHoldPickupLocation system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871 Lucas Gass changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36890] New: Add ability to limit purchase suggestion when fines are over a threshold
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36890 Bug ID: 36890 Summary: Add ability to limit purchase suggestion when fines are over a threshold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.sch...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org Libraries would like the ability to block users from suggesting if they have fines/fees above a threshold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #6 from David Nind --- Thanks Lucas! Just to confirm that it now works as expected for the staff interface and OPAC. David -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36589] Advanced cataloging - restore the correct height of the clipboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 --- Comment #4 from Phil Ringnalda --- Created attachment 166856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166856=edit Bug 36589: Advanced cataloging - restore the correct height of the clipboard A simple direct fix for the height of the advanced editor's clipboard, which is a that's currently cut down to the height of one thick line by CSS intended for non-multiple, non-sized selects with dropdown menus. Test plan: 1. Set the pref EnableAdvancedCatalogingEditor to Enable 2. Cataloging -> Advanced editor 3. Note the Clipboard is a single line tall 4. Apply patch, shift+reload Advanced editor 5. Note the Clipboard is ten lines tall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36589] Advanced cataloging - restore the correct height of the clipboard
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36589 Phil Ringnalda changed: What|Removed |Added Patch complexity|--- |Trivial patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #33 from Tomás Cohen Arazi --- (In reply to Jonathan Druart from comment #15) > I am still getting a lot of warnings Please check with my follow-up. There's a '23.11' and a 'main' version of the patch set. Besides the noise on the tests, this is a nightnmare on busy sites with some moderate ILL activity. as any action triggers many warnings per request that is displayed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #32 from Tomás Cohen Arazi --- Created attachment 166855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166855=edit Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #31 from Tomás Cohen Arazi --- Created attachment 166854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166854=edit Bug 34838: Tidy Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #30 from Tomás Cohen Arazi --- Created attachment 166853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166853=edit Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #29 from Tomás Cohen Arazi --- Created attachment 166852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166852=edit Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #28 from Tomás Cohen Arazi --- Created attachment 166851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166851=edit Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #27 from Tomás Cohen Arazi --- Created attachment 166850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166850=edit [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #26 from Tomás Cohen Arazi --- Created attachment 166849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166849=edit [23.11.x] Bug 34838: Tidy Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #25 from Tomás Cohen Arazi --- Created attachment 166848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166848=edit [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #24 from Tomás Cohen Arazi --- Created attachment 166847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166847=edit [23.11.x] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi changed: What|Removed |Added Attachment #166841|0 |1 is obsolete|| Attachment #166842|0 |1 is obsolete|| Attachment #166843|0 |1 is obsolete|| Attachment #166844|0 |1 is obsolete|| Attachment #166845|0 |1 is obsolete|| --- Comment #23 from Tomás Cohen Arazi --- Created attachment 166846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166846=edit [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] The ILL module generates a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com Summary|ILL tests generate a lot of |The ILL module generates a |"redefined" warnings|lot of "redefined" warnings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #22 from Tomás Cohen Arazi --- Created attachment 166845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166845=edit [23.11.x] Bug 34838: Use ->set to avoid method redefinition warnings This patch silences more warnings. To test 1. Be on 23.11.x 2. Apply the patches before this one 3. Run: $ ktd --shell k$ prove t/db_dependent/Illrequests.t => FAIL: Lots of warnings like this: Subroutine Koha::Illrequest::SUPER::status redefined at /kohadevbox/koha/Koha/Object.pm line 955. Subroutine Koha::Illrequest::SUPER::status_alias redefined at /kohadevbox/koha/Koha/Object.pm line 955. illrequestattributes is DEPRECATED in favor of extended_attributes at t/db_dependent/Illrequests.t line 1071. 4. Apply this patch 5. Repeat 3 => SUCCESS: No more warnings! 6. Sign off :-D Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #21 from Tomás Cohen Arazi --- Created attachment 166844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166844=edit [23.11.x] Bug 34838: Tidy Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #20 from Tomás Cohen Arazi --- Created attachment 166843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166843=edit [23.11.x] Bug 34838: Only check for status in status graph if request has a status This check is required because when the existing_statuses method checks for the existing status_alias, it'll leave out the status from the query, so the status will be NULL for those particular query results when calling strings_map, throwing a warning Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36870] Don't ask for pickup location when there is only one library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36870 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 --- Comment #19 from Tomás Cohen Arazi --- Created attachment 166842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166842=edit [23.11.x] Bug 34838: Only call strings_map if status_alias is not undef in status_alias cycle Because its highly likely that at least one request will have status_alias null in the database, the select MAX query will always return at least one result with NULL status_alias, throwing a warning, so we skip that Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi changed: What|Removed |Added Attachment #156217|0 |1 is obsolete|| Attachment #156218|0 |1 is obsolete|| Attachment #156219|0 |1 is obsolete|| Attachment #156220|0 |1 is obsolete|| --- Comment #18 from Tomás Cohen Arazi --- Created attachment 166841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166841=edit [23.11.x] Bug 34838: Replace SUPER::AUTOLOAD with get_column I'm not 100% happy with this but I'm out of ideas. I think the problem warning happens because there is no method status or status_alias directly defined in Object.pm so it tries to define it, but it has already been defined by AUTOLOAD previously. Test plan: prove t/db_dependent/Koha/Illbackend.t Signed-off-by: Jonathan Druart Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34838] ILL tests generate a lot of "redefined" warnings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34838 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36271] Bookings should respect circulation rules for max loan periods
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36271 --- Comment #15 from David Nind --- Dependent bug 35906 no longer applies 8-(.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #5 from Lucas Gass --- Created attachment 166840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166840=edit Bug 36862: Remove call to selRecord() on the OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 Lucas Gass changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 35906] Add bookable option on itemtypes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35906 David Nind changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||da...@davidnind.com --- Comment #44 from David Nind --- The patch no longer applies 8-(... git bz apply 35906 Bug 35906 - Add bookable option on itemtypes 164579 - Bug 35906: Add bookable option on itemtype 164580 - Bug 35906: Add unit test 164581 - Bug 35906: Remove preference and add override handling 164582 - Bug 35906: Schema dump 164583 - Bug 35906: (QA follow-up) Fix item-type schema 165437 - Bug 35906: (follow-up) rebased it Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 35906: Add bookable option on itemtype Using index info to reconstruct a base tree... M Koha/Items.pm M Koha/REST/V1/Biblios.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/REST/V1/Biblios.pm CONFLICT (content): Merge conflict in Koha/REST/V1/Biblios.pm Auto-merging Koha/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 35906: Add bookable option on itemtype -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36862] Cart window becomes unresponsive if checkboxes are manipulated in a certain order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36862 --- Comment #4 from Lucas Gass --- (In reply to David Nind from comment #3) > For me, the change works fine in the staff interface, but not in the OPAC. > That is, still experience the described issue. > > Tested in Firefox Developer Edition and Chromium. Thanks David, I didn't do the OPAC. But I have a patch incoming. On the OPAC, when using #CheckAll or #CheckNone there is also a call to selRecord(). I don't see why we need to do so if all we are doing is checking/unchecking the checkboxes! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #67 from Andrew Fuerste-Henry --- (In reply to Katrin Fischer from comment #66) > Hi Andrew, thanks for doing that - asking around. I still hope that the > sorting is a solvable issue. Strong agree, I'm very much in favor of this feature and would love to see it move forward! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34189] Provide warning for protected fields when overlaying record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34189 Marie-Luce Laflamme changed: What|Removed |Added CC||marie-luce.laflamme@inlibro ||.com --- Comment #1 from Marie-Luce Laflamme --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #66 from Katrin Fischer --- (In reply to Andrew Fuerste-Henry from comment #65) > After soliciting some more opinions, I am marking this FQA for the search > results issue. Inaccurate sorting of patrons by name will cause too much > confusion for thi to be usable. Hi Andrew, thanks for doing that - asking around. I still hope that the sorting is a solvable issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36889] Unable to send a password reset for staff at my branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36889 Christopher Brannon changed: What|Removed |Added Version|unspecified |23.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36889] New: Unable to send a password reset for staff at my branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36889 Bug ID: 36889 Summary: Unable to send a password reset for staff at my branch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: cbran...@cdalibrary.org QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Send password reset is not in the menu if the patron is a staff member from the same branch I am logged in as. I can reset the password for staff from other branches, just not my own. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts might be failing if run too slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012 --- Comment #26 from Katrin Fischer --- Thanks Matt for looking into this! I'd really love to see the random failures reduced. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36888] Have better indicators for when a hold is placed successfully
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36888 Katrin Fischer changed: What|Removed |Added Summary|Have a a better indicators |Have better indicators for |when a hold is placed |when a hold is placed |successfully|successfully -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36677] Unable to access the dropdown options for list and account details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36677 Katrin Fischer changed: What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #10 from Katrin Fischer --- (In reply to Ruth Elliott from comment #9) > Hello The issue has been resolved so we added a dropdown code in our html > customizations that was using the same class name declared in in koha for > the list dropdown. Oh that's a tricky one. Thanks for the feedback! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36876] In table settings words are split in two and some of them cannot be translated properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Roman Dolny changed: What|Removed |Added Attachment #166820|0 |1 is obsolete|| --- Comment #3 from Roman Dolny --- Created attachment 166839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166839=edit Bug 36876: Correct s around translatable strings in table settings This patch corrects the way translatable strings are handled in the table settings template. The switch to Bootstrap WRAPPERs for the accordion widget included several errors. To test, apply the patch and go to Administration -> Table settings. - Confirm that the sections expand and collapse correctly. - Test the translation process with a language, e.g. fr-FR: - In KTD, run: gulp po:update --lang fr-FR - Check fr-FR-staff-prog.po for the line referring to koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt:298 - It should show the whole string "Interlibrary loans" Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36876] In table settings words are split in two and some of them cannot be translated properly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36876 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 26170] Add protected status for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 Emily Lamancusa changed: What|Removed |Added Blocks||36085 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36085 [Bug 36085] Protected Status should come with a permission -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36085] Protected Status should come with a permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36085 Emily Lamancusa changed: What|Removed |Added CC||emily.lamancusa@montgomeryc ||ountymd.gov Depends on||26170 --- Comment #1 from Emily Lamancusa --- +1 for adding a permission! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 [Bug 26170] Add protected status for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Add ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny changed: What|Removed |Added Attachment #166830|0 |1 is obsolete|| --- Comment #6 from Roman Dolny --- Created attachment 166838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166838=edit Bug 36798: Unit tests Added unit tests. Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Add ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny changed: What|Removed |Added Attachment #166829|0 |1 is obsolete|| --- Comment #5 from Roman Dolny --- Created attachment 166837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166837=edit Bug 36798: Add ability to search across all ISBNs using the ISBN-search With the Bug 36574 we added a new ES search field isbn-all which makes it possible to find records with the content of the subfield 020 $z (invalid/cancelled ISBN) in general search (by keyword). But still, when performing a search with ISBN-search these records will not be found. Since some libraries deliberately want to find records with only 020 $a with ISBN-search, a system preference would be needed here to be able to customize the ISBN search. The same for ISSNs, with one system preference. Test plan: == (ISBN) -- 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISBN search from Advanced search for 9780141930848. You should get no results. In the general search input field (on the main page) try a search nb:9780141930848 and/or isbn:9780141930848 - you should get no results. 3. Apply the patch, restart_all. 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 9780141930848 in 020 $z). (ISSN) -- 0. Return to main, delete the bug branch, reset_all == start from fresh. 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISSN search from Advanced search for 1089-6891. You should get no results. In the general search input field (on the main page) try a search ns:1089-6891 and/or issn:1089-6891 - you should get no results. 3. Apply the patch, restart_all. If you have had to apply also the bug 36727, reindex ES with: koha-elasticsearch --rebuild -r -d kohadev (there is a modification of mappings.yaml) 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 1089-6891 in 022 $y). Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Add ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny changed: What|Removed |Added Attachment #166828|0 |1 is obsolete|| --- Comment #4 from Roman Dolny --- Created attachment 166836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166836=edit Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system preference This patch adds a new system preference SearchCancelAndInvalidISBNandISSN: whether to search for cancelled / invalid forms of ISBN/ISSN when performing ISBN/ISSN search. (By default, with ES, only valid forms, i.e. 020 $a / 022 $a are considered). Signed-off-by: Roman Dolny -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Add ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Roman Dolny changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33312] Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 --- Comment #3 from Laura O'Neil --- Yes please! Being able to configure the circ/fine rules table would be so nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33312] Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Laura O'Neil changed: What|Removed |Added CC||la...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33312] Add circulation and fines rules table from smart-rules.pl to column settings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33312 Catrina Berka changed: What|Removed |Added CC||catr...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 --- Comment #3 from Benjamin Daeuber --- We'd also need to consider what happens if the user doesn't have an email. I don't like the idea of rolling these into print notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36888] New: Have a a better indicators when a hold is placed successfully
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36888 Bug ID: 36888 Summary: Have a a better indicators when a hold is placed successfully Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: lu...@bywatersolutions.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com Currenty if you place a hold on the staff side ( reserve/request.pl?biblionumber=32 ) it can be hard to know if the hold was successfully placed or not. There is the 'Existing holds' table but that can be confusing, especially if there are a lot of holds. It would be nice to see an alert box indicating that the hold was successfully place and for whom. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Benjamin Daeuber changed: What|Removed |Added CC||bdaeu...@cityoffargo.com --- Comment #2 from Benjamin Daeuber --- What does the workflow look like here? As an example, right now we have a BOR_NOTE that puts a message on the patron card that they brought back an item missing a disc. So the staff person picks the note from the dropdown that says "Item mixup at :" then they type in the title of the item. Would your suggestion keep that workflow, or would it behave differently? Also, presumably this would allow us to send an email at the same time, so we can let the patron know they need to get us the disc. Would it be the same note, or would different "transport types" (if that's the term for a staff note), generate different messages like notices do now (so we could send a more detailed message to the user)? My other concern is ensuring that no accidental emails are sent. I never want someone to accidentally click "email" on a message that should be staff only. The nice thing about the current setup is that it doesn't allow accidental OPAC notes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Add ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek changed: What|Removed |Added Summary|Ability to search across|Add ability to search |all ISBNs using the |across all ISBNs using the |ISBN-search |ISBN-search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |janus...@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 Andrew Fuerste-Henry changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #65 from Andrew Fuerste-Henry --- After soliciting some more opinions, I am marking this FQA for the search results issue. Inaccurate sorting of patrons by name will cause too much confusion for thi to be usable. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Cheryl changed: What|Removed |Added CC||clack...@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 --- Comment #1 from Caroline Cyr La Rose --- Is this a duplicate of Bug 36717 or a different thing? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36717 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Caroline Cyr La Rose changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=36887 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36868] Add ability to automatically empty cart after placing holds ( staff interface and OPAC )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 Lucas Gass changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36868] Add ability to automatically empty cart after placing holds ( staff interface and OPAC )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #2 from Lucas Gass --- Created attachment 166835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166835=edit Bug 36868: Logic for staff interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36868] Add ability to automatically empty cart after placing holds ( staff interface and OPAC )
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36868 --- Comment #1 from Lucas Gass --- Created attachment 166834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166834=edit Bug 36868: Add system preference AutoDeleteFromCartWhenHoldPlaced -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36012] ERM/Agreements_spec.ts might be failing if run too slow
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36012
--- Comment #25 from Matt Blenkinsop ---
I've been looking at the cypress failures today using CPULimit with the limit
set to 25%. When doing that in KTD I can get random failures quite easily.
I've tried various changes in the test files to try and prevent these failures
but nothing seems to be working. It seems to be CPU related and the tests
lagging beyond the timeout. We don't want to keep increasing the timeouts but
we could try adding retries to give the tests more chances at passing?
When I run ```yarn cypress run --spec
t/cypress/integration/InfiniteScrollSelect_spec.ts --config video=false
retries={runMode:3,openMode:0}``` I get a big reduction in the random failures
even on 25% CPU
Not a complete fix but it might improve things slightly
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize changed: What|Removed |Added Blocks|36887 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Martin Renvoize changed: What|Removed |Added Depends on|32986 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 [Bug 32986] Add ability to generate custom slips for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Martin Renvoize changed: What|Removed |Added Blocks|36887 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Martin Renvoize changed: What|Removed |Added Depends on|36717 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 32986] Add ability to generate custom slips for patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 Martin Renvoize changed: What|Removed |Added Blocks||36887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 Martin Renvoize changed: What|Removed |Added Blocks||36887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29393] Ability to send emails from patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Martin Renvoize changed: What|Removed |Added Blocks||36887 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 [Bug 36887] Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36887] New: Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36887 Bug ID: 36887 Summary: Migrate "Authorized Values (BOR_NOTES)" into "Patrons (custom message)" in Notices Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvo...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: caroline.cyr-la-r...@inlibro.com, katrin.fisc...@bsz-bw.de, testo...@bugs.koha-community.org Depends on: 29393, 36717, 32986 With the introduction of custom email messages in Bug 29393, we discussed (https://chat.koha-community.org/koha-community/pl/ixoy58im47dhpr4gmwtn9sdbjw) the opportunity to merge the "Patrons (custom slip)" notice type introduced in Bug 32986 and the new "Patrons (custom message)" notice type. We could also do away with the BOR_NOTES authorized value that is currently used for the non-email notes/messages and instead combine them into the above and use a checkbox for display options (staff or opac & email) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32986 [Bug 32986] Add ability to generate custom slips for patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36717 [Bug 36717] Merge "Patrons (custom slip)" and "Patrons (custom message)" in Notices -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36761] Add ability to specify patron attribute as a boolean
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36761 Pedro Amorim changed: What|Removed |Added Resolution|--- |INVALID Status|NEW |RESOLVED URL||https://github.com/PTFS-Eur ||ope/koha/tree/bug_36761 --- Comment #1 from Pedro Amorim --- I'm dropping this, the use case I need can effectively be satisfied by an attribute type of authorized value linked to the YES_NO list. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36677] Unable to access the dropdown options for list and account details
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36677 --- Comment #9 from Ruth Elliott --- Hello The issue has been resolved so we added a dropdown code in our html customizations that was using the same class name declared in in koha for the list dropdown. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36886] Allow Patron messages to be restricted to predetermined messages only. No free text messages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36886 --- Comment #1 from Martin Renvoize --- We'll want to cover both browser-based messages and the newer email messages functionality here I think too. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 29393] Ability to send emails from patron details page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 Martin Renvoize changed: What|Removed |Added Blocks||36886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36886 [Bug 36886] Allow Patron messages to be restricted to predetermined messages only. No free text messages. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36886] Allow Patron messages to be restricted to predetermined messages only. No free text messages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36886 Martin Renvoize changed: What|Removed |Added Depends on||29393 CC||martin.renvoize@ptfs-europe ||.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29393 [Bug 29393] Ability to send emails from patron details page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36885] Missing tooltip on budget planning page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #2 from Owen Leonard --- It's a bug in that the feature is half-implemented, an enhancement in that nothing is broken in the current state. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36885] Missing tooltip on budget planning page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 --- Comment #1 from Owen Leonard --- Created attachment 166831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166831=edit Bug 36885: Fix Bootstrap tooltip on budget planning page This patch finishes the process of adding a Bootstrap tooltip to the listing of funds which are locked. To test, apply the patch and go to Administration -> Budgets. - Edit a budget and make it locked: Check the "Lock budget" checkbox and save. - View the budget you locked. - From the toolbar, click Planning -> Plan by months. - In the table of funds, hover your mouse over a fund. - You should see a Bootstrap-styled tooltip, "Fund locked." -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36885] Missing tooltip on budget planning page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek changed: What|Removed |Added Change sponsored?|--- |Sponsored CC||alei...@catalyst.net.nz, ||alexbuck...@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #3 from Janusz Kaczmarek --- Created attachment 166830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166830=edit Bug 36798: Unit tests Added unit tests. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #2 from Janusz Kaczmarek --- Created attachment 166829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166829=edit Bug 36798: Add ability to search across all ISBNs using the ISBN-search With the Bug 36574 we added a new ES search field isbn-all which makes it possible to find records with the content of the subfield 020 $z (invalid/cancelled ISBN) in general search (by keyword). But still, when performing a search with ISBN-search these records will not be found. Since some libraries deliberately want to find records with only 020 $a with ISBN-search, a system preference would be needed here to be able to customize the ISBN search. The same for ISSNs, with one system preference. Test plan: == (ISBN) -- 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISBN search from Advanced search for 9780141930848. You should get no results. In the general search input field (on the main page) try a search nb:9780141930848 and/or isbn:9780141930848 - you should get no results. 3. Apply the patch, restart_all. 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 9780141930848 in 020 $z). (ISSN) -- 0. Return to main, delete the bug branch, reset_all == start from fresh. 1. Have the ktd with with ES enabled. 2. With standard ktd test data, try to perform a ISSN search from Advanced search for 1089-6891. You should get no results. In the general search input field (on the main page) try a search ns:1089-6891 and/or issn:1089-6891 - you should get no results. 3. Apply the patch, restart_all. If you have had to apply also the bug 36727, reindex ES with: koha-elasticsearch --rebuild -r -d kohadev (there is a modification of mappings.yaml) 4. Repeat p. 2 -- you should still get no results. 5. Enable SearchCancelAndInvalidISBNandISSN syspref. 6. Repeat p. 2 -- now you should get one record (having 1089-6891 in 022 $y). Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 --- Comment #1 from Janusz Kaczmarek --- Created attachment 166828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166828=edit Bug 36798: Add 'SearchCancelAndInvalidISBNandISSN' system preference This patch adds a new system preference SearchCancelAndInvalidISBNandISSN: whether to search for cancelled / invalid forms of ISBN/ISSN when performing ISBN/ISSN search. (By default, with ES, only valid forms, i.e. 020 $a / 022 $a are considered). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36798] Ability to search across all ISBNs using the ISBN-search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36798 Janusz Kaczmarek changed: What|Removed |Added Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36886] New: Allow Patron messages to be restricted to predetermined messages only. No free text messages.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36886 Bug ID: 36886 Summary: Allow Patron messages to be restricted to predetermined messages only. No free text messages. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.a...@ptfs-europe.com QA Contact: testo...@bugs.koha-community.org CC: gmcha...@gmail.com, kyle.m.h...@gmail.com Staff users can currently add patron messages to a patron account choosing from a pre-determined set of messages or creating a free text message. They can also choose whether the message shows to the Patron in the OPAC as well as staff, or just to staff. It should be possible to disable the addition of free text messages. There should be a choice between whether the free text message is allowable on the OPAC messages or just the staff side or not at all. This should also be permission based so that certain library staff could be given the permission to use free text messages and certain not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 Owen Leonard changed: What|Removed |Added Blocks||36885 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 [Bug 36885] Missing tooltip on budget planning page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36885] New: Missing tooltip on budget planning page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36885 Bug ID: 36885 Summary: Missing tooltip on budget planning page Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleon...@myacpl.org Reporter: oleon...@myacpl.org QA Contact: testo...@bugs.koha-community.org Depends on: 34404 It looks like I got halfway to adding a Bootstrap tooltip to the budget planning template for funds which are locked. I added the JS trigger but didn't change the markup to match. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34404 [Bug 34404] Inconsistencies in Budgets and funds page titles, breadcrumbs, and header -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 28633] Add a preferred_name field and an effective_name method to patrons
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28633 --- Comment #64 from Andrew Fuerste-Henry --- We should not copy preferred name when duplicating a patron, just as we do not copy over first name. I'm very much tempted to Fail QA on this due to the search results sorting issue. When looking at a mis-sort of three patrons with the name last name it seems like a manageable speed bump, but I'm concerned about the impact on searching within a larger patron base. If any patron with a preferred name is inherently harder to find than a patron without a preferred name, then patrons with preferred names present a burden that staff may come to resent. I may be overthinking this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
