[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #72 from Victor Grousset/tuxayo --- > Instead of disabling overlay rules to change the record - I updated the MARC > modificatoin template for the 300 to set value 'FAILFAILFAILFAIL' > After applying, updating, restarting all, I batch modified and the 300 was > still updated. Did the same, 300$a wasn't replaced with 'FAILFAILFAILFAIL'. Any more details to reproduce? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #71 from Victor Grousset/tuxayo --- UI: The MARCOverlayRules preference is not set, don't forget to enable it for rules to take effect. No, wait, I just missed that. Retesting. (good, bisecting that would have been tedious) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #70 from Victor Grousset/tuxayo --- > 6. 300$a should have been catified (expected, that's the bug) > 7. 245$a is preserved There has been something up in main since last time I tested this. So, without patches, both subfields are changed by the batch record modification. I checked that the overlay rules are the same with a diff between the test plan a selecting the rules tables in the page. Same with the patches, overlay is not protecting either fields. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Nick Clemens (kidclamp) changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #69 from Nick Clemens (kidclamp) --- I didn't get the expected results (mostly) following the test plan Instead of disabling overlay rules to change the record - I updated the MARC modificatoin template for the 300 to set value 'FAILFAILFAILFAIL' After applying, updating, restarting all, I batch modified and the 300 was still updated. My rules match what Victor posts after the update -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Katrin Fischer changed: What|Removed |Added Keywords||RM_priority --- Comment #68 from Katrin Fischer --- Bug was filed a year ago and poses a real risk of data loss. Can we move this forward please? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Katrin Fischer changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #67 from David Gustafsson --- Thanks, no problem! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how marc overlay rules are |how marc overlay rules are |evaluated. Before the |evaluated. |change rules with filter| |set to '*' (wildcard) where |Before the |only applied when no other |change rules with filter |rules had been defined for |set to '*' (wildcard) where |a specific filter value,|only applied when no other |regardless of if any of the |rules had been defined for |rules with that filter |a specific filter value, |value matched or not. With |regardless of if any of the |this change we fallback to |rules with that filter |the wildcard filter rules |value matched or not. |even though rules with a| |matching filter value do|With |exists, if no rule for that |this change we fallback to |filter value matches. This |the wildcard filter rules |resolves the issue of |even though rules with a |having to repeat the same |matching filter value do |default rules for each |exists, if no rule for that |filter value rule set. If |filter value matches. This |for some filter value the |resolves the issue of |wildcard filter rules |having to repeat the same |should be overridden, a |default rules for each |wildcard tag rule for that |filter value rule set. If |filter value can be defined |for some filter value the |which will have higher |wildcard filter rules |precedence and override all |should be overridden, a |the filter wildcard rules. |wildcard tag rule for that |In summary, the rules will |filter value can be defined |applied as follows: - A |which will have higher |matching rule is looked for |precedence and override all |based on context (module|the filter wildcard rules. |and filter value), if | |multiple contexts matches |In summary, the rules will |rules for the module with |applied as follows: |highest priority are used. | |The module priority is |- A |(from highest to lowest)|matching rule is looked for |"User name", "Patron|based on context (module |category" and "Source". - |and filter value), if |If no matching rule is |multiple contexts matches |found, we fallback to the |rules for the module with |wildcard filter rules of|highest priority are used. |the current context module. |The module priority is |For Koha installations |(from highest to lowest) |where marc overlay rules is |"User name", "Patron |in use a database migration |category" and "Source". |will run that creates new | |rules if necessary to |- |preserve the current|If no matching rule is |behavior, so no user action |found, we fallback to the |needs to be taken in order |wildcard filter rules of |to correct for this change. |the current context module. || ||For Koha installations ||where marc overlay rules is ||in use a database migration ||will run that creates new ||rules if necessary to ||preserve the current ||behavior, so no user action ||needs to be taken in order ||to correct for this change. --- Comment #66 from Victor Grousset/tuxayo --- Oh sorry, no idea what happened! :o I didn't even do another real change that day on the ticket. The "Removed" column for my action on the 2024-03-12 in the ticket history makes absolutely no sense
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #65 from David Gustafsson --- Hi! No problem. I think Victor Grousset/tuxayo removed the release note, perhaps by mistake, but now re-added it again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Text to go in the||This enhancement changes release notes||how marc overlay rules are ||evaluated. Before the ||change rules with filter ||set to '*' (wildcard) where ||only applied when no other ||rules had been defined for ||a specific filter value, ||regardless of if any of the ||rules with that filter ||value matched or not. With ||this change we fallback to ||the wildcard filter rules ||even though rules with a ||matching filter value do ||exists, if no rule for that ||filter value matches. This ||resolves the issue of ||having to repeat the same ||default rules for each ||filter value rule set. If ||for some filter value the ||wildcard filter rules ||should be overridden, a ||wildcard tag rule for that ||filter value can be defined ||which will have higher ||precedence and override all ||the filter wildcard rules. ||In summary, the rules will ||applied as follows: - A ||matching rule is looked for ||based on context (module ||and filter value), if ||multiple contexts matches ||rules for the module with ||highest priority are used. ||The module priority is ||(from highest to lowest) ||"User name", "Patron ||category" and "Source". - ||If no matching rule is ||found, we fallback to the ||wildcard filter rules of ||the current context module. ||For Koha installations ||where marc overlay rules is ||in use a database migration ||will run that creates new ||rules if necessary to ||preserve the current ||behavior, so no user action ||needs to be taken in order ||to correct for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #64 from Katrin Fischer --- (In reply to David Gustafsson from comment #63) > @Victor Grousset/tuxayo > > Ok, thanks for the feedback and test plan. I now submitted a release note. > It's not that easy to explain the change in clear terms, so suggestions are > welcome if there is room for improvements. Hi David, sorry if my comments where not clear enough and thanks for your perseverance. With release-notes-needed or "add to release notes" we usually mean the bugzilla field "Text to go in the release notes:". This is used when the release notes are auto generated. Not sure if yours got lost somehow as the field is now empty, can you please double check? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Text to go in the|This enhancement changes| release notes|how marc overlay rules are | |evaluated. Before the | |change rules with filter| |set to '*' (wildcard) where | |only applied when no other | |rules had been defined for | |a specific filter value,| |regardless of if any of the | |rules with that filter | |value matched or not. | | | |With| |this change we fallback to | |the wildcard filter rules | |even though rules with a| |matching filter value do| |exists, if no rule for that | |filter value matches. This | |resolves the issue of | |having to repeat the same | |default rules for each | |filter value rule set. If | |for some filter value the | |wildcard filter rules | |should be overridden, a | |wildcard tag rule for that | |filter value can be defined | |which will have higher | |precedence and override all | |the filter wildcard rules. | || |In summary, the rules will | |applied as follows: | | | |- A | |matching rule is looked for | |based on context (module| |and filter value), if | |multiple contexts matches | |rules for the module with | |highest priority are used. | |The module priority is | |(from highest to lowest)| |"User name", "Patron| |category" and "Source". | | | |- | |If no matching rule is | |found, we fallback to the | |wildcard filter rules of| |the current context module. | | | |For Koha installations | |where marc overlay rules is | |in use a database migration | |will run that creates new | |rules if necessary to | |preserve the current| |behavior, so no user action | |needs to be taken in order | |to correct for this change. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Miranda Nero changed: What|Removed |Added CC||mn...@oslri.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how marc overlay rules are |how marc overlay rules are |evaluated. Before the |evaluated. Before the |change rules with filter|change rules with filter |set to '*' (wildcard) where |set to '*' (wildcard) where |only applied when no other |only applied when no other |rules had been defined for |rules had been defined for |a specific filter value,|a specific filter value, |regardless of if any of the |regardless of if any of the |rules with that filter |rules with that filter |value matched or not. |value matched or not. | | |With|With |this change we fallback to |this change we fallback to |the wildcard filter rules |the wildcard filter rules |even though rules with a|even though rules with a |matching filter value do|matching filter value do |exists, if no rule for that |exists, if no rule for that |filter value matches. This |filter value matches. This |resolves the issue of |resolves the issue of |having to repeat the same |having to repeat the same |default rules for each |default rules for each |filter value rule set. If |filter value rule set. If |for some filter value the |for some filter value the |wildcard filter rules |wildcard filter rules |should be overridden, a |should be overridden, a |wildcard tag rule for that |wildcard tag rule for that |filter value can be defined |filter value can be defined |which will have higher |which will have higher |precedence and override all |precedence and override all |the filter wildcard rules. |the filter wildcard rules. || |In summary, the rules will |In summary, the rules will |applied as follows: |applied as follows: | | |- A |- A |matching rule is looked for |matching rule is looked for |based on context (module|based on context (module |and filter value), if |and filter value), if |multiple contexts matches |multiple contexts matches |rules for the module with |rules for the module with |highest priority are used. |highest priority are used. |The module priority is |The module priority is |(from highest to lowest)|(from highest to lowest) |"User name", "Patron|"User name", "Patron |category" and "Source" |category" and "Source". | | |- |- |If no matching rule is |If no matching rule is |found, we fallback to the |found, we fallback to the |wildcard filter rules of|wildcard filter rules of |the current context. |the current context module. | | |For |For Koha installations |Koha installations where|where marc overlay rules is |marc overlay rules is in|in use a database migration |use a database migration|will run that creates new |will run that creates new |rules if necessary to |rules if necessary to |preserve the current |preserve the current|behavior, so no user action |behavior, so no user action |needs to be taken in order |needs to be taken in order |to correct for this change. |to correct for this change. | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how marc overlay rules are |how marc overlay rules are |evaluated. Before the |evaluated. Before the |change rules with filter|change rules with filter |set to '*' (wildcard) where |set to '*' (wildcard) where |only applied when no other |only applied when no other |rules had been defined for |rules had been defined for |a specific filter value,|a specific filter value, |regardless of if any of the |regardless of if any of the |rules with that filter |rules with that filter |value matched or not. |value matched or not. | | |With|With |this change we fallback to |this change we fallback to |the wildcard filter rules |the wildcard filter rules |even though rules with a|even though rules with a |matching filter value do|matching filter value do |exists, if no rule for that |exists, if no rule for that |filter value matches. This |filter value matches. This |resolves the issue of |resolves the issue of |having to repeat the same |having to repeat the same |default rules for each |default rules for each |filter value rule set. If |filter value rule set. If |for some filter value the |for some filter value the |wildcard filter rules |wildcard filter rules |should be overridden, a |should be overridden, a |wildcard tag rule for that |wildcard tag rule for that |filter value can be defined |filter value can be defined |which will have higher |which will have higher |precedence and override all |precedence and override all |the filter wildcard rules. |the filter wildcard rules. || |In summary, the rules will |In summary, the rules will |applied as follows: |applied as follows: | | |- A |- A |matching rule is looked for |matching rule is looked for |based on context (module|based on context (module |and filter value), if |and filter value), if |multiple contexts matches |multiple contexts matches |rules for the module with |rules for the module with |highest priority are used. |highest priority are used. |The module priority is |The module priority is |(from highest to lowest)|(from highest to lowest) |"User name", "Patron|"User name", "Patron |category" and "Source" |category" and "Source" | | |- |- |If no matching rule is |If no matching rule is |found, we fallback to the |found, we fallback to the |wildcard filter rules of|wildcard filter rules of |the current context.|the current context. || ||For ||Koha installations where ||marc overlay rules is in ||use a database migration ||will run that creates new ||rules if necessary to ||preserve the current ||behavior, so no user action ||needs to be taken in order ||to correct for this change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git :
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #63 from David Gustafsson --- @Victor Grousset/tuxayo Ok, thanks for the feedback and test plan. I now submitted a release note. It's not that easy to explain the change in clear terms, so suggestions are welcome if there is room for improvements. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Patch complexity|--- |Medium patch Change sponsored?|--- |Sponsored Text to go in the||This enhancement changes release notes||how marc overlay rules are ||evaluated. Before the ||change rules with filter ||set to '*' (wildcard) where ||only applied when no other ||rules had been defined for ||a specific filter value, ||regardless of if any of the ||rules with that filter ||value matched or not. || ||With ||this change we fallback to ||the wildcard filter rules ||even though rules with a ||matching filter value do ||exists, if no rule for that ||filter value matches. This ||resolves the issue of ||having to repeat the same ||default rules for each ||filter value rule set. If ||for some filter value the ||wildcard filter rules ||should be overridden, a ||wildcard tag rule for that ||filter value can be defined ||which will have higher ||precedence and override all ||the filter wildcard rules. || ||In summary, the rules will ||applied as follows: || ||- A ||matching rule is looked for ||based on context (module ||and filter value), if ||multiple contexts matches ||rules for the module with ||highest priority are used. ||The module priority is ||(from highest to lowest) ||"User name", "Patron ||category" and "Source" || ||- ||If no matching rule is ||found, we fallback to the ||wildcard filter rules of ||the current context. Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #62 from Victor Grousset/tuxayo --- It works :) -- @QA here is an example of the changes from the DB upgrade on the data used in test plan: ++-++--+-++++ | id | tag | module | filter | add | append | remove | delete | ++-++--+-++++ | 2 | 245 | source | z3950| 0 | 0 | 0 | 0 | | 3 | 300 | source | *| 0 | 0 | 0 | 0 | | 4 | 245 | source | batchmod | 0 | 0 | 0 | 0 | ++-++--+-++++ ↓ ++-++--+-++++ | id | tag | module | filter | add | append | remove | delete | ++-++--+-++++ | 2 | 245 | source | z3950| 0 | 0 | 0 | 0 | | 3 | 300 | source | *| 0 | 0 | 0 | 0 | | 4 | 245 | source | batchmod | 0 | 0 | 0 | 0 | | 12 | * | source | z3950| 1 | 1 | 1 | 1 | | 13 | * | source | batchmod | 1 | 1 | 1 | 1 | ++-++--+-++++ --- @David G. to address Comment 28 's point 3 (release notes) you can look at latest release announcement: https://koha-community.org/koha-23-11-released/ Some tickets have grey boxes with text. That's from the "Text to go in the release notes" field here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162805|0 |1 is obsolete|| --- Comment #61 from Victor Grousset/tuxayo --- Created attachment 162940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162940=edit Bug 33268: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162804|0 |1 is obsolete|| --- Comment #60 from Victor Grousset/tuxayo --- Created attachment 162939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162939=edit Bug 33268: If rules exists add rules to preserve current behavior Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162803|0 |1 is obsolete|| --- Comment #59 from Victor Grousset/tuxayo --- Created attachment 162938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162938=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1. Administration => record overlay rules 2. Add this: Module Filter Tag Preset Added Appended Removed Deleted Source Z39.50 245 Protect Skip Skip SkipSkip Source * 300 Protect Skip Skip SkipSkip Source Batch record modification 245 Protect Skip Skip SkipSkip 3. Add MARC modification templates: Update existing or add new field 245$a with value CATSCATSCATSCATS Update existing or add new field 300$a with value CATSCATSCATSCATS 4. Find a record that has those fields (likely any record would) 5. Use batch record modification on the record 6. 300$a should have been catified (expected, that's the bug) 7. 245$a is preserved 8. Change the value of the 300$a to something else. Temporarly disable MARCOverlayRules to be able to do so. And reenable it. 9. Apply the patch, restart services 10. Use batch record modification on the record 11. 300$a should be preserved, cat protection should have worked 12. Run tests: prove t/db_dependent/Biblio/MarcOverlayRules.t 13. Celebrate! :D Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162802|0 |1 is obsolete|| --- Comment #58 from Victor Grousset/tuxayo --- Created attachment 162937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162937=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162801|0 |1 is obsolete|| --- Comment #57 from Victor Grousset/tuxayo --- Created attachment 162936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162936=edit Bug 33268: Add tests Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #56 from Victor Grousset/tuxayo --- (In reply to David Gustafsson from comment #55) > Yes, exactly. I retried and it works!!! :D I might have messed something because I should have been blocked at step: > 8. Change the values of the two subfields to something else Because the * overlay rules also include the editor. And back then I was able to change the values with the editor and now as expected, I can't. So likely had mess the rules. (You likely hit that too with my bogus test plan and that was an hint that I did something wrong) Anyway, I'm fixing the test plan and putting it in the patch commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268
--- Comment #55 from David Gustafsson ---
Yes, exactly. You could try this script (run with koha-shell -c
"perl ":
use Koha::MarcOverlayRules;
use Data::Dumper;
my $rules = Koha::MarcOverlayRules->context_rules({ source => 'batchmod' });
print Dumper($rules);
And review the resulting rule-set. Could be useful for debugging.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #54 from Victor Grousset/tuxayo --- > I'm not able to reproduce your test case, for me it seems to work. > [...] > Works for me also with the latest version of the patch So you followed the steps and at the 11th you got the subfield protected as expected? :D (vs at the 6th were it got changed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #53 from David Gustafsson --- Works for me also with the latest version of the patch, hope I'm not missing something, but setting back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #52 from David Gustafsson --- About the tests there is no difference testing manually vs the test cases with the exception if there is an incorrect overlay_context parameter for ModBiblio somewhere, and that has already been manually testing and would also probably have been discovered in production if where the case. Of course there could also be some testing scenario not covered by the tests (and most should be), but in that case we should just add that test in the test suite instead. I'm not able to reproduce your test case, for me it seems to work. Tried both with the same rules, and some different permutations. I will try again with your version of the patch. Also made a script to print out the resulting rule-set, and it produces the expected result. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #51 from Victor Grousset/tuxayo --- I was a bit too quick to signoff the patches. That indeed doesn't look like a change that can only have automated tests (thanks for these though) without some basic manual testing. So I tried something based on comment 0 1. Administration => record overlay rules 2. Add this: Module Filter Tag Preset Added Appended Removed Deleted Source Z39.50 245 Protect Skip Skip SkipSkip Source * 300 Protect Skip Skip SkipSkip Source Batch record modification 245 Protect Skip Skip SkipSkip 3. Add MARC modification templates: Update existing or add new field 245$a with value CATSCATSCATSCATS Update existing or add new field 300$a with value CATSCATSCATSCATS 4. Find a record that has those field (likely any record would) 5. Use batch record modification on the record 6. 300$a should have been catified (expected, that's the bug) 7. 245$a is preserved 8. Change the values of the two subfields to something else 9. Apply the patch, restart services 10. Use batch record modification on the record 11. 300$a should be preserved, cat protection should have worked But no it still got changed :( It's the first time I'm using record overlay rules so there is likely a mistake there. Either that or there is still a bug. So in the end, test plan needed or bug found. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162800|0 |1 is obsolete|| --- Comment #50 from Victor Grousset/tuxayo --- Created attachment 162805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162805=edit Bug 33268: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162799|0 |1 is obsolete|| --- Comment #49 from Victor Grousset/tuxayo --- Created attachment 162804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162804=edit Bug 33268: If rules exists add rules to preserve current behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162798|0 |1 is obsolete|| --- Comment #48 from Victor Grousset/tuxayo --- Created attachment 162803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162803=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162797|0 |1 is obsolete|| --- Comment #47 from Victor Grousset/tuxayo --- Created attachment 162802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162802=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162796|0 |1 is obsolete|| --- Comment #46 from Victor Grousset/tuxayo --- Created attachment 162801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162801=edit Bug 33268: Add tests Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #45 from Victor Grousset/tuxayo --- Thanks for the follow-up David. I moved the tests to their own commit (with a generic commit message that would benefit some completion) and reordered so we have all the test changes first. That allowed to run the test without implementation to confirm that they indeed fail without it. So that's great :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #44 from Victor Grousset/tuxayo --- Created attachment 162800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162800=edit Bug 33268: (QA follow-up): tidy up code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #162786|0 |1 is obsolete|| --- Comment #43 from Victor Grousset/tuxayo --- Created attachment 162799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162799=edit Bug 33268: If rules exists add rules to preserve current behavior Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #160017|0 |1 is obsolete|| --- Comment #42 from Victor Grousset/tuxayo --- Created attachment 162798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162798=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added Attachment #160018|0 |1 is obsolete|| --- Comment #41 from Victor Grousset/tuxayo --- Created attachment 162797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162797=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #40 from Victor Grousset/tuxayo --- Created attachment 162796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162796=edit Bug 33268: Add tests Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize Signed-off-by: Victor Grousset/tuxayo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #162785|0 |1 is obsolete|| --- Comment #39 from David Gustafsson --- Created attachment 162786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162786=edit Bug 33268: If rules exists add rules to preserve current behavior -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #162767|0 |1 is obsolete|| --- Comment #38 from David Gustafsson --- Created attachment 162785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162785=edit Bug 33268: If rules exists add rules to preserve current behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #37 from David Gustafsson --- Discovered an issue with the previous version of the update script which should now be fixed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #36 from David Gustafsson --- 2) Should now be fixed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #162766|0 |1 is obsolete|| --- Comment #35 from David Gustafsson --- Created attachment 162767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162767=edit Bug 33268: If rules exists add rules to preserve current behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #162764|0 |1 is obsolete|| --- Comment #34 from David Gustafsson --- Created attachment 162766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162766=edit Bug 33268: If rules exists add rules sure to preserve current behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #33 from David Gustafsson --- Created attachment 162764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162764=edit Bug 33268: If rules exists add rules sure to preserve current behaviour -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #32 from David Gustafsson --- @Katrin Fischer Sorry about the late reply. 1) I don't know if I can summarize it better than the current commit message, perhaps I could add "instead of falling back to the default rule (overwrite), which was the previous behavior. Previously the wildcard filter rules where only applied if no other filter value would match. The added tests should also be equivalent to performing manual testing, so don't really see why we would need both, but I guess I could add some simple case to be performed in the staff interface. 2) Gave this some thought and I think there is a relatively simple way to add rules depending on existing rules that would result in this patch not at all affecting behavior for current used defined rules. Will add a database migration for this. 3) Haven't done this for any other patch, so a little bit uncertain what it should contain. About your rules the wildcard filter rule will be merged in to the rule-sets of both the other rules. If the filter value is z3950 rule 2 and 4 will be applied, if batchmod 4 and five. If instead of 245 you had *, the wildcard filter rule (for tag 300) would not be included since the rule for z3950 and batchmod would always match, and rules with a specific filter value take precedence over wildcard filter rules if they match. (As summarized with "Fallback to overlay rules with wildcard filter if no match found for exact filter match." in the commit message. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #31 from Ray Delahunty --- I've just set up my first overlay rule in our test server and my clumsy workaround to protect 506, 541, 561 and 562 (set up 4 sets of rules, for each filter of Staff interface MARC editor, 39.50 import, Staged MARC import and Batch record modification) seems to work in the meantime, while a fix is being worked on. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Ray Delahunty changed: What|Removed |Added CC||r.delahu...@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #30 from Katrin Fischer --- I am sad to see this has dropped off the radar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #29 from Katrin Fischer --- *ping* This is waiting now waiting for feedback for more than 2 weeks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Katrin Fischer changed: What|Removed |Added Status|Passed QA |Failed QA Keywords||release-notes-needed --- Comment #28 from Katrin Fischer --- Hi all, I have tried to make sense of the notes here, but I am not confident I fully understand the consequences of this change yet. I'll try to summarize what I got so far: * The problem is about how we determine which rules apply in a situation. * context = filter + module * In my example context source-z3950 deactivated source-*, as they had the same context. ++-++--+-++++ | id | tag | module | filter | add | append | remove | delete | ++-++--+-++++ | 3 | 245 | source | z3950| 0 | 0 | 0 | 0 | | 4 | 300 | source | *| 0 | 0 | 0 | 0 | | 5 | 245 | source | batchmod | 0 | 0 | 0 | 0 | ++-++--+-++++ The patch states: "Fallback to overlay rules with wildcard filter if no match found for exact filter match." Does an exact match comprise of context + tag and now as there is no exact match for 300-source-z3950 we will also check for 300-source-*? Please: 1) Update commit message to include a test plan that highlights the change 2) Please explain: How will this change affect existing installations? Do we need to provide any information? Can we rule out data loss? 3) Please add release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #27 from Martin Renvoize --- Great teamwork here.. QA scripts happy and functionality now works more as described. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Martin Renvoize changed: What|Removed |Added Attachment #159519|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 160018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160018=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Martin Renvoize changed: What|Removed |Added Attachment #159518|0 |1 is obsolete|| --- Comment #25 from Martin Renvoize --- Created attachment 160017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160017=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #24 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #18) > > Please tidy inline. Done! I think the fact '*' rules don't stack up is a bit confusing, but it makes sense. We should (maybe) name it 'fallback' or similar. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #23 from Tomás Cohen Arazi --- Created attachment 159519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159519=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Tomás Cohen Arazi changed: What|Removed |Added Attachment #159160|0 |1 is obsolete|| Attachment #159161|0 |1 is obsolete|| --- Comment #22 from Tomás Cohen Arazi --- Created attachment 159518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159518=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind Signed-off-by: Tomas Cohen Arazi Edit: tidied inline (tcohen) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Tomás Cohen Arazi changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Signed Off |Failed QA --- Comment #21 from Victor Grousset/tuxayo --- pending comment 18 (perltidy unhappy) and comment 20 (test plan needed) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #20 from Katrin Fischer --- We are keen on the feature, but not on the right version yet. I know of at least one big library that will be using it in production very soon. I found the current behaviour with * confusing and we also had others reporting about it. But I haven't been able to follow the latest developments here to give an opinion about the planned changes yet. It looks like we are missing a test plan that highlights the change. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #19 from Marcel de Rooy --- It would be nice to know how many libraries have enabled OverlayRules btw. Unfortunately this pref is not sent to HEA ;) I need to study the manual what is actually meant by Delete and Remove etc. I think that the whole feature is very confusing and unclear. Not sure if this is a major. Not even sure if we should call this an Enh. Just my opinion.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #18 from Marcel de Rooy --- WARN Koha/MarcOverlayRules.pm WARN tidiness The file is less tidy than before (bad/messy lines before: 114, now: 128) WARN t/db_dependent/Biblio/MarcOverlayRules.t WARN tidiness The file is less tidy than before (bad/messy lines before: 226, now: 285) Please tidy inline. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Nind changed: What|Removed |Added Attachment #159058|0 |1 is obsolete|| --- Comment #17 from David Nind --- Created attachment 159161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159161=edit Bug 33268: Add tests for context module priority Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Nind changed: What|Removed |Added Attachment #159004|0 |1 is obsolete|| --- Comment #16 from David Nind --- Created attachment 159160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159160=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |glask...@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #15 from David Gustafsson --- Added tests for module priority when multiple module filters matches, and ran qa-script. Should now be ready for signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #14 from David Gustafsson --- Created attachment 159058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159058=edit Bug 33268: Add tests for context module priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #13 from David Gustafsson --- Would be nice with some feedback whether this is preferable to the current way rules are evaluated, will also need to update documentation in the manual. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #12 from David Gustafsson --- Now added some tests, it would probably be a good idea to add a test for multiple contexts with regards to module precedence. Besides from that it should be ready for review. Also have not run the qa-script yet. Don't know how much more time I currently have to spend on this though, it should more or less be ready for review. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Attachment #158956|0 |1 is obsolete|| --- Comment #11 from David Gustafsson --- Created attachment 159004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159004=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. To test: 1) Run tests t/db_dependent/Biblio/MarcOverlayRules.t Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added Status|NEW |In Discussion --- Comment #10 from David Gustafsson --- The attached patch needs some more work. Have done some manual testing and I think it's probably ok, but need to add tests before ready for review. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #9 from David Gustafsson --- Created attachment 158956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158956=edit Bug 33268: Overlay rules don't work correctly when source is set to * Fallback to overlay rules with wildcard filter if no match found for exact filter match. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #8 from David Gustafsson --- To summarize how the rules would be applied in a less convoluted way, for a specific tag and context: First all the rules for the matching module filter combination (context) are evaluated, if there is a match, that rule applies. If no rule was matched then rules for the wildcard filter are evaluated. There is another issue to address, and that is module priority. Say we have two or more matching context with different modules, which one applies? I think this is an oversight in the current implementation, and we have to make sure we loop through modules in a specific predefined order. Right now we just loop though the hash keys of "context" provided to the function merge_record in effect resulting in random order. I will have a go at patch addressing both the merging issue, and priority of modules. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #7 from David Gustafsson --- I have to correct my previous comment, if context + filter (context) has higher priority, but default rules are still merged in (but only if a rule with an exact match on context already does already match the tag condition) our current rules would work the same (as we have a wildcard rule matching the exact context (source => staff interface). I gave it some thought, and I think it would be possible to merge in the '*' with a few simple rules: If there are rules for the context with an exact filter match with a wildcard tag, discard all wildcard filter rules. If there are one or more regexp rules for the context with exact match, loop through all wildcard filter rules and throw away rules with tags matching this context. Else merge in all wildcard filter rules with tags not already present in current matching context. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #6 from David Gustafsson --- Context is module and filter, so if rules are applied with either z3950 or batchmod, '*' rules are ignored. '*' rules are only applied if there are no rules defined for the current context (module + filter). I think I decided on this so that each context would have a clean slate and though that would be easier to maintain, not having to undo wildcard rules for a new context, but I can see how it's not the most intuitive. For our library for example, we want to protect quite a lot of fields on imports, but want everything to be overwritable in the staff interface. So we define the "import" rules in the '*' context, and can just add one tag wildcard rule with for the staff interface to make everything overwritable again. I think I assumed that would be the most common use case. Merging in '*' would complicate things for us (but perhaps make things easier for others). Another reason avoided this was that it complicates the code quite a bit, but I think it would still be doable. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #5 from Katrin Fischer --- Hm, If they were intended as a fallback, why does my second rule in the example above not work? What is context here? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 David Gustafsson changed: What|Removed |Added CC||glask...@gmail.com --- Comment #4 from David Gustafsson --- Yes, even though this behaviour seems be confusing users, that was the intention. '*' rules are never "merged in" into another rule set, they just serve as defaults where no rules matching the current context are found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Michaela Sieber changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=34191 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Nick Clemens changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com, ||martin.renvoize@ptfs-europe ||.com, ||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #3 from Nick Clemens --- So, the way it seems to work is, if there are any rules for the context, then we don't get the '*' rules i.e. if you are going to define rules for z3950, then you must define all the rules you want - but if you don't define any rules for a specific filter, then the '*' rules are used Is this the intention, Tomas? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Katrin Fischer changed: What|Removed |Added CC||esther.melander@bywatersolu ||tions.com --- Comment #2 from Katrin Fischer --- *** Bug 33975 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 --- Comment #1 from Katrin Fischer --- It would be great if this could get some attention as it can create data loss. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 33268] Overlay rules don't work correctly when source is set to *
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33268 Katrin Fischer changed: What|Removed |Added Depends on||14957 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 [Bug 14957] Write protecting MARC fields based on source of import -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
