[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

--- Comment #5 from Caroline Cyr La Rose  ---
Thanks Lucas, I hadn't realized we had to fill either the top or the bottom
ones. It works this way and removes the extra click.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Attachment #166857|0   |1
is obsolete||

--- Comment #4 from Caroline Cyr La Rose  ---
Created attachment 166905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166905=edit
Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple
items at once

To test:
0. Make sure the DefaultHoldPickupLocation system preference is set to logged
in library.
1. In the staff interface, search the catalog with a term that will return a
couple of items (e.g. Shakespeare)
2. In the search results, select two or more results
3. Click Place hold
4. Search for a patron (e.g. Acevedo)
   --> "Pickup location" is empty and the staff member must select the library
5. APPLY PATCH and restart_all
6. Try again, the default should be set according to the
DefaultHoldPickupLocation system preference

Signed-off-by: Caroline Cyr La Rose 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-17 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

--- Comment #3 from Caroline Cyr La Rose  ---
(In reply to Lucas Gass from comment #2)
> This patch sets the 'Pickup location' according to the
> DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was
> unsure how you'd set that to the item's home/holding branch when there are
> more than 1 holds being placed. 

That's why I specified "if DefaultHoldPickupLocation is set to logged in
library". It should be the same for all holds in that case.

The client who reported this to me is a one-branch library and they wanted to
avoid having to choose a branch there (I also filed bug 36870 about that). But
I figured if their pref is set to logged in library, it would be another way to
avoid the extra clicks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

--- Comment #2 from Lucas Gass  ---
This patch sets the 'Pickup location' according to the
DefaultHoldPickupLocation but not the 'Pickup at' higher up because I was
unsure how you'd set that to the item's home/holding branch when there are more
than 1 holds being placed. 

I was thinking it would be nice that if you changed 'Pickup at' al the lower
'Pickup location' would also change to what you choose?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Lucas Gass  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
   Severity|enhancement |normal
 CC||lu...@bywatersolutions.com
   Assignee|koha-b...@lists.koha-commun |lu...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

--- Comment #1 from Lucas Gass  ---
Created attachment 166857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166857=edit
Bug 36871: Honor DefaultHoldPickupLocation when placing holds for multiple
items at once

To test:
0. Make sure the DefaultHoldPickupLocation system preference is set to logged
in library.
1. In the staff interface, search the catalog with a term that will return a
couple of items (e.g. Shakespeare)
2. In the search results, select two or more results
3. Click Place hold
4. Search for a patron (e.g. Acevedo)
   --> "Pickup location" is empty and the staff member must select the library
5. APPLY PATCH and restart_all
6. Try again, the default should be set according to the
DefaultHoldPickupLocation system preference

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-16 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Lucas Gass  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 36871] DefaultHoldPickupLocation = logged in library on multi-holds

2024-05-15 Thread bugzilla-daemon--- via Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36871

Caroline Cyr La Rose  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=36870

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/