[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891
--- Comment #7 from Phil Ringnalda ---
(In reply to Marcel de Rooy from comment #6)
> Having the impression that I got the 404 also without your patch. But I cant
> understand that either? Is Plack fooling me?
I hope it's Plack fooling you, since the code path to have that happen would be
to have eval { $record = undef->metadata->record } not set $@.
If you change
https://git.koha-community.org/Koha-community/Koha/src/commit/b16e2059a94cf8f803c5687460e73ccf6c85a5f0/svc/bib#L84
to return something other than 404, like maybe 406 Not Acceptable, do you get
that, or still 404?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 --- Comment #6 from Marcel de Rooy --- Having the impression that I got the 404 also without your patch. But I cant understand that either? Is Plack fooling me? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Lauren Denny changed: What|Removed |Added CC||lauren_de...@sil.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 David Nind changed: What|Removed |Added Attachment #166914|0 |1 is obsolete|| --- Comment #5 from David Nind --- Created attachment 166923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166923=edit Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist Changing from GetMarcBiblio to Biblios->find plus metadata->record lost the way that svc/bib used to return 404 when the bib number wasn't found. This patch restores that by checking for undef after the Biblios->find step. Test plan: 1. Load e.g. http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 which returns an XML bib record 2. Load http://127.0.0.1:8081/cgi-bin/koha/svc/bib/ and get a 500 error 2. Appply patch, restart_all 4. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 and get the bib again 5. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/ and get a 404 Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Phil Ringnalda changed: What|Removed |Added Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Phil Ringnalda changed: What|Removed |Added Attachment #166858|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 --- Comment #4 from Phil Ringnalda --- Created attachment 166914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166914=edit Bug 36891: Restore returning 404 from svc/bib when the bib number doesn't exist Changing from GetMarcBiblio to Biblios->find plus metadata->record lost the way that svc/bib used to return 404 when the bib number wasn't found. This patch restores that by checking for undef after the Biblios->find step. Test plan: 1. Load e.g. http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 which returns an XML bib record 2. Load http://127.0.0.1:8081/cgi-bin/koha/svc/bib/ and get a 500 error 2. Appply patch, restart_all 4. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 and get the bib again 5. Reload http://127.0.0.1:8081/cgi-bin/koha/svc/bib/ and get a 404 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Phil Ringnalda changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 --- Comment #3 from Phil Ringnalda --- D'oh, I told myself in comment 0 to move that if (defined $record), not add a second if (defined $biblio). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |p...@chetcolibrary.org |ity.org | CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 Phil Ringnalda changed: What|Removed |Added Assignee|p...@chetcolibrary.org |koha-b...@lists.koha-commun ||ity.org --- Comment #2 from Phil Ringnalda --- The nice part is that it works, http://127.0.0.1:8081/cgi-bin/koha/svc/bib/289 returns a bib, http://127.0.0.1:8081/cgi-bin/koha/svc/bib/9 returns a 404. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 --- Comment #1 from Phil Ringnalda --- Created attachment 166858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166858=edit Bug 36891: Naive attempt to fix svc/bib to return 404 when bib number not found But of course it can't be simple. After just adding if ( defined $biblio ) and reindenting and tidying what I indented, I'm told that I made two more untidy lines. And there's a bad smell around the "if ( defined $record )" since I don't see how it could be false, because $biblio->metadata->record doesn't return undef. But maybe I'm missing something. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 36891] Restore returning 404 from svc/bib when the bib number doesn't exist
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36891 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
