Re: [Libreoffice] LO Custom properties
Hi, I made a build that was successful, but when I run make dev-install, it fails.. Any ideas? Also I want a .deb installation. How can I get it? I tried --with-package-format=deb. Is this correct? I got the following error code. LibreOffice: Using system memory allocator. LibreOffice: This is for debugging only. To disable, LibreOffice: unset the environment variable G_SLICE. LibreOffice: Using system memory allocator. LibreOffice: This is for debugging only. To disable, LibreOffice: unset the environment variable G_SLICE. Error: File /home/eswagsh/Documents/LibreOffice_Sourc_Code/libo/framework/source/jobs/jobexecutor.cxx, Line 163: JobExecutor::~JobExecutor() Configuration don't send dispoing() message! Exited with code '-1' officeconnection.cxx:140:Assertion Test name: N12_GLOBAL__N_14TestE::test setUp() failed - equality assertion failed - Expected: 2 - Actual : 0 Failures !!! Run: 1 Failure total: 1 Failures: 1 Errors: 0 dmake: Error code 1, while making 'cpptest' --- Oh dear - something failed during the build - sorry ! For more help with debugging build errors, please see the section in: http://wiki.documentfoundation.org/Development internal build errors: ERROR: error 65280 occurred while making /home/eswagsh/Documents/LibreOffice_Sourc_Code/libo/smoketestoo_native it seems that the error is inside 'smoketestoo_native', please re-run build inside this module to isolate the error and/or test your fix: --- rm -Rf /home/eswagsh/Documents/LibreOffice_Sourc_Code/libo/smoketestoo_native/ unxlngx6.pro # optional module 'clean' /bin/bash cd /home/eswagsh/Documents/LibreOffice_Sourc_Code/libo source ./Env.Host.sh cd smoketestoo_native build when the problem is isolated and fixed exit and re-run 'make' from the top-level make: *** [dev-install] Error 1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSOC] Report #10. Wizards
Hello everybody, I finished last weekend the agenda wizard ( perhaps there're still some minor not-really-relevant issues to fix) and I'm already working on the last wizard, the web one. I also have in mind that I still have to create the make files for calling the python code within libo but i'm going to be quite busy this week because I'm moving back to Spain so I don't know how much time I'll have to work on it. You can take a look to my last commits here: http://cgit.freedesktop.org/libreoffice/components/log/?h=feature/gsoc2011_wizards Greetings ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell
Hi Miklos On 01/08/11 19:26, Miklos Vajna wrote: Hello Noel, I recently tested the copypaste export (using RTF) on master and got a crash. The attached patch solves the issue here. OK to push, or you want to add a check in the called SwMSConvertControls constructor? actually I am not at all familiar with the export side of this stuff. In theory I think your check is ok ( unfortunately I would guess the expectation that the doc shell is valid is probably buried deep in the SvxMSDffManager implementation ( where it probably isn't checked either ) ) but... I wonder why the doc shell isn't set up in the case of the RTF export ( is this something expected ) will this screw up other things later on. Also for the case above is the control export something that is relevant for the RTF filter even ? sorry haven't helped much :-( Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] BrOffice on LibO start screen in RTL languages
Hi, Today I started LibreOffice 3.4.2 with Uyghur UI and I saw BrOffice branding on the start screen. I fixed this on master 2 months ago but I did not think that it caused a visible problem. http://cgit.freedesktop.org/libreoffice/artwork/commit/?id=743e9624001a111c2e7011665c3965bea6918092 Please cherry-pick this to libreoffice-3-4. Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Leiam suas mensagens antes que sejam deletadas!
Leia as mensagens deixadas por Klaibson Ribeiro antes que sejam deletadas! Para ler sua mensagem, siga este link: http://us1.badoo.com/01131247047/in/MNfw8UtS6yw/?lang_id=61m=65mid=4e37c4b8003df298847d Mais gente que espera pacientemente por você: Elinho Junior (São José, Brasil) Nina (São José, Brasil) Toty (São José, Brasil) http://us1.badoo.com/01131247047/in/MNfw8UtS6yw/?lang_id=61m=65mid=4e37c4b8003df298847d Se os links desta mensagem não funcionarem, copie e cole-os na barra de endereços do seu browser. Este email e parte do procedimento de entrega de mensagens enviadas por Klaibson Ribeiro. Caso tenha recebido este email por engano, apenas ignore. Em breve esta mensagem será removida do sistema. Divirta-se! A Equipe Badoo Você recebeu este email, porque um membro do Badoo deixou uma mensagem para você no Badoo. Esta é uma mensagem de somente envio. Respostas a esta mensagem não são monitoradas ou respondidas. Se você não quer receber mais mensagens do Badoo, por favor nos notifique: http://us1.badoo.com/impersonation.phtml?lang_id=61mail_code=65email=libreoffice%40lists.freedesktop.orgsecret=invite_id=751518user_id=1131247047m=65mid=4e37c4b8003df298847d___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 HansPL hans...@ib-lederer.de changed: What|Removed |Added See Also||https://bugs.freedesktop.or ||g/show_bug.cgi?id=31481 --- Comment #179 from HansPL hans...@ib-lederer.de 2011-08-02 02:51:52 PDT --- Add https://bugs.freedesktop.org/show_bug.cgi?id=31481 Split pane in same window -- inherited from OOo, this seems the single most wanted feature for years. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [MHST] GDB doesn't show name of methods in backtrace
On 08/01/2011 06:55 PM, Michael Meeks wrote: Hi there, On Thu, 2011-07-28 at 01:09 +0700, Ta Duc Tung wrote: I've tried to make with debug=t but no change. GDB log still the same :( Any one please help! You need to 'make clean' in sw and then 'make debug=true' - and -then- you need to ensure that your install is linked to the dev tree with solenv/bin/linkoo. Then you need to re-run gdb, (with ooenv sourced), and you should have more luck. Thanks ! Michael. Hi, Firstly, I want to thank Michael. I still don't know how to ensure whether my install is linked to the dev tree but follow your word, GDB is somehow working (even there are still some ?? things, but at least, I can next and step now). I've try to use DDD to debug the code and I get this Segmentation Fault http://pastebin.com/6ciQanTq The bug above happens when I try to add a radio button to print dialog of Writer. Like this: http://pastebin.com/mS2G3e8t Please, how to fix this fault. I think I miss something in adding new radiobutton, but I don't know where it is. Thanks and Best Regards, Ta Tung ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added See Also|https://bugs.freedesktop.or | |g/show_bug.cgi?id=31481 | --- Comment #180 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-08-02 03:07:08 PDT --- @HansPL This meta is not for Enhancements, please read original report! And if a bug is a most annoying one, it's for Depends on -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [MHST] GDB doesn't show name of methods in backtrace
On Tue, 2011-08-02 at 17:06 +0700, Ta Duc Tung wrote: Please, how to fix this fault. I think I miss something in adding new radiobutton, but I don't know where it is. Attach a patch of your changes which crash for you and someone might apply it to their local tree and have a look. FWIW, on the symbols issue I'd add --enable-symbols to the ./autogen.sh configure line to make sure that everything gets built with -g C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Git hangs?
Hi Christian I keep getting git hangs here: [tdf@olivier git]$ git clone git:// anongit.freedesktop.org/libreoffice/bootstrap libo Cloning into libo... fatal: The remote end hung up unexpectedly I tried different DSL networks connections, clean users in my Linux, wiped all local repos, dug into hidden files... Git is release 1.7.3.4 (64 bits) from Mandriva (sigh) I am puzzled. It is frustrating... Olivier 2011/8/1 Christian Lohmaier lohmaier+libreoff...@googlemail.com Hi Olivier, *, On Mon, Aug 1, 2011 at 11:51 AM, Olivier Hallot olivier.hal...@documentfoundation.org wrote: It might of course have been a temporary outage, who knows - so does the problem remain now? ciao Christian -- Olivier Hallot Founder and Steering Commitee Member The Document Foundation ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Shiny, new EasyHacks
Hi all, the shiny, new EasyHacks are there. Details at: http://sweetshark.livejournal.com/3997.html Enjoy! Best, Bjoern -- https://launchpad.net/~bjoern-michaelsen ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Remove duplicated entry in configure.in
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Fix building bridge with -mavx
Libreoffice bridge code won't compile on new CPUs which add -mavx to cxxflags with --march=native. As first idea for the fix is actual ban for the -mavx cxxflag by adding -nomavx. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] add missing quotes to bashscript allowing space in variables
___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Request for a VM
I do not have enough resources such disk space for running the build process and the connectivity.. 2011/8/2 Marc-André Laverdière marc-an...@atc.tcs.com Hello, I am not sure what exactly you are asking for. My desktop is F15 and I run a virtual machine on my desktop all the time. VirtualBox OSE is free software, and Fedora is free software. So it should be easy :) Maybe I got your question wrong... would you please rephrase? Marc-André Laverdière Software Security Scientist Innovation Labs, Tata Consultancy Services Hyderabad, India On 08/01/2011 10:13 PM, Danishka Navin wrote: Hi, As you may know Fedora 14 does not release F14 based Libo RPMs but for F15. I would like to take care of building Libo for F14. If some one install Libo RPMs manually he/she wont get automatic updates. I am trying to maintain a repository where users can easily install Libo on F14 using the YUM. Highly appreciate if I could get a VM to start the build process. -- Danishka Navin http://danishkanavin.blogspot.com http://twitter.com/danishkanavin http://identi.ca/danishka http://www.flickr.com/photos/danishkanavin/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Danishka Navin http://danishkanavin.blogspot.com http://twitter.com/danishkanavin http://identi.ca/danishka http://www.flickr.com/photos/danishkanavin/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Request for a VM
Hi, Danishka Navin wrote on 2011-08-02 13:28: I do not have enough resources such disk space for running the build process and the connectivity.. TDF has some VMs, but at the moment, all are occupied - so if someone else could jump in, that would be greatly appreciated. Florian -- Florian Effenberger flo...@documentfoundation.org Steering Committee and Founding Member of The Document Foundation Tel: +49 8341 99660880 | Mobile: +49 151 14424108 Skype: floeff | Twitter/Identi.ca: @floeff ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [link] The patches I tried to sent in previous 3 threads
As the mail web interface is not cooperating nicely and didn't attach my patches I am just sending this link [1] as fixup. Sorry for the fuzz. [1] http://dev.gentooexperimental.org/~scarabeus/libreo/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Request for a VM
HI Danishka, *, On Mon, Aug 1, 2011 at 6:43 PM, Danishka Navin danis...@gmail.com wrote: As you may know Fedora 14 does not release F14 based Libo RPMs but for F15. I would like to take care of building Libo for F14. Why building? What is wrong with the rpms that are provided? They surely run on F14, don't they? If some one install Libo RPMs manually he/she wont get automatic updates. This is an entirely different topic. I am trying to maintain a repository where users can easily install Libo on F14 using the YUM. Sorry, this very likely won't happen on TDF servers. What *might* be possible (in future, not in the short term) is to provide repositories for different distros with the released rpms/debs (i.e. the same versions as available now, but installabe via your repo's tools, but what won't be hosted on TDF servers is distro-specific builds of LO everyone would get the same files, no matter whether the user is running Fedora or Mandriva or SuSE,... or whether the user runs F14 or F15. Highly appreciate if I could get a VM to start the build process. building: Why not use your own system? providing a repo with F14 specific files: Surely F14 has some kind of contrib system like every other distro? You should get in touch with the fedora project for that. ciao Christian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] debug compile failed on automation module
On Sat, 2011-07-30 at 22:24 +0200, Julien Nabet wrote: ../unxlngi6/obj/testbasi.o: In function `SbxBase::SetFlag(unsigned short)': /home/maryline/compile-libreoffice/libo/solver/350/unxlngi6/inc/basic/sbxcore.hxx:154: undefined reference to `DbgName_SbxBase()' visibility issues in --enable-dbgutil wrt one of the debugging-only classses in basic. Fixed it over the extended w/e. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 39447, which changed state. Bug 39447 Summary: Writer crashes at closing a document with footnotes in a single paragraph over two pages https://bugs.freedesktop.org/show_bug.cgi?id=39447 What|Old Value |New Value Resolution||DUPLICATE Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Git hangs?
Hi Olivier As Michael mentioned you can try to use http reguest instead: $ git clone http://anongit.freedesktop.org/git/libreoffice/bootstrap.git/ libo -- RN ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Fix building bridge with -mavx
On Tue, 2011-08-02 at 13:18 +0200, Tomas Chvatal wrote: Libreoffice bridge code won't compile on new CPUs which add -mavx to cxxflags with --march=native. As first idea for the fix is actual ban for the -mavx cxxflag by adding -nomavx. Isn't that a x86 (and x86_64 ?) only option, i.e. no need for it except in the _intel and _x86_64 bridges ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] BrOffice on LibO start screen in RTL languages
On Tue, 2011-08-02 at 11:31 +0200, Andras Timar wrote: http://cgit.freedesktop.org/libreoffice/artwork/commit/?id=743e9624001a111c2e7011665c3965bea6918092 Please cherry-pick this to libreoffice-3-4. done C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED][PATCH] Remove duplicated entry in configure.in
pushed now, thanks. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Reporting an error when loading of a component fails
Hello,
last week .docx support was broken because of a mistake during the gbuild
changes and I wasted quite some time finding out what was wrong. As something
similar had happened to me already before I'd like to apply the attached
patches. However I have some issues with it:
- the error dialog that pops up just says 'General error. General input/output
error.', which is completely unhelpful, however I don't feel like digging
more for how to pass the information as far as the place where the dialog is
shown, so I'd like to add at least debug output
- the debug output in the patch is done just using fprintf(stderr), as I
cannot find anything that would simply log a debug message and not do more -
is there anything like that in LO?
- osl_loadModule*() functions are plain C functions from stable API, so no
overloading to add the extra argument for the error message, the best I've
come up with was simply a wrapper around dlerror(), which I admit is not very
nice API either, would there be any better approach?
--
Lubos Lunak
l.lu...@suse.cz
diff --git a/cppuhelper/source/shlib.cxx b/cppuhelper/source/shlib.cxx
index a979454..1beed1f 100644
--- a/cppuhelper/source/shlib.cxx
+++ b/cppuhelper/source/shlib.cxx
@@ -367,9 +367,14 @@ Reference XInterface SAL_CALL loadSharedLibComponentFactory(
aModulePath.pData, SAL_LOADMODULE_LAZY | SAL_LOADMODULE_GLOBAL );
if (! lib)
{
-throw loader::CannotActivateFactoryException(
-OUSTR(loading component library failed: ) + aModulePath,
-Reference XInterface () );
+OUStringBuffer message = OUSTR(loading component library failed: ) + aModulePath;
+if( const char* error = osl_loadModuleLastError())
+{
+message.appendAscii( ( );
+message.append( OStringToOUString( error, RTL_TEXTENCODING_UTF8 ));
+message.appendAscii( ) );
+}
+throw loader::CannotActivateFactoryException( message.makeStringAndClear(), Reference XInterface () );
}
Reference XInterface xRet;
diff --git a/sal/inc/osl/module.h b/sal/inc/osl/module.h
index 803b0b6..2a92d39 100644
--- a/sal/inc/osl/module.h
+++ b/sal/inc/osl/module.h
@@ -102,6 +102,16 @@ oslModule SAL_CALL osl_loadModuleAscii(const sal_Char *pModuleName, sal_Int32 nR
oslModule SAL_CALL osl_loadModuleRelative(
oslGenericFunction baseModule, rtl_uString * relativePath, sal_Int32 mode);
+/**
+Return an error message for the last error in any of the osl_loadModule*() functions,
+or NULL if none.
+@since 3.5.0
+*/
+// TODO 4.0: this is kind of retarded, the osl_loadModule functions themselves should provide
+// this, but this is stable API and C-only, so no simple extending is possible and I don't
+// feel like making the API even more ugly by introducing osl_loadModule*WithError() copies
+const char* SAL_CALL osl_loadModuleLastError();
+
/** Retrieve the handle of an already loaded module.
This function can be used to search for a function symbol in the process address space.
diff --git a/sal/osl/unx/module.c b/sal/osl/unx/module.c
index a5beea9..7b7ca6f 100644
--- a/sal/osl/unx/module.c
+++ b/sal/osl/unx/module.c
@@ -104,6 +104,11 @@ oslModule SAL_CALL osl_loadModuleAscii(const sal_Char *pModuleName, sal_Int32 nR
return NULL;
}
+const char* SAL_CALL osl_loadModuleLastError()
+{
+return dlerror();
+}
+
/*/
/* osl_getModuleHandle */
/*/
diff --git a/sal/osl/w32/module.cxx b/sal/osl/w32/module.cxx
index a332d3a..1a906dd 100644
--- a/sal/osl/w32/module.cxx
+++ b/sal/osl/w32/module.cxx
@@ -144,6 +144,11 @@ oslModule SAL_CALL osl_loadModuleAscii(const sal_Char *pModuleName, sal_Int32 nR
return ret;
}
+const char* SAL_CALL osl_loadModuleLastError()
+{
+return NULL; // TODO
+}
+
/*/
/* osl_getModuleHandle */
/*/
diff --git a/sal/util/sal.map b/sal/util/sal.map
index 152b023..b4367e2 100755
--- a/sal/util/sal.map
+++ b/sal/util/sal.map
@@ -609,6 +609,7 @@ LIBO_UDK_3.5 { # symbols available in = LibO 3.5
global:
rtl_stringbuffer_remove;
rtl_uStringbuffer_remove;
+osl_loadModuleLastError;
} UDK_3.10;
PRIVATE_1.0 {
diff --git a/sfx2/source/doc/objstor.cxx b/sfx2/source/doc/objstor.cxx
index 31ee8f0..fca227b 100644
--- a/sfx2/source/doc/objstor.cxx
+++ b/sfx2/source/doc/objstor.cxx
@@ -2281,8 +2281,13 @@ sal_Bool SfxObjectShell::ExportTo( SfxMedium rMedium )
try{
xExporter = uno::Reference document::XExporter
( xFilterFact-createInstanceWithArguments( aFilterName, uno::Sequence uno::Any () ), uno::UNO_QUERY );
-}catch(const uno::Exception)
-{
[Libreoffice] [ANNOUNCE] libreoffice-3.3.4.1 tag created (3.3.4-rc1)
Hi, there have been created the libreoffice-3.3.4.1 tag for 3.3.4-rc1 release. The corresponding official builds will be available by the end of the week. See the attached list of changes against 3.3.3-final. I am going to create the libreoffice-3-3-4 branch for the final stabilization. You might switch your current 3-3 source tree to it using: cd build git fetch --tags git checkout -b tag-libreoffice-3.3.4.1 libreoffice-3.3.4.1 bin/g fetch --tags bin/g checkout -b tag-libreoffice-3.3.4.1 libreoffice-3.3.4.1 See also the schedule at http://wiki.documentfoundation.org/ReleasePlan#3.3_release and release criteria at http://wiki.documentfoundation.org/Release_Criteria Best Regards, Petr + calc + set selection request as done for macro recorder (fdo#38955) [Caolán McNamara] + help + revert Update the operation of delete and backspace key (fdo#31652) [Andras Timar] + update the operation of delete and backspace key (fdo#31652) [Korrawit Pruegsanusak] + libs-gui + fix regression in SvGlobalName::operator (fdo#32709) [Radek Doulik] + writer + fExtChar affects only 8 (if at all) (i#118018) [Caolán McNamara] + fix for character count without spaces (fdo#30550) [Korrawit Pruegsanusak] + related: use standard sprm iterator (fdo#37057) [Caolán McNamara] + common + version 3.3.4.1, tag libreoffice-3.3.4.1 (3.3.4-rc1) [Petr Mladek] + bootstrap + bump product version to 3.3.4-rc1, release number to 401 [Petr Mladek] + build + fix configure message for libreoffice-3-3 branch [Petr Mladek] + updated eu, pl, ta translations [Andras Timar] + calc + set selection request as done for macro recorder (fdo#38955) [Caolán McNamara] + help + revert Update the operation of delete and backspace key (fdo#31652) [Andras Timar] + update the operation of delete and backspace key (fdo#31652) [Korrawit Pruegsanusak] + l10n + updated da, et, lt, pt-BR, tr, and zh-TW translations [Andras Timar] + libs-gui + fix regression in SvGlobalName::operator (fdo#32709) [Radek Doulik] + handle busted emf lengths [Caolán McNamara] + writer + fExtChar affects only 8 (if at all) (i#118018) [Caolán McNamara] + fix backport [Luboš Luňák] + fix for character count without spaces (fdo#30550) [Korrawit Pruegsanusak] + fix loss of init on merge [Caolán McNamara] + merge these sprm finders and do it right [Caolán McNamara] + related: use standard sprm iterator (fdo#37057) [Caolán McNamara] + valgrind: init some values [Caolán McNamara] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for bnc#707486
Hi Kohei On 29/07/11 17:01, Kohei Yoshida wrote: On Fri, 2011-07-29 at 16:48 +0100, Noel Power wrote: perfect sense. In this case, I don't see it will make any difference, so you can change the order to the way it was or not as you wish ( I have no preference ) Ok. Pushed to -3-4 with the lines flipped back (so that I can rest easy). Kohei It appears another tweak is necessary, somewhere between when I tested and posted the patch I must have changed this line, the only other explanation is that somehow this worked randomly :-( ( it doesn't for me in the latest build ) Could you do the honours and review/commit ? Noel diff --git a/sc/source/ui/view/viewfun3.cxx b/sc/source/ui/view/viewfun3.cxx index 8358b56..222571a 100644 --- a/sc/source/ui/view/viewfun3.cxx +++ b/sc/source/ui/view/viewfun3.cxx @@ -596,7 +596,7 @@ sal_Bool ScViewFunc::CopyToClip( ScDocument* pClipDoc, const ScRangeList rRange if (!bValidRanges) break; -pDoc-CopyToClip4VBA( aClipParam, pClipDoc, false, bIncludeObjects ); +pDoc-CopyToClip4VBA( aClipParam, pDocClip.get(), false, bIncludeObjects ); ScChangeTrack* pChangeTrack = pDoc-GetChangeTrack(); if ( pChangeTrack ) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Git hangs?
Hi *, On Tue, Aug 2, 2011 at 2:34 PM, Niko Rönkkö niko.ron...@wippies.fi wrote: As Michael mentioned you can try to use http reguest instead: $ git clone http://anongit.freedesktop.org/git/libreoffice/bootstrap.git/ libo http is much slower than git transport, so I doubt that would help. But you definitely should try a traceroute. for reference the bug when US was super-fast, but Europe was slow: http://bugs.freedesktop.org/show_bug.cgi?id=37416 If other people can confirm it with IPs from Brazil, it might be a generic problem that their ISP might be able to solve. ciao Christain ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Request for a VM
I know this is offtopic for this list but if you want a cheap and affordable xen based vm check out www.linode.com and you can format with a wide variety of operating systems, you just have to check that they are supported by linode. On 02/08/2011 13:33, Florian Effenberger wrote: Hi, Danishka Navin wrote on 2011-08-02 13:28: I do not have enough resources such disk space for running the build process and the connectivity.. TDF has some VMs, but at the moment, all are occupied - so if someone else could jump in, that would be greatly appreciated. Florian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for bnc#707486
Hi Noel, On Tue, 2011-08-02 at 14:19 +0100, Noel Power wrote: It appears another tweak is necessary, somewhere between when I tested and posted the patch I must have changed this line, the only other explanation is that somehow this worked randomly :-( ( it doesn't for me in the latest build ) Could you do the honours and review/commit ? Sure. Pushed to the 3-4 branch with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kyosh...@novell.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [ANNOUNCE] libreoffice-3.3.4.1 tag created (3.3.4-rc1)
Petr Mladek píše v Út 02. 08. 2011 v 15:18 +0200: Hi, there have been created the libreoffice-3.3.4.1 tag for 3.3.4-rc1 release. Sigh, I forgot to bump version in libreoffice/build/configure.in. I have fixed it in the libreoffice-3.3.4.1-buildfix1 tag in the build repo. You might switch your current 3-3 source tree to it using: Please use: cd build git fetch --tags git checkout -b tag-libreoffice-3.3.4.1 libreoffice-3.3.4.1-buildfix1 bin/g fetch --tags bin/g checkout -b tag-libreoffice-3.3.4.1 libreoffice-3.3.4.1 I am sorry for the inconvenience. The build repo is not used for LO-3.4, so this trick went out of my mind. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [ANNOUNCE] Branch libreoffice-3-3-4 created
Hi all, there have been created the libreoffice-3-3-4 branch. It will be used for fine tuning of the 3.3.4 bugfix release. It is based on the tag libreoffice-3.3.4.1 for 3.3.4-rc1 release. The following rules apply: + preferably just translation or blocker fixes + only cherry-picking from libreoffice-3-3 branch + 2 additional reviews needed; 2nd reviewer pushes + no regular merges back to anything The 'libreoffice-3-3' branch is still active, will be used for the next bugfix release (3.3.5). Please read more at http://wiki.documentfoundation.org/ReleasePlan http://wiki.documentfoundation.org/Development/Branches Now, if you want to switch your clone to the libreoffice-3-3-4 branch, please do: git pull -r bin/g pull -r git checkout -b libreoffice-3-3-4 origin/libreoffice-3-3-4 bin/g checkout -b libreoffice-3-3-4 origin/libreoffice-3-3-4 Hopefully it will work for you :-) Most probably, you will also want to do (if you haven't done it yet): git config --global push.default tracking When you do git push with this, git will push only the branch you are on; e.g. libreoffice-3-3-4 when you have switched to it. This will save you some git shouting at you. Happy hacking, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell
Hi Noel, On Tue, Aug 02, 2011 at 10:07:22AM +0100, Noel Power nopo...@novell.com wrote: actually I am not at all familiar with the export side of this stuff. In theory I think your check is ok ( unfortunately I would guess the expectation that the doc shell is valid is probably buried deep in the SvxMSDffManager implementation ( where it probably isn't checked either ) ) Sure, that's why I touched the caller. but... I wonder why the doc shell isn't set up in the case of the RTF export ( is this something expected ) will this screw up other things later on. Also for the case above is the control export something that is relevant for the RTF filter even ? sorry haven't helped much :-( I guess the reason is that the doc shell points to the whole document, while you usually export only part of the doc during copypaste export. And yes, I don't think missing the control export is a big issue (at least it's a smaller one thatn the current instant crash), that's why I asked if you're fine with pushing the patch I sent. Thanks. pgpWxQ2RZIJYd.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] MSWordExportBase::ExportDocument: check if we have a DocShell
Hi Miklos On 02/08/11 16:46, Miklos Vajna wrote: I guess the reason is that the doc shell points to the whole document, while you usually export only part of the doc during copypaste export. 'copypaste export' is it a new thing you can't normally do from writer ? ( not familiar with it anyway ) And yes, I don't think missing the control export is a big issue (at least it's a smaller one thatn the current instant crash), yes of course and no problem for me with the fix for that Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer
Hello,
This is my second patch for Bug 38831 - [EasyHack] Get rid of
SV_DECL_VARARR, SV_DECL_VARARR_PLAIN, SV_DECL_VARARR_SORT
It replace SvULongs and WW8_WrSepInfoPtrs (another VARARR) with
std:vector, SvStringsDtor with boost::ptr_vector in writer.
Best Regards,
Maciej
From fd48141c12a6e9abd84d32fd1553a789bd9e2a4b Mon Sep 17 00:00:00 2001
From: Maciej Rumianowski maciej.rumianow...@gmail.com
Date: Tue, 2 Aug 2011 17:27:34 +0200
Subject: [PATCH] Get rid of SvULongs in writer
Replace SvULongs with std::vector. In SwHTMLWriter simultaneously replace aOutlineMarks with boost::ptr_vector.
---
sw/source/filter/html/htmlfly.cxx | 10 ++--
sw/source/filter/html/wrthtml.cxx | 20
sw/source/filter/html/wrthtml.hxx |7 ++-
sw/source/filter/ww8/wrtw8esh.cxx |4 +-
sw/source/filter/ww8/wrtw8sty.cxx | 84 +
sw/source/filter/ww8/wrtww8.cxx | 24 +--
sw/source/filter/ww8/wrtww8.hxx | 24 ---
7 files changed, 80 insertions(+), 93 deletions(-)
diff --git a/sw/source/filter/html/htmlfly.cxx b/sw/source/filter/html/htmlfly.cxx
index a6bd6c3..873afd5 100644
--- a/sw/source/filter/html/htmlfly.cxx
+++ b/sw/source/filter/html/htmlfly.cxx
@@ -1804,20 +1804,20 @@ void SwHTMLWriter::AddLinkTarget( const String rURL )
SwPosition aPos( *pCurPam-GetPoint() );
if( pDoc-GotoOutline( aPos, aOutline ) )
{
-sal_uLong nIdx = aPos.nNode.GetIndex();
+sal_uInt32 nIdx = aPos.nNode.GetIndex();
-sal_uInt16 nIns=0;
-while( nIns aOutlineMarkPoss.Count()
+sal_uInt32 nIns=0;
+while( nIns aOutlineMarkPoss.size()
aOutlineMarkPoss[nIns] nIdx )
nIns++;
-aOutlineMarkPoss.Insert( nIdx, nIns );
+aOutlineMarkPoss.insert( aOutlineMarkPoss.begin()+nIns, nIdx );
if( bEncoded )
{
aURL.Erase( nPos, 2 );
aURL.SetChar( nPos-1, cMarkSeperator );
}
-aOutlineMarks.Insert( new String( aURL ), nIns );
+aOutlineMarks.insert( aOutlineMarks.begin()+nIns, new String( aURL ) );
}
}
else if( sCmp.EqualsAscii( pMarkToText ) )
diff --git a/sw/source/filter/html/wrthtml.cxx b/sw/source/filter/html/wrthtml.cxx
index 0e78fae..e6baa5a 100644
--- a/sw/source/filter/html/wrthtml.cxx
+++ b/sw/source/filter/html/wrthtml.cxx
@@ -402,11 +402,11 @@ sal_uLong SwHTMLWriter::WriteStream()
if( aImplicitMarks.Count() )
aImplicitMarks.DeleteAndDestroy( sal_uInt16(0), aImplicitMarks.Count() );
-if( aOutlineMarks.Count() )
-aOutlineMarks.DeleteAndDestroy( sal_uInt16(0), aOutlineMarks.Count() );
+if( !aOutlineMarks.empty() )
+aOutlineMarks.clear();
-if( aOutlineMarkPoss.Count() )
-aOutlineMarkPoss.Remove( sal_uInt16(0), aOutlineMarkPoss.Count() );
+if( !aOutlineMarkPoss.empty() )
+aOutlineMarkPoss.clear();
if( aNumRuleNames.Count() )
aNumRuleNames.DeleteAndDestroy( sal_uInt16(0), aNumRuleNames.Count() );
@@ -1065,18 +1065,18 @@ void SwHTMLWriter::OutBookmarks()
pBookmark = (pMarkAccess-getMarksBegin() + nBkmkTabPos)-get();
}
-sal_uInt16 nPos;
-for( nPos = 0; nPos aOutlineMarkPoss.Count()
+sal_uInt32 nPos;
+for( nPos = 0; nPos aOutlineMarkPoss.size()
aOutlineMarkPoss[nPos] nNode; nPos++ )
;
-while( nPos aOutlineMarkPoss.Count() aOutlineMarkPoss[nPos] == nNode )
+while( nPos aOutlineMarkPoss.size() aOutlineMarkPoss[nPos] == nNode )
{
-String sMark( *aOutlineMarks[nPos] );
+String sMark( aOutlineMarks[nPos] );
sMark.SearchAndReplaceAll( '?', '_' ); // '?' causes problems in IE/Netscape 5
OutAnchor( sMark );
-aOutlineMarkPoss.Remove( nPos, 1 );
-aOutlineMarks.DeleteAndDestroy( nPos, 1 );
+aOutlineMarkPoss.erase( aOutlineMarkPoss.begin()+nPos );
+aOutlineMarks.erase( aOutlineMarks.begin() + nPos );
}
}
diff --git a/sw/source/filter/html/wrthtml.hxx b/sw/source/filter/html/wrthtml.hxx
index 4e040f1..83f93f4 100644
--- a/sw/source/filter/html/wrthtml.hxx
+++ b/sw/source/filter/html/wrthtml.hxx
@@ -28,13 +28,14 @@
#ifndef _WRTHTML_HXX
#define _WRTHTML_HXX
+#include boost/ptr_container/ptr_vector.hpp
+#include vector
#include com/sun/star/container/XIndexContainer.hpp
#include com/sun/star/form/XForm.hpp
#include vcl/field.hxx
#define _SVSTDARR_STRINGSDTOR
#define _SVSTDARR_STRINGSSORTDTOR
-#define _SVSTDARR_ULONGS
#include svl/svstdarr.hxx
#include i18npool/lang.h
#include tools/stream.hxx
@@ -227,11 +228,11 @@ public:
SvStringsDtor aImgMapNames; // geschriebene Image Maps
SvStringsSortDtor aImplicitMarks;// implizite Stprungmarken
-SvStringsDtor aOutlineMarks; // geschriebene Image Maps
SvStringsSortDtor aNumRuleNames;// Names of exported num
[Libreoffice] [REVIEW] fix for fdo#39728: check for empty local range names
Hello,
this patch checks if we have a local ScRangeName before it tries to use it.
I consider this patch safe and think it should be in 3-4 so Review Sign-off
appreciated.
Regards,
Markus
From eda5da2df84567b4025cdfd2f94c0e425553db6c Mon Sep 17 00:00:00 2001
From: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Tue, 2 Aug 2011 21:19:52 +0200
Subject: [PATCH] fix for fdo#39728: check for empty local range names
---
sc/source/core/tool/compiler.cxx |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index b61b146..9f39358 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -2895,7 +2895,9 @@ sal_Bool ScCompiler::IsNamedRange( const String rUpperName )
// try local names first
bool bGlobal = false;
ScRangeName* pRangeName = pDoc-GetRangeName(aPos.Tab());
-const ScRangeData* pData = pRangeName-findByUpperName(rUpperName);
+const ScRangeData* pData = NULL;
+if (pRangeName)
+pData = pRangeName-findByUpperName(rUpperName);
if (!pData)
{
pRangeName = pDoc-GetRangeName();
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#39728: check for empty local range names
On Tue, 2011-08-02 at 21:43 +0200, Markus Mohrhard wrote: Hello, this patch checks if we have a local ScRangeName before it tries to use it. I consider this patch safe and think it should be in 3-4 so Review Sign-off appreciated. I concur. Pushed to 3-4 with my sign-off. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Small Question About sal_* Types
2011/8/1 Marc-André Laverdière marc-an...@atc.tcs.com:
I remember that one rocket disintegrated because of an issue of types...
https://secure.wikimedia.org/wikipedia/en/wiki/Ariane_5_Flight_501
Thankfully, LO shouldn't be used in this way... but mismatching of types
(especially between modules) can be a source of a gazillion bugs and a
few security issues. I guess that is the reason why POSIX and Windows
APIs have created all sorts of types like HANDLE and size_t :)
That has been standardized more than 10 years ago in C99 with stdint.h, i.e with
[u]int_{8,16,32,64}_t and the like.
granted the project pre-date that standardization, so it did not use
it back then... but that does not mean we should
ignore standard ever-after
on the other hand forcing a compiler to use a given size when all you
care is 'at least that size' is not a good thing. Sure performance
wise that is probably not on top of the list... but still...
I am inclined to think that we should follow suit and standardize on the
sal_* types, and not just on the boundaries.
There is merit to have a way to highlight ABI-breaking boundaries...
Nobert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#38382, a missing icon
Hi, In Draw/Impress the second icon of the Styles and Formatting dialog is missing. Its tooltip text appears on the button instead of the image. It was a victim of code cleanup. The following patchs restores it. Please cherry-pick it to libreoffice-3-4 branch. http://cgit.freedesktop.org/libreoffice/impress/commit/?id=061ecea4152845422123ff66f1829c31f29466d1 Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#39151: local db data needs to be updated when copying sheets
Hello,
this patch updates local db data when sheets are copied. We need to update
the table number set in ScDBData to point to the new table.
Patch should be safe, so review and sign-off appreciated. This patch may not
apply to master.
Regards,
Markus
From 3ad3174c10e07d3d45db71f011f31d08963dd512 Mon Sep 17 00:00:00 2001
From: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Wed, 3 Aug 2011 00:04:53 +0200
Subject: [PATCH] fix for fdo#39151: set correct table number in local db data
---
sc/source/core/data/table2.cxx | 10 +-
1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/sc/source/core/data/table2.cxx b/sc/source/core/data/table2.cxx
index 67d94bc..24fc269 100644
--- a/sc/source/core/data/table2.cxx
+++ b/sc/source/core/data/table2.cxx
@@ -768,7 +768,15 @@ void ScTable::CopyToTable(SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW nRow2,
return;
if (pDBDataNoName)
-pDestTab-SetAnonymousDBData(new ScDBData(*pDBDataNoName));
+{
+ScDBData* pNewDBData = new ScDBData(*pDBDataNoName);
+SCCOL aCol1, aCol2;
+SCROW aRow1, aRow2;
+SCTAB aTab;
+pNewDBData-GetArea(aTab, aCol1, aRow1, aCol2, aRow2);
+pNewDBData-MoveTo(pDestTab-nTab, aCol1, aRow1, aCol2, aRow2);
+pDestTab-SetAnonymousDBData(pNewDBData);
+}
// Charts muessen beim Ein-/Ausblenden angepasst werden
ScChartListenerCollection* pCharts = pDestTab-pDocument-GetChartListenerCollection();
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] How to set fillcolor and linecolor to a SdrObject?
Hi all, ODF1.2 defines 15 standard symbols for charts. As earlier mentioned, I try to implement the missing ones. But there are some problems with the symbols horizontal-bar and vertical-bar. The implementation of the current symbols in /calc/chart2/source/view/main/ShapeFactory.cxx in method createPolyPolygon_Symbol draws the symbols in a way, that the given size in parameter rSize is completely used. Moreover, this method is called with a square in rSize in all default cases. I have tried now this way for a horizontal-bar: Draw a rectangle, which is 1/5 of the given height. With this attempt I get correct symbols in the chart itself and in the legend. But the preview in the data series dialog or in the data point dialog paints my horizontal-bar and my vertical-bar as square. And in the list in the pop-up menu my bars are shifted. As far as I see, the graphics to be used in the dialog are generated in components/cui/source/tapages/tpline.cxx. My idea is now to insert a 100% transparent square into the temporary page pPage and mark that object together with my symbols for generating the bitmaps. For inserting an additional object, I have used SdrObject *pInvisibleSquare=pSymbolList-GetObj(0); pInvisibleSquare=pInvisibleSquare-Clone(); pPage-NbcInsertObject(pInvisibleSquare); in IMPL_LINK( SvxLineTabPage, MenuCreateHdl_Impl, MenuButton *, pButton ) after line 1540 and pView-MarkAll(); instead of pView-MarkObj(pObj,pPageView); in line 1552 seems to work too. But I do not know how to make the object transparent. Especially, I do not know how to use these itempool-thing. In Basic I would have assigned a value to the property. But in C++ I'm totally lost. Do you can point me to a guide or lead me to a solution? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [REVIEW] fix for fdo#39773: crash with hidden column in Data-Form
Hello, this patch adds a necessary check for a null pointer. Regards, Markus From 9af8fdaba562e8d8e7f3e4241edc70d282eb1b56 Mon Sep 17 00:00:00 2001 From: Markus Mohrhard markus.mohrh...@googlemail.com Date: Wed, 3 Aug 2011 03:14:55 +0200 Subject: [PATCH] fix for fdo#39773: crash with hidden column in Data-Form --- sc/source/ui/miscdlgs/datafdlg.cxx |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sc/source/ui/miscdlgs/datafdlg.cxx b/sc/source/ui/miscdlgs/datafdlg.cxx index 10ef3a3..d8774f2 100644 --- a/sc/source/ui/miscdlgs/datafdlg.cxx +++ b/sc/source/ui/miscdlgs/datafdlg.cxx @@ -201,7 +201,8 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri pFixedTexts[nIndex] = NULL; pEdits[nIndex] = NULL; } -pEdits[nIndex]-SetModifyHdl( HDL(Impl_DataModifyHdl) ); +if (pEdits[nIndex]) +pEdits[nIndex]-SetModifyHdl( HDL(Impl_DataModifyHdl) ); } Size nDialogSize = this-GetSizePixel(); -- 1.7.3.4 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#38382, a missing icon
Hello Andras, On Tue, 2011-08-02 at 23:10 +0200, Andras Timar wrote: In Draw/Impress the second icon of the Styles and Formatting dialog is missing. Its tooltip text appears on the button instead of the image. It was a victim of code cleanup. The following patchs restores it. Please cherry-pick it to libreoffice-3-4 branch. http://cgit.freedesktop.org/libreoffice/impress/commit/?id=061ecea4152845422123ff66f1829c31f29466d1 Verified the fix, and pushed to 3-4 with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#39151: local db data needs to be updated when copying sheets
On Wed, 2011-08-03 at 00:17 +0200, Markus Mohrhard wrote: Hello, this patch updates local db data when sheets are copied. We need to update the table number set in ScDBData to point to the new table. Patch should be safe, so review and sign-off appreciated. This patch may not apply to master. Yup, the patch makes sense should be safe. Pushed to 3-4 with my sign-off. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED] [PUSHED 3-4] fix for fdo#39773: crash with hidden column in Data-Form
On Wed, 2011-08-03 at 03:22 +0200, Markus Mohrhard wrote: Hello, this patch adds a necessary check for a null pointer. Simple enough. Pushed to 3-4. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc kohei.yosh...@suse.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Make dev-install without running smoketests
Hi, My build is successful but when I issue make dev-install, it crashes in the smoketest module. Is there any way by which I can skip smoketest? Regards -- Swagat ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Easy Hack - Get rid ofSvULongs in writer
On Tue, 2011-08-02 at 19:12 +0200, Maciej Rumianowski wrote:
Hello,
This is my second patch for Bug 38831 - [EasyHack] Get rid of
SV_DECL_VARARR, SV_DECL_VARARR_PLAIN, SV_DECL_VARARR_SORT
It replace SvULongs and WW8_WrSepInfoPtrs (another VARARR) with
std:vector, SvStringsDtor with boost::ptr_vector in writer.
@@ -2017,7 +2011,7 @@ bool WW8_WrPlcSubDoc::WriteGenericTxt( WW8Export rWrt,
sal_uInt8 nTTyp,
{
// textbox - content
WW8_CP nCP = rWrt.Fc2Cp( rWrt.Strm().Tell() );
-aCps.Insert( nCP, i );
+aCps.push_back( nCP );
pTxtPos-Append( nCP );
Hmm are you sure that you can replace that with vector's push_back()
there? For this to work correctly the i has to always point to the end
position (last element + 1), but from the surrounding code I'm not sure
if that's guaranteed. You probably should use vector's insert() method
with a specific insert position, instead of using push_back() in this
case.
Also, I've seen a code like the following
if (!vec.empty())
vec.clear();
in several places. While this code is not wrong (since the original
code was written that way), calling clear() on an empty vector does
nothing is harmless. So just calling clear() should be fine without
checking for empty-ness.
Other than that, the rest looks okay to me. I'd prefer someone more
experienced in Writer's code to sanity-check though.
Kohei
--
Kohei Yoshida, LibreOffice hacker, Calc
kohei.yosh...@suse.com
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
