date:20120125

 scp2/source/canvas/makefile.mk   |5 +
 scp2/util/makefile.mk|5 +
 sd/CppunitTest_sd_filters_test.mk|2 +-
 sd/CppunitTest_sd_regression_test.mk |1 +
 4 files changed, 4 insertions(+), 9 deletions(-)

New commits:
commit 554bcf4205ede6ec3adb9f39e676b77054b1e8a1
Author: Riccardo Magliocchetti riccardo.magliocche...@gmail.com
Date:   Wed Jan 25 12:00:45 2012 +0100

Fix file not found: cairocanvas.uno.so in smoketestoo_native

diff --git a/scp2/source/canvas/makefile.mk b/scp2/source/canvas/makefile.mk
index 7ce0257..d0d8362 100644
--- a/scp2/source/canvas/makefile.mk
+++ b/scp2/source/canvas/makefile.mk
@@ -41,12 +41,9 @@ PARFILES= canvascommons.par  \
   vclcanvas.par \
  mtfrenderer.par
 
-.IF $(GUI)==UNX
-#X11 MacOSX has no cairo-canvas
-.IF $(OS) != MACOSX || $(GUIBASE) == aqua
+.IF $(ENABLE_CAIRO_CANVAS)==TRUE
 PARFILES+= cairocanvas.par
 .ENDIF
-.ENDIF
 
 .IF $(ENABLE_DIRECTX) != 
 .IF $(USE_DIRECTX5) != 
diff --git a/scp2/util/makefile.mk b/scp2/util/makefile.mk
index 74b45a8..7de0c6c 100644
--- a/scp2/util/makefile.mk
+++ b/scp2/util/makefile.mk
@@ -209,12 +209,9 @@ SCP1FILES += \
  vclcanvas.par \
 mtfrenderer.par
 
-.IF $(GUI)==UNX
-#X11 MacOSX has no cairo-canvas
-.IF $(OS) != MACOSX || $(GUIBASE) == aqua
+.IF $(ENABLE_CAIRO_CANVAS)==TRUE
 SCP1FILES += cairocanvas.par
 .ENDIF
-.ENDIF
 
 .IF $(ENABLE_ONLINE_UPDATE)!=
 SCP1FILES += \
commit 400ad00534afbbc93de9fd0835e487980f85a336
Author: Thorsten Behrens tbehr...@suse.com
Date:   Wed Jan 25 11:52:00 2012 +0100

Put font embedding disable to correct unit test

diff --git a/sd/CppunitTest_sd_filters_test.mk 
b/sd/CppunitTest_sd_filters_test.mk
index 5b89b8f..b4de440 100644
--- a/sd/CppunitTest_sd_filters_test.mk
+++ b/sd/CppunitTest_sd_filters_test.mk
@@ -123,7 +123,7 @@ $(eval $(call 
gb_CppunitTest_add_old_components,sd_filters_test,\
 $(eval $(call gb_CppunitTest_set_args,sd_filters_test,\
 --headless \
 --protector unoexceptionprotector$(gb_Library_DLLEXT) 
unoexceptionprotector \
--env:CONFIGURATION_LAYERS=xcsxcu:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry) 
-env:SVG_DISABLE_FONT_EMBEDDING=YEAH module:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry/spool) \
+-env:CONFIGURATION_LAYERS=xcsxcu:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry) module:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry/spool) \
 ))
 # .../spool is required for the (somewhat strange) filter configuration
 
diff --git a/sd/CppunitTest_sd_regression_test.mk 
b/sd/CppunitTest_sd_regression_test.mk
index 1c3b089..8e56336 100644
--- a/sd/CppunitTest_sd_regression_test.mk
+++ b/sd/CppunitTest_sd_regression_test.mk
@@ -130,6 +130,7 @@ $(eval $(call gb_CppunitTest_set_args,sd_regression_test,\
 --headless \
 --protector unoexceptionprotector$(gb_Library_DLLEXT) 
unoexceptionprotector \
 -env:CONFIGURATION_LAYERS=xcsxcu:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry) module:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry/spool) xcsxcu:$(call 
gb_CppunitTarget__make_url,$(OUTDIR)/unittest/registry) \
+-env:SVG_DISABLE_FONT_EMBEDDING=YEAH \
 ))
 # .../spool is required for the (somewhat strange) filter configuration
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 3 commits - basegfx/inc basegfx/Library_basegfx.mk basegfx/Package_inc.mk basegfx/source basegfx/StaticLibrary_basegfx_s.mk Makefile sc/source sd/source solenv/bin svx/inc svx

2012-01-25 Thread Jan Holesovsky

 Makefile|5 +
 basegfx/Library_basegfx.mk  |1 
 basegfx/Package_inc.mk  |1 
 basegfx/StaticLibrary_basegfx_s.mk  |1 
 basegfx/inc/basegfx/tools/zoomtools.hxx |   52 +++
 basegfx/source/tools/zoomtools.cxx  |  150 
 sc/source/ui/view/prevwsh.cxx   |6 -
 sc/source/ui/view/tabview.cxx   |7 -
 sd/source/ui/view/viewshel.cxx  |7 -
 solenv/bin/mkdocs.sh|2 
 svx/inc/svx/zoom_def.hxx|4 
 svx/source/stbctrls/zoomsliderctrl.cxx  |7 -
 sw/source/ui/uiview/viewport.cxx|7 -
 13 files changed, 226 insertions(+), 24 deletions(-)

New commits:
commit 3092e57f0c46ab1eafebcff0ad875acdd49d4e45
Author: Jan Holesovsky ke...@suse.cz
Date:   Wed Jan 25 12:35:29 2012 +0100

Add a note to the toplevel Makefile where to actually edit stuff.

diff --git a/Makefile b/Makefile
index 9f6c897..ed8e30e 100644
--- a/Makefile
+++ b/Makefile
@@ -26,6 +26,11 @@
 #
 #*
 
+# The real targets are in solenv/gbuild/Module.mk, resp.
+# solenv/gbuild/extensions/post_BuildplTargets.mk, this file only forwards
+# the calls - please look there if you want to edit what this toplevel
+# Makefile does.
+
 SRCDIR:=$(patsubst %/,%,$(dir $(realpath $(firstword $(MAKEFILE_LIST)
 
 ifeq ($(strip $(gb_SourceEnvAndRecurse_STAGE)),)
commit 1195d989d454a96e3b9fb0c0b6053db61b68f0b1
Author: Jan Holesovsky ke...@suse.cz
Date:   Wed Jan 25 12:34:56 2012 +0100

Allow killing 'make docs' by Ctrl-c.

diff --git a/solenv/bin/mkdocs.sh b/solenv/bin/mkdocs.sh
index 1112b0f..dbf4c46 100755
--- a/solenv/bin/mkdocs.sh
+++ b/solenv/bin/mkdocs.sh
@@ -89,7 +89,7 @@ do
   echo Ref-Tags:   $DOXYGEN_REF_TAGFILES
   echo Title:  $DOXYGEN_PROJECTNAME
 
-  nice -15 doxygen $DOXYGEN_CFG
+  nice -15 doxygen $DOXYGEN_CFG || exit 1
 
   # setup referenced tagfiles for next round
   DOXYGEN_REF_TAGFILES=$DOXYGEN_REF_TAGFILES 
$DOXYGEN_OUR_TAGFILE=$BASE_URL/$PROJECT/html
commit 315d2ddc161e4b296febe9e54c3cfc9270310bfe
Author: Tim Hardeck thard...@suse.com
Date:   Wed Jan 18 16:42:55 2012 +0100

optimized zoom to use more common intervals

Round zoom values beginning with 50 to a multiple of 5, with 100 to one
of 10, with 500 to one of 50 and with 1000 to one of 100.
The step 100 is enforced to have one fixed point.

diff --git a/basegfx/Library_basegfx.mk b/basegfx/Library_basegfx.mk
index fa0607b..fc6a479 100644
--- a/basegfx/Library_basegfx.mk
+++ b/basegfx/Library_basegfx.mk
@@ -66,6 +66,7 @@ $(eval $(call gb_Library_add_linked_libs,basegfx,\
 $(eval $(call gb_Library_add_exception_objects,basegfx,\
basegfx/source/tools/b2dclipstate \
basegfx/source/tools/canvastools \
+   basegfx/source/tools/zoomtools \
basegfx/source/tools/gradienttools \
basegfx/source/tools/keystoplerp \
basegfx/source/tools/liangbarsky \
diff --git a/basegfx/Package_inc.mk b/basegfx/Package_inc.mk
index 5767a8f..13b5ff8 100644
--- a/basegfx/Package_inc.mk
+++ b/basegfx/Package_inc.mk
@@ -37,6 +37,7 @@ $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/unopolypolygon.h
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/tools.hxx,basegfx/tools/tools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/unotools.hxx,basegfx/tools/unotools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/gradienttools.hxx,basegfx/tools/gradienttools.hxx))
+$(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tools/zoomtools.hxx,basegfx/tools/zoomtools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/numeric/ftools.hxx,basegfx/numeric/ftools.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tuple/b3i64tuple.hxx,basegfx/tuple/b3i64tuple.hxx))
 $(eval $(call 
gb_Package_add_file,basegfx_inc,inc/basegfx/tuple/b3dtuple.hxx,basegfx/tuple/b3dtuple.hxx))
diff --git a/basegfx/StaticLibrary_basegfx_s.mk 
b/basegfx/StaticLibrary_basegfx_s.mk
index 79d6ed9..69616f7 100644
--- a/basegfx/StaticLibrary_basegfx_s.mk
+++ b/basegfx/StaticLibrary_basegfx_s.mk
@@ -72,6 +72,7 @@ $(WORKDIR)/CustomTarget/basegfx/source/%.cxx : 
$(SRCDIR)/basegfx/source/%.cxx
 $(eval $(call gb_StaticLibrary_add_generated_exception_objects,basegfx_s,\
CustomTarget/basegfx/source/tools/liangbarsky \
CustomTarget/basegfx/source/tools/canvastools \
+   CustomTarget/basegfx/source/tools/zoomtools \
CustomTarget/basegfx/source/tools/gradienttools \
CustomTarget/basegfx/source/tools/keystoplerp \
CustomTarget/basegfx/source/tools/unopolypolygon \
diff --git a/basegfx/inc/basegfx/tools/zoomtools.hxx 
b/basegfx/inc/basegfx/tools/zoomtools.hxx
new file mode 100644
index 000..566418d
--- /dev/null
+++ b/basegfx/inc/basegfx/tools/zoomtools.hxx
@@ -0,0 +1,52 @@
+/* -*-

[Libreoffice-commits] .: canvas/source

2012-01-25 Thread David Tardon

 canvas/source/tools/spriteredrawmanager.cxx |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 259e0dfc293d455f1ea777de132730f7e5fde22d
Author: David Tardon dtar...@redhat.com
Date:   Wed Jan 25 12:34:23 2012 +0100

transparency gradient effect fade in is wrong (fdo#45219)

diff --git a/canvas/source/tools/spriteredrawmanager.cxx 
b/canvas/source/tools/spriteredrawmanager.cxx
index 91b81c5..72976c1 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -301,7 +301,8 @@ namespace canvas
aSortedSpriteVector.end(),
aUpdatableSprites.begin(),
aEnd,
-   ::std::back_insert_iterator VectorOfSprites 
(aUnchangedSprites) );
+   ::std::back_insert_iterator VectorOfSprites 
(aUnchangedSprites),
+   aSpriteComparator );
 
 // add each remaining unchanged sprite to connected ranges,
 // marked as don't need update
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5-0' - extensions/source scp2/source

 extensions/source/nsplugin/source/makefile.mk |4 
 scp2/source/ooo/common_brand.scp  |2 +-
 scp2/source/ooo/file_ooo.scp  |3 ---
 3 files changed, 1 insertion(+), 8 deletions(-)

New commits:
commit d4260355159afda5d91e9f9072e239ffe4ca7a2f
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date:   Wed Jan 25 10:20:07 2012 +0100

Fix building and packaging of the mozilla plugin

Signed-off-by: Tomas Chvatal tchva...@suse.cz
Signed-off-by: Rene Engelhard r...@debian.org
Signed-off-by: Thorsten Behrens tbehr...@suse.com

diff --git a/extensions/source/nsplugin/source/makefile.mk 
b/extensions/source/nsplugin/source/makefile.mk
index 3d52234..5b74764 100644
--- a/extensions/source/nsplugin/source/makefile.mk
+++ b/extensions/source/nsplugin/source/makefile.mk
@@ -36,8 +36,6 @@ USE_DEFFILE=TRUE
 
 .INCLUDE : settings.mk
 
-.IF $(WITH_MOZILLA) != NO
-
 .IF $(SYSTEM_MOZILLA_HEADERS) == YES
 INCPRE+=$(MOZILLA_HEADERS_CFLAGS)
 .ELSE
@@ -160,8 +158,6 @@ DEF2EXPORTFILE=exports.dxp
 DEF2EXPORTFILE=exports_wnt.dxp
 .ENDIF
 
-.ENDIF # $(WITH_MOZILLA) != NO
-
 # --- Targets --
 
 .INCLUDE : target.mk
diff --git a/scp2/source/ooo/common_brand.scp b/scp2/source/ooo/common_brand.scp
index 6c6fb66..aa8c77a 100644
--- a/scp2/source/ooo/common_brand.scp
+++ b/scp2/source/ooo/common_brand.scp
@@ -642,7 +642,7 @@ File gid_Brand_File_Bin_Libxml2
 End
 #endif
 
-#if !defined WITHOUT_MOZILLA  defined ENABLE_NSPLUGIN
+#ifdef ENABLE_NSPLUGIN
 File gid_Brand_File_Lib_Npsoplugin
 BIN_FILE_BODY;
 Name = SPECIAL_NAME(npsoplugin);
diff --git a/scp2/source/ooo/file_ooo.scp b/scp2/source/ooo/file_ooo.scp
index 091415b..e7bc85a 100644
--- a/scp2/source/ooo/file_ooo.scp
+++ b/scp2/source/ooo/file_ooo.scp
@@ -108,8 +108,6 @@ File gid_File_Basic_Tutorials
 Name = basicsrvtutorials.zip;
 End
 
-#ifndef WITHOUT_MOZILLA
-
 #ifdef ENABLE_NSPLUGIN
 File gid_File_Exe_Nsplugin
 BIN_FILE_BODY;
@@ -122,7 +120,6 @@ File gid_File_Exe_Nsplugin
   #endif
 End
 #endif
-#endif
 
 #if !defined(WITHOUT_MOZILLA)  defined(UNX)  !defined(QUARTZ)
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sc/source

2012-01-25 Thread Noel Power

 sc/source/ui/app/inputwin.cxx |   18 +++---
 sc/source/ui/inc/inputwin.hxx |2 ++
 2 files changed, 13 insertions(+), 7 deletions(-)

New commits:
commit 7580fff93292d08bc6f42792f256b832f5c4bad6
Author: Noel Power noel.po...@novell.com
Date:   Wed Jan 25 12:36:17 2012 +

fix initial height of multiline input window

There is a hardcoded preferred height for the input window that was getting 
picked up becuase the result of GetTextHeight was just '1' ( due to no font 
being set up ) We shouldn't use a hardcoded value, we should always use the 
proper text height e.g. the result of a successfull call to  GetTextHeight() ( 
the patch makes sure we get a decent result from this call )

diff --git a/sc/source/ui/app/inputwin.cxx b/sc/source/ui/app/inputwin.cxx
index 1ae727c..3771d37 100644
--- a/sc/source/ui/app/inputwin.cxx
+++ b/sc/source/ui/app/inputwin.cxx
@@ -1128,6 +1128,15 @@ ScMultiTextWnd::ScMultiTextWnd( ScInputBarGroup* pParen, 
ScTabViewShell* pViewSh
 mnLastExpandedLines( INPUTWIN_MULTILINES ),
 mbInvalidate( false )
 {
+// Calculate the text height, need to set a font for that. Probably we 
could set the font
+// here ( on this Window ) and avoid the temp Window. OTOH vcl is such a 
mystery I prefer
+// to minimise possible unexpected side-affects this way
+Window aTmp(this, WB_BORDER );
+aTmp.SetFont(aTextFont);
+mnTextHeight = LogicToPixel(Size(0,aTmp.GetTextHeight())).Height() ;
+Size aBorder;
+aBorder = CalcWindowSize( aBorder);
+mnBorderHeight = aBorder.Height();
 nTextStartPos = TEXT_MULTI_STARTPOS;
 }
 
@@ -1158,13 +1167,8 @@ EditView* ScMultiTextWnd::GetEditView()
 
 long ScMultiTextWnd::GetPixelHeightForLines( long nLines )
 {
-long height = ( LogicToPixel(Size(0,GetTextHeight())).Height() );
-// need to figure out why GetTextHeight is not set up when I need it
-// some initialisation timing issue ?
-height = Max ( long( 14 ), height );
-// add padding ( for the borders of the window I guess ) otherwise we
-// chop slightly the top and bottom of whatever is in the inputbox
-return ( nLines *  height ) + 4;
+// add padding ( for the borders of the window )
+return ( nLines *  mnTextHeight ) + mnBorderHeight;
 }
 
 void ScMultiTextWnd::SetNumLines( long nLines )
diff --git a/sc/source/ui/inc/inputwin.hxx b/sc/source/ui/inc/inputwin.hxx
index eec7fed..185ac45 100644
--- a/sc/source/ui/inc/inputwin.hxx
+++ b/sc/source/ui/inc/inputwin.hxx
@@ -204,6 +204,8 @@ private:
 ScInputBarGroup mrGroupBar;
 long mnLines;
 long mnLastExpandedLines;
+long mnTextHeight;
+long mnBorderHeight;
 bool mbInvalidate;
 };
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] Changes to 'feature/android'

New branch 'feature/android' available with the following commits:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/android' - android/qa

 android/qa/desktop/Makefile |   17 +
 1 file changed, 17 insertions(+)

New commits:
commit 3e52b896843ae0a9e137d4728e2ef73245e7e144
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 14:45:16 2012 +

android: add versionrc generation for desktop

diff --git a/android/qa/desktop/Makefile b/android/qa/desktop/Makefile
index 375bb82..1dd0d83 100644
--- a/android/qa/desktop/Makefile
+++ b/android/qa/desktop/Makefile
@@ -38,6 +38,7 @@ buildrcs:
echo OSL_SOCKET_PATH=$(APP_DATA_PATH)/files  
assets/program/lofficerc
 # - this looks useful but breaks more than it fixes ...
 #  echo DISABLE_EXTENSION_SYNCHRONIZATION=1  assets/program/lofficerc
+
 # fundamentalrc ini ...
echo [Bootstrap]  assets/program/fundamentalrc
echo LO_LIB_DIR=file://$(APP_DATA_PATH)/lib/  
assets/program/fundamentalrc
@@ -71,6 +72,22 @@ buildrcs:
echo ProductKey=LibreOffice 3.5  assets/program/bootstraprc
echo UserInstallation=file://$(APP_DATA_PATH)/files/.libreoffice  
assets/program/bootstraprc
 
+# versionrc ini ...
+   echo [Version]  assets/program/versionrc
+   echo AllLanguages=en-US  assets/program/versionrc
+   echo BuildVersion=  assets/program/versionrc
+   echo buildid=dead-beef  assets/program/versionrc
+   echo 
ExtensionUpdateURL=http://updateexte.libreoffice.org/ExtensionUpdateService/check.Update;
  assets/program/versionrc
+   echo ProductBuildid=3  assets/program/versionrc
+   echo ProductMajor=360  assets/program/versionrc
+   echo ProductMinor=1  assets/program/versionrc
+   echo ProductSource=OOO350  assets/program/versionrc
+   echo ReferenceOOoMajorMinor=3.6  assets/program/versionrc
+   echo UpdateID=LibreOffice_3_en-US  assets/program/versionrc
+   echo UpdateURL=  assets/program/versionrc
+   echo UpdateUserAgent=PRODUCT (${buildid}; ${_OS}; ${_ARCH}; 
BundledLanguages=${AllLanguages})  assets/program/versionrc
+   echo Vendor=SelfCompiledGit  assets/program/versionrc
+
 copy-stuff: buildrcs
 #
 # Copy shared libraries we need to libs/armeabi-v7a so that ant will
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/android' - sal/osl

 sal/osl/unx/security.c |   20 +++-
 1 file changed, 11 insertions(+), 9 deletions(-)

New commits:
commit fd268507704ba82af2abe4f5f777daf4c43d74fe
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 15:09:55 2012 +

android: cleanup osl security code for empty home / username fields

diff --git a/sal/osl/unx/security.c b/sal/osl/unx/security.c
index d73111c..96605fc 100644
--- a/sal/osl/unx/security.c
+++ b/sal/osl/unx/security.c
@@ -276,7 +276,7 @@ static sal_Bool SAL_CALL osl_psz_getUserName(oslSecurity 
Security, sal_Char* psz
 {
 oslSecurityImpl *pSecImpl = (oslSecurityImpl *)Security;
 
-if (pSecImpl == NULL)
+if (pSecImpl == NULL || pSecImpl-m_pPasswd.pw_name == NULL)
 return sal_False;
 
 strncpy(pszName, pSecImpl-m_pPasswd.pw_name, nMax);
@@ -364,14 +364,17 @@ static sal_Bool SAL_CALL osl_psz_getHomeDir(oslSecurity 
Security, sal_Char* pszD
 pStr = getenv(HOME);
 #endif
 
-if ((pStr != NULL)  (strlen(pStr)  0) 
-(access(pStr, 0) == 0))
+if (pStr != NULL  strlen(pStr)  0  access(pStr, 0) == 0)
 strncpy(pszDirectory, pStr, nMax);
-else
+else if (pSecImpl-m_pPasswd.pw_dir != NULL)
 strncpy(pszDirectory, pSecImpl-m_pPasswd.pw_dir, nMax);
+else
+return sal_False;
 }
-else
+else if (pSecImpl-m_pPasswd.pw_dir != NULL)
 strncpy(pszDirectory, pSecImpl-m_pPasswd.pw_dir, nMax);
+else
+return sal_False;
 
 return sal_True;
 }
@@ -403,8 +406,7 @@ static sal_Bool SAL_CALL osl_psz_getConfigDir(oslSecurity 
Security, sal_Char* ps
 {
 sal_Char *pStr = getenv(XDG_CONFIG_HOME);
 
-if ((pStr == NULL) || (strlen(pStr) == 0) ||
-(access(pStr, 0) != 0))
+if (pStr == NULL || strlen(pStr) == 0 || access(pStr, 0) != 0)
 {
 size_t n = 0;
 // a default equal to $HOME/.config should be used.
@@ -460,9 +462,9 @@ sal_Bool SAL_CALL osl_isAdministrator(oslSecurity Security)
 return sal_False;
 
 if (pSecImpl-m_pPasswd.pw_uid != 0)
-return (sal_False);
+return sal_False;
 
-return (sal_True);
+return sal_True;
 }
 
 void SAL_CALL osl_freeSecurityHandle(oslSecurity Security)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: sw/source

2012-01-25 Thread Miklos Vajna

 sw/source/filter/rtf/swparrtf.cxx |6 ++
 1 file changed, 6 insertions(+)

New commits:
commit bb147bbb801b53dba8928340df7e2aa2d4545349
Author: Miklos Vajna vmik...@frugalware.org
Date:   Wed Jan 25 16:33:25 2012 +0100

fdo#43869 use the old rtf importer for paste

diff --git a/sw/source/filter/rtf/swparrtf.cxx 
b/sw/source/filter/rtf/swparrtf.cxx
index 8099617..81abb16 100644
--- a/sw/source/filter/rtf/swparrtf.cxx
+++ b/sw/source/filter/rtf/swparrtf.cxx
@@ -34,6 +34,7 @@
 #include tools/stream.hxx
 #include svl/itemiter.hxx
 #include svtools/rtftoken.h
+#include svtools/miscopt.hxx
 #include svl/intitem.hxx
 #include editeng/fhgtitem.hxx
 #include editeng/ulspitem.hxx
@@ -161,6 +162,11 @@ sal_uLong SwRTFReader::Read( SwDoc rDoc, const String 
/*rBaseURL*/, SwPaM /*r
 
 extern C SAL_DLLPUBLIC_EXPORT Reader* SAL_CALL ImportRTF()
 {
+// Use the old rtf importer by default for paste, till the new one supports
+// undo stack and PaM.
+SvtMiscOptions aMiscOptions;
+if (!aMiscOptions.IsExperimentalMode())
+return new RtfReader();
 return new SwRTFReader();
 }
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: binfilter/bf_svtools

 binfilter/bf_svtools/source/misc/svt_ehdl.cxx |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 58f9f554d5fb9a3ca9a2b80038cdfa9d609a72d7
Author: CaolÃ¡n McNamara caol...@redhat.com
Date:   Tue Jan 24 20:57:51 2012 +

String(String

diff --git a/binfilter/bf_svtools/source/misc/svt_ehdl.cxx 
b/binfilter/bf_svtools/source/misc/svt_ehdl.cxx
index 4db63b8..5b14396 100644
--- a/binfilter/bf_svtools/source/misc/svt_ehdl.cxx
+++ b/binfilter/bf_svtools/source/misc/svt_ehdl.cxx
@@ -365,7 +365,7 @@ BOOL SfxErrorHandler::GetErrorString(
 SolarMutexGuard aGuard;
 
 BOOL bRet = FALSE;
-rStr=String(String(RTL_CONSTASCII_USTRINGPARAM($(CLASS)$(ERROR;
+rStr=rtl::OUString(RTL_CONSTASCII_USTRINGPARAM($(CLASS)$(ERROR)));
 ResId *pResId = new ResId(nId, *pMgr);
 
 {
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source

 sc/source/core/data/dpoutput.cxx |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit 6cc0bf1394ef9d6941d38a55a6155688a6f9bd43
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Tue Jan 24 16:32:10 2012 -0500

fdo#45067: Differentiate numeric and non-numeric field member values.

Signed-off-by: Petr Mladek pmla...@suse.cz

diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index 990e212..32179e3 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -795,10 +795,18 @@ void ScDPOutput::HeaderCell( SCCOL nCol, SCROW nRow, 
SCTAB nTab,
 
 if ( nFlags  sheet::MemberResultFlags::HASMEMBER )
 {
-// Avoid unwanted automatic format detection.
+bool bNumeric = (nFlags  sheet::MemberResultFlags::NUMERIC) != 0;
 ScSetStringParam aParam;
-aParam.mbDetectNumberFormat = false;
-aParam.mbSetTextCellFormat = true;
+if (bNumeric)
+{
+aParam.mbDetectNumberFormat = true;
+aParam.mbSetTextCellFormat = false;
+}
+else
+{
+aParam.mbDetectNumberFormat = false;
+aParam.mbSetTextCellFormat = true;
+}
 pDoc-SetString(nCol, nRow, nTab, rData.Caption, aParam);
 }
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 3 commits - postprocess/prj sal/android sal/inc sal/Package_inc.mk solenv/inc svx/source sw/source vcl/android vcl/inc

2012-01-25 Thread Tor Lillqvist

 postprocess/prj/build.lst|2 
 sal/Package_inc.mk   |2 
 sal/android/android_native_app_glue.c|   15 -
 sal/android/lo-bootstrap.c   |7 
 sal/inc/osl/detail/android.h |  352 ---
 sal/inc/osl/detail/android_native_app_glue.h |  349 ++
 solenv/inc/unxandr/lo-bootstrap.h|2 
 svx/source/stbctrls/zoomsliderctrl.cxx   |4 
 sw/source/ui/uiview/viewport.cxx |4 
 vcl/android/androidinst.cxx  |   14 -
 vcl/inc/android/androidinst.hxx  |1 
 11 files changed, 376 insertions(+), 376 deletions(-)

New commits:
commit f9c0e552355a0ae30ba75b427a3d8749ca8ebe9b
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Wed Jan 25 16:41:45 2012 +0200

Bin global_android_app and instead use lo-bootstrap API

Instead of introducing a global variable, use the already existing
saved android_app pointer in lo-bootstrap.c, and just add a function
to rettrieve that.

Reanme osl/detail/android.h back to android_native_app_glue.h, which
is the file from NDK/sources that it is. android.h sounded to me too
grand, as if it was some universal Android header. But if we do start
to modify the android_native_app_glue stuff heavily, then it indeed
makes sense to call it something else. Until then, revert also some
whitespace changes to android_native_app_glue.c for it to be as close
as possible to the upstream one in the NDK, for clarity.

diff --git a/sal/Package_inc.mk b/sal/Package_inc.mk
index d0520ef..e43de3e 100644
--- a/sal/Package_inc.mk
+++ b/sal/Package_inc.mk
@@ -64,7 +64,7 @@ $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/thread.hxx,osl/thread.hxx))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/time.h,osl/time.h))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/util.h,osl/util.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/file.h,osl/detail/file.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android.h,osl/detail/android.h))
+$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android_native_app_glue.h,osl/detail/android_native_app_glue.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/rtl/allocator.hxx,rtl/allocator.hxx))
 $(eval $(call gb_Package_add_file,sal_inc,inc/rtl/alloc.h,rtl/alloc.h))
 $(eval $(call gb_Package_add_file,sal_inc,inc/rtl/bootstrap.h,rtl/bootstrap.h))
diff --git a/sal/android/android_native_app_glue.c 
b/sal/android/android_native_app_glue.c
index efd7a4b..cf5d8e8 100644
--- a/sal/android/android_native_app_glue.c
+++ b/sal/android/android_native_app_glue.c
@@ -22,7 +22,7 @@
 #include unistd.h
 #include sys/resource.h
 
-#include osl/detail/android.h
+#include osl/detail/android_native_app_glue.h
 #include android/log.h
 
 #define LOGI(...) ((void)__android_log_print(ANDROID_LOG_INFO, threaded_app, 
__VA_ARGS__))
@@ -236,14 +236,9 @@ static void* android_app_entry(void* param) {
 // 
 
 static struct android_app* android_app_create(ANativeActivity* activity,
-void* savedState, size_t savedStateSize)
-{
+void* savedState, size_t savedStateSize) {
 struct android_app* android_app = (struct 
android_app*)malloc(sizeof(struct android_app));
 memset(android_app, 0, sizeof(struct android_app));
-
-// get this across to VCL.
-global_android_app = android_app;
-
 android_app-activity = activity;
 
 pthread_mutex_init(android_app-mutex, NULL);
@@ -419,13 +414,9 @@ static void onInputQueueDestroyed(ANativeActivity* 
activity, AInputQueue* queue)
 android_app_set_input((struct android_app*)activity-instance, NULL);
 }
 
-__attribute__ ((visibility(default))) struct android_app *global_android_app 
= NULL;
-
 __attribute__ ((visibility(default))) void 
ANativeActivity_onCreate(ANativeActivity* activity,
-void* savedState, size_t savedStateSize)
-{
+void* savedState, size_t savedStateSize) {
 LOGI(Creating: %p\n, activity);
-
 activity-callbacks-onDestroy = onDestroy;
 activity-callbacks-onStart = onStart;
 activity-callbacks-onResume = onResume;
diff --git a/sal/android/lo-bootstrap.c b/sal/android/lo-bootstrap.c
index bd90494..3cb8d3a 100644
--- a/sal/android/lo-bootstrap.c
+++ b/sal/android/lo-bootstrap.c
@@ -1470,6 +1470,13 @@ lo_get_javavm(void)
 }
 
 __attribute__ ((visibility(default)))
+struct android_app *
+lo_get_app(void)
+{
+return app;
+}
+
+__attribute__ ((visibility(default)))
 void
 android_main(struct android_app* state)
 {
diff --git a/sal/inc/osl/detail/android.h b/sal/inc/osl/detail/android.h
deleted file mode 100644
index beb5b1d..000
--- a/sal/inc/osl/detail/android.h
+++ /dev/null
@@ -1,352 +0,0 @@
-/*
- * Copyright (C) 2010 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the License);
- * you may not

[Libreoffice-commits] .: 3 commits - basctl/source cui/source dbaccess/source offapi/com officecfg/registry sw/source unotools/inc unotools/Library_utl.mk unotools/Package_inc.mk unotools/source

 basctl/source/basicide/baside2.hxx   |   24 -
 basctl/source/basicide/baside2b.cxx  |  108 +---
 cui/source/options/fontsubs.cxx  |   42 ++-
 cui/source/options/fontsubs.hxx  |7 
 dbaccess/source/ui/control/sqledit.cxx   |   86 +-
 dbaccess/source/ui/inc/sqledit.hxx   |   17 +
 offapi/com/sun/star/configuration/ReadOnlyAccess.idl |2 
 officecfg/registry/cppheader.xsl |   24 +
 sw/source/ui/docvw/srcedtw.cxx   |   84 +-
 sw/source/ui/inc/srcedtw.hxx |   23 +
 unotools/Library_utl.mk  |1 
 unotools/Package_inc.mk  |1 
 unotools/inc/unotools/configuration.hxx  |   48 +++
 unotools/inc/unotools/itemholderbase.hxx |1 
 unotools/inc/unotools/sourceviewconfig.hxx   |   62 
 unotools/source/config/configuration.cxx |   25 +
 unotools/source/config/itemholder1.cxx   |5 
 unotools/source/config/sourceviewconfig.cxx  |  242 ---
 18 files changed, 384 insertions(+), 418 deletions(-)

New commits:
commit a2195b2dc301a6c2cfd0bf1a7ff74483bcc5998a
Author: Stephan Bergmann sberg...@redhat.com
Date:   Wed Jan 25 18:18:18 2012 +0100

Replace SourceViewConfig with (simplified) direct configuration access.

diff --git a/basctl/source/basicide/baside2.hxx 
b/basctl/source/basicide/baside2.hxx
index 8d5aab9..a44e02b 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -50,6 +50,7 @@ class SvxSearchItem;
 
 #include sfx2/progress.hxx
 #include svtools/syntaxhighlight.hxx
+#include unotools/options.hxx
 
 #include breakpoint.hxx
 #include linenumberwindow.hxx
@@ -58,10 +59,9 @@ DBG_NAMEEX( ModulWindow )
 
 #define MARKER_NOMARKER 0x
 
-namespace utl
-{
-class SourceViewConfig;
-}
+namespace com { namespace sun { namespace star { namespace beans {
+class XMultiPropertySet;
+} } } }
 
 // #108672 Helper functions to get/set text in TextEngine
 // using the stream interface (get/setText() only supports
@@ -91,18 +91,19 @@ inline void ProgressInfo::StepProgress()
 SetState( ++nCurState );
 }
 
-
-namespace svt {
-class SourceViewConfig;
-}
-
-class EditorWindow : public Window, public SfxListener, public 
utl::ConfigurationListener
+class EditorWindow : public Window, public SfxListener
 {
 private:
+class ChangesListener;
+friend class ChangesListener;
+
 ExtTextView*pEditView;
 ExtTextEngine*  pEditEngine;
 
-utl::SourceViewConfig* pSourceViewConfig;
+rtl::Reference ChangesListener  listener_;
+osl::Mutex mutex_;
+com::sun::star::uno::Reference com::sun::star::beans::XMultiPropertySet 
+notifier_;
 
 longnCurTextWidth;
 
@@ -139,7 +140,6 @@ protected:
 virtual voidCommand( const CommandEvent rCEvt );
 virtual voidLoseFocus();
 virtual voidRequestHelp( const HelpEvent rHEvt );
-virtual voidConfigurationChanged( utl::ConfigurationBroadcaster*, 
sal_uInt32 );
 
 voidDoSyntaxHighlight( sal_uLong nPara );
 String  GetWordAtCursor();
diff --git a/basctl/source/basicide/baside2b.cxx 
b/basctl/source/basicide/baside2b.cxx
index 52f9752..101fcfd 100644
--- a/basctl/source/basicide/baside2b.cxx
+++ b/basctl/source/basicide/baside2b.cxx
@@ -40,8 +40,11 @@
 #include basic/sbmeth.hxx
 #include basic/sbuno.hxx
 #include com/sun/star/script/XLibraryContainer2.hpp
+#include com/sun/star/beans/XMultiPropertySet.hpp
+#include com/sun/star/beans/XPropertiesChangeListener.hpp
 #include comphelper/processfactory.hxx
 #include comphelper/string.hxx
+#include officecfg/Office/Common.hxx
 #include sfx2/dispatch.hxx
 #include sfx2/viewfrm.hxx
 #include vcl/msgbox.hxx
@@ -52,7 +55,6 @@
 #include svtools/textwindowpeer.hxx
 #include vcl/taskpanelist.hxx
 #include vcl/help.hxx
-#include unotools/sourceviewconfig.hxx
 
 using namespace ::com::sun::star;
 using namespace ::com::sun::star::uno;
@@ -147,6 +149,30 @@ void lcl_SeparateNameAndIndex( const String rVName, 
String rVar, String rInde
 }
 }
 
+class EditorWindow::ChangesListener:
+public cppu::WeakImplHelper1 beans::XPropertiesChangeListener 
+{
+public:
+ChangesListener(EditorWindow  editor): editor_(editor) {}
+
+private:
+virtual ~ChangesListener() {}
+
+virtual void disposing(lang::EventObject const ) throw (RuntimeException)
+{
+osl::MutexGuard g(editor_.mutex_);
+editor_.notifier_.clear();
+}
+
+virtual void propertiesChange(
+Sequence beans::PropertyChangeEvent  const ) throw 
(RuntimeException)
+{
+SolarMutexGuard g;
+editor_.ImplSetFont();
+}
+
+EditorWindow  editor_;
+};
 
 EditorWindow::EditorWindow( Window* pParent ) :
 Window( pParent, WB_BORDER )
@@ -156,7 +182,6 @@ EditorWindow::EditorWindow(

[Libreoffice-commits] .: sc/qa

2012-01-25 Thread Kohei Yoshida

 sc/qa/unit/ucalc.cxx |   96 +--
 1 file changed, 94 insertions(+), 2 deletions(-)

New commits:
commit 85d34beec5f8196896487c96028b2dc2ce3cf6c8
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Wed Jan 25 12:50:54 2012 -0500

New unit test for pivot table's date output handling.

We rely on the cell type of those date value outputs when grouping
by date or value range.

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 7f5f143..ec31a04 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -130,6 +130,13 @@ public:
 void testPivotTableLabels();
 
 /**
+ * Make sure that we set cells displaying date values numeric cells,
+ * rather than text cells.  Grouping by date or number functionality
+ * depends on this.
+ */
+void testPivotTableDateLabels();
+
+/**
  * Test for pivot table's filtering functionality by page fields.
  */
 void testPivotTableFilters();
@@ -190,6 +197,7 @@ public:
 CPPUNIT_TEST(testMatrix);
 CPPUNIT_TEST(testPivotTable);
 CPPUNIT_TEST(testPivotTableLabels);
+CPPUNIT_TEST(testPivotTableDateLabels);
 CPPUNIT_TEST(testPivotTableFilters);
 CPPUNIT_TEST(testPivotTableNamedSource);
 CPPUNIT_TEST(testSheetCopy);
@@ -1144,13 +1152,13 @@ bool checkDPTableOutput(ScDocument* pDoc, const 
ScRange aOutRange, const char*
 bool bEqual = aCheckVal.equals(aVal);
 if (!bEqual)
 {
-cerr  Expected:   aCheckValActual:   aVal 
 endl;
+cout  Expected:   aCheckValActual:   aVal 
 endl;
 bResult = false;
 }
 }
 else if (!aVal.isEmpty())
 {
-cerr  Empty cell expected  endl;
+cout  Empty cell expected  endl;
 bResult = false;
 }
 }
@@ -1476,6 +1484,90 @@ void Test::testPivotTableLabels()
 CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
 }
 
+pDPs-FreeTable(pDPObj);
+
+m_pDoc-DeleteTab(1);
+m_pDoc-DeleteTab(0);
+}
+
+void Test::testPivotTableDateLabels()
+{
+m_pDoc-InsertTab(0, OUString(RTL_CONSTASCII_USTRINGPARAM(Data)));
+m_pDoc-InsertTab(1, OUString(RTL_CONSTASCII_USTRINGPARAM(Table)));
+
+// Dimension definition
+DPFieldDef aFields[] = {
+{ Name,  sheet::DataPilotFieldOrientation_ROW },
+{ Date,  sheet::DataPilotFieldOrientation_COLUMN },
+{ Value, sheet::DataPilotFieldOrientation_DATA }
+};
+
+// Raw data
+const char* aData[][3] = {
+{ Zena,   2011-1-1, 30 },
+{ Yodel,  2011-1-2, 20 },
+{ Xavior, 2011-1-3, 45 }
+};
+
+size_t nFieldCount = SAL_N_ELEMENTS(aFields);
+size_t nDataCount = SAL_N_ELEMENTS(aData);
+
+ScRange aSrcRange = insertDPSourceData(m_pDoc, aFields, nFieldCount, 
aData, nDataCount);
+SCROW nRow1 = aSrcRange.aStart.Row(), nRow2 = aSrcRange.aEnd.Row();
+SCCOL nCol1 = aSrcRange.aStart.Col(), nCol2 = aSrcRange.aEnd.Col();
+
+ScDPObject* pDPObj = createDPFromRange(
+m_pDoc, ScRange(nCol1, nRow1, 0, nCol2, nRow2, 0), aFields, 
nFieldCount, false);
+
+ScDPCollection* pDPs = m_pDoc-GetDPCollection();
+bool bSuccess = pDPs-InsertNewTable(pDPObj);
+CPPUNIT_ASSERT_MESSAGE(failed to insert a new datapilot object into 
document, bSuccess);
+CPPUNIT_ASSERT_MESSAGE(there should be only one data pilot table.,
+   pDPs-GetCount() == 1);
+pDPObj-SetName(pDPs-CreateNewName());
+
+bool bOverFlow = false;
+ScRange aOutRange = pDPObj-GetNewOutputRange(bOverFlow);
+CPPUNIT_ASSERT_MESSAGE(Table overflow!?, !bOverFlow);
+
+pDPObj-Output(aOutRange.aStart);
+aOutRange = pDPObj-GetOutRange();
+
+{
+// Expected output table content.  0 = empty cell
+const char* aOutputCheck[][5] = {
+{ Sum - Value, Date, 0, 0, 0 },
+{ Name, 2011-01-01, 2011-01-02, 2011-01-03, Total Result 
},
+{ Xavior,  0, 0, 45, 45 },
+{ Yodel,  0, 20, 0, 20 },
+{ Zena,  30, 0, 0, 30 },
+{ Total Result, 30, 20, 45, 95 }
+};
+
+bSuccess = checkDPTableOutput5(m_pDoc, aOutRange, aOutputCheck, 
DataPilot table output);
+CPPUNIT_ASSERT_MESSAGE(Table output check failed, bSuccess);
+}
+
+{
+const char* aChecks[] = {
+2011-01-01, 2011-01-02, 2011-01-03
+};
+
+// Make sure those cells that contain dates are numeric.
+SCROW nRow = aOutRange.aStart.Row() + 1;
+nCol1 = aOutRange.aStart.Col() + 1;
+nCol2 = nCol1 + 2;
+for (SCCOL nCol = nCol1; nCol = nCol2; ++nCol)
+{
+OUString aVal = m_pDoc-GetString(nCol, nRow, 1);
+CPPUNIT_ASSERT_MESSAGE(Cell value is not as expected., 
aVal.equalsAscii(aChecks[nCol-nCol1]));
+

[Libreoffice-commits] .: basctl/source basic/source sc/source sw/source

2012-01-25 Thread Takeshi Abe

 basctl/source/dlged/managelang.cxx |3 +--
 basctl/source/dlged/propbrw.cxx|3 +--
 basic/source/classes/sbxmod.cxx|   11 ---
 basic/source/sbx/sbxbase.cxx   |3 +--
 sc/source/core/data/column.cxx |2 +-
 sc/source/core/data/documen3.cxx   |3 +--
 sc/source/core/data/table4.cxx |3 +--
 sw/source/core/text/itrform2.cxx   |3 +--
 sw/source/core/txtnode/atrfld.cxx  |3 +--
 sw/source/ui/docvw/edtwin.cxx  |8 ++--
 10 files changed, 14 insertions(+), 28 deletions(-)

New commits:
commit bb51e8e72be424f0fd92350006c536a97fd4b210
Author: Takeshi Abe t...@fixedpoint.jp
Date:   Thu Jan 26 01:02:30 2012 +0900

Deleting a null pointer is safe

diff --git a/basctl/source/dlged/managelang.cxx 
b/basctl/source/dlged/managelang.cxx
index eb16d60..58fd948 100644
--- a/basctl/source/dlged/managelang.cxx
+++ b/basctl/source/dlged/managelang.cxx
@@ -197,8 +197,7 @@ void ManageLanguageDialog::ClearLanguageBox()
 for ( i = 0; i  nCount; ++i )
 {
 LanguageEntry* pEntry = (LanguageEntry*)( 
m_aLanguageLB.GetEntryData(i) );
-if ( pEntry )
-delete pEntry;
+delete pEntry;
 }
 m_aLanguageLB.Clear();
 }
diff --git a/basctl/source/dlged/propbrw.cxx b/basctl/source/dlged/propbrw.cxx
index 5ee9c28..4e1f90f 100644
--- a/basctl/source/dlged/propbrw.cxx
+++ b/basctl/source/dlged/propbrw.cxx
@@ -308,8 +308,7 @@ Sequence Reference XInterface  
 // next element
 pCurrent = pGroupIterator  pGroupIterator-IsMore() ? 
pGroupIterator-Next() : NULL;
 }
-if (pGroupIterator)
-delete pGroupIterator;
+delete pGroupIterator;
 }
 
 sal_Int32 nCount = aInterfaces.size();
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index d61b63c..40ae0d7 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -541,13 +541,10 @@ SbModule::SbModule( const String rName,  sal_Bool 
bVBACompat )
 SbModule::~SbModule()
 {
 OSL_TRACE(Module named %s is destructing, rtl::OUStringToOString( 
GetName(), RTL_TEXTENCODING_UTF8 ).getStr() );
-if( pImage )
-delete pImage;
-if( pBreaks )
-delete pBreaks;
-if( pClassData )
-delete pClassData;
-mxWrapper = NULL;
+delete pImage;
+delete pBreaks;
+delete pClassData;
+mxWrapper = NULL;
 }
 
 uno::Reference script::XInvocation 
diff --git a/basic/source/sbx/sbxbase.cxx b/basic/source/sbx/sbxbase.cxx
index 303f382..e2987d0 100644
--- a/basic/source/sbx/sbxbase.cxx
+++ b/basic/source/sbx/sbxbase.cxx
@@ -55,8 +55,7 @@ SbxAppData GetSbxData_Impl()
 
 SbxAppData::~SbxAppData()
 {
-if( pBasicFormater )
-delete pBasicFormater;
+delete pBasicFormater;
 }
 
 
diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx
index 6c1c849..50f0e95 100644
--- a/sc/source/core/data/column.cxx
+++ b/sc/source/core/data/column.cxx
@@ -93,7 +93,7 @@ ScColumn::ScColumn() :
 ScColumn::~ScColumn()
 {
 FreeAll();
-if (pAttrArray) delete pAttrArray;
+delete pAttrArray;
 }
 
 
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index 66973de..991eb6b 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -273,8 +273,7 @@ void ScDocument::SetDBCollection( ScDBCollection* 
pNewDBCollection, bool bRemove
 }
 }
 
-if (pDBCollection)
-delete pDBCollection;
+delete pDBCollection;
 
 pDBCollection = pNewDBCollection;
 }
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index bc99c5c..dac4111 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -564,8 +564,7 @@ void ScTable::FillAuto( SCCOL nCol1, SCROW nRow1, SCCOL 
nCol2, SCROW nRow2,
 {
 if ( bGetPattern )
 {
-if ( pNewPattern )
-delete pNewPattern;
+delete pNewPattern;
 if (bVertical)  // rInner:=nRow, rOuter:=nCol
 pSrcPattern = 
aCol[nCol].GetPattern(static_castSCROW(nAtSrc));
 else// rInner:=nCol, rOuter:=nRow
diff --git a/sw/source/core/text/itrform2.cxx b/sw/source/core/text/itrform2.cxx
index 54a7825..b46d5b8 100644
--- a/sw/source/core/text/itrform2.cxx
+++ b/sw/source/core/text/itrform2.cxx
@@ -1629,8 +1629,7 @@ xub_StrLen SwTxtFormatter::FormatLine( const xub_StrLen 
nStartPos )
 GetInfo().GetParaPortion()-GetReformat()-LeftMove( GetInfo().GetIdx() );
 
 // delete master copy of rest portion
-if ( pSaveFld )
-delete pSaveFld;
+delete pSaveFld;
 
 xub_StrLen nNewStart = nStartPos + pCurr-GetLen();
 
diff --git a/sw/source/core/txtnode/atrfld.cxx 
b/sw/source/core/txtnode/atrfld.cxx
index 4789c5f..dc285ef 100644
--- a/sw/source/core/txtnode/atrfld.cxx
+++ b/sw/source/core/txtnode/atrfld.cxx
@@ -134,8 +134,7 @@ void

[Libreoffice-commits] .: set_soenv.in

2012-01-25 Thread François Tigeot

 set_soenv.in |3 +++
 1 file changed, 3 insertions(+)

New commits:
commit a79889083b25d69ae6b801ed8cee90b5dd9199c4
Author: FranÃ§ois Tigeot ftig...@wolfpond.org
Date:   Wed Jan 25 18:50:35 2012 +0100

Ensure Env.Host.sh always return a zero exit code

* On some NetBSD systems, the last unset command returns a
  non-zero exit code

* This made the make(1) processes terminate immediately in
  source-env-and-recurse, breaking the build.

Reported by: Thomas Klausner w...@netbsd.org

diff --git a/set_soenv.in b/set_soenv.in
index 53b388f..704378d 100755
--- a/set_soenv.in
+++ b/set_soenv.in
@@ -1102,6 +1102,9 @@ ToFile( ENV_SCRIPT, $outfile, e );
 #
 print OUT export $exportvars$newline;
 print OUT unset $unsetvars$newline;
+# unset may return a non-zero value and make the initial
+# make(1) processes terminate with an error
+print OUT true $newline;
 
 #
 #---
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/android' - 3 commits - postprocess/prj sal/android sal/inc sal/Package_inc.mk solenv/inc svx/source sw/source vcl/android vcl/inc

2012-01-25 Thread Tor Lillqvist

 postprocess/prj/build.lst|2 
 sal/Package_inc.mk   |2 
 sal/android/android_native_app_glue.c|   15 -
 sal/android/lo-bootstrap.c   |7 
 sal/inc/osl/detail/android.h |  352 ---
 sal/inc/osl/detail/android_native_app_glue.h |  349 ++
 solenv/inc/unxandr/lo-bootstrap.h|2 
 svx/source/stbctrls/zoomsliderctrl.cxx   |4 
 sw/source/ui/uiview/viewport.cxx |4 
 vcl/android/androidinst.cxx  |   37 +-
 vcl/inc/android/androidinst.hxx  |1 
 11 files changed, 387 insertions(+), 388 deletions(-)

New commits:
commit 25f78344e8dea95cedb0b981f08865d676154e5b
Author: Tor Lillqvist tlillqv...@suse.com
Date:   Wed Jan 25 16:41:45 2012 +0200

Bin global_android_app and instead use lo-bootstrap API

Instead of introducing a global variable, use the already existing
saved android_app pointer in lo-bootstrap.c, and just add a function
to retrieve it from there. Store it in the AndroidSalInstance.

Reanme osl/detail/android.h back to android_native_app_glue.h, which
is the name of that file in NDK/sources. android.h sounded to me too
grand, as if it was some universal Android header. But if we do start
to modify the android_native_app_glue stuff heavily, then it indeed
makes sense to call it something else. Until then, revert also some
whitespace changes to android_native_app_glue.c for it to be as close
as possible to the upstream one in the NDK, for clarity.

diff --git a/sal/Package_inc.mk b/sal/Package_inc.mk
index d0520ef..e43de3e 100644
--- a/sal/Package_inc.mk
+++ b/sal/Package_inc.mk
@@ -64,7 +64,7 @@ $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/thread.hxx,osl/thread.hxx))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/time.h,osl/time.h))
 $(eval $(call gb_Package_add_file,sal_inc,inc/osl/util.h,osl/util.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/file.h,osl/detail/file.h))
-$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android.h,osl/detail/android.h))
+$(eval $(call 
gb_Package_add_file,sal_inc,inc/osl/detail/android_native_app_glue.h,osl/detail/android_native_app_glue.h))
 $(eval $(call 
gb_Package_add_file,sal_inc,inc/rtl/allocator.hxx,rtl/allocator.hxx))
 $(eval $(call gb_Package_add_file,sal_inc,inc/rtl/alloc.h,rtl/alloc.h))
 $(eval $(call gb_Package_add_file,sal_inc,inc/rtl/bootstrap.h,rtl/bootstrap.h))
diff --git a/sal/android/android_native_app_glue.c 
b/sal/android/android_native_app_glue.c
index efd7a4b..cf5d8e8 100644
--- a/sal/android/android_native_app_glue.c
+++ b/sal/android/android_native_app_glue.c
@@ -22,7 +22,7 @@
 #include unistd.h
 #include sys/resource.h
 
-#include osl/detail/android.h
+#include osl/detail/android_native_app_glue.h
 #include android/log.h
 
 #define LOGI(...) ((void)__android_log_print(ANDROID_LOG_INFO, threaded_app, 
__VA_ARGS__))
@@ -236,14 +236,9 @@ static void* android_app_entry(void* param) {
 // 
 
 static struct android_app* android_app_create(ANativeActivity* activity,
-void* savedState, size_t savedStateSize)
-{
+void* savedState, size_t savedStateSize) {
 struct android_app* android_app = (struct 
android_app*)malloc(sizeof(struct android_app));
 memset(android_app, 0, sizeof(struct android_app));
-
-// get this across to VCL.
-global_android_app = android_app;
-
 android_app-activity = activity;
 
 pthread_mutex_init(android_app-mutex, NULL);
@@ -419,13 +414,9 @@ static void onInputQueueDestroyed(ANativeActivity* 
activity, AInputQueue* queue)
 android_app_set_input((struct android_app*)activity-instance, NULL);
 }
 
-__attribute__ ((visibility(default))) struct android_app *global_android_app 
= NULL;
-
 __attribute__ ((visibility(default))) void 
ANativeActivity_onCreate(ANativeActivity* activity,
-void* savedState, size_t savedStateSize)
-{
+void* savedState, size_t savedStateSize) {
 LOGI(Creating: %p\n, activity);
-
 activity-callbacks-onDestroy = onDestroy;
 activity-callbacks-onStart = onStart;
 activity-callbacks-onResume = onResume;
diff --git a/sal/android/lo-bootstrap.c b/sal/android/lo-bootstrap.c
index bd90494..3cb8d3a 100644
--- a/sal/android/lo-bootstrap.c
+++ b/sal/android/lo-bootstrap.c
@@ -1470,6 +1470,13 @@ lo_get_javavm(void)
 }
 
 __attribute__ ((visibility(default)))
+struct android_app *
+lo_get_app(void)
+{
+return app;
+}
+
+__attribute__ ((visibility(default)))
 void
 android_main(struct android_app* state)
 {
diff --git a/sal/inc/osl/detail/android.h b/sal/inc/osl/detail/android.h
deleted file mode 100644
index beb5b1d..000
--- a/sal/inc/osl/detail/android.h
+++ /dev/null
@@ -1,352 +0,0 @@
-/*
- * Copyright (C) 2010 The Android Open Source Project
- *
- * Licensed under the Apache License,

[Libreoffice-commits] .: Branch 'libreoffice-3-4' - filter/source

 filter/source/msfilter/msdffimp.cxx |   20 +---
 1 file changed, 13 insertions(+), 7 deletions(-)

New commits:
commit 3475d300ef29866542007e295569075e592bde66
Author: Ivan Timofeev timofeev@gmail.com
Date:   Wed Jan 25 20:54:27 2012 +0100

fdo#43193: fix rotation of shapes in imported MS documents

Signed-off-by: Petr Mladek pmla...@suse.cz

diff --git a/filter/source/msfilter/msdffimp.cxx 
b/filter/source/msfilter/msdffimp.cxx
index 5764c66..784b5a0 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -4643,6 +4643,8 @@ SdrObject* SvxMSDffManager::ImportGroup( const 
DffRecordHeader rHd, SvStream r
 rSt  aRecHd;
 if ( aRecHd.nRecType == DFF_msofbtSpContainer )
 {
+sal_Int32 nGroupRotateAngle = 0;
+sal_Int32 nSpFlags = 0;
 mnFix16Angle = 0;
 
 aRecHd.SeekToBegOfRecord(rSt);
@@ -4650,15 +4652,19 @@ SdrObject* SvxMSDffManager::ImportGroup( const 
DffRecordHeader rHd, SvStream r
 pRet = ImportObj( rSt, pClientData, rClientRect, rGlobalChildRect, 
nCalledByGroup + 1, pShapeId );
 if ( pRet )
 {
+nSpFlags = nGroupShapeFlags;
+nGroupRotateAngle = mnFix16Angle;
+
 Rectangle aClientRect( rClientRect );
+
 Rectangle aGlobalChildRect;
 if ( !nCalledByGroup || rGlobalChildRect.IsEmpty() )
 aGlobalChildRect = GetGlobalChildAnchor( rHd, rSt, aClientRect 
);
 else
 aGlobalChildRect = rGlobalChildRect;
 
-if ( ( mnFix16Angle  4500  mnFix16Angle = 13500 )
-|| ( mnFix16Angle  22500  mnFix16Angle = 31500 ) )
+if ( ( nGroupRotateAngle  4500  nGroupRotateAngle = 13500 )
+|| ( nGroupRotateAngle  22500  nGroupRotateAngle = 31500 ) 
)
 {
 sal_Int32 nHalfWidth = ( aClientRect.GetWidth() + 1 )  1;
 sal_Int32 nHalfHeight = ( aClientRect.GetHeight() + 1 )  1;
@@ -4704,18 +4710,18 @@ SdrObject* SvxMSDffManager::ImportGroup( const 
DffRecordHeader rHd, SvStream r
 aRecHd2.SeekToEndOfRecord( rSt );
 }
 
-if ( mnFix16Angle )
+if ( nGroupRotateAngle )
 {
-double a = mnFix16Angle * nPi180;
-pRet-NbcRotate( aClientRect.Center(), mnFix16Angle, sin( a ), 
cos( a ) );
+double a = nGroupRotateAngle * nPi180;
+pRet-NbcRotate( aClientRect.Center(), nGroupRotateAngle, sin( 
a ), cos( a ) );
 }
-if ( nGroupShapeFlags  SP_FFLIPV )// Vertical 
flip?
+if ( nSpFlags  SP_FFLIPV ) // Vertical flip?
 {  // BoundRect in aBoundRect
 Point aLeft( aClientRect.Left(), ( aClientRect.Top() + 
aClientRect.Bottom() )  1 );
 Point aRight( aLeft.X() + 1000, aLeft.Y() );
 pRet-NbcMirror( aLeft, aRight );
 }
-if ( nGroupShapeFlags  SP_FFLIPH )// Horizontal 
flip?
+if ( nSpFlags  SP_FFLIPH ) // Horizontal flip?
 {  // BoundRect in aBoundRect
 Point aTop( ( aClientRect.Left() + aClientRect.Right() )  1, 
aClientRect.Top() );
 Point aBottom( aTop.X(), aTop.Y() + 1000 );
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: 6 commits - sc/CppunitTest_sc_tablesheetobj.mk sc/CppunitTest_sc_tablesheetsobj.mk sc/qa sc/source test/inc test/Library_subsequenttest.mk test/Package_inc.mk test/source

 sc/CppunitTest_sc_tablesheetobj.mk |  140 +
 sc/CppunitTest_sc_tablesheetsobj.mk|   20 +--
 sc/qa/extras/scdatapilottableobj.cxx   |   16 ++
 sc/qa/extras/sctablesheetobj.cxx   |   87 +++
 sc/qa/extras/testdocuments/ScTableSheetObj.ods |binary
 sc/qa/unoapi/knownissues.xcl   |   13 ++
 sc/source/ui/unoobj/cellsuno.cxx   |4 
 test/Library_subsequenttest.mk |2 
 test/Package_inc.mk|2 
 test/inc/test/container/xnamed.hxx |   53 +
 test/inc/test/util/xsearchable.hxx |   55 +
 test/source/container/xnamed.cxx   |   58 ++
 test/source/util/xsearchable.cxx   |   79 ++
 13 files changed, 514 insertions(+), 15 deletions(-)

New commits:
commit 3e82bf0e5e6a1d5dcbe6b7ebbbe124912e8e8700
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date:   Wed Jan 25 21:01:06 2012 +0100

add test for ScTableSheetObj

diff --git a/sc/CppunitTest_sc_tablesheetobj.mk 
b/sc/CppunitTest_sc_tablesheetobj.mk
new file mode 100644
index 000..9ccd9c8
--- /dev/null
+++ b/sc/CppunitTest_sc_tablesheetobj.mk
@@ -0,0 +1,140 @@
+# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*-
+#*
+# Version: MPL 1.1 / GPLv3+ / LGPLv3+
+#
+# The contents of this file are subject to the Mozilla Public License Version
+# 1.1 (the License); you may not use this file except in compliance with
+# the License or as specified alternatively below. You may obtain a copy of
+# the License at http://www.mozilla.org/MPL/
+#
+# Software distributed under the License is distributed on an AS IS basis,
+# WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
+# for the specific language governing rights and limitations under the
+# License.
+#
+# The Initial Developer of the Original Code is
+#   Markus Mohrhard markus.mohrh...@googlemail.com
+# Portions created by the Initial Developer are Copyright (C) 2011 the
+# Initial Developer. All Rights Reserved.
+#
+# Major Contributor(s):
+#
+# For minor contributions see the git repository.
+#
+# Alternatively, the contents of this file may be used under the terms of
+# either the GNU General Public License Version 3 or later (the GPLv3+), or
+# the GNU Lesser General Public License Version 3 or later (the LGPLv3+),
+# in which case the provisions of the GPLv3+ or the LGPLv3+ are applicable
+# instead of those above.
+#*
+
+$(eval $(call gb_CppunitTest_CppunitTest,sc_spreadsheetobj))
+
+$(eval $(call gb_CppunitTest_add_exception_objects,sc_spreadsheetobj, \
+sc/qa/extras/sctablesheetobj \
+))
+
+$(eval $(call gb_CppunitTest_add_linked_libs,sc_spreadsheetobj, \
+avmedia \
+basegfx \
+comphelper \
+cppu \
+cppuhelper \
+drawinglayer \
+editeng \
+fileacc \
+for \
+forui \
+i18nisolang1 \
+msfilter \
+oox \
+sal \
+salhelper \
+sax \
+sb \
+sc \
+sfx \
+sot \
+subsequenttest \
+svl \
+svt \
+svx \
+svxcore \
+   test \
+tl \
+tk \
+ucbhelper \
+   unotest \
+utl \
+vbahelper \
+vcl \
+xo \
+   $(gb_STDLIBS) \
+))
+
+$(eval $(call gb_CppunitTest_set_include,sc_spreadsheetobj,\
+-I$(realpath $(SRCDIR)/sc/source/ui/inc) \
+-I$(realpath $(SRCDIR)/sc/inc) \
+$$(INCLUDE) \
+-I$(OUTDIR)/inc \
+))
+
+$(eval $(call gb_CppunitTest_add_api,sc_spreadsheetobj,\
+offapi \
+udkapi \
+))
+
+$(eval $(call gb_CppunitTest_uses_ure,sc_spreadsheetobj))
+
+$(eval $(call gb_CppunitTest_add_type_rdbs,sc_spreadsheetobj,\
+types \
+))
+
+$(eval $(call gb_CppunitTest_add_components,sc_spreadsheetobj,\
+basic/util/sb \
+comphelper/util/comphelp \
+configmgr/source/configmgr \
+dbaccess/util/dba \
+fileaccess/source/fileacc \
+filter/source/config/cache/filterconfig1 \
+forms/util/frm \
+framework/util/fwk \
+i18npool/util/i18npool \
+i18npool/source/search/i18nsearch \
+oox/util/oox \
+package/source/xstor/xstor \
+package/util/package2 \
+sax/source/expatwrap/expwrap \
+sax/source/fastparser/fastsax \
+sc/util/sc \
+sc/util/scd \
+sc/util/scfilt \
+sc/util/vbaobj \
+scripting/source/basprov/basprov \
+scripting/util/scriptframe \
+sfx2/util/sfx \
+sot/util/sot \
+svl/source/fsstor/fsstorage \
+toolkit/util/tk \
+ucb/source/core/ucb1 \
+ucb/source/ucp/file/ucpfile1 \
+ucb/source/ucp/tdoc/ucptdoc1 \
+unotools/util/utl \
+unoxml/source/rdf/unordf \
+unoxml/source/service/unoxml \
+))
+
+$(eval $(call gb_CppunitTest_set_args,sc_spreadsheetobj,\
+--headless \
+--protector unoexceptionprotector$(gb_Library_DLLEXT)

[Libreoffice-commits] .: Branch 'feature/android' - 2 commits - sal/android sal/Library_lo-bootstrap.mk vcl/android

 sal/Library_lo-bootstrap.mk |5 +
 sal/android/lo-bootstrap.c  |8 +-
 vcl/android/androidinst.cxx |  161 +---
 3 files changed, 118 insertions(+), 56 deletions(-)

New commits:
commit b3904a718bbf278034afb231df3473e7138b05ac
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 21:07:24 2012 +

android: move event handling to members of SalInstance

rename app - mpApp and initial handling of frames, we will need
a mini window-manager in here, most likely.

diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx
index e6df7fb..b4ea9e0 100644
--- a/vcl/android/androidinst.cxx
+++ b/vcl/android/androidinst.cxx
@@ -30,13 +30,19 @@
 #include headless/svpdummies.hxx
 #include generic/gendata.hxx
 #include android/log.h
-#include android/input.h
 #include android/looper.h
-#include android/native_window.h
 #include lo-bootstrap.h
 #include osl/detail/android_native_app_glue.h
 #include rtl/strbuf.hxx
 
+class AndroidSalData : public SalGenericData
+{
+public:
+AndroidSalData( SalInstance *pInstance ) : SalGenericData( 
SAL_DATA_ANDROID, pInstance ) {}
+virtual void ErrorTrapPush() {}
+virtual bool ErrorTrapPop( bool ) { return false; }
+};
+
 static rtl::OString MotionEdgeFlagsToString(int32_t nFlags)
 {
 rtl::OStringBuffer aStr;
@@ -67,13 +73,62 @@ static rtl::OString KeyMetaStateToString(int32_t nFlags)
 return aStr.makeStringAndClear();
 }
 
-int32_t AMotionEvent_getEdgeFlags(const AInputEvent* motion_event);
+static void BlitFrameRegionToWindow(ANativeWindow *pWindow,
+const basebmp::BitmapDeviceSharedPtr /* 
aDev */,
+const ARect aSrcRect,
+int nDestX, int nDestY)
+{
+fprintf (stderr, Blit frame src %d,%d-%d,%d to positoon %d, %d\n,
+ aSrcRect.left, aSrcRect.top, aSrcRect.right, aSrcRect.bottom,
+ nDestX, nDestY);
+#if 1
+ARect aRect;
+ANativeWindow_Buffer aBuffer;
+memset ((void *)aBuffer, 0, sizeof (aBuffer));
+int32_t nRet = ANativeWindow_lock(pWindow, aBuffer, aRect);
+fprintf (stderr, locked window %d returned rect: %d,%d-%d,%d 
+ buffer: %dx%d stride %d, format %d, bits %p\n,
+ nRet, aRect.left, aRect.top, aRect.right, aRect.bottom,
+ aBuffer.width, aBuffer.height, aBuffer.stride,
+ aBuffer.format, aBuffer.bits);
+if (aBuffer.bits)
+{
+// hard-code / guess at a format ...
+int32_t *p = (int32_t *)aBuffer.bits;
+for (int32_t y = 0; y  aBuffer.height; y++)
+{
+for (int32_t x = 0; x  aBuffer.stride / 4; x++)
+*p++ = (y  24) + x;
+}
+}
+ANativeWindow_unlockAndPost(pWindow);
+fprintf (stderr, done render!\n);
+#endif
 
-extern C {
-void onAppCmd_cb (struct android_app* app, int32_t cmd)
+}
+
+void AndroidSalInstance::BlitFrameToWindow(ANativeWindow *pWindow,
+   const 
basebmp::BitmapDeviceSharedPtr aDev)
+{
+basegfx::B2IVector aDevSize = aDev-getSize();
+ARect aWhole = { 0, 0, aDevSize.getX(), aDevSize.getY() };
+BlitFrameRegionToWindow(pWindow, aDev, aWhole, 0, 0);
+}
+
+void AndroidSalInstance::RedrawWindows(ANativeWindow *pWindow)
+{
+std::list SalFrame* ::const_iterator it;
+for ( it = getFrames().begin(); it != getFrames().end(); it++ )
 {
+SvpSalFrame *pFrame = static_castSvpSalFrame *(*it);
+BlitFrameToWindow (pWindow, pFrame-getDevice());
+}
+}
+
+void AndroidSalInstance::onAppCmd (struct android_app* app, int32_t cmd)
+{
 fprintf (stderr, app cmd for app %p, cmd %d\n, app, cmd);
-ANativeWindow *pWindow = app-window;
+ANativeWindow *pWindow = mpApp-window;
 switch (cmd) {
 case APP_CMD_INIT_WINDOW:
 {
@@ -83,26 +138,8 @@ extern C {
 fprintf (stderr, we have an app window ! %p %dx%x (%d)\n,
  pWindow, aRect.right, aRect.bottom,
  ANativeWindow_getFormat(pWindow));
-ANativeWindow_Buffer aBuffer;
-memset ((void *)aBuffer, 0, sizeof (aBuffer));
-int32_t nRet = ANativeWindow_lock(pWindow, aBuffer, aRect);
-fprintf (stderr, locked window %d returned rect: %d,%d-%d,%d 
- buffer: %dx%d stride %d, format %d, bits %p\n,
- nRet, aRect.left, aRect.top, aRect.right, aRect.bottom,
- aBuffer.width, aBuffer.height, aBuffer.stride,
- aBuffer.format, aBuffer.bits);
-if (aBuffer.bits)
-{
-// hard-code / guess at a format ...
-int32_t *p = (int32_t *)aBuffer.bits;
-for (int32_t y = 0; y  aBuffer.height; y++)
-{
-for (int32_t x = 0; x  aBuffer.stride / 4; x++)
-*p++ = (y  24) + x;

[Libreoffice-commits] .: Branch 'feature/android' - vcl/inc

 vcl/inc/android/androidinst.hxx |   13 -
 vcl/inc/headless/svpframe.hxx   |4 ++--
 2 files changed, 14 insertions(+), 3 deletions(-)

New commits:
commit 32af4e15048e53b223294ad33ac428f992bfd0eb
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 21:13:36 2012 +

android: missing header pieces

diff --git a/vcl/inc/android/androidinst.hxx b/vcl/inc/android/androidinst.hxx
index 3b026b0..aec2735 100644
--- a/vcl/inc/android/androidinst.hxx
+++ b/vcl/inc/android/androidinst.hxx
@@ -30,22 +30,33 @@
 #ifndef ANDROID_SALINST_H
 #define ANDROID_SALINST_H
 
+#include android/input.h
+#include android/native_window.h
 #include headless/svpinst.hxx
+#include headless/svpframe.hxx
 
 class AndroidSalInstance : public SvpSalInstance
 {
+void RedrawWindows(ANativeWindow *pWindow);
+void BlitFrameToWindow(ANativeWindow *pWindow,
+   const basebmp::BitmapDeviceSharedPtr aDev);
 public:
 AndroidSalInstance( SalYieldMutex *pMutex );
 virtual ~AndroidSalInstance();
+static AndroidSalInstance *getInstance();
 
 virtual SalSystem* CreateSalSystem();
 
 // mainloop pieces
 virtual void Wakeup();
 virtual bool AnyInput( sal_uInt16 nType );
+
+// incoming android event handlers:
+voidonAppCmd (struct android_app* app, int32_t cmd);
+int32_t onInputEvent (struct android_app* app, AInputEvent* event);
 protected:
 virtual void DoReleaseYield( int nTimeoutMS );
-struct android_app *app;
+struct android_app *mpApp;
 };
 
 #endif // ANDROID_SALINST_H
diff --git a/vcl/inc/headless/svpframe.hxx b/vcl/inc/headless/svpframe.hxx
index 5f88e64..37e0ae9 100644
--- a/vcl/inc/headless/svpframe.hxx
+++ b/vcl/inc/headless/svpframe.hxx
@@ -41,9 +41,9 @@ class SvpSalGraphics;
 class SvpSalFrame : public SalFrame, public SvpElement
 {
 SvpSalInstance* m_pInstance;
-SvpSalFrame*m_pParent;   // pointer to parent frame
+SvpSalFrame*m_pParent;   // pointer to parent 
frame
 std::list SvpSalFrame*m_aChildren; // List of child 
frames
-sal_uLong m_nStyle;
+sal_uLong   m_nStyle;
 boolm_bVisible;
 longm_nMinWidth;
 longm_nMinHeight;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'libreoffice-3-5-0' - sc/source

 sc/source/core/data/dpoutput.cxx |   14 +++---
 1 file changed, 11 insertions(+), 3 deletions(-)

New commits:
commit be8e049d01f05773ac595b5ee32b262540381a44
Author: Kohei Yoshida kohei.yosh...@suse.com
Date:   Tue Jan 24 16:32:10 2012 -0500

fdo#45067: Differentiate numeric and non-numeric field member values.

Signed-off-by: Markus Mohrhard markus.mohrh...@googlemail.com

diff --git a/sc/source/core/data/dpoutput.cxx b/sc/source/core/data/dpoutput.cxx
index 990e212..32179e3 100644
--- a/sc/source/core/data/dpoutput.cxx
+++ b/sc/source/core/data/dpoutput.cxx
@@ -795,10 +795,18 @@ void ScDPOutput::HeaderCell( SCCOL nCol, SCROW nRow, 
SCTAB nTab,
 
 if ( nFlags  sheet::MemberResultFlags::HASMEMBER )
 {
-// Avoid unwanted automatic format detection.
+bool bNumeric = (nFlags  sheet::MemberResultFlags::NUMERIC) != 0;
 ScSetStringParam aParam;
-aParam.mbDetectNumberFormat = false;
-aParam.mbSetTextCellFormat = true;
+if (bNumeric)
+{
+aParam.mbDetectNumberFormat = true;
+aParam.mbSetTextCellFormat = false;
+}
+else
+{
+aParam.mbDetectNumberFormat = false;
+aParam.mbSetTextCellFormat = true;
+}
 pDoc-SetString(nCol, nRow, nTab, rData.Caption, aParam);
 }
 
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: Branch 'feature/android' - vcl/android

 vcl/android/androidinst.cxx |  103 
 1 file changed, 76 insertions(+), 27 deletions(-)

New commits:
commit 0def387f351b7e67c2f45474105333c4cb4f55dc
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 22:09:39 2012 +

android: add first cut of frame contents blitting, and error dialog

diff --git a/vcl/android/androidinst.cxx b/vcl/android/androidinst.cxx
index b4ea9e0..4772a74 100644
--- a/vcl/android/androidinst.cxx
+++ b/vcl/android/androidinst.cxx
@@ -74,44 +74,70 @@ static rtl::OString KeyMetaStateToString(int32_t nFlags)
 }
 
 static void BlitFrameRegionToWindow(ANativeWindow *pWindow,
-const basebmp::BitmapDeviceSharedPtr /* 
aDev */,
-const ARect aSrcRect,
+const basebmp::BitmapDeviceSharedPtr aDev,
+const ARect rSrcRect,
 int nDestX, int nDestY)
 {
-fprintf (stderr, Blit frame src %d,%d-%d,%d to positoon %d, %d\n,
- aSrcRect.left, aSrcRect.top, aSrcRect.right, aSrcRect.bottom,
+fprintf (stderr, Blit frame src %d,%d-%d,%d to position %d, %d\n,
+ rSrcRect.left, rSrcRect.top, rSrcRect.right, rSrcRect.bottom,
  nDestX, nDestY);
-#if 1
 ARect aRect;
-ANativeWindow_Buffer aBuffer;
-memset ((void *)aBuffer, 0, sizeof (aBuffer));
-int32_t nRet = ANativeWindow_lock(pWindow, aBuffer, aRect);
+ANativeWindow_Buffer aOutBuffer;
+memset ((void *)aOutBuffer, 0, sizeof (aOutBuffer));
+int32_t nRet = ANativeWindow_lock(pWindow, aOutBuffer, aRect);
 fprintf (stderr, locked window %d returned rect: %d,%d-%d,%d 
  buffer: %dx%d stride %d, format %d, bits %p\n,
  nRet, aRect.left, aRect.top, aRect.right, aRect.bottom,
- aBuffer.width, aBuffer.height, aBuffer.stride,
- aBuffer.format, aBuffer.bits);
-if (aBuffer.bits)
+ aOutBuffer.width, aOutBuffer.height, aOutBuffer.stride,
+ aOutBuffer.format, aOutBuffer.bits);
+if (aOutBuffer.bits == NULL)
 {
-// hard-code / guess at a format ...
-int32_t *p = (int32_t *)aBuffer.bits;
-for (int32_t y = 0; y  aBuffer.height; y++)
+fprintf (stderr, no buffer for locked window\n);
+ANativeWindow_unlockAndPost(pWindow);
+return;
+}
+
+// FIXME: do some cropping goodness on aSrcRect to ensure no overflows etc.
+ARect aSrcRect = rSrcRect;
+sal_Int32 nStride = aDev-getScanlineStride();
+basebmp::RawMemorySharedArray aSrcData = aDev-getBuffer();
+unsigned char *pSrc = aSrcData.get();
+
+for (unsigned int y = 0; y  (unsigned int)(aSrcRect.bottom - 
aSrcRect.top); y++)
+{
+unsigned char *sp = ( pSrc + nStride * (y + aSrcRect.top) +
+  aSrcRect.left * 3 /* src pixel size */ );
+unsigned char *dp = ( (unsigned char *)aOutBuffer.bits +
+  aOutBuffer.stride * (y + nDestY) +
+  nDestX * 4 /* dest pixel size */ );
+for (unsigned int x = 0; x  (unsigned int)(aSrcRect.right - 
aSrcRect.left); x++)
 {
-for (int32_t x = 0; x  aBuffer.stride / 4; x++)
-*p++ = (y  24) + x;
+dp[x*4 + 0] = sp[x*3 + 0]; // B
+dp[x*4 + 1] = sp[x*3 + 1]; // G
+dp[x*4 + 2] = sp[x*3 + 2]; // R
+dp[x*4 + 3] = 255; // A
 }
 }
-ANativeWindow_unlockAndPost(pWindow);
-fprintf (stderr, done render!\n);
+fprintf (stderr, done blit!\n);
+#if 0
+// hard-code / guess at a format ...
+int32_t *p = (int32_t *)aBuffer.bits;
+for (int32_t y = 0; y  aBuffer.height; y++)
+{
+for (int32_t x = 0; x  aBuffer.stride / 4; x++)
+*p++ = (y  24) + x;
+}
 #endif
 
+ANativeWindow_unlockAndPost(pWindow);
+fprintf (stderr, done render!\n);
 }
 
 void AndroidSalInstance::BlitFrameToWindow(ANativeWindow *pWindow,
const 
basebmp::BitmapDeviceSharedPtr aDev)
 {
 basegfx::B2IVector aDevSize = aDev-getSize();
-ARect aWhole = { 0, 0, aDevSize.getX(), aDevSize.getY() };
+ARect aWhole = { 0, 0, 400, 400 }; // FIXME: aDevSize.getX(), 
aDevSize.getY() };
 BlitFrameRegionToWindow(pWindow, aDev, aWhole, 0, 0);
 }
 
@@ -211,6 +237,8 @@ int32_t AndroidSalInstance::onInputEvent (struct 
android_app* app, AInputEvent*
 
 AndroidSalInstance *AndroidSalInstance::getInstance()
 {
+if (!ImplGetSVData())
+return NULL;
 AndroidSalData *pData = static_castAndroidSalData 
*(ImplGetSVData()-mpSalData);
 if (!pData)
 return NULL;
@@ -299,14 +327,7 @@ public:
 virtual int ShowNativeDialog( const rtl::OUString rTitle,
   const rtl::OUString rMessage,
   const std::list rtl::OUString  rButtons,
-

[Libreoffice-commits] .: Branch 'feature/android' - android/qa

 android/qa/desktop/Makefile |1 +
 1 file changed, 1 insertion(+)

New commits:
commit 0f32f98564f8e0e66bc2d2ee5c55406930007044
Author: Michael Meeks michael.me...@suse.com
Date:   Wed Jan 25 22:41:41 2012 +

android: add missing deployment component

diff --git a/android/qa/desktop/Makefile b/android/qa/desktop/Makefile
index 1dd0d83..876c432 100644
--- a/android/qa/desktop/Makefile
+++ b/android/qa/desktop/Makefile
@@ -109,6 +109,7 @@ copy-stuff: buildrcs
  bootstrap.uno \
  comphelpgcc3 \
  configmgr.uno \
+ deployment \
  deploymentmisclo \
  fileacc \
  fontconfig \
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits

[Libreoffice-commits] .: xmloff/source

2012-01-25 Thread Olivier Hallot

 xmloff/source/forms/controlpropertyhdl.cxx |6 +-
 xmloff/source/forms/elementexport.cxx  |   24 +-
 xmloff/source/forms/elementimport.cxx  |   48 ++---
 xmloff/source/forms/eventexport.cxx|4 -
 xmloff/source/forms/eventimport.cxx|2 
 xmloff/source/forms/formcellbinding.cxx|4 -
 xmloff/source/forms/layerexport.cxx|4 -
 xmloff/source/forms/layerimport.cxx|   10 ++--
 xmloff/source/forms/property_meta_data.cxx |   10 ++--
 xmloff/source/forms/propertyexport.cxx |   20 
 xmloff/source/forms/propertyimport.cxx |   10 ++--
 xmloff/source/meta/xmlmetae.cxx|   14 +++---
 xmloff/source/meta/xmlmetai.cxx|4 -
 xmloff/source/meta/xmlversion.cxx  |4 -
 xmloff/source/script/XMLStarBasicExportHandler.cxx |2 
 xmloff/source/script/xmlbasici.cxx |2 
 xmloff/source/style/DashStyle.cxx  |4 -
 xmloff/source/style/FillStyleContext.cxx   |4 -
 xmloff/source/style/GradientStyle.cxx  |4 -
 xmloff/source/style/HatchStyle.cxx |4 -
 xmloff/source/style/ImageStyle.cxx |8 +--
 xmloff/source/style/MarkerStyle.cxx|4 -
 xmloff/source/style/PageMasterImportContext.cxx|2 
 xmloff/source/style/PageMasterPropHdl.cxx  |   12 ++---
 xmloff/source/style/TransGradientStyle.cxx |4 -
 xmloff/source/style/XMLBackgroundImageContext.cxx  |6 +-
 xmloff/source/style/XMLBackgroundImageExport.cxx   |8 +--
 xmloff/source/style/XMLFontAutoStylePool.cxx   |4 -
 xmloff/source/style/XMLPageExport.cxx  |4 -
 xmloff/source/style/bordrhdl.cxx   |2 
 xmloff/source/style/cdouthdl.cxx   |2 
 xmloff/source/style/chrhghdl.cxx   |6 +-
 xmloff/source/style/chrlohdl.cxx   |4 -
 xmloff/source/style/csmaphdl.cxx   |2 
 34 files changed, 126 insertions(+), 126 deletions(-)

New commits:
commit 3dbb89e5a39e7811d2fc0c1fbad012c3d565396b
Author: Olivier Hallot olivier.hal...@alta.org.br
Date:   Wed Jan 25 21:59:48 2012 -0200

Fix for fdo43460 Part XLVIII getLength() to isEmpty()

Part XLVIII
Modules
xmloff (part 2)

diff --git a/xmloff/source/forms/controlpropertyhdl.cxx 
b/xmloff/source/forms/controlpropertyhdl.cxx
index 3c8b0fc..5442a55 100644
--- a/xmloff/source/forms/controlpropertyhdl.cxx
+++ b/xmloff/source/forms/controlpropertyhdl.cxx
@@ -245,7 +245,7 @@ namespace xmloff
 sal_uInt16 nStyle = 1;
 
 while   (   aTokens.getNextToken(sToken)// have a new token
-  (0 != sToken.getLength())   // really have a new token
+  (!sToken.isEmpty())   // really have a new token
 )
 {
 // try interpreting the token as border style
@@ -304,7 +304,7 @@ namespace xmloff
 if ( !bSuccess )
 return sal_False;
 
-if ( _rStrExpValue.getLength() )
+if ( !_rStrExpValue.isEmpty() )
 _rStrExpValue += ::rtl::OUString( RTL_CONSTASCII_USTRINGPARAM(   
) );
 _rStrExpValue += aOut.makeStringAndClear();
 
@@ -343,7 +343,7 @@ namespace xmloff
 }
 _rStrExpValue = aResult.makeStringAndClear();
 
-return _rStrExpValue.getLength() != 0;
+return !_rStrExpValue.isEmpty();
 }
 
 //=
diff --git a/xmloff/source/forms/elementexport.cxx 
b/xmloff/source/forms/elementexport.cxx
index fcc3efa..863d99a 100644
--- a/xmloff/source/forms/elementexport.cxx
+++ b/xmloff/source/forms/elementexport.cxx
@@ -316,7 +316,7 @@ namespace xmloff
 // the control id
 if (CCA_CONTROL_ID  m_nIncludeCommon)
 {
-OSL_ENSURE(m_sControlId.getLength(), 
OControlExport::exportInnerAttributes: have no control id for the control!);
+OSL_ENSURE(!m_sControlId.isEmpty(), 
OControlExport::exportInnerAttributes: have no control id for the control!);
 m_rContext.getGlobalContext().AddAttributeIdLegacy(
 XML_NAMESPACE_FORM, m_sControlId);
 #if OSL_DEBUG_LEVEL  0
@@ -799,7 +799,7 @@ namespace xmloff
 // the target frame
 if (m_nIncludeCommon  CCA_FOR)
 {
-if (m_sReferringControls.getLength())
+if (!m_sReferringControls.isEmpty())
 {   // there is at least one control referring to the one we're 
handling currently
 AddAttribute(
 
OAttributeMetaData::getCommonControlAttributeNamespace(CCA_FOR),
@@ -1095,7 +1095,7 @@ namespace xmloff
 else
 OSL_FAIL( OControlExport::exportSpecialAttributes: not 
property which can be mapped to

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

fabien.mic...@hespul.org changed:

   What|Removed |Added

 Depends on||40907

--- Comment #140 from fabien.mic...@hespul.org 2012-01-25 00:26:28 PST ---
#40907 : Networking for Mac users is strongly affected by this bug. When a user
attempts to open a file already open on AFP shared folder, it is not advised of
which use this file, but receive an I/O error

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

2012-01-25 Thread Radek Doulik

Hi Stefan,

I have reverted the patch and will try to replicate the problem and fix
it. Thanks for info and sorry for the trouble.

Cheers
Radek

On Tue, 2012-01-24 at 22:11 +0100, Stephan Bergmann wrote:
 Radek,
 
 bisecting showed me that it is this commit that causes my machine to 
 become unresponsive (as the involved soffice.bin process keeps growing 
 in size, apparently without limit) when executing the forms_unoapi test 
 (during make check) -- and it is also most likely this commit that 
 causes the current failures of the Linux-RHEL6-x86_64@14-with-check 
 tinderbox when executing the same test.
 
 Though what's the problem is beyond me for tonight...
 
 -Stephan
 
 On 01/24/2012 01:42 PM, Radek Doulík wrote:
vcl/source/gdi/gdimtf.cxx |8 
1 file changed, 4 insertions(+), 4 deletions(-)
 
  New commits:
  commit f7b6cd87f78b786b59984e5b3c8a5a78f0ed7a94
  Author: Radek Doulikr...@novell.com
  Date:   Tue Jan 24 13:39:25 2012 +0100
 
   fix rendering of metafiles embedded in emf+
 
  diff --git a/vcl/source/gdi/gdimtf.cxx b/vcl/source/gdi/gdimtf.cxx
  index 38d66ed..1395fe6 100644
  --- a/vcl/source/gdi/gdimtf.cxx
  +++ b/vcl/source/gdi/gdimtf.cxx
  @@ -406,9 +406,9 @@ void GDIMetaFile::Play( OutputDevice* pOut, size_t nPos 
  )
pOut-SetLayoutMode( 0 );
pOut-SetDigitLanguage( 0 );
 
  -for( size_t nCurPos = nCurrentActionElement; nCurPos  nPos; 
  nCurPos++ )
  -{
  -if( !Hook() )
  +OSL_TRACE(GDIMetaFile::Play on device of size: %d x %d, 
  pOut-GetOutputSizePixel().Width(), pOut-GetOutputSizePixel().Height());
  +if( !ImplPlayWithRenderer( pOut, Point(0,0), 
  pOut-GetOutputSizePixel() ) ) {
  +for( size_t nCurPos = nCurrentActionElement; nCurPos  nPos; 
  nCurPos++ )
{
MetaCommentAction* pCommentAct = 
  static_castMetaCommentAction*(pAction);
if( pAction-GetType() == META_COMMENT_ACTION
  @@ -608,7 +608,7 @@ void GDIMetaFile::Play( OutputDevice* pOut, const 
  Point  rPos,
{
GDIMetaFile*pMtf = pOut-GetConnectMetaFile();
 
  -if( bUseCanvas  !pMtf  ImplPlayWithRenderer( pOut, rPos, 
  aDestSize ) )
  +if( bUseCanvas  ImplPlayWithRenderer( pOut, rPos, aDestSize ) )
return;
 
Size aTmpPrefSize( pOut-LogicToPixel( GetPrefSize(), aDrawMap ) 
  );
 


___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Fw: [ODFPlugtest] Call for proposals for 8th ODF plugfest in Brussel

FYI -

- Forwarded message from robert_w...@us.ibm.com -

From:   Arthur Buijs a.bu...@opendocsociety.org
To: plugt...@opendocsociety.org
Date:   01/17/2012 08:08 AM
Subject:[ODFPlugtest] Call fo proposals for 8th ODF plugfest in 
Brussel
Sent by:plugtest-boun...@opendocsociety.org

  Amsterdam, Jan 16th 2012
Dear sir/madam,

on behalf of OpenDoc Society we kindly invite your contributions for
the Eight ODF plugfest will take place in Brussels (Belgium) on April
19-20, 2012. The venue is kindly provided by Microsoft Corporation.
Previous plugfests were held in Den Haag (NL), Orvieto (Italy),
Granada (Spain), Brussels, Windsor and Maidenhead (UK), Berlin (DE)
and Gouda (NL).

The programme of the plugfest will again consist of of a technical part
where the actual plugtesting is done (under Chatham house rule) and a
part which is open to the general public. The public facing event will
take place on the afternoon of April 20th 2012.

The deadline for submitting talks for the 8th ODF plugfest is March 1st
2012. Short abstracts of 50 - 100 words are invited on all subjects
relevant to OpenDocument Format. You will have an estimated 12-15
minutes available for your presentation and follow up questions. The
programme already contains a section on product updates where all
vendors attending can announce relevant product improvements and other
new developments, there is no need to submit a talk proposal for that.

Your contributions will be evaluated by an independent programme
committee, consisting of:

- - Alan Bell (OFE)
- - Basil Cousins (OFE)
- - Patrick Durusau (Individual)
- - Roberto Galoppini (Individual)
- - Sophie Gautier (The Document Foundation)
- - Bart Hanssens (Fedict)
- - Michiel Leenaars (NLnet foundation)
- - John Haug (Microsoft)
- - Jos van den Oever (WebODF, KO GmbH)
- - Louis-Suarez Potts
- - Rob Weir (IBM)

Please send your contributions before March 1st 2012 12:00 UCT to:
plugtest-organis...@opendocsociety.org. If you have any questions,
please contact one of the members of the programme committee.

Kind regards,

on behalf of OpenDoc Society
Arthur Buijs

- End forwarded message -

Cheers,

-- Thorsten

pgpbVnTyoLAnw.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+


On 01/25/2012 09:33 AM, Radek Doulik wrote:

I have reverted the patch and will try to replicate the problem and fix
it. Thanks for info and sorry for the trouble.


Looks like it is a memory leak in ImplPlayWithRenderer, just having a 
look there myself right now.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Wrong cast to css.table.BorderLine2

2012-01-25 Thread Cedric Bosdonnat

Hi Stephan,

On Mon, 2012-01-23 at 21:41 +0100, Stephan Bergmann wrote:

 where borderline.cxx:128
 const table::BorderLine2 rBorder2 = static_cast const 
 table::BorderLine2 ( rStruct );
 
 erroneously treats a BorderLine contained in a TableBorder (created at 
 afmtuno.cxx:776) as a derived BorderLine2.  That cast seemingly got in with
 
  commit 89d3e8a8424ce44404a554812e5136452bb8cb60
  Author: Cédric Bosdonnat cedricbo...@openoffice.org
  Date:   Fri Dec 24 10:00:15 2010 +0100
 
  Switching the order of the SetLinesWidth arguments

Hum, I'll have a look at that... but my problem with BorderLine and
BorderLine2 is that the second one should be used everywhere... and that
sometimes isn't the case. If only we could extend existing published UNO
types instead of specializing these.

--
Cedric

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+


On 01/25/2012 09:53 AM, Stephan Bergmann wrote:

On 01/25/2012 09:33 AM, Radek Doulik wrote:

I have reverted the patch and will try to replicate the problem and fix
it. Thanks for info and sorry for the trouble.


Looks like it is a memory leak in ImplPlayWithRenderer, just having a
look there myself right now.


Nah, can't find any obvious leak there.  Must be something more tricky. 
 Will wait for your fix then.


Thanks,
Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] bootstrap repos (was: Re: Problem with clipboard paste in 3.5)

Hi Michael,

On Tue, 2012-01-24 at 18:38 +0100, Michael Stahl wrote:
 it seems we have somebody unfortunate enough to try to build the master
 branch from bootstrap repos once a week; would it be possible to do
 something to prevent that?

We could commit a huge warning to the end of configure.in in there that
prints out:

You are using the wrong branch, obsolete since 2010

etc. :-)

 e.g. create a master-backup that points at the current master commit,
 then let master point to an empty source tree; that way people should
 notice something's wrong when they try... any opinions from git experts?

Sure - or we could do that. Are packagers still using build ? there is
no particular git-ness about either approach. It is easy to create a
libreoffice-3-5 branch from master there [ if it even works ], and then
just delete everything in master.

ATB,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-commits] .: vcl/source fix rendering of metafiles embedded in emf+

One thing I did notice with the first hunk of your patch is that it 
moved pAction = NextAction(); outside the for loop -- but that looks 
irrelevant to the problem at hand, as ImplPlayWithRenderer appears to 
always return true in the newly introduced if here.


Also, forms_unoapi now triggers lots of


warn:legacy.osl:10979:9:/data/lo/core/cppcanvas/source/mtfrenderer/implrenderer.cxx:2715:
 Unknown meta action type encountered


from within ImplPlayWithRenderer and at least once triggers that 
function's catch (RuntimeException) block with an exception with message



basegfx::B2DPolyPolygon cppcanvas::tools::createTextLinesPolyPolygon(basegfx::B2DPoint, 
const double, const cppcanvas::tools::TextLineInfo),
::cppcanvas::internal::createTextLinesPolyPolygon(): Unexpected strikeout case


-- anomalies the original code did not exhibit.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

Cor Nouws píše v Út 24. 01. 2012 v 23:10 +0100:
Hi all,

Pedro wrote (10-01-12 18:57)
Michael Meeks-2 wrote

OTH more releases means more features but also more bugs. And because new
bugs occur, old bugs are left behind.

Oh ! so - this is an argument for doing a build every decade ;-)

Not really. It's just an argument that if releases are too close, developers
will only have time to fix blockers :)
So not so critical bugs tend to accumulate. This could mean that it will
loose quality as it goes along if it there are no major obstacles ;)

This has been part of our discussion in Paris.
http://wiki.documentfoundation.org/QA/Improving_QA-Release-3.5
more specific

http://wiki.documentfoundation.org/File:Liboconf2011_improving_qa_release_cycle-cornouws_Slides19-28.pdf
See #4 on slide 23, and slide 27 explaining that point.

That discussion (of course) carried no final conclusion - but the
'agreement' (consent with Petr that it is a good idea) that the
developers try to remember/summarise their experience with this, so that
that can be part of an evaluation.

The idea/hope is, that faster/smarter fixing of bugs, leads to a shift
in the time spending: less weeks on bug fixing and more on features.

Please, look at
http://download.go-oo.org/lo/lo-release-plan-in-colors.png

The picture tries to visualize an expectation where developers spend
time. The strong yellow and red color shows huge activity in bug fixing.
The strong green shows the time where developers prefer work on
features. You see that the strong green is only half size of the strong
yellow and red.

= developers spend a lot of time on bug fixing

Here are the commit statistics from weeks between 3.4.0-beta1 and
3.5.0-beta1:

week 13, 2011:19 bug fixes of 339 commits
week 14, 2011:22 bug fixes of 283 commits
week 15, 2011:17 bug fixes of 183 commits
week 16, 2011:16 bug fixes of 182 commits
week 17, 2011:21 bug fixes of 179 commits
week 18, 2011:20 bug fixes of 158 commits
week 19, 2011:19 bug fixes of 194 commits
week 20, 2011:26 bug fixes of 361 commits
week 21, 2011:26 bug fixes of 333 commits
week 22, 2011:8 bug fixes of 301 commits
week 23, 2011:40 bug fixes of 313 commits
week 24, 2011:27 bug fixes of 436 commits
week 25, 2011:21 bug fixes of 223 commits
week 26, 2011:23 bug fixes of 245 commits
week 27, 2011:21 bug fixes of 252 commits
week 28, 2011:11 bug fixes of 352 commits
week 29, 2011:15 bug fixes of 314 commits
week 30, 2011:33 bug fixes of 441 commits
week 31, 2011:15 bug fixes of 226 commits
week 32, 2011:20 bug fixes of 350 commits
week 33, 2011:24 bug fixes of 468 commits
week 34, 2011:16 bug fixes of 375 commits
week 35, 2011:20 bug fixes of 309 commits
week 36, 2011:34 bug fixes of 332 commits
week 39, 2011:5 bug fixes of 357 commits
week 40, 2011:16 bug fixes of 482 commits
week 41, 2011:10 bug fixes of 127 commits
week 42, 2011:21 bug fixes of 268 commits
week 43, 2011:17 bug fixes of 307 commits
week 44, 2011:24 bug fixes of 309 commits
week 45, 2011:20 bug fixes of 333 commits
week 46, 2011:36 bug fixes of 462 commits
week 47, 2011:64 bug fixes of 558 commits
week 48, 2011:59 bug fixes of 569 commits
week 49, 2011:52 bug fixes of 460 commits

Note that the real numbers are higher because developers sometimes do
not mention the fixed bug number in commit messages. It would be better
to get statistics from bugzilla but it is not that easy for me. Rainer
is the expert here.

Anyway, it shows that developers fix bugs all the time. They do not
spend months working only on features!

However, there is inevitably a strong tangling with the QA work.
And - despite my optimistic nature and the many hours spent on both QA
and getting that process at a higher level/notice - I have some serious
concerns on how secure our over all process is in this regard.

This results in bugs that should have been handled/getting floated much
earlier. Fix may be easy / ready in master / needed, but do not find
their way to the bug fix releases.

Examples:
- 45068 Update from 3.4.4 on Win not possible without ...
initial bug 2011-04-29 3.4.0 beta3,
workaround published 2012-01-22

There was no activity on this bug until 2011-11-24; It was fixed the day
after on 2011-11-25.

= The problem was that it was hidden in the swamp of other bugs and
newer assigned to a developer who could look at it

- 41054 Saving problem ods with new sheets
initial report 2011-09-20
fixed for 3.5 2012-01-10
fixed for 3.4 still pending

There was no real activity until 2012-01-11. The bug was fixed the same
day.

= again the same problem with hidden bug in the swamp

- 39118 Charts do not update
initial report 2011-07-10
fixed for master/3.5 2011-12-13

This one was assigned correctly on 2011-07-11. The bug had set medium
priority

Re: [Libreoffice] Wrong cast to css.table.BorderLine2


On 01/25/2012 09:48 AM, Cedric Bosdonnat wrote:

Hum, I'll have a look at that... but my problem with BorderLine and
BorderLine2 is that the second one should be used everywhere... and that
sometimes isn't the case.


You apparently need a css.table.TableBorder2 that has members of type 
BorderLine2 instead of plain BorderLine.  At least in the C++ UNO 
language binding (unlike in the Java one), struct members within structs 
are contained directly in the enclosing struct, without any 
pointer/reference indirection, so that, say, assigning a BorderLine2 
instance to a TableBorder.TopLine slices it to just BorderLine.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] 3.5.0 QA ... from BHS 1 to BHS 2

Hi Cor,

On Tue, 2012-01-24 at 23:10 +0100, Cor Nouws wrote:
 The idea/hope is, that faster/smarter fixing of bugs, leads to a shift 
 in the time spending: less weeks on bug fixing and more on features.

Sure - of course, those bugs need good visibility; they need to be
marked 'most annoying' if they are major issues as early as possible. So
this 'initial bug' date is (to me) uninteresting. There are thousands of
bugs, if we have serious / critical stoppers they need to be
-immediately- associated with the most annoying bug, or at least
suggested there in a comment [ NB. as we add a dependency we need to add
the bug in a comment too to have this date ;-].

 Examples:
 - 45068 Update from 3.4.4 on Win not possible without ...
  initial bug 2011-04-29 3.4.0 beta3,
  workaround published 2012-01-22

most annoying in 3.5 from: 2012-01-22

so - we got a same-day workaround; but the bug was not prioritised for
six months ? :-)

 - 41054 Saving problem ods with new sheets
  initial report 2011-09-20
  fixed for 3.5 2012-01-10
  fixed for 3.4 still pending

added 3.4 most annoying 2012-01-13 after the 3.4.5 release ;-)
Hopefully it'll make it into 3.4.6 somewhen before we do that release
until we do - not a big issue.

 - 39118 Charts do not update
  initial report 2011-07-10
  fixed for master/3.5 2011-12-13
  fixed for 3.4.6 2012-01-16

added to 3.4 most annoying: 2012-01-13 - also after the 3.4.5 release;
six months after filing.

 (pls don't ask me to provide more examples)

Sure - please do :-)

What I see here is that (for whatever reason) serious bugs (or at least
bugs with easy fixes which we could easily back-port) are not being
raised at the place that we track these things carefully before release
at, such that we have time to deal with them.

 Another reason: lack of triage / bundling of issues, which is both 
 important for developers (fixing) ans users (simple how-to's for work 
 around).

Right - it is a serious issue as you say; we need to get better
visibility into easy-to-back-port, and/or blocker-like bugs. And we need
to get that earlier.

All the best,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

On Tue, 2012-01-24 at 21:01 +0100, khagaroth wrote:
 While at it, it would be nice to also set Reply-To:
 libreoffice@lists.freedesktop.org.

Which is an abomination :-)

ATB,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [ANN] LibreOffice 3.5.0 RC2 available

Hi *,

for the upcoming new version 3.5.0, the RC2 builds now start to be
available on pre-releases. For further milestones on the way towards
3.5.0, please refer to our release plan timings here:

 http://wiki.documentfoundation.org/ReleasePlan#3.5_release

Builds are now being uploaded to a public (but non-mirrored - so don't
spread news too widely!) place, as soon as they're available. Grab
them here:

 http://dev-builds.libreoffice.org/pre-releases/

If you've a bit of time, please give them a try  report *critical*
bugs not yet in bugzilla here, so we can incorporate them into the
release notes. Please note that it takes approximately 24 hours to
populate the mirrors, so that's about the time we have to collect
feedback.

The list of fixed bugs relative to rc1 is here:

 
http://dev-builds.libreoffice.org/pre-releases/src/bugfixes-libreoffice-3-5-release-3.5.0.2.log

So playing with the areas touched there also greatly appreciated - and
validation that those bugs are really fixed.

Thanks a lot for your help,

-- Thorsten


pgpE3sBsRg9h8.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Rainer Bielefeld libreoff...@bielefeldundbuss.de changed:

   What|Removed |Added

 OS/Version|Linux (All) |All

--- Comment #141 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 
2012-01-25 02:49:57 PST ---
Add Bug 45219 - SLIDESHOW: Transparency gradient effect fade in with wrong
VIEWING, that might make Presentation useless fol many users.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Andras Timar

Hi,

Yesterday two bugs came to my attention.
fdo#44208 - under Windows crash occurred when user selected Tools -
Options in selected Indian locales
fdo#45107 - under Windows garbage characters appeared at random places
in selected Indian locales
I suspected a font issue. Interestingly, these bugs are not
reproducible on all systems, but at least I could reproduce them on
clean Windows XP and clean Windows 7 64-bit. On my other Windows XP,
which is 6 years old, and there are many fonts from different sources
installed, the bugs were not reproducible.

I did not find how to fix the crash, but I found a workaround, and
that also solved fdo#45107. In VCL.xcu I replaced the iso code of
problematic Indian locales to language code only.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=82e0266b05dd53d0ce8b12bd5c76ae25872b87a9
I was too greedy, Fridrich fixed it after me:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=86bf32c487852f4e466b27320e3724266cb53dba

I would like to have these commits in libreoffice-3-5,
libreoffice-3-5-0, and libreoffice-3-4. These are rather serious
issues, that make Indian localizations useless under Windows.

Also, if somebody (Caolán?) knows how VCL.xcu works today, please help
to update the documentation in wiki:
http://wiki.documentfoundation.org/LibreOffice_Localization_Guide#Define_the_default_fonts_for_the_locale
If for example ta-IN entry was ignored, and it works with ta, then
we need to review the whole file, because many locales have country
codes, while UI localization uses only language code. Should we add
entries for locales which are not there? Moreover, I'm not sure if the
recently fixed fdo#43984 works at all (it uses zh-cn and zh-hk locale
codes).

Thanks,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=35673

Bug 35673 depends on bug 44208, which changed state.

Bug 44208 Summary: CRASH when click Tools - Options with UI [ta_IN], [hi_IN] 
and other [xx_IN]
https://bugs.freedesktop.org/show_bug.cgi?id=44208

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

On Tuesday 24 of January 2012, khagaroth wrote:
 While at it, it would be nice to also set Reply-To:
 libreoffice@lists.freedesktop.org.

 Oh, well, that's something people will probably never agree on *shrug*. You 
just need to get a mail client that is modern enough (that's, like, last 
decade) to have 'reply-to-mailing-list' and that solves the problem. And that 
was a plural you, if I wanted to get all those useless duplicates of replies 
to my mails, I would have said so.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] UPDATE: Swedish hunspell dictionary

2012-01-25 Thread Göran Andersson

The Swedish spell checking dictionary has been updated.
The latest version will always be available at
http://extensions.libreoffice.org/extension-center/swedish-spelling-dictionary-den-stora-svenska-ordlistan
(it can also be downloaded from http://code.google.com/p/dsso/downloads/list).

Please include the latest version in your next release (the latest
version of the dictionary is 1.51, the one currently distributed with
LibreOffice is 1.48).
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Regina Henschel


Hi,

Lubos Lunak schrieb:

On Tuesday 24 of January 2012, khagaroth wrote:

While at it, it would be nice to also set Reply-To:
libreoffice@lists.freedesktop.org.


  Oh, well, that's something people will probably never agree on *shrug*. You
just need to get a mail client that is modern enough (that's, like, last
decade) to have 'reply-to-mailing-list' and that solves the problem. And that
was a plural you, if I wanted to get all those useless duplicates of replies
to my mails, I would have said so.



I use an actual Seamonkey and it has no reply-to-mailing-list but 
only a reply-to-all. Please tell me a mail client for WinXP and for 
Windows 7, that has got this kind of replying.


Kind regards
Regina

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] File not found: cairocanvas.uno.so in smoketestoo_native

Riccardo Magliocchetti wrote:
 The attached patch is enough to give me a succesfull make
 dev-install. And the build even run :)
 
Thanks, good catch - while at it, killed the silly
UNX/MAC/but-not-X11 crazy there, if cairocanvas is built, it should
surely be packaged as well.

Just to confirm, I assume your patch is under our LGPLv3+/MPL
project license?

Cheers,

-- Thorsten


pgpCvkmXAT9qP.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject


On 01/25/2012 12:04 PM, Lubos Lunak wrote:

if I wanted to get all those useless duplicates of replies to my
mails, I would have said so.


This might be a controversial issue.  While I too feel I don't require 
to receive a personal to/cc in a response to a mail I sent to the list, 
I already got (indirect) complaint that people did not notice my replies 
to their mails-to-list when I sent the reply to the list only.  So, I 
got into the habit of reply-all.


Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] File not found: cairocanvas.uno.so in smoketestoo_native

2012-01-25 Thread Riccardo Magliocchetti


Il 25/01/2012 12:04, Thorsten Behrens ha scritto:

Riccardo Magliocchetti wrote:

The attached patch is enough to give me a succesfull make
dev-install. And the build even run :)


Thanks, good catch - while at it, killed the silly
UNX/MAC/but-not-X11 crazy there, if cairocanvas is built, it should
surely be packaged as well.

Just to confirm, I assume your patch is under our LGPLv3+/MPL
project license?


Sure, thanks!

--
Riccardo Magliocchetti
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

On Wednesday 25 of January 2012, Regina Henschel wrote:
 Hi,

 Lubos Lunak schrieb:
  On Tuesday 24 of January 2012, khagaroth wrote:
  While at it, it would be nice to also set Reply-To:
  libreoffice@lists.freedesktop.org.
 
Oh, well, that's something people will probably never agree on *shrug*.
  You just need to get a mail client that is modern enough (that's, like,
  last decade) to have 'reply-to-mailing-list' and that solves the problem.
  And that was a plural you, if I wanted to get all those useless
  duplicates of replies to my mails, I would have said so.

 I use an actual Seamonkey and it has no reply-to-mailing-list but
 only a reply-to-all. Please tell me a mail client for WinXP and for
 Windows 7, that has got this kind of replying.

 I checked Thunderbird on Linux and it has this, so I expect the Windows 
version has it as well. There also seems to exist an extension for Seamonkey 
that hacks it in (http://www.juergen-ernst.de/addons/replytolist.html). But 
otherwise, yeah, the sarcastic comment about last decade sadly was there for 
a reason.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Jan Holesovsky

Hi Tim,

On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote:

 thanks for the information, I have attached a new patch and also 25% is 
 enforced like Stefan requested.

Great stuff - I've pushed that:

http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d2ddc161e4b296febe9e54c3cfc9270310bfe

I did a minor stylistic cleanup - I've hidden the helper functions
(supposedly you did not want to make them public?), and reduced the
indentation in zoomtools.cxx; no point in having the entire file
starting at 8th position - I hope it is OK for you :-)

Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better
here, the 1.1 means way too much wheel rotation to increase / decrease
the zoom considerably; but of course can be changed easily when another
value feels better.  And now with your nice embedding of this stuff,
even the pre-defined values would be easy to implement, should there be
demand for that - nice work!

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-5] send-feedback patch (was: Re: minutes of ESC call ...)


On Tue, 2012-01-24 at 23:30 +0100, Thorsten Behrens wrote:
  Let's push this to -3-5 after the 3.5.0 branch-off.
  
 That would be now - Stefan, Caolan, this is a late, but IMO very
 useful feature (for 3.5.1, I suggest), and needs two more approvals
 from differently affiliated people.

I attach the fairly obvious patch; you have a 3rd ack from me. IIRC we
dropped the requirement for inter-organisation approval a while back.

Anyhow - be that as it may, I'm interested in how we're going to send
the properties of the system to this form: the exact version, the
component, etc. AFIACS we send people to a plain URL currently: much
better than nothing, but could be improved (?).

Christian, how would you recommend improving upon:

+::rtl::OUString 
sURL(RTL_CONSTASCII_USTRINGPARAM(http://hub.libreoffice.org/file-a-bug/;));
+try
+{
+uno::Reference com::sun::star::system::XSystemShellExecute  
xSystemShellExecute(
+::comphelper::getProcessServiceFactory()-createInstance(
+
DEFINE_CONST_UNICODE(com.sun.star.system.SystemShellExecute) ), 
uno::UNO_QUERY_THROW );
+xSystemShellExecute-execute( sURL, ::rtl::OUString(),  
com::sun::star::system::SystemShellExecuteFlags::DEFAULTS );

Can we mangle that stuff into the URL somehow ? :-) [ I'm ignorant of
the server side ]

ATB,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot
From 924d0bdd47ed895592332714be8ee32afe1acebb Mon Sep 17 00:00:00 2001
From: Ivan Timofeev timofeev@gmail.com
Date: Wed, 18 Jan 2012 22:47:58 +0400
Subject: [PATCH] add the Send Feedback... help menu item

---
 basctl/uiconfig/basicide/menubar/menubar.xml   |3 +-
 chart2/uiconfig/menubar/menubar.xml|3 +-
 dbaccess/uiconfig/dbapp/menubar/menubar.xml|3 +-
 dbaccess/uiconfig/dbquery/menubar/menubar.xml  |3 +-
 dbaccess/uiconfig/dbrelation/menubar/menubar.xml   |3 +-
 dbaccess/uiconfig/dbtable/menubar/menubar.xml  |3 +-
 dbaccess/uiconfig/dbtdata/menubar/menubar.xml  |3 +-
 .../uiconfig/sbibliography/menubar/menubar.xml |3 +-
 framework/uiconfig/startmodule/menubar/menubar.xml |3 +-
 .../org/openoffice/Office/UI/GenericCommands.xcu   |5 
 reportdesign/uiconfig/dbreport/menubar/menubar.xml |3 +-
 sc/uiconfig/scalc/menubar/menubar.xml  |3 +-
 sd/uiconfig/sdraw/menubar/menubar.xml  |3 +-
 sd/uiconfig/simpress/menubar/menubar.xml   |3 +-
 sfx2/inc/sfx2/sfxsids.hrc  |1 +
 sfx2/sdi/appslots.sdi  |4 +++
 sfx2/sdi/sfx.sdi   |   25 
 sfx2/source/appl/appserv.cxx   |   16 
 starmath/uiconfig/smath/menubar/menubar.xml|3 +-
 sw/uiconfig/sglobal/menubar/menubar.xml|3 +-
 sw/uiconfig/sweb/menubar/menubar.xml   |3 +-
 sw/uiconfig/swform/menubar/menubar.xml |3 +-
 sw/uiconfig/swreport/menubar/menubar.xml   |3 +-
 sw/uiconfig/swriter/menubar/menubar.xml|3 +-
 sw/uiconfig/swxform/menubar/menubar.xml|3 +-
 25 files changed, 91 insertions(+), 20 deletions(-)

diff --git a/basctl/uiconfig/basicide/menubar/menubar.xml b/basctl/uiconfig/basicide/menubar/menubar.xml
index 15d4fcd..0d7ecd7 100644
--- a/basctl/uiconfig/basicide/menubar/menubar.xml
+++ b/basctl/uiconfig/basicide/menubar/menubar.xml
@@ -83,8 +83,9 @@
 menu:menuitem menu:id=.uno:HelpIndex/
 menu:menuitem menu:id=.uno:ExtendedHelp/
 menu:menuseparator/
-menu:menuitem menu:id=.uno:ShowLicense/
+menu:menuitem menu:id=.uno:SendFeedback/
 menu:menuseparator/
+menu:menuitem menu:id=.uno:ShowLicense/
 menu:menuitem menu:id=.uno:ShowCredits/
 menu:menuitem menu:id=.uno:About/
 /menu:menupopup
diff --git a/chart2/uiconfig/menubar/menubar.xml b/chart2/uiconfig/menubar/menubar.xml
index 3c50167..a52dff8 100644
--- a/chart2/uiconfig/menubar/menubar.xml
+++ b/chart2/uiconfig/menubar/menubar.xml
@@ -147,8 +147,9 @@
 menu:menuitem menu:id=.uno:HelpIndex/
 menu:menuitem menu:id=.uno:ExtendedHelp/
 menu:menuseparator/
-menu:menuitem menu:id=.uno:ShowLicense/
+menu:menuitem menu:id=.uno:SendFeedback/
 menu:menuseparator/
+menu:menuitem menu:id=.uno:ShowLicense/
 menu:menuitem menu:id=.uno:ShowCredits/
 menu:menuitem menu:id=.uno:About/
 /menu:menupopup
diff --git a/dbaccess/uiconfig/dbapp/menubar/menubar.xml b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
index a76fda5..0367d7e 100644
--- a/dbaccess/uiconfig/dbapp/menubar/menubar.xml
+++ b/dbaccess/uiconfig/dbapp/menubar/menubar.xml
@@

Re: [Libreoffice] Changing list setup to not add to subject

On Wednesday 25 of January 2012, Stephan Bergmann wrote:
 On 01/25/2012 12:04 PM, Lubos Lunak wrote:
  if I wanted to get all those useless duplicates of replies to my
  mails, I would have said so.

 This might be a controversial issue.  While I too feel I don't require
 to receive a personal to/cc in a response to a mail I sent to the list,
 I already got (indirect) complaint that people did not notice my replies
 to their mails-to-list when I sent the reply to the list only.  So, I
 got into the habit of reply-all.

 Well, I can start complaining about the extra copies whenever I get one if 
that helps anything :).

 There exists http://cr.yp.to/proto/replyto.html , which should help with 
this. There's of course the usual problem of some mail clients not bothering 
to support useful functionality, but if the reply-to-munging-harmful crowd 
can waive that argument off, I don't see why the same couldn't be done here. 

 Besides, there's the much simpler way of getting the copy by making a filter 
rule on In-Reply-To:.*email*.

 Another reason is that this gives everybody a choice whether they want the 
extra copy or not, whereas reply-to-all forces everybody to get the duplicate 
(and the filter-it-out suggestion is ridiculous, what if somebody really 
explicitly also CC-ed me e.g. because it's urgent?).

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] UPDATE: Swedish hunspell dictionary

2012-01-25 Thread Andras Timar

Hi,

2012/1/25 Göran Andersson goran.anders...@init.se:
 The Swedish spell checking dictionary has been updated.
 The latest version will always be available at
 http://extensions.libreoffice.org/extension-center/swedish-spelling-dictionary-den-stora-svenska-ordlistan
 (it can also be downloaded from http://code.google.com/p/dsso/downloads/list).

 Please include the latest version in your next release (the latest
 version of the dictionary is 1.51, the one currently distributed with
 LibreOffice is 1.48).
 _
In fact it was 1.50 in LibreOffice 3.5 RC2, but thanks for the update anyway!

http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=203e688ea667c26d0885a9d62c5a4c90090edb0b
Please review and cherry pick to 3-5 and 3-5-0.

Thanks,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] More information in tinderbox failure mails.

http://cgit.freedesktop.org/libreoffice/contrib/buildbot/commit/?id=718756193736a7b0918b6ed3c62a5680b51614f2 
adds more information to tinderbox failure mails, which should 
(hopefully) make it easier for people to understand what's going on:


* The name of the tinderbox and of the branch (i.e., MASTER or 
libreoffice-3-5) is included in the mail's subject.


* The name of the branch and the starttime token are included in the 
Tinderbox info block at the top of the mail's body.  The starttime 
token is the same one that is listed as tinderbox: starttime in the 
Build Data section of the build logs available at 
http://tinderbox.libreoffice.org/, and should help find the full build 
data corresponding to a failure mail.


It would be great if tinderbox owners could update to this revision.

Stephan
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] More information in tinderbox failure mails.


On Wed, 2012-01-25 at 12:57 +0100, Stephan Bergmann wrote:
 * The name of the tinderbox and of the branch (i.e., MASTER or 
 libreoffice-3-5) is included in the mail's subject.

Lovely.

 * The name of the branch and the starttime token are included in the 
 Tinderbox info block at the top of the mail's body.  The starttime 
 token is the same one that is listed as tinderbox: starttime in the

Thanks for that ! :-)

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Wed, 2012-01-25 at 11:52 +0100, Andras Timar wrote:
Hi,

Yesterday two bugs came to my attention.
fdo#44208 - under Windows crash occurred when user selected Tools -
Options in selected Indian locales

Doesn't seem to be a lot of info wrt backtraces or anything like that in
that bug. I've seen crashes like this before with FreeSans and icu so my
instinct would be to blame icu :-)

In which case it *might* be possible to figure that crash out by copying
the windows fonts to a linux box under ~/.fonts and running under
valgrind and scrolling through the font list

fdo#45107 - under Windows garbage characters appeared at random places
in selected Indian locales

I would like to have these commits in libreoffice-3-5,
libreoffice-3-5-0, and libreoffice-3-4. These are rather serious
issues, that make Indian localizations useless under Windows.

On the basis that we should keep language tags as short as possible when
there isn't ambiguity I'm happy enough to have e.g. hi instead of
hi-IN and so on, while zh-CN has to remain as zh-CN given that there
are two scripts in use in different territories to write Chinese.

I *presume* this isn't simply some casing cockup ?, e.g. hi-IN vs hi-in
or some such. Not entirely sure where the code is for reading those and
matching them against the requested locale.

Well, I updated it a little to show where fontconfig comes into the
picture under Unix, which is the bit I know best.

If for example ta-IN entry was ignored, and it works with ta, then
we need to review the whole file, because many locales have country
codes, while UI localization uses only language code. Should we add
entries for locales which are not there?

In the general case, stuff like hu-HU should probably be just hu, its
not like Hungarian is some territory outside of Hungary gets written in
a different script (I presume anyway), so following the as short as is
possible rule, while e.g. pa-IN is a bit more problematic given the
multiple scripts used to write Punjabi in different territories and best
left alone without a bit of research to determine which script a bare
pa would best default to.

Moreover, I'm not sure if the
recently fixed fdo#43984 works at all (it uses zh-cn and zh-hk locale
codes).

You mean
http://cgit.freedesktop.org/libreoffice/core/commit/?id=969abdc19a4d686b0288fee3d8e223df04becc7e
It better work :-), because like the pa-IN/pa-PK example zh-TW and zh-HK
are Traditional Chinese territories while zh-CN is Simplified Chinese so
need different lists of preferred fonts for the two different scripts.

Anyway, best would be to find the bit of locale matching code and see
why it doesn't do the right thing, but either way the final outcome of

82e0266b05dd53d0ce8b12bd5c76ae25872b87a9
86bf32c487852f4e466b27320e3724266cb53dba
9b55eeba78d4e6418750a12c3dad4b42e2dd3f03

looks sane to me

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] More information in tinderbox failure mails.

2012-01-25 Thread Jan Holesovsky

Hi Stephan,

On 2012-01-25 at 12:57 +0100, Stephan Bergmann wrote:

 It would be great if tinderbox owners could update to this revision.

SLED11 (master Linux, libreoffice-3-5 Linux, master MinGW and
libreoffice-3-5 MinGW), and Windows fast boxes restarted.

Thank you,
Kendy

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] Binary URP bridge already disposed

2012-01-25 Thread Execute SARL


Hi,

I'm digging the UNO protocol to understand why my Delphi URP client 
freeze on a local host.


If I use (for debug purpose) always the same ID for an XInputStream, 
like '20767c8;uno[0];104;80fb13f4cf34cebb8f2971cc166b5d8' Office raise 
an exception even after a restart of my client.


com.sun.star.uno.RuntimeException
Binary URP bridge already disposed
(Thread : ...my thread ID...)

Why, and how, Office still know about this ID even after a client 
deconnexion and restart ? I have to restart Office to reuse this ID in a 
loadCompontFromURL request.


Regards
Paul
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW-3-5] send-feedback patch (was: Re: minutes of ESC call ...)

Michael Meeks wrote:
   Anyhow - be that as it may, I'm interested in how we're going to send
 the properties of the system to this form: the exact version, the
 component, etc. AFIACS we send people to a plain URL currently: much
 better than nothing, but could be improved (?).
 
Sure - but only starts to be a requirement past the first version we
release with this. ;)

There are a few more open todos, among them an icon for the
startcenter. Still, I think it's valuable to have the core feature
and the strings in early.

Cheers,

-- Thorsten


pgph49nyLbuag.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Petr Mladek pmla...@suse.cz changed:

   What|Removed |Added

 OS/Version|All |Linux (All)
 Depends on||45219

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

--- Comment #142 from Petr Mladek pmla...@suse.cz 2012-01-25 05:31:01 PST ---
(In reply to comment #138)
 In one bug hard to distinguish regression from new functionality:
 Bug 35735 - Save As defaults to current document format

It was already in LO-3.4. The current state seems reasonable. Just the
description is slightly confusing. People do not complain about LO-3.4 =
normal bug.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

2012-01-25 Thread Rainer Bielefeld


Thorsten Behrens schrieb:


for the upcoming new version 3.5.0, the RC2 builds now start to be
available on pre-releases.[...]

If you've a bit of time, please give them a try  report *critical*


Hi,

I got a virus alert, please see [Bug 45227] New: Virus Kazy.7720 
detected on installation By Bit defender


Might be a pest if lots of uses see the same message.

CU

Rainer
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Petr Mladek pmla...@suse.cz changed:

   What|Removed |Added

   Platform|x86-64 (AMD64)  |All
 OS/Version|Linux (All) |All

--- Comment #143 from Petr Mladek pmla...@suse.cz 2012-01-25 06:02:04 PST ---
Heh, I have modified the platform setting by mistake.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Wed, 2012-01-25 at 12:03 +, Caolán McNamara wrote:
 Anyway, best would be to find the bit of locale matching code and see
 why it doesn't do the right thing

The default fonts get selected via OutputDevice::GetDefaultFont in
vcl/source/gdi/outdev3.cxx which calls
DefaultFontConfiguration::getDefaultFont
in unotools/source/config/fontcfg.cxx which calls tryLocale with the
full locale string, then with variant cleared and then with Country
cleared if the earlier attempts fail

so...

if in master if I set my locale via export LANG=ta_IN.UTF-8 I get with
the attached debugging patch...

searching for a node for ta IN  for type CTL_TEXT
result is 
searching for a node for ta   for type CTL_TEXT
result is Lohit Tamil;Latha;Lucidasans;Lucida Sans;Arial Unicode MS

so it does the right thing.

if I revert all the changes to officecfg I get..

searching for a node for ta IN  for type CTL_TEXT
result is Lohit Tamil;Latha;Lucidasans;Lucida Sans;Arial Unicode MS

so it does the right thing there too for me.

So it seems to have been working correctly under Linux anyway. Can
you find out what the value of aLocale is in
OutputDevice::GetDefaultFont under windows for your failing case, i.e. a
trace with the attached patch in place.

C.
diff --git a/unotools/source/config/fontcfg.cxx b/unotools/source/config/fontcfg.cxx
index cab7eb3..7cac6ad 100644
--- a/unotools/source/config/fontcfg.cxx
+++ b/unotools/source/config/fontcfg.cxx
@@ -158,6 +158,11 @@ DefaultFontConfiguration::DefaultFontConfiguration()
 aLoc.Variant = OUString();
 m_aConfig[ aLoc ] = LocaleAccess();
 m_aConfig[ aLoc ].aConfigLocaleString = pLocaleStrings[i];
+fprintf(stderr, default-font entry for \%s\ \%s\ \%s\ added\n,
+rtl::OUStringToOString(aLoc.Language, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(aLoc.Country, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(aLoc.Variant, RTL_TEXTENCODING_UTF8).getStr()
+);
 }
 }
 }
@@ -193,6 +198,13 @@ DefaultFontConfiguration::~DefaultFontConfiguration()
 
 OUString DefaultFontConfiguration::tryLocale( const Locale rLocale, const OUString rType ) const
 {
+fprintf(stderr, searching for a node for \%s\ \%s\ \%s\ for type %s\n,
+rtl::OUStringToOString(rLocale.Language, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(rLocale.Country, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(rLocale.Variant, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(rType, RTL_TEXTENCODING_UTF8).getStr()
+);
+
 OUString aRet;
 
 boost::unordered_map Locale, LocaleAccess, LocaleHash ::const_iterator it =
@@ -237,6 +249,7 @@ OUString DefaultFontConfiguration::tryLocale( const Locale rLocale, const OUStr
 }
 }
 
+fprintf(stderr, result is \%s\\n, rtl::OUStringToOString(aRet, RTL_TEXTENCODING_UTF8).getStr());
 return aRet;
 }
 
diff --git a/vcl/source/gdi/outdev3.cxx b/vcl/source/gdi/outdev3.cxx
index bf2628c..044375b 100755
--- a/vcl/source/gdi/outdev3.cxx
+++ b/vcl/source/gdi/outdev3.cxx
@@ -474,6 +474,8 @@ Font OutputDevice::GetDefaultFont( sal_uInt16 nType, LanguageType eLang,
 {
 OSL_TRACE( OutputDevice::GetDefaultFont() );
 
+fprintf(stderr, vcl: search for font for lang %x of type %d\n, eLang, nType);
+
 com::sun::star::lang::Locale aLocale;
 if( eLang == LANGUAGE_NONE || eLang == LANGUAGE_SYSTEM || eLang == LANGUAGE_DONTKNOW )
 {
@@ -484,9 +486,20 @@ Font OutputDevice::GetDefaultFont( sal_uInt16 nType, LanguageType eLang,
 MsLangId::convertLanguageToLocale( eLang, aLocale );
 }
 
+fprintf(stderr, vcl: search for \%s\ \%s\ \%s\\n,
+rtl::OUStringToOString(aLocale.Language, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(aLocale.Country, RTL_TEXTENCODING_UTF8).getStr(),
+rtl::OUStringToOString(aLocale.Variant, RTL_TEXTENCODING_UTF8).getStr()
+);
+
+
 utl::DefaultFontConfiguration rDefaults = utl::DefaultFontConfiguration::get();
 String aSearch = rDefaults.getUserInterfaceFont( aLocale ); // ensure a fallback
 String aDefault = rDefaults.getDefaultFont( aLocale, nType );
+
+fprintf(stderr, vcl: default font string is %s\n, rtl::OUStringToOString(aDefault,
+RTL_TEXTENCODING_UTF8).getStr());
+
 if( aDefault.Len() )
 aSearch = aDefault;
 
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Tim Hardeck

Hi Kendy,

thanks for the commit and cleanup. I also thought that 1.2 was a better fit so 
fine with me.

Regards
Tim

On Wednesday 25 January 2012 12:46:02 Jan Holesovsky wrote:
 Hi Tim,
 
 On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote:
 
  thanks for the information, I have attached a new patch and also 25% is 
  enforced like Stefan requested.
 
 Great stuff - I've pushed that:
 
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d2ddc161e4b296febe9e54c3cfc9270310bfe
 
 I did a minor stylistic cleanup - I've hidden the helper functions
 (supposedly you did not want to make them public?), and reduced the
 indentation in zoomtools.cxx; no point in having the entire file
 starting at 8th position - I hope it is OK for you :-)
 
 Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better
 here, the 1.1 means way too much wheel rotation to increase / decrease
 the zoom considerably; but of course can be changed easily when another
 value feels better.  And now with your nice embedding of this stuff,
 even the pre-defined values would be easy to implement, should there be
 demand for that - nice work!
 
 Thank you,
 Kendy
 
 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice
 

-- 
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 
16746 (AG Nürnberg)
Maxfeldstr. 5, 90409 Nürnberg, Germany
T: +49 (0) 911 74053-0  F: +49 (0) 911 74053-483
http://www.suse.de/


signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available

2012-01-25 Thread Volker Merschmann

Hi,

2012/1/25 Rainer Bielefeld libreoff...@bielefeldundbuss.de:
 Thorsten Behrens schrieb:

 for the upcoming new version 3.5.0, the RC2 builds now start to be
 available on pre-releases.[...]


 I got a virus alert, please see [Bug 45227] New: Virus Kazy.7720 detected
 on installation By Bit defender

 Might be a pest if lots of uses see the same message.

No problem here with Avira Antivirus on Windows XP.

Volker


-- 
Volker Merschmann
Member of The Document Foundation
http://www.documentfoundation.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW:3-5-0] UPDATE: Swedish hunspell dictionary

Andras Timar píše v St 25. 01. 2012 v 12:55 +0100:

 http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=203e688ea667c26d0885a9d62c5a4c90090edb0b
 Please review and cherry pick to 3-5 and 3-5-0.

Looks fine = pushed into 3-5, see
http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?h=libreoffice-3-5id=8774041bbdbfe2419b07f9704a61c8ebbb5ddb19

Two more approvals needed for 3-5-0 branch.


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW:3-5-0] UPDATE: Swedish hunspell dictionary

On Wed, 2012-01-25 at 15:35 +0100, Petr Mladek wrote:
 Two more approvals needed for 3-5-0 branch.

+ack from me

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Fridrich Strba


On 24/01/12 16:26, Lubos Lunak wrote:

- it leaves less room for the actually important part of the subject when
browsing mail
- which gets expecially insane when forwarding mails futher or between such
mailing lists
- it makes adding tags like [PUSHED] more cumbersome
- one would hope that by 2012 everybody interested in filtering mail can
actually do it based on the List-Id header, which has the additional benefit
of really filtering mails from the mailing list


Because of the huge traffic of this list, I had to go to gmail with it. 
Now, when I access that gmail from my phone, I don't want to have 
hundreds of messages messing up the actual inbox. And Gmail allows 
server-side filtering only on from/to/subject and has the words/does not 
have the words and presence of attachment.


I would really object to this change vehemently. Whether my voice counts 
something, that is other thing though.


Cheers

Fridrich
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

Lubos Lunak wrote:
 (and the filter-it-out suggestion is ridiculous, what if somebody really 
 explicitly also CC-ed me e.g. because it's urgent?).
 
http://help.cselabs.umn.edu/email/procmail ;)

-- Thorsten, who simply can't resist the bikeshedding


pgpORhGZR0Ryo.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

On Wednesday 25 of January 2012, Fridrich Strba wrote:
 On 24/01/12 16:26, Lubos Lunak wrote:
  - it leaves less room for the actually important part of the subject when
  browsing mail
  - which gets expecially insane when forwarding mails futher or between
  such mailing lists
  - it makes adding tags like [PUSHED] more cumbersome
  - one would hope that by 2012 everybody interested in filtering mail can
  actually do it based on the List-Id header, which has the additional
  benefit of really filtering mails from the mailing list

 Because of the huge traffic of this list, I had to go to gmail with it.
 Now, when I access that gmail from my phone, I don't want to have
 hundreds of messages messing up the actual inbox. And Gmail allows
 server-side filtering only on from/to/subject and has the words/does not
 have the words and presence of attachment.

http://googlesystem.blogspot.com/2007/11/filter-messages-from-mailing-list-in.html
 
disagrees.

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

On Wednesday 25 of January 2012, Thorsten Behrens wrote:
 Lubos Lunak wrote:
  (and the filter-it-out suggestion is ridiculous, what if somebody really
  explicitly also CC-ed me e.g. because it's urgent?).

 http://help.cselabs.umn.edu/email/procmail ;)

 Cool! So what exactly is the rule that makes procmail detect whether I'm in 
CC because the sender was lazy and did reply-to-all or because they actually 
wanted me to be in CC?

-- 
 Lubos Lunak
 l.lu...@suse.cz
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Wrong cast to css.table.BorderLine2

2012-01-25 Thread Eike Rathke

Hi,

On Wednesday, 2012-01-25 11:17:54 +0100, Stephan Bergmann wrote:

 On 01/25/2012 09:48 AM, Cedric Bosdonnat wrote:
 Hum, I'll have a look at that... but my problem with BorderLine and
 BorderLine2 is that the second one should be used everywhere... and that
 sometimes isn't the case.
 
 You apparently need a css.table.TableBorder2 that has members of
 type BorderLine2 instead of plain BorderLine.

Right. Just to say that I'm wading my way through this as Cedric is
occupied with Writer stuff. This is going to be a larger patch that
will also have to go into 3.5.0

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgpNWX3Gb8XzZ.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 43869, which changed state.

Bug 43869 Summary: Paste special as RTF inserted at wrong position, undo stack 
damaged
https://bugs.freedesktop.org/show_bug.cgi?id=43869

   What|Old Value   |New Value

 Resolution||FIXED
 Status|NEW |RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW:3-5-0] UPDATE: Swedish hunspell dictionary

2012-01-25 Thread Norbert Thiebaud

2012/1/25 Petr Mladek pmla...@suse.cz:
 Andras Timar píše v St 25. 01. 2012 v 12:55 +0100:

 http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?id=203e688ea667c26d0885a9d62c5a4c90090edb0b
 Please review and cherry pick to 3-5 and 3-5-0.

 Looks fine = pushed into 3-5, see
 http://cgit.freedesktop.org/libreoffice/dictionaries/commit/?h=libreoffice-3-5id=8774041bbdbfe2419b07f9704a61c8ebbb5ddb19

 Two more approvals needed for 3-5-0 branch.

+1 from me. and pushed

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

2012-01-25 Thread Andras Timar

2012/1/25 Caolán McNamara caol...@redhat.com:

 So it seems to have been working correctly under Linux anyway. Can
 you find out what the value of aLocale is in
 OutputDevice::GetDefaultFont under windows for your failing case, i.e. a
 trace with the attached patch in place.

Result on Windows is confusing. My test language was Hindi (hi).

Case 1 - without the patch in officecfg
...
default-font entry for hi IN  added
...
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
searching for a node for hi   for type UI_SANS
result is 
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
searching for a node for hi IN  for type UI_SANS
result is Lohit Hindi;Mangal;Lucidasans;Lucida Sans;Andale Sans
UI;Arial Unicode MS;Lucida Sans Unicode;clearlyU
searching for a node for hi IN  for type UI_SANS
result is Lohit Hindi;Mangal;Lucidasans;Lucida Sans;Andale Sans
UI;Arial Unicode MS;Lucida Sans Unicode;clearlyU
searching for a node for hi IN  for type UI_SANS
result is Lohit Hindi;Mangal;Lucidasans;Lucida Sans;Andale Sans
UI;Arial Unicode MS;Lucida Sans Unicode;clearlyU
...
Some characters are corrupted.

Case 2 - with the patch in officecfg
...
default-font entry for hi   added
...
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
searching for a node for hi   for type UI_SANS
result is Lohit Hindi;Mangal;Lucidasans;Lucida Sans;Andale Sans
UI;Arial Unicode MS;Lucida Sans Unicode;clearlyU
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
searching for a node for en   for type UI_SANS
result is Andale Sans UI;Arial Unicode MS;Lucida Sans
Unicode;Tahoma;DejaVu Sans;Albany AMT;Albany;Arial;Nimbus Sans
L;Interface User;WarpSans;Geneva;Tahoma;MS Sans
Serif;Helv;Dialog;Lucida;Helvetica;Charcoal;Chicago;Helmet;Interface
System;Sans Serif
...
All characters are correct.

BTW it was not called from outdev3.cxx, I did not get log messages
from there, until I created a new document.

Cheers,
Andras
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fdo#43869 use the old rtf importer for paste

2012-01-25 Thread Miklos Vajna

Hi,

See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=bb147bbb801b53dba8928340df7e2aa2d4545349

Could somebody sign-off and push to -3-5, please?

Thanks,

Miklos


pgpNpwHoNVbcT.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PUSHED] Re: [PATCH] optimized zoom to use more common intervals

2012-01-25 Thread Stefan Knorr (Astron)

Sounds good. Had checked Tim's original patch yesterday and liked the
behaviour so far.

Astron.

On 25/01/2012, Tim Hardeck thard...@suse.de wrote:
 Hi Kendy,

 thanks for the commit and cleanup. I also thought that 1.2 was a better fit
 so fine with me.

 Regards
 Tim

 On Wednesday 25 January 2012 12:46:02 Jan Holesovsky wrote:
 Hi Tim,

 On 2012-01-24 at 17:38 +0100, Tim Hardeck wrote:

  thanks for the information, I have attached a new patch and also 25% is
  enforced like Stefan requested.

 Great stuff - I've pushed that:

 http://cgit.freedesktop.org/libreoffice/core/commit/?id=315d2ddc161e4b296febe9e54c3cfc9270310bfe

 I did a minor stylistic cleanup - I've hidden the helper functions
 (supposedly you did not want to make them public?), and reduced the
 indentation in zoomtools.cxx; no point in having the entire file
 starting at 8th position - I hope it is OK for you :-)

 Also I changed the ZOOM_FACTOR from 1.1 to 2^(1/4), it feels better
 here, the 1.1 means way too much wheel rotation to increase / decrease
 the zoom considerably; but of course can be changed easily when another
 value feels better.  And now with your nice embedding of this stuff,
 even the pre-defined values would be easy to implement, should there be
 demand for that - nice work!

 Thank you,
 Kendy

 ___
 LibreOffice mailing list
 LibreOffice@lists.freedesktop.org
 http://lists.freedesktop.org/mailman/listinfo/libreoffice


 --
 SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer,
 HRB 16746 (AG Nürnberg)
 Maxfeldstr. 5, 90409 Nürnberg, Germany
 T: +49 (0) 911 74053-0  F: +49 (0) 911 74053-483
 http://www.suse.de/

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5-0] Fix pivot table's date and number grouping, take 2

Kohei Yoshida píše v Út 24. 01. 2012 v 16:53 -0500:
 Again, this fixes
 
 https://bugs.freedesktop.org/show_bug.cgi?id=45067
 
 Since we've already branched for 3.5.0, I'll need three sign-off's to
 get this piece into 3.5.0 final.  Reviews and sign-off will be
 appreciated.

Works well here. It correctly creates pivot table with dates and with
strings and allows to group them accordingly. The patch looks sensible
= pushed to 3-5 branch, see 
http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=6cc0bf1394ef9d6941d38a55a6155688a6f9bd43

We need two more reviews for 3-5-0 branch.


Best Regards,
Petr


PS: I attach another test file from Kohei that allows to test both types
(dates and strings) when creating the pivot table.


test-pivot.ods
Description: application/vnd.oasis.opendocument.spreadsheet
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] 3-5, 3-5-0, 3-4 corrupted Indic characters and crash under Windows fdo#44208, fdo#45107

On Wed, 2012-01-25 at 16:44 +0100, Andras Timar wrote:
 Result on Windows is confusing. My test language was Hindi (hi).
 
 Case 1 - without the patch in officecfg
 ...
 default-font entry for hi IN  added
...
 searching for a node for hi   for type UI_SANS

 BTW it was not called from outdev3.cxx

Righteo, so might as well get the backtrace from unotools when the
locale Language is hi and locale Country isEmpty() and see where that
bare hi comes from. 

I suspect that hi was basically injected in from from GetUILocale
maybe and *probably your /path/to/3/user/registrymodifications.xcu has
a oor:name=UILocale ... valuehi/value, right ? not
valuehi-IN/value.

If that's the case, then fair enough, I'm happy that there's nothing
horribly busted here and its simply an unexpected side-effect of
renaming hi-IN etc to hi uncovering that the config for default fonts
was over-specialized.

Assuming that UILocale is set as hi in the config then I suspect that
comes originally from code like optgdlg.cxx:1482 aLangString =
seqInstalledLanguages[d-1] where the name of the language comes from the
name of the installed language packs.

C.

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5-0] Fix pivot table's date and number grouping, take 2

2012-01-25 Thread Eike Rathke

Hi,

On Wednesday, 2012-01-25 17:36:02 +0100, Petr Mladek wrote:

 Kohei Yoshida píše v Út 24. 01. 2012 v 16:53 -0500:
  https://bugs.freedesktop.org/show_bug.cgi?id=45067
 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=6cc0bf1394ef9d6941d38a55a6155688a6f9bd43
 We need two more reviews for 3-5-0 branch.

Found fixed. One more review and a sign-off needed.

  Eike

-- 
LibreOffice Calc developer. Number formatter stricken i18n transpositionizer.
GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3  9E96 2F1A D073 293C 05FD


pgp8ViTJcJpQP.pgp
Description: PGP signature
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread khagaroth

On Wed, Jan 25, 2012 at 12:04 PM, Lubos Lunak l.lu...@suse.cz wrote:
 On Tuesday 24 of January 2012, khagaroth wrote:
 While at it, it would be nice to also set Reply-To:
 libreoffice@lists.freedesktop.org.

  Oh, well, that's something people will probably never agree on *shrug*. You
 just need to get a mail client that is modern enough (that's, like, last
 decade) to have 'reply-to-mailing-list' and that solves the problem. And that
 was a plural you, if I wanted to get all those useless duplicates of replies
 to my mails, I would have said so.

Tell that to google. I don't understand how they can support filtering
by mailing list so well, but don't have a 'reply to mailing list'
option.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] NetBSD fixes

2012-01-25 Thread Francois Tigeot

Hi,

I've just pushed two small fixes to -master and I'd like to have them
cherry-picked to the 3.5 and 3.5.0 branches:

* Ensure Env.Host.sh always return a zero exit code
http://cgit.freedesktop.org/libreoffice/core/commit/?id=a79889083b25d69ae6b801ed8cee90b5dd9199c4

* NetBSD also needs the internal gethostbyname_r() implementation
http://cgit.freedesktop.org/libreoffice/core/commit/?id=5f32a5558e8672ed56d5d393228aefacc632846c

Thanks for reviewing them,

-- 
Francois Tigeot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Fridrich Strba


OK, thanks for the pointer. I withdraw my vehement opposition then

F.

On 25/01/12 16:25, Lubos Lunak wrote:

http://googlesystem.blogspot.com/2007/11/filter-messages-from-mailing-list-in.html
disagrees.



___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW 3-4][PUSHED 3-4] fdo#43193: fix rotation of shapes in imported MS documents

Ivan Timofeev píše v St 18. 01. 2012 v 08:43 +0400:
 17.01.2012 16:49, Thorsten Behrens пишет:
  Seen pushed on -3-5
 
 Great, thanks! -3-4 is still pending.

I have ported it for 3-4 (fixed some context). It worked and looked fine
= I pushed it there, see
http://cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4id=3475d300ef29866542007e295569075e592bde66


Best Regards,
Petr

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] LibreOffice / openIndiana ...

Hi guys

I was thrilled to read of your efforts trying to get LibreOffice going
on OpenIndiana; it'd be great to get any patches you have back into the
code.

Having said that - I think we -really- want to discourage use of the
sunpro compiler, and I'd suggest trying to build with gcc/g++ and fixing
that. That is likelier to cause fewer problems in the longer run I think
(though we'll need to rip out a number of compiler conditionals for
solaris at the same time I think). We routinely find  have to
workaround compiler bugs, and the fewer compilers we have to support the
better.

Anyhow - please do ask questions etc. here - hopefully we're a friendly
lot :-) I'd really recommend building from the libreoffice-3-5
code-branch, that is feature frozen and about to get released, whereas
3.4 is some rather ultra deep-frozen branch.

All the best,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Norbert Thiebaud

On Tue, Jan 24, 2012 at 2:48 PM, Michael Meeks michael.me...@suse.com wrote:

 On Tue, 2012-01-24 at 16:26 +0100, Lubos Lunak wrote:
  could this mailing list's configuration be changed to not add the pointless
 [Libreoffice] to the beginning?

        I'd be up for that, in the absence of any violent objections /
 industrial-scale bike-shed construction, lets make a decision at the ESC
 this Thur. :-)

I don't mind the removal of [LibreOffice], but I mind messing with the reply-to

Norbert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [Libreoffice-qa] [ANN] LibreOffice 3.5.0 RC2 available


On Wed, 2012-01-25 at 14:54 +0100, Rainer Bielefeld wrote:
 I got a virus alert, please see [Bug 45227] New: Virus Kazy.7720 
 detected on installation By Bit defender

Grief - these are random, depend on the virus checker and are simply
impossible to guard against.

 Might be a pest if lots of uses see the same message.

Yep - but without some hard-core details ~impossible to defend against.
Many virus checkers do the moral equivalent of:

can we find these sequence of bytes: 0x13 0x67 0xfe 0x78

if so it must be the foo virus ! ;-)

unfortunately, given the number of these things, the short sequences
that are often checked for etc. etc. the # of false-positives is really
rather high, and it's unclear if we can really work around them. Then
again, the way compression works - hopefully if we just change the
version number to rc3 - perhaps it'll perturb the bit causing the
grief ;-)

Thanks,

Michael.

-- 
michael.me...@suse.com  , Pseudo Engineer, itinerant idiot

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs

https://bugs.freedesktop.org/show_bug.cgi?id=37361

Bug 37361 depends on bug 43462, which changed state.

Bug 43462 Summary: findAll doesn't work
https://bugs.freedesktop.org/show_bug.cgi?id=43462

   What|Old Value   |New Value

 Status|NEW |ASSIGNED
 Resolution||FIXED
 Status|ASSIGNED|RESOLVED

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found

Hey,

It would be great if we could backport
http://cgit.freedesktop.org/libreoffice/core/commit/?id=b0af6fd51c644827593f3d69c46dc8074dca0ee3
to 3-5 and 3-5-0.

The patch is extremelly safe and just removes the unnecessary and
wrong usage of ScMarkData in this case. rMark is passed as const
reference now and the range containing the result is in
aMatchedRanges.

If you want to check, I also pushed an api test to
sc/qa/extras/sctablesheetobj.cxx testing that we now return the
correct number of elements.

Regards,
Markus
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] Changing list setup to not add to subject

2012-01-25 Thread Kohei Yoshida

On Wed, 2012-01-25 at 14:05 -0600, Norbert Thiebaud wrote:
 
 I don't mind the removal of [LibreOffice], but I mind messing with the
 reply-to 

Same here.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW] fix for fdo#43462, ScTableSheetObj::findAll returns always the whole sheet if something is found

2012-01-25 Thread Kohei Yoshida

On Wed, 2012-01-25 at 21:19 +0100, Markus Mohrhard wrote:
 Hey,
 
 It would be great if we could backport
 http://cgit.freedesktop.org/libreoffice/core/commit/?id=b0af6fd51c644827593f3d69c46dc8074dca0ee3
 to 3-5 and 3-5-0.
 
 The patch is extremelly safe and just removes the unnecessary and
 wrong usage of ScMarkData in this case. rMark is passed as const
 reference now and the range containing the result is in
 aMatchedRanges.

I concur.  Pushed to the -3-5 branch with my sign-off.

We'll need two more sign-off's to put this into 3-5-0.

Kohei

-- 
Kohei Yoshida, LibreOffice hacker, Calc

___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [PATCH] Making default tab prefix name configurable in Calc

2012-01-25 Thread Albert Thuswaldner

Hi Kohei/LO devs,

 Now, a slightly bigger issue.  The sheet prefix option input box doesn't
 check for valid sheet name.  It even allows an empty one, which is not
 very good.  So, we should at least apply the same restriction as in
 ScDocument::ValidTabName() method (located in document.cxx#250).  You
 can simply call that method from the option page to validate the name
 since that method is static.

 The preferred way to set the restriction is to inspect the new name each
 time the text value in the input box changes.  You can intercept a input
 value change event for the input box to do the inspection and accept or
 reject the new text value.  I believe there are other UI parts that do
 the same thing so hopefully you can find some example code to follow.
 If not, let me know and I'll dig in to find one.


This is an old one, other priorities in life, but now I'm back to
finish this

Can you give me any pointers on how to intercept a input value change
event. I've done some digging (looking for an event listener) but
haven't found it quite yet.

Thanks in advance.

/Albert
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

Re: [Libreoffice] [REVIEW][3-5-0][PUSHED]Fix pivot table's date and number grouping, take 2

Hey,

 Kohei Yoshida píše v Út 24. 01. 2012 v 16:53 -0500:
  https://bugs.freedesktop.org/show_bug.cgi?id=45067
 http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=6cc0bf1394ef9d6941d38a55a6155688a6f9bd43
 We need two more reviews for 3-5-0 branch.

 Found fixed. One more review and a sign-off needed.


Seems to work and looks good. Pushed to 3-5-0 with my sign-off.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice

[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs