[Libreoffice-commits] .: binfilter/bf_svtools binfilter/bf_sw binfilter/bf_xmloff
binfilter/bf_svtools/source/filter.vcl/wmf/svt_winmtf.cxx |2 -
binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx |1
binfilter/bf_xmloff/source/chart/xmloff_SchXMLTableContext.cxx |2 -
binfilter/bf_xmloff/source/core/xmloff_attrlist.cxx|4
+-
binfilter/bf_xmloff/source/draw/xmloff_XMLShapeStyleContext.cxx|2 -
binfilter/bf_xmloff/source/style/xmloff_PageMasterExportPropMapper.cxx |2 -
binfilter/bf_xmloff/source/style/xmloff_PageMasterImportPropMapper.cxx |2 -
binfilter/bf_xmloff/source/style/xmloff_XMLPageExport.cxx |2 -
binfilter/bf_xmloff/source/style/xmloff_xmlexppr.cxx | 20
+-
binfilter/bf_xmloff/source/style/xmloff_xmlnumfe.cxx |6
+--
binfilter/bf_xmloff/source/style/xmloff_xmlnumi.cxx|2 -
binfilter/bf_xmloff/source/style/xmloff_xmlstyle.cxx |2 -
binfilter/bf_xmloff/source/text/xmloff_txtexppr.cxx|2 -
binfilter/bf_xmloff/source/text/xmloff_txtimppr.cxx|2 -
binfilter/bf_xmloff/source/text/xmloff_txtparae.cxx|4
+-
15 files changed, 27 insertions(+), 28 deletions(-)
New commits:
commit 0b54eb6b70f1102a84ee9da01b2c6aea1aa50904
Author: Julien Nabet serval2...@yahoo.fr
Date: Mon May 7 23:13:07 2012 +0200
Some cppcheck cleaning
Change-Id: Ib0dee8fed7c3ac54870024853d0bcdfcb964039d
diff --git a/binfilter/bf_svtools/source/filter.vcl/wmf/svt_winmtf.cxx
b/binfilter/bf_svtools/source/filter.vcl/wmf/svt_winmtf.cxx
index 1310b8c..e13b783 100644
--- a/binfilter/bf_svtools/source/filter.vcl/wmf/svt_winmtf.cxx
+++ b/binfilter/bf_svtools/source/filter.vcl/wmf/svt_winmtf.cxx
@@ -2126,7 +2126,7 @@ void WinMtfOutput::Push() // !! to
be able to access the o
void WinMtfOutput::Pop()
{
// Die aktuellen Daten vom Stack holen
-if( vSaveStack.size() )
+if( !vSaveStack.empty() )
{
// Die aktuelle Daten auf dem Stack sichern
SaveStructPtr pSave( vSaveStack.back() );
diff --git a/binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx
b/binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx
index de2dc23..51814e8 100644
--- a/binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx
+++ b/binfilter/bf_sw/source/core/unocore/sw_unosrch.cxx
@@ -383,7 +383,6 @@ void SwSearchProperties_Impl::FillItemSet(SfxItemSet rSet,
sal_Bool bIsValueSea
}
}
delete pBoxItem;
-delete pBreakItem;
delete pBreakItem ;
delete pAutoKernItem ;
delete pWLineItem;
diff --git a/binfilter/bf_xmloff/source/chart/xmloff_SchXMLTableContext.cxx
b/binfilter/bf_xmloff/source/chart/xmloff_SchXMLTableContext.cxx
index d816c6c..e9b20a1 100644
--- a/binfilter/bf_xmloff/source/chart/xmloff_SchXMLTableContext.cxx
+++ b/binfilter/bf_xmloff/source/chart/xmloff_SchXMLTableContext.cxx
@@ -445,7 +445,7 @@ void SchXMLTableHelper::applyTableSimple(
double fVal;
const sal_Bool bConstConvertNan = bConvertNaN;
-for( ++iRow, nRow = 0; iRow != rTable.aData.end(); iRow++, nRow++ )
+for( ++iRow, nRow = 0; iRow != rTable.aData.end(); ++iRow, nRow++ )
{
aCategories[ nRow ] = (*iRow)[ 0 ].aString;
for( nCol = 1; nCol nColumnCount; nCol++ )
diff --git a/binfilter/bf_xmloff/source/core/xmloff_attrlist.cxx
b/binfilter/bf_xmloff/source/core/xmloff_attrlist.cxx
index 71f2587..12fdc17 100644
--- a/binfilter/bf_xmloff/source/core/xmloff_attrlist.cxx
+++ b/binfilter/bf_xmloff/source/core/xmloff_attrlist.cxx
@@ -125,7 +125,7 @@ OUString SAL_CALL SvXMLAttributeList::getValueByName(const
OUString sName) thro
{
::std::vectorstruct SvXMLTagAttribute_Impl::iterator ii =
m_pImpl-vecAttribute.begin();
-for( ; ii != m_pImpl-vecAttribute.end() ; ii ++ ) {
+for( ; ii != m_pImpl-vecAttribute.end() ; ++ii ) {
if( (*ii).sName == sName ) {
return (*ii).sValue;
}
@@ -172,7 +172,7 @@ void SvXMLAttributeList::RemoveAttribute( const OUString
sName )
{
::std::vectorstruct SvXMLTagAttribute_Impl::iterator ii =
m_pImpl-vecAttribute.begin();
-for( ; ii != m_pImpl-vecAttribute.end() ; ii ++ ) {
+for( ; ii != m_pImpl-vecAttribute.end() ; ++ii ) {
if( (*ii).sName == sName ) {
m_pImpl-vecAttribute.erase( ii );
break;
diff --git a/binfilter/bf_xmloff/source/draw/xmloff_XMLShapeStyleContext.cxx
b/binfilter/bf_xmloff/source/draw/xmloff_XMLShapeStyleContext.cxx
index 866686f..7d6238c 100644
--- a/binfilter/bf_xmloff/source/draw/xmloff_XMLShapeStyleContext.cxx
+++ b/binfilter/bf_xmloff/source/draw/xmloff_XMLShapeStyleContext.cxx
@@ -130,7 +130,7 @@ void XMLShapeStyleContext::FillPropertySet( const
Reference beans::XPropertySet
// first, look for the old format, where we had a text:list-style-name
//
[REVIEW-3-5] PDF image export fix
Hi, It will be great if someone can cherry-pick this fix for n#717947, please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a651507e34ee423674d2a537f2bb4b509af6d6 Summary: when exporting to PDF, images (in notes view) aren't exported completely (they were optimized exported - i.e. small image rendered to full size). This patch fixes it. Thanks Regards, Muthu Subramanian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-5] Text color in shapes (pptx import)
Hi, It will be great if someone can cherry-pick this fix for n#746996, please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=1a2a2a02bd03829d2d50fb5f1a2178280ed2e997 Summary: Text color is imported wrong when there are none specified. We should use default color settings (in pptx - i.e. tx1) instead. Thanks Regards, Muthu Subramanian ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] Changes to 'feature/gbuild_testtools'
New branch 'feature/gbuild_testtools' available with the following commits: commit 46233dfcacc6ca2230c5b152f4d1012d5e161500 Author: David Ostrovsky david.ostrov...@gmx.de Date: Mon May 7 08:48:12 2012 +0200 gbuild conversion: testtools module Change-Id: I1fde7853d4708da9ec217b6e4d5b782648b065cb commit 1d675bb88afbe62f90eab3d3c78cb2769973e1ce Author: David Ostrovsky david.ostrov...@gmx.de Date: Mon May 7 08:40:36 2012 +0200 gbuild conversion: testtools module Change-Id: I90787a7d239dd4f73f53d13bd5b08172ee2b6a5e commit 443faf68fc5d91f2b153386bce72f44304cba3d9 Author: David Ostrovsky david.ostrov...@gmx.de Date: Sun May 6 17:17:22 2012 +0200 gbuild conversion: store module Change-Id: Idbab17b87d042079a8fa6ded7a7424a745761b2f ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] Translate two German comments in swtable.cxx
Hi Gábor, On Mon, May 07, 2012 at 01:36:08AM +0200, Gábor Stefanik netrolller...@gmail.com wrote: Found while debugging fdo#32531. You forgot to attach the patch. :-) Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - uui/source vcl/Library_vcl.mk vcl/source vcl/unx
uui/source/alreadyopen.cxx | 10 +-
uui/source/filechanged.cxx |8
uui/source/iahndl-locking.cxx | 18 --
uui/source/iahndl.cxx |4 ++--
uui/source/lockfailed.cxx |6 +++---
uui/source/nameclashdlg.cxx|6 +++---
uui/source/openlocked.cxx |6 +++---
uui/source/passworddlg.cxx | 12 ++--
uui/source/trylater.cxx|6 +++---
vcl/Library_vcl.mk |7 +++
vcl/source/gdi/bitmap2.cxx | 20
vcl/unx/generic/gdi/salbmp.cxx | 15 +--
12 files changed, 73 insertions(+), 45 deletions(-)
New commits:
commit 535e9e7f7d2ddf312a2b77350e94606584778709
Author: Caolán McNamara caol...@redhat.com
Date: Sun May 6 23:28:17 2012 +0100
tidy ResId String/rtl::OUString cast foo
Change-Id: I1e8fca182a27efb403e903b424ca4c1c0d3acc49
diff --git a/uui/source/alreadyopen.cxx b/uui/source/alreadyopen.cxx
index fbe6a7f..3d9a726 100644
--- a/uui/source/alreadyopen.cxx
+++ b/uui/source/alreadyopen.cxx
@@ -31,23 +31,23 @@
AlreadyOpenQueryBox::AlreadyOpenQueryBox( Window* pParent, ResMgr* pResMgr,
const String aMessage, sal_Bool bIsStoring ) :
MessBox(pParent, 0,
-String( ResId( STR_ALREADYOPEN_TITLE, *pResMgr ) ),
+ResId(STR_ALREADYOPEN_TITLE, *pResMgr).toString(),
aMessage )
{
SetImage( QueryBox::GetStandardImage() );
if ( bIsStoring )
{
-AddButton( String( ResId( STR_ALREADYOPEN_RETRY_SAVE_BTN, *pResMgr )
), RET_YES,
+AddButton( ResId(STR_ALREADYOPEN_RETRY_SAVE_BTN, *pResMgr).toString(),
RET_YES,
BUTTONDIALOG_DEFBUTTON | BUTTONDIALOG_OKBUTTON |
BUTTONDIALOG_FOCUSBUTTON );
-AddButton( String( ResId( STR_ALREADYOPEN_SAVE_BTN, *pResMgr ) ),
RET_NO, 0 );
+AddButton( ResId(STR_ALREADYOPEN_SAVE_BTN, *pResMgr).toString(),
RET_NO, 0 );
AddButton( BUTTON_CANCEL, RET_CANCEL, BUTTONDIALOG_CANCELBUTTON );
}
else
{
-AddButton( String( ResId( STR_ALREADYOPEN_READONLY_BTN, *pResMgr ) ),
RET_YES,
+AddButton( ResId(STR_ALREADYOPEN_READONLY_BTN, *pResMgr).toString(),
RET_YES,
BUTTONDIALOG_DEFBUTTON | BUTTONDIALOG_OKBUTTON |
BUTTONDIALOG_FOCUSBUTTON );
-AddButton( String( ResId( STR_ALREADYOPEN_OPEN_BTN, *pResMgr ) ),
RET_NO, 0 );
+AddButton( ResId(STR_ALREADYOPEN_OPEN_BTN, *pResMgr).toString(),
RET_NO, 0 );
AddButton( BUTTON_CANCEL, RET_CANCEL, BUTTONDIALOG_CANCELBUTTON );
}
diff --git a/uui/source/filechanged.cxx b/uui/source/filechanged.cxx
index 0a41fa8..c926d94 100644
--- a/uui/source/filechanged.cxx
+++ b/uui/source/filechanged.cxx
@@ -31,17 +31,17 @@
FileChangedQueryBox::FileChangedQueryBox( Window* pParent, ResMgr* pResMgr ) :
MessBox(pParent, 0,
-String( ResId( STR_FILECHANGED_TITLE, *pResMgr ) ),
+ResId(STR_FILECHANGED_TITLE, *pResMgr).toString(),
String::EmptyString() )
{
SetImage( QueryBox::GetStandardImage() );
-AddButton( String( ResId( STR_FILECHANGED_SAVEANYWAY_BTN, *pResMgr ) ),
RET_YES,
-BUTTONDIALOG_DEFBUTTON | BUTTONDIALOG_OKBUTTON |
BUTTONDIALOG_FOCUSBUTTON );
+AddButton(ResId(STR_FILECHANGED_SAVEANYWAY_BTN, *pResMgr).toString(),
RET_YES,
+BUTTONDIALOG_DEFBUTTON | BUTTONDIALOG_OKBUTTON |
BUTTONDIALOG_FOCUSBUTTON);
AddButton( BUTTON_CANCEL, RET_CANCEL, BUTTONDIALOG_CANCELBUTTON );
SetButtonHelpText( RET_YES, String::EmptyString() );
-SetMessText( String( ResId( STR_FILECHANGED_MSG, *pResMgr ) ) );
+SetMessText(ResId(STR_FILECHANGED_MSG, *pResMgr).toString());
}
FileChangedQueryBox::~FileChangedQueryBox()
diff --git a/uui/source/iahndl-locking.cxx b/uui/source/iahndl-locking.cxx
index 5ed5c01..e7235e5 100644
--- a/uui/source/iahndl-locking.cxx
+++ b/uui/source/iahndl-locking.cxx
@@ -97,10 +97,9 @@ handleLockedDocumentRequest_(
{
aArguments.push_back( !aInfo.isEmpty()
? aInfo
- : ::rtl::OUString( String(
-ResId( STR_UNKNOWNUSER,
- *xManager.get() ) ) ) );
-aMessage = String( ResId( STR_OPENLOCKED_MSG, *xManager.get() ) );
+ : ResId( STR_UNKNOWNUSER,
+ *xManager.get() ).toString() );
+aMessage = ResId(STR_OPENLOCKED_MSG, *xManager.get()).toString();
aMessage = UUIInteractionHelper::replaceMessageWithArguments(
aMessage, aArguments );
@@ -112,10 +111,9 @@ handleLockedDocumentRequest_(
{
aArguments.push_back( !aInfo.isEmpty()
? aInfo
- : ::rtl::OUString( String(
-ResId( STR_UNKNOWNUSER,
-
[Libreoffice-commits] .: solenv/gdb
solenv/gdb/libreoffice/cppu.py |1 +
1 file changed, 1 insertion(+)
New commits:
commit 0b369e8ff91fb62c5095a0739eb0ec76043162fa
Author: Miklos Vajna vmik...@suse.cz
Date: Mon May 7 09:23:48 2012 +0200
gdb: enable pretty-printer for uno::Reference
Change-Id: Ia4ac141d8e054d8558d77251c6f069a51a7e6fab
diff --git a/solenv/gdb/libreoffice/cppu.py b/solenv/gdb/libreoffice/cppu.py
index 852281f..1e3b25e 100644
--- a/solenv/gdb/libreoffice/cppu.py
+++ b/solenv/gdb/libreoffice/cppu.py
@@ -153,6 +153,7 @@ def build_pretty_printers():
# basic UNO stuff
printer.add('_uno_Any', UnoAnyPrinter)
printer.add('com::sun::star::uno::Any', UnoAnyPrinter)
+printer.add('com::sun::star::uno::Reference', UnoReferencePrinter)
printer.add('com::sun::star::uno::Sequence', UnoSequencePrinter)
printer.add('com::sun::star::uno::Type', UnoTypePrinter)
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 4 commits - filter/inc filter/source sw/source writerfilter/source
filter/inc/filter/msfilter/util.hxx|2
filter/source/msfilter/util.cxx| 11 +++
sw/source/filter/ww8/ww8par6.cxx | 17 -
sw/source/filter/ww8/ww8struc.hxx |4 -
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 77 ++---
writerfilter/source/rtftok/rtfdocumentimpl.hxx |5 +
writerfilter/source/rtftok/rtfsdrimport.cxx| 17 -
7 files changed, 95 insertions(+), 38 deletions(-)
New commits:
commit c450ea69921001621a1114369b3508bfa69bd088
Author: Miklos Vajna vmik...@suse.cz
Date: Mon May 7 09:32:48 2012 +0200
introduce msfilter::util::BGRToRGB to avoid copypaste
Change-Id: Ic3fa8865bf3862407867b5e4a438e3d9bc723e86
diff --git a/filter/inc/filter/msfilter/util.hxx
b/filter/inc/filter/msfilter/util.hxx
index 01ff373..2dc5fa7 100644
--- a/filter/inc/filter/msfilter/util.hxx
+++ b/filter/inc/filter/msfilter/util.hxx
@@ -41,6 +41,8 @@ namespace util {
/// what the encoding is, but you know or can guess the language
MSFILTER_DLLPUBLIC rtl_TextEncoding getBestTextEncodingFromLocale(const
::com::sun::star::lang::Locale rLocale);
+/// Convert a color in BGR format to RGB.
+MSFILTER_DLLPUBLIC sal_uInt32 BGRToRGB(sal_uInt32 nColour);
}
}
diff --git a/filter/source/msfilter/util.cxx b/filter/source/msfilter/util.cxx
index 76fe07c..03df8af 100644
--- a/filter/source/msfilter/util.cxx
+++ b/filter/source/msfilter/util.cxx
@@ -51,6 +51,17 @@ rtl_TextEncoding getBestTextEncodingFromLocale(const
::com::sun::star::lang::Loc
return RTL_TEXTENCODING_MS_1252;
}
+sal_uInt32 BGRToRGB(sal_uInt32 nColor)
+{
+sal_uInt8
+r(static_castsal_uInt8(nColor0xFF)),
+g(static_castsal_uInt8(((nColor)8)0xFF)),
+b(static_castsal_uInt8((nColor16)0xFF)),
+t(static_castsal_uInt8((nColor24)0xFF));
+nColor = (t24) + (r16) + (g8) + b;
+return nColor;
+}
+
}
}
diff --git a/sw/source/filter/ww8/ww8par6.cxx b/sw/source/filter/ww8/ww8par6.cxx
index 8a71999..d0a94a1 100644
--- a/sw/source/filter/ww8/ww8par6.cxx
+++ b/sw/source/filter/ww8/ww8par6.cxx
@@ -3363,24 +3363,13 @@ void SwWW8ImplReader::Read_TxtColor( sal_uInt16, const
sal_uInt8* pData, short n
}
}
-sal_uInt32 wwUtility::BGRToRGB(sal_uInt32 nColor)
-{
-sal_uInt8
-r(static_castsal_uInt8(nColor0xFF)),
-g(static_castsal_uInt8(((nColor)8)0xFF)),
-b(static_castsal_uInt8((nColor16)0xFF)),
-t(static_castsal_uInt8((nColor24)0xFF));
-nColor = (t24) + (r16) + (g8) + b;
-return nColor;
-}
-
void SwWW8ImplReader::Read_TxtForeColor(sal_uInt16, const sal_uInt8* pData,
short nLen)
{
if( nLen 0 )
pCtrlStck-SetAttr( *pPaM-GetPoint(), RES_CHRATR_COLOR );
else
{
-Color aColor(wwUtility::BGRToRGB(SVBT32ToUInt32(pData)));
+Color aColor(msfilter::util::BGRToRGB(SVBT32ToUInt32(pData)));
NewAttr(SvxColorItem(aColor, RES_CHRATR_COLOR));
if (pAktColl pStyles)
pStyles-bTxtColChanged = true;
@@ -4663,9 +4652,9 @@ sal_uInt32 SwWW8ImplReader::ExtractColour(const
sal_uInt8* rpData, bool bVer67)
{
(void) bVer67; // unused in non-debug
OSL_ENSURE(bVer67 == false, Impossible);
-sal_uInt32 nFore = wwUtility::BGRToRGB(SVBT32ToUInt32(rpData));
+sal_uInt32 nFore = msfilter::util::BGRToRGB(SVBT32ToUInt32(rpData));
rpData+=4;
-sal_uInt32 nBack = wwUtility::BGRToRGB(SVBT32ToUInt32(rpData));
+sal_uInt32 nBack = msfilter::util::BGRToRGB(SVBT32ToUInt32(rpData));
rpData+=4;
sal_uInt16 nIndex = SVBT16ToShort(rpData);
rpData+=2;
diff --git a/sw/source/filter/ww8/ww8struc.hxx
b/sw/source/filter/ww8/ww8struc.hxx
index 3790ebf..98dff63 100644
--- a/sw/source/filter/ww8/ww8struc.hxx
+++ b/sw/source/filter/ww8/ww8struc.hxx
@@ -34,6 +34,7 @@
#include sal/config.h
#include editeng/borderline.hxx
+#include filter/msfilter/util.hxx
#if defined OSL_BIGENDIAN || SAL_TYPES_ALIGNMENT4 2 || defined UNX
# define __WW8_NEEDS_COPY
@@ -978,8 +979,7 @@ struct SEPr
namespace wwUtility
{
-sal_uInt32 BGRToRGB(sal_uInt32 nColour);
-inline sal_uInt32 RGBToBGR(sal_uInt32 nColour) { return BGRToRGB(nColour);
}
+inline sal_uInt32 RGBToBGR(sal_uInt32 nColour) { return
msfilter::util::BGRToRGB(nColour); }
}
#endif
diff --git a/writerfilter/source/rtftok/rtfsdrimport.cxx
b/writerfilter/source/rtftok/rtfsdrimport.cxx
index 01b1d00..4fc0453 100644
--- a/writerfilter/source/rtftok/rtfsdrimport.cxx
+++ b/writerfilter/source/rtftok/rtfsdrimport.cxx
@@ -35,6 +35,7 @@
#include ooxml/resourceids.hxx // NS_ooxml namespace
#include filter/msfilter/escherex.hxx
+#include filter/msfilter/util.hxx
#include rtfsdrimport.hxx
@@ -44,18 +45,6 @@ using rtl::OUString;
using rtl::OUStringBuffer;
using rtl::OUStringToOString;
-// NEEDSWORK: wwUtility::BGRToRGB does the same.
-static sal_uInt32 lcl_BGRToRGB(sal_uInt32 nColor)
-{
-sal_uInt8
-r(static_castsal_uInt8(nColor0xFF)),
[Libreoffice-commits] .: sw/qa writerfilter/source
sw/qa/extras/rtftok/data/fdo38786.rtf |2 ++
sw/qa/extras/rtftok/rtftok.cxx | 13 +
writerfilter/source/rtftok/rtfdocumentimpl.cxx |9 +
3 files changed, 24 insertions(+)
New commits:
commit 116016d5160302413d5c2c97c436c5e4f6383338
Author: Miklos Vajna vmik...@suse.cz
Date: Mon May 7 09:50:02 2012 +0200
fdo#38786 implement RTF_CHPGN
Change-Id: I0ae693193b4fc8ed155e2d71b06daa80d46da47c
diff --git a/sw/qa/extras/rtftok/data/fdo38786.rtf
b/sw/qa/extras/rtftok/data/fdo38786.rtf
new file mode 100644
index 000..6397cee
--- /dev/null
+++ b/sw/qa/extras/rtftok/data/fdo38786.rtf
@@ -0,0 +1,2 @@
+{\rtf1\chpgn
+\par}
diff --git a/sw/qa/extras/rtftok/rtftok.cxx b/sw/qa/extras/rtftok/rtftok.cxx
index 137062a..1f340b5 100644
--- a/sw/qa/extras/rtftok/rtftok.cxx
+++ b/sw/qa/extras/rtftok/rtftok.cxx
@@ -92,6 +92,7 @@ public:
void testFdo44211();
void testFdo48037();
void testFdo47764();
+void testFdo38786();
CPPUNIT_TEST_SUITE(Test);
#if !defined(MACOSX) !defined(WNT)
@@ -122,6 +123,7 @@ public:
CPPUNIT_TEST(testFdo44211);
CPPUNIT_TEST(testFdo48037);
CPPUNIT_TEST(testFdo47764);
+CPPUNIT_TEST(testFdo38786);
#endif
CPPUNIT_TEST_SUITE_END();
@@ -676,6 +678,17 @@ void Test::testFdo47764()
CPPUNIT_ASSERT_EQUAL(sal_Int32(-1), nValue);
}
+void Test::testFdo38786()
+{
+load(fdo38786.rtf);
+
+uno::Referencetext::XTextFieldsSupplier xTextFieldsSupplier(mxComponent,
uno::UNO_QUERY);
+uno::Referencecontainer::XEnumerationAccess
xFieldsAccess(xTextFieldsSupplier-getTextFields());
+uno::Referencecontainer::XEnumeration
xFields(xFieldsAccess-createEnumeration());
+// \chpgn was ignored, so exception was thrown
+xFields-nextElement();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(Test);
CPPUNIT_PLUGIN_IMPLEMENT();
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index d8fa4c3..16ca2ec 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1552,6 +1552,15 @@ int RTFDocumentImpl::dispatchSymbol(RTFKeyword nKeyword)
parBreak();
}
break;
+case RTF_CHPGN:
+{
+OUString aStr(PAGE);
+singleChar(0x13);
+text(aStr);
+singleChar(0x14);
+singleChar(0x15);
+}
+break;
default:
SAL_INFO(writerfilter, OSL_THIS_FUNC : TODO handle symbol '
lcl_RtfToString(nKeyword) ');
aSkip.setParsed(false);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
License Statement
Hi all, just to be sure ... All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Cheers, Christoph Noack ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
License statement
All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. -- Amicalement, Laurent. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - registry/Library_reg.mk registry/Module_registry.mk
registry/Library_reg.mk |1 + registry/Module_registry.mk |2 +- 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit dd3124dfa4cdab080943127dde53ca2130ecf602 Author: Tor Lillqvist tlillqv...@suse.com Date: Mon May 7 10:58:42 2012 +0300 Don't bother with the static lib and the exes for non-desktop OSes Change-Id: Ia559990745d10c2f128624b6ffe76ece8a9151b9 diff --git a/registry/Module_registry.mk b/registry/Module_registry.mk index 0867564..c62ece0 100644 --- a/registry/Module_registry.mk +++ b/registry/Module_registry.mk @@ -31,7 +31,7 @@ $(eval $(call gb_Module_add_targets,registry,\ Package_inc \ )) -ifneq ($(OS),IOS) +ifneq (,$(filter DESKTOP,$(BUILD_TYPE))) $(eval $(call gb_Module_add_targets,registry,\ StaticLibrary_registry_helper \ commit c8155a58bd1370d2375bdc7f08ae7cd40282b1ec Author: Tor Lillqvist tlillqv...@suse.com Date: Mon May 7 10:57:18 2012 +0300 Use gb_STDLIBS Change-Id: I6fcbe4db269472543e8b3310c966a68f5846a510 diff --git a/registry/Library_reg.mk b/registry/Library_reg.mk index 0ee4ccd..4dd10b7 100644 --- a/registry/Library_reg.mk +++ b/registry/Library_reg.mk @@ -40,6 +40,7 @@ $(eval $(call gb_Library_add_defs,reg,\ $(eval $(call gb_Library_use_libraries,reg,\ sal \ store \ + $(gb_STDLIBS) \ )) $(eval $(call gb_Library_add_exception_objects,reg,\ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] Translate two German comments in swtable.cxx
Sorry, here it is :-) On Mon, May 7, 2012 at 9:18 AM, Miklos Vajna vmik...@suse.cz wrote: Hi Gábor, On Mon, May 07, 2012 at 01:36:08AM +0200, Gábor Stefanik netrolller...@gmail.com wrote: Found while debugging fdo#32531. You forgot to attach the patch. :-) Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) 0001-Translate-two-German-comments-in-swtable.cxx.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: May I ask questions ? [WAS: On SSL library support]
Well - I'm sorry you feel that way; you're of course welcome to discuss things inside the project, but please use the discuss list for everything not directly related to a code contribution you're working on :-) Hopefully it's not such a bad thing to have different purposes for different lists. Ah, so the development discussions happen on a completely different list (that's not actually well announced), while -dev is only for patches ? Well, how could I miss that obvious part ... ;-o cu ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sw/source
sw/source/core/table/swtable.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit ffc53f86501b6f29eeb5d75b6b2dfcf9ae982c18
Author: Gábor Stefanik netrolller...@gmail.com
Date: Sat May 5 21:36:48 2012 +0200
Translate two German comments in swtable.cxx
Change-Id: I968fb58b6ceb406a62a2b403c270aef2281945c3
diff --git a/sw/source/core/table/swtable.cxx b/sw/source/core/table/swtable.cxx
index c5f0d09..cd8a389 100644
--- a/sw/source/core/table/swtable.cxx
+++ b/sw/source/core/table/swtable.cxx
@@ -210,12 +210,12 @@ void _InsTblBox( SwDoc* pDoc, SwTableNode* pTblNd,
SwTableBox* pBox,
sal_uInt16 nInsPos, sal_uInt16 nCnt )
{
-OSL_ENSURE( pBox-GetSttNd(), Box ohne Start-Node );
+OSL_ENSURE( pBox-GetSttNd(), Box with no start node );
SwNodeIndex aIdx( *pBox-GetSttNd(), +1 );
SwCntntNode* pCNd = aIdx.GetNode().GetCntntNode();
if( !pCNd )
pCNd = pDoc-GetNodes().GoNext( aIdx );
-OSL_ENSURE( pCNd, Box ohne ContentNode );
+OSL_ENSURE( pCNd, Box with no content node );
if( pCNd-IsTxtNode() )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED] Translate two German comments in swtable.cxx
On Mon, May 07, 2012 at 10:09:37AM +0200, Gábor Stefanik netrolller...@gmail.com wrote: Sorry, here it is :-) Pushed, thanks. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] fdo#48391: Remove TEST_ENSHURE
What's the status of this one? Is it still being reviewed? Has it been silently dropped? Thanks, Gábor On Thu, May 3, 2012 at 10:30 PM, Gábor Stefanik netrolller...@gmail.com wrote: Get rid of the misspelled TEST_ENSHURE macro. -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action
Hi Andras,
On Sun, May 6, 2012 at 10:34 PM, Andras Timar tima...@gmail.com wrote:
Fortunately the tree control under Windows can receive
a message that does the sort, so everything can be solved with pure
Windows API calls.
http://cgit.freedesktop.org/libreoffice/core/commit/?id=39bb77fd667f9d9fdaf374f3934b6eec7b7dc57a
The Windows code looks OK, but there's no error control anywhere and
that makes me shiver.
I know in theory it shouldn't fail, but I would prefer to use an error
logging mechaninsm instead of letting it crash. This is just a sketch,
not real code.
BOOL bDidItWork = FALSE;
HWND hwndMSI = FindWindow(TEXT(MsiDialogCloseClass), NULL);
if (hwdMSI) {
HWND hwndTV = FindWindowEx(hwndMSI, NULL, TEXT(SysTreeView32), NULL);
if (hwndTV)
{
HTREEITEM treeRoot = TreeView_GetRoot(hwndTV);
if (treeRoot)
{
HTREEITEM optional = TreeView_GetNextSibling(hwndTV, treeRoot);
if (optional)
{
HTREEITEM dicts = TreeView_GetChild(hwndTV, optional);
if ( dicts)
{
TreeView_SortChildren(hwndTV, dicts, TRUE);
HTREEITEM langs = TreeView_GetNextSibling(hwndTV, optional);
if (langs)
{
TreeView_SortChildren(hwndTV, langs, TRUE);
bDidItWork = TRUE;
}
}
}
}
}
if (!bDidItWork) MessageBox(NULL, LError, LSomething is wrong. Call
the ghostbusters!);
or even a more controversial version:
HWND hwndMSI = FindWindow(TEXT(MsiDialogCloseClass), NULL);
if(!hwndMSI) goto error;
HWND hwndTV = FindWindowEx(hwndMSI, NULL, TEXT(SysTreeView32), NULL);
if(!hwndTV) goto error;
HTREEITEM treeRoot = TreeView_GetRoot(hwndTV);
if(!treeRoot) goto error;
HTREEITEM optional = TreeView_GetNextSibling(hwndTV, treeRoot);
if(!optional) goto error;
HTREEITEM dicts = TreeView_GetChild(hwndTV, optional);
if(!dicts) goto error;
TreeView_SortChildren(hwndTV, dicts, TRUE);
HTREEITEM langs = TreeView_GetNextSibling(hwndTV, optional);
if(!langs) goto error;
TreeView_SortChildren(hwndTV, langs, TRUE);
return TRUE;
error:
MessageBox(NULL, LError, LSomething is wrong. Call the ghostbusters!);
--
Jesús Corrius je...@softcatala.org
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] [PUSHED] fdo#48391: Remove TEST_ENSHURE
Thanks, pushed. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action
2012/5/7 Jesús Corrius je...@softcatala.org: Hi Andras, On Sun, May 6, 2012 at 10:34 PM, Andras Timar tima...@gmail.com wrote: Fortunately the tree control under Windows can receive a message that does the sort, so everything can be solved with pure Windows API calls. http://cgit.freedesktop.org/libreoffice/core/commit/?id=39bb77fd667f9d9fdaf374f3934b6eec7b7dc57a The Windows code looks OK, but there's no error control anywhere and that makes me shiver. If it fails, nothing special will happen. The control will not be sorted, that is. I don't think we should stop and rollback the install. We ignore the return code of most of our custom actions. Cheers, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: instsetoo_native/inc_ooohelppack instsetoo_native/inc_ooolangpack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo instsetoo_native/inc_ure
instsetoo_native/inc_ooohelppack/windows/msi_templates/CheckBox.idt |4 -- instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt |9 - instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt | 13 +-- instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlE.idt |2 - instsetoo_native/inc_ooolangpack/windows/msi_templates/CheckBox.idt |4 -- instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt |9 - instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt | 13 +-- instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlE.idt |2 - instsetoo_native/inc_openoffice/windows/msi_languages/Control.ulf | 18 -- instsetoo_native/inc_openoffice/windows/msi_templates/CheckBox.idt |1 instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt |9 - instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt | 13 +-- instsetoo_native/inc_openoffice/windows/msi_templates/ControlE.idt |2 - instsetoo_native/inc_sdkoo/windows/msi_templates/CheckBox.idt |4 -- instsetoo_native/inc_sdkoo/windows/msi_templates/Control.idt|9 - instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt | 13 +-- instsetoo_native/inc_sdkoo/windows/msi_templates/ControlE.idt |2 - instsetoo_native/inc_ure/windows/msi_templates/CheckBox.idt |4 -- instsetoo_native/inc_ure/windows/msi_templates/Control.idt |9 - instsetoo_native/inc_ure/windows/msi_templates/ControlC.idt | 13 +-- instsetoo_native/inc_ure/windows/msi_templates/ControlE.idt |2 - 21 files changed, 10 insertions(+), 145 deletions(-) New commits: commit 1c2529ee738148f95f0f80df25950979ea89910f Author: Andras Timar ati...@suse.com Date: Mon May 7 10:14:56 2012 +0200 remove unused checkboxes from Windows installer Change-Id: I51eea9c45b893f56dece99e8d01e385c96051f8d diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/CheckBox.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/CheckBox.idt deleted file mode 100644 index c7c8e06..000 --- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/CheckBox.idt +++ /dev/null @@ -1,4 +0,0 @@ -Property Value -s72S64 -CheckBox Property -ISCHECKFORPRODUCTUPDATES 1 diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt index 40fbe5e..b686c60 100644 --- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt +++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt @@ -254,21 +254,12 @@ SetupCompleteErrorTextLine1 Text135 8 225 45 65539 OOO_CONTROL_190 SetupCompleteError TextLine2 Text135 55 228 25 65539 OOO_CONTROL_191 SetupCompleteSuccess BackPushButton 164 243 66 17 1 OOO_CONTROL_192 OK SetupCompleteSuccess Cancel PushButton 301 243 66 17 1 OOO_CONTROL_193 Image -SetupCompleteSuccess CheckBoxUpdates CheckBox135 164 10 9 2 ISCHECKFORPRODUCTUPDATESCheckBox1 Back -SetupCompleteSuccess CheckForUpdatesText Text152 162 190 30 65538 OOO_CONTROL_194 -SetupCompleteSuccess CheckLaunchProgram CheckBox151 114 10 9 2 LAUNCHPROGRAM -SetupCompleteSuccess CheckLaunchReadme CheckBox151 148 10 9 2 LAUNCHREADME SetupCompleteSuccess DlgLine Line0 234 374 0 1 SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpCheckBoxUpdates -SetupCompleteSuccess LaunchProgramText Text164 112 198 15 65538 OOO_CONTROL_195 -SetupCompleteSuccess LaunchReadmeTextText164 148 198 13 65538 OOO_CONTROL_196 SetupCompleteSuccess OK PushButton 230 243 66 17 3 OOO_CONTROL_197 Cancel SetupCompleteSuccess TextLine1 Text135 8 225 45 65539 OOO_CONTROL_198 SetupCompleteSuccess TextLine2 Text135 55 228 45 65538 OOO_CONTROL_199 SetupCompleteSuccess TextLine3 Text135 55 228 45 65538 OOO_CONTROL_200 -SetupCompleteSuccess UpdateTextLine1 Text135 30 228 45 65538 OOO_CONTROL_201 -SetupCompleteSuccess UpdateTextLine2 Text135 80 228 45 65538
[PATCH] cups configure switch
Hi guys,
please see the patch in the attachment.
I finaly got a Gentoo user to get annoyed enough by the hard requirement of
cups. The patch itself seems pretty straight-forward and for the basic testing
on runtime I didn't see anything broken.
Please let me know if you think that something might break or if it is ok to
commit.
Cheers
TomFrom 48a8cece9fd85230b389996aa4efc414f6ff43f3 Mon Sep 17 00:00:00 2001
From: Dave Flogeras dfloge...@gmail.com
Date: Mon, 7 May 2012 10:49:41 +0200
Subject: [PATCH] Enable configure switch for cups
This allows us not to have cups during the build time of libreoffice.
Change-Id: I2c79b5e59a514fd6a0f9adda40289e2e26af400c
Signed-off-by: Tomas Chvatal tchva...@suse.cz
---
configure.in|8
vcl/unx/generic/printer/cupsmgr.cxx | 22 ++
2 files changed, 26 insertions(+), 4 deletions(-)
diff --git a/configure.in b/configure.in
index 43a6544..8b5a74e 100644
--- a/configure.in
+++ b/configure.in
@@ -842,6 +842,11 @@ AC_ARG_ENABLE(nsplugin,
[Do not build nsplugin extension for browser embedding.])
)
+AC_ARG_ENABLE(cups,
+AS_HELP_STRING([--disable-cups],
+[Do not build cups and thus disable printing support.])
+)
+
AC_ARG_ENABLE(ccache,
AS_HELP_STRING([--disable-ccache],
[Do not try to use ccache automatically.
@@ -3597,6 +3602,9 @@ fi
dnl check for cups support
dnl ===
+if test $enable_cups = no; then
+test_cups=no
+fi
if test $test_cups = yes; then
AC_MSG_CHECKING([whether cups support is present])
AC_CHECK_LIB([cups], [cupsPrintFiles], [:])
diff --git a/vcl/unx/generic/printer/cupsmgr.cxx b/vcl/unx/generic/printer/cupsmgr.cxx
index a0e020a..ed976bc 100644
--- a/vcl/unx/generic/printer/cupsmgr.cxx
+++ b/vcl/unx/generic/printer/cupsmgr.cxx
@@ -26,6 +26,22 @@
*
/
+#include cupsmgr.hxx
+#include rtl/ustrbuf.hxx
+
+#ifndef HAVE_CUPS_H // disable printing support
+
+namespace psp {
+ CUPSManager* CUPSManager::tryLoadCUPS() {
+// Don't load anything, the printerInfoManager will take care of this
+return 0x0;
+ }
+ const PPDParser* CUPSManager::createCUPSParser( const ::rtl::OUString rPrinter ) {
+return 0x0;
+ }
+}
+
+#else // HAVE_CUPS_H
#include cups/cups.h
#include cups/http.h
@@ -34,14 +50,10 @@
#include unistd.h
-#include cupsmgr.hxx
-
#include osl/thread.h
#include osl/diagnose.h
#include osl/conditn.hxx
-#include rtl/ustrbuf.hxx
-
#include algorithm
#include setjmp.h
#include signal.h
@@ -1177,4 +1189,6 @@ const char* CUPSManager::authenticateUser( const char* /*pIn*/ )
return pRet;
}
+#endif // HAVE_CUPS_H
+
/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
--
1.7.3.4
signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Unopkg fails to register extension (com.sun.star.registry.CannotRegisterImplementationException)
On 05/06/2012 09:47 PM, Sebastian Humenda wrote: I hope I'm on the right list for my question. There is an accessibility checker for Libreoffice documents which I package for Debian GNU/Linux. In Bug 668376 (http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668376) the package fails to install because unopkg causes a mysterious error (see output at the bottom of bug the report). I've discussed it with the upstream developer of AccessODF, but he said there's no reason why an error should occure. So I have two questions: 1. Can I somehow optain even more error output then I get with -v during install? 2. Could it even be a unopkg/Libreoffice bug? The upstream developer and I can install the package with no problem, only the bug reporter had those errors. We tested the installation of corse in a clean chroot. Looking into AccessODF.oxt as included in http://crustulus.de/accessodf_0.1-1_all.deb, the actively registered accessodf-addon.jar uses classes from lib/accessodf.jar (java.lang.NoClassDefFoundError: be/docarch/accessodf/Constants), but the manifest Class-Path of accessodf-addon.jar reads Class-Path: file:///usr/share/java/accessodf.jar instead of Class-Path: lib/accessodf.jar so it won't find the accessodf.jar contained in AccessODF.oxt when calling unopkg add on it. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - writerperfect/source
writerperfect/source/filter/OdtGenerator.cxx | 34 +++
1 file changed, 30 insertions(+), 4 deletions(-)
New commits:
commit 27482e865d1fc8d66d9a11fa524ceddf9d982833
Author: Laurent Alonso laurent.alo...@inria.fr
Date: Mon May 7 10:52:13 2012 +0200
Add possibility of generating foot/endnotes with text labels
diff --git a/writerperfect/source/filter/OdtGenerator.cxx
b/writerperfect/source/filter/OdtGenerator.cxx
index 10443b9..16bc97b 100644
--- a/writerperfect/source/filter/OdtGenerator.cxx
+++ b/writerperfect/source/filter/OdtGenerator.cxx
@@ -852,8 +852,17 @@ void OdtGenerator::openFootnote(const WPXPropertyList
propList)
}
mpImpl-mpCurrentContentElements-push_back(pOpenFootNote);
-mpImpl-mpCurrentContentElements-push_back(new
TagOpenElement(text:note-citation));
-if (propList[libwpd:number])
+TagOpenElement *pOpenFootCitation = new
TagOpenElement(text:note-citation);
+if (propList[text:label])
+{
+WPXString tmpString(propList[text:label]-getStr(),true);
+pOpenFootCitation-addAttribute(text:label, tmpString);
+}
+mpImpl-mpCurrentContentElements-push_back(pOpenFootCitation);
+
+if (propList[text:label])
+mpImpl-mpCurrentContentElements-push_back(new
CharDataElement(propList[text:label]-getStr().cstr()));
+else if (propList[libwpd:number])
mpImpl-mpCurrentContentElements-push_back(new
CharDataElement(propList[libwpd:number]-getStr().cstr()));
mpImpl-mpCurrentContentElements-push_back(new
TagCloseElement(text:note-citation));
@@ -885,8 +894,17 @@ void OdtGenerator::openEndnote(const WPXPropertyList
propList)
}
mpImpl-mpCurrentContentElements-push_back(pOpenEndNote);
-mpImpl-mpCurrentContentElements-push_back(new
TagOpenElement(text:note-citation));
-if (propList[libwpd:number])
+TagOpenElement *pOpenEndCitation = new
TagOpenElement(text:note-citation);
+if (propList[text:label])
+{
+WPXString tmpString(propList[text:label]-getStr(),true);
+pOpenEndCitation-addAttribute(text:label, tmpString);
+}
+mpImpl-mpCurrentContentElements-push_back(pOpenEndCitation);
+
+if (propList[text:label])
+mpImpl-mpCurrentContentElements-push_back(new
CharDataElement(propList[text:label]-getStr().cstr()));
+else if (propList[libwpd:number])
mpImpl-mpCurrentContentElements-push_back(new
CharDataElement(propList[libwpd:number]-getStr().cstr()));
mpImpl-mpCurrentContentElements-push_back(new
TagCloseElement(text:note-citation));
commit 916b0a18acf0cabb01988a8162b9545aeee838a9
Author: Laurent Alonso laurent.alo...@inria.fr
Date: Sun Apr 15 15:30:31 2012 +0200
Check for frame borders and frame background
diff --git a/writerperfect/source/filter/OdtGenerator.cxx
b/writerperfect/source/filter/OdtGenerator.cxx
index 8f6ae1b..10443b9 100644
--- a/writerperfect/source/filter/OdtGenerator.cxx
+++ b/writerperfect/source/filter/OdtGenerator.cxx
@@ -1192,6 +1192,14 @@ void OdtGenerator::openFrame(const WPXPropertyList
propList)
if (propList[fo:max-height])
frameAutomaticStylePropertiesElement-addAttribute(fo:max-height,
propList[fo:max-height]-getStr());
+// check if the frame has border, background attributes
+if (propList[fo:border])
+frameAutomaticStylePropertiesElement-addAttribute(fo:border,
propList[fo:border]-getStr());
+if (propList[style:border-line-width])
+
frameAutomaticStylePropertiesElement-addAttribute(style:border-line-width,
propList[style:border-line-width]-getStr());
+if (propList[fo:background-color])
+
frameAutomaticStylePropertiesElement-addAttribute(fo:background-color,
propList[fo:background-color]-getStr());
+
frameAutomaticStylePropertiesElement-addAttribute(draw:ole-draw-aspect,
1);
mpImpl-mFrameAutomaticStyles.push_back(frameAutomaticStylePropertiesElement);
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: jurt/com
jurt/com/sun/star/comp/loader/JavaLoader.java |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
New commits:
commit eac5b793aa4a39dcbdd7caf4b4e939a204c5c333
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon May 7 11:01:55 2012 +0200
Improved error reporting
Change-Id: Ifbb44b8d711b82f5d3ca0cd678579e9dcbb44bf2
diff --git a/jurt/com/sun/star/comp/loader/JavaLoader.java
b/jurt/com/sun/star/comp/loader/JavaLoader.java
index 113e763..cffed88 100644
--- a/jurt/com/sun/star/comp/loader/JavaLoader.java
+++ b/jurt/com/sun/star/comp/loader/JavaLoader.java
@@ -428,7 +428,10 @@ public class JavaLoader implements XImplementationLoader,
success = ((Boolean) oRet).booleanValue();
}
catch (Exception e) {
-throw new CannotRegisterImplementationException( e.getMessage());
+CannotRegisterImplementationException e2 =
+new CannotRegisterImplementationException(e.toString());
+e2.initCause(e);
+throw e2;
}
return success;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] cups configure switch
Hello Tomáš, Il 07/05/2012 10:57, Tomáš Chvátal ha scritto: Hi guys, please see the patch in the attachment. I finaly got a Gentoo user to get annoyed enough by the hard requirement of cups. The patch itself seems pretty straight-forward and for the basic testing on runtime I didn't see anything broken. Please let me know if you think that something might break or if it is ok to commit. Another possibility is to add some ifdefery in vcl/Library_vcl.mk instead of providing a stub CUPSManager. This would match other platforms already building with test_cups=no. hth, riccardo ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW-3-5] fdo#46355 sort SelectionTree control of Custom Setup with a custom action
Hi Andras, If it fails, nothing special will happen. The control will not be sorted, that is. I don't think we should stop and rollback the install. We ignore the return code of most of our custom actions. The behavior of FindWindow or FindWindowEx is different if some of the parameters are NULL (If hwndParent is NULL, the function uses the desktop window as the parent window). Although I agree that it is highly unlikely that we do any collateral damage, a few IFs will ensure that the code does what we want in all cases. So I would put them even if we never show any error message. -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
clothes dongli与您共享了照片
Hello, sir thank you for your time We are Dongli uniforms clothing manufactory, we mainly produce Uniforms, camouflage clothing and uniforms, currently we mainly export to Russian market and USA Market. If you are looking for this kinds clothing, please contact our factory by soonest. Our website: www.dongli-uniform.com email: sa...@dongli-uniform.com we welcome OEM clothing!! We are looking forward to getting your reply soonest thank you Robert Zeng Our website: www.dongli-uniform.com email: sa...@dongli-uniform.com attachment: 衣服dongli clothing.jpg___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] cups configure switch
Dne Po 7. května 2012 11:07:52, Riccardo Magliocchetti napsal(a):
Hello Tomáš,
Another possibility is to add some ifdefery in vcl/Library_vcl.mk
instead of providing a stub CUPSManager. This would match other
platforms already building with test_cups=no.
Good idea. Altho it is more changed lines it looks more clean.
So any other suggestions for this, or can I go ahead?
Cheers
TomFrom 62cdd0f6621b11e2fb5eedc01b7672fe4be9ae46 Mon Sep 17 00:00:00 2001
From: Tomas Chvatal tchva...@suse.cz
Date: Mon, 7 May 2012 13:46:09 +0200
Subject: [PATCH] Enable configure switch for cups
This allows us not to have cups during the build time of libreoffice.
Commit is based of patch from Dave Flogeras dfloge...@gmail.com.
Change-Id: I32a14eb6e7bdd13de1a737d4798c852a830ae326
Signed-off-by: Tomas Chvatal tchva...@suse.cz
---
config_host.mk.in |1 +
configure.in | 12
vcl/Library_vcl.mk|9 +++--
vcl/null/printerinfomanager.cxx | 10 ++
vcl/unx/generic/printer/ppdparser.cxx |2 +-
5 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/config_host.mk.in b/config_host.mk.in
index 65affa9..fd5e8a0 100644
--- a/config_host.mk.in
+++ b/config_host.mk.in
@@ -98,6 +98,7 @@ export DPKG=@DPKG@
export DYNAMIC_CRT=@DYNAMIC_CRT@
export ENABLE_CAIRO_CANVAS=@ENABLE_CAIRO_CANVAS@
export ENABLE_CRASHDUMP=@ENABLE_CRASHDUMP@
+export ENABLE_CUPS=@ENABLE_CUPS@
export ENABLE_DBUS=@ENABLE_DBUS@
export ENABLE_DIRECTX=@ENABLE_DIRECTX@
export ENABLE_EVOAB2=@ENABLE_EVOAB2@
diff --git a/configure.in b/configure.in
index 43a6544..91c871d 100644
--- a/configure.in
+++ b/configure.in
@@ -842,6 +842,11 @@ AC_ARG_ENABLE(nsplugin,
[Do not build nsplugin extension for browser embedding.])
)
+AC_ARG_ENABLE(cups,
+AS_HELP_STRING([--disable-cups],
+[Do not build cups support.])
+)
+
AC_ARG_ENABLE(ccache,
AS_HELP_STRING([--disable-ccache],
[Do not try to use ccache automatically.
@@ -3597,6 +3602,13 @@ fi
dnl check for cups support
dnl ===
+if test $enable_cups = no; then
+test_cups=no
+ENABLE_CUPS=NO
+else
+ENABLE_CUPS=YES
+fi
+AC_SUBST(ENABLE_CUPS)
if test $test_cups = yes; then
AC_MSG_CHECKING([whether cups support is present])
AC_CHECK_LIB([cups], [cupsPrintFiles], [:])
diff --git a/vcl/Library_vcl.mk b/vcl/Library_vcl.mk
index 92e35a2..05be361 100644
--- a/vcl/Library_vcl.mk
+++ b/vcl/Library_vcl.mk
@@ -445,10 +445,15 @@ $(eval $(call gb_Library_add_defs,vcl,\
$(eval $(call gb_Library_add_exception_objects,vcl,\
$(vcl_generic_code) \
vcl/unx/generic/plugadapt/salplug \
-vcl/unx/generic/printer/cupsmgr \
vcl/unx/generic/printer/jobdata \
vcl/unx/generic/printer/ppdparser \
-vcl/unx/generic/printer/printerinfomanager \
+$(if $(filter YES,$(ENABLE_CUPS)),\
+vcl/unx/generic/printer/cupsmgr \
+vcl/unx/generic/printer/printerinfomanager \
+) \
+$(if $(filter NO,$(ENABLE_CUPS)),\
+vcl/null/printerinfomanager \
+) \
))
$(eval $(call gb_Library_use_externals,vcl,\
fontconfig \
diff --git a/vcl/null/printerinfomanager.cxx b/vcl/null/printerinfomanager.cxx
index 526a936..d606c41 100644
--- a/vcl/null/printerinfomanager.cxx
+++ b/vcl/null/printerinfomanager.cxx
@@ -84,6 +84,16 @@ void PrinterInfoManager::initialize()
// ???
}
+bool PrinterInfoManager::isCUPSDisabled() const
+{
+return m_bDisableCUPS;
+}
+
+void PrinterInfoManager::setCUPSDisabled( bool bDisable )
+{
+// cups is already disabled in config so do nothing
+}
+
void PrinterInfoManager::listPrinters( ::std::list OUString rList ) const
{
rList.clear();
diff --git a/vcl/unx/generic/printer/ppdparser.cxx b/vcl/unx/generic/printer/ppdparser.cxx
index e555396..9acee56 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -655,7 +655,7 @@ const PPDParser* PPDParser::getParser( const String rFile )
PrinterInfoManager rMgr = PrinterInfoManager::get();
if( rMgr.getType() == PrinterInfoManager::CUPS )
{
-#if !defined(ANDROID) !defined(LIBO_HEADLESS)
+#if defined HAVE_CUPS_H
pNewParser = const_castPPDParser*(static_castCUPSManager(rMgr).createCUPSParser( aFile ));
#endif
}
--
1.7.3.4
signature.asc
Description: This is a digitally signed message part.
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: instsetoo_native/inc_ooohelppack instsetoo_native/inc_ooolangpack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo instsetoo_native/inc_ure
instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt |2 +- instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt |2 +- instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt |2 +- instsetoo_native/inc_sdkoo/windows/msi_templates/Control.idt |2 +- instsetoo_native/inc_ure/windows/msi_templates/Control.idt |2 +- 5 files changed, 5 insertions(+), 5 deletions(-) New commits: commit 56934b87937a03ccc008379f7b03bbd4f255cc02 Author: Andras Timar ati...@suse.com Date: Mon May 7 13:02:38 2012 +0200 don't refer to a deleted control Change-Id: I61f54a76096f3d2390c16fb1715aa95761e761e5 diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt index b686c60..de52236 100644 --- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt +++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/Control.idt @@ -255,7 +255,7 @@ SetupCompleteError TextLine2 Text135 55 228 25 65539 OOO_CONTROL_191 SetupCompleteSuccess BackPushButton 164 243 66 17 1 OOO_CONTROL_192 OK SetupCompleteSuccess Cancel PushButton 301 243 66 17 1 OOO_CONTROL_193 Image SetupCompleteSuccess DlgLine Line0 234 374 0 1 -SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpCheckBoxUpdates +SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpBack SetupCompleteSuccess OK PushButton 230 243 66 17 3 OOO_CONTROL_197 Cancel SetupCompleteSuccess TextLine1 Text135 8 225 45 65539 OOO_CONTROL_198 SetupCompleteSuccess TextLine2 Text135 55 228 45 65538 OOO_CONTROL_199 diff --git a/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt b/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt index b686c60..de52236 100644 --- a/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt +++ b/instsetoo_native/inc_ooolangpack/windows/msi_templates/Control.idt @@ -255,7 +255,7 @@ SetupCompleteError TextLine2 Text135 55 228 25 65539 OOO_CONTROL_191 SetupCompleteSuccess BackPushButton 164 243 66 17 1 OOO_CONTROL_192 OK SetupCompleteSuccess Cancel PushButton 301 243 66 17 1 OOO_CONTROL_193 Image SetupCompleteSuccess DlgLine Line0 234 374 0 1 -SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpCheckBoxUpdates +SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpBack SetupCompleteSuccess OK PushButton 230 243 66 17 3 OOO_CONTROL_197 Cancel SetupCompleteSuccess TextLine1 Text135 8 225 45 65539 OOO_CONTROL_198 SetupCompleteSuccess TextLine2 Text135 55 228 45 65538 OOO_CONTROL_199 diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt b/instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt index f929518..7fb391d 100644 --- a/instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt +++ b/instsetoo_native/inc_openoffice/windows/msi_templates/Control.idt @@ -259,7 +259,7 @@ SetupCompleteError TextLine2 Text135 55 228 25 65539 OOO_CONTROL_191 SetupCompleteSuccess BackPushButton 164 243 66 17 1 OOO_CONTROL_192 OK SetupCompleteSuccess Cancel PushButton 301 243 66 17 1 OOO_CONTROL_193 Image SetupCompleteSuccess DlgLine Line0 234 374 0 1 -SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpCheckBoxUpdates +SetupCompleteSuccess Image Bitmap 0 0 122 234 1 ImageBmpBack SetupCompleteSuccess OK PushButton 230 243 66 17 3 OOO_CONTROL_197 Cancel SetupCompleteSuccess TextLine1 Text135 8 225 45 65539 OOO_CONTROL_198 SetupCompleteSuccess TextLine2 Text135 55 228 45 65538 OOO_CONTROL_199 diff --git a/instsetoo_native/inc_sdkoo/windows/msi_templates/Control.idt
Re: [PATCH] make, use mixed paths on cygwin, remove ugly paths conversion
Awesome! I can confirm that this works together with Michael Stahl's --with-solver-and-workdir-root option to allow me to build using a RAM-Drive under WIndows7. Could someone check this in please? On 2012-05-06 20:57, Matúš Kukan wrote: Hello, These patches allow us to get rid of path conversions in makefiles by using cygpath -m format. But this only works with make 3.82, so configure is also changed. (Only for cygwin) There are only few exceptions where we need cygpath -u format. I am not sure if we want this now or later. (after libreoffice-3-6 branch is created ?) Posting here, so you know about this and can push if that's good. It should work without problems ;-) HTH, Matúš ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] make, use mixed paths on cygwin, remove ugly paths conversion
2012/5/7 Noel Grandin n...@peralex.com: Awesome! I can confirm that this works together with Michael Stahl's --with-solver-and-workdir-root option to allow me to build using a RAM-Drive under WIndows7. Out of interest, could you please share the know-how of building with RAM-Drive under Windows 7? Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[HOW-TO] Building LibreOffice on Windows using RAM-Drive
On 2012-05-07 14:08, Andras Timar wrote: Out of interest, could you please share the know-how of building with RAM-Drive under Windows 7? Thanks, Andras (0) I'm building under Windows7-64, using the latest Cygwin release, and the Visual Studio 2008 compiler. (1) I use the excellent free (donationware) IMDisk utility to create a ram-disk. I appear to need around 5G of space for this RAM-disk. http://www.ltr-data.se/opencode.html/#ImDisk During the build, at peak this machine was using around 10G of RAM. (2) run configure with the --with-solver-and-workdir-root option pointing at the ram-drive. For example, mine looks like --with-solver-and-workdir-root=/cygdrive/D where D: is my RAM-drive. (3) You need Matus Kukan's patch to use mixed paths under cygwin (at least until it gets committed). And voila! It builds in about an hour on this machine (8-core AMD processor) Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - oox/source
oox/source/ppt/slidefragmenthandler.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 009776a16410024a9437847af065d2160b434f30
Author: Muthu Subramanian sumu...@suse.com
Date: Sat May 5 12:48:57 2012 +0530
fdo#48778: PPTX import crashes.
This probably occurs when the document has wrong idx (?)
(cherry picked from commit 11713989b1580799635fff997b920d9bd4bf619f)
Signed-off-by: Michael Stahl mst...@redhat.com
diff --git a/oox/source/ppt/slidefragmenthandler.cxx
b/oox/source/ppt/slidefragmenthandler.cxx
index 4652690..59844ef 100644
--- a/oox/source/ppt/slidefragmenthandler.cxx
+++ b/oox/source/ppt/slidefragmenthandler.cxx
@@ -140,8 +140,8 @@ SlideFragmentHandler::~SlideFragmentHandler() throw()
case PPT_TOKEN( bgRef ):// a:CT_StyleMatrixReference
{
-FillPropertiesPtr pFillPropertiesPtr( new FillProperties(
-*mpSlidePersistPtr-getTheme()-getFillStyle(
rAttribs.getInteger( XML_idx, -1 ) ) ) );
+const FillProperties *pFillProperties =
mpSlidePersistPtr-getTheme()-getFillStyle( rAttribs.getInteger( XML_idx, -1 )
);
+FillPropertiesPtr pFillPropertiesPtr( pFillProperties ? new
FillProperties( *pFillProperties ) : new FillProperties() );
ContextHandlerRef ret = new ColorContext( *this,
mpSlidePersistPtr-getBackgroundColor() );
mpSlidePersistPtr-setBackgroundProperties( pFillPropertiesPtr );
return ret;
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PUSHED][3-5] Re: [REVIEW-3-5] PDF image export fix
On 07/05/12 08:23, Muthu Subramanian K wrote: Hi, It will be great if someone can cherry-pick this fix for n#717947, please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a651507e34ee423674d2a537f2bb4b509af6d6 Summary: when exporting to PDF, images (in notes view) aren't exported completely (they were optimized exported - i.e. small image rendered to full size). This patch fixes it. was already pushed weeks ago by Thorsten: 90872c979687c6e866ca632e770e75f05f54e3b2 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED][3-5] Re: [REVIEW-3-5] crash fix - fdo#48778
On 07/05/12 07:56, Muthu Subramanian K wrote: Hi, It will be great if someone can cherry-pick this fix, please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=11713989b1580799635fff997b920d9bd4bf619f Its a crasher - I guess, it happens with certain type of (broken?) pptx files. makes sense, pushed to libreoffice-3-5; btw perhaps it would be a good idea to have a SAL_INFO debug output there invalid index in input file or something like that. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: uui/source vcl/source
uui/source/iahndl-ssl.cxx |1 -
vcl/source/app/settings.cxx|7 ---
vcl/source/control/menubtn.cxx |7 ---
vcl/source/gdi/bitmap2.cxx |2 --
vcl/source/gdi/graph.cxx | 11 ---
vcl/source/gdi/image.cxx |2 --
vcl/source/gdi/impimage.cxx|1 -
vcl/source/gdi/metaact.cxx |1 -
vcl/source/gdi/outdev2.cxx |4
vcl/source/gdi/salmisc.cxx |3 ---
vcl/source/window/wrkwin.cxx |5 -
11 files changed, 44 deletions(-)
New commits:
commit 3312d3462318d39b90d3a30e09df08ccb20d51cc
Author: Takeshi Abe t...@fixedpoint.jp
Date: Mon May 7 22:11:27 2012 +0900
removed unused defines
Change-Id: Ieaba4fe704cc588bd515b427a7f14008afea8c03
diff --git a/uui/source/iahndl-ssl.cxx b/uui/source/iahndl-ssl.cxx
index 2b860ff..53812e2 100644
--- a/uui/source/iahndl-ssl.cxx
+++ b/uui/source/iahndl-ssl.cxx
@@ -52,7 +52,6 @@
#include boost/scoped_ptr.hpp
#define DESCRIPTION_1 1
-#define DESCRIPTION_2 2
#define TITLE 3
#define OID_SUBJECT_ALTERNATIVE_NAME 2.5.29.17
diff --git a/vcl/source/app/settings.cxx b/vcl/source/app/settings.cxx
index 939a751..cd2c7e6 100644
--- a/vcl/source/app/settings.cxx
+++ b/vcl/source/app/settings.cxx
@@ -56,13 +56,6 @@ DBG_NAME( AllSettings )
// ===
-#define STDSYS_STYLE(STYLE_OPTION_SCROLLARROW | \
- STYLE_OPTION_SPINARROW | \
- STYLE_OPTION_SPINUPDOWN | \
- STYLE_OPTION_NOMNEMONICS)
-
-// ===
-
ImplMouseData::ImplMouseData()
{
mnRefCount = 1;
diff --git a/vcl/source/control/menubtn.cxx b/vcl/source/control/menubtn.cxx
index 2bb1412..5715367 100644
--- a/vcl/source/control/menubtn.cxx
+++ b/vcl/source/control/menubtn.cxx
@@ -35,13 +35,6 @@
#include vcl/menubtn.hxx
#include vcl/svapp.hxx
-
-
-// ===
-
-#define IMAGEBUTTON_BORDER_OFF1 11
-#define IMAGEBUTTON_BORDER_OFF2 16
-
// ===
void MenuButton::ImplInitMenuButtonData()
diff --git a/vcl/source/gdi/bitmap2.cxx b/vcl/source/gdi/bitmap2.cxx
index c559383..dc05ba9 100644
--- a/vcl/source/gdi/bitmap2.cxx
+++ b/vcl/source/gdi/bitmap2.cxx
@@ -49,8 +49,6 @@
#define DIBINFOHEADERSIZE ( sizeof( DIBInfoHeader ) )
#define BITMAPINFOHEADER0x28
-#define SETPIXEL4( pBuf, nX, cChar )( (pBuf)[ (nX) 1 ] |= ( (nX) 1 ) ? (
cChar ): (cChar) 4 );
-
// --
// - Compression defines
// --
diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx
index 4f02074..35ac193 100644
--- a/vcl/source/gdi/graph.cxx
+++ b/vcl/source/gdi/graph.cxx
@@ -43,17 +43,6 @@
#include cppuhelper/typeprovider.hxx
#include rtl/instance.hxx
-// ---
-// - Compression defines -
-// ---
-
-#define COMPRESS_OWN('S'|('D'8UL))
-#define COMPRESS_NONE ( 0UL )
-#define RLE_8 ( 1UL )
-#define RLE_4 ( 2UL )
-#define BITFIELDS ( 3UL )
-#define ZCOMPRESS ( COMPRESS_OWN | 0x0100UL ) /* ==
'SD01' (binary) */
-
using namespace ::com::sun::star;
// ---
diff --git a/vcl/source/gdi/image.cxx b/vcl/source/gdi/image.cxx
index c922982..f0b8744 100644
--- a/vcl/source/gdi/image.cxx
+++ b/vcl/source/gdi/image.cxx
@@ -52,8 +52,6 @@
DBG_NAME( Image )
DBG_NAME( ImageList )
-#define IMAGE_FILE_VERSION 100
-
using namespace ::com::sun::star;
// -
diff --git a/vcl/source/gdi/impimage.cxx b/vcl/source/gdi/impimage.cxx
index 4e7ebed..99fcfb2 100644
--- a/vcl/source/gdi/impimage.cxx
+++ b/vcl/source/gdi/impimage.cxx
@@ -43,7 +43,6 @@
#define IMPSYSIMAGEITEM_MASK( 0x01 )
#define IMPSYSIMAGEITEM_ALPHA ( 0x02 )
-#define DISA_ALL( 0x )
// ---
diff --git a/vcl/source/gdi/metaact.cxx b/vcl/source/gdi/metaact.cxx
index 0572394..1a25a12 100644
--- a/vcl/source/gdi/metaact.cxx
+++ b/vcl/source/gdi/metaact.cxx
@@ -85,7 +85,6 @@ inline void ImplScaleLineInfo( LineInfo rLineInfo, double
fScaleX, double fScal
//
#define COMPAT( _def_rIStm ) VersionCompat aCompat( ( _def_rIStm ),
STREAM_READ );
-#define COMPAT_VERSION() aCompat.GetVersion()
#define WRITE_BASE_COMPAT( _def_rOStm, _def_nVer, _pWriteData ) \
MetaAction::Write( ( _def_rOStm ), _pWriteData ); \
VersionCompat aCompat( ( _def_rOStm ), STREAM_WRITE, ( _def_nVer ) );
diff --git a/vcl/source/gdi/outdev2.cxx
[Libreoffice-commits] .: sc/source unusedcode.easy
sc/source/filter/inc/drawingmanager.hxx | 30 --
sc/source/filter/oox/drawingmanager.cxx | 68
unusedcode.easy |1
3 files changed, 99 deletions(-)
New commits:
commit 7099da8058b5ca6ed681745e8049d095fd38294e
Author: Matúš Kukan matus.ku...@gmail.com
Date: Sun May 6 14:16:22 2012 +0200
unusedcode: BiffGroupObject
Change-Id: I13d969511dfb8cb87a88be47c72de4d882247f46
diff --git a/sc/source/filter/inc/drawingmanager.hxx
b/sc/source/filter/inc/drawingmanager.hxx
index 7021b38..6a1953c 100644
--- a/sc/source/filter/inc/drawingmanager.hxx
+++ b/sc/source/filter/inc/drawingmanager.hxx
@@ -196,36 +196,6 @@ private:
};
//
-
-/** A group object that is able to contain other child objects. */
-class BiffGroupObject : public BiffDrawingObjectBase
-{
-public:
-explicitBiffGroupObject( const WorksheetHelper rHelper );
-
-/** Tries to insert the passed drawing object into this or a nested group.
*/
-booltryInsert( const BiffDrawingObjectRef rxDrawingObj );
-
-protected:
-/** Reads the contents of the a BIFF3 OBJ record from the passed stream. */
-virtual voidimplReadObjBiff3( BiffInputStream rStrm, sal_uInt16
nMacroSize );
-/** Reads the contents of the a BIFF4 OBJ record from the passed stream. */
-virtual voidimplReadObjBiff4( BiffInputStream rStrm, sal_uInt16
nMacroSize );
-/** Reads the contents of the a BIFF5 OBJ record from the passed stream. */
-virtual voidimplReadObjBiff5( BiffInputStream rStrm, sal_uInt16
nNameLen, sal_uInt16 nMacroSize );
-
-/** Creates the corresponding XShape and insert it into the passed
container. */
-virtual ::com::sun::star::uno::Reference
::com::sun::star::drawing::XShape
-implConvertAndInsert( BiffDrawingBase rDrawing,
-const ::com::sun::star::uno::Reference
::com::sun::star::drawing::XShapes rxShapes,
-const ::com::sun::star::awt::Rectangle rShapeRect
) const;
-
-protected:
-BiffDrawingObjectContainer maChildren; /// All child objects contained
in this group object.
-sal_uInt16 mnFirstUngrouped; /// Object identfier of first
object not grouped into this group.
-};
-
-//
// BIFF drawing page
//
diff --git a/sc/source/filter/oox/drawingmanager.cxx
b/sc/source/filter/oox/drawingmanager.cxx
index 2d081ac..9f6f31d 100644
--- a/sc/source/filter/oox/drawingmanager.cxx
+++ b/sc/source/filter/oox/drawingmanager.cxx
@@ -221,10 +221,6 @@ BiffDrawingObjectContainer::BiffDrawingObjectContainer()
void BiffDrawingObjectContainer::insertGrouped( const BiffDrawingObjectRef
rxDrawingObj )
{
-if( !maObjects.empty() )
-if( BiffGroupObject* pGroupObj = dynamic_cast BiffGroupObject* (
maObjects.back().get() ) )
-if( pGroupObj-tryInsert( rxDrawingObj ) )
-return;
maObjects.push_back( rxDrawingObj );
}
@@ -536,70 +532,6 @@ void BiffDrawingObjectBase::implReadObjBiff8SubRec(
BiffInputStream /*rStrm*/,
}
//
-
-BiffGroupObject::BiffGroupObject( const WorksheetHelper rHelper ) :
-BiffDrawingObjectBase( rHelper ),
-mnFirstUngrouped( BIFF_OBJ_INVALID_ID )
-{
-}
-
-bool BiffGroupObject::tryInsert( const BiffDrawingObjectRef rxDrawingObj )
-{
-if( rxDrawingObj-getObjId() == mnFirstUngrouped )
-return false;
-// insert into own list or into nested group
-maChildren.insertGrouped( rxDrawingObj );
-return true;
-}
-
-void BiffGroupObject::implReadObjBiff3( BiffInputStream rStrm, sal_uInt16
nMacroSize )
-{
-rStrm.skip( 4 );
-rStrm mnFirstUngrouped;
-rStrm.skip( 16 );
-readMacroBiff3( rStrm, nMacroSize );
-}
-
-void BiffGroupObject::implReadObjBiff4( BiffInputStream rStrm, sal_uInt16
nMacroSize )
-{
-rStrm.skip( 4 );
-rStrm mnFirstUngrouped;
-rStrm.skip( 16 );
-readMacroBiff4( rStrm, nMacroSize );
-}
-
-void BiffGroupObject::implReadObjBiff5( BiffInputStream rStrm, sal_uInt16
nNameLen, sal_uInt16 nMacroSize )
-{
-rStrm.skip( 4 );
-rStrm mnFirstUngrouped;
-rStrm.skip( 16 );
-readNameBiff5( rStrm, nNameLen );
-readMacroBiff5( rStrm, nMacroSize );
-}
-
-Reference XShape BiffGroupObject::implConvertAndInsert( BiffDrawingBase
rDrawing,
-const Reference XShapes rxShapes, const Rectangle rShapeRect )
const
-{
-Reference XShape xGroupShape;
-if( !maChildren.empty() ) try
-{
-xGroupShape = rDrawing.createAndInsertXShape( CREATE_OUSTRING(
com.sun.star.drawing.GroupShape ), rxShapes, rShapeRect );
-Reference XShapes
[REVIEW:3-5] fdo#48193 fix RTF import of fields without a result
Hi,
See
http://cgit.freedesktop.org/libreoffice/core/commit/?id=bec0bab
This never really worked (foopage numberbar was imported as
foopagenumber), but without this commit in 3.5 it got even worse, as
foo-. Backported patch attached.
Thanks,
Miklos
From 338cf7de8e2bc63cab38898dcb1875b977fed3ea Mon Sep 17 00:00:00 2001
From: Miklos Vajna vmik...@suse.cz
Date: Wed, 25 Apr 2012 11:21:06 +0200
Subject: [PATCH] fdo#48193 fix RTF import of fields without a result
---
writerfilter/source/rtftok/rtfdocumentimpl.cxx | 26 +++-
writerfilter/source/rtftok/rtfdocumentimpl.hxx |9
2 files changed, 34 insertions(+), 1 deletions(-)
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.cxx b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
index b74b26e..23df13f 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.cxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.cxx
@@ -1097,7 +1097,7 @@ int RTFDocumentImpl::dispatchDestination(RTFKeyword nKeyword)
m_aStates.top().nDestinationState = DESTINATION_STYLESHEET;
break;
case RTF_FIELD:
-// A field consists of an fldinst and an fldrslt group.
+m_aStates.top().nDestinationState = DESTINATION_FIELD;
break;
case RTF_FLDINST:
{
@@ -3526,6 +3526,30 @@ int RTFDocumentImpl::popState()
}
else if (bLevelNumbersEnd)
m_aStates.top().aTableSprms = aSprms;
+else if (aState.nDestinationState == DESTINATION_FIELDINSTRUCTION)
+m_aStates.top().nFieldStatus = FIELD_INSTRUCTION;
+else if (aState.nDestinationState == DESTINATION_FIELDRESULT)
+m_aStates.top().nFieldStatus = FIELD_RESULT;
+else if (aState.nDestinationState == DESTINATION_FIELD)
+{
+if (aState.nFieldStatus == FIELD_INSTRUCTION)
+{
+sal_uInt8 sFieldEnd[] = { 0x15 };
+if (!m_pCurrentBuffer)
+{
+Mapper().startCharacterGroup();
+Mapper().text(sFieldEnd, 1);
+Mapper().endCharacterGroup();
+}
+else
+{
+m_pCurrentBuffer-push_back(make_pair(BUFFER_STARTRUN, RTFValue::Pointer_t()));
+RTFValue::Pointer_t pValue(new RTFValue(*sFieldEnd));
+m_pCurrentBuffer-push_back(make_pair(BUFFER_TEXT, pValue));
+m_pCurrentBuffer-push_back(make_pair(BUFFER_ENDRUN, RTFValue::Pointer_t()));
+}
+}
+}
else if (bPopShapeProperties)
{
m_aStates.top().aShape = aShape;
diff --git a/writerfilter/source/rtftok/rtfdocumentimpl.hxx b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
index 1d0a37d..885f75a 100644
--- a/writerfilter/source/rtftok/rtfdocumentimpl.hxx
+++ b/writerfilter/source/rtftok/rtfdocumentimpl.hxx
@@ -65,6 +65,7 @@ namespace writerfilter {
DESTINATION_STYLESHEET,
DESTINATION_STYLEENTRY,
DESTINATION_EQINSTRUCTION,
+DESTINATION_FIELD,
DESTINATION_FIELDINSTRUCTION,
DESTINATION_FIELDRESULT,
DESTINATION_LISTTABLE,
@@ -162,6 +163,13 @@ namespace writerfilter {
BMPSTYLE_PNG
};
+enum RTFFieldStatus
+{
+FIELD_NONE,
+FIELD_INSTRUCTION,
+FIELD_RESULT
+};
+
/// A buffer storing dmapper calls.
typedef std::deque std::pairRTFBufferTypes, RTFValue::Pointer_t RTFBuffer_t;
@@ -245,6 +253,7 @@ namespace writerfilter {
RTFDocumentImpl* m_pDocumentImpl;
RTFInternalState nInternalState;
RTFDesitnationState nDestinationState;
+RTFFieldStatus nFieldStatus;
RTFBorderState nBorderState;
// font table, stylesheet table
RTFSprms aTableSprms;
--
1.7.7
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][3-5] Re: [REVIEW-3-5] PDF image export fix
Oops..sorry for the troubles, missed that some how :( Thank you so much! On 05/07/2012 06:02 PM, Michael Stahl wrote: On 07/05/12 08:23, Muthu Subramanian K wrote: Hi, It will be great if someone can cherry-pick this fix for n#717947, please? http://cgit.freedesktop.org/libreoffice/core/commit/?id=03a651507e34ee423674d2a537f2bb4b509af6d6 Summary: when exporting to PDF, images (in notes view) aren't exported completely (they were optimized exported - i.e. small image rendered to full size). This patch fixes it. was already pushed weeks ago by Thorsten: 90872c979687c6e866ca632e770e75f05f54e3b2 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [HOW-TO] Building LibreOffice on Windows using RAM-Drive
On Mon, May 7, 2012 at 5:26 AM, Noel Grandin n...@peralex.com wrote: On 2012-05-07 14:08, Andras Timar wrote: Out of interest, could you please share the know-how of building with RAM-Drive under Windows 7? Thanks, Andras (0) I'm building under Windows7-64, using the latest Cygwin release, and the Visual Studio 2008 compiler. (1) I use the excellent free (donationware) IMDisk utility to create a ram-disk. I appear to need around 5G of space for this RAM-disk. http://www.ltr-data.se/opencode.html/#ImDisk During the build, at peak this machine was using around 10G of RAM. (2) run configure with the --with-solver-and-workdir-root option pointing at the ram-drive. For example, mine looks like --with-solver-and-workdir-root=/cygdrive/D where D: is my RAM-drive. (3) You need Matus Kukan's patch to use mixed paths under cygwin (at least until it gets committed). And voila! It builds in about an hour on this machine (8-core AMD processor) As oppose to how long before ? iow what is the gain ? Norbert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [HOW-TO] Building LibreOffice on Windows using RAM-Drive
Was 1h55 before, now approx 55min On 2012-05-07 16:06, Norbert Thiebaud wrote: As oppose to how long before ? iow what is the gain ? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - vcl/source vcl/unx
vcl/source/control/scrbar.cxx|2 ++
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |1 -
2 files changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 092d72a5591283459eb261e26d57ad8ecf1d5280
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon May 7 14:28:10 2012 +0400
gtk: scrollbar: fix visual response to a mouse click
Change-Id: I5f3b7f1bba1d751004399e4ea995acc813df3636
diff --git a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
index b2b6d7c..9da696c 100644
--- a/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx
@@ -1659,7 +1659,6 @@ sal_Bool GtkSalGraphics::NWPaintGTKScrollbar(
ControlType, ControlPart nPart,
if ( has_slider )
{
NWConvertVCLStateToGTKState( pScrollbarVal-mnThumbState, stateType,
shadowType );
-if ( pScrollbarVal-mnThumbState CTRL_STATE_PRESSED ) stateType =
GTK_STATE_PRELIGHT;
gtk_paint_slider( style, gdkDrawable, stateType, GTK_SHADOW_OUT,
gdkRect, GTK_WIDGET(scrollbarWidget), slider,
x+hShim+thumbRect.Left(), y+vShim+thumbRect.Top(),
commit b07d7d348a728fc54991320ff7bc882f341478af
Author: Ivan Timofeev timofeev@gmail.com
Date: Mon May 7 14:10:56 2012 +0400
fdo#49421: do not divide by zero when scrollbar cannot be moved
Change-Id: I63338f6c2cfa3d206260b536a44de3d51fcd5710
diff --git a/vcl/source/control/scrbar.cxx b/vcl/source/control/scrbar.cxx
index 44a093b..78e05fd 100644
--- a/vcl/source/control/scrbar.cxx
+++ b/vcl/source/control/scrbar.cxx
@@ -63,6 +63,8 @@ using ::rtl::OUString;
static long ImplMulDiv( long nNumber, long nNumerator, long nDenominator )
{
+if (!nDenominator)
+return 0;
double n = ((double)nNumber * (double)nNumerator) / (double)nDenominator;
return (long)n;
}
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [HOW-TO] Building LibreOffice on Windows using RAM-Drive
On Mon, May 7, 2012 at 4:15 PM, Noel Grandin n...@peralex.com wrote: Was 1h55 before, now approx 55min Just for reference: 3h45m for a Windows full debug build in my computer using the VM. -- Jesús Corrius je...@softcatala.org ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [HOW-TO] Building LibreOffice on Windows using RAM-Drive
On 7 May 2012 14:26, Noel Grandin n...@peralex.com wrote: (3) You need Matus Kukan's patch to use mixed paths under cygwin (at least until it gets committed). I think Michael's patch [1] also helps? Just saying there are also other options. [1] http://lists.freedesktop.org/archives/libreoffice/2012-May/031166.html Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: instsetoo_native/inc_ooohelppack instsetoo_native/inc_ooolangpack instsetoo_native/inc_openoffice instsetoo_native/inc_sdkoo instsetoo_native/inc_ure
instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt |4 ++-- instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt |4 ++-- instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt |4 ++-- instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt |4 ++-- instsetoo_native/inc_ure/windows/msi_templates/ControlC.idt |4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 7bfded003e8333b167c94f9f55ce7cc224f5cd7b Author: Andras Timar ati...@suse.com Date: Mon May 7 16:38:00 2012 +0200 fix condition for SetupCompleteSuccess Change-Id: Ia134204af1747f570e3048b47c2e12415ceb56b3 diff --git a/instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt b/instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt index 99e5224..9e3faef 100644 --- a/instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt +++ b/instsetoo_native/inc_ooohelppack/windows/msi_templates/ControlC.idt @@ -29,8 +29,8 @@ SetupCompleteErrorRestContText1 HideNOT UpdateStarted SetupCompleteError RestContText1 ShowUpdateStarted SetupCompleteError RestContText2 HideNOT UpdateStarted SetupCompleteError RestContText2 ShowUpdateStarted -SetupCompleteSuccess TextLine2 ShowProgressType2=installed And ((ACTIONINSTALL) -SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled And ((ACTIONINSTALL) +SetupCompleteSuccess TextLine2 ShowProgressType2=installed +SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled SetupInterrupted BackDefault UpdateStarted SetupInterrupted BackDisable NOT UpdateStarted SetupInterrupted BackEnable UpdateStarted diff --git a/instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt b/instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt index 99e5224..9e3faef 100644 --- a/instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt +++ b/instsetoo_native/inc_ooolangpack/windows/msi_templates/ControlC.idt @@ -29,8 +29,8 @@ SetupCompleteErrorRestContText1 HideNOT UpdateStarted SetupCompleteError RestContText1 ShowUpdateStarted SetupCompleteError RestContText2 HideNOT UpdateStarted SetupCompleteError RestContText2 ShowUpdateStarted -SetupCompleteSuccess TextLine2 ShowProgressType2=installed And ((ACTIONINSTALL) -SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled And ((ACTIONINSTALL) +SetupCompleteSuccess TextLine2 ShowProgressType2=installed +SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled SetupInterrupted BackDefault UpdateStarted SetupInterrupted BackDisable NOT UpdateStarted SetupInterrupted BackEnable UpdateStarted diff --git a/instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt b/instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt index 6239d90..ae5f29d 100644 --- a/instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt +++ b/instsetoo_native/inc_openoffice/windows/msi_templates/ControlC.idt @@ -36,8 +36,8 @@ SetupCompleteErrorRestContText1 HideNOT UpdateStarted SetupCompleteError RestContText1 ShowUpdateStarted SetupCompleteError RestContText2 HideNOT UpdateStarted SetupCompleteError RestContText2 ShowUpdateStarted -SetupCompleteSuccess TextLine2 ShowProgressType2=installed And ((ACTIONINSTALL) -SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled And ((ACTIONINSTALL) +SetupCompleteSuccess TextLine2 ShowProgressType2=installed +SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled SetupInterrupted BackDefault UpdateStarted SetupInterrupted BackDisable NOT UpdateStarted SetupInterrupted BackEnable UpdateStarted diff --git a/instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt b/instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt index 99e5224..9e3faef 100644 --- a/instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt +++ b/instsetoo_native/inc_sdkoo/windows/msi_templates/ControlC.idt @@ -29,8 +29,8 @@ SetupCompleteErrorRestContText1 HideNOT UpdateStarted SetupCompleteError RestContText1 ShowUpdateStarted SetupCompleteError RestContText2 HideNOT UpdateStarted SetupCompleteError RestContText2 ShowUpdateStarted -SetupCompleteSuccess TextLine2 ShowProgressType2=installed And ((ACTIONINSTALL) -SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled And ((ACTIONINSTALL) +SetupCompleteSuccess TextLine2 ShowProgressType2=installed +SetupCompleteSuccess TextLine3 ShowProgressType2=uninstalled SetupInterrupted BackDefault UpdateStarted
Re: [HOW-TO] Building LibreOffice on Windows using RAM-Drive
I was only using Matus' patch when I did the successful build. On 2012-05-07 16:28, Matúš Kukan wrote: On 7 May 2012 14:26, Noel Grandinn...@peralex.com wrote: (3) You need Matus Kukan's patch to use mixed paths under cygwin (at least until it gets committed). I think Michael's patch [1] also helps? Just saying there are also other options. [1] http://lists.freedesktop.org/archives/libreoffice/2012-May/031166.html Best, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - bean/com bean/native Repository.mk scp2/source
Repository.mk|2 +-
bean/com/sun/star/comp/beans/LocalOfficeConnection.java |2 +-
bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c | 10 ++
bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c |7 +--
scp2/source/ooo/file_library_ooo.scp | 11 ++-
5 files changed, 23 insertions(+), 9 deletions(-)
New commits:
commit 708229dc96533b6f165b82ce4d9e07537d1ce8b1
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon May 7 16:54:43 2012 +0200
fdo#49580: Fix bean after gbuild'ification
4478b739ddade09425d496cbddee1542fdfd5e9b convert bean to gbuild and add to
tail_build broke the following:
* The name of the officebean dynamic library must not be changed (by adding
the
lo extension), as code in officebean.jar uses it in NativeLibraryLoader.
* With gbuild's per-default hidden visibility, JNIEXPORT functions must
instead
use SAL_DLLPUBLIC_EXPORT. (Windows-only code in bean/native/win32/
should be
safe to continue using JNIEXPORT.)
Change-Id: I I3c312dd05c90421ba0c726496b7149a26d155604
diff --git a/Repository.mk b/Repository.mk
index 68a8890..900b538 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -218,7 +218,6 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
forui \
odbc \
odbcbase \
-officebean \
oox \
ooxml \
sdbc \
@@ -409,6 +408,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \
localedata_euro \
localedata_others \
mcnttype \
+officebean \
package2 \
scriptframe \
smoketest \
diff --git a/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
b/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
index a45b49e..cc35283 100644
--- a/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
+++ b/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
@@ -26,6 +26,8 @@
*
/
+#include sal/config.h
+
#include X11/Xlib.h
#include X11/Xutil.h
#include X11/Intrinsic.h
@@ -40,7 +42,7 @@
#include jawt_md.h
#include jawt.h
-/*#include ../inc/com_sun_star_comp_beans_LocalOfficeWindow.h*/
+#include sal/types.h
#if defined assert
#undef assert
@@ -55,7 +57,7 @@
#define SYSTEM_MAC 5
#define SYSTEM_XWINDOW 6
-JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
(JNIEnv * env, jobject obj_this);
/*/
@@ -64,7 +66,7 @@ JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNative
* Method:getNativeWindowSystemType
* Signature: ()I
*/
-JNIEXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindowSystemType
+SAL_DLLPUBLIC_EXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindowSystemType
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
@@ -79,7 +81,7 @@ JNIEXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
* Method:getNativeWindow
* Signature: ()J
*/
-JNIEXPORT jlong JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
diff --git a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
index 5b36110..8510dc3 100644
--- a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
+++ b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
@@ -26,6 +26,8 @@
*
/
+#include sal/config.h
+
#include X11/Xlib.h
#include X11/Xutil.h
#include X11/Intrinsic.h
@@ -40,6 +42,7 @@
#include jawt_md.h
#include jawt.h
+#include sal/types.h
#define SYSTEM_WIN32 1
#define SYSTEM_WIN16 2
@@ -71,7 +74,7 @@ static void ThrowException(JNIEnv * env, char const * type,
char const * msg) {
* Method:getNativeWindowSystemType
* Signature: ()I
*/
-JNIEXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindowSystemType
+SAL_DLLPUBLIC_EXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindowSystemType
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
@@ -86,7 +89,7 @@ JNIEXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeW
* Method:getNativeWindow
* Signature: ()J
*/
-JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
[REVIEW-3-5] fdo#49580: Fix bean after gbuild'ification
Please consider the below fix for
https://bugs.freedesktop.org/show_bug.cgi?id=49580 OfficeBean.jar
references officebean.dll not officebeanlo.dll for inclusion in 3.5.
Thanks,
Stephan
On 05/07/2012 05:03 PM, Stephan Bergmann wrote:
commit 708229dc96533b6f165b82ce4d9e07537d1ce8b1
Author: Stephan Bergmannsberg...@redhat.com
Date: Mon May 7 16:54:43 2012 +0200
fdo#49580: Fix bean after gbuild'ification
4478b739ddade09425d496cbddee1542fdfd5e9b convert bean to gbuild and add to
tail_build broke the following:
* The name of the officebean dynamic library must not be changed (by
adding the
lo extension), as code in officebean.jar uses it in
NativeLibraryLoader.
* With gbuild's per-default hidden visibility, JNIEXPORT functions must
instead
use SAL_DLLPUBLIC_EXPORT. (Windows-only code in bean/native/win32/
should be
safe to continue using JNIEXPORT.)
Change-Id: I I3c312dd05c90421ba0c726496b7149a26d155604
diff --git a/Repository.mk b/Repository.mk
index 68a8890..900b538 100644
--- a/Repository.mk
+++ b/Repository.mk
@@ -218,7 +218,6 @@ $(eval $(call gb_Helper_register_libraries,OOOLIBS, \
forui \
odbc \
odbcbase \
-officebean \
oox \
ooxml \
sdbc \
@@ -409,6 +408,7 @@ $(eval $(call gb_Helper_register_libraries,PLAINLIBS_OOO, \
localedata_euro \
localedata_others \
mcnttype \
+officebean \
package2 \
scriptframe \
smoketest \
diff --git a/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
b/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
index a45b49e..cc35283 100644
--- a/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
+++ b/bean/native/unix/com_sun_star_beans_LocalOfficeWindow.c
@@ -26,6 +26,8 @@
*
/
+#include sal/config.h
+
#includeX11/Xlib.h
#includeX11/Xutil.h
#includeX11/Intrinsic.h
@@ -40,7 +42,7 @@
#include jawt_md.h
#include jawt.h
-/*#include ../inc/com_sun_star_comp_beans_LocalOfficeWindow.h*/
+#include sal/types.h
#if defined assert
#undef assert
@@ -55,7 +57,7 @@
#define SYSTEM_MAC 5
#define SYSTEM_XWINDOW 6
-JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
(JNIEnv * env, jobject obj_this);
/*/
@@ -64,7 +66,7 @@ JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNative
* Method:getNativeWindowSystemType
* Signature: ()I
*/
-JNIEXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindowSystemType
+SAL_DLLPUBLIC_EXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindowSystemType
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
@@ -79,7 +81,7 @@ JNIEXPORT jint JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
* Method:getNativeWindow
* Signature: ()J
*/
-JNIEXPORT jlong JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
Java_com_sun_star_beans_LocalOfficeWindow_getNativeWindow
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
diff --git a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
index 5b36110..8510dc3 100644
--- a/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
+++ b/bean/native/unix/com_sun_star_comp_beans_LocalOfficeWindow.c
@@ -26,6 +26,8 @@
*
/
+#include sal/config.h
+
#includeX11/Xlib.h
#includeX11/Xutil.h
#includeX11/Intrinsic.h
@@ -40,6 +42,7 @@
#include jawt_md.h
#include jawt.h
+#include sal/types.h
#define SYSTEM_WIN32 1
#define SYSTEM_WIN16 2
@@ -71,7 +74,7 @@ static void ThrowException(JNIEnv * env, char const * type,
char const * msg) {
* Method:getNativeWindowSystemType
* Signature: ()I
*/
-JNIEXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindowSystemType
+SAL_DLLPUBLIC_EXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindowSystemType
(JNIEnv * env, jobject obj_this)
{
(void) env; /* avoid warning about unused parameter */
@@ -86,7 +89,7 @@ JNIEXPORT jint JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeW
* Method:getNativeWindow
* Signature: ()J
*/
-JNIEXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
+SAL_DLLPUBLIC_EXPORT jlong JNICALL
Java_com_sun_star_comp_beans_LocalOfficeWindow_getNativeWindow
(JNIEnv * env, jobject obj_this)
{
jboolean result;
diff --git
[Libreoffice-commits] .: vcl/win
vcl/win/source/gdi/salnativewidgets-luna.cxx | 10 ++ 1 file changed, 10 insertions(+) New commits: commit f0e68c48b95e223704d51257f6c767204d6b63c0 Author: Jan Holesovsky ke...@suse.cz Date: Mon May 7 17:52:16 2012 +0200 Add some useful links to the Windows theming. Change-Id: I2ced06de50b145ab9a876679f1ec49dd8915fbf9 diff --git a/vcl/win/source/gdi/salnativewidgets-luna.cxx b/vcl/win/source/gdi/salnativewidgets-luna.cxx index 888b1a7..1f684b8 100644 --- a/vcl/win/source/gdi/salnativewidgets-luna.cxx +++ b/vcl/win/source/gdi/salnativewidgets-luna.cxx @@ -26,6 +26,16 @@ * / +// General info: +// http://msdn.microsoft.com/en-us/library/windows/desktop/hh270423%28v=vs.85%29.aspx +// http://msdn.microsoft.com/en-us/library/windows/desktop/bb773178%28v=vs.85%29.aspx +// +// Useful tool to explore the themes their rendering: +// http://privat.rejbrand.se/UxExplore.exe +// (found at http://stackoverflow.com/questions/4009701/windows-visual-themes-gallery-of-parts-and-states/4009712#4009712) +// +// Theme subclasses: +// http://msdn.microsoft.com/en-us/library/windows/desktop/bb773218%28v=vs.85%29.aspx #define _SV_SALNATIVEWIDGETS_CXX ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: vcl/win
vcl/win/source/window/salframe.cxx |4
1 file changed, 4 insertions(+)
New commits:
commit 05597378a1f8aa5ff691d7e4b61cdb70b797cb6a
Author: Jan Holesovsky ke...@suse.cz
Date: Mon May 7 18:19:37 2012 +0200
Added a fixme.
Change-Id: I303a750058039a4df5a237c823178c8a065f04a4
diff --git a/vcl/win/source/window/salframe.cxx
b/vcl/win/source/window/salframe.cxx
index 3cb870b..aae5999 100644
--- a/vcl/win/source/window/salframe.cxx
+++ b/vcl/win/source/window/salframe.cxx
@@ -2704,6 +2704,10 @@ static HRESULT WINAPI
backwardCompatibleDwmIsCompositionEnabled( BOOL* pOut )
static BOOL ImplDwmIsCompositionEnabled()
{
+// FIXME It seems that this wrong advice to use 'DwmIsCompositionEnabled'
+// is widely spread; causing LO to not theme menus when running in
+// rdesktop. We should beter use IsThemeActive() from uxtheme.dll.
+// But the entire ::UpdateSettings() need a rework anyway ;-)
SalData* pSalData = GetSalData();
if( ! pSalData-mpDwmIsCompositionEnabled )
{
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
blanket license statement
Hi everyone, All of my past future contributions to LibreOffice may be licensed under the MPL/LGPLv3+ dual license. Regards, Joachim. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] Revert Set the listbox height to an integer multiple of the listbox entry height
Hi, this patch reverts commit http://cgit.freedesktop.org/libreoffice/core/commit/?id=16c9d63da67897e51960f3684d8d05b06f2c8f81 Quote: This ensures that we don't get a half visible entry at the bottom of the view. Actually that creates some problems: 1. Some listboxes get too small so that it's impossible to use the scrollbar.[1] 2. Just open the LibreOffice file picker and resize it. Notice the ugly gray space between the bottom of the listbox and the bottom of the decoration. I wonder what's ugly in a partially visible item at the bottom? Yes, I can make the current behavior optional and use it somewhere. But where?.. [1] https://bugs.freedesktop.org/attachment.cgi?id=60955 Regards, Ivan 0001-Revert-Set-the-listbox-height-to-an-integer-multiple.patch Description: application/mbox ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-5] calc import filters sometimes get shape positions badly wrong ( fdo##49430 )
Hi Noel, On Friday, 2012-05-04 10:33:37 +0100, Noel Power wrote: There seems to be some issue with how the drawing layer and the grid/view part calculate positions :/ they just don't agree. Yes, that's due to accumulated rounding errors when converting to/from drawing layer 100th mm mapping and the integer positioning. For unequal row heights that becomes even worse. The hope was that Armin's new drawing layer with double values could solve that. Maybe we can tweak it a little by calculating row heights to drawing layer differently, but past experience was that each time a can of worms was opened.. Eike I cc you here as maybe you can shed some light on this weirdness ( I confess it confuses the hell out me ) otoh I think this patch is safe, it also addresses another issue ( see details in bug ) where sometimes ( like in the attached test document ) the shape size is imported incorrectly and the shape may not be visible. While the import looks clearly better now it seems that it fixes only one symptom. When loading shapeanchorskew.xls of https://bugs.freedesktop.org/attachment.cgi?id=60994 it looks ok after load, but saving the file and reloading it's off again, approximately by the same amount as before, just in the other direction further down, and row heights wrong, nearly doubled and not saving different heights. I tried with 3.4.5 and there the objects are imported to the correct row and also survive save/reload (except that row heights are saved wrongly also there), from 3.5.0 it's broken. Funny enough, after save/reload .xls in 3.5.x the objects do appear in row 517 as they should, again with the wrong and equal row heights. Saving/reloading to/from .ods it's worse and objects are off even further to the top, in 3.4.5, 3.5.x and with your patch, but only if loaded from an .xls file. Once saved to .odf the position stays fixed. I'm hesitating to push your patch because it changes behavior such that after import it looks ok but saving messes things up so may go unnoticed. Before at least it was clearly visible that something's wrong ;-) Would be good if you could find the cause of the jumping around when saving/reloading, and why row heights aren't saved properly. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpUmpjJKhqXC.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Lior Kaplan kaplanl...@gmail.com changed: What|Removed |Added Depends on||33538 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Bug 37361] LibreOffice 3.5 most annoying bugs
Bug_ID=49342 is not fixed in LOdev 3.5.4rc0+ (Win-x86@7-MinGW; Build ID: 009776a-a73d29c-6845e52-f269e46; Data stamp: 2012-05-07_12.31.58) Error persists. -- View this message in context: http://nabble.documentfoundation.org/Bug-37361-LibreOffice-3-5-most-annoying-bugs-tp3964746p3969474.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/core/data/dociter.cxx | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
New commits:
commit 864fc92a5644ea56cd0fd3dec4e40601b828b31c
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon May 7 03:27:18 2012 +0200
string result of formula is also valid, fdo#49052
Change-Id: I I0beb439381a0d01b27d219b148c47839055b6f62
(cherry picked from commit c0ca1ef1990226cd5d7af6c1f76872e9ad8711f2)
Signed-off-by: Eike Rathke er...@redhat.com
Backported to use the older void ScFormulaCell::GetString(String)
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 0b466c0..1ab2b43 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -616,8 +616,16 @@ bool
ScDBQueryDataIterator::DataAccessInternal::getCurrent(Value rValue)
rValue.mnError =
((ScFormulaCell*)pCell)-GetErrCode();
return sal_True;// gefunden
}
-else
+else if(mpParam-mbSkipString)
nRow++;
+else
+{
+static_castScFormulaCell*(pCell)-GetString(
rValue.maString);
+rValue.mfValue = 0.0;
+rValue.mnError =
static_castScFormulaCell*(pCell)-GetErrCode();
+rValue.mbIsNumber = false;
+return true;
+}
}
break;
case CELLTYPE_STRING:
___
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Weird code in apple_remote
I noticed that when I run LO master built against the 10.6 SDK (with
Clang from Xcode 4.3.2, if it matters), I see messages like this:
2012-05-07 22:12:34.637 soffice[65405:6a03] ***
+[AppleRemote0x38f578c init]: cannot init a class object.
2012-05-07 22:12:34.641 soffice[65405:6a03] (
0 CoreFoundation 0x9b795b67 __raiseError + 231
1 libobjc.A.dylib 0x9a8a5149 objc_exception_throw
+ 155
2 CoreFoundation 0x9b798c2d +[NSObject init] +
237
3 libAppleRemotelo.dylib 0x038efa73 +[RemoteControl
sendDistributedNotification:targetBundleIdentifier:] + 51
4 libAppleRemotelo.dylib 0x038efbc2 +[RemoteControl
sendFinishedNotifcationForAppIdentifier:] + 50
5 libAppleRemotelo.dylib 0x038f0f8f
-[HIDRemoteControlDevice stopListening:] + 319
6 libAppleRemotelo.dylib 0x038f00b2
-[RemoteControlContainer stopListening:] + 98
7 libvcllo.dylib 0x027d7ba8
-[VCL_NSApplication applicationWillResignActive:] + 104
At first the message cannot init a class object sounded a but terse
and obscure, but after some thinking and googling I realized that it
actually means exactly what it says...
The code in question is in apple_remote/source/RemoteControl.m, in the
class method +sendDistributedNotification:targetBundleIdentifier: .
Look:
+ (void) sendDistributedNotification: (NSString*) notificationName
targetBundleIdentifier: (NSString*) targetIdentifier
{
if ( (self = [super init]) ) {
...
WTF? As far as I understand, it makes no sense to call [super init] in
a class method.
The well-known init is an instance method. In a class method, I
guess self refers to the class object for the class, so the code
does compile, even if it is equivalent to using this in a static
class method in C++, more or less. So the code tries to call the
instance method init of the RemoteControl class's superclass's
(which is NSObject) (meta)class object... That makes no sense, does
it? Do class objects even have init methods? Can there be some weird
(accidentally working?) mechanism that actually makes the code
necessary and sane, at least if built against the 10.4 and earlier
SDKs?
Googling I find for instance
http://www.iphonedevsdk.com/forum/objective-c-python-ruby-development/58572-simple-question.html#post243571
.
It would be interesting to know why qɔᴉɹə added that code when he
adapted Martin Kahr's Apple Remote Control code to OOo. Unfortunately
I can't find the upstream version of Martin Kahr's code that the
OOo/LO code is based upon, so I can't extract the exact changes he
did.
The current upstream at
https://github.com/martinkahr/apple_remote_control starts with an
initial import in 2009, while qɔᴉɹə's adaptation of it for OOo is from
CWS appleremote01 which was integrated in 2008.
It probably would be a good idea to update the apple_remote code to
the latest version of Martin Kahr's code, and then try to re-apply
those changes by qɔᴉɹə that still make sense. If only one had time to
investigate more... But anyway, I probably will at least remove that
obviously (?) bogus line of code. I don't have a remote control so I
can't check if the code still works after that, though... and I only
have 10.7...
--tml
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][REVIEW-3-5] fix for fdo#49052, string result of formulas is ignored by DGET()
Hi Markus, On Monday, 2012-05-07 05:40:12 +0200, Markus Mohrhard wrote: [1] should fix the problem that string result from formulas are ignored in DGET and maybe some other DB functions. Looks good and fixes the bug. Pushed to 3-5 with a little massaging as rtl::OUString ScFormulaCell::GetString() isn't available there. http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-5id=864fc92a5644ea56cd0fd3dec4e40601b828b31c Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpgtPEtkGWqr.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [GSOC] Template UI Dialog
On Thu, May 3, 2012 at 3:31 AM, Cedric Bosdonnat cbosdon...@suse.comwrote: Hello Rafael, Great to see that you are still around :) Do you have exams or classes that could conflict with GSoC? It would be great for you to join the des...@global.libreoffice.org mailing list: the guys there are eager to work with you on this project. IMHO, we should split the project into pieces to be able to process step by step: 1/ create a dialog browsing local templates. 2/ integrate the CMIS connection into the dialog 3/ enhance CMIS support in the template repository if needed. 4/ enhance the dialog with some more useful infos like rating, tags... You can contact me on IRC pretty easily during the european office hours, but I don't know at what time of the day you'll be working. We need to sync on the time to meet on IRC (due to the big TZ difference). Do you have an idea where to start in the code already? I talked with the design guys this saturday, and we should have a almost final design ready this weekend to work on. It will be with the most important and basic stuff needed to get work going. About the classes and stuff, yes ill be having classes and exams during the gsoc but only half day, so ill be working noon/night my time on the gsoc stuff. I checked the CMIS code, but ill need some pointers on how to use that, im guessing i need to use that through uno stuff right?? This week, im gonna try doing basic stuff with the GUI to get more familiar with it and know exactly what i need todo when implementing the full dialog and already got libreoffice compiled without issues on latest master. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - apple_remote/inc apple_remote/source
apple_remote/inc/apple_remote/RemoteControl.h|3 +++
apple_remote/inc/apple_remote/RemoteMainController.h |3 +++
apple_remote/source/AppleRemote.h|3 +++
apple_remote/source/AppleRemote.m|3 +++
apple_remote/source/GlobalKeyboardDevice.h |3 +++
apple_remote/source/GlobalKeyboardDevice.m |3 +++
apple_remote/source/HIDRemoteControlDevice.h |3 +++
apple_remote/source/HIDRemoteControlDevice.m |2 ++
apple_remote/source/KeyspanFrontRowControl.h |3 +++
apple_remote/source/KeyspanFrontRowControl.m |3 +++
apple_remote/source/MultiClickRemoteBehavior.h |3 +++
apple_remote/source/MultiClickRemoteBehavior.m |3 +++
apple_remote/source/RemoteControl.m |5 +++--
apple_remote/source/RemoteControlContainer.h |3 +++
apple_remote/source/RemoteControlContainer.m |3 +++
apple_remote/source/RemoteMainController.m |3 +++
16 files changed, 47 insertions(+), 2 deletions(-)
New commits:
commit fbd82ae8835adf40930be35e7cf14ce812786224
Author: Tor Lillqvist t...@iki.fi
Date: Tue May 8 00:03:53 2012 +0300
Bin a line of apparently meaningless and wrong Mac OS X code
When LibreOffice is compiled against the 10.6 SDK and run under gdb,
the apple_remote code caused cannot init a class object exception
messages to be printed.
Upon closer inspection this was caused by the call to [super init] in
the sendDistributedNotification class method of the RemoteControl
class.
As far as I understand, calling [super init] and assigning its return
value to self, even, is pointless and wrong in a class method.
This code apparently has not been causing any harm when built against
the 10.4 SDK. This is probably just accidental thanks to a more
lenient Objective-C runtime getting used?
When built against the 10.6 SDK, though, the resulting Objective-C
exception seemed to make input event handling non-functional. After
this fix LibreOffice built this way works better.
Change-Id: I I I383611753f3f83a9efa4694b1900c8b66ed1a8e3
diff --git a/apple_remote/source/RemoteControl.m
b/apple_remote/source/RemoteControl.m
index 49aacd4..36f7ffe 100644
--- a/apple_remote/source/RemoteControl.m
+++ b/apple_remote/source/RemoteControl.m
@@ -103,7 +103,6 @@ NSString* kTargetApplicationIdentifier =
@TargetBundleIdentifier;
+ (void) sendDistributedNotification: (NSString*) notificationName
targetBundleIdentifier: (NSString*) targetIdentifier
{
-if ( (self = [super init]) ) {
NSDictionary* userInfo = [NSDictionary dictionaryWithObjectsAndKeys:
[NSString stringWithCString:[self remoteControlDeviceName]
encoding:NSASCIIStringEncoding],
kRemoteControlDeviceName /* key =
RemoteControlDeviceName - OK */,
[[NSBundle mainBundle] bundleIdentifier] /* value
= org.openoffice.script - OK */,
@@ -129,7 +128,6 @@ NSString* kTargetApplicationIdentifier =
@TargetBundleIdentifier;
object:nil
userInfo:userInfo
deliverImmediately:YES];
-}
}
+ (void) sendFinishedNotifcationForAppIdentifier: (NSString*) identifier {
commit 8701f5ef0591bdb7746f19fe94ba27632e983347
Author: Tor Lillqvist t...@iki.fi
Date: Mon May 7 23:57:21 2012 +0300
Add Emacs and vim mode lines
Change-Id: I8ccb7be448faf42904eb6246a4f5a06ff8028ffc
diff --git a/apple_remote/inc/apple_remote/RemoteControl.h
b/apple_remote/inc/apple_remote/RemoteControl.h
index 4476af2..cffc631 100644
--- a/apple_remote/inc/apple_remote/RemoteControl.h
+++ b/apple_remote/inc/apple_remote/RemoteControl.h
@@ -1,3 +1,4 @@
+/* -*- Mode: ObjC; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
*/
/*
* RemoteControl.h
* RemoteControlWrapper
@@ -118,3 +119,5 @@ typedef enum _RemoteControlEventIdentifier {
+ (const char*) remoteControlDeviceName;
@end
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/apple_remote/inc/apple_remote/RemoteMainController.h
b/apple_remote/inc/apple_remote/RemoteMainController.h
index 1674540..4949877 100644
--- a/apple_remote/inc/apple_remote/RemoteMainController.h
+++ b/apple_remote/inc/apple_remote/RemoteMainController.h
@@ -1,3 +1,4 @@
+/* -*- Mode: ObjC; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
*/
/*
* RemoteMainController.h
*
@@ -57,3 +58,5 @@ typedef int NSColorRenderingIntent;
- (MultiClickRemoteBehavior*) remoteBehavior;
@end
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git
[Libreoffice-qa] Impress Documents ODF validation
Hi, due to idea of Mike Schinagl and test results in Migrationsleitfaden des Bundes [1,3], where doubs concerning ODF compatibility of LibO created presentations was mentioned, I want to do a mass test of Presentation documents. Soon a mighty competitor (AOOo) will be back, and we should not show any bareness. For the preparations I created a Wiki Page [2], where you can watch and comment the progress of the efforts. If you have proposals, concerns or anything else you want to tell please discuss on libreoffice-qa@lists.freedesktop.org (here in the thread) or add a hint in the Wiki. We should not test masses of Presentations before preparations will have been finished. Best regards Rainer Bielefeld Hyperlinks: [1] http://www.heise.de/open/meldung/Migrationsleitfaden-des-Bundes-in-neuer-Version-erschienen-1463867.html [2] https://wiki.documentfoundation.org/QA-Projects-Incubator#Check_IMPRESS_ODF_compatibility [3] http://flosmind.wordpress.com/2012/04/16/en-migrationsleifaden-des-bundes/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Impress Documents ODF validation
Rainer Bielefeld wrote: If you have proposals, concerns or anything else you want to tell please discuss on libreoffice-qa@lists.freedesktop.org (here in the thread) or add a hint in the Wiki. Hi Rainer, nice, excellent idea - as for the validators used, may I suggest the following two additional places: http://code.google.com/p/officeotron/ and http://officeshots.org/ (validation is one of many tasks there) , since validators are curious beasts - as ODF is not only RNG-schema, but also normative prose, stuff is sometimes amenable to interpretation. And then there are simple bugs and oversights - so it's best to get some breadth in validator coverage... Cheers, -- Thorsten pgpQ79B0cBrud.pgp Description: PGP signature ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of the LibreOffice QA call 2012-05-04 14:00 UTC
Hi all, here are the minutes of the QA call on 2012-05-04 1400UTC. attendants: Cor, Rainer, Bjoern pending action items: - Update/Create active triagers wiki page (Cor/Rainer) - collect further ideas for spending a dedicated resource (Cor/Rainer) - blocked on CC/Litmus choice availability - MozTrap evaluation install (Bjoern) - write update scenario testcase in Litmus/MozTrap (Kendy) - bulk change remove EasyHacks in summary, make that white board only (Rainer, all) (actually not possible in bulk, so lets crowdsource this: when you come across a bug with EasyHack in title, please remove it there - community building/communication (everyone) - Set Cor up with the Community/Forum maintainers at the distros to better propagate Hackfests, Bug Hunting Sessions etc. RedHat, Debian, Gentoo still missing completed action items: - create updated 3.6 bibisect (Bjoern) bug wrangling (Rainer): - handling needinfo bugs - conclusion: more liberal use of assigned should be ok if in status NEEDINFO (only) AA - send a proposal for liberal assigned use in NEEDINFO to Rainer for review (Bjoern) - change version master to release branch on branch off? see: http://rrbd.wordpress.com/2012/05/03/how-can-we-allow-more-purposeful-queries-for-version-master/ AA - create a QA EasyHack Gather own bugzilla requirements (Bjoern) - create a wikipage with what we have so far and link to it (Rainer) community building/communication (Cor?) - the QA dashboard needs some love - we should identify top-priority action items after each call, those should be done ASAP/to the next call. The are marked AA+ in the minutes (Cor) AA+- blog about QA EasyHacks (Cor/Bjoern) AA+- blog about daily build changes/bugs/features from git log (Cor) - this should happen best once every 1-2 weeks - Rainer looking into this too - if git log messages are unparseable to mere mortals, dont hestitate to email the author about this, this should also encourage good commit messages (Bjoern) - this should also go out to the QA-List and social media - To grow the QA community and get more people to run and test master we should ask people to verify issues once they are marked fixed by dev AA - blog about bug verification (Bjoern) - the goal is not so much to supervise developer fixes, but the side effects like: - more people running master - more people getting involved/started with an easy task on QA - verification is positive/uplifting, while confirming bugs might be more demotivating bibisect for 3.5 release branch and 3.6 master (Bjoern): - no bibisect for 3.5 still (no urgent calls that it is needed yet) - there is a up-to-date 3.6 bibisect up until 2012-04-28 with more than 60 full libreoffice installs based on Ubuntu 12.04 LTS AA - also rebuild the old ~50 3.5 bibisect installs for the next update (Bjoern) - we should grow bibisect knowledge wide and far to get a stable pool of people who can mentor it Next call will be on 2012-05-18 1400UTC. Top priority action item as hinted to me by Cor. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] verification tweets (was: minutes of the LibreOffice QA call 2012-05-04 14:00 UTC)
On Mon, May 07, 2012 at 08:47:24PM +0200, Bjoern Michaelsen wrote: AA - blog about bug verification (Bjoern) I had some additional thoughts on this and think we should make that another QA EasyHack: Twiiter resolved bugs for verification. The task is to set up a some bot that sends a short tweet about each bug being marked as resolved/fixed by development and ask for testing and verifying the fix on master. Target is again growing the QA community and getting more people to run master builds. If there is no violent disagreement about this, I will create such a EasyHack in a few days. We could do the same asking for bug confirmation, but would need check that we are not creating too many of those compared to those asking for verification. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Bug Lifecycle diagram (was: Re: minutes of the LibreOffice QA call 2012-05-04 14:00 UTC)
Hi, On 07.05.2012 20:47, Bjoern Michaelsen wrote: Hi all, here are the minutes of the QA call on 2012-05-04 1400UTC. Thanks. bug wrangling (Rainer): - handling needinfo bugs Question: Do we have a bug lifecylce illustration? For not-so-trained people this can be of real help in understanding QA. I found a generic one at [1], but our friends at AOO do also have a nice one[2] on their QA web[3] which might be worth having a look at ;-) [1] http://www.bugzilla.org/docs/4.2/en/html/lifecycle.html [2] see PDF on http://www.openoffice.org/qa/ooQAReloaded/ooQA-IssueRules.html [3] http://www.openoffice.org/qa/ Regards, Nino - conclusion: more liberal use of assigned should be ok if in status NEEDINFO (only) AA - send a proposal for liberal assigned use in NEEDINFO to Rainer for review (Bjoern) - change version master to release branch on branch off? see: http://rrbd.wordpress.com/2012/05/03/how-can-we-allow-more-purposeful-queries-for-version-master/ AA - create a QA EasyHack Gather own bugzilla requirements (Bjoern) - create a wikipage with what we have so far and link to it (Rainer) community building/communication (Cor?) - the QA dashboard needs some love - we should identify top-priority action items after each call, those should be done ASAP/to the next call. The are marked AA+ in the minutes (Cor) AA+- blog about QA EasyHacks (Cor/Bjoern) AA+- blog about daily build changes/bugs/features from git log (Cor) - this should happen best once every 1-2 weeks - Rainer looking into this too - if git log messages are unparseable to mere mortals, dont hestitate to email the author about this, this should also encourage good commit messages (Bjoern) - this should also go out to the QA-List and social media - To grow the QA community and get more people to run and test master we should ask people to verify issues once they are marked fixed by dev AA - blog about bug verification (Bjoern) - the goal is not so much to supervise developer fixes, but the side effects like: - more people running master - more people getting involved/started with an easy task on QA - verification is positive/uplifting, while confirming bugs might be more demotivating bibisect for 3.5 release branch and 3.6 master (Bjoern): - no bibisect for 3.5 still (no urgent calls that it is needed yet) - there is a up-to-date 3.6 bibisect up until 2012-04-28 with more than 60 full libreoffice installs based on Ubuntu 12.04 LTS AA - also rebuild the old ~50 3.5 bibisect installs for the next update (Bjoern) - we should grow bibisect knowledge wide and far to get a stable pool of people who can mentor it Next call will be on 2012-05-18 1400UTC. Top priority action item as hinted to me by Cor. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 49569] New: [Task]: ODF compatibility issues
https://bugs.freedesktop.org/show_bug.cgi?id=49569 Bug #: 49569 Summary: [Task]: ODF compatibility issues Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other URL: https://wiki.documentfoundation.org/QA-Projects-Incuba tor#Check_IMPRESS_ODF_compatibility OS/Version: All Status: NEW Severity: normal Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de This is the Meta issue to track IMPRESS ODF compatibility issues of LibreOffice 3.5.2 (or later) releases and in 3.6 Master. Details concerning the reasons for this activity you find on linked Wiki Web Page. If anyone wants to list Bug here, please add the Bug ID as dependent Bug here to the Meta Bug in field Depends on. Additionally please cite the Subject line of the Bug. Please check carefully whether the problem has already been reported with a separate Bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49569] [Task]: ODF compatibility issues
https://bugs.freedesktop.org/show_bug.cgi?id=49569 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status Whiteboard||odf_validation CC||LibreOffice@bielefeldundbus ||s.de -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43107] Regular expression \n in replace field inputs \n instead of paragraph break
https://bugs.freedesktop.org/show_bug.cgi?id=43107 Winfried Donkers o...@dci-electronics.nl changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #2 from Winfried Donkers o...@dci-electronics.nl 2012-05-06 23:30:22 PDT --- I think this is a duplicate of bug44398, i.e. isn't this a more general problem than just \n? (behaviour confirmed with version 3.5.3release, details entered in comment with bug 44398) *** This bug has been marked as a duplicate of bug 44398 *** -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49570] New: ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document
https://bugs.freedesktop.org/show_bug.cgi?id=49570 Bug #: 49570 Summary: ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document Classification: Unclassified Product: LibreOffice Version: unspecified Platform: Other URL: http://wiki.documentfoundation.org/images/a/ad/Bergman n-makecheck.odp OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de Created attachment 61116 -- https://bugs.freedesktop.org/attachment.cgi?id=61116 Error Messages of validators Source Document: see URL Validator 1 http://odf-validator.rhcloud.com/ Result: Bergmann-makecheck.odp: Info: ODF version of root document: 1.2 Bergmann-makecheck.odp/META-INF/manifest.xml: Warning: The directory 'Thumbnails/' is not a sub-document and should not be listed in the 'META-INF/manifest.xml' file of ODF package 'Bergmann-makecheck.odp'! Validator 2 http://opendocumentfellowship.com/validator (wrong ODF version for validation?) Valitator 3 none Common error messages: None? Plausibility of Validator error messages: I can not check Other Bug reports for other errors listed in attached report (with reference to this bug) coming soon. Observed with original document (created with 3.3)? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49570] ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document
https://bugs.freedesktop.org/show_bug.cgi?id=49570 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution||WORKSFORME CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-05-06 23:40:38 PDT --- After having saved document from WIN7 LibO 3.5.3 the error has vanished in Validator 1: Bergmann-makecheck_353.odp/META-INF/manifest.xml: Info: no errors, no warnings So WORKSFORME -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49569] [Task]: ODF compatibility issues
https://bugs.freedesktop.org/show_bug.cgi?id=49569 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||49570 --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-05-06 23:41:49 PDT --- Add: Bug 49570 - ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49570] ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document
https://bugs.freedesktop.org/show_bug.cgi?id=49570 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Blocks||49569 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49570] ODF Compatibility - manifest.xml: Warning - The directory 'Thumbnails/' is not a sub-document
https://bugs.freedesktop.org/show_bug.cgi?id=49570 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status Whiteboard||odf_validation -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43107] Regular expression \n in replace field inputs \n instead of paragraph break
https://bugs.freedesktop.org/show_bug.cgi?id=43107 Christopher M. Penalver christopher.penal...@gmx.com changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE | --- Comment #3 from Christopher M. Penalver christopher.penal...@gmx.com 2012-05-06 23:51:50 UTC --- Winfried Donkers, I do not agree with this being a duplicate of bug 44398, nor do I agree with bug 44398 being accepted as a valid report for that matter based on the title. Many, purposefully or ignorantly, make wide-scoped fix everything about a feature set reports, as 44398's title is, and your subsequent comment https://bugs.freedesktop.org/show_bug.cgi?id=44398#c2 . This makes a report less likely to be resolved quickly. However, this (43107) report is targeted, specific, and detailed. Please do not toggle this report further unless you are submitting a patch. Thank you. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49561] Impress: Font settings for the Footer are not being saved.
https://bugs.freedesktop.org/show_bug.cgi?id=49561 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO CC||jbf.fa...@orange.fr Ever Confirmed|0 |1 --- Comment #2 from Jean-Baptiste Faure jbf.fa...@orange.fr 2012-05-06 23:55:03 PDT --- (In reply to comment #1) Workaround: If you save it into .opd format, it seems to keep it settings. So you saved your slideshow in MS-Powerpoint format ? Which kind ? ppt or pptx ? Please attach a document showing the problem. Best regards. JBF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47134] New arrow style symbol is not correct.
https://bugs.freedesktop.org/show_bug.cgi?id=47134 --- Comment #2 from Jan spacen...@nurfuerspam.de 2012-05-07 00:03:26 PDT --- @Akira: You have to reset/delete your LO config folder. It worked for me afterwards. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44991] FILEOPEN: [docx] Open MS_Word document ends in LO3.4 has stopped working
https://bugs.freedesktop.org/show_bug.cgi?id=44991 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added CC||jbf.fa...@orange.fr --- Comment #4 from Jean-Baptiste Faure jbf.fa...@orange.fr 2012-05-07 00:17:09 PDT --- (In reply to comment #3) anyone able to reproduce this bug under Linux ? Works beautifully for me with 3-5 Not me :-) No crash with LO 3.4.5 (Ubuntu version, opened by double-click in the file manager), LO 3.4.6, LO 3.5.3.2 and current master (Build ID: e35b1d8), opened from LO File menu or by dragging it from file manager into the startcenter. Ubuntu 11.10 x86_64 gnome-shell. Best regards. JBF -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41567] LibreOffice hung twice when I tried to make changes to a file in 2007 Word XML format
https://bugs.freedesktop.org/show_bug.cgi?id=41567 --- Comment #4 from goldf...@aol.in 2012-05-07 00:46:05 PDT --- @Roman I do not want to try and reproduce the bug now introduce confounding factors. This is because: I have changed the version of my OS (clean install to Ubuntu 12.04) made several changes unique to my system for example the Global Menu bar for LO in this latest Ubuntu have also activated quick-starter. I feel the Global Menu bar for LO in this latest Ubuntu makes LO very slow to start it causes it to crash very often. In fact, after this Global Menu bar of LO installation, even the Print Preview causes LO to crash now. Fortunately, the recovery is perfect as far as data-recovery but annoying time-consuming sometimes breaks the rhythm of the work flow. Therefore, I do not want to reproduce the bug now as I may confuse the issue with the bug of Global Menu for LO. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39586] [FILEOPEN] Writer crashes or hangs when try to open .docx file
https://bugs.freedesktop.org/show_bug.cgi?id=39586 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #12 from Caolán McNamara caol...@redhat.com 2012-05-07 00:46:29 PDT --- Seems to be fixed in 3.5/master. No output under valgrind either. re, sasha's findings. I can reproduce an effect under a --enable-debug+--enable-dbgutil build of massively slowness and debugging spew, but that's a side-effect of slowly checking the table consistency over and over and over again during import which doesn't happen during a non debugging build. If anyone can get it to crash in 3-5/master feel free to reopen again -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 40579] FILEOPEN Crash opening docx file
https://bugs.freedesktop.org/show_bug.cgi?id=40579 Bug 40579 depends on bug 39586, which changed state. Bug 39586 Summary: [FILEOPEN] Writer crashes or hangs when try to open .docx file https://bugs.freedesktop.org/show_bug.cgi?id=39586 What|Old Value |New Value Status|NEEDINFO|NEW Resolution||FIXED Status|NEW |RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 43866] FILESAVE/FILEOPEN: Wrong bullet symbol in lists after .doc/.docx file export/import
https://bugs.freedesktop.org/show_bug.cgi?id=43866 Roman Eisele b...@eikota.de changed: What|Removed |Added Summary|Regression: Writer doc |FILESAVE/FILEOPEN: Wrong |export wrong bullet |bullet symbol in lists ||after .doc/.docx file ||export/import --- Comment #6 from Roman Eisele b...@eikota.de 2012-05-07 00:47:57 PDT --- Still reproducible with LibreOffice 3.5.3.2. Updated Summary according to comment #5 and own experience: -- not a regression -- FILESAVE and/or FILEOPEN is affected -- not only .doc, also .docx affected. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49571] New: ODF Compatibility - styles.xml Error: unexpected attribute text:enable-numbering
https://bugs.freedesktop.org/show_bug.cgi?id=49571 Bug #: 49571 Summary: ODF Compatibility - styles.xml Error: unexpected attribute text:enable-numbering Classification: Unclassified Product: LibreOffice Version: LibO Master Platform: Other URL: http://wiki.documentfoundation.org/images/a/ad/Bergman n-makecheck.odp OS/Version: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Presentation AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de Steps how to reproduce with parallel installation of Master LOdev 3.6.0alpha0+ – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 35ec153] (tinderbox: Win-x86@6-fast, pull time 2012-05-02 06:53:41) 1. download Sample document from URL 2. Open with LibO and save under new with enabled Menu 'Tools - Options - Load/Save - General - ODF Format Version = 1.2 Extended' 3. Start Validator http://odf-validator.rhcloud.com/ and validate document with Autodetct for ODF version. Expected: compatible Actual: Bergmann-makecheck_360.odp/styles.xml[2,72857]: Error: unexpected attribute text:enable-numbering Bergmann-makecheck_360.odp/content.xml[2,6376]: Error: unexpected attribute text:enable-numbering Plausibility of Validator error messages: I can not check -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49569] [Task]: ODF compatibility issues
https://bugs.freedesktop.org/show_bug.cgi?id=49569 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||49571 --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-05-07 01:08:06 PDT --- Add: Bug 49571 - ODF Compatibility - styles.xml Error: unexpected attribute text:enable-numbering -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49571] ODF Compatibility - styles.xml Error: unexpected attribute text:enable-numbering
https://bugs.freedesktop.org/show_bug.cgi?id=49571 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Blocks||49569 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47511] PDF: Writer: exporting a document as pdf file will crash Writer.
https://bugs.freedesktop.org/show_bug.cgi?id=47511 --- Comment #26 from Michael Stahl mst...@redhat.com 2012-05-07 01:44:59 PDT --- (In reply to comment #22) 00a8a93c 6ddd5d0c 00a8ab44 4f0f20e5 0001 vcllo!WorkWindow::IsMaximized+0x3e6e0 ^^^ the 0x3e6e0 offset looks unrealistically large to me, probably the stack trace is wrong, some missing symbols... 00a8aacc 6ddd5736 0ed73a18 00a8ab44 4f0f2199 vcllo!OutputDevice::ImplGlyphFallbackLayout+0x2cc looks the most suspicious to me. There shouldn't be any way ImplGlyphFallbackLayout calls WorkWindow::IsMaximized so the problem might be in there. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 39833] Add Support assistive technology tools option to installation process [accessibility]
https://bugs.freedesktop.org/show_bug.cgi?id=39833 Andras Timar tima...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|libreoffice-b...@lists.free |tima...@gmail.com |desktop.org | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49572] New: FORMATTING: missing grid on specific cells
https://bugs.freedesktop.org/show_bug.cgi?id=49572 Bug #: 49572 Summary: FORMATTING: missing grid on specific cells Classification: Unclassified Product: LibreOffice Version: LibO 3.5.3 release Platform: x86 (IA32) OS/Version: Windows (All) Status: UNCONFIRMED Severity: critical Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: faxio...@virgilio.it Created attachment 61117 -- https://bugs.freedesktop.org/attachment.cgi?id=61117 screen print showing the bug When opening .xlsx files the empty cells don't show the cell's graphic limits and appear completely blank, the cells with a number 10 inside lose their format and color -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 47648] [EasyHack] Create VirtualBox for bibisecting
https://bugs.freedesktop.org/show_bug.cgi?id=47648 Korrawit Pruegsanusak detective.conan.1...@gmail.com changed: What|Removed |Added AssignedTo|el...@layerjet.com |detective.conan.1412@gmail. ||com --- Comment #3 from Korrawit Pruegsanusak detective.conan.1...@gmail.com 2012-05-07 01:56:47 PDT --- From http://wiki.documentfoundation.org/Development/Easy_Hacks : If a task has an owner without an update in a week, feel free to notify them that you're taking that on yourself ... So, I'm taking this :) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49431] Extensioname: PDF import has incompatibility problems with PDF format
https://bugs.freedesktop.org/show_bug.cgi?id=49431 --- Comment #4 from Frank frank.breitl...@gmx.de 2012-05-07 01:57:16 UTC --- I also reported it here: https://issues.apache.org/ooo/show_bug.cgi?id=119312 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49573] New: FORMATTING: FORMATTING. XLXS: empty cell have missing borders; missing color on some
https://bugs.freedesktop.org/show_bug.cgi?id=49573 Bug #: 49573 Summary: FORMATTING: FORMATTING. XLXS: empty cell have missing borders; missing color on some Classification: Unclassified Product: LibreOffice Version: LibO 3.5.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: faxio...@virgilio.it Created attachment 61118 -- https://bugs.freedesktop.org/attachment.cgi?id=61118 screen print showing how the sheet appears when loading xlxs Problem description: when opening an XLXS file , the empty cell have missing borders; missing color on some specific cells Expected behavior: correct color, correct displaying of the cells' borders with empty cells Platform (if different from the browser): Browser: Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Win64; x64; Trident/5.0; .NET CLR 2.0.50727; SLCC2; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44026] MAILMERGE: Writer crashes after sending the first out of four mass mails
https://bugs.freedesktop.org/show_bug.cgi?id=44026 --- Comment #7 from sasha.libreoff...@gmail.com 2012-05-07 02:09:30 PDT --- @ h8...@t-online.de Thanks for additional testing and additional information I have some questions: It reproducible in another computer? It reproducible on another OS if available? In another desktop (Gnome,Xfce)? Which JRE used and what if use another (Open, Oracle)? read(10, #!/bin/sh\n/usr/lib/libreoffice/p..., 8192) = 53 What for file mentioned? May be there is some interesting. What if move Libreoffice to another place? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42346] EDITING: Cross-references (numbered paragraph) in .doc file are lost
https://bugs.freedesktop.org/show_bug.cgi?id=42346 Josef josef.dalco...@gmx.net changed: What|Removed |Added Platform|Other |All Severity|normal |major Priority|medium |high Version|LibO 3.4.3 release |LibO 3.5.3 release --- Comment #3 from Josef josef.dalco...@gmx.net 2012-05-07 02:29:45 PDT --- Correction: when saving a file with a cross-reference, the cross references turn into plain text, but are no longer real links. This means, after saving the document in .doc or .docx the cross-references are broken. I am having trouble to upload an example, but it is easy to reproduce: Open an new .odt document. Add a table. Add a caption to the table. Insert a cross reference to the caption of the table. Save the file as .odt Save the file as MS-Word document (.doc) now close Openoffice and open the .doc file: the cross-reference no longer has a grey background - it is plain text now! For comparison, the cross-reference works properly in the saved .odt file. The same happens with cross-references to figures as well. I marked this with importance high and major, since it is really a show-stopper when trying to exchange any larger document with MS-Office users. Any larger document has at least tenth of cross-references and there is no way to export them properly. Since we cannot force our customers to use Libreoffice, we had to switch back to using MS-Word because of this bug. Tested on Ubuntu 10.04, Debian stable, Windows(In reply to comment #2) Thanks for bugreport in 3.3.4 and 3.5.2 on Fedora 64 bit not reproducible for me Please, verify if in last version of LibreOffice still reproducible Please, attach odt that demonstrates this problem when saved to doc (In reply to comment #2) Thanks for bugreport in 3.3.4 and 3.5.2 on Fedora 64 bit not reproducible for me Please, verify if in last version of LibreOffice still reproducible Please, attach odt that demonstrates this problem when saved to doc -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42346] EDITING: Cross-references (numbered paragraph) in .doc file are lost
https://bugs.freedesktop.org/show_bug.cgi?id=42346 --- Comment #4 from Josef josef.dalco...@gmx.net 2012-05-07 02:33:56 PDT --- Created attachment 61119 -- https://bugs.freedesktop.org/attachment.cgi?id=61119 cross-reference test the attached file shows the behavior: save the file in MS-Word format (.doc or .docx): the reference Table 1 is just plain text in the MS-Word document, no longer a link (e.g. if you insert another table above this one, the reference remains Table 1 instead of becoming Table 2. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42899] Macro changes not saved on document Close/Save
https://bugs.freedesktop.org/show_bug.cgi?id=42899 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All OS/Version|Windows (All) |All --- Comment #6 from sasha.libreoff...@gmail.com 2012-05-07 02:36:59 PDT --- In link in description mentioned Linux and Ubuntu. I reproduced something like it on Fedora 64 bit, but last time not tested. Changing again to All -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49291] CRASH at menu Tools - Macros
https://bugs.freedesktop.org/show_bug.cgi?id=49291 --- Comment #4 from pz1 p...@xs4all.nl 2012-05-07 02:40:59 PDT --- (In reply to comment #3) I can confirm that this is happening with last night's build on both WinXP and Win7. In both cases I observe that in the Option-Java setting the JRE is not recognised. Maybe causal relation? On both machines LO 3.5.3 has no problems. Forgot to mention that the JRE issue has been reported under 48946 and 49275 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49575] New: Writer FILESAVE: validation of odt not passed, unexpected attribute style:layout-grid-snap-to-characters
https://bugs.freedesktop.org/show_bug.cgi?id=49575 Bug #: 49575 Summary: Writer FILESAVE: validation of odt not passed, unexpected attribute style:layout-grid-snap-to-characters Classification: Unclassified Product: LibreOffice Version: LibO 3.5.3 release Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: sasha.libreoff...@gmail.com Created attachment 61123 -- https://bugs.freedesktop.org/attachment.cgi?id=61123 test case, produced in 3.5.3 validation not passed on http://odf-validator.rhcloud.com/ used Writer 3.5.3 on Fedora 64 bit error is: changes-3-5-3.odt/styles.xml[109,707]: Error: unexpected attribute style:layout-grid-snap-to-characters -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49575] Writer FILESAVE: validation of odt not passed, unexpected attribute style:layout-grid-snap-to-characters
https://bugs.freedesktop.org/show_bug.cgi?id=49575 sasha.libreoff...@gmail.com changed: What|Removed |Added Status Whiteboard||odf odf_validation CC||sasha.libreoff...@gmail.com -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44991] FILEOPEN: [docx] Open MS_Word document ends in LO3.4 has stopped working
https://bugs.freedesktop.org/show_bug.cgi?id=44991 --- Comment #5 from s-joyemuseq...@vf.uni-konstanz.de 2012-05-07 03:27:50 PDT --- Retested with LibO 3.5.3 on Windows XP. It works for me. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49555] EDITING: improve access to contents in Frames with wrap=through and in background option
https://bugs.freedesktop.org/show_bug.cgi?id=49555 --- Comment #3 from Saverio saveb...@gmail.com 2012-05-07 03:28:52 PDT --- I'm not sure about that, since I encountered no problems, with the same file, with LibO 3.4.3 of my previous Ubuntu 11.10 distribution. (In reply to comment #2) Same for me with LibO 3.3.3 and OOo 3.3, so I believe current behavior is inherited from OOo. @Reporter: what solution do you expect? Can you try to help to check for DUPLICATES? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
