[Libreoffice-commits] .: binfilter/bf_sch binfilter/bf_sd binfilter/bf_svx
binfilter/bf_sch/source/ui/docshell/makefile.mk |5 - binfilter/bf_sch/util/sch_sch.cxx | 29 --- binfilter/bf_sd/util/sd_sd.cxx | 29 --- binfilter/bf_svx/util/svx_svxpch.cxx| 63 4 files changed, 1 insertion(+), 125 deletions(-) New commits: commit e4812b0d9ce2527bd3fe314010e540f6411539b3 Author: Thomas Arnhold tho...@arnhold.org Date: Thu Jun 28 12:36:35 2012 +0200 Remove PCH traces Change-Id: I2c39feaaab0b41af107a22baeaab48713539 diff --git a/binfilter/bf_sch/source/ui/docshell/makefile.mk b/binfilter/bf_sch/source/ui/docshell/makefile.mk index 936e17e..c2fecb4 100644 --- a/binfilter/bf_sch/source/ui/docshell/makefile.mk +++ b/binfilter/bf_sch/source/ui/docshell/makefile.mk @@ -34,12 +34,9 @@ INC+= -I$(PRJ)$/inc$/bf_sch # --- Files -CXXFILES = $(BFPRJ)$/util$/sch_sch.cxx \ -sch_docshell.cxx \ -sch_docshel1.cxx +CXXFILES = $(BFPRJ)$/util$/sch_docshel1.cxx SLOFILES = \ -$(SLO)$/sch_docshell.obj \ $(SLO)$/sch_docshel1.obj diff --git a/binfilter/bf_sch/util/sch_sch.cxx b/binfilter/bf_sch/util/sch_sch.cxx deleted file mode 100644 index 4ba1e5c..000 --- a/binfilter/bf_sch/util/sch_sch.cxx +++ /dev/null @@ -1,29 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the License); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -#include sv.hxx -#include svtool.hxx -#include sfx.hxx -#include sfxitems.hxx -#include sfxdoc.hxx -#include sfxdlg.hxx -namespace binfilter { -#include svdraw.hxx -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/binfilter/bf_sd/util/sd_sd.cxx b/binfilter/bf_sd/util/sd_sd.cxx deleted file mode 100644 index 4ba1e5c..000 --- a/binfilter/bf_sd/util/sd_sd.cxx +++ /dev/null @@ -1,29 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the License); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -#include sv.hxx -#include svtool.hxx -#include sfx.hxx -#include sfxitems.hxx -#include sfxdoc.hxx -#include sfxdlg.hxx -namespace binfilter { -#include svdraw.hxx -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/binfilter/bf_svx/util/svx_svxpch.cxx b/binfilter/bf_svx/util/svx_svxpch.cxx deleted file mode 100644 index bdfdf0f..000 --- a/binfilter/bf_svx/util/svx_svxpch.cxx +++ /dev/null @@ -1,63 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the License); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -#include thread.hxx -#include
[Libreoffice-commits] .: sd/source
sd/source/ui/view/drviewsa.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit bb7f52e9fc4fc692f14d76aee6e0a141ad864a3b Author: Ivan Timofeev timofeev@gmail.com Date: Fri Jun 29 11:29:24 2012 +0400 fdo#51543: fix incomplete slide number info in status bar Change-Id: I73cdd236a9e167fb812b0e2c0922df5bd3e2537b diff --git a/sd/source/ui/view/drviewsa.cxx b/sd/source/ui/view/drviewsa.cxx index d99fd9b..22464d2 100644 --- a/sd/source/ui/view/drviewsa.cxx +++ b/sd/source/ui/view/drviewsa.cxx @@ -748,9 +748,9 @@ void DrawViewShell::GetStatusBarState(SfxItemSet rSet) // Allways show the slide/page number. OUString aOUString = SD_RESSTR(STR_SD_PAGE); aOUString += ; -aOUString += OUString::valueOf( maTabControl.GetCurPageId() ); +aOUString += OUString::valueOf( sal_Int32(maTabControl.GetCurPageId()) ); aOUString += / ; -aOUString += OUString::valueOf( GetDoc()-GetSdPageCount( mePageKind ) ); +aOUString += OUString::valueOf( sal_Int32(GetDoc()-GetSdPageCount(mePageKind)) ); // If in layer mode additionally show the layer that contains all // selected shapes of the page. If the shapes are distributed on ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sd/source
sd/source/ui/view/drviewsa.cxx |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) New commits: commit ca4e735794a824ba34f372431659f7757be1971b Author: Ivan Timofeev timofeev@gmail.com Date: Fri Jun 29 11:29:24 2012 +0400 fdo#51543: fix incomplete slide number info in status bar Change-Id: I73cdd236a9e167fb812b0e2c0922df5bd3e2537b (cherry picked from commit bb7f52e9fc4fc692f14d76aee6e0a141ad864a3b) diff --git a/sd/source/ui/view/drviewsa.cxx b/sd/source/ui/view/drviewsa.cxx index 56ee97a..eac7b28 100644 --- a/sd/source/ui/view/drviewsa.cxx +++ b/sd/source/ui/view/drviewsa.cxx @@ -748,9 +748,9 @@ void DrawViewShell::GetStatusBarState(SfxItemSet rSet) // Allways show the slide/page number. OUString aOUString = SD_RESSTR(STR_SD_PAGE); aOUString += ; -aOUString += OUString::valueOf( maTabControl.GetCurPageId() ); +aOUString += OUString::valueOf( sal_Int32(maTabControl.GetCurPageId()) ); aOUString += / ; -aOUString += OUString::valueOf( GetDoc()-GetSdPageCount( mePageKind ) ); +aOUString += OUString::valueOf( sal_Int32(GetDoc()-GetSdPageCount(mePageKind)) ); // If in layer mode additionally show the layer that contains all // selected shapes of the page. If the shapes are distributed on ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: mysqlc/source
mysqlc/source/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit d817891d69602d9877ac46131c6e123b99376802 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Jun 29 09:38:16 2012 +0200 Export the UNO symbols from mysqlc.uno.dll Change-Id: I528acab43cad3abc88d1a20f0f19f42d652262dd diff --git a/mysqlc/source/makefile.mk b/mysqlc/source/makefile.mk index 8f8eb40..c36e836 100644 --- a/mysqlc/source/makefile.mk +++ b/mysqlc/source/makefile.mk @@ -164,11 +164,11 @@ SHL1STDLIBS= \ $(SALHELPERLIB) \ $(CPPUHELPERLIB) -SHL1USE_EXPORTS = name SHL1LIBS= $(LIB1TARGET) SHL1DEF= $(MISC)$/$(SHL1TARGET).def SHL1RPATH=OXT DEF1NAME= $(SHL1TARGET) +DEF1EXPORTFILE=exports.dxp # create Extension - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - mysqlc/source
mysqlc/source/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit a64ea3c1ab202f5941f1bbe803f8673ec81a221f Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Jun 29 09:38:16 2012 +0200 Export the UNO symbols from mysqlc.uno.dll Change-Id: I528acab43cad3abc88d1a20f0f19f42d652262dd Signed-off-by: Fridrich Å trba fridrich.st...@bluewin.ch diff --git a/mysqlc/source/makefile.mk b/mysqlc/source/makefile.mk index 8f8eb40..c36e836 100644 --- a/mysqlc/source/makefile.mk +++ b/mysqlc/source/makefile.mk @@ -164,11 +164,11 @@ SHL1STDLIBS= \ $(SALHELPERLIB) \ $(CPPUHELPERLIB) -SHL1USE_EXPORTS = name SHL1LIBS= $(LIB1TARGET) SHL1DEF= $(MISC)$/$(SHL1TARGET).def SHL1RPATH=OXT DEF1NAME= $(SHL1TARGET) +DEF1EXPORTFILE=exports.dxp # create Extension - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - 3 commits - sw/source
sw/source/core/layout/paintfrm.cxx | 71 ++--- 1 file changed, 43 insertions(+), 28 deletions(-) New commits: commit 3d0d2611b5a2e735fc325e769f8de90e5e0518a2 Author: Michael Stahl mst...@redhat.com Date: Wed Jun 27 23:10:00 2012 +0200 fdo#39415: sw: fix vertical collapsing border painting: For borders in vertically oriented text it's necessary to correct positions at different sides, i.e., right and left instead of top and bottom; refactor SwTabFrmPainter::Insert some more to handle this properly. Change-Id: If20b9477415e9bd12e63aab4eed2f070065eb473 (cherry picked from commit d0bbbfdef6b31650a351883de09b5338562048a2) diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx index 5a78bfc..0bcf3fa 100755 --- a/sw/source/core/layout/paintfrm.cxx +++ b/sw/source/core/layout/paintfrm.cxx @@ -2717,42 +2717,44 @@ void SwTabFrmPainter::Insert( const SwFrm rFrm, const SvxBoxItem rBoxItem ) bool const bBottomAsTop(lcl_IsFirstRowInFollowTableWithoutRepeatedHeadlines( mrTabFrm, rFrm, rBoxItem)); - -// these are positions of the lines -const SwTwips nLeft = aBorderRect._Left(); -const SwTwips nRight = aBorderRect._Right(); -const SwTwips nTop= aBorderRect._Top(); -const SwTwips nBottom = aBorderRect._Bottom(); +bool const bVert = mrTabFrm.IsVertical(); +bool const bR2L = mrTabFrm.IsRightToLeft(); svx::frame::Style aL( rBoxItem.GetLeft() ); svx::frame::Style aR( rBoxItem.GetRight() ); svx::frame::Style aT( rBoxItem.GetTop() ); svx::frame::Style aB( rBoxItem.GetBottom() ); +aR.MirrorSelf(); +aB.MirrorSelf(); + const SwTwips nHalfBottomWidth = aB.GetWidth() / 2; const SwTwips nHalfTopWidth = (bBottomAsTop) ? nHalfBottomWidth : aT.GetWidth() / 2; -aR.MirrorSelf(); -aB.MirrorSelf(); - -bool bVert = mrTabFrm.IsVertical(); -bool bR2L = mrTabFrm.IsRightToLeft(); +// these are positions of the lines +const SwTwips nLeft = +aBorderRect._Left() - ((bVert) ? nHalfBottomWidth : 0); +const SwTwips nRight = +aBorderRect._Right() - ((bVert) ? nHalfTopWidth : 0); +const SwTwips nTop= +aBorderRect._Top() + ((bVert) ? 0 : nHalfTopWidth); +const SwTwips nBottom = +aBorderRect._Bottom()+ ((bVert) ? 0 : nHalfBottomWidth); aL.SetRefMode( svx::frame::REFMODE_CENTERED ); aR.SetRefMode( svx::frame::REFMODE_CENTERED ); aT.SetRefMode( !bVert ? svx::frame::REFMODE_BEGIN : svx::frame::REFMODE_END ); aB.SetRefMode( !bVert ? svx::frame::REFMODE_BEGIN : svx::frame::REFMODE_END ); -SwLineEntry aLeft ( nLeft, nTop + nHalfTopWidth, -nBottom + nHalfBottomWidth, bVert ? aB : ( bR2L ? aR : aL ) ); -SwLineEntry aRight ( nRight, nTop + nHalfTopWidth, -nBottom + nHalfBottomWidth, -bVert ? ((bBottomAsTop) ? aB : aT) : ( bR2L ? aL : aR ) ); -SwLineEntry aTop ( nTop + nHalfTopWidth, -nLeft, nRight, bVert ? aL : ((bBottomAsTop) ? aB : aT) ); -SwLineEntry aBottom( nBottom + nHalfBottomWidth, -nLeft, nRight, bVert ? aR : aB ); +SwLineEntry aLeft (nLeft, nTop, nBottom, +(bVert) ? aB : ((bR2L) ? aR : aL)); +SwLineEntry aRight (nRight, nTop, nBottom, +(bVert) ? ((bBottomAsTop) ? aB : aT) : ((bR2L) ? aL : aR)); +SwLineEntry aTop (nTop,nLeft, nRight, +(bVert) ? aL : ((bBottomAsTop) ? aB : aT)); +SwLineEntry aBottom(nBottom, nLeft, nRight, +(bVert) ? aR : aB); Insert( aLeft, false ); Insert( aRight, false ); commit bac0e1fccde840f6ec2265c0198648ae6927781d Author: Michael Stahl mst...@redhat.com Date: Wed Jun 27 20:51:24 2012 +0200 fdo#39415: sw: fix collapsing border painting more: There is a special case for i#9860, which is for first line in follow table (i.e. continued on new page) without repeated headlines: Here the bottom border of the cell is used as the top border in case the cell does not have a top border; this is fixed now with a bit of refactoring, so the correct half width adjustment can be made. Change-Id: I58ef81b7e13544014ef75973ea793f673a242488 (cherry picked from commit 3a4b7c3555f2ffb4e89502bb04ff063d8c08f628) diff --git a/sw/source/core/layout/paintfrm.cxx b/sw/source/core/layout/paintfrm.cxx index d851cf0..5a78bfc 100755 --- a/sw/source/core/layout/paintfrm.cxx +++ b/sw/source/core/layout/paintfrm.cxx @@ -2682,6 +2682,24 @@ void SwTabFrmPainter::FindStylesForLine( const Point rStartPoint, } } +// special case: #i9860# +// first line in follow table without repeated headlines +static bool lcl_IsFirstRowInFollowTableWithoutRepeatedHeadlines( +SwTabFrm const rTabFrm, SwFrm const rFrm, SvxBoxItem const rBoxItem) +{ +
Re: Window background (was: Re: [ANN] LibreOffice 3.6.0.0 beta2 available for testing)
Hi Kendy, Astron Sorry, but you do not see another feature, which I think is a mistake. The new rulers have no boundary lines in black. Now, the cursor can be on the ruler, and the user does not understand this. (Please look carefully 2nd GIF-file http://nabble.documentfoundation.org/file/n3991801/note_3.gif). Thanks a lot, ape -- View this message in context: http://nabble.documentfoundation.org/Window-background-was-Re-ANN-LibreOffice-3-6-0-0-beta2-available-for-testing-tp3992631p3992795.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED][3-5] fdo#39415 Writer collapsing table border painting fixes
On Thu, Jun 28, 2012 at 02:59:46PM +0200, Michael Stahl mst...@redhat.com wrote: hi all, to fix this LO 3.4 regression i've committed 3 patches, which should be applied to libreoffice-3-5. i've just pushed these to gerrit, which has strangely resulted in 3 reviews instead of the expected one, but you can look at these here: https://gerrit.libreoffice.org/239 https://gerrit.libreoffice.org/240 https://gerrit.libreoffice.org/241 Pushed now, thanks. the thing i don't understand is how you would add sign-offs to these before pushing them, but i haven't actually pushed a gerrit patch yet so probably i don't understand it yet :) As far as I understand, you need to do git commit --amend -s manually or so -- when gerrit will be the main repo, then just the review will be enough (without manual push) and gerrit will automatically add the signed-off-by. Anyway, this is the first time I tried to use logerrit review, and I found 3 issues. The generated commandline should be like: ssh logerrit gerrit review -m \looks good\ --verified=+1 --code-review=2 1080c131c0c512a9d5273e860a48af13667bc9e8 But logerrit: - prints instead of \ - uses codereview insead of code-review (who tested this? ;) ) - tries to use the changeid instead of the sha1 of the commit The first two is trivial and I fixed it, the last one is something I'm not sure about - Norbert/Björn, care to have a look? The error message is: fatal: I7605eda6ef8111612ceb1ded79c0811de9ca7b25 is not a valid patch set Just getting the sha1 from FETCH_HEAD is what I did manually for now, but that's not a solution - if I gerrit-cherry-pick two independent patches, then I have no idea how to get the original sha1 for the first one, unless we make gerrit-cherry-pick use git cherry-pick -x. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: logerrit
logerrit | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) New commits: commit 616ad0b94ca3f20080d19595b6a69a2a6969 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jun 29 09:59:14 2012 +0200 logerrit review: fix missing escaping, codereview - code-review Change-Id: Icf5facbb59cba2116ae3fc6bdfc035673cf47985 diff --git a/logerrit b/logerrit index 52be193..851af7d 100755 --- a/logerrit +++ b/logerrit @@ -127,13 +127,13 @@ case $1 in ask_tristate $CODEREVIEW case $ANSWER in y) - CODEREVIEWFLAG=--codereview=2 + CODEREVIEWFLAG=--code-review=2 ;; n) - CODEREVIEWFLAG=--codereview=1 + CODEREVIEWFLAG=--code-review=1 ;; *) - CODEREVIEWFLAG=--codereview=1 + CODEREVIEWFLAG=--code-review=1 ;; esac ;; @@ -142,15 +142,15 @@ case $1 in ask_tristate $CODEREVIEW case $ANSWER in y) - CODEREVIEWFLAG=--codereview=-1 + CODEREVIEWFLAG=--code-review=-1 MESSAGEREQ=$MESSAGEREQ and explain why you have reservations about the code ;; n) - CODEREVIEWFLAG=--codereview=-2 + CODEREVIEWFLAG=--code-review=-2 MESSAGEREQ=$MESSAGEREQ and explain why you want to block this ;; *) - CODEREVIEWFLAG=--codereview=-1 + CODEREVIEWFLAG=--code-review=-1 MESSAGEREQ=$MESSAGEREQ and explain why you have reservations about the code ;; esac @@ -159,7 +159,7 @@ case $1 in ;; esac read -p please type a friendly comment$MESSAGEREQ: MESSAGE - echo ssh ${GERRITHOST?} gerrit review -m \$MESSAGE\ $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID + echo ssh ${GERRITHOST?} gerrit review -m '\'$MESSAGE'\' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID ;; checkout) get_SHA_for_change $2 ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 50964, which changed state. Bug 50964 Summary: PresenterConsole - missing all images... https://bugs.freedesktop.org/show_bug.cgi?id=50964 What|Old Value |New Value Resolution|FIXED | Status|RESOLVED|REOPENED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Jean-Baptiste Faure jbf.fa...@orange.fr changed: What|Removed |Added Depends on||51547 --- Comment #32 from Jean-Baptiste Faure jbf.fa...@orange.fr 2012-06-29 01:37:16 UTC --- Add bug 51547 : make Presenter screen unusable. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - mysqlc/source
mysqlc/source/makefile.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 18b47395284d0453d8946d84a2c3cfd2e46eaaa0 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Fri Jun 29 09:38:16 2012 +0200 Export the UNO symbols from mysqlc.uno.dll Change-Id: I528acab43cad3abc88d1a20f0f19f42d652262dd Signed-off-by: Petr Mladek pmla...@suse.cz diff --git a/mysqlc/source/makefile.mk b/mysqlc/source/makefile.mk index 97207ff..0b89339 100644 --- a/mysqlc/source/makefile.mk +++ b/mysqlc/source/makefile.mk @@ -164,11 +164,11 @@ SHL1STDLIBS= \ $(SALHELPERLIB) \ $(CPPUHELPERLIB) -SHL1USE_EXPORTS = name SHL1LIBS= $(LIB1TARGET) SHL1DEF= $(MISC)$/$(SHL1TARGET).def SHL1RPATH=OXT DEF1NAME= $(SHL1TARGET) +DEF1EXPORTFILE=exports.dxp # create Extension - ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
minutes of ESC call ...
* Present: + Eike, Astron, Markus, Rainer, Michael, Kendy, Bjoern, Michael Stahl, Caolan, David, Cedric, Andras, Petr, Lionel * Completed Action Items + icons: poke Mango authors (Michael) + revert 3.6 to opaque background on Win7 (Kendy) * Pending Action Items + [pending] merge the new pretty templates in place of the old ugly ones (Michael S) + new problems shown up with this - + Caolan has tool for templates to strip lang tags so it works + try template lang tag stripping tool + need to fix merge for Beta3 + check new templates are using auto-fitting functionality (Thorsten) + notify all committers when we have a nice simple, minimal statement of what is required for gerrit written (Bjoern) * Ongoing Action Items: + https://gerrit.libreoffice.org/ - click 'register' (All hackers) + then poke Norbert by E-mail to get yourself setup a commiter / reviewer + the E-mail used for openID registration and user-account on is needed (cf. core/.git/config) * GSOC update (Cedric) + mid term evaluations arriving soon - start thinking about what to put + face-to-face mentor meeting in Berlin + submit a private GSOC mentors' BoF @ conference * Release Engineering update (Petr) + 3.5.5 status - RC2 + currently being pushed to mirrors; on-track + not aware of any blockers = final. + 3.5.6 planned for September: 2 months away - a lot ? + do another in August between 3.6.0 and 3.6.1 ? AI: + add to schedule (Petr) + 3.6 / Beta 3 + deadline Monday for final string / late-feature freeze + Beta 3 issue: template blocking - Michael S kindly took it. + last beta before 3x release candidates + commit bug fixes without review, until RC1 + then one extra review from RC1 * UI / design update (Astron) + splash screen + start-center + have a google+ vote on which one is best shortly. + get it included over the weekend + official TDF artwork handed around in a tar-ball AA: + mail the winning image to Thorsten (Astron) + Win7 glass foo reverted by popular request + templates as above + killing options: + nice research in: + http://wiki.documentfoundation.org/Whiteboards/KillOptions + would like CJK always-on, and with less UI + but: three font-selectos in the paragraph style dialog, not ideal. + (Caolan) 'C' locale is a 'no idea what people want' locale the categories are the same as MS Office. add an easy one-click button to see these ? * CXX0X-ABI incompatibility can of worms (Bjoern) + gcc 4.7 - cxx0x extension is binary incompatible + incompatible stdlib symbols that bust + http://gcc.gnu.org/ml/gcc/2012-06/msg00201.html + luck that it worked until now: it was compatible. AA: + should disable in our builds by default (Bjoern) + not easy to detect; crashers like: + https://bugs.freedesktop.org/show_bug.cgi?id=51342 + show up randomly. + lots of cascading dependencies of different ABI's ... + serious long-run problem for building vs. system packages + potentially accelerates our move away from a single image that runs on every linux if disros pick up the new ver. * new cppunit release (Markus) + all our patches up-streamed into the new cppunit version + have a VisualStudio project file to build on win32 + misc. sourceforge bug tracker bugs fixed. + build-system issues nailed + auto_ptr warning spew killed + master updated to latest cppunit AA: + look into misc. build issues on master (Michael) * re-basing update (Michael) + 15k of 45k files complete - ~30% + 47 of ~150 directories complete + will incorporate migrate of idlc - uccp + discuss other migrations as/when/next * gerrit update (Bjoern) + still getting a couple of mails if you push: something to review and it's already in + goes away when gerrit owns the repo. + multiple efforts to update the helper scripts AA: + work on unifying spaetz + David's tools (Bjoern) + please review mst's patches for the -3-5 branch (mst) + only those in the reviewer field get mailed + not got a fire-hose
Re: vcl checkbox behaviour
On 28/06/12 19:02, Jan Holesovsky wrote: [...] Actually the for quite a while spans to 8ab086b6cc054501bfbf7ef6fa509c393691e860, the inital import of button.cxx to CVS :-( - it has been imported in 2000 with this already in place. Looking deeper, I thought that the 'alignment of checkboxes without text' behavior might make sense for the dialogs like Tools - Options - Load/Save - Microsoft Office and alike, where you'd want to center the checkbox; sure and any such instances could be covered by setting the bounding box of the checkbox appropriately I guess but it seems to me that it is actually SvLBoxButton that is used there, not CheckBox. so no issue there ( but don't forget radio buttons afaict are also treated the same way and probably would make sense to change them also ) So - can you in any way check if we are actually using this CheckBox feature anywhere in the UI? [Ie. if we construct a CheckBox without text, but with WB_CENTER or WB_RIGHT?] If we do not use it, I'd get rid of that [even in UNO controls and everywhere], as you proposed. Regards, Kendy yes, I will try to check ( hopefully without missing anything ) :-) I would also like to make an enhancement to really control the alignment of the control itself e.g. either left or right. This would not affect the behaviour previously described ( which is more about the justification of the label ) but the position of the label relative to the control e.g. - control aligned left: [x] some label - control aligned right: some label [x] again such an enhancement is driven by interoperability but... one step at a time :-) Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: binfilter/bf_sch
binfilter/bf_sch/source/ui/docshell/makefile.mk |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) New commits: commit 791329fd1d2e14c4fb9a3120b0d9947899bb3f98 Author: Thomas Arnhold tho...@arnhold.org Date: Fri Jun 29 11:39:10 2012 +0200 Fix build Didn't see the difference between l and 1... Change-Id: Ifb4178186300348b098770c2e15dc2757e0879a7 diff --git a/binfilter/bf_sch/source/ui/docshell/makefile.mk b/binfilter/bf_sch/source/ui/docshell/makefile.mk index c2fecb4..1294814 100644 --- a/binfilter/bf_sch/source/ui/docshell/makefile.mk +++ b/binfilter/bf_sch/source/ui/docshell/makefile.mk @@ -34,9 +34,11 @@ INC+= -I$(PRJ)$/inc$/bf_sch # --- Files -CXXFILES = $(BFPRJ)$/util$/sch_docshel1.cxx +CXXFILES = $(BFPRJ)$/util$/sch_docshell.cxx \ +sch_docshel1.cxx SLOFILES = \ +$(SLO)$/sch_docshell.obj \ $(SLO)$/sch_docshel1.obj ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: mythes/mythes-1.2.0-makefile-mk.diff
mythes/mythes-1.2.0-makefile-mk.diff |1 + 1 file changed, 1 insertion(+) New commits: commit 23d3a5e257e21520419133f02f449d007ad49644 Author: Caolán McNamara caol...@redhat.com Date: Fri Jun 29 12:43:37 2012 +0100 lost the patch directives on merge conflict fix Change-Id: I69321f8a5b4c0377ac6ceb7b6795d25bd9a3e6ba diff --git a/mythes/mythes-1.2.0-makefile-mk.diff b/mythes/mythes-1.2.0-makefile-mk.diff index 4b7b552..de247f6 100644 --- a/mythes/mythes-1.2.0-makefile-mk.diff +++ b/mythes/mythes-1.2.0-makefile-mk.diff @@ -1,5 +1,6 @@ --- misc/mythes-1.2.3/makefile.mk 2010-05-14 23:36:09.0 +0200 +++ misc/build/mythes-1.2.3/makefile.mk2010-05-14 23:35:14.0 +0200 +@@ -1 +1,84 @@ -dummy +#* +# ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Andras Timar tima...@gmail.com changed: What|Removed |Added Depends on||51143 --- Comment #33 from Andras Timar tima...@gmail.com 2012-06-29 04:58:46 UTC --- Add bug 51143: crash if online update not installed, that may hinder corporate deployments. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sax/qa
sax/qa/cppunit/test_converter.cxx | 98 +++--- 1 file changed, 49 insertions(+), 49 deletions(-) New commits: commit 6736ca4bb92b0b40afce0f628511a82724c6747d Author: Michael Meeks michael.me...@suse.com Date: Fri Jun 29 12:59:50 2012 +0100 another unit test issue diff --git a/sax/qa/cppunit/test_converter.cxx b/sax/qa/cppunit/test_converter.cxx index f547674..1a33915 100644 --- a/sax/qa/cppunit/test_converter.cxx +++ b/sax/qa/cppunit/test_converter.cxx @@ -34,7 +34,7 @@ using namespace ::com::sun::star; -using namespace ::com::sun::star::util::MeasureUnit; +using namespace ::com::sun::star::util; using sax::Converter; @@ -260,54 +260,54 @@ void doTestDouble(char const*const pis, double const rd, void ConverterTest::testDouble() { -doTestDouble(42, 42.0, TWIP, TWIP); -doTestDouble(42, 42.0, POINT, POINT); -doTestDouble(42, 42.0, MM_100TH, MM_100TH); -doTestDouble(42, 42.0, MM_10TH, MM_10TH); -doTestDouble(42, 42.0, MM, MM); // identity don't seem to add unit? -doTestDouble(42, 42.0, CM, CM); -doTestDouble(42, 42.0, INCH, INCH); -doTestDouble(2pt, 40.0, POINT, TWIP); -doTestDouble(20pc, 1, TWIP, POINT); -doTestDouble(4, 2.26771653543307, MM_100TH, TWIP); -doTestDouble(4, 22.6771653543307, MM_10TH, TWIP); -doTestDouble(4mm, 226.771653543307, MM, TWIP); -doTestDouble(4cm, 2267.71653543307, CM, TWIP); -doTestDouble(4in, 5760.0, INCH, TWIP); -doTestDouble(1440pc, 1.0, TWIP, INCH); -doTestDouble(567pc, 1.000125, TWIP, CM); -doTestDouble(56.7pc, 1.000125, TWIP, MM); -doTestDouble(5.67pc, 1.000125, TWIP, MM_10TH); -doTestDouble(0.567pc, 1.000125, TWIP, MM_100TH); -doTestDouble(42pt, 1.48166, POINT, CM); -doTestDouble(42pt, 14.8166, POINT, MM); -doTestDouble(42pt, 148.166, POINT, MM_10TH); -doTestDouble(42pt, 1481.66, POINT, MM_100TH); -doTestDouble(72pt, 1.0, POINT, INCH); -doTestDouble(3.5in, 8.89, INCH, CM); -doTestDouble(3.5in, 88.9, INCH, MM); -doTestDouble(3.5in, 889.0, INCH, MM_10TH); -doTestDouble(3.5in, 8890.0, INCH, MM_100TH); -doTestDouble(2in, 144, INCH, POINT); -doTestDouble(5.08cm, 2.0, CM, INCH); -doTestDouble(3.5cm, 3500.0, CM, MM_100TH); -doTestDouble(3.5cm, 350.0, CM, MM_10TH); -doTestDouble(3.5cm, 35.0, CM, MM); -doTestDouble(10cm, 283.464566929134, CM, POINT); -doTestDouble(0.5cm, 283.464566929134, CM, TWIP); -doTestDouble(10mm, 28.3464566929134, MM, POINT); -doTestDouble(0.5mm, 28.3464566929134, MM, TWIP); -doTestDouble(10, 2.83464566929134, MM_10TH, POINT); -doTestDouble(0.5, 2.83464566929134, MM_10TH, TWIP); -doTestDouble(10, 0.283464566929134, MM_100TH, POINT); -doTestDouble(0.5, 0.283464566929134, MM_100TH, TWIP); -doTestDouble(10mm, 1.0, MM, CM); -doTestDouble(10mm, 100.0, MM, MM_10TH); -doTestDouble(20mm, 2000.0, MM, MM_100TH); -doTestDouble(300, 30.0, MM_10TH, MM); -doTestDouble(400, 4.0, MM_100TH, MM); -doTestDouble(600, 6000.0, MM_10TH, MM_100TH); -doTestDouble(700, 70.0, MM_100TH, MM_10TH); +doTestDouble(42, 42.0, MeasureUnit::TWIP, MeasureUnit::TWIP); +doTestDouble(42, 42.0, MeasureUnit::POINT, MeasureUnit::POINT); +doTestDouble(42, 42.0, MeasureUnit::MM_100TH, MeasureUnit::MM_100TH); +doTestDouble(42, 42.0, MeasureUnit::MM_10TH, MeasureUnit::MM_10TH); +doTestDouble(42, 42.0, MeasureUnit::MM, MeasureUnit::MM); // identity don't seem to add unit? +doTestDouble(42, 42.0, MeasureUnit::CM, MeasureUnit::CM); +doTestDouble(42, 42.0, MeasureUnit::INCH, MeasureUnit::INCH); +doTestDouble(2pt, 40.0, MeasureUnit::POINT, MeasureUnit::TWIP); +doTestDouble(20pc, 1, MeasureUnit::TWIP, MeasureUnit::POINT); +doTestDouble(4, 2.26771653543307, MeasureUnit::MM_100TH, MeasureUnit::TWIP); +doTestDouble(4, 22.6771653543307, MeasureUnit::MM_10TH, MeasureUnit::TWIP); +doTestDouble(4mm, 226.771653543307, MeasureUnit::MM, MeasureUnit::TWIP); +doTestDouble(4cm, 2267.71653543307, MeasureUnit::CM, MeasureUnit::TWIP); +doTestDouble(4in, 5760.0, MeasureUnit::INCH, MeasureUnit::TWIP); +doTestDouble(1440pc, 1.0, MeasureUnit::TWIP, MeasureUnit::INCH); +doTestDouble(567pc, 1.000125, MeasureUnit::TWIP, MeasureUnit::CM); +doTestDouble(56.7pc, 1.000125, MeasureUnit::TWIP, MeasureUnit::MM); +doTestDouble(5.67pc, 1.000125, MeasureUnit::TWIP, MeasureUnit::MM_10TH); +doTestDouble(0.567pc, 1.000125, MeasureUnit::TWIP, MeasureUnit::MM_100TH); +doTestDouble(42pt, 1.48166, MeasureUnit::POINT, MeasureUnit::CM); +doTestDouble(42pt, 14.8166, MeasureUnit::POINT, MeasureUnit::MM); +doTestDouble(42pt, 148.166, MeasureUnit::POINT, MeasureUnit::MM_10TH); +doTestDouble(42pt, 1481.66, MeasureUnit::POINT, MeasureUnit::MM_100TH); +doTestDouble(72pt, 1.0, MeasureUnit::POINT, MeasureUnit::INCH); +doTestDouble(3.5in, 8.89,
[Libreoffice-commits] .: mythes/makefile.mk mythes/mythes-ssizet.patch
mythes/makefile.mk |3 ++- mythes/mythes-ssizet.patch | 20 2 files changed, 22 insertions(+), 1 deletion(-) New commits: commit 22d9af36bf1716607272b25513349b3d325a3ebf Author: Caolán McNamara caol...@redhat.com Date: Fri Jun 29 13:19:17 2012 +0100 ah MS why do you hate me so Change-Id: I268e1f5caa68668efdd2d83d1d8fe00401c6ed0f diff --git a/mythes/makefile.mk b/mythes/makefile.mk index 1efbc21..ce1005d 100644 --- a/mythes/makefile.mk +++ b/mythes/makefile.mk @@ -44,7 +44,8 @@ ADDITIONAL_FILES += makefile.mk PATCH_FILES=\ mythes-1.2.0-vanilla-th-gen-idx.patch \ mythes-1.2.0-makefile-mk.diff \ -mythes-1.2.0-android.patch +mythes-1.2.0-android.patch \ +mythes-ssizet.patch .IF $(COM)==GCC .IF $(SYSTEM_HUNSPELL) != YES diff --git a/mythes/mythes-ssizet.patch b/mythes/mythes-ssizet.patch new file mode 100644 index 000..25d9516 --- /dev/null +++ b/mythes/mythes-ssizet.patch @@ -0,0 +1,20 @@ +--- misc/mythes-1.2.3/mythes.cxx 2012-06-29 13:16:55.812939142 +0100 misc/build/mythes-1.2.3/mythes.cxx 2012-06-29 13:17:21.159198507 +0100 +@@ -48,7 +48,7 @@ + len = readLine(pifile,wrd,MAX_WD_LEN); + int idxsz = atoi(wrd); + +-if (idxsz = 0 || idxsz std::numeric_limitsssize_t::max() / sizeof(sizeof(char*))) { ++if (idxsz = 0 || idxsz std::numeric_limitsint::max() / sizeof(sizeof(char*))) { +fprintf(stderr,Error - bad index %d\n, idxsz); +fclose(pifile); +return 0; +@@ -176,7 +176,7 @@ + return 0; + } + int nmeanings = atoi(buf+np+1); +-if (nmeanings 0 || nmeanings std::numeric_limitsssize_t::max() / sizeof(mentry)) ++if (nmeanings 0 || nmeanings std::numeric_limitsint::max() / sizeof(mentry)) + nmeanings = 0; + *pme = (mentry*)(nmeanings ? malloc(nmeanings * sizeof(mentry)) : NULL); + if (!(*pme)) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: ucb/source
ucb/source/ucp/cmis/cmis_content.cxx | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) New commits: commit 5e67fb190be69b40ce24a36540031d07c691db07 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Fri Jun 29 13:06:21 2012 +0200 UCP CMIS: avoid breaking the media type when saving a document Change-Id: Iab7f932c25f66734994dfa44a09fc1d9f511ad11 diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx index 6c41521..43cb682 100644 --- a/ucb/source/ucp/cmis/cmis_content.cxx +++ b/ucb/source/ucp/cmis/cmis_content.cxx @@ -405,6 +405,21 @@ namespace cmis { xRow-appendObject( rProp, uno::makeAny( queryCreatableContentsInfo( xEnv ) ) ); } +else if ( rProp.Name == MediaType ) +{ +try +{ +libcmis::Document* document = dynamic_cast libcmis::Document* ( getObject().get( ) ); +if ( NULL != document ) +xRow-appendString( rProp, STD_TO_OUSTR( document-getContentType() ) ); +else +xRow-appendVoid( rProp ); +} +catch ( const libcmis::Exception ) +{ +xRow-appendVoid( rProp ); +} +} else SAL_INFO( cmisucp, Looking for unsupported property rProp.Name ); } @@ -601,10 +616,11 @@ namespace cmis libcmis::Document* document = dynamic_cast libcmis::Document* ( object.get( ) ); if ( NULL != document ) { +string sMime = document-getContentType( ); boost::shared_ptr ostream pOut( new ostringstream ( ios_base::binary | ios_base::in | ios_base::out ) ); uno::Reference io::XOutputStream xOutput = new ucbhelper::StdOutputStream( pOut ); copyData( xInputStream, xOutput ); -document-setContentStream( pOut, string( ), bReplaceExisting ); +document-setContentStream( pOut, sMime, bReplaceExisting ); } } else @@ -837,6 +853,9 @@ namespace cmis beans::Property( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( CreatableContentsInfo ) ), -1, getCppuType( static_cast const uno::Sequence ucb::ContentInfo * ( 0 ) ), beans::PropertyAttribute::BOUND | beans::PropertyAttribute::READONLY ), +beans::Property( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( MediaType ) ), +-1, getCppuType( static_cast const rtl::OUString * ( 0 ) ), +beans::PropertyAttribute::BOUND ), }; const int nProps = SAL_N_ELEMENTS(aGenericProperties); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - ucb/source
ucb/source/ucp/cmis/cmis_content.cxx | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) New commits: commit f5c45d91032d1f9e6783a15bd89c36a4a9841742 Author: Cédric Bosdonnat cedric.bosdon...@free.fr Date: Fri Jun 29 13:06:21 2012 +0200 UCP CMIS: avoid breaking the media type when saving a document Change-Id: Iab7f932c25f66734994dfa44a09fc1d9f511ad11 diff --git a/ucb/source/ucp/cmis/cmis_content.cxx b/ucb/source/ucp/cmis/cmis_content.cxx index 6c41521..43cb682 100644 --- a/ucb/source/ucp/cmis/cmis_content.cxx +++ b/ucb/source/ucp/cmis/cmis_content.cxx @@ -405,6 +405,21 @@ namespace cmis { xRow-appendObject( rProp, uno::makeAny( queryCreatableContentsInfo( xEnv ) ) ); } +else if ( rProp.Name == MediaType ) +{ +try +{ +libcmis::Document* document = dynamic_cast libcmis::Document* ( getObject().get( ) ); +if ( NULL != document ) +xRow-appendString( rProp, STD_TO_OUSTR( document-getContentType() ) ); +else +xRow-appendVoid( rProp ); +} +catch ( const libcmis::Exception ) +{ +xRow-appendVoid( rProp ); +} +} else SAL_INFO( cmisucp, Looking for unsupported property rProp.Name ); } @@ -601,10 +616,11 @@ namespace cmis libcmis::Document* document = dynamic_cast libcmis::Document* ( object.get( ) ); if ( NULL != document ) { +string sMime = document-getContentType( ); boost::shared_ptr ostream pOut( new ostringstream ( ios_base::binary | ios_base::in | ios_base::out ) ); uno::Reference io::XOutputStream xOutput = new ucbhelper::StdOutputStream( pOut ); copyData( xInputStream, xOutput ); -document-setContentStream( pOut, string( ), bReplaceExisting ); +document-setContentStream( pOut, sMime, bReplaceExisting ); } } else @@ -837,6 +853,9 @@ namespace cmis beans::Property( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( CreatableContentsInfo ) ), -1, getCppuType( static_cast const uno::Sequence ucb::ContentInfo * ( 0 ) ), beans::PropertyAttribute::BOUND | beans::PropertyAttribute::READONLY ), +beans::Property( rtl::OUString( RTL_CONSTASCII_USTRINGPARAM( MediaType ) ), +-1, getCppuType( static_cast const rtl::OUString * ( 0 ) ), +beans::PropertyAttribute::BOUND ), }; const int nProps = SAL_N_ELEMENTS(aGenericProperties); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: cppunit/makefile.mk cppunit/windows.patch
cppunit/makefile.mk |2 +- cppunit/windows.patch | 48 2 files changed, 49 insertions(+), 1 deletion(-) New commits: commit 2414bb8d9ef6a23b4491c0893b462a57d4db860d Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Fri Jun 29 14:40:36 2012 +0200 add windows patch back Change-Id: Id30b06eb093e373da6eb328b5d22788f308ae4ff diff --git a/cppunit/makefile.mk b/cppunit/makefile.mk index 598dd9d..2880d32 100644 --- a/cppunit/makefile.mk +++ b/cppunit/makefile.mk @@ -32,7 +32,7 @@ TARGET = cppunit TARFILE_NAME=cppunit-1.13.0 TARFILE_MD5=0c65c839854edd43d9294d1431a2b292 -PATCH_FILES = +PATCH_FILES = windows.patch .IF $(OS) == ANDROID PATCH_FILES += android.patch diff --git a/cppunit/windows.patch b/cppunit/windows.patch new file mode 100644 index 000..c23477d --- /dev/null +++ b/cppunit/windows.patch @@ -0,0 +1,48 @@ +--- misc/cppunit-1.13.0/include/cppunit/plugin/TestPlugIn.h2010-01-11 14:42:25.084658287 +0100 misc/build/cppunit-1.13.0/include/cppunit/plugin/TestPlugIn.h 2010-01-11 14:42:18.660706180 +0100 +@@ -133,9 +133,8 @@ + /*! \def CPPUNIT_PLUGIN_IMPLEMENT_MAIN() + * \brief Implements the 'main' function for the plug-in. + * +- * This macros implements the main() function for dynamic library. +- * For example, WIN32 requires a DllMain function, while some Unix +- * requires a main() function. This macros takes care of the implementation. ++ * This macro implements the main() function for dynamic library ++ * on Unix for some weird reason. + */ + + // Win32 +@@ -149,21 +149,7 @@ + + // Win32 + #if defined(CPPUNIT_HAVE_WIN32_DLL_LOADER) +-#if !defined(APIENTRY) +-#define WIN32_LEAN_AND_MEAN +-#define NOGDI +-#define NOUSER +-#define NOKERNEL +-#define NOSOUND +-#define NOMINMAX +-#define BLENDFUNCTION void// for mingw gcc +-#include windows.h +-#endif + #define CPPUNIT_PLUGIN_IMPLEMENT_MAIN() \ +- BOOL APIENTRY DllMain( HANDLE, DWORD, LPVOID ) \ +- { \ +- return TRUE;\ +- } \ + typedef char __CppUnitPlugInImplementMainDummyTypeDef + + // Unix +--- misc/cppunit-1.13.0/include/cppunit/TestAssert.h misc/build/cppunit-1.13.0/include/cppunit/TestAssert.h +@@ -76,7 +76,7 @@ +const int precision = 15; + #endif // #ifdef DBL_DIG +char buffer[128]; +-#ifdef __STDC_SECURE_LIB__ // Use secure version with visual studio 2005 to avoid warning. ++#if defined(_MSC_VER) defined(__STDC_SECURE_LIB__) // Use secure version with visual studio 2005 to avoid warning. +sprintf_s(buffer, sizeof(buffer), %.*g, precision, x); + #else +sprintf(buffer, %.*g, precision, x); + ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: minutes of ESC call ...
On Fri, 2012-06-29 at 09:56 +0100, Michael Meeks wrote: + (Caolan) 'C' locale is a 'no idea what people want' locale I mean that a huge amount of people use the en_US locale as their default I want everything in English even though I'm not in the US locale[1] so that its probably useless to assume too much from an en_US locale. On the other hand though if its *not* an en_US locale, e.g. nl_NL, hi_IN, ja_JP or some such then it would seem fairly reasonable to assume that the locale means what it says. So... one (odd I suppose) possibility would be to continue the current logic of hiding either or both of the CJK and CTL options based on the locale if that locale *isn't* en_US. Maybe another possibility is to dig around the various system and LibreOffice locale subsettings a bit deeper to see if there's any evidence that e.g. enabling CJK/CTL would be useful. i.e. if *any* locale setting is set to a territory using a CJK language toggle them on or if e.g. the underlying locale settings are en_US but the paper has been changed to A4 then they're lying about being in the US so toggle everything on :-) add an easy one-click button to see these ? * un-merged patches in bugzilla (Bjoern) + Bjoern worked on a few, many are already merged = just close them. + query of doom for the recent batch: https://bugs.freedesktop.org/buglist.cgi?chfieldto=Nowchfield=[Bug%20creation]chfield=aliaschfield=assigned_tochfield=cclist_accessiblechfield=componentchfield=deadlinechfield=everconfirmedchfield=rep_platformchfield=op_syschfield=prioritychfield=productchfield=qa_contactchfield=reporter_accessiblechfield=resolutionchfield=bug_severitychfield=bug_statuschfield=short_descchfield=target_milestonechfield=bug_file_locchfield=versionchfield=voteschfield=status_whiteboardquery_format=advancedchfieldfrom=2012-05-10list_id=88624field0-0-0=attachments.ispatchbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFObug_status=PLEASETESTtype0-0-0=equalsvalue0-0-0=1product=LibreOffice I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. I *tried* to make a query to get a list of bugs that contain 1 non obsolete patches and mark the debugging patches as obsolete to try and weed out the noise but failed. Anyone got better bugzilla query king-fu to make the right query for that ? C. [1] There is the en_DK Linux locale which would, to my mind, fit a sort of international english pseudo-locale which would e.g. have A4 paper and not US letter as default paper, iso -MM-DD dates, not US date style. Unclear though what spelling standard would be in use. UK English with OED spelling rules for -ize, rumoured to be the in-house standard in many international organizations, would be tempting, i.e. langtag en-GB-oed. But what currency then, bah... ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PATCH] cleanup java code and update to Java5, including generics (36)
On 2012-06-29 14:30, Philipp Riemer wrote: Hey Noel, I would like to offer my help for that because I have some spare time over the weekend. If it's ok with you, can you send me (better off the list, I guess) some pointers to files/folders I can start working on? It's always great to get more people helping with LibreOffice, but first let's see how happy the powers-that-be are with my changes :-) I'm sure exactly to what degree the LO hackers want such changes (I'm not even sure if they'll be happy with all of my generics changes). So we should probably wait for some feedback before proceeding. Just as a note for other people - I did the bulk of the work using Eclipse and it's built-in re-factoring tools and quickfix tools. Most of my time was spent (a) configuring an Eclipse workspace to handle the weird and wonderful directory layouts that the LO java code lives in. (b) handling the tricky little edge cases that the automatic tools could not figure out. (c) in the case of javadoc errors, trying to figure out the original intention, so I could update it correctly. Now that I think about it, one thing you could do that would help, and that I'm pretty sure the LO hackers would not mind, is to run a spellcheck tool over the java code, and fix whatever errors you may find. These links should be enough to get you started: http://blogs.operationaldynamics.com/andrew/software/java-gnome/spell-checking-source-code http://www.bdaum.de/eclipse/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On 2012-06-29 14:47, Caolán McNamara wrote: I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. Maybe we should have some way of marking bugs in in-progress or experimental ? Maybe just push bugs that have incomplete patches into NEEDSINFO state? Disclaimer: http://www.peralex.com/disclaimer.html ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
EasyHack #41291 playterm build session
Hi Pietro, (copying the dev-list for better visibilty) On Thu, Jun 28, 2012 at 07:45:09PM -0700, Pietro F. Menna wrote: I'm writing to you because you are the Core Developer from libreoffice which should be copied in the resolution of the entry 41291 from link below: https://bugs.freedesktop.org/show_bug.cgi?id=41291 Awesome! Great work! What I understood it was asked in this case was to make a ttyrecord of how to build libreoffice. I just made it and recorded the full session from a fresh Ubuntu 12.04 install. So in this case people will also be able to watch the dependencies before building. How long does that take? I assume it is rather quick, right? I also got into some issues while building, so those can be seen and checked how I troubleshooted it. Heh, oh, cool. I wonder however, if we want to keep those. While it might help newcomers who to see how to fix common problems, we do not want to scare away new contributors with stuff that ususally doesnt happen. ;) Since the build generetes a lot of log, the ttyrecord file got a bit large. So I gzipped and I have attached to this email so you can review it. If you would like me to do it again from a fresh start, I would have no problem at all. Please feel free to send your comments and I will review it. Could you upload that as-is at http://playterm.org/ so we have a starting point there (and to see if the file is too large for playterm)? That would be great. And yes, having a recording of a simple, straightforward build would be even better in the long run, so once this thing is uploaded, it would be cool if you would have another streamlined try. But lets start with what you have first ;) Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On Fri, Jun 29, 2012 at 01:47:58PM +0100, Caolán McNamara caol...@redhat.com wrote: I mean that a huge amount of people use the en_US locale as their default I want everything in English even though I'm not in the US locale[1] But that is just plain wrong IMHO, LC_MESSAGES=C can be used to get everything in English without screwing up LANG. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Error when trying to compile LibreOffice 3.5.2
On Tue, 2012-06-26 at 12:35 -0700, Leonardo Josué Corcega Ufona wrote: vcbuild.exe : error VCBLD0001: VCProjectEngine.dll no se puede cargar. Aseg▒rese de que el archivo VCProjectEngine.dll se encuentra en el mismo directorio que el archivo vcbuild.exe. Well, google translate turns this into... VCBLD0001: CProjectEngine.dll not be loaded. Make sure VCProjectEngine.dll that the file is in the same directory as the VCBuild.exe. googling on that then gives http://wiki.postgresql.org/wiki/PgAdmin_Internals as a plausible similar problem and solution, i.e. on non-english version of visual c++ express edition (spanish, french and others). This Problem seems to be that for non english versions, vcbuild cannot load the specific languages dll. SOLUTION: copy the content of the localized folder (for french it is ...vcpackages\1036, spanish it is ...vcpackages\3082) in vcpackages. It worked on french and spanish version. -- Fabulous! It was a problem with the language version. The solution worked great. Caolán, Thank you very much for help! Leonardo Josué ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - instsetoo_native/util
instsetoo_native/util/openoffice.lst | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) New commits: commit c2096b71ac7b6ba71779505484e7a10e0dd2db88 Author: Petr Mladek pmla...@suse.cz Date: Fri Jun 29 15:14:40 2012 +0200 use the version 3.5.6.0+ in the about dialog (fdo#51467) follow the new version scheme at least in the about dialog; renaming the download tarballs, rpm names, and other stuff would be a bit risky at this stage Change-Id: Iacf367cf726da71d3095096bc92e89051f0cd5b5 diff --git a/instsetoo_native/util/openoffice.lst b/instsetoo_native/util/openoffice.lst index 9aa7a5e..a354d02 100644 --- a/instsetoo_native/util/openoffice.lst +++ b/instsetoo_native/util/openoffice.lst @@ -59,7 +59,7 @@ LibreOffice BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.6 - ABOUTBOXPRODUCTVERSIONSUFFIX rc0+ + ABOUTBOXPRODUCTVERSIONSUFFIX .0+ BASEPRODUCTVERSION 3.5 PCPFILENAME libreoffice.pcp UPDATEURL http://update.libreoffice.org/check.php @@ -118,7 +118,7 @@ LibreOffice_wJRE BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.6 - ABOUTBOXPRODUCTVERSIONSUFFIX rc0+ + ABOUTBOXPRODUCTVERSIONSUFFIX .0+ BASEPRODUCTVERSION 3.5 UPDATEURL http://update.libreoffice.org/check.php ADD_INCLUDE_FILES cliureversion.mk,clioootypesversion.mk,javaversion2.dat,userland.txt,version.lst @@ -177,7 +177,7 @@ LibreOffice_Dev BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.6 - ABOUTBOXPRODUCTVERSIONSUFFIX rc0+ + ABOUTBOXPRODUCTVERSIONSUFFIX .0+ BASEPRODUCTVERSION 3.5 DEVELOPMENTPRODUCT 1 BASISPACKAGEPREFIX lodevbasis @@ -464,7 +464,7 @@ OxygenOffice BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.6 - ABOUTBOXPRODUCTVERSIONSUFFIX rc0+ + ABOUTBOXPRODUCTVERSIONSUFFIX .0+ BASEPRODUCTVERSION 3.5 PCPFILENAME openoffice.pcp UPDATEURL http://update.libreoffice.org/check.php @@ -528,7 +528,7 @@ OxygenOffice_wJRE BRANDPACKAGEVERSION 3.5 USERDIRPRODUCTVERSION 3 ABOUTBOXPRODUCTVERSION 3.5.6 - ABOUTBOXPRODUCTVERSIONSUFFIX rc0+ + ABOUTBOXPRODUCTVERSIONSUFFIX .0+ BASEPRODUCTVERSION 3.5 UPDATEURL http://update.libreoffice.org/check.php ADD_INCLUDE_FILES cliureversion.mk,clioootypesversion.mk,javaversion2.dat,userland.txt ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] cleanup java code and update to Java5, including generics (36)
2012/6/29 Noel Grandin noelgran...@gmail.com: On 2012-06-29 14:30, Philipp Riemer wrote: Hey Noel, I would like to offer my help for that because I have some spare time over the weekend. If it's ok with you, can you send me (better off the list, I guess) some pointers to files/folders I can start working on? It's always great to get more people helping with LibreOffice, but first let's see how happy the powers-that-be are with my changes :-) OK ;-) I'm sure exactly to what degree the LO hackers want such changes (I'm not even sure if they'll be happy with all of my generics changes). So we should probably wait for some feedback before proceeding. Just as a note for other people - I did the bulk of the work using Eclipse and it's built-in re-factoring tools and quickfix tools. Most of my time was spent (a) configuring an Eclipse workspace to handle the weird and wonderful directory layouts that the LO java code lives in. (b) handling the tricky little edge cases that the automatic tools could not figure out. (c) in the case of javadoc errors, trying to figure out the original intention, so I could update it correctly. Did you consider sharing this eclipse project config file or create a blog/wiki post, so that not everyone would need to figure out all this nittygritty stuff..? Now that I think about it, one thing you could do that would help, and that I'm pretty sure the LO hackers would not mind, is to run a spellcheck tool over the java code, and fix whatever errors you may find. These links should be enough to get you started: http://blogs.operationaldynamics.com/andrew/software/java-gnome/spell-checking-source-code http://www.bdaum.de/eclipse/ Thank you for the links! I wasn't aware that such a spellchecking tool even exists as an Eclipse plugin. Even while wishing for it, I never actually checked if someone already did that work. I will see what I can do. Have a nice weekend! Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - configure.in languagetool/JLanguageTool-1.4.0-no-hc.patch languagetool/JLanguageTool-1.4.0.patch languagetool/JLanguageTool-1.7.0.patch languagetool/makefile.mk oo
configure.in |2 languagetool/JLanguageTool-1.4.0-no-hc.patch |8 - languagetool/JLanguageTool-1.4.0.patch | 117 --- languagetool/JLanguageTool-1.7.0.patch | 159 +++ languagetool/makefile.mk |8 - ooo.lst.in |2 6 files changed, 169 insertions(+), 127 deletions(-) New commits: commit 8d1a2b4f210cb486028a24012851954669faf58c Author: Andras Timar ati...@suse.com Date: Fri Jun 29 15:42:42 2012 +0200 Update LanguageTool to version 1.7 + passive registration Change-Id: I43c6235546976f6d17bcd782b370e9fa2264f2b6 diff --git a/languagetool/JLanguageTool-1.4.0-no-hc.patch b/languagetool/JLanguageTool-1.4.0-no-hc.patch index 0078cf8..ea32087 100644 --- a/languagetool/JLanguageTool-1.4.0-no-hc.patch +++ b/languagetool/JLanguageTool-1.4.0-no-hc.patch @@ -1,5 +1,5 @@ misc/JLanguageTool-1.4.0/build.xml 2012-02-29 22:18:05.118789546 +0100 -+++ misc/build/JLanguageTool-1.4.0/build.xml 2012-02-29 22:17:02.385235706 +0100 +--- misc/JLanguageTool-1.7.0/build.xml 2012-02-29 22:18:05.118789546 +0100 misc/build/JLanguageTool-1.7.0/build.xml 2012-02-29 22:17:02.385235706 +0100 @@ -82,7 +82,6 @@ include name=openoffice/Linguistic.xcu/ include name=openoffice/description.xml/ @@ -8,8 +8,8 @@ include name=openoffice/images/LanguageToolBig.png/ include name=openoffice/images/LanguageToolSmall.png/ include name=openoffice/images/dialog.png/ misc/JLanguageTool-1.4.0/openoffice/Linguistic.xcu 2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/openoffice/Linguistic.xcu 2012-02-29 22:17:25.551071099 +0100 +--- misc/JLanguageTool-1.7.0/openoffice/Linguistic.xcu 2011-06-26 20:29:43.0 +0200 misc/build/JLanguageTool-1.7.0/openoffice/Linguistic.xcu 2012-02-29 22:17:25.551071099 +0100 @@ -27,9 +27,6 @@ prop oor:name=SpellAndGrammarDialogImage oor:type=xs:string value%origin%/images/dialog.png/value diff --git a/languagetool/JLanguageTool-1.4.0.patch b/languagetool/JLanguageTool-1.4.0.patch deleted file mode 100644 index 26afc30..000 --- a/languagetool/JLanguageTool-1.4.0.patch +++ /dev/null @@ -1,117 +0,0 @@ -diff -Naur misc/JLanguageTool-1.4.0//build.properties misc/build/JLanguageTool-1.4.0/build.properties misc/JLanguageTool-1.4.0//build.properties 2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/build.properties2011-08-25 18:22:31.305870800 +0200 -@@ -50,10 +50,10 @@ - ext.log4j.lib = ${ext.dir}/build/cobertura/log4j-1.2.9.jar - ext.jakarta-oro.lib = ${ext.dir}/build/cobertura/jakarta-oro-2.0.8.jar - --ext.ooo.juh.lib = ${ext.ooo.dir}/juh.jar --ext.ooo.unoil.lib = ${ext.ooo.dir}/unoil.jar --ext.ooo.ridl.lib = ${ext.ooo.dir}/ridl.jar --ext.ooo.jurt.lib = ${ext.ooo.dir}/jurt.jar -+ext.ooo.juh.lib = ${solver.ooo.dir}/juh.jar -+ext.ooo.unoil.lib = ${solver.ooo.dir}/unoil.jar -+ext.ooo.ridl.lib = ${solver.ooo.dir}/ridl.jar -+ext.ooo.jurt.lib = ${solver.ooo.dir}/jurt.jar - - build.meta-inf = ${build.dir}/META-INF - final.name = LanguageTool -diff -Naur misc/JLanguageTool-1.4.0//build.xml misc/build/JLanguageTool-1.4.0/build.xml misc/JLanguageTool-1.4.0//build.xml2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/build.xml 2011-08-25 18:26:51.816771100 +0200 -@@ -24,6 +24,8 @@ - pathelement location=${ext.jakarta-regex.lib} / - pathelement location=${ext.segment.lib} / - !-- -- -+ pathelement location=${ext.junit.lib}/ -+ !-- -- - pathelement location=${ext.ooo.juh.lib} / - pathelement location=${ext.ooo.unoil.lib} / - pathelement location=${ext.ooo.ridl.lib} / -@@ -390,11 +392,11 @@ - !-- == -- - - target name=dist depends=ooo-internal description=Builds one ZIP for both OpenOffice.org and stand-alone use --zip compress=yes destfile=${dist.dir}/LanguageTool-${version}.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / -+zip compress=yes destfile=${dist.dir}/LanguageTool.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / - /target - - target name=fast depends=ooo-internal description=like dist, but without ZIP compression (for development only) --zip compress=no destfile=${dist.dir}/LanguageTool-${version}.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / -+zip compress=no destfile=${dist.dir}/LanguageTool.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / - /target - - target
[Libreoffice-commits] .: 2 commits - sd/inc sd/Library_sd.mk sd/source
sd/Library_sd.mk|2 sd/inc/CustomAnimationEffect.hxx|1 sd/inc/Outliner.hxx |4 sd/inc/OutlinerIterator.hxx |1 sd/inc/anminfo.hxx |5 sd/inc/drawdoc.hxx | 11 sd/inc/sdabstdlg.hxx|5 sd/inc/sddll.hxx|6 sd/inc/sdfilter.hxx |1 sd/inc/sdgrffilter.hxx |2 sd/inc/sdmod.hxx|5 sd/inc/undo/undoobjects.hxx |2 sd/source/ui/animations/CustomAnimationPane.hxx |1 sd/source/ui/animations/SlideTransitionPane.hxx |1 sd/source/ui/annotations/annotationwindow.hxx |3 sd/source/ui/dlg/sddlgfact.hxx |1 sd/source/ui/framework/factories/ChildWindowPane.hxx|2 sd/source/ui/framework/module/ToolPanelModule.hxx |2 sd/source/ui/inc/DrawDocShell.hxx |4 sd/source/ui/inc/DrawViewShell.hxx |3 sd/source/ui/inc/SdUnoOutlineView.hxx |2 sd/source/ui/inc/SdUnoSlideView.hxx |4 sd/source/ui/inc/TextObjectBar.hxx |1 sd/source/ui/inc/View.hxx |1 sd/source/ui/inc/ViewShell.hxx |9 sd/source/ui/inc/ViewShellBase.hxx |1 sd/source/ui/inc/ViewShellImplementation.hxx|2 sd/source/ui/inc/bulmaper.hxx |2 sd/source/ui/inc/celltempl.hxx |4 sd/source/ui/inc/copydlg.hxx|2 sd/source/ui/inc/dlgpage.hxx|4 sd/source/ui/inc/drawview.hxx |2 sd/source/ui/inc/framework/ConfigurationController.hxx |5 sd/source/ui/inc/fuconbez.hxx |2 sd/source/ui/inc/fuconcs.hxx|2 sd/source/ui/inc/fuprlout.hxx |1 sd/source/ui/inc/futext.hxx |1 sd/source/ui/inc/headerfooterdlg.hxx|1 sd/source/ui/inc/navigatr.hxx |1 sd/source/ui/inc/optsitem.hxx |1 sd/source/ui/inc/prltempl.hxx |6 sd/source/ui/inc/taskpane/ControlContainer.hxx |2 sd/source/ui/inc/taskpane/TaskPaneControlFactory.hxx|4 sd/source/ui/inc/taskpane/TaskPaneTreeNode.hxx |4 sd/source/ui/inc/taskpane/ToolPanelViewShell.hxx|5 sd/source/ui/inc/unosrch.hxx|1 sd/source/ui/slideshow/showwindow.hxx |2 sd/source/ui/toolpanel/LayoutMenu.hxx |1 sd/source/ui/toolpanel/TestMenu.cxx | 310 sd/source/ui/toolpanel/TestMenu.hxx | 78 --- sd/source/ui/toolpanel/TestPanel.cxx| 172 -- sd/source/ui/toolpanel/TestPanel.hxx| 51 - sd/source/ui/toolpanel/ToolPanelUIElement.hxx |2 sd/source/ui/toolpanel/controls/AllMasterPagesSelector.hxx |4 sd/source/ui/toolpanel/controls/CustomAnimationPanel.hxx|4 sd/source/ui/toolpanel/controls/MasterPageContainer.hxx |6 sd/source/ui/toolpanel/controls/MasterPagesSelector.hxx |4 sd/source/ui/toolpanel/controls/RecentlyUsedMasterPages.hxx |2 sd/source/ui/toolpanel/controls/SlideTransitionPanel.hxx|4 sd/source/ui/toolpanel/controls/TableDesignPanel.hxx|4 60 files changed, 5 insertions(+), 771 deletions(-) New commits: commit bf5115328ed454f43b4443f3891a0183dfd62814 Author: Takeshi Abe t...@fixedpoint.jp Date: Fri Jun 29 18:13:20 2012 +0900 removed unnecessary forward declarations of class except * sd::ViewTabBar moved to ViewShellBase.hxx * sd::TemplateEntry moved to AllMasterPageSelector.hxx Change-Id: I802cdc0b77027bbe0843fbb259ce1a5a46354fc3 diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx index 860db64..458bba4 100644 --- a/sd/inc/CustomAnimationEffect.hxx +++ b/sd/inc/CustomAnimationEffect.hxx @@ -55,7 +55,6 @@ namespace sd { enum EValue { VALUE_FROM, VALUE_TO, VALUE_BY, VALUE_FIRST, VALUE_LAST }; class CustomAnimationEffect; -class AnimationTrigger; class CustomAnimationPreset; typedef
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 2 commits - configure.in languagetool/JLanguageTool-1.4.0-no-hc.patch languagetool/JLanguageTool-1.4.0.patch languagetool/JLanguageTool-1.7.0.patch
configure.in |2 languagetool/JLanguageTool-1.4.0-no-hc.patch |8 - languagetool/JLanguageTool-1.4.0.patch | 117 --- languagetool/JLanguageTool-1.7.0.patch | 159 +++ languagetool/makefile.mk |8 - ooo.lst.in |2 6 files changed, 169 insertions(+), 127 deletions(-) New commits: commit 97bc134310fe8ac07beace92b41e692603b86dc6 Author: Andras Timar ati...@suse.com Date: Fri Jun 29 15:42:42 2012 +0200 Update LanguageTool to version 1.7 + passive registration Change-Id: I43c6235546976f6d17bcd782b370e9fa2264f2b6 diff --git a/languagetool/JLanguageTool-1.4.0-no-hc.patch b/languagetool/JLanguageTool-1.4.0-no-hc.patch index 0078cf8..ea32087 100644 --- a/languagetool/JLanguageTool-1.4.0-no-hc.patch +++ b/languagetool/JLanguageTool-1.4.0-no-hc.patch @@ -1,5 +1,5 @@ misc/JLanguageTool-1.4.0/build.xml 2012-02-29 22:18:05.118789546 +0100 -+++ misc/build/JLanguageTool-1.4.0/build.xml 2012-02-29 22:17:02.385235706 +0100 +--- misc/JLanguageTool-1.7.0/build.xml 2012-02-29 22:18:05.118789546 +0100 misc/build/JLanguageTool-1.7.0/build.xml 2012-02-29 22:17:02.385235706 +0100 @@ -82,7 +82,6 @@ include name=openoffice/Linguistic.xcu/ include name=openoffice/description.xml/ @@ -8,8 +8,8 @@ include name=openoffice/images/LanguageToolBig.png/ include name=openoffice/images/LanguageToolSmall.png/ include name=openoffice/images/dialog.png/ misc/JLanguageTool-1.4.0/openoffice/Linguistic.xcu 2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/openoffice/Linguistic.xcu 2012-02-29 22:17:25.551071099 +0100 +--- misc/JLanguageTool-1.7.0/openoffice/Linguistic.xcu 2011-06-26 20:29:43.0 +0200 misc/build/JLanguageTool-1.7.0/openoffice/Linguistic.xcu 2012-02-29 22:17:25.551071099 +0100 @@ -27,9 +27,6 @@ prop oor:name=SpellAndGrammarDialogImage oor:type=xs:string value%origin%/images/dialog.png/value diff --git a/languagetool/JLanguageTool-1.4.0.patch b/languagetool/JLanguageTool-1.4.0.patch deleted file mode 100644 index 26afc30..000 --- a/languagetool/JLanguageTool-1.4.0.patch +++ /dev/null @@ -1,117 +0,0 @@ -diff -Naur misc/JLanguageTool-1.4.0//build.properties misc/build/JLanguageTool-1.4.0/build.properties misc/JLanguageTool-1.4.0//build.properties 2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/build.properties2011-08-25 18:22:31.305870800 +0200 -@@ -50,10 +50,10 @@ - ext.log4j.lib = ${ext.dir}/build/cobertura/log4j-1.2.9.jar - ext.jakarta-oro.lib = ${ext.dir}/build/cobertura/jakarta-oro-2.0.8.jar - --ext.ooo.juh.lib = ${ext.ooo.dir}/juh.jar --ext.ooo.unoil.lib = ${ext.ooo.dir}/unoil.jar --ext.ooo.ridl.lib = ${ext.ooo.dir}/ridl.jar --ext.ooo.jurt.lib = ${ext.ooo.dir}/jurt.jar -+ext.ooo.juh.lib = ${solver.ooo.dir}/juh.jar -+ext.ooo.unoil.lib = ${solver.ooo.dir}/unoil.jar -+ext.ooo.ridl.lib = ${solver.ooo.dir}/ridl.jar -+ext.ooo.jurt.lib = ${solver.ooo.dir}/jurt.jar - - build.meta-inf = ${build.dir}/META-INF - final.name = LanguageTool -diff -Naur misc/JLanguageTool-1.4.0//build.xml misc/build/JLanguageTool-1.4.0/build.xml misc/JLanguageTool-1.4.0//build.xml2011-06-26 20:29:43.0 +0200 -+++ misc/build/JLanguageTool-1.4.0/build.xml 2011-08-25 18:26:51.816771100 +0200 -@@ -24,6 +24,8 @@ - pathelement location=${ext.jakarta-regex.lib} / - pathelement location=${ext.segment.lib} / - !-- -- -+ pathelement location=${ext.junit.lib}/ -+ !-- -- - pathelement location=${ext.ooo.juh.lib} / - pathelement location=${ext.ooo.unoil.lib} / - pathelement location=${ext.ooo.ridl.lib} / -@@ -390,11 +392,11 @@ - !-- == -- - - target name=dist depends=ooo-internal description=Builds one ZIP for both OpenOffice.org and stand-alone use --zip compress=yes destfile=${dist.dir}/LanguageTool-${version}.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / -+zip compress=yes destfile=${dist.dir}/LanguageTool.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / - /target - - target name=fast depends=ooo-internal description=like dist, but without ZIP compression (for development only) --zip compress=no destfile=${dist.dir}/LanguageTool-${version}.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / -+zip compress=no destfile=${dist.dir}/LanguageTool.oxt basedir=${dist.dir} includes=** excludes=deploy.sh,undeploy.sh,turn.sh,printlocales.jar / - /target - - target
[Libreoffice-commits] .: offapi/com svx/inc sw/inc sw/source
offapi/com/sun/star/style/PageProperties.idl | 12 ++ svx/inc/svx/svxids.hrc |1 sw/inc/cmdid.h |2 + sw/inc/pagedesc.hxx | 11 + sw/inc/unoprnms.hxx |5 +++- sw/source/core/doc/docdesc.cxx |2 + sw/source/core/layout/pagedesc.cxx | 31 ++- sw/source/core/unocore/unomap.cxx|2 + sw/source/core/unocore/unoprnms.cxx |2 + sw/source/core/unocore/unostyle.cxx | 17 ++ sw/source/ui/utlui/uitool.cxx| 12 ++ 11 files changed, 95 insertions(+), 2 deletions(-) New commits: commit 5b021a1f0d281aed40ae83dffe4af7600b858bd5 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jun 29 11:26:13 2012 +0200 sw: initial HeaderIsSharedFirst / FooterIsSharedFirst It's just like HeaderIsShared / FooterIsShared, enabled by default when header / footer is on. It does nothing yet, but it's read-writable. Motivation: https://wiki.oasis-open.org/office/HeaderFooterFirst Change-Id: I1ccfd0aedd1ac71e9f39b7fd43754264afafc1ef diff --git a/offapi/com/sun/star/style/PageProperties.idl b/offapi/com/sun/star/style/PageProperties.idl index b0da251..ebd7b49 100644 --- a/offapi/com/sun/star/style/PageProperties.idl +++ b/offapi/com/sun/star/style/PageProperties.idl @@ -258,6 +258,12 @@ published service PageProperties */ [property, maybevoid] boolean HeaderIsShared; //- +/** determines if the header content on the first page and remaining pages is the same. + +@since LibreOffice 3.7 + */ +[optional, property, maybevoid] boolean HeaderIsSharedFirst; +//- /** contains the height of the header. */ [property, maybevoid] long HeaderHeight; @@ -364,6 +370,12 @@ published service PageProperties */ [property, maybevoid] boolean FooterIsShared; //- +/** determines if the footer content on the first page and remaining pages is the same. + +@since LibreOffice 3.7 + */ +[optional, property, maybevoid] boolean FooterIsSharedFirst; +//- /** determines the height of the footer. */ [property, maybevoid] long FooterHeight; diff --git a/svx/inc/svx/svxids.hrc b/svx/inc/svx/svxids.hrc index 918d44d..db8753e 100644 --- a/svx/inc/svx/svxids.hrc +++ b/svx/inc/svx/svxids.hrc @@ -956,6 +956,7 @@ #define SID_INSERT_FORM_VSCROLL (SID_SVX_START+) #define SID_INSERT_FORM_HSCROLL (SID_SVX_START+1112) #define SID_EXTERNAL_EDIT (SID_SVX_START+1113) +#define SID_ATTR_PAGE_SHARED_FIRST (SID_SVX_START+1114) // IMPORTANT NOTE: adjust SID_SVX_FIRSTFREE, when adding new slot id #define SID_SVX_FIRSTFREE (SID_EXTERNAL_EDIT + 1) diff --git a/sw/inc/cmdid.h b/sw/inc/cmdid.h index 2262521..97ebfc5 100644 --- a/sw/inc/cmdid.h +++ b/sw/inc/cmdid.h @@ -863,6 +863,8 @@ included in c-context files, so c++ style stuff will cause problems. #define FN_MATH_BASELINE_ALIGNMENT (FN_EXTRA2 + 115) #define FN_EMBEDDED_OBJECT (FN_EXTRA2 + 116) +#define FN_UNO_HEADER_SHARE_FIRST_CONTENT (FN_EXTRA2 + 117) +#define FN_UNO_FOOTER_SHARE_FIRST_CONTENT (FN_EXTRA2 + 118) /* Area: Help diff --git a/sw/inc/pagedesc.hxx b/sw/inc/pagedesc.hxx index 44367f5..08e55c0 100644 --- a/sw/inc/pagedesc.hxx +++ b/sw/inc/pagedesc.hxx @@ -133,6 +133,10 @@ namespace nsUseOnPage const UseOnPage PD_FOOTERSHARE= 0x0080; const UseOnPage PD_NOHEADERSHARE = 0x00BF; // For internal use only. const UseOnPage PD_NOFOOTERSHARE = 0x007F; // For internal use only. +const UseOnPage PD_HEADERSHAREFIRST = 0x0100; +const UseOnPage PD_NOHEADERSHAREFIRST = 0xFEFF; +const UseOnPage PD_FOOTERSHAREFIRST = 0x0200; +const UseOnPage PD_NOFOOTERSHAREFIRST = 0xFDFF; } class SW_DLLPUBLIC SwPageDesc : public SwModify @@ -144,6 +148,7 @@ class SW_DLLPUBLIC SwPageDesc : public SwModify SvxNumberType aNumType; SwFrmFmtaMaster; SwFrmFmtaLeft; +SwFrmFmtaFirst; SwDependaDepend;// Because of grid alignment (Registerhaltigkeit). SwPageDesc *pFollow; sal_uInt16 nRegHeight; // Sentence spacing and fontascent of style. @@ -183,6 +188,10 @@ public: inline sal_Bool IsFooterShared() const; inline void ChgHeaderShare( sal_Bool bNew ); inline void ChgFooterShare( sal_Bool bNew ); +sal_Bool IsHeaderSharedFirst() const; +void ChgHeaderShareFirst( sal_Bool bNew ); +sal_Bool
[Libreoffice-commits] .: sw/source
sw/source/core/unocore/unostyle.cxx |1 - 1 file changed, 1 deletion(-) New commits: commit 73202f8edc074ec035255d25ff29bfd4a8d8dfd6 Author: Miklos Vajna vmik...@suse.cz Date: Fri Jun 29 16:03:22 2012 +0200 SwXStyleFamily::getPropertySetInfo: remove useless OSL_FAIL When poking around using an xray-like tool, it's quite expected that this method is reached. Change-Id: Ie795bbb06df740d853065d21c838e10a55ff34c6 diff --git a/sw/source/core/unocore/unostyle.cxx b/sw/source/core/unocore/unostyle.cxx index d43d6fc..1795c16 100644 --- a/sw/source/core/unocore/unostyle.cxx +++ b/sw/source/core/unocore/unostyle.cxx @@ -967,7 +967,6 @@ void SwXStyleFamily::removeByName(const OUString rName) throw( container::NoSuc uno::Reference beans::XPropertySetInfo SAL_CALL SwXStyleFamily::getPropertySetInfo( ) throw (uno::RuntimeException) { -OSL_FAIL( ###unexpected! ); return uno::Reference beans::XPropertySetInfo (); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/core/doc/docfmt.cxx |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) New commits: commit 9628c1b52a4cba8464962d77a65fe1a559cfd42a Author: Miklos Vajna vmik...@suse.cz Date: Fri Jun 29 16:06:11 2012 +0200 SwDoc::CopyPageDesc: sal_Bool - bool Change-Id: I146e4b8c1e174a20dd9524c63bcb6aa0d09849de diff --git a/sw/source/core/doc/docfmt.cxx b/sw/source/core/doc/docfmt.cxx index bbf3c76..b18f21f 100644 --- a/sw/source/core/doc/docfmt.cxx +++ b/sw/source/core/doc/docfmt.cxx @@ -2041,7 +2041,7 @@ void SwDoc::CopyPageDescHeaderFooterImpl( bool bCpyHeader, void SwDoc::CopyPageDesc( const SwPageDesc rSrcDesc, SwPageDesc rDstDesc, sal_Bool bCopyPoolIds ) { -sal_Bool bNotifyLayout = sal_False; +bool bNotifyLayout = false; SwRootFrm* pTmpRoot = GetCurrentLayout();//swmod 080219 rDstDesc.SetLandscape( rSrcDesc.GetLandscape() ); @@ -2049,7 +2049,7 @@ void SwDoc::CopyPageDesc( const SwPageDesc rSrcDesc, SwPageDesc rDstDesc, if( rDstDesc.ReadUseOn() != rSrcDesc.ReadUseOn() ) { rDstDesc.WriteUseOn( rSrcDesc.ReadUseOn() ); -bNotifyLayout = sal_True; +bNotifyLayout = true; } if( bCopyPoolIds ) @@ -2072,7 +2072,7 @@ void SwDoc::CopyPageDesc( const SwPageDesc rSrcDesc, SwPageDesc rDstDesc, CopyPageDesc( *rSrcDesc.GetFollow(), *pFollow ); } rDstDesc.SetFollow( pFollow ); -bNotifyLayout = sal_True; +bNotifyLayout = true; } // the header and footer attributes are copied seperately ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] cleanup java code and update to Java5, including generics (36)
Hi Noel, On Fri, 2012-06-29 at 11:03 +0200, Noel Grandin wrote: This patch series primarily updates our java code to use the new features in Java5, which means generics. Along the way I also cleaned up some javadoc warnings, and a few other things. Nice :-) Because of the size of this patch series (3MB total), I have pushed the files via YouSendIt links. Sigh - that is -really- unpleasant to deal with at least for me; a single tar-ball with a single file to download and unpack would be good (via sendit or whatever) but the click, click, scroll, click click for each of these patches is rather a nightmare. Any chance of an archive instead ? I don't appear to be able to sed a direct link that I can wget for each one out of that either sadly ... Also - I'd really like to re-base the .java files on the ALv2 base before merging this - if I could get at the patches, I could start on that now but ... Could you just mail them to me directly ? [ archived they'll be smaller too ;-]. Thanks anyhow ! :-) it's great to have cleanups. All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On Fri, 2012-06-29 at 15:04 +0200, Miklos Vajna wrote: On Fri, Jun 29, 2012 at 01:47:58PM +0100, Caolán McNamara caol...@redhat.com wrote: I mean that a huge amount of people use the en_US locale as their default I want everything in English even though I'm not in the US locale[1] But that is just plain wrong IMHO, LC_MESSAGES=C can be used to get everything in English without screwing up LANG. Agreed, of course, but its what people do, and then moan endlessly about their en_US defaults :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: android/experimental
android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java | 206 +- android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java | 54 +- android/experimental/LibreOffice4Android/src/org/libreoffice/ui/LibreOfficeUIActivity.java |2 3 files changed, 146 insertions(+), 116 deletions(-) New commits: commit 5f091e66d74b27430260e743e354b1a843213f11 Author: Michael Meeks michael.me...@suse.com Date: Fri Jun 29 15:50:22 2012 +0100 android: cleanup the file extension guessing and expand it for prettiness diff --git a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java index 2195caf..a76d45b 100644 --- a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java +++ b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java @@ -1,3 +1,11 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ package org.libreoffice.ui; import org.libreoffice.R; @@ -5,106 +13,121 @@ import org.libreoffice.R; import java.io.File; import java.io.FileFilter; import java.io.FilenameFilter; +import java.util.Map; import java.util.Arrays; +import java.util.HashMap; import java.util.Comparator; +import android.util.Log; public class FileUtilities { - - static final int ALL = -1; - static final int DOC = 0; - static final int CALC = 1; - static final int IMPRESS = 2; - - static final int SORT_AZ = 0; - static final int SORT_ZA = 1; - /** Oldest Files First*/ - static final int SORT_OLDEST = 2; - /** Newest Files First*/ - static final int SORT_NEWEST = 3; - /** Largest Files First */ - static final int SORT_LARGEST = 4; - /** Smallest Files First */ - static final int SORT_SMALLEST = 5; - - private static String[] fileExtensions = {.odt,.ods,.odp}; - - static boolean isDoc(String filename){ - if( filename.endsWith( fileExtensions[ DOC ] ) ){ - return true; - } - return false; - } - - static boolean isCalc(String filename){ - if( filename.endsWith( fileExtensions[ CALC ] ) ){ - return true; - } - return false; - } - - static boolean isImpress(String filename){ - if( filename.endsWith( fileExtensions[ IMPRESS ] ) ){ - return true; - } +static final int ALL = -1; +static final int DOC = 0; +static final int CALC = 1; +static final int IMPRESS = 2; +static final int DRAWING = 3; +static final int UNKNOWN = 10; + +static final int SORT_AZ = 0; +static final int SORT_ZA = 1; +/** Oldest Files First*/ +static final int SORT_OLDEST = 2; +/** Newest Files First*/ +static final int SORT_NEWEST = 3; +/** Largest Files First */ +static final int SORT_LARGEST = 4; +/** Smallest Files First */ +static final int SORT_SMALLEST = 5; + +private static final MapString,Integer mExtnMap = new HashMapString,Integer(); +static { +mExtnMap.put(.odt, DOC); +mExtnMap.put(.sxw, DOC); +mExtnMap.put(.rtf, DOC); +mExtnMap.put(.doc, DOC); +mExtnMap.put(.docx, DOC); +mExtnMap.put(.html, DOC); +mExtnMap.put(.txt, DOC); + +mExtnMap.put(.ods, CALC); +mExtnMap.put(.sxc, CALC); +mExtnMap.put(.xls, CALC); +mExtnMap.put(.xlsx, CALC); + +mExtnMap.put(.odp, IMPRESS); +mExtnMap.put(.sxi, IMPRESS); +mExtnMap.put(.ppt, IMPRESS); +mExtnMap.put(.pptx, IMPRESS); + +mExtnMap.put(.vsd, DRAWING); + // FIXME: we need to expand this ... +} + +private static final String getExtension(String filename) +{ + int nExt = filename.lastIndexOf('.'); + if (nExt 0) + return ; + return filename.substring(nExt); +} + +private static final int lookupExtension(String filename) +{ + String extn = getExtension (filename); + if (!mExtnMap.containsKey(extn)) + return UNKNOWN; + return mExtnMap.get (extn); +} + +static int getType(String filename) +{ + int type = lookupExtension (filename); + android.util.Log.d(debug, extn : + filename + - + type); + return type; +} + +// Filter by mode, and/or in future by filename/wildcard +static private boolean doAccept(String
Re: minutes of ESC call ...
On Fri, 2012-06-29 at 14:51 +0200, Noel Grandin wrote: On 2012-06-29 14:47, Caolán McNamara wrote: I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. Maybe we should have some way of marking bugs in in-progress or experimental ? Maybe just push bugs that have incomplete patches into NEEDSINFO state? We could use whiteboard for that I guess; it's a shame to be looking at the same experimental patches again when I spent that time a few months back already. I tried to subset to only 25 from the 60 by doing some 'something changed since' that date in my monster query. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: android/experimental
android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java |5 + android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java |2 +- 2 files changed, 6 insertions(+), 1 deletion(-) New commits: commit 98ec4db47a402a4d4811ecacd910a347c4e1689e Author: Michael Meeks michael.me...@suse.com Date: Fri Jun 29 16:04:01 2012 +0100 android: add more extensions, fix build issue diff --git a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java index a76d45b..40975f8 100644 --- a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java +++ b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/FileUtilities.java @@ -47,6 +47,9 @@ public class FileUtilities { mExtnMap.put(.docx, DOC); mExtnMap.put(.html, DOC); mExtnMap.put(.txt, DOC); +mExtnMap.put(.wpd, DOC); +mExtnMap.put(.wps, DOC); +mExtnMap.put(.lwp, DOC); mExtnMap.put(.ods, CALC); mExtnMap.put(.sxc, CALC); @@ -58,7 +61,9 @@ public class FileUtilities { mExtnMap.put(.ppt, IMPRESS); mExtnMap.put(.pptx, IMPRESS); +mExtnMap.put(.svg, DRAWING); mExtnMap.put(.vsd, DRAWING); +mExtnMap.put(.wpg, DRAWING); // FIXME: we need to expand this ... } diff --git a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java index 52ff99e..1c20249 100644 --- a/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java +++ b/android/experimental/LibreOffice4Android/src/org/libreoffice/ui/GridItemAdapter.java @@ -92,7 +92,7 @@ public class GridItemAdapter extends BaseAdapter{ case FileUtilities.CALC: imageView.setImageResource(R.drawable.calc); break; - case FileUtilities.DRAW: // FIXME: only for now ... + case FileUtilities.DRAWING: // FIXME: only for now ... case FileUtilities.IMPRESS: imageView.setImageResource(R.drawable.impress); break; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PATCH] cleanup java code and update to Java5, including generics (36)
On Fri, 2012-06-29 at 15:19 +0100, Michael Meeks wrote: Also - I'd really like to re-base the .java files on the ALv2 base before merging this - if I could get at the patches, I could start on that now but ... Actually; now I look at the situation, it's no-where near as bad as I feared :-) this shouldn't need to block anything vs. master. Sorry for the noise ! Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On Thu, Jun 28, 2012 at 11:16 AM, Eike Rathke er...@redhat.com wrote: Hi Daniel, On Wednesday, 2012-06-27 16:34:38 -0500, Daniel Bankston wrote: When ScInterpreter::Interpret() is called multiple times, I assume that each call is for each formula cell, although I have not thoroughly verified this. Your assumption is correct. Does this mean we are indeed unnecessarily recalculating formula results even though we have imported formula results at our disposal? As discussed on IRC yesterday, yes and no.. unnecessarily if we could trust all results are identical to what we would calculate, including modifications that might had been done by other processors and differences that may result from improved algorithms / changed behavior in our own code. So, a possible solution could be to set formula cells dirty only if the content of the meta:generator element differs from the current office version. What I think we should do eventually is to prompt the user on whether or not to do a full re-calc when the generator and the loader and their versions differ. I'm sure we all agree that, using the cached formula results is safe if the generator and the loader (and their versions) match. But doing a full re-calc in *all* other cases unconditionally to me is an over-kill. We should leave that decision up to the user, with a sensible default for those who don't really care. That said, doing what Eike suggests will be a good intermediate step even if we decide to prompt the user in the end. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On 06/29/2012 10:39 AM, Kohei Yoshida wrote: That said, doing what Eike suggests will be a good intermediate step even if we decide to prompt the user in the end. So does that mean this is my next task? :-) --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On Fri, Jun 29, 2012 at 11:43 AM, Daniel Bankston daniel.dev.libreoff...@gmail.com wrote: On 06/29/2012 10:39 AM, Kohei Yoshida wrote: That said, doing what Eike suggests will be a good intermediate step even if we decide to prompt the user in the end. So does that mean this is my next task? :-) Not knowing what you are working on at the moment (sorry, been away for far too long), it could be your next task if you don't have anything else more urgent. Kohei ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: overview of localization
On Thu, 2012-06-28 at 16:27 +0200, Andras Timar wrote: You need translate-toolkit (http://translate.sourceforge.net/wiki/toolkit/index). Create pot files from en-US.sdf: $ oo2po -P workdir/unxlngi6.pro/CustomTarget/translations/translate/sdf-template/en-US.sdf workdir/unxlngi6.pro/CustomTarget/translations/translate/pot Then update languages, e.g. $ cd translations/source/ $ for in de fr it;do pomigrate2 $i $i.new workdir/unxlngi6.pro/CustomTarget/translations/translate/pot;rm -rf $i;mv $i.new $i;done That should work for local testing purposes. Great, thanks. Worked, got my translatables extracted anyway. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: EasyHack #41291 playterm build session
Hi Bjoern, I could not upload to playterm.org. I believe it is due to the size of the file. I will start all over the process. This file I have sent you contain almost 6 hours of build time. I believe, I could make one shorter by just teaching how to get the first build one and how to get the dependencies. I believe something like at most 45 minutes (including the time spent on git during downloading the main repo). I will do this by the end of this weekend. Thanks a lot for your comments. Best regards, Pietro De: Bjoern Michaelsen bjoern.michael...@canonical.com Para: Pietro F. Menna pietrome...@yahoo.com Cc: libreoffice@lists.freedesktop.org Enviadas: Sexta-feira, 29 de Junho de 2012 9:52 Assunto: EasyHack #41291 playterm build session Hi Pietro, (copying the dev-list for better visibilty) On Thu, Jun 28, 2012 at 07:45:09PM -0700, Pietro F. Menna wrote: I'm writing to you because you are the Core Developer from libreoffice which should be copied in the resolution of the entry 41291 from link below: https://bugs.freedesktop.org/show_bug.cgi?id=41291 Awesome! Great work! What I understood it was asked in this case was to make a ttyrecord of how to build libreoffice. I just made it and recorded the full session from a fresh Ubuntu 12.04 install. So in this case people will also be able to watch the dependencies before building. How long does that take? I assume it is rather quick, right? I also got into some issues while building, so those can be seen and checked how I troubleshooted it. Heh, oh, cool. I wonder however, if we want to keep those. While it might help newcomers who to see how to fix common problems, we do not want to scare away new contributors with stuff that ususally doesnt happen. ;) Since the build generetes a lot of log, the ttyrecord file got a bit large. So I gzipped and I have attached to this email so you can review it. If you would like me to do it again from a fresh start, I would have no problem at all. Please feel free to send your comments and I will review it. Could you upload that as-is at http://playterm.org/ so we have a starting point there (and to see if the file is too large for playterm)? That would be great. And yes, having a recording of a simple, straightforward build would be even better in the long run, so once this thing is uploaded, it would be cool if you would have another streamlined try. But lets start with what you have first ;) Best, Bjoern___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On 06/29/2012 10:47 AM, Kohei Yoshida wrote: Not knowing what you are working on at the moment (sorry, been away for far too long), it could be your next task if you don't have anything else more urgent. The last thing I worked on was avoiding recalculating row heights during ODS import and instead use row heights imported from the document. I think I cc'd you on that, but you just got back so you probably haven't had a chance to go through all the spam I cc'd you on. :-) It seemed that the row heights were being recalculated twice and then the row heights were also being imported. So I just changed it to where the row heights were being imported only. However, Eike brought up some interesting concerns about this change. The last few days Markus had me starting to get familiar with callgrind and looking at performance related bugs on bugzilla for ODS import. We also had the discussion about whether or not to recalculate cell formulas. I think Markus wanted to wait until you go back before assigning me any more major tasks. While there were no bugzilla bugs directly related to ODS import performance, Markus did find https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about performance while calc is already running, and may be closely related to our discussion about ScInterpreter::Interpret() and recalculating cell formulas. So I think I can work on both fdo47106 and using imported formula results for now, unless you guys think otherwise. --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On 06/29/2012 11:20 AM, Daniel Bankston wrote: While there were no bugzilla bugs directly related to ODS import performance, Markus did find https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about performance while calc is already running, and may be closely related to our discussion about ScInterpreter::Interpret() and recalculating cell formulas. It also deals with row heights. --Daniel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: EasyHack #41291 playterm build session
On Fri, Jun 29, 2012 at 09:16:34AM -0700, Pietro F. Menna wrote: Hi Bjoern, I could not upload to playterm.org. I believe it is due to the size of the file. I will start all over the process. This file I have sent you contain almost 6 hours of build time. I believe, I could make one shorter by just teaching how to get the first build one and how to get the dependencies. I believe something like at most 45 minutes (including the time spent on git during downloading the main repo). I will do this by the end of this weekend. Another thing to look into is to do the build itself inside of tmux or gnu screen: http://tmux.sourceforge.net/ http://www.gnu.org/software/screen/ that would allow you to not having to record all the output of the build, but still being able to take a look at the progress ... I dont know, if and how those work together with ttyrecord though, so just a thought ... Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: ScInterpreter::Interpret() backtraces during ODS import
On 06/29/2012 12:20 PM, Daniel Bankston wrote: The last thing I worked on was avoiding recalculating row heights during ODS import and instead use row heights imported from the document. I think I cc'd you on that, but you just got back so you probably haven't had a chance to go through all the spam I cc'd you on. :-) It seemed that the row heights were being recalculated twice and then the row heights were also being imported. So I just changed it to where the row heights were being imported only. However, Eike brought up some interesting concerns about this change. IIRC there was some very old weirdness wrt calculating the position and size of drawing objects requiring excessive calculation and re-calculation of row heights. We need to take another look at this to see if that's still a concern since we re-worked Calc's drawing object handling (including cell note positions). While there were no bugzilla bugs directly related to ODS import performance, Markus did find https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about performance while calc is already running, and may be closely related to our discussion about ScInterpreter::Interpret() and recalculating cell formulas. Yes. Calculating row heights is a very expensive operation, and while the bug report says it's not related to the import, the poor performance of row height calculation does affect both run-time and load performance. I took a brief look at that many years ago, but it wasn't something that could be improved easily. Having said that, maybe we should take another look at this since we are already on it. Getting a callgrind profile data will be the first step toward addressing this. So I think I can work on both fdo47106 and using imported formula results for now, unless you guys think otherwise. Yup, that sounds like a good plan. Thanks, Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/tubes2' - 5 commits - sc/source tubes/inc
sc/source/ui/collab/contacts.cxx | 29 + sc/source/ui/collab/contacts.hxx |2 +- sc/source/ui/collab/sendfunc.cxx |6 +- sc/source/ui/collab/sendfunc.hxx |1 - sc/source/ui/view/cellsh3.cxx|4 ++-- tubes/inc/tubes/manager.hxx |1 + 6 files changed, 26 insertions(+), 17 deletions(-) New commits: commit 9fb21707db92e051493a3e959308a37112d32ffe Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Jun 29 19:30:46 2012 +0200 tubes: fallback to master mode when not possible to init TeleManager as slave diff --git a/sc/source/ui/collab/contacts.cxx b/sc/source/ui/collab/contacts.cxx index 7ef5ab0..0c70585 100644 --- a/sc/source/ui/collab/contacts.cxx +++ b/sc/source/ui/collab/contacts.cxx @@ -76,7 +76,18 @@ class TubeContacts : public ModelessDialog pSender = new ScDocFuncSend( *pScDocShell, pReceiver ); pDocFunc = pSender; } -pSender-InitTeleManager( false ); +// This is a hack to work around: +// `error registering client handler: Name +// 'org.freedesktop.Telepathy.Client.LibreOffice' already in use by another process` +// This happens when there is already slave instance running, +// so we try to init TeleManager as master. +bool bIsMaster = false; +if (!pSender-InitTeleManager( bIsMaster )) +{ +fprintf( stderr, Trying to initialize TeleManager as master..\n ); +bIsMaster = true; +pSender-InitTeleManager( bIsMaster ); +} } void StartBuddySession() commit 26ff9e3b06efcefb1b9cda2b41378fcb23a01ece Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Jun 29 19:17:59 2012 +0200 tubes: unref TeleManager if we do not store the pointer diff --git a/sc/source/ui/collab/sendfunc.cxx b/sc/source/ui/collab/sendfunc.cxx index f58fd6a..9ab6e78 100644 --- a/sc/source/ui/collab/sendfunc.cxx +++ b/sc/source/ui/collab/sendfunc.cxx @@ -302,6 +302,7 @@ bool ScDocFuncSend::InitTeleManager( bool bIsMaster ) return true; } fprintf( stderr, Could not connect.\n ); +pManager-unref(); return false; } commit c81e93931f42567f4e662804129d97b6e0cfa0d7 Author: Matúš Kukan matus.ku...@gmail.com Date: Fri Jun 29 19:15:40 2012 +0200 tubes: use new TeleManager::get() method without parameter diff --git a/sc/source/ui/collab/contacts.cxx b/sc/source/ui/collab/contacts.cxx index bd6e6d4..7ef5ab0 100644 --- a/sc/source/ui/collab/contacts.cxx +++ b/sc/source/ui/collab/contacts.cxx @@ -132,9 +132,11 @@ public: RTL_TEXTENCODING_UTF8 ); } -void Populate( const TeleManager rManager ) +void Populate( const TeleManager *pManager ) { -ContactList *pContacts = rManager.getContactList(); +if (!pManager) +return ; +ContactList *pContacts = pManager-getContactList(); if ( pContacts ) { fprintf( stderr, contacts !\n ); @@ -193,11 +195,11 @@ IMPL_LINK_NOARG( TubeContacts, BtnListenHdl ) #endif namespace tubes { -void createContacts( const TeleManager rManager ) +void createContacts( const TeleManager *pManager ) { #ifdef CONTACTS_DLG TubeContacts *pContacts = new TubeContacts(); -pContacts-Populate( rManager ); +pContacts-Populate( pManager ); #endif } } diff --git a/sc/source/ui/collab/contacts.hxx b/sc/source/ui/collab/contacts.hxx index f7ff6a9..404a6fc 100644 --- a/sc/source/ui/collab/contacts.hxx +++ b/sc/source/ui/collab/contacts.hxx @@ -30,7 +30,7 @@ class TeleManager; namespace tubes { -void createContacts( const TeleManager rContacts ); +void createContacts( const TeleManager *pManager ); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/sc/source/ui/view/cellsh3.cxx b/sc/source/ui/view/cellsh3.cxx index 6d3fcf3..e10d5b5 100644 --- a/sc/source/ui/view/cellsh3.cxx +++ b/sc/source/ui/view/cellsh3.cxx @@ -60,7 +60,7 @@ #ifdef ENABLE_TELEPATHY #include tubes/manager.hxx namespace tubes { -void createContacts( const TeleManager rContacts ); +void createContacts( const TeleManager *pManager ); } #endif @@ -125,7 +125,7 @@ void ScCellShell::Execute( SfxRequest rReq ) case SID_COLLABORATION: #ifdef ENABLE_TELEPATHY -tubes::createContacts( TeleManager::get( true ) ); +tubes::createContacts( TeleManager::get() ); #endif break; diff --git a/tubes/inc/tubes/manager.hxx b/tubes/inc/tubes/manager.hxx index 1aba675..c780fd2 100644 --- a/tubes/inc/tubes/manager.hxx +++ b/tubes/inc/tubes/manager.hxx @@ -82,6 +82,7 @@ public: TeleManager( bool bAcceptIncoming = true, bool bCreateOwnGMainLoop = false ); ~TeleManager(); +static TeleManager *get() { return pSingleton; } static TeleManager *get( bool bAcceptIncoming ); voidunref(); commit 352c5e358dba7cd575c5579698b2fff348612926
Re: [Libreoffice-ux-advise] [PATCH] fdo#35365 default font color for documents
Am Mittwoch, den 27.06.2012, 10:56 +0200 schrieb Stefan Knorr: Hi all, I am not a user of high-contrast themes, and might not be able to help very much here. I am adding Christophe from a11y here who might be able to share some more ideas. So, High-Contrast... there are two types of high-contrast themes in most OS's, namely dark on light and light on dark. I think the users of the different types have different needs, too. Ooo, and thus, LibO generally cater to light on dark themes (as is evident in our hicontrast theme). Which incidentally, is the type of theme making trouble here. The question is: Should the theme influence the document? What does other application do? Does an image viewer increases the contrast of an image if the user uses a high-contrast theme? Does a PDF viewer displays a PDF file differently if the user uses a high-contrast theme? -- Benjamin Drung Debian Ubuntu Developer signature.asc Description: This is a digitally signed message part ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[GSoC 2012][Collaboration] Problems with replacing pDocFunc ?
Hello there, I've pushed a few new patches but I can't get the code in TubeContacts::Listen to work. Assume there is somewhere LIBO_TUBES=slave ./soffice --calc running. Now when you run LIBO_TUBES=master ./soffice --calc and start collaboration from menu, it's fine and everything should work. But I was hoping that also plain ./soffice --calc and pressing Listen in the File-Collaborate dialog and then starting Collaboration by pressing Collaborate from the dialog would work. It should somehow replace ScDocFuncDirect by ScDocFuncSend. But the collaboration works only one way. It can accept messages but not send. Maybe I can't replace pDocFunc just like that when calc is already running ? Any idea ? I hope it's possible to understand this e-mail. And also that you look out for my changes because I may be doing something else as I should do ;-) Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - cui/source
cui/source/inc/numpages.hxx | 13 cui/source/tabpages/numpages.cxx | 113 --- cui/source/tabpages/page.cxx | 21 +-- cui/source/tabpages/page.src | 28 +++-- 4 files changed, 110 insertions(+), 65 deletions(-) New commits: commit 88a083f8be05449630c9e2af30474281fd0d8af2 Author: Eike Rathke er...@redhat.com Date: Fri Jun 29 20:00:16 2012 +0200 fdo#42558 consolidated duplicated code * Moved almost identical code of SvxNumOptionsTabPage::SvxNumOptionsTabPage() and SvxPageDescPage::SvxPageDescPage() into static SvxNumOptionsTabPage::GetI18nNumbering() * Removed now unnecessary includes and using namespace directives Change-Id: I7babe68f2bb8af4fd227cbe558c34c7f85104a15 diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx index 5be85fb..cc89339 100644 --- a/cui/source/inc/numpages.hxx +++ b/cui/source/inc/numpages.hxx @@ -346,6 +346,19 @@ class SvxNumOptionsTabPage : public SfxTabPage ListBoxGetCharFmtListBox() {return aCharFmtLB;} voidSetModified(sal_Bool bRepaint = sal_True); virtual voidPageCreated(SfxAllItemSet aSet); + +/** Get the numberings provided by the i18n framework (CTL, Asian, ...) and +add them to the listbox. Extended numbering schemes present in the +resource and already in the listbox but not offered by the i18n +framework per configuration are removed. + +@param nDoNotRemove +A value that shall not be removed, i.e. the ugly 0x88 +(SVX_NUM_BITMAP|0x80) +Pass ::std::numeric_limitssal_uInt16::max() if there is no such +restriction. + */ +static void GetI18nNumbering( ListBox rFmtLB, sal_uInt16 nDoNotRemove ); }; // diff --git a/cui/source/tabpages/numpages.cxx b/cui/source/tabpages/numpages.cxx index 8936ebc..e909c17 100644 --- a/cui/source/tabpages/numpages.cxx +++ b/cui/source/tabpages/numpages.cxx @@ -1023,6 +1023,64 @@ IMPL_LINK_NOARG(SvxBitmapPickTabPage, LinkBmpHdl_Impl) return 0; } +// static +void SvxNumOptionsTabPage::GetI18nNumbering( ListBox rFmtLB, sal_uInt16 nDoNotRemove ) +{ + +ReferenceXDefaultNumberingProvider xDefNum = lcl_GetNumberingProvider(); +ReferenceXNumberingTypeInfo xInfo(xDefNum, UNO_QUERY); + +// Extended numbering schemes present in the resource but not offered by +// the i18n framework per configuration must be removed from the listbox. +// Do not remove a special entry matching nDoNotRemove. +const sal_uInt16 nDontRemove = 0x; +::std::vector sal_uInt16 aRemove( rFmtLB.GetEntryCount(), nDontRemove); +for (size_t i=0; iaRemove.size(); ++i) +{ +sal_uInt16 nEntryData = (sal_uInt16)(sal_uLong)rFmtLB.GetEntryData( +sal::static_int_cast sal_uInt16 (i)); +if (nEntryData NumberingType::CHARS_LOWER_LETTER_N nEntryData != nDoNotRemove) +aRemove[i] = nEntryData; +} +if(xInfo.is()) +{ +Sequencesal_Int16 aTypes = xInfo-getSupportedNumberingTypes( ); +const sal_Int16* pTypes = aTypes.getConstArray(); +for(sal_Int32 nType = 0; nType aTypes.getLength(); nType++) +{ +sal_Int16 nCurrent = pTypes[nType]; +if(nCurrent NumberingType::CHARS_LOWER_LETTER_N) +{ +sal_Bool bInsert = sal_True; +for(sal_uInt16 nEntry = 0; nEntry rFmtLB.GetEntryCount(); nEntry++) +{ +sal_uInt16 nEntryData = (sal_uInt16)(sal_uLong)rFmtLB.GetEntryData(nEntry); +if(nEntryData == (sal_uInt16) nCurrent) +{ +bInsert = sal_False; +aRemove[nEntry] = nDontRemove; +break; +} +} +if(bInsert) +{ +OUString aIdent = xInfo-getNumberingIdentifier( nCurrent ); +sal_uInt16 nPos = rFmtLB.InsertEntry(aIdent); +rFmtLB.SetEntryData(nPos,(void*)(sal_uLong)nCurrent); +} +} +} +} +for (size_t i=0; iaRemove.size(); ++i) +{ +if (aRemove[i] != nDontRemove) +{ +sal_uInt16 nPos = rFmtLB.GetEntryPos( (void*)(sal_uLong)aRemove[i]); +rFmtLB.RemoveEntry( nPos); +} +} +} + // tabpage numeration options #define NUM_NO_GRAPHIC 1000 SvxNumOptionsTabPage::SvxNumOptionsTabPage(Window* pParent, @@ -1113,60 +1171,9 @@ SvxNumOptionsTabPage::SvxNumOptionsTabPage(Window* pParent, FreeResource(); -//get advanced numbering types from the component -ReferenceXDefaultNumberingProvider xDefNum = lcl_GetNumberingProvider(); -ReferenceXNumberingTypeInfo xInfo(xDefNum, UNO_QUERY); - -// Extended numbering schemes
Re: ScInterpreter::Interpret() backtraces during ODS import
Hi Daniel, On Friday, 2012-06-29 11:27:16 -0500, Daniel Bankston wrote: https://bugs.freedesktop.org/show_bug.cgi?id=47106 which is about performance while calc is already running, and may be closely related to our discussion about ScInterpreter::Interpret() and recalculating cell formulas. It also deals with row heights. The underlying cause during editing the document is the extensive use of the OFFSET() function. I'll try to remove the volatility from that function. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpwfbLDue6rM.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PUSHED] Re: [PATCH] cleanup java code and update to Java5, including generics (36)
On 29/06/12 11:03, Noel Grandin wrote: Hi This patch series primarily updates our java code to use the new features in Java5, which means generics. Along the way I also cleaned up some javadoc warnings, and a few other things. After this patch, make check no longer generates any warnings from the java compiler about unchecked conversions. Because of the size of this patch series (3MB total), I have pushed the files via YouSendIt links. downloading 36 patches from there was no fun at all, please upload a tarball next time, or use gerrit (do you have an account already?). the patch Java cleanup - remove unused local variables does some silly things like -Short aShort = new Short((short) 1); +new Short((short) 1); but i guess it's difficult to automate removal of that, because the methods called could have side effects, or (in the unit tests) the called method is one of the methods that should be tested, so by calling it we know it doesn't crash. [PATCH 22/36] Java5 update - convert code to use generics [PATCH 36/36] Java5 updates - update code to use generics the above 2 patches seem to change interfaces of classes in ridljar and javaunohelper that are likely part of the stable URE ABI, and shouldn't be changed; i think adding type parameters is OK (after all the Java standard libraries had these retrofitted as well, and they don't exist at runtime anyway thanks to type erasure) but things like replacing Hashtable with Map is not OK, so i've reverted those parts. after applying the patches my javac 1.7.0 produced still some warnings like this, which i've fixed: /work/lo/master/wizards/com/sun/star/wizards/common/JavaTools.java:455: warning: unreachable catch clause catch (IOException e) ^ thrown type MalformedURLException has already been caught now there are some deprecation things left that javac doesn't want to show unless given some -Xlint parameter. but this is clearly an enormous improvement in terms of annoying warning output, thanks a lot, pushed to master. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: locales (was: minutes of ESC call ...)
Hi Eike, On Fri, Jun 29, 2012 at 05:25:51PM +0200, Eike Rathke er...@redhat.com wrote: But that is just plain wrong IMHO, LC_MESSAGES=C can be used to get everything in English without screwing up LANG. How many users know about a C locale? And how many know that there's LC_MESSAGES that can be set differently and how? An why should anyone choose C that doesn't even know utf-8? Nowadays you mostly choose a locale during installation and never touch it again. If you want an English system that usually results in LC_ALL and LANG set to en_US.UTF-8 then. I admit probably only a few users read man locale.conf (and probably I'm just too young if there was already such a manpage when I first met this problem ;-) ), on the other hand I still think this sounds like the proper way of solving the situation. By the way, as far as I understand man 7 locale, the LC_COLLATE determines the encoding (and if that's unset LANG), so LC_MESSAGES=C + a utf-8 LANG results in a configuration that knows utf-8. That's what I do as well despite living in de_DE, because my daily work happens in English environments (and I never understood why and how anyone can bear translated system and compiler messages ;-) and even Sure, I agree. :-) most data import involves en_US separators and so on. When I feel a need of nitpicking I can set paper and measurement and monetary and such to de_DE, but then again LibO handles only LC_PAPER of those. One of my motivations is that the KDE calendar this way still mentions our Hungarian public holidays (maybe GNOME does the same, no idea). And yes, a finer granularity of the LibO internal locales that takes also system settings into account is on my todo list. Nah, I didn't mean to criticise that, I just wanted to share that I think when one sets LANG to en_US and files a bugreport about a wrong default paper size, my answer would be you asked for it. Miklos ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||51555 --- Comment #34 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-29 14:09:51 PDT --- Add: Bug 51555 - FORMATTING Not possible to add Conditional formatting; basic function, affecting many users -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Importing from Mindview worth our time??
I try not to bug devs over these kinds of things but I came across one of these enhancement requests that I wanted to see what everyone thought. The request is to get IMPORT working for the software program MINDVIEW. I feel like we should close it as WONTFIX. Reasons: 1. The software isn't free which makes it a lot harder to do something like this (pricey to say the least). 2. # of users using this software + using LO must be low (must being a subjective term that just is my impression of it). 3. If we were to do this I think it would be so time consuming and difficult to do that we would miss out on doing a lot of the more functional enhancement requests 4. The list of Enhancements is in the hundreds, if this one just stays open it'll just be one of those UNCONFIRMED or NEW requests that sit around for years and never has any input. 5. Not one other user has posted on the bug since its creation 5+ months ago Here is the request: https://bugs.freedesktop.org/show_bug.cgi?id=44606list_id=88922 Thanks all, hope you all have a great weekend. Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
API Documentation - Since/Minimum Version
Hi All, Friendly discussion about if we can commit to putting a minimum version or a since on our API documentation. We've had a user put in a bug report (I closed as not a bug but thought it was valid anyways) that we don't consistently -- or more accurately, rarely ever -- put a minimum version with our API documentation. Here is the example he provided: http://api.libreoffice.org/common/ref/com/sun/star/table/BorderLine2.html Would this be possible for us to try to do? If so is there documentation somewhere that we need to update for new devs to look at when making API documentation that will now include a requirement for minimum version? Thanks all for the input Joel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - accessibility/source
accessibility/source/extended/AccessibleBrowseBox.cxx | 16 ++ accessibility/source/extended/AccessibleBrowseBoxBase.cxx | 11 -- accessibility/source/extended/AccessibleBrowseBoxHeaderBar.cxx |7 accessibility/source/extended/AccessibleBrowseBoxTable.cxx |4 -- accessibility/source/extended/AccessibleBrowseBoxTableBase.cxx |4 -- accessibility/source/extended/AccessibleBrowseBoxTableCell.cxx |2 - accessibility/source/extended/AccessibleGridControl.cxx |6 +-- accessibility/source/extended/AccessibleGridControlHeader.cxx |2 - accessibility/source/extended/accessiblebrowseboxcell.cxx |4 -- accessibility/source/extended/accessibleeditbrowseboxcell.cxx |9 - accessibility/source/extended/accessibleiconchoicectrl.cxx |5 --- accessibility/source/extended/accessibleiconchoicectrlentry.cxx |9 - accessibility/source/extended/accessiblelistbox.cxx |5 --- accessibility/source/extended/accessiblelistboxentry.cxx| 13 +--- accessibility/source/extended/accessibletabbar.cxx |5 --- accessibility/source/extended/accessibletabbarbase.cxx |6 +-- accessibility/source/extended/accessibletabbarpagelist.cxx |5 --- accessibility/source/extended/accessibletablistbox.cxx |6 --- accessibility/source/extended/accessibletablistboxtable.cxx | 10 +- accessibility/source/extended/listboxaccessible.cxx |6 +-- accessibility/source/standard/accessiblemenubasecomponent.cxx |5 +-- accessibility/source/standard/vclxaccessiblelistitem.cxx|6 --- accessibility/source/standard/vclxaccessiblemenubar.cxx |4 +- accessibility/source/standard/vclxaccessibletoolbox.cxx |5 --- accessibility/source/standard/vclxaccessibletoolboxitem.cxx |9 - 25 files changed, 27 insertions(+), 137 deletions(-) New commits: commit 3c1a1aacf5a1eac4b16c2a2eacbaf262e295d2a0 Author: Jacek Wolszczak shutdownrun...@gmail.com Date: Sun Aug 21 09:34:15 2011 +0200 fdo#39425: Remove DBG_NAME, DBG_CTOR, DBG_DTOR and debug.hxx in accessibility Change-Id: I194f776c298f6e149f8e30e82c4b591fed594d55 diff --git a/accessibility/source/extended/AccessibleBrowseBox.cxx b/accessibility/source/extended/AccessibleBrowseBox.cxx index 88782c7..06201e8 100644 --- a/accessibility/source/extended/AccessibleBrowseBox.cxx +++ b/accessibility/source/extended/AccessibleBrowseBox.cxx @@ -64,14 +64,11 @@ public: // Ctor/Dtor/disposing -DBG_NAME( AccessibleBrowseBox ) - AccessibleBrowseBox::AccessibleBrowseBox( const Reference XAccessible _rxParent, const Reference XAccessible _rxCreator, IAccessibleTableProvider _rBrowseBox ) : AccessibleBrowseBoxBase( _rxParent, _rBrowseBox,NULL, BBTYPE_BROWSEBOX ) { -DBG_CTOR( AccessibleBrowseBox, NULL ); m_pImpl.reset( new AccessibleBrowseBoxImpl() ); m_pImpl-m_aCreator = _rxCreator; @@ -90,7 +87,6 @@ void AccessibleBrowseBox::setCreator( const Reference XAccessible _rxCreator // - AccessibleBrowseBox::~AccessibleBrowseBox() { -DBG_DTOR( AccessibleBrowseBox, NULL ); } // - @@ -327,20 +323,16 @@ void AccessibleBrowseBox::commitHeaderBarEvent( sal_Int16 _nEventId, // // = AccessibleBrowseBoxAccess // -DBG_NAME( AccessibleBrowseBoxAccess ) -// - AccessibleBrowseBoxAccess::AccessibleBrowseBoxAccess( const Reference XAccessible _rxParent, IAccessibleTableProvider _rBrowseBox ) :m_xParent( _rxParent ) ,m_rBrowseBox( _rBrowseBox ) ,m_pContext( NULL ) { -DBG_CTOR( AccessibleBrowseBoxAccess, NULL ); } // - AccessibleBrowseBoxAccess::~AccessibleBrowseBoxAccess() { -DBG_DTOR( AccessibleBrowseBoxAccess, NULL ); } // - diff --git a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx index 4391ec5..de953a9 100644 --- a/accessibility/source/extended/AccessibleBrowseBoxBase.cxx +++ b/accessibility/source/extended/AccessibleBrowseBoxBase.cxx @@ -57,8 +57,6 @@ using namespace com::sun::star::accessibility::AccessibleStateType; // Ctor/Dtor/disposing -DBG_NAME( AccessibleBrowseBoxBase ) - AccessibleBrowseBoxBase::AccessibleBrowseBoxBase(
Re: minutes of ESC call ...
On 29/06/12 10:56, Michael Meeks wrote: * Pending Action Items + [pending] merge the new pretty templates in place of the old ugly ones (Michael S) hmm... how come the minutes say i am merging templates? i consider it unlikely that i said i would do such a thing, except possibly if i had a habit of talking in my sleep :) so probably somebody else wanted to do that (the topic that woke me up was that C++0x fiasco...) + new problems shown up with this - + Caolan has tool for templates to strip lang tags so it works + try template lang tag stripping tool + need to fix merge for Beta3 * gerrit update (Bjoern) + please review mst's patches for the -3-5 branch (mst) + only those in the reviewer field get mailed + not got a fire-hose to the ML yet vmiklos has done that :) * un-merged patches in bugzilla (Bjoern) + Bjoern worked on a few, many are already merged = just close them. + query of doom for the recent batch: https://bugs.freedesktop.org/buglist.cgi?chfieldto=Nowchfield=[Bug%20creation]chfield=aliaschfield=assigned_tochfield=cclist_accessiblechfield=componentchfield=deadlinechfield=everconfirmedchfield=rep_platformchfield=op_syschfield=prioritychfield=productchfield=qa_contactchfield=reporter_accessiblechfield=resolutionchfield=bug_severitychfield=bug_statuschfield=short_descchfield=target_milestonechfield=bug_file_locchfield=versionchfield=voteschfield=status_whiteboardquery_format=advancedchfieldfrom=2012-05-10list_id=88624field0-0-0=attachments.ispatchbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFObug_status=PLEASETESTtype0-0-0=equalsvalue0-0-0=1product=LibreOffice Caolan and me made some progress here (i've pushed 2 patches, mostly though reset attachment flags or resolved bug), now down to 49 bugs with patch. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
On Fri, 2012-06-29 at 23:57 +0200, Michael Stahl wrote: mostly though reset attachment flags what's your route here ? changing to non-patch/plain-text the experimental/dead stuff ? C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Importing from Mindview worth our time??
On Fri, 2012-06-29 at 14:11 -0700, Joel Madero wrote: I feel like we should close it as WONTFIX. Reasons: 5. Not one other user has posted on the bug since its creation 5+ months ago request: https://bugs.freedesktop.org/show_bug.cgi?id=44606list_id=88922 There isn't anything anything IMO anything very wrong about the bug, but I agree that it just isn't going to happen, unless someone happens to really take a sudden interest in it. In fedora we close still-open bugs reported against fedora versions three (or so) releases earlier than the current release with a if this still matters to you then test in the current version and reopen it if the problem persists. It's hardly an ideal solution, but it does avoid the accumulation of infinite amounts of bugs. Maybe this is the way to go: cull all bugs reported against versions = 3 older than the current release that haven't had any activity in X months with a polite request to retest that its still broken if it still matters with a few links to commercial support if there's an itch they really want scratched. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Importing from Mindview worth our time??
I am really hesitant to support just having so many bugs floating around like this. I think that marking as RESOLVED - WONTFIX enables devs to look at these if they are ever inclined to do so but makes it clear to the users that we won't be doing this (almost guaranteed). I think if we just keep asking them to update it we give them the hope that there is a chance when in fact there isn't, plus we add that we'll have bugs open for months (year(s)) that won't be fixed ever and then ultimately just go to WILLNOTFIX, when we knew that months prior to changing the status. Joel On Fri, Jun 29, 2012 at 3:31 PM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2012-06-29 at 14:11 -0700, Joel Madero wrote: I feel like we should close it as WONTFIX. Reasons: 5. Not one other user has posted on the bug since its creation 5+ months ago request: https://bugs.freedesktop.org/show_bug.cgi?id=44606list_id=88922 There isn't anything anything IMO anything very wrong about the bug, but I agree that it just isn't going to happen, unless someone happens to really take a sudden interest in it. In fedora we close still-open bugs reported against fedora versions three (or so) releases earlier than the current release with a if this still matters to you then test in the current version and reopen it if the problem persists. It's hardly an ideal solution, but it does avoid the accumulation of infinite amounts of bugs. Maybe this is the way to go: cull all bugs reported against versions = 3 older than the current release that haven't had any activity in X months with a polite request to retest that its still broken if it still matters with a few links to commercial support if there's an itch they really want scratched. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Hi, On 2012-06-29 at 23:57 +0200, Michael Stahl wrote: * Pending Action Items + [pending] merge the new pretty templates in place of the old ugly ones (Michael S) hmm... how come the minutes say i am merging templates? I believe it was Astron who volunteered (and probably Michael confused his voice with yours). Astron - is that correct? If yes, thanks so much in advance for looking into that! All the best, Kendy ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: minutes of ESC call ...
Hi all, hmm... how come the minutes say i am merging templates? i consider it Apparently, we sound alike..? Anyway, it was me who said that he'd try to help out there. Astron. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Importing from Mindview worth our time??
On Fri, 2012-06-29 at 15:36 -0700, Joel Madero wrote: I am really hesitant to support just having so many bugs floating around like this. I think that marking as RESOLVED - WONTFIX enables devs to look at these if they are ever inclined to do so but makes it clear to the users that we won't be doing this. Yup, I agree totally. Its not helpful to have loads of no-hoper bugs floating around. They should be closed with resolved-wontfix. My suggestion is only around the comment and criteria to use when closing them. e.g. here's our fedora-16 one http://fedoraproject.org/w/index.php?title=BugZappers/HouseKeeping/Fedora16#Comment_Text_2 So taking the fedora comment and adjusting it for us, it would look like... LibreOffice ''(major-version}'' changed to end-of-life (EOL) status on ''(date here)''. LibreOffice ''(major-version}'' is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of LibreOffice please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. so for us that would mean anything reported against 3.3.X and 3.4.X is up for mass-closing with the above. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] 51497
Hello LibreOffice, Please find attached a patch for bug 51497. My grateful thanks to Caolán for all his/her support. :) Best Regards, philhart 0001-Show-output-from-SELECT-statements-in-Execute-SQL-di.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Importing from Mindview worth our time??
One of my mein concerns is that we aren't keeping up with bug reports so we may close a bug at eol without anyone from QA or any developer ever looking at it. To me this seems unfair to the reporter. On Jun 29, 2012 4:00 PM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2012-06-29 at 15:36 -0700, Joel Madero wrote: I am really hesitant to support just having so many bugs floating around like this. I think that marking as RESOLVED - WONTFIX enables devs to look at these if they are ever inclined to do so but makes it clear to the users that we won't be doing this. Yup, I agree totally. Its not helpful to have loads of no-hoper bugs floating around. They should be closed with resolved-wontfix. My suggestion is only around the comment and criteria to use when closing them. e.g. here's our fedora-16 one http://fedoraproject.org/w/index.php?title=BugZappers/HouseKeeping/Fedora16#Comment_Text_2 So taking the fedora comment and adjusting it for us, it would look like... LibreOffice ''(major-version}'' changed to end-of-life (EOL) status on ''(date here)''. LibreOffice ''(major-version}'' is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of LibreOffice please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. so for us that would mean anything reported against 3.3.X and 3.4.X is up for mass-closing with the above. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Bug 6 depends on bug 51507, which changed state. Bug 51507 Summary: FILEOPEN 3.5 document: conditional formatting of type Formula is not recognized correctly, lost after saved https://bugs.freedesktop.org/show_bug.cgi?id=51507 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sc/source
sc/source/filter/xml/xmlcondformat.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit e8451dba20390387289765b112568166a5f411fe Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sat Jun 30 03:01:22 2012 +0200 the end of the formula is the closing bracket, fdo#51507 Change-Id: I2cc6505571ff62d3c161317b61033be0d7ec diff --git a/sc/source/filter/xml/xmlcondformat.cxx b/sc/source/filter/xml/xmlcondformat.cxx index a8fc8bb..ed9bc49 100644 --- a/sc/source/filter/xml/xmlcondformat.cxx +++ b/sc/source/filter/xml/xmlcondformat.cxx @@ -363,7 +363,7 @@ void GetConditionData(const rtl::OUString rValue, ScConditionMode eMode, rtl:: const sal_Unicode* pStr = rValue.getStr(); const sal_Unicode* pStart = pStr + 11; const sal_Unicode* pEnd = pStr + rValue.getLength(); -rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ','); +rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')'); eMode = SC_COND_DIRECT; } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/filter/xml/xmlcondformat.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 66018b9685dd7337daae9bb62ffeb43cd4161caf Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sat Jun 30 03:01:22 2012 +0200 the end of the formula is the closing bracket, fdo#51507 Change-Id: I2cc6505571ff62d3c161317b61033be0d7ec diff --git a/sc/source/filter/xml/xmlcondformat.cxx b/sc/source/filter/xml/xmlcondformat.cxx index a8fc8bb..ed9bc49 100644 --- a/sc/source/filter/xml/xmlcondformat.cxx +++ b/sc/source/filter/xml/xmlcondformat.cxx @@ -363,7 +363,7 @@ void GetConditionData(const rtl::OUString rValue, ScConditionMode eMode, rtl:: const sal_Unicode* pStr = rValue.getStr(); const sal_Unicode* pStart = pStr + 11; const sal_Unicode* pEnd = pStr + rValue.getLength(); -rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ','); +rExpr1 = ScXMLConditionHelper::getExpression( pStart, pEnd, ')'); eMode = SC_COND_DIRECT; } else ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-qa] minutes of ESC call ...
* Present: + Eike, Astron, Markus, Rainer, Michael, Kendy, Bjoern, Michael Stahl, Caolan, David, Cedric, Andras, Petr, Lionel * Completed Action Items + icons: poke Mango authors (Michael) + revert 3.6 to opaque background on Win7 (Kendy) * Pending Action Items + [pending] merge the new pretty templates in place of the old ugly ones (Michael S) + new problems shown up with this - + Caolan has tool for templates to strip lang tags so it works + try template lang tag stripping tool + need to fix merge for Beta3 + check new templates are using auto-fitting functionality (Thorsten) + notify all committers when we have a nice simple, minimal statement of what is required for gerrit written (Bjoern) * Ongoing Action Items: + https://gerrit.libreoffice.org/ - click 'register' (All hackers) + then poke Norbert by E-mail to get yourself setup a commiter / reviewer + the E-mail used for openID registration and user-account on is needed (cf. core/.git/config) * GSOC update (Cedric) + mid term evaluations arriving soon - start thinking about what to put + face-to-face mentor meeting in Berlin + submit a private GSOC mentors' BoF @ conference * Release Engineering update (Petr) + 3.5.5 status - RC2 + currently being pushed to mirrors; on-track + not aware of any blockers = final. + 3.5.6 planned for September: 2 months away - a lot ? + do another in August between 3.6.0 and 3.6.1 ? AI: + add to schedule (Petr) + 3.6 / Beta 3 + deadline Monday for final string / late-feature freeze + Beta 3 issue: template blocking - Michael S kindly took it. + last beta before 3x release candidates + commit bug fixes without review, until RC1 + then one extra review from RC1 * UI / design update (Astron) + splash screen + start-center + have a google+ vote on which one is best shortly. + get it included over the weekend + official TDF artwork handed around in a tar-ball AA: + mail the winning image to Thorsten (Astron) + Win7 glass foo reverted by popular request + templates as above + killing options: + nice research in: + http://wiki.documentfoundation.org/Whiteboards/KillOptions + would like CJK always-on, and with less UI + but: three font-selectos in the paragraph style dialog, not ideal. + (Caolan) 'C' locale is a 'no idea what people want' locale the categories are the same as MS Office. add an easy one-click button to see these ? * CXX0X-ABI incompatibility can of worms (Bjoern) + gcc 4.7 - cxx0x extension is binary incompatible + incompatible stdlib symbols that bust + http://gcc.gnu.org/ml/gcc/2012-06/msg00201.html + luck that it worked until now: it was compatible. AA: + should disable in our builds by default (Bjoern) + not easy to detect; crashers like: + https://bugs.freedesktop.org/show_bug.cgi?id=51342 + show up randomly. + lots of cascading dependencies of different ABI's ... + serious long-run problem for building vs. system packages + potentially accelerates our move away from a single image that runs on every linux if disros pick up the new ver. * new cppunit release (Markus) + all our patches up-streamed into the new cppunit version + have a VisualStudio project file to build on win32 + misc. sourceforge bug tracker bugs fixed. + build-system issues nailed + auto_ptr warning spew killed + master updated to latest cppunit AA: + look into misc. build issues on master (Michael) * re-basing update (Michael) + 15k of 45k files complete - ~30% + 47 of ~150 directories complete + will incorporate migrate of idlc - uccp + discuss other migrations as/when/next * gerrit update (Bjoern) + still getting a couple of mails if you push: something to review and it's already in + goes away when gerrit owns the repo. + multiple efforts to update the helper scripts AA: + work on unifying spaetz + David's tools (Bjoern) + please review mst's patches for the -3-5 branch (mst) + only those in the reviewer field get mailed + not got a fire-hose
Re: [Libreoffice-qa] LibreOffice QA Call 2012-06-29 [corrected date!!!!]
On Thu, Jun 28, 2012 at 08:25:40PM +0200, Florian Reisinger wrote: the next LibreOffice QA call is on 2012-06-28 14:00 UTC. See prototype agenda below. Hopefully it should be 2012-06-29?? Yes, sorry. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] [reisi...@gmail.com: Re: LibreOffice QA Call 2012-06-28]
- Forwarded message from Florian Reisinger reisi...@gmail.com - Date: Thu, 28 Jun 2012 20:25:40 +0200 From: Florian Reisinger reisi...@gmail.com To: Bjoern Michaelsen bjoern.michael...@canonical.com Subject: Re: [Libreoffice-qa] LibreOffice QA Call 2012-06-28 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 Hi there! Am 28.06.2012 18:14, schrieb Bjoern Michaelsen: Hi all, the next LibreOffice QA call is on 2012-06-28 14:00 UTC. See prototype agenda below. Hopefully it should be 2012-06-29?? pending action items: - write update scenario testcase in Litmus/MozTrap (Kendy) - Set Cor up with the Community/Forum maintainers at the distros to better propagate Hackfests, Bug Hunting Sessions etc. RedHat, Debian, Gentoo still missing + - Invite active bugwranglers to next call/QA list, CC Rainer (Bjoern) - merge 3.5 and 3.6 in one big bibisect repo (Bjoern) - recheck and tweak bibisect details (Bjoern) - research how it is done on SUSE/if there is a ready-to-use-extension for bugzilla email search improvements - Ping cloph if we can make that switchable to say Bug instead of EasyHack when explcitly requested (Bjoern) - authorative close of bugzilla versioning thread (Rainer/Petr) - adapt scripts for new versioning (Markus) - new Bug Hunting Sessions (Cor) - betas for Fedora (Caolan) structured manual testing (Yifan/Petr?) - gerrit possiblities - updates bug wrangling (Rainer): - own bugzilla requirements/improvement tasks http://wiki.documentfoundation.org/How_to_Improve_Bugzilla - NEEDINFO wrapup - bugzilla timestamps - 3.5.4 release community building/communication: - Summary of the Virtaual German QA meeting - ... bibisect for 3.5 release branch and 3.6 master (Bjoern/Korrawit): - ... Dial-in numbers for countries outside Germany can be found at: http://www.talkyoo.net/main/telefonkonferenz_internationale_rufnummern Dial-in numbers inside Germany are: +49 40 18881000 (Hamburg, landline) +49 40 95069970 (Hamburg, landline) +49 89 60893 (Munich, landline) +49 1570 3336000 (vistream mobile network) Room: Room number: 53 71 38 No participant PIN is required All calls will be recorded All participants can speak Note that you can also use Skype to join the call. Comments and additions most welcome. Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/ Yours Florian - End forwarded message - ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On Fri, 2012-06-29 at 09:56 +0100, Michael Meeks wrote: + (Caolan) 'C' locale is a 'no idea what people want' locale I mean that a huge amount of people use the en_US locale as their default I want everything in English even though I'm not in the US locale[1] so that its probably useless to assume too much from an en_US locale. On the other hand though if its *not* an en_US locale, e.g. nl_NL, hi_IN, ja_JP or some such then it would seem fairly reasonable to assume that the locale means what it says. So... one (odd I suppose) possibility would be to continue the current logic of hiding either or both of the CJK and CTL options based on the locale if that locale *isn't* en_US. Maybe another possibility is to dig around the various system and LibreOffice locale subsettings a bit deeper to see if there's any evidence that e.g. enabling CJK/CTL would be useful. i.e. if *any* locale setting is set to a territory using a CJK language toggle them on or if e.g. the underlying locale settings are en_US but the paper has been changed to A4 then they're lying about being in the US so toggle everything on :-) add an easy one-click button to see these ? * un-merged patches in bugzilla (Bjoern) + Bjoern worked on a few, many are already merged = just close them. + query of doom for the recent batch: https://bugs.freedesktop.org/buglist.cgi?chfieldto=Nowchfield=[Bug%20creation]chfield=aliaschfield=assigned_tochfield=cclist_accessiblechfield=componentchfield=deadlinechfield=everconfirmedchfield=rep_platformchfield=op_syschfield=prioritychfield=productchfield=qa_contactchfield=reporter_accessiblechfield=resolutionchfield=bug_severitychfield=bug_statuschfield=short_descchfield=target_milestonechfield=bug_file_locchfield=versionchfield=voteschfield=status_whiteboardquery_format=advancedchfieldfrom=2012-05-10list_id=88624field0-0-0=attachments.ispatchbug_status=UNCONFIRMEDbug_status=NEWbug_status=ASSIGNEDbug_status=REOPENEDbug_status=NEEDINFObug_status=PLEASETESTtype0-0-0=equalsvalue0-0-0=1product=LibreOffice I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. I *tried* to make a query to get a list of bugs that contain 1 non obsolete patches and mark the debugging patches as obsolete to try and weed out the noise but failed. Anyone got better bugzilla query king-fu to make the right query for that ? C. [1] There is the en_DK Linux locale which would, to my mind, fit a sort of international english pseudo-locale which would e.g. have A4 paper and not US letter as default paper, iso -MM-DD dates, not US date style. Unclear though what spelling standard would be in use. UK English with OED spelling rules for -ize, rumoured to be the in-house standard in many international organizations, would be tempting, i.e. langtag en-GB-oed. But what currency then, bah... ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On 2012-06-29 14:47, Caolán McNamara wrote: I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. Maybe we should have some way of marking bugs in in-progress or experimental ? Maybe just push bugs that have incomplete patches into NEEDSINFO state? Disclaimer: http://www.peralex.com/disclaimer.html ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] BugHunt Session ...Re: Re: minutes of the libreoffice qa call 2012-06-14
Hi Cor Le 2012-06-27 08:02, Cor Nouws a écrit : Hi all, Rainer Bielefeld wrote (26-06-12 20:13) Michael Meeks schrieb: If it gets us more testing of 3.6 - it sounds like an excellent idea to I also believe it would be great do do some final spurt for 3.6. [..] But may be I will join for a short visit. So here we go: https://wiki.documentfoundation.org/QA/BugHunting_Session_3.6.0 We'll have to make sure that preparations are in place, just for in case that non of us is able to join :-) Italo, could you draft a simple PR, or can you give me permission to recycle some of your previous work ;-) Cheers Just as a suggestion for future bug hunting and other events. Could you please check the calendar of events before planning any events? This will help avoid any conflicts with any other events that show on the calendar. For example, the next bug hunting session of July 6-7 falls on a common day with the Libre Software Meeting (LSM) (btw, we don't have anyone attending this conference). This is not to suggest to not plan any events on such dates, but to be aware of the impact of planning events on the same day(s) as another pre-planned event. We may be spreading ourselves too thin if we plan events on conflicting dates. I try to keep the visual calendar as up to date as possible[1][2]. (the same visual calendar exists on both the wiki and website) I have added the BugHunt date on the events calendar. Cheers, Marc [1] http://www.libreoffice.org/about-us/libreoffice-international-events-calendar/ [2] http://wiki.documentfoundation.org/EventsCalendar -- Unsubscribe instructions: E-mail to marketing+h...@global.libreoffice.org Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://listarchives.libreoffice.org/global/marketing/ All messages sent to this list will be publicly archived and cannot be deleted ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Bug transfer from AOOo Bugzilla to LibO Bugzilla
Hi. In regards to https://bugs.freedesktop.org/show_bug.cgi?id=51352#c3 I think that imported bugs which are in RESOLVED FIXED state should get some kind of notification by a triagger. LO devs, with the current backlog, should not waste time for bugs, which are already fixed in the other codebase. According to http://nabble.documentfoundation.org/Including-a-patch-from-AOO-tp3992463p3992646.html such import will be possible in near future, so bugs indicated by such notification could be proceed ASAP (possibly as EasyHack or Import Day). Query based on See also field is no good, as there are many bugs reported that are not fixed in AOO. Best regards. -- View this message in context: http://nabble.documentfoundation.org/Libreoffice-qa-Bug-transfer-from-AOOo-Bugzilla-to-LibO-Bugzilla-tp3986722p3992866.html Sent from the QA mailing list archive at Nabble.com. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Idea about ancient NEEDINFO bugs Nr. 1
Hi! Beside of the QA confcall: Every of this should be closed with an automatic message... This message should contain a long string like rf4g55gb48h4 So that we can search that string and close that: https://bugs.freedesktop.org/buglist.cgi?list_id=88813field0-0-0=bug_statuschfieldto=Nowquery_format=advancedchfield=qa_contactbug_status=NEEDINFOtype0-0-0=changedbeforevalue0-0-0=-10mproduct=LibreOffice All found with this search should be closed: https://bugs.freedesktop.org/buglist.cgi?list_id=88818field0-0-0=bug_statuschfieldto=Nowquery_format=advancedchfield=qa_contactbug_status=NEEDINFOlongdesc=rf4g55gb48h4type0-0-0=changedaftervalue0-0-0=-2mproduct=LibreOfficelongdesc_type=allwordssubstr -- Florian Reisinger ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On Fri, 2012-06-29 at 14:51 +0200, Noel Grandin wrote: On 2012-06-29 14:47, Caolán McNamara wrote: I looked through some of these, some patches are just experimental stuff or debugging patches or obsolete stuff. Maybe we should have some way of marking bugs in in-progress or experimental ? Maybe just push bugs that have incomplete patches into NEEDSINFO state? We could use whiteboard for that I guess; it's a shame to be looking at the same experimental patches again when I spent that time a few months back already. I tried to subset to only 25 from the 60 by doing some 'something changed since' that date in my monster query. HTH, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] [libreoffice-projects] Re: BugHunt Session ...Re: Re: minutes of the libreoffice qa call 2012-06-14
Hi Marc, Marc Paré wrote (29-06-12 16:12) Just as a suggestion for future bug hunting and other events. Could you please check the calendar of events before planning any events? This will help avoid any conflicts with any other events that show on the calendar. You're right, thanks for noticing and reminding me! (Hope I won't forget :-\ / ;-) ) [...] I have added the BugHunt date on the events calendar. [...] http://www.libreoffice.org/about-us/libreoffice-international-events-calendar/ [2] http://wiki.documentfoundation.org/EventsCalendar Regards, Cor -- - Cor - http://nl.libreoffice.org ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] minutes of the LibreOffice QA Call 2012-06-29 1400UTC
Hi, please find the minutes of the QA call below. Additions and corrections most welcome. attending: Cor, Florian, Petr, Rainer, Bjoern pending action items: - write update scenario testcase in Litmus/MozTrap (Kendy) - merge 3.5 and 3.6 in one big bibisect repo (Bjoern) - recheck and tweak bibisect details (Bjoern) - research how it is done on SUSE/if there is a ready-to-use-extension for bugzilla email search improvements (Petr) completed action items: - Set Cor up with the Community/Forum maintainers at the distros to better propagate Hackfests, Bug Hunting Sessions etc. - Invite active bugwranglers to next call/QA list, CC Rainer (Bjoern) (Bjoern will repeat by bugzilla query, Rainer by his spreadsheet) - Ping cloph if we can make that switchable to say Bug instead of EasyHack when explcitly requested (Bjoern) - authorative close of bugzilla versioning thread (Rainer/Petr) - adapt scripts for new versioning (Markus) - new Bug Hunting Sessions (Cor) done, see mailing list - betas for Fedora (Caolan) structured manual testing (Yifan/Petr?) - moztrap: no news - gerrit possiblities - LibreOffice Online for testing? (Florian) - more tests needed, still write them in litmus, migration to moztrap shouldnt be too much of issue (Petr) bug wrangling (Rainer): - own bugzilla requirements/improvement tasks http://wiki.documentfoundation.org/How_to_Improve_Bugzilla - make things more concrete: - list of powerful extensions (Rainer) - wiki is canonical place to discuss/amend starting from Sunday - NEEDINFO wrapup (Rainer) - NEEDINFO cleanun session - more closing of NEEDINFO -- more than 60-90 days old - more than 1000 of those around (Florian) - we need a good bulk change comment and wiki page - this is an automatic message - postponed to the next call AI: - draft this - findtheexpert is out of date (Rainer) - should be dynamically generated from git (Petr/Bjoern) - take it to the ESC - old memory leaks report lurking in bz (Rainer) - not securty issues per se for an desktop app (Bjoern/Petr) - take it to the ESC community building/communication: - localizition/qa call on weekends/evening? - additional call splits us thin (Cor) AI: - quantify: how much potential is there for new l10n/voluteer contributors? (Sophie) - does not really work for Bjoern/Petr as a sole call - for now stay where we are, - virtual german community meeting (Florian): - long weekend - not too much actual bugwrangling, but - bibisecting - education - knowledge sharing - needs more people - needs repetition bibisect for 3.5 release branch and 3.6 master (Bjoern/Korrawit): - no news next call: 2012-07-13 1400UTC Best, Bjoern ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Importing from Mindview worth our time??
I try not to bug devs over these kinds of things but I came across one of these enhancement requests that I wanted to see what everyone thought. The request is to get IMPORT working for the software program MINDVIEW. I feel like we should close it as WONTFIX. Reasons: 1. The software isn't free which makes it a lot harder to do something like this (pricey to say the least). 2. # of users using this software + using LO must be low (must being a subjective term that just is my impression of it). 3. If we were to do this I think it would be so time consuming and difficult to do that we would miss out on doing a lot of the more functional enhancement requests 4. The list of Enhancements is in the hundreds, if this one just stays open it'll just be one of those UNCONFIRMED or NEW requests that sit around for years and never has any input. 5. Not one other user has posted on the bug since its creation 5+ months ago Here is the request: https://bugs.freedesktop.org/show_bug.cgi?id=44606list_id=88922 Thanks all, hope you all have a great weekend. Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] API Documentation - Since/Minimum Version
Hi All, Friendly discussion about if we can commit to putting a minimum version or a since on our API documentation. We've had a user put in a bug report (I closed as not a bug but thought it was valid anyways) that we don't consistently -- or more accurately, rarely ever -- put a minimum version with our API documentation. Here is the example he provided: http://api.libreoffice.org/common/ref/com/sun/star/table/BorderLine2.html Would this be possible for us to try to do? If so is there documentation somewhere that we need to update for new devs to look at when making API documentation that will now include a requirement for minimum version? Thanks all for the input Joel ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
On Fri, 2012-06-29 at 23:57 +0200, Michael Stahl wrote: mostly though reset attachment flags what's your route here ? changing to non-patch/plain-text the experimental/dead stuff ? C. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Importing from Mindview worth our time??
I am really hesitant to support just having so many bugs floating around like this. I think that marking as RESOLVED - WONTFIX enables devs to look at these if they are ever inclined to do so but makes it clear to the users that we won't be doing this (almost guaranteed). I think if we just keep asking them to update it we give them the hope that there is a chance when in fact there isn't, plus we add that we'll have bugs open for months (year(s)) that won't be fixed ever and then ultimately just go to WILLNOTFIX, when we knew that months prior to changing the status. Joel On Fri, Jun 29, 2012 at 3:31 PM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2012-06-29 at 14:11 -0700, Joel Madero wrote: I feel like we should close it as WONTFIX. Reasons: 5. Not one other user has posted on the bug since its creation 5+ months ago request: https://bugs.freedesktop.org/show_bug.cgi?id=44606list_id=88922 There isn't anything anything IMO anything very wrong about the bug, but I agree that it just isn't going to happen, unless someone happens to really take a sudden interest in it. In fedora we close still-open bugs reported against fedora versions three (or so) releases earlier than the current release with a if this still matters to you then test in the current version and reopen it if the problem persists. It's hardly an ideal solution, but it does avoid the accumulation of infinite amounts of bugs. Maybe this is the way to go: cull all bugs reported against versions = 3 older than the current release that haven't had any activity in X months with a polite request to retest that its still broken if it still matters with a few links to commercial support if there's an itch they really want scratched. C. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
Hi, On 2012-06-29 at 23:57 +0200, Michael Stahl wrote: * Pending Action Items + [pending] merge the new pretty templates in place of the old ugly ones (Michael S) hmm... how come the minutes say i am merging templates? I believe it was Astron who volunteered (and probably Michael confused his voice with yours). Astron - is that correct? If yes, thanks so much in advance for looking into that! All the best, Kendy ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] minutes of ESC call ...
Hi all, hmm... how come the minutes say i am merging templates? i consider it Apparently, we sound alike..? Anyway, it was me who said that he'd try to help out there. Astron. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Importing from Mindview worth our time??
One of my mein concerns is that we aren't keeping up with bug reports so we may close a bug at eol without anyone from QA or any developer ever looking at it. To me this seems unfair to the reporter. On Jun 29, 2012 4:00 PM, Caolán McNamara caol...@redhat.com wrote: On Fri, 2012-06-29 at 15:36 -0700, Joel Madero wrote: I am really hesitant to support just having so many bugs floating around like this. I think that marking as RESOLVED - WONTFIX enables devs to look at these if they are ever inclined to do so but makes it clear to the users that we won't be doing this. Yup, I agree totally. Its not helpful to have loads of no-hoper bugs floating around. They should be closed with resolved-wontfix. My suggestion is only around the comment and criteria to use when closing them. e.g. here's our fedora-16 one http://fedoraproject.org/w/index.php?title=BugZappers/HouseKeeping/Fedora16#Comment_Text_2 So taking the fedora comment and adjusting it for us, it would look like... LibreOffice ''(major-version}'' changed to end-of-life (EOL) status on ''(date here)''. LibreOffice ''(major-version}'' is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of LibreOffice please feel free to reopen this bug against that version. Thank you for reporting this bug and we are sorry it could not be fixed. so for us that would mean anything reported against 3.3.X and 3.4.X is up for mass-closing with the above. C. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-qa] Macro Writing by non Developers should be made more easy
Macro Writing by non Developers should be made more easy At present for example, it is difficult to know how to: (1) create tool tips comments in one's own written macros, (2) index all the macros and their functionality, to reduce duplication, (3) create new icons more suited to a particular macro, (4) find existing icons in pairs or sets, like right hand arrow and left hand arrow ( such two icons are listed in entirely different places in the icons choosing dialog ) Akhil 30.06.2012 0830 BBY, IN ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 46479] FILESAVE: Save As dialog File name filed pre-fill misbehaving
https://bugs.freedesktop.org/show_bug.cgi?id=46479 --- Comment #9 from sasha.libreoff...@gmail.com 2012-06-28 22:59:17 PDT --- @ Rainer Greetings Please, help us here with reproducing this bug. May be You have some idea how to reproduce it. Thanks in advance -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51395] Unable to spell-check or hyphenate German, although dictionary and langugage pack installed
https://bugs.freedesktop.org/show_bug.cgi?id=51395 --- Comment #2 from Ulrich Windl ulrich.wi...@rz.uni-regensburg.de 2012-06-28 23:01:11 PDT --- My installation (Windows/XP, just in case it matters) was done as Administrator, but the problem occurred for a different user without administrative rights (a common scenario IMHO). The bundled directory for that user had a timestamp file and a database file. While that timestamp file had the date of installation (or first start after installation), the database file seemed untouched. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51543] UI: incomplete slide number info in status bar
https://bugs.freedesktop.org/show_bug.cgi?id=51543 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|Linux (All) |All Status Whiteboard||bibisectrequest Severity|normal |minor CC||LibreOffice@bielefeldundbus ||s.de, ||timofeev@gmail.com Summary|incorrect slide number in |UI: incomplete slide number |status bar |info in status bar Version|3.6.0.0.beta2 |Master old -3.6 Keywords||regression --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-28 23:14:50 PDT --- Reproducible with WIN 3.6.0.0.beta1 and Already [Reproducible] with Server installation of Master LOdev 3.6.0alpha0+ – WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 7175cee] (tinderbox: Win-x86@6-fast, pull time 2012-05-16 22:07:37) For me status bar shows Slide / , but I believe that's only a variant of reporter#s problem. Was ok with LOdev 3.6.0alpha0+ English UI/Locale [Build ID: 9518535-d09cf17-8a74106-c695ecd-16afab (libreoffice-3-5-branch-point)] {Win-x86@9-Voreppe Win32 pull time 2012-02-29 04:21:51}. OS: German WIN7 Home Premium (64bit) May be bibisecting can help? @Ivan: Please set Status to ASSIGNED and add yourself to Assigned To if you accept this Bug or forward the Bug if it's not your turf. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48183] FORMCONTROLS: Control inactive
https://bugs.freedesktop.org/show_bug.cgi?id=48183 sasha.libreoff...@gmail.com changed: What|Removed |Added Platform|Other |All Status|UNCONFIRMED |NEW CC||sasha.libreoff...@gmail.com Ever Confirmed|0 |1 --- Comment #1 from sasha.libreoff...@gmail.com 2012-06-28 23:23:51 PDT --- Thanks for bugreport reproduced in 3.5.4 on Fedora 64 bit Fileopen problem. Calc saves this property into xls correctly, as I can see in msExcel 2007. Possible duplicate of Bug 48123 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48192] Extensioname: PDF import doesn't display correctly checkboxes in drawing when opening certain type of PDF
https://bugs.freedesktop.org/show_bug.cgi?id=48192 sasha.libreoff...@gmail.com changed: What|Removed |Added CC||sasha.libreoff...@gmail.com --- Comment #2 from sasha.libreoff...@gmail.com 2012-06-28 23:27:49 PDT --- Thanks for bugreport PDF from link is corrupted. Please, attach correct version of this file. Attaching of files bigger than 3 Mb is impossible. Tell if this file is bigger than 3 Mb. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 48183] FORMCONTROLS: Control inactive
https://bugs.freedesktop.org/show_bug.cgi?id=48183 --- Comment #2 from sasha.libreoff...@gmail.com 2012-06-28 23:28:37 PDT --- Created attachment 63586 -- https://bugs.freedesktop.org/attachment.cgi?id=63586 test case for control anchoring -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46479] UI - FILESAVE WIN file dialog name pane empty
https://bugs.freedesktop.org/show_bug.cgi?id=46479 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever Confirmed|0 |1 Summary|FILESAVE: Save As dialog|UI - FILESAVE WIN file |File name filed pre-fill|dialog name pane empty |misbehaving | --- Comment #10 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-06-28 23:53:17 PDT --- NOT reproducible with LibreOffice 3.5.0 RC2 German UI/Locale [Build-ID: e371a95-bf68a13-5a1aa2b-d3c1ae9-b938258] on German WIN7 Home Premium (64bit) following reporter's instrucition without having seen movie. I remember a problem that for 'save as' or 'export' (I believe it was Export to PDF') the name pane in OS File dialog only will show a name if already a document with the same file type already is in the folder.If reporter confirms this relation we should try to find those reports. @reporter: Can you confirm this file name only showed if already document of file type exists in folder effect? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs