[Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #346 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 07:29:05 UTC --- Add Bug 52108 - CRASH on any action for particular big .odt. 7000 pages document is nothing affecting many users, but we had it working in 3.4, and who can know whether we also have an increased vulnerability with some hundreds pages documents? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - vcl/generic
vcl/generic/glyphs/gcach_layout.cxx | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) New commits: commit d7e5f9b315b5cbe6195504a4bb94b99e6f1b7d99 Author: Caolán McNamara caol...@redhat.com Date: Sat Jul 14 21:41:11 2012 +0100 Resolves: fdo#31821 always process ZW[N]J in the font regardless of script Change-Id: Icd309199b393d89e202fa9d1aba1a1ace51c6c6e diff --git a/vcl/generic/glyphs/gcach_layout.cxx b/vcl/generic/glyphs/gcach_layout.cxx index d04cebe..cd6b96c 100644 --- a/vcl/generic/glyphs/gcach_layout.cxx +++ b/vcl/generic/glyphs/gcach_layout.cxx @@ -187,6 +187,7 @@ public: using LEFontInstance::mapCharToGlyph; virtual LEGlyphID mapCharToGlyph( LEUnicode32 ch ) const; +virtual LEGlyphID mapCharToGlyph( LEUnicode32 ch, const LECharMapper *mapper, le_bool filterZeroWidth ) const; virtual le_int32getAscent() const; virtual le_int32getDescent() const; @@ -263,6 +264,18 @@ LEGlyphID IcuFontFromServerFont::mapCharToGlyph( LEUnicode32 ch ) const return nGlyphIndex; } +LEGlyphID IcuFontFromServerFont::mapCharToGlyph( LEUnicode32 ch, const LECharMapper *mapper, le_bool /*filterZeroWidth*/ ) const +{ +/* + fdo#31821, icu has... + â93 if (filterZeroWidth (mappedChar == 0x200C || mappedChar == 0x200D)) {â + â94 return canDisplay(mappedChar) ? 0x0001 : 0x; â + â95 } + so only the Indic layouts allow the joiners to get mapped to glyphs +*/ +return LEFontInstance::mapCharToGlyph( ch, mapper, false ); +} + // --- le_int32 IcuFontFromServerFont::getAscent() const commit f4d20a400b5c06959fd5a362a350bb4d9a6e4bd1 Author: Caolán McNamara caol...@redhat.com Date: Sat Jul 14 21:21:15 2012 +0100 Resolves: fdo#31821 use icu layout whenever possible because icu knows all about otf so we don't have to, which makes things its problem and not ours. This is the default route for all ctl languages already so if we suffer performance issues here we should try and fix that before just reverting Change-Id: I68c8d9929ca48388f61951344f2cfc195045166f diff --git a/vcl/generic/glyphs/gcach_layout.cxx b/vcl/generic/glyphs/gcach_layout.cxx index 0e8cd64..d04cebe 100644 --- a/vcl/generic/glyphs/gcach_layout.cxx +++ b/vcl/generic/glyphs/gcach_layout.cxx @@ -61,9 +61,7 @@ void ServerFontLayout::DrawText( SalGraphics rSalGraphics ) const bool ServerFontLayout::LayoutText( ImplLayoutArgs rArgs ) { -ServerFontLayoutEngine* pLE = NULL; -if( !(rArgs.mnFlags SAL_LAYOUT_COMPLEX_DISABLED) ) -pLE = mrServerFont.GetLayoutEngine(); +ServerFontLayoutEngine* pLE = mrServerFont.GetLayoutEngine(); if( !pLE ) pLE = SimpleLayoutEngine::get(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/filter/html/htmlpars.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 02e0c1b0e8e0b798694445bfa84383dd8d44216a Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Jul 15 03:42:27 2012 +0200 prevent double delete in calc's html parser, fdo#52107 Change-Id: I0a203a39697d3b12304e4b9dc99714cd7b2a008c (cherry picked from commit 0d21d9ddbe0561f45419ae4fc376c312565b413b) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx index 6395fb6..0566f66 100644 --- a/sc/source/filter/html/htmlpars.cxx +++ b/sc/source/filter/html/htmlpars.cxx @@ -554,6 +554,7 @@ void ScHTMLLayoutParser::Adjust() nCurRow = pS-nCurRow; } delete pS; +pS = NULL; nTab = pE-nTab; if (pTables) { ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/filter/html/htmlpars.cxx |1 + 1 file changed, 1 insertion(+) New commits: commit 5a86dee80fed8470213186294169582b89cf497f Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Sun Jul 15 03:42:27 2012 +0200 prevent double delete in calc's html parser, fdo#52107 Change-Id: I0a203a39697d3b12304e4b9dc99714cd7b2a008c (cherry picked from commit 0d21d9ddbe0561f45419ae4fc376c312565b413b) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/filter/html/htmlpars.cxx b/sc/source/filter/html/htmlpars.cxx index 323e1a2..d9363e4 100644 --- a/sc/source/filter/html/htmlpars.cxx +++ b/sc/source/filter/html/htmlpars.cxx @@ -554,6 +554,7 @@ void ScHTMLLayoutParser::Adjust() nCurRow = pS-nCurRow; } delete pS; +pS = NULL; nTab = pE-nTab; pTab = (pTables ? (Table*) pTables-Get( nTab ) : NULL); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [PUSHED-3-6][PUSHED-3-5] fix for fdo#52107
On Sun, 2012-07-15 at 03:51 +0200, Markus Mohrhard wrote: Hey, [1] fixes a crash when pasting a html table into calc. The problem is that in case of aStack being empty we are double deleting pS. Pushed to 3-5 and 3-6 C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history
On Sun, 2012-07-15 at 08:32 +0900, Takeshi Abe wrote: Hi, Having reproduced fdo#52013 on master, I would like to ask for a favor of reviewing http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b689371cc344f14af783f87c7fe37f5350c10ab for 3.6. Seems to me that the original conversion of 9c0ca924446933431d736ee0dd37e6852b4947dc should have used vector::insert rather than std::copy ?, i.e. like the attached C. diff --git a/sw/source/core/inc/rolbck.hxx b/sw/source/core/inc/rolbck.hxx index 982d26e..9bd1214 100644 --- a/sw/source/core/inc/rolbck.hxx +++ b/sw/source/core/inc/rolbck.hxx @@ -400,8 +400,7 @@ public: SwpHstry::iterator itSourceBegin = pIns-m_SwpHstry.begin() + nStart; SwpHstry::iterator itSourceEnd = pIns-m_SwpHstry.end(); if (itSourceBegin == itSourceEnd) return; -m_SwpHstry.reserve(nPos + static_castsize_t(itSourceEnd - itSourceBegin)); -std::copy( itSourceBegin, itSourceEnd, m_SwpHstry.begin() + nPos ); +m_SwpHstry.insert(m_SwpHstry.begin() + nPos, itSourceBegin, itSourceEnd); pIns-m_SwpHstry.erase( itSourceBegin, itSourceEnd ); } ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Impress test is now working in master
Hey, I recently merged Artur's feature branch into master and was prepared to deal with all the differences between different systems when it come to rendering shapes. Luckily and unexpected this did not occure so we I think we can suppose we can now use the new sd regression-test with more documents to prevent regressions in impress import and impress rendering. Adding a new test case is quite easy: Generate a test document, add it to the regression test, generate the reference xml files and let the test compare the dump and the reference file. The test will check for a lot of properties of shape objects and can be easily extended by extending the dumper code in drawinglyer/source/dumper/ Artur already created a nice test document that you can find at sd/qa/unit/data/ods/shapes-test.odp Regards, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Roman Eisele b...@eikota.de changed: What|Removed |Added Depends on||52028 --- Comment #42 from Roman Eisele b...@eikota.de 2012-07-15 09:03:23 PDT --- Add bug 52028 - Writer 3.6 creates and applies empty automatic styles everywhere, leading to needless file complexity and size. I don't know why nobody tries to confirm (or disprove) this bug, maybe my explanation is just too lengthy ;-), but if this bug is reproducible (even if it is just partially reproducible), this is an important regression which needs to get fixed soon. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'feature/svg-export' - filter/source
filter/source/svg/presentation_engine.js | 486 +-- 1 file changed, 406 insertions(+), 80 deletions(-) New commits: commit e9718383879ebea87c32fae11d71ead57b7adf81 Author: Marco Cecchetti mrcek...@gmail.com Date: Sun Jul 15 10:54:49 2012 +0200 JavaScript engine: added support for skipping/rewinding an effect belonging to an interactive animation sequence. Moreover now when the mouse pointer is over an event-source shape, through which the user can start an interactive animation, the cursor appearance is changed to a hand diff --git a/filter/source/svg/presentation_engine.js b/filter/source/svg/presentation_engine.js index cccbcd0..88d8de0 100644 --- a/filter/source/svg/presentation_engine.js +++ b/filter/source/svg/presentation_engine.js @@ -3006,7 +3006,7 @@ function skipEffects(dir) { if( dir == 1 ) { -var bRet = aSlideShow.skipEffect(); +var bRet = aSlideShow.skipPlayingOrNextEffect(); if( !bRet ) { @@ -5145,6 +5145,7 @@ function BaseNode( aAnimElem, aParentNode, aNodeContext ) this.aDuration = null; this.aEnd = null; this.bMainSequenceRootNode = false; +this.bInteractiveSequenceRootNode = false; this.eFillMode = FILL_MODE_FREEZE; this.eRestartMode = RESTART_MODE_NEVER; this.nReapeatCount = undefined; @@ -5462,6 +5463,11 @@ BaseNode.prototype.isMainSequenceRootNode = function() return this.bMainSequenceRootNode; }; +BaseNode.prototype.isInteractiveSequenceRootNode = function() +{ +return this.bInteractiveSequenceRootNode; +}; + BaseNode.prototype.makeDeactivationEvent = function( nDelay ) { if( this.aDeactivationEvent ) @@ -5528,6 +5534,8 @@ BaseNode.prototype.notifyEndListeners = function() } this.aContext.aEventMultiplexer.notifyEvent( EVENT_TRIGGER_END_EVENT, this.getId() ); +if( this.getParentNode() this.getParentNode().isMainSequenceRootNode() ) +this.aContext.aEventMultiplexer.notifyNextEffectEndEvent(); }; BaseNode.prototype.getContext = function() @@ -6123,6 +6131,7 @@ BaseContainerNode.prototype.parseElement= function() if( sNodeTypeAttr aImpressNodeTypeInMap[ sNodeTypeAttr ] ) this.eImpressNodeType = aImpressNodeTypeInMap[ sNodeTypeAttr ]; this.bMainSequenceRootNode = ( this.eImpressNodeType == IMPRESS_MAIN_SEQUENCE_NODE ); +this.bInteractiveSequenceRootNode = ( this.eImpressNodeType == IMPRESS_INTERACTIVE_SEQUENCE_NODE ); // preset-class attribute this.ePresetClass = undefined; @@ -6554,6 +6563,7 @@ SequentialTimeContainer.prototype.rewindCurrentEffect = function( aChildNode ) // resolve it again. aChildNode.init(); this.resolveChild( aChildNode ); +this.notifyRewindedEvent( aChildNode ); this.bIsRewinding = false; } else @@ -6582,12 +6592,17 @@ SequentialTimeContainer.prototype.rewindLastEffect = function( aChildNode ) // immediately without increment the finished children counter and // resolve the next child. this.bIsRewinding = true; -// We end the current effect and remove any change it applies on the -// animated shape. +// We end the current effect. this.getContext().aTimerEventQueue.forceEmpty(); this.getContext().aActivityQueue.clear(); aChildNode.end(); -aChildNode.removeEffect(); +// Invoking the end method on the current child node that has not yet +// been activated should not lead to any change on the animated shape. +// However for safety we used to call the removeEffect method but +// lately we noticed that when interactive animation sequences are +// involved into the shape effect invoking such a method causes +// some issue. +//aChildNode.removeEffect(); // As we rewind the previous effect we need to decrease the finished // children counter. @@ -6603,6 +6618,7 @@ SequentialTimeContainer.prototype.rewindLastEffect = function( aChildNode ) // in ENDED state now, On the contrary it cannot be resolved again later. aChildNode.init(); this.resolveChild( aPreviousChildNode ); +this.notifyRewindedEvent( aChildNode ); this.bIsRewinding = false; } else @@ -6629,29 +6645,50 @@ SequentialTimeContainer.prototype.resolveChild = function( aChildNode ) { var bResolved = aChildNode.resolve(); -if( bResolved this.isMainSequenceRootNode() ) +if( bResolved ( this.isMainSequenceRootNode() || this.isInteractiveSequenceRootNode() ) ) { if( this.aCurrentSkipEvent ) this.aCurrentSkipEvent.dispose(); - this.aCurrentSkipEvent = makeEvent( bind2( SequentialTimeContainer.prototype.skipEffect, this, aChildNode ) ); -this.aContext.aEventMultiplexer.registerSkipEffectEvent( this.aCurrentSkipEvent ); if( this.aRewindCurrentEffectEvent )
Feature comparison: LibreOffice - Microsoft Office in the Wiki
Dear all, please find a first draft of a comprehensive feature comparison between LibreOffice 3.6 and Microsoft Office 2010 in the Documentfoundation wiki: https://wiki.documentfoundation.org/Feature_Comparison:_LibreOffice_-_Microsoft_Office Please feel free to use or change the information in any way you like. Best greetings, Gerry ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history
Hi Caolán, Thank you for your review! On Sun, 15 Jul 2012 08:43:38 +0100, Caolán McNamara caol...@redhat.com wrote: On Sun, 2012-07-15 at 08:32 +0900, Takeshi Abe wrote: Having reproduced fdo#52013 on master, I would like to ask for a favor of reviewing http://cgit.freedesktop.org/libreoffice/core/commit/?id=7b689371cc344f14af783f87c7fe37f5350c10ab for 3.6. Seems to me that the original conversion of 9c0ca924446933431d736ee0dd37e6852b4947dc should have used vector::insert rather than std::copy ?, i.e. like the attached Exactly, I stand corrected. Please push it to master, and do we need another ack for the 3.6 branch? Cheers, -- Takeshi Abe C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Gtk-WARNING **: /opt/libreoffice3.6/program/../ure-link/lib/libstdc++.so.6: version `GLIBCXX_3.4.11' not found (required by /usr/lib/i386-linux-gnu/gtk-2.0/2.10.0/engines/liboxygen-gtk.so)
On Sat, Jul 14, 2012 at 04:56:03PM +0300, Nikola Yanev wrote: I will try it tonight, but the same system with lo 3.5.5 gives me no problem. I will try the one tou are telling me and will write down. It is probably worth double-checking you have uninstalled the libreoffice3.6-stdlibs package. On Jul 14, 2012 3:51 PM, Ruslan Kabatsayev b7.10110...@gmail.com wrote: What if you set SAL_USE_VCLPLUGIN=gen before starting soffice? What if you remove oxygen-gtk having stdlibs installed? -- Lionel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: fdo#36187 Swedish accelerators
Hi Lionel, 2012/7/15 Lionel Elie Mamane lio...@mamane.lu: On Sat, Jul 14, 2012 at 04:55:15PM +0200, Andras Timar wrote: Swedish localizers asked for special accelerator keys, because Ctrl + [ and ] are not accessible from Swedish keyboard. http://cgit.freedesktop.org/libreoffice/core/commit/?id=4090ec5c4c8c68783ef94460d0809377769944e7 This looks to me like it enables these alternate shortcuts independently of the keyboard layout, but depending on one of LibO UI language or maybe document language. Maybe that's the least bad we can easily do, but it is the wrong conditional: Think of people using an English UI to work on a document written in Danish (or Portuguese). It depends on the UI language. I admit that this is not a perfect solution, e.g. I use English UI with Hungarian keyboard layout, but I cannot think of anything better at the moment. For the minority, who use different UI localization and keyboard layout, it is still possible to manually re-define accelerators. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: sfx2/source
sfx2/source/appl/lnkbase2.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 602445c1aae34c1770b627c60238f4f8ba8515ac Author: Julien Nabet serval2...@yahoo.fr Date: Sun Jul 15 15:24:09 2012 +0200 Prefer prefix ++/-- operators for non-primitive types Change-Id: I6cfaf9f4623c67fcf9383426f04b32e095acbf42 diff --git a/sfx2/source/appl/lnkbase2.cxx b/sfx2/source/appl/lnkbase2.cxx index d22c4fd..8bc6704 100644 --- a/sfx2/source/appl/lnkbase2.cxx +++ b/sfx2/source/appl/lnkbase2.cxx @@ -620,7 +620,7 @@ static DdeTopic* FindTopic( const String rLinkName, sal_uInt16* pItemStt ) for( int i = 0; i 2; ++i ) { for( std::vectorDdeTopic*::iterator iterTopic = rTopics.begin(); - iterTopic != rTopics.end(); iterTopic++ ) + iterTopic != rTopics.end(); ++iterTopic ) if( (*iterTopic)-GetName() == sTopic ) return *iterTopic; ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: framework/source
framework/source/lomenubar/MenuItemInfo.cxx | 10 +- framework/source/lomenubar/MenuItemInfo.hxx | 10 +- 2 files changed, 10 insertions(+), 10 deletions(-) New commits: commit 6c4838c13cdc1a6b127e08f1a46883da1b45cfbf Author: Julien Nabet serval2...@yahoo.fr Date: Sun Jul 15 15:41:15 2012 +0200 These methods can be const Change-Id: Ia4aa8df3768923f7b5a31fb5158e4a744f4b9788 diff --git a/framework/source/lomenubar/MenuItemInfo.cxx b/framework/source/lomenubar/MenuItemInfo.cxx index 18c159d..904f82a 100644 --- a/framework/source/lomenubar/MenuItemInfo.cxx +++ b/framework/source/lomenubar/MenuItemInfo.cxx @@ -74,31 +74,31 @@ MenuItemInfo::setVisible (gboolean is_visible) //Getters gchar* -MenuItemInfo::getLabel () +MenuItemInfo::getLabel () const { return m_label; } gboolean -MenuItemInfo::getEnabled () +MenuItemInfo::getEnabled () const { return m_is_enabled; } gint -MenuItemInfo::getCheckState () +MenuItemInfo::getCheckState () const { return m_check_state; } const gchar* -MenuItemInfo::getCheckType () +MenuItemInfo::getCheckType () const { return m_check_type; } gboolean -MenuItemInfo::getVisible () +MenuItemInfo::getVisible () const { return m_is_visible; } diff --git a/framework/source/lomenubar/MenuItemInfo.hxx b/framework/source/lomenubar/MenuItemInfo.hxx index 72d411c..0171795 100644 --- a/framework/source/lomenubar/MenuItemInfo.hxx +++ b/framework/source/lomenubar/MenuItemInfo.hxx @@ -46,11 +46,11 @@ class MenuItemInfo { void setVisible (gboolean is_visible); //Getters -gchar* getLabel (); -gboolean getEnabled (); -gint getCheckState (); -const gchar* getCheckType (); -gboolean getVisible (); +gchar* getLabel () const; +gboolean getEnabled () const; +gint getCheckState () const; +const gchar* getCheckType () const; +gboolean getVisible () const; }; #endif // __MENU_ITEM_INFO_HXX__ ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/svg-export' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Hillar liivhil...@gmail.com changed: What|Removed |Added Depends on||40317, 33773 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Hillar liivhil...@gmail.com changed: What|Removed |Added Depends on|33773 | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on|40317 | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: What is bibisect? And what is it doing in my office?
On Sat, Jul 7, 2012 at 10:19 AM, Robinson Tryon bishop.robin...@gmail.com wrote: I'll set up a machine as a buildbot so that I can test my changes. Here's my first shot at bibisect integration into tinbuild2. I threw together a couple of test files to make it easier to test the bibisect part without running a whole new build, I plundered Bjoern's bibisect code to make the output more in line with the existing bibisect repos (probably still needs improvements), and I added a number of tests throughout the do_bibisect_push() function to ensure that all of the steps of the tinbuild phase are executed properly. I've tested these changes on Ubuntu 12.04, but I'd love to get feedback from people running buildbots on other OSes. Couple of notes: The code currently adds every build to the bibisect repository, but nightly builds might be often enough (or should we shoot for a strict 64 commits interval ?) Git push to a local-filesystem remote (e.g. fake-remote made by redo-repos.sh) is fast. It'll be interesting to see how slow push is to a physically distant remote. Will there be a big repack hit as the repository grows to include dozens of builds? --R 0001-Bibisect-Add-basic-support-for-bibisect-repository-i.patch.gz Description: GNU Zip compressed data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#50941: Characters per line will not change when changi...
From Takeshi Abe t...@fixedpoint.jp: Takeshi Abe has uploaded a new change for review. Change subject: fdo#50941: Characters per line will not change when changing Max base text size .. fdo#50941: Characters per line will not change when changing Max base text size max characters per line follows max base text size in the squared mode of text grid Change-Id: I47f8cd0db1ece5c940f31aada7d51d40058c7513 --- M sw/source/ui/misc/pggrid.cxx 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/12/312/1 -- To view, visit https://gerrit.libreoffice.org/312 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I47f8cd0db1ece5c940f31aada7d51d40058c7513 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Takeshi Abe t...@fixedpoint.jp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on|39006 | -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: instsetoo_native/inc_openoffice solenv/bin
instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf |2 +- solenv/bin/modules/installer/windows/msiglobal.pm |1 + 2 files changed, 2 insertions(+), 1 deletion(-) New commits: commit 1b31d5fb52ebdf9c32ec50dd5521724bc1b1c73e Author: Andras Timar ati...@suse.com Date: Sun Jul 15 17:30:47 2012 +0200 fdo#52088 use [ProductName] placeholder instead of LibreOffice Change-Id: I560139949c89798581ed7631eb5d0b3124c83002 diff --git a/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf b/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf index 3376c3d..46e84bf 100644 --- a/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf +++ b/instsetoo_native/inc_openoffice/windows/msi_languages/SIS.ulf @@ -2,7 +2,7 @@ en-US = Installation database [OOO_SIS_COMMENT] -en-US = This installer database contains the logic and data required to install LibreOffice. +en-US = This installer database contains the logic and data required to install [ProductName]. [OOO_SIS_KEYWORDS] en-US = Install,MSI diff --git a/solenv/bin/modules/installer/windows/msiglobal.pm b/solenv/bin/modules/installer/windows/msiglobal.pm index c6a70ff..d4b626d 100644 --- a/solenv/bin/modules/installer/windows/msiglobal.pm +++ b/solenv/bin/modules/installer/windows/msiglobal.pm @@ -940,6 +940,7 @@ sub write_summary_into_msi_database my $author = get_author_for_sis(); my $subject = get_subject_for_sis($allvariableshashref); my $comment = get_comment_for_sis($sislanguage,$languagefile, OOO_SIS_COMMENT); +$comment =~ s/\[ProductName\]/$allvariableshashref-{'PRODUCTNAME'}/; my $keywords = get_keywords_for_sis($sislanguage,$languagefile, OOO_SIS_KEYWORDS); my $appname = get_appname_for_sis($sislanguage,$languagefile, OOO_SIS_APPNAME); my $security = get_security_for_sis(); ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sw/source
sw/source/core/inc/rolbck.hxx |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) New commits: commit c06fe7e201cdb0fa77da3067dc51a2c6e081d82a Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 15 16:21:44 2012 +0100 Resolves: fdo#52013 use vector::insert instead Change-Id: I3cbc0c0751c069ff9bc7d8b1b737fcfdc3be2b9d diff --git a/sw/source/core/inc/rolbck.hxx b/sw/source/core/inc/rolbck.hxx index 982d26e..9bd1214 100644 --- a/sw/source/core/inc/rolbck.hxx +++ b/sw/source/core/inc/rolbck.hxx @@ -400,8 +400,7 @@ public: SwpHstry::iterator itSourceBegin = pIns-m_SwpHstry.begin() + nStart; SwpHstry::iterator itSourceEnd = pIns-m_SwpHstry.end(); if (itSourceBegin == itSourceEnd) return; -m_SwpHstry.reserve(nPos + static_castsize_t(itSourceEnd - itSourceBegin)); -std::copy( itSourceBegin, itSourceEnd, m_SwpHstry.begin() + nPos ); +m_SwpHstry.insert(m_SwpHstry.begin() + nPos, itSourceBegin, itSourceEnd); pIns-m_SwpHstry.erase( itSourceBegin, itSourceEnd ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: l10ntools/source
l10ntools/source/localize.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 7f4790388b5b3d09a364fa9d7ea10bd4765288ba Author: Andras Timar ati...@suse.com Date: Sun Jul 15 17:51:53 2012 +0200 fdo#52090 update Danish dictionaries (2012.07.14) Change-Id: Ia05018afcfcba044e568e9262ccb90324c2807f5 diff --git a/l10ntools/source/localize.cxx b/l10ntools/source/localize.cxx index 81d4875..a54d096 100644 --- a/l10ntools/source/localize.cxx +++ b/l10ntools/source/localize.cxx @@ -116,6 +116,9 @@ bool passesNegativeList(rtl::OUString const url) { /dictionaries/da_DK/help/da/ org.openoffice.da.hunspell.dictionaries/page1.xhp) }, { RTL_CONSTASCII_STRINGPARAM( +/dictionaries/da_DK/help/da/ +org.openoffice.da.hunspell.dictionaries/page2.xhp) }, +{ RTL_CONSTASCII_STRINGPARAM( /dictionaries/hu_HU/help/hu/ org.openoffice.hu.hunspell.dictionaries/page1.xhp) }, { RTL_CONSTASCII_STRINGPARAM(/hidother.src) }, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - l10ntools/source
l10ntools/source/localize.cxx |3 +++ 1 file changed, 3 insertions(+) New commits: commit 525d2dab0e02c40dad8258958b2877e16f54976e Author: Andras Timar ati...@suse.com Date: Sun Jul 15 17:51:53 2012 +0200 fdo#52090 update Danish dictionaries (2012.07.14) Change-Id: Ia05018afcfcba044e568e9262ccb90324c2807f5 Signed-off-by: Andras Timar ati...@suse.com diff --git a/l10ntools/source/localize.cxx b/l10ntools/source/localize.cxx index 81d4875..a54d096 100644 --- a/l10ntools/source/localize.cxx +++ b/l10ntools/source/localize.cxx @@ -116,6 +116,9 @@ bool passesNegativeList(rtl::OUString const url) { /dictionaries/da_DK/help/da/ org.openoffice.da.hunspell.dictionaries/page1.xhp) }, { RTL_CONSTASCII_STRINGPARAM( +/dictionaries/da_DK/help/da/ +org.openoffice.da.hunspell.dictionaries/page2.xhp) }, +{ RTL_CONSTASCII_STRINGPARAM( /dictionaries/hu_HU/help/hu/ org.openoffice.hu.hunspell.dictionaries/page1.xhp) }, { RTL_CONSTASCII_STRINGPARAM(/hidother.src) }, ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[PATCH] move remotebridges to tail_build
From David Tardon dtar...@redhat.com: David Tardon has uploaded a new change for review. Change subject: move remotebridges to tail_build .. move remotebridges to tail_build Change-Id: I54d0e708f00ecbd95f34a62b54768f15d263ec69 --- M Module_tail_build.mk M tail_build/prj/build.lst 2 files changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/15/315/1 -- To view, visit https://gerrit.libreoffice.org/315 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I54d0e708f00ecbd95f34a62b54768f15d263ec69 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Tardon dtar...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] move sysui to postprocess
From David Tardon dtar...@redhat.com: David Tardon has uploaded a new change for review. Change subject: move sysui to postprocess .. move sysui to postprocess The only thing that sysui exports that is used by another package are application icons, used in desktop (windows build only). But since gbuildification of desktop they are included directly from $(SRCDIR)/sysui/desktop/icons instead of $(OUTDIR)/inc/icons, so the dependency is no longer necessary. Change-Id: I6fa3153d3793e785c1ed602c3e67c86cead2bae2 --- M desktop/prj/build.lst M postprocess/prj/build.lst M tail_build/prj/build.lst 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/14/314/1 -- To view, visit https://gerrit.libreoffice.org/314 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6fa3153d3793e785c1ed602c3e67c86cead2bae2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Tardon dtar...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] move l10ntools to cross_tail_build
From David Tardon dtar...@redhat.com: David Tardon has uploaded a new change for review. Change subject: move l10ntools to cross_tail_build .. move l10ntools to cross_tail_build Change-Id: I3e47892002a0cf0d22d86e9da925c76ac2781579 --- M Module_cross_tail_build.mk M cross_tail_build/prj/build.lst 2 files changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/17/317/1 -- To view, visit https://gerrit.libreoffice.org/317 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e47892002a0cf0d22d86e9da925c76ac2781579 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Tardon dtar...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] move ulfconv to l10ntools
From David Tardon dtar...@redhat.com: David Tardon has uploaded a new change for review. Change subject: move ulfconv to l10ntools .. move ulfconv to l10ntools This allows us to drop dependency on setup_native everywhere. Change-Id: Ib033f8d5953682379c6c2ab53d5cf221e9d8cfec --- M Repository.mk M cross_toolset/prj/build.lst A l10ntools/Executable_ulfconv.mk M l10ntools/Module_l10ntools.mk A l10ntools/Package_ulfconv.mk R l10ntools/source/ulfconv/msi-encodinglist.txt R l10ntools/source/ulfconv/ulfconv.cxx M postprocess/prj/build.lst M scp2/prj/build.lst M setup_native/prj/build.lst M setup_native/prj/d.lst D setup_native/source/ulfconv/makefile.mk M sysui/prj/build.lst M tail_build/prj/build.lst 14 files changed, 43 insertions(+), 53 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/13/313/1 -- To view, visit https://gerrit.libreoffice.org/313 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib033f8d5953682379c6c2ab53d5cf221e9d8cfec Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Tardon dtar...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] drop translations from build phase: not required anymore
From David Tardon dtar...@redhat.com: David Tardon has uploaded a new change for review. Change subject: drop translations from build phase: not required anymore .. drop translations from build phase: not required anymore Change-Id: I70df41a8ed5ed7e6c614749125f19b80c5e03291 --- M cross_tail_build/prj/build.lst 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/16/316/1 -- To view, visit https://gerrit.libreoffice.org/316 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I70df41a8ed5ed7e6c614749125f19b80c5e03291 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: David Tardon dtar...@redhat.com ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
It's a very interesting link you gave! I added this on your page : MS Excel allows to group and outline but had no fdo bug ref (put a link about a wikihow instead) and I don't know if something is planned about this. Anyone to bring some info about this ? Julien -- View this message in context: http://nabble.documentfoundation.org/Feature-comparison-LibreOffice-Microsoft-Office-in-the-Wiki-tp3995567p3995620.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [GSoC 2012][svg export filter] Weekly Report #8
Hi everybody, I'm really happy to going on working on my project for the second half of GSoC! Thanks to the whole LibreOffice community for your support! :) It follows my weekly report: Report #8 - This week I added support for skipping and rewinding effects that belong to interactive animation sequences, that is those effects started by clicking on a given shape. That required a rework of some parts composing the skip/rewind feature implementation. After several tries I succeeded in finding a good solution. When a skip action is requested by the user all playing effects are skipped, both the ones belonging to the main animation sequence and the ones belonging to any interactive animation sequence. In case no effect is playing, the next effect, if any, belonging to the main animation sequence is skipped. When a rewind action is requested by the user, any playing or ended effect started later the oldest playing effect is rewinded, if there is no playing effect, the last started (not ended!) effect, indifferently from the animation sequence it belongs to, is rewinded. I also implemented a little nice feature: miming the behavior of the C++ presentation player now when the mouse pointer is over an event-source shape, through which the user can start an interactive animation, the cursor appearance is changed to a hand. Filed a new bug report (fdo#52120) for pointing out that in the C++ implementation skipping an effect does not work as expected when the hide after animation option is selected. Merged the feature/svg-export branch to the master branch. Now the skip/rewind effect support is available in the master branch directly, the same is true for interactive effects. --- You can read more details on my project log book (week 8): https://docs.google.com/document/d/1GSLPSIWRGSDTSi69dT9Te8tRyTJcAekxT7scoCoGO2M/edit?pli=1#heading=h.3hsb6kvnww9l You can download a sample presentation here: https://docs.google.com/open?id=0BwS_9-CU4098bkY4bG51aHJMUkk In order to download the zip files click on the Download item under the File menu. You can look at the source code in the feature branch: feature/svg-export, that includes all new commits after the last master branch merging. Cheers, -- Marco -- Using Opera's revolutionary e-mail client: http://www.opera.com/mail/ ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi On top of that, it makes sense for me if this page is under Documentation tree. Nice work! already under translation for pt-br. Kind regards Olivier Em 15-07-2012 09:51, Philipp Riemer escreveu: 2012/7/15 Gerry T. gerry.trep...@googlemail.com: Dear all, please find a first draft of a comprehensive feature comparison between LibreOffice 3.6 and Microsoft Office 2010 in the Documentfoundation wiki: https://wiki.documentfoundation.org/Feature_Comparison:_LibreOffice_-_Microsoft_Office Please feel free to use or change the information in any way you like. Best greetings, Gerry Thank you for your work so far! Pretty impressive! Might also help the marketing guys a lot for their next big advertisement campain (LO4?). Coming from academia, most of the texts are too long for me to read ;-) Would it be possible to make a TL;DR version? Maybe a table with LO on the left and MSO on the right and green background for a column where A outperforms B? Next weekend I have some spare time again and could help with that/ provide a draft if you like. Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice - -- Olivier Hallot Founder, Board of Directors Member - The Document Foundation The Document Foundation, Zimmerstr. 69, 10117 Berlin, Germany Fundação responsável civilmente, de acordo com o direito civil Detalhes Legais: http://www.documentfoundation.org/imprint LibreOffice translation leader for Brazilian Portuguese +55-21-8822-8812 -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJQAu4aAAoJEJp3R7nH3vLxN0cIAKB+bQ9umTjr8mph5RnGb277 nGJSAnT3RP/vPvxE26Aj1cXyedk1+elm8EJ0r9PjGXI/nPGTYc4hzYsRZ01V/Bl7 iNqdptMCIJk629mAnllsFZyFUKoRzVxUg/ijDqtSJ8F1c53a1yC+4p7Zf8lTE/wg Bm0yh3AH5/FTAZByHNgXPOy98OrXX8GdQyd/syRVa/tj25EdEACDQ927VO+CVJoL 2zcP48IbRdBQ8Jxmqb6AIY3NRARScY6eonV0+CMg6yLWGn44HVGrpR64j0toUen3 6/9ondEMyDCU6T7NnvypXqEFL7MMsaS5lDekxrLOzzbiIU/+9jbdfWViHPyIKMU= =EB6K -END PGP SIGNATURE- ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: gbuild migration
Hi, On Thu, Jul 12, 2012 at 08:36:45AM +0200, David Tardon wrote: * setup_native builds the ulfconv executable that is needed for scp2 (yes, I already suggested at least once it should be moved elsewhere, probably to l10ntools. Good time to do it? :-) So I did that in https://gerrit.libreoffice.org/313 (with more cleanup in following patches). The result is that setup_native and sysui are now built from postprocess (so they do not block tail_build); as a bonus the build phase of cross-compilation does not need to build translations anymore. I believe the main tail_build blocker is now cli_ure (immediately followed by bridges) followed by readlicense_oo. D. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - 5 commits - l10ntools/source
l10ntools/source/gsicheck.cxx |4 ++-- l10ntools/source/helper.hxx |9 + l10ntools/source/tagtest.cxx | 11 +++ 3 files changed, 18 insertions(+), 6 deletions(-) New commits: commit 9865dbc7af9331ccb1a8e55a09dd821fb014a5a4 Author: Stephan Bergmann sberg...@redhat.com Date: Fri Jul 13 15:35:42 2012 +0200 fdo#51954: More tools-rtl string conversion regressions Change-Id: If9c5b0a0876540e9546617faaa5dcb4ae1e5a2cb Signed-off-by: Andras Timar ati...@suse.com diff --git a/l10ntools/source/gsicheck.cxx b/l10ntools/source/gsicheck.cxx index 98e4b31..b2981a3 100644 --- a/l10ntools/source/gsicheck.cxx +++ b/l10ntools/source/gsicheck.cxx @@ -479,7 +479,7 @@ sal_Bool GSIBlock::HasSuspiciousChars( GSILine* pTestee, GSILine* pSource ) rtl::OStringToOUString( pTestee-GetText().copy(0, nPos), RTL_TEXTENCODING_UTF8)); sal_Int32 nErrorPos = aUTF8Tester.getLength(); -rtl::OString aContext( pTestee-GetText().copy( nPos, 20 ) ); +rtl::OString aContext( helper::abbreviate( pTestee-GetText(), nPos, 20 ) ); PrintError(rtl::OStringBuffer(RTL_CONSTASCII_STRINGPARAM(Found double questionmark in translation only. Looks like an encoding problem at Position )) .append(nErrorPos).getStr(), Text format, aContext, pTestee-GetLineNumber(), pTestee-GetUniqId()); commit 025c3122716ea363545e04329d0ebc8f7bb65bc9 Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jul 11 19:09:44 2012 +0200 Regression fix correction Change-Id: I03f020f474c198368aa3528870b0752752a3bd2c Signed-off-by: Andras Timar ati...@suse.com diff --git a/l10ntools/source/tagtest.cxx b/l10ntools/source/tagtest.cxx index 77b3be8..062c5c7 100644 --- a/l10ntools/source/tagtest.cxx +++ b/l10ntools/source/tagtest.cxx @@ -772,7 +772,10 @@ rtl::OUString SimpleParser::GetNextTokenString( ParserMessageList rErrorList, s if (nStyle2StartPos == -1 nStyle3StartPos == -1) return rtl::OUString(); // no more tokens -if ( nStyle4StartPos != -1 nStyle4StartPos nStyle2StartPos nStyle4StartPos = nStyle3StartPos ) // = to make sure \\ is always handled first +if ( nStyle4StartPos != -1 + (nStyle2StartPos == -1 || nStyle4StartPos nStyle2StartPos) + (nStyle3StartPos == -1 || nStyle4StartPos nStyle3StartPos ) ) +// to make sure \\ is always handled first { // Skip quoted Backslash nPos = nStyle4StartPos +2; return GetNextTokenString( rErrorList, rTagStartPos ); commit fd4129ef6116adfcda39acac7fb6d28211464a72 Author: Michael Meeks michael.me...@suse.com Date: Wed Jul 11 12:10:56 2012 +0100 fix std::max mismatched type compile snafu Change-Id: Ia6572f8c648168053ae327fa995fc4f33029ab33 Signed-off-by: Andras Timar ati...@suse.com diff --git a/l10ntools/source/helper.hxx b/l10ntools/source/helper.hxx index ee03eda..cc33b71 100644 --- a/l10ntools/source/helper.hxx +++ b/l10ntools/source/helper.hxx @@ -103,7 +103,7 @@ inline sal_Int32 indexOfAnyAsciiL( template typename T inline T abbreviate( T const text, sal_Int32 start, sal_Int32 length) { -start = std::max(0, start); +start = std::max(sal_Int32(0), start); assert(start = text.getLength()); return text.copy(start, std::min(text.getLength() - start, length)); } commit 5085fb2b0a8e74e5cdc67487c05c605570e8c71b Author: Stephan Bergmann sberg...@redhat.com Date: Wed Jul 11 12:16:13 2012 +0200 fdo#51954: More tools-rtl string conversion regressions Change-Id: I490cc82b60663d30fdc8e09d9d6021c964656bec Signed-off-by: Andras Timar ati...@suse.com diff --git a/l10ntools/source/gsicheck.cxx b/l10ntools/source/gsicheck.cxx index bb0e116..98e4b31 100644 --- a/l10ntools/source/gsicheck.cxx +++ b/l10ntools/source/gsicheck.cxx @@ -362,7 +362,7 @@ void GSIBlock::PrintList( ParserMessageList *pList, rtl::OString const aPrefix if ( pMsg-GetTagBegin() == -1 ) aContext = pLine-GetText().copy( 0, 300 ); else -aContext = pLine-data_.copy( pMsg-GetTagBegin()-150, 300 ); +aContext = helper::abbreviate( pLine-data_, pMsg-GetTagBegin()-150, 300 ); aContext = aContext.trim(); } diff --git a/l10ntools/source/helper.hxx b/l10ntools/source/helper.hxx index 59f8628..ee03eda 100644 --- a/l10ntools/source/helper.hxx +++ b/l10ntools/source/helper.hxx @@ -32,6 +32,7 @@ #include sal/config.h +#include algorithm #include cassert #include rtl/string.hxx @@ -99,6 +100,14 @@ inline sal_Int32 indexOfAnyAsciiL( return -1; } +template typename T inline T abbreviate( +T const text, sal_Int32 start, sal_Int32 length) +{ +start = std::max(0, start); +assert(start = text.getLength()); +return text.copy(start, std::min(text.getLength() - start, length)); +} + } #endif diff --git
Re: gbuild migration
Hi, On 15 July 2012 18:35, David Tardon dtar...@redhat.com wrote: So I did that in https://gerrit.libreoffice.org/313 (with more cleanup in following patches). The result is that setup_native and sysui are now built from postprocess (so they do not block tail_build); as a bonus the build phase of cross-compilation does not need to build translations anymore. nice :-) I believe the main tail_build blocker is now cli_ure (immediately followed by bridges) followed by readlicense_oo. So, only two more modules and even salhelper can be in tail_build, great. We could then put almost everything relevant into libmerged but I don't know who would link it ;-) Thanks, Matus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
Dear Philipp, [...] Thank you for your work so far! Pretty impressive! Might also help the marketing guys a lot for their next big advertisement campain (LO4?). Coming from academia, most of the texts are too long for me to read ;-) Would it be possible to make a TL;DR version? Maybe a table with LO on the left and MSO on the right and green background for a column where A outperforms B? Next weekend I have some spare time again and could help with that/ provide a draft if you like. Philipp This is a very good idea. Not many people read lengthy bullet point lists. My graphical skills are limited, though, so the provision of a draft sounds perfect. I assume that you want to limit the focus of a table on the major features (or even a selection out of it) or do you plan to cover all major and minor features in such a table? Best greetings, Gerry ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - desktop/source sc/source svx/source
desktop/source/app/desktop.hrc |4 desktop/source/app/desktop.src | 14 -- sc/source/ui/inc/datafdlg.hxx | 13 +++-- sc/source/ui/miscdlgs/datafdlg.cxx | 17 +++-- sc/source/ui/src/datafdlg.src | 36 +--- svx/source/dialog/docrecovery.src |4 ++-- 6 files changed, 37 insertions(+), 51 deletions(-) New commits: commit c61e3c941d46fe1ae6066f31e01786100e39da56 Author: Andras Timar ati...@suse.com Date: Sun Jul 15 21:18:42 2012 +0200 fdo#47947 Data Form dialog layout fix Change-Id: Ifa1689ff9be7afa14f5694825c506f7c8c3eff43 diff --git a/sc/source/ui/inc/datafdlg.hxx b/sc/source/ui/inc/datafdlg.hxx index bfa3769..6f41ddb 100644 --- a/sc/source/ui/inc/datafdlg.hxx +++ b/sc/source/ui/inc/datafdlg.hxx @@ -43,12 +43,13 @@ #define MAX_DATAFORM_COLS 256 #define MAX_DATAFORM_ROWS 32000 -#define CTRL_HEIGHT 22 -#define FIXED_WIDTH 60 -#define EDIT_WIDTH 140 -#define FIXED_LEFT 12 -#define EDIT_LEFT 78 -#define LINE_HEIGHT 30 +#define FIXED_WIDTH 54 +#define EDIT_WIDTH 86 +#define FIXED_HEIGHT10 +#define EDIT_HEIGHT 12 +#define FIXED_LEFT 6 +#define EDIT_LEFT 62 +#define LINE_HEIGHT 16 //zhangyun class ScDataFormDlg : public ModalDialog diff --git a/sc/source/ui/miscdlgs/datafdlg.cxx b/sc/source/ui/miscdlgs/datafdlg.cxx index 9f0f318..d87d552 100644 --- a/sc/source/ui/miscdlgs/datafdlg.cxx +++ b/sc/source/ui/miscdlgs/datafdlg.cxx @@ -163,10 +163,15 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri String aFieldName; -int nTop = 12; +//align with LAB_DATAFORM_RECORDNO +int nTop = LogicToPixel( Size(1,6), MapMode(MAP_APPFONT) ).getHeight(); +const int nOne = LogicToPixel( Size(1,1), MapMode(MAP_APPFONT) ).getHeight(); +const int nLineHeight = LogicToPixel( Size(1, LINE_HEIGHT), MapMode(MAP_APPFONT) ).getHeight(); +const int nFixedLeft = LogicToPixel( Size(FIXED_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); +const int nEditLeft = LogicToPixel( Size(EDIT_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); -SizenFixedSize(FIXED_WIDTH, CTRL_HEIGHT ); -SizenEditSize(EDIT_WIDTH, CTRL_HEIGHT ); +SizenFixedSize(LogicToPixel( Size(FIXED_WIDTH, FIXED_HEIGHT), MapMode(MAP_APPFONT) )); +SizenEditSize(LogicToPixel( Size(EDIT_WIDTH, EDIT_HEIGHT), MapMode(MAP_APPFONT) )); aColLength = nEndCol - nStartCol + 1; @@ -185,13 +190,13 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri maFixedTexts[nIndex].SetSizePixel(nFixedSize); maEdits[nIndex].SetSizePixel(nEditSize); -maFixedTexts[nIndex].SetPosPixel(Point(FIXED_LEFT, nTop)); -maEdits[nIndex].SetPosPixel(Point(EDIT_LEFT, nTop)); +maFixedTexts[nIndex].SetPosPixel(Point(nFixedLeft, nTop + nOne)); +maEdits[nIndex].SetPosPixel(Point(nEditLeft, nTop)); maFixedTexts[nIndex].SetText(aFieldName); maFixedTexts[nIndex].Show(); maEdits[nIndex].Show(); -nTop += LINE_HEIGHT; +nTop += nLineHeight; } else { diff --git a/sc/source/ui/src/datafdlg.src b/sc/source/ui/src/datafdlg.src index 5c0ee6d..0b6d01f 100644 --- a/sc/source/ui/src/datafdlg.src +++ b/sc/source/ui/src/datafdlg.src @@ -26,67 +26,66 @@ */ #include datafdlg.hrc -//zhangyun, dataform ModalDialog RID_SCDLG_DATAFORM { OutputSize = TRUE ; SVLook = TRUE ; -Size = MAP_APPFONT ( 191 , 180 ) ; +Size = MAP_APPFONT ( 257 , 180 ) ; Text [ en-US ] = Data Form ; Moveable = TRUE ; Closeable = TRUE ; FixedText LAB_DATAFORM_RECORDNO { -Pos = MAP_APPFONT ( 136 , 6 ) ; -Size = MAP_APPFONT ( 50 , 12 ) ; -Text [ en-US ] = / ; +Pos = MAP_APPFONT ( 162 , 6 ) ; +Size = MAP_APPFONT ( 60 , 12 ) ; +Text = / ; //placeholder only }; PushButton BTN_DATAFORM_NEW { -Pos = MAP_APPFONT ( 135 , 23 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 23 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; DefButton = TRUE ; Text [ en-US ] = New ; }; PushButton BTN_DATAFORM_DELETE { -Pos = MAP_APPFONT ( 135 , 40 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 40 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; Text [ en-US ] = Delete ; }; PushButton BTN_DATAFORM_RESTORE { -Pos = MAP_APPFONT ( 135 , 57 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 57 ) ; +Size = MAP_APPFONT ( 90 , 14
[REVIEW 3-5][REVIEW 3-6] Data Form dialog layout (fdo#47947)
Hi, There were two problems with this dialog. First, buttons on the right were not wide enough for some languages (French, German, etc.) Second, the original developer used hardcoded pixel coordinates instead of logical coordinates, and it resulted in suboptimal layout. http://cgit.freedesktop.org/libreoffice/core/commit/?id=c61e3c941d46fe1ae6066f31e01786100e39da56 Thanks, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
Hi Gerry, 2012/7/15 Gerry T. gerry.trep...@googlemail.com: Dear Philipp, [...] Thank you for your work so far! Pretty impressive! Might also help the marketing guys a lot for their next big advertisement campain (LO4?). Coming from academia, most of the texts are too long for me to read ;-) Would it be possible to make a TL;DR version? Maybe a table with LO on the left and MSO on the right and green background for a column where A outperforms B? Next weekend I have some spare time again and could help with that/ provide a draft if you like. Philipp This is a very good idea. Not many people read lengthy bullet point lists. My graphical skills are limited, though, so the provision of a draft sounds perfect. I assume that you want to limit the focus of a table on the major features (or even a selection out of it) or do you plan to cover all major and minor features in such a table? Best greetings, Gerry I really appreciate your work. Since I think that you made a pretty holistic comparison, I would suggest (kind of how you did already) to group the pro and cons per product/ application type. As a result, someone who is only interested in e.g. Calc vs. Excel might get the info on one page. By linking each point/line to a more detailed explanation further below, we might combine a quick overview with fully phrased content... Will see what I can do next Friday. When I wrote my mail I had something like http://en.wikipedia.org/wiki/Comparison_of_office_suites in mind which also links to http://en.wikipedia.org/wiki/Comparison_of_word_processors and http://en.wikipedia.org/wiki/Comparison_of_spreadsheet_software. Btw. maybe http://en.wikipedia.org/wiki/LibreOffice_Writer gives you also further ideas what might be useful to compare... Having only MSO2007 I don't know how much some functionalities changed. Sorry, just an idea, did not check that yet: Did you already include the information from http://wiki.documentfoundation.org/ReleaseNotes/3.5 and http://wiki.documentfoundation.org/ReleaseNotes/3.6 in your list? Have a nice week! Philipp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sw/source
sw/source/core/inc/rolbck.hxx |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 3669bb966f709089f43111b5ca1057bfe4a22697 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 15 20:46:27 2012 +0100 Resolves: fdo#52013 use vector::insert instead Change-Id: Ie12e5b11196b1b0f919bd18f28a0b86f60cc6513 Signed-off-by: Takeshi Abe t...@fixedpoint.jp diff --git a/sw/source/core/inc/rolbck.hxx b/sw/source/core/inc/rolbck.hxx index efb6f41..cd5a947 100644 --- a/sw/source/core/inc/rolbck.hxx +++ b/sw/source/core/inc/rolbck.hxx @@ -402,7 +402,8 @@ public: { SwpHstry::iterator itSourceBegin = pIns-m_SwpHstry.begin() + nStart; SwpHstry::iterator itSourceEnd = pIns-m_SwpHstry.end(); -std::copy( itSourceBegin, itSourceEnd, m_SwpHstry.begin() + nPos ); +if (itSourceBegin == itSourceEnd) return; +m_SwpHstry.insert(m_SwpHstry.begin() + nPos, itSourceBegin, itSourceEnd); pIns-m_SwpHstry.erase( itSourceBegin, itSourceEnd ); } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: libmspub/libmspub-0.0.1.patch libmspub/makefile.mk ooo.lst.in
libmspub/libmspub-0.0.1.patch | 339 -- libmspub/makefile.mk |6 ooo.lst.in|2 3 files changed, 3 insertions(+), 344 deletions(-) New commits: commit 4dcac7b33bf3eb8125f5ae94c27980ea863c02e0 Author: Fridrich Å trba fridrich.st...@bluewin.ch Date: Sun Jul 15 21:55:36 2012 +0200 Uploading libmspub-0.0.2 release Change-Id: I0f91e4a4d9c47d91637eac8c28d4ab3062269e35 diff --git a/libmspub/libmspub-0.0.1.patch b/libmspub/libmspub-0.0.1.patch deleted file mode 100644 index 6067ed6..000 --- a/libmspub/libmspub-0.0.1.patch +++ /dev/null @@ -1,339 +0,0 @@ misc/libmspub-0.0.1/src/lib/ColorReference.cpp 2012-07-11 23:03:45.0 +0200 -+++ misc/build/libmspub-0.0.1/src/lib/ColorReference.cpp 2012-07-12 15:13:47.840592701 +0200 -@@ -44,13 +44,13 @@ - return l.m_baseColor == r.m_baseColor l.m_modifiedColor == r.m_modifiedColor; - } - --// const unsigned char ColorReference::COLOR_PALETTE; -+// const unsigned char ColorReference::COLOR_PALETTE = 0x8; - --const unsigned char ColorReference::CHANGE_INTENSITY; -+const unsigned char ColorReference::CHANGE_INTENSITY = 0x10; - --const unsigned char ColorReference::BLACK_BASE; -+const unsigned char ColorReference::BLACK_BASE = 0x1; - --const unsigned char ColorReference::WHITE_BASE; -+const unsigned char ColorReference::WHITE_BASE = 0x2; - - } - misc/libmspub-0.0.1/src/lib/ColorReference.h 2012-07-11 23:03:07.0 +0200 -+++ misc/build/libmspub-0.0.1/src/lib/ColorReference.h 2012-07-12 15:13:47.840592701 +0200 -@@ -37,10 +37,10 @@ - { - unsigned m_baseColor; - unsigned m_modifiedColor; --// static const unsigned char COLOR_PALETTE = 0x8; -- static const unsigned char CHANGE_INTENSITY = 0x10; -- static const unsigned char BLACK_BASE = 0x1; -- static const unsigned char WHITE_BASE = 0x2; -+// static const unsigned char COLOR_PALETTE; -+ static const unsigned char CHANGE_INTENSITY; -+ static const unsigned char BLACK_BASE; -+ static const unsigned char WHITE_BASE; - Color getRealColor(unsigned c, const std::vectorColor palette) const; - public: - explicit ColorReference(unsigned color) : m_baseColor(color), m_modifiedColor(color) { } misc/libmspub-0.0.1/src/lib/MSPUBCollector.cpp 2012-07-10 08:13:15.0 +0200 -+++ misc/build/libmspub-0.0.1/src/lib/MSPUBCollector.cpp 2012-07-12 15:13:47.841592676 +0200 -@@ -28,6 +28,7 @@ - * instead of those above. - */ - -+#include math.h - #include MSPUBCollector.h - #include ShapeGroupPainter.h - #include libmspub_utils.h -@@ -35,6 +36,10 @@ - #include MSPUBTypes.h - #include PolygonUtils.h - -+#ifndef M_PI -+#define M_PI 3.14159265358979323846 -+#endif -+ - libmspub::MSPUBCollector::MSPUBCollector(libwpg::WPGPaintInterface *painter) : - m_painter(painter), m_contentChunkReferences(), m_width(0), m_height(0), - m_widthSet(false), m_heightSet(false), -@@ -364,11 +369,11 @@ - case 7: - return sqrt(valOne * valTwo * valThree); - case 8: --return atan2(valTwo, valOne) / (PI / 180); -+return atan2(valTwo, valOne) / (M_PI / 180); - case 9: --return valOne * sin(valTwo * (PI / 180) ); -+return valOne * sin(valTwo * (M_PI / 180) ); - case 10: --return valOne * cos(valTwo * (PI / 180) ); -+return valOne * cos(valTwo * (M_PI / 180) ); - case 11: - return valOne * cos(atan2(valThree, valTwo)); - case 12: -@@ -382,9 +387,9 @@ - case 0x80: - return sqrt(valThree * valThree - valOne * valOne); - case 0x81: --return (cos(valThree * (PI / 180)) * (valOne - 10800) + sin(valThree * (PI / 180)) * (valTwo - 10800)) + 10800; -+return (cos(valThree * (M_PI / 180)) * (valOne - 10800) + sin(valThree * (M_PI / 180)) * (valTwo - 10800)) + 10800; - case 0x82: --return -(sin(valThree * (PI / 180)) * (valOne - 10800) - cos(valThree * (PI / 180)) * (valTwo - 10800)) + 10800; -+return -(sin(valThree * (M_PI / 180)) * (valOne - 10800) - cos(valThree * (M_PI / 180)) * (valTwo - 10800)) + 10800; - default: - return 0; - } -@@ -623,10 +628,10 @@ - unsigned seqNum = i-first; - double *ptr_rotation = getIfExists(m_shapeRotationsBySeqNum, seqNum); - VectorTransformation2D rot = ptr_rotation ? VectorTransformation2D::fromCounterRadians((*ptr_rotation) * M_PI / 180.) -- : IDENTITY_TRANSFORMATION; -+ : VectorTransformation2D(); - std::pairbool, bool *ptr_flips = getIfExists(m_shapeFlipsBySeqNum, seqNum); - VectorTransformation2D flips = ptr_flips ? VectorTransformation2D::fromFlips(ptr_flips-second, ptr_flips-first) : -- IDENTITY_TRANSFORMATION; -+ VectorTransformation2D(); - group.m_transform = rot * flips; - Coordinate *ptr_coords = getIfExists(m_shapeCoordinatesBySeqNum, seqNum); - if (ptr_coords) -@@ -655,9 +660,9 @@ -
Re: libmspub update, running out of virtual memory
On Fri, Jul 13, 2012 at 1:41 AM, Rafael Dominguez venccsra...@gmail.com wrote: After the update to libmspub-0.0.1 a day ago, my gcc terminates with the error running out of virtual memory when compiling the PolygonUtils.cpp file (i got 4GB ram), im using gcc 4.4.5 in Gentoo Linux. My build parameters are --enable-python=system --disable-epm --with-system-boost --enable-crashdump --with-system-zlib --with-system-stdlibs --with-system-openssl --with-system-db --with-system-curl --with-system-cppunit --without-ppds --with-system-cairo --with-junit=/home/ralph/Proyectos/junit-4.10.jar --enable-symbols --enable-werror Could it be possible because the file is too big??? Hmm, After upgrading master for the first time in a while, my build fails at the same spot. log for /home/thuswa/work/libo2/libmspub Compiling: libmspub/unxlngi6.pro/misc/build/libmspub-0.0.1/src/lib/PolygonUtils.cpp g++: Internal error: Killed (program cc1plus) Please submit a full bug report. See http://bugs.opensuse.org/ for instructions. dmake: Error code 1, while making '../../../../../../unxlngi6.pro/slo/PolygonUtils.obj' dmake: Error code 255, while making './unxlngi6.pro/misc/build/so_built_mspub' Does anyone know what's going on here? Thanks! /Albert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history
On Sun, 2012-07-15 at 19:00 +0900, Takeshi Abe wrote: Please push it to master, and do we need another ack for the 3.6 branch? Pushed to master, and pushed to 3-6 with your (forged) sign off :-) C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
Hi Philipp, [...]I would suggest (kind of how you did already) to group the pro and cons per product/ application type. As a result, someone who is only interested in e.g. Calc vs. Excel might get the info on one page. By linking each point/line to a more detailed explanation further below, we might combine a quick overview with fully phrased content... Will see what I can do next Friday. [...] Your idea sounds very good. [...] Sorry, just an idea, did not check that yet: Did you already include the information from http://wiki.documentfoundation.org/ReleaseNotes/3.5 and http://wiki.documentfoundation.org/ReleaseNotes/3.6 in your list? [...] Yes, everything relevant from the Release notes should be already in the list. Greetings, Gerry ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: Feature comparison: LibreOffice - Microsoft Office in the Wiki
Hi, julien2412 wrote It's a very interesting link you gave! I added this on your page : MS Excel allows to group and outline but had no fdo bug ref (put a link about a wikihow instead) and I don't know if something is planned about this. Anyone to bring some info about this ? Julien I use this feature in LibO and previously in OOo for years. :) Gérard -- View this message in context: http://nabble.documentfoundation.org/Feature-comparison-LibreOffice-Microsoft-Office-in-the-Wiki-tp3995567p3995664.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: svx/inc svx/source
svx/inc/svx/compressgraphicdialog.hxx | 37 +++- svx/source/dialog/compressgraphicdialog.cxx | 234 ++-- svx/source/dialog/compressgraphicdialog.hrc | 56 +++--- svx/source/dialog/compressgraphicdialog.src | 189 +- 4 files changed, 365 insertions(+), 151 deletions(-) New commits: commit 660e3c1b204ac709e2acdace2a67f359505a1555 Author: Tomaž Vajngerl qui...@gmail.com Date: Sun Jul 15 22:22:45 2012 +0200 GUI improvements for CompressGraphicDialog. In CompressGraphicDialog it is possible to set the target image width and height besides resolution. Better lossless / JPEG compression selection. Added Compression / Quality settings. Change-Id: Ic8a6bfbe9dfbcd4acdfda4c0a856c3ea813a2702 diff --git a/svx/inc/svx/compressgraphicdialog.hxx b/svx/inc/svx/compressgraphicdialog.hxx index a33bb76..bf93e62 100644 --- a/svx/inc/svx/compressgraphicdialog.hxx +++ b/svx/inc/svx/compressgraphicdialog.hxx @@ -16,8 +16,8 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ -#ifndef _COMPRESS_GRAPHICS_DIALOG_HXX -#define _COMPRESS_GRAPHICS_DIALOG_HXX +#ifndef _COMPRESS_GRAPHIC_DIALOG_HXX +#define _COMPRESS_GRAPHIC_DIALOG_HXX #include vcl/dialog.hxx #include vcl/button.hxx @@ -30,19 +30,32 @@ class SVX_DLLPUBLIC CompressGraphicsDialog : public ModalDialog { private: +FixedLine m_aImageDetailsFL; FixedText m_aFixedText2X; FixedText m_aFixedText2; FixedText m_aFixedText3X; FixedText m_aFixedText3; -FixedText m_aFixedText4X; -FixedText m_aFixedText4; FixedText m_aFixedText5X; FixedText m_aFixedText5; FixedText m_aFixedText6X; FixedText m_aFixedText6; + +FixedLine m_aSettingsFL; +CheckBoxm_aReduceResolutionCB; +FixedText m_aNewWidthFT; +MetricField m_aMFNewWidth; +FixedText m_aNewHeightFT; +MetricField m_aMFNewHeight; +FixedText m_aResolutionFT; ComboBoxm_aResolutionLB; -MetricField m_aMFQuality; -CheckBoxm_aLossless; +FixedText m_aFixedTextDPI; +RadioButton m_aLosslessRB; +RadioButton m_aJpegCompRB; +FixedText m_aCompressionFT; +MetricField m_aCompressionMF; +FixedText m_aQualityFT; +MetricField m_aQualityMF; +CheckBoxm_aCropCB; OKButtonm_aBtnOK; CancelButtonm_aBtnCancel; HelpButton m_aBtnHelp; @@ -52,10 +65,20 @@ private: Sizem_aViewSize100mm; SfxBindingsm_rBindings; +double m_dResolution; + +DECL_LINK( NewWidthModifiedHdl, void* ); +DECL_LINK( NewHeightModifiedHdl, void* ); DECL_LINK( ResolutionModifiedHdl, void* ); -DECL_LINK( ClickHdl, void* ); +DECL_LINK( ToggleCompressionRB, void* ); +DECL_LINK( ToggleReduceResolutionRB, void* ); + +DECL_LINK( CalculateClickHdl, void* ); void Update(); +void UpdateNewWidthMF(); +void UpdateNewHeightMF(); +void UpdateResolutionLB(); public: CompressGraphicsDialog( Window* pParent, const Graphic rGraphic, const Size rViewSize100mm, SfxBindings rBindings ); diff --git a/svx/source/dialog/compressgraphicdialog.cxx b/svx/source/dialog/compressgraphicdialog.cxx index b1bdb6a..637af17 100644 --- a/svx/source/dialog/compressgraphicdialog.cxx +++ b/svx/source/dialog/compressgraphicdialog.cxx @@ -35,35 +35,67 @@ using namespace com::sun::star::uno; using namespace com::sun::star::beans; CompressGraphicsDialog::CompressGraphicsDialog( Window* pParent, const Graphic rGraphic, const Size rViewSize100mm, SfxBindings rBindings ) : -ModalDialog ( pParent, SVX_RES( RID_SVXDLG_COMPRESSGRAPHICS ) ), -m_aFixedText2X( this,SVX_RES( FT_CG_2_X ) ), -m_aFixedText2 ( this,SVX_RES( FT_CG_2 ) ), -m_aFixedText3X( this,SVX_RES( FT_CG_3_X ) ), -m_aFixedText3 ( this,SVX_RES( FT_CG_3 ) ), -m_aFixedText4X( this,SVX_RES( FT_CG_4_X ) ), -m_aFixedText4 ( this,SVX_RES( FT_CG_4 ) ), -m_aFixedText5X( this,SVX_RES( FT_CG_5_X ) ), -m_aFixedText5 ( this,SVX_RES( FT_CG_5 ) ), -m_aFixedText6X( this,SVX_RES( FT_CG_6_X ) ), -m_aFixedText6 ( this,SVX_RES( FT_CG_6 ) ), -m_aResolutionLB ( this,SVX_RES( LB_CG_RESOLUTION ) ), -m_aMFQuality ( this,SVX_RES( MF_CG_QUALITY ) ), -m_aLossless ( this,SVX_RES( CB_CG_LOSSLESS ) ), -m_aBtnOK ( this,SVX_RES( BUTTON_CG_OK ) ), -m_aBtnCancel ( this,SVX_RES( BUTTON_CG_CANCEL ) ), -m_aBtnHelp( this,SVX_RES( BUTTON_CG_HELP ) ), -m_aBtnCalculate ( this,SVX_RES( BUTTON_CG_CALCULATE ) ), -m_aGraphic( rGraphic ), -m_aViewSize100mm ( rViewSize100mm ), -m_rBindings
Re: gerrit for 3-6, LibreOffice gerrit bot wrong Merged status
On 15.07.2012 12:29, Bjoern Michaelsen wrote: On Sat, Jul 14, 2012 at 08:02:37PM +0400, Ivan Timofeev wrote: I am trying to use the following workflow on master: 1. git commit 2. ./logerrit submit libreoffice-3-6 just fine till now. 3. git push Huh?! What is that for? it makes no sense for me to simultaneously submit to gerrit and to push directly to master (and thus bypass gerrit). Think about it: if your patch is going to be rejected or must be adjusted what is going on with your changes that already in master? Note 1: we are going to turn on the automatic patch verification machinery (build + test). What is if your patch doesn't even compile, introduces WaE, beaks unit tests? Note 2: in the long term (unsure how long, though ;-) there will be no way to push directly to master (and bypass gerrit) anyway. Since the gerrit team seems to be struck in the philosophical question if a change is still the same on a different branch, I guess we should patch our gerrit(*). I took a look into that patch: it closes the (first) gerrit patch only if in the submitted (second) master commit the branch information is the same. But, as you pointed out gerrit can not handle it currently anyway (*), why not to follow this simple workflow: *Either* to push the patch directly to the master and send a mail to ML with cgit link and ask for review -- my i add not recommended here? ;-) --, *or* to submit it only to gerrit (master or specific branch), wait for verification and once approved and merged, push it to all other branches (manually for now or even through gerrit later). Regards David (*) I disagree with you to patch our gerrit because of that. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - dbaccess/source svtools/inc svtools/source svx/source
dbaccess/source/ui/control/dbtreelistbox.cxx |2 - svtools/inc/svtools/svlbitm.hxx | 41 +-- svtools/source/contnr/svlbitm.cxx| 20 - svtools/source/contnr/svtabbx.cxx|4 +- svtools/source/contnr/svtreebx.cxx |7 +--- svtools/source/uno/treecontrolpeer.cxx | 31 +--- svx/source/dialog/ctredlin.cxx |2 - svx/source/dialog/fontlb.cxx |2 - 8 files changed, 39 insertions(+), 70 deletions(-) New commits: commit aa3eeb28bcba10d603c15ee850620bed638514f5 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 15 21:59:04 2012 +0100 Resolves: fdo#37279 and #i78701# startEditingAtNode does nothing inherit class UnoTreeListItem from SvLBoxString instead of SvLBoxItem so that it really isa SvLBoxString and can be edited with startEditingAtNode a) remove the unused SvLBoxEntry argument to SvLBoxString's SetText b) used rtl::OUString instead of XubString c) rename aStr to maText d) inherit UnoTreeListItem from SvLBoxString and drop its maText in favour of that of SvLBoxEntry Change-Id: Id78f43ae5be8cd6f581e6c2fd2bd6f46de9144ba diff --git a/dbaccess/source/ui/control/dbtreelistbox.cxx b/dbaccess/source/ui/control/dbtreelistbox.cxx index 7e593f0..d73a435 100644 --- a/dbaccess/source/ui/control/dbtreelistbox.cxx +++ b/dbaccess/source/ui/control/dbtreelistbox.cxx @@ -120,7 +120,7 @@ SvLBoxEntry* DBTreeListBox::GetEntryPosByName( const String aName, SvLBoxEntry* { pEntry = static_castSvLBoxEntry*((*pChildren)[ i ]); SvLBoxString* pItem = (SvLBoxString*)(pEntry-GetFirstItem(SV_ITEM_ID_LBOXSTRING)); -if ( pItem-GetText().Equals(aName) ) +if ( pItem-GetText().equals(aName) ) { if ( !_pFilter || _pFilter-includeEntry( pEntry ) ) // found diff --git a/svtools/inc/svtools/svlbitm.hxx b/svtools/inc/svtools/svlbitm.hxx index 7299ec7..ae259ac 100644 --- a/svtools/inc/svtools/svlbitm.hxx +++ b/svtools/inc/svtools/svlbitm.hxx @@ -122,15 +122,16 @@ inline SvButtonState SvLBoxButtonData::GetActButtonState() const class SVT_DLLPUBLIC SvLBoxString : public SvLBoxItem { -XubString aStr; +protected: +rtl::OUString maText; public: -SvLBoxString( SvLBoxEntry*,sal_uInt16 nFlags,const XubString rStr); +SvLBoxString(SvLBoxEntry*, sal_uInt16 nFlags, const rtl::OUString rStr); SvLBoxString(); virtual ~SvLBoxString(); virtual sal_uInt16 IsA(); -virtual voidInitViewData( SvLBox*,SvLBoxEntry*,SvViewDataItem* ); -XubString GetText() const { return aStr; } -voidSetText( SvLBoxEntry*, const XubString rStr ); +virtual voidInitViewData(SvLBox*, SvLBoxEntry*, SvViewDataItem*); +rtl::OUString GetText() const { return maText; } +voidSetText( const rtl::OUString rText ) { maText = rText; } virtual voidPaint( const Point, SvLBox rDev, sal_uInt16 nFlags,SvLBoxEntry* ); virtual SvLBoxItem* Create() const; virtual voidClone( SvLBoxItem* pSource ); diff --git a/svtools/source/contnr/svlbitm.cxx b/svtools/source/contnr/svlbitm.cxx index f3a669f..509654a 100644 --- a/svtools/source/contnr/svlbitm.cxx +++ b/svtools/source/contnr/svlbitm.cxx @@ -197,11 +197,11 @@ sal_Bool SvLBoxButtonData::IsRadio() { DBG_NAME(SvLBoxString); -SvLBoxString::SvLBoxString( SvLBoxEntry* pEntry,sal_uInt16 nFlags,const XubString rStr) : -SvLBoxItem( pEntry, nFlags ) +SvLBoxString::SvLBoxString(SvLBoxEntry* pEntry, sal_uInt16 nFlags, const rtl::OUString rStr) +: SvLBoxItem(pEntry, nFlags) { DBG_CTOR(SvLBoxString,0); -SetText( pEntry, rStr ); +SetText(rStr); } SvLBoxString::SvLBoxString() : SvLBoxItem() @@ -229,10 +229,10 @@ void SvLBoxString::Paint( const Point rPos, SvLBox rDev, sal_uInt16 /* nFlags sal_uInt16 nStyle = rDev.IsEnabled() ? 0 : TEXT_DRAW_DISABLE; if ( rDev.IsEntryMnemonicsEnabled() ) nStyle |= TEXT_DRAW_MNEMONIC; -rDev.DrawText( Rectangle(rPos,GetSize(rDev,_pEntry)),aStr,nStyle); +rDev.DrawText(Rectangle(rPos, GetSize(rDev,_pEntry)), maText, nStyle); } else -rDev.DrawText( rPos, aStr); +rDev.DrawText(rPos, maText); } @@ -245,13 +245,7 @@ SvLBoxItem* SvLBoxString::Create() const void SvLBoxString::Clone( SvLBoxItem* pSource ) { DBG_CHKTHIS(SvLBoxString,0); -aStr = ((SvLBoxString*)pSource)-aStr; -} - -void SvLBoxString::SetText( SvLBoxEntry*, const XubString rStr ) -{ -DBG_CHKTHIS(SvLBoxString,0); -aStr = rStr; +maText = ((SvLBoxString*)pSource)-maText; } void SvLBoxString::InitViewData( SvLBox* pView,SvLBoxEntry* pEntry, @@ -260,7 +254,7 @@ void SvLBoxString::InitViewData( SvLBox* pView,SvLBoxEntry* pEntry,
[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source
sc/source/ui/inc/datafdlg.hxx | 13 +++-- sc/source/ui/miscdlgs/datafdlg.cxx | 17 +++-- sc/source/ui/src/datafdlg.src | 36 +--- 3 files changed, 35 insertions(+), 31 deletions(-) New commits: commit e535c1f6d4d14c27b8d963758184b2fd025d10a9 Author: Andras Timar ati...@suse.com Date: Sun Jul 15 21:18:42 2012 +0200 fdo#47947 Data Form dialog layout fix Change-Id: Ifa1689ff9be7afa14f5694825c506f7c8c3eff43 (cherry picked from commit c61e3c941d46fe1ae6066f31e01786100e39da56) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/ui/inc/datafdlg.hxx b/sc/source/ui/inc/datafdlg.hxx index bfa3769..6f41ddb 100644 --- a/sc/source/ui/inc/datafdlg.hxx +++ b/sc/source/ui/inc/datafdlg.hxx @@ -43,12 +43,13 @@ #define MAX_DATAFORM_COLS 256 #define MAX_DATAFORM_ROWS 32000 -#define CTRL_HEIGHT 22 -#define FIXED_WIDTH 60 -#define EDIT_WIDTH 140 -#define FIXED_LEFT 12 -#define EDIT_LEFT 78 -#define LINE_HEIGHT 30 +#define FIXED_WIDTH 54 +#define EDIT_WIDTH 86 +#define FIXED_HEIGHT10 +#define EDIT_HEIGHT 12 +#define FIXED_LEFT 6 +#define EDIT_LEFT 62 +#define LINE_HEIGHT 16 //zhangyun class ScDataFormDlg : public ModalDialog diff --git a/sc/source/ui/miscdlgs/datafdlg.cxx b/sc/source/ui/miscdlgs/datafdlg.cxx index 9f0f318..d87d552 100644 --- a/sc/source/ui/miscdlgs/datafdlg.cxx +++ b/sc/source/ui/miscdlgs/datafdlg.cxx @@ -163,10 +163,15 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri String aFieldName; -int nTop = 12; +//align with LAB_DATAFORM_RECORDNO +int nTop = LogicToPixel( Size(1,6), MapMode(MAP_APPFONT) ).getHeight(); +const int nOne = LogicToPixel( Size(1,1), MapMode(MAP_APPFONT) ).getHeight(); +const int nLineHeight = LogicToPixel( Size(1, LINE_HEIGHT), MapMode(MAP_APPFONT) ).getHeight(); +const int nFixedLeft = LogicToPixel( Size(FIXED_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); +const int nEditLeft = LogicToPixel( Size(EDIT_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); -SizenFixedSize(FIXED_WIDTH, CTRL_HEIGHT ); -SizenEditSize(EDIT_WIDTH, CTRL_HEIGHT ); +SizenFixedSize(LogicToPixel( Size(FIXED_WIDTH, FIXED_HEIGHT), MapMode(MAP_APPFONT) )); +SizenEditSize(LogicToPixel( Size(EDIT_WIDTH, EDIT_HEIGHT), MapMode(MAP_APPFONT) )); aColLength = nEndCol - nStartCol + 1; @@ -185,13 +190,13 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri maFixedTexts[nIndex].SetSizePixel(nFixedSize); maEdits[nIndex].SetSizePixel(nEditSize); -maFixedTexts[nIndex].SetPosPixel(Point(FIXED_LEFT, nTop)); -maEdits[nIndex].SetPosPixel(Point(EDIT_LEFT, nTop)); +maFixedTexts[nIndex].SetPosPixel(Point(nFixedLeft, nTop + nOne)); +maEdits[nIndex].SetPosPixel(Point(nEditLeft, nTop)); maFixedTexts[nIndex].SetText(aFieldName); maFixedTexts[nIndex].Show(); maEdits[nIndex].Show(); -nTop += LINE_HEIGHT; +nTop += nLineHeight; } else { diff --git a/sc/source/ui/src/datafdlg.src b/sc/source/ui/src/datafdlg.src index 5c0ee6d..0b6d01f 100644 --- a/sc/source/ui/src/datafdlg.src +++ b/sc/source/ui/src/datafdlg.src @@ -26,67 +26,66 @@ */ #include datafdlg.hrc -//zhangyun, dataform ModalDialog RID_SCDLG_DATAFORM { OutputSize = TRUE ; SVLook = TRUE ; -Size = MAP_APPFONT ( 191 , 180 ) ; +Size = MAP_APPFONT ( 257 , 180 ) ; Text [ en-US ] = Data Form ; Moveable = TRUE ; Closeable = TRUE ; FixedText LAB_DATAFORM_RECORDNO { -Pos = MAP_APPFONT ( 136 , 6 ) ; -Size = MAP_APPFONT ( 50 , 12 ) ; -Text [ en-US ] = / ; +Pos = MAP_APPFONT ( 162 , 6 ) ; +Size = MAP_APPFONT ( 60 , 12 ) ; +Text = / ; //placeholder only }; PushButton BTN_DATAFORM_NEW { -Pos = MAP_APPFONT ( 135 , 23 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 23 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; DefButton = TRUE ; Text [ en-US ] = New ; }; PushButton BTN_DATAFORM_DELETE { -Pos = MAP_APPFONT ( 135 , 40 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 40 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; Text [ en-US ] = Delete ; }; PushButton BTN_DATAFORM_RESTORE { -Pos = MAP_APPFONT ( 135 , 57 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 57 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop
[Libreoffice-commits] .: 9 commits - Makefile.top configure.in sc/qa smoketest/CppunitTest_smoketest.mk smoketest/smoketest_too.cxx solenv/gbuild svl/Module_svl.mk sw/JunitTest_sw_complex.mk
Makefile.top|8 +++- configure.in|2 +- sc/qa/extras/scdatapilottableobj.cxx|2 +- smoketest/CppunitTest_smoketest.mk |9 - smoketest/smoketest_too.cxx |1 + solenv/gbuild/JavaClassSet.mk |6 +++--- solenv/gbuild/JunitTest.mk |6 +++--- solenv/gbuild/platform/WNT_INTEL_MSC.mk |4 +--- solenv/gbuild/platform/windows.mk |2 ++ svl/Module_svl.mk |3 +++ sw/JunitTest_sw_complex.mk |8 +++- 11 files changed, 37 insertions(+), 14 deletions(-) New commits: commit 81af84c04fa7ef8c8c12d2a9d3899a9a75cb8260 Author: Michael Stahl mst...@redhat.com Date: Sun Jul 15 23:01:48 2012 +0200 gbuild: let JunitTests run with MSVC: Apparently the long path name hack is no longer necessary; at least i did not experience any obvious problem with a source tree rooted in D:/lo/master. Change-Id: I2fd1893a827c27b5dcee438eae6572c596ae907c diff --git a/solenv/gbuild/platform/WNT_INTEL_MSC.mk b/solenv/gbuild/platform/WNT_INTEL_MSC.mk index 05d7628..9519a48 100644 --- a/solenv/gbuild/platform/WNT_INTEL_MSC.mk +++ b/solenv/gbuild/platform/WNT_INTEL_MSC.mk @@ -633,10 +633,8 @@ gb_JunitTest_JunitTest_platform_longpathname_hack = endif # OOO_TEST_SOFFICE define gb_JunitTest_JunitTest_platform -$(call gb_JunitTest_JunitTest_platform_longpathname_hack,$(1)) - $(call gb_JunitTest_get_target,$(1)) : DEFS := \ - -Dorg.openoffice.test.arg.soffice={OOO_TEST_SOFFICE:-path:`cat $(call gb_JunitTest_get_target,$(1)).instpath`/opt/OpenOffice.org 3/program/soffice.exe} \ + -Dorg.openoffice.test.arg.soffice={OOO_TEST_SOFFICE:-path:$(OUTDIR)/installation/opt/program/soffice.exe} \ -Dorg.openoffice.test.arg.env=PATH \ -Dorg.openoffice.test.arg.user=file:///$(call gb_JunitTest_get_userdir,$(1)) commit 0ec45dc41dd4872482b817387f253d6fab6bf20c Author: Michael Stahl mst...@redhat.com Date: Sun Jul 15 22:58:52 2012 +0200 let make dev-install do something useful on MSVC Forcing creation of second installation set is perhaps not ideal, but i have no idea how that installer perl crud work and at least it gives something to run tests against. Change-Id: I506160013de23f76128c9e39b4f3bacc6e32cc7a diff --git a/Makefile.top b/Makefile.top index 15d27ba..a1090e2 100644 --- a/Makefile.top +++ b/Makefile.top @@ -394,7 +394,8 @@ endif build: build-packimages ifeq ($(OS_FOR_BUILD),WNT) - cd instsetoo_native unset MAKEFLAGS $(SOLARENV)/bin/build.pl + cd instsetoo_native unset MAKEFLAGS \ + $(SOLARENV)/bin/build.pl FORCE2ARCHIVE=TRUE else cd instsetoo_native unset MAKEFLAGS \ $(SOLARENV)/bin/build.pl -P$(BUILD_NCPUS) -- -P$(GMAKE_PARALLELISM) @@ -425,12 +426,17 @@ install-strip: dev-install: build @rm -rf $(DEVINSTALLDIR) @mkdir $(DEVINSTALLDIR) +ifeq ($(OS_FOR_BUILD),WNT) + unzip -d $(DEVINSTALLDIR) $(SRCDIR)/instsetoo_native/$(INPATH)/LibreOffice_Dev/archive/install/en-US/LibO*_install-arc_en-US.zip + mv $(DEVINSTALLDIR)/LibO*_install-arc_en-US/* $(DEVINSTALLDIR)/opt +else ifeq ($(DISABLE_LINKOO),TRUE) @ooinstall $(DEVINSTALLDIR)/opt @install-gdb-printers -L else @ooinstall -l $(DEVINSTALLDIR)/opt endif +endif @rm -f $(SRCDIR)/install ln -s $(DEVINSTALLDIR)/opt/ $(SRCDIR)/install distro-pack-install: install commit 01550a7450f099c4016af53fef53c286040b1575 Author: Michael Stahl mst...@redhat.com Date: Sun Jul 15 22:34:48 2012 +0200 sw: disable CheckBookmarks on WNT Change-Id: Ia52cbea28c832706cbfa74c2b1d9bca43df006d9 diff --git a/sw/JunitTest_sw_complex.mk b/sw/JunitTest_sw_complex.mk index fbfb740..c31b027 100644 --- a/sw/JunitTest_sw_complex.mk +++ b/sw/JunitTest_sw_complex.mk @@ -58,7 +58,6 @@ $(eval $(call gb_JunitTest_use_jars,sw_complex,\ $(eval $(call gb_JunitTest_add_classes,sw_complex,\ complex.accessibility.AccessibleRelationSet \ -complex.writer.CheckBookmarks \ complex.checkColor.CheckChangeColor \ complex.writer.CheckCrossReferences \ complex.writer.CheckFields\ @@ -68,4 +67,11 @@ $(eval $(call gb_JunitTest_add_classes,sw_complex,\ complex.writer.TextPortionEnumerationTest \ )) +# FIXME has never worked on windows, hashes are different +ifneq ($(OS),WNT) +$(eval $(call gb_JunitTest_add_classes,sw_complex,\ +complex.writer.CheckBookmarks \ +)) +endif + # vim: set noet sw=4 ts=4: commit 09b853e38b7a35d614caebd97116ca8a106148bd Author: Michael Stahl mst...@redhat.com Date: Sun Jul 15 22:32:09 2012 +0200 CppunitTest_svl_urihelper fails on MSVC Change-Id: Ia1154ab9e677ac0d27eb8cf671139d4e23f78794 diff --git a/svl/Module_svl.mk b/svl/Module_svl.mk index da0cb1d..d12fa3a 100644 --- a/svl/Module_svl.mk +++ b/svl/Module_svl.mk @@ -32,10 +32,13 @@ $(eval $(call
[Libreoffice-commits] .: Branch 'libreoffice-3-5' - sc/source
sc/source/ui/inc/datafdlg.hxx | 13 +++-- sc/source/ui/miscdlgs/datafdlg.cxx | 17 +++-- sc/source/ui/src/datafdlg.src | 36 +--- 3 files changed, 35 insertions(+), 31 deletions(-) New commits: commit 12b3bdea08062fb4ad8b11d63a117c50d60f5b93 Author: Andras Timar ati...@suse.com Date: Sun Jul 15 21:18:42 2012 +0200 fdo#47947 Data Form dialog layout fix Change-Id: Ifa1689ff9be7afa14f5694825c506f7c8c3eff43 (cherry picked from commit c61e3c941d46fe1ae6066f31e01786100e39da56) Signed-off-by: Caolán McNamara caol...@redhat.com diff --git a/sc/source/ui/inc/datafdlg.hxx b/sc/source/ui/inc/datafdlg.hxx index 5600d2c..ef80611 100644 --- a/sc/source/ui/inc/datafdlg.hxx +++ b/sc/source/ui/inc/datafdlg.hxx @@ -43,12 +43,13 @@ #define MAX_DATAFORM_COLS 256 #define MAX_DATAFORM_ROWS 32000 -#define CTRL_HEIGHT 22 -#define FIXED_WIDTH 60 -#define EDIT_WIDTH 140 -#define FIXED_LEFT 12 -#define EDIT_LEFT 78 -#define LINE_HEIGHT 30 +#define FIXED_WIDTH 54 +#define EDIT_WIDTH 86 +#define FIXED_HEIGHT10 +#define EDIT_HEIGHT 12 +#define FIXED_LEFT 6 +#define EDIT_LEFT 62 +#define LINE_HEIGHT 16 //zhangyun class ScDataFormDlg : public ModalDialog diff --git a/sc/source/ui/miscdlgs/datafdlg.cxx b/sc/source/ui/miscdlgs/datafdlg.cxx index 698eb7b..1cbb8d4 100644 --- a/sc/source/ui/miscdlgs/datafdlg.cxx +++ b/sc/source/ui/miscdlgs/datafdlg.cxx @@ -163,10 +163,15 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri String aFieldName; -int nTop = 12; +//align with LAB_DATAFORM_RECORDNO +int nTop = LogicToPixel( Size(1,6), MapMode(MAP_APPFONT) ).getHeight(); +const int nOne = LogicToPixel( Size(1,1), MapMode(MAP_APPFONT) ).getHeight(); +const int nLineHeight = LogicToPixel( Size(1, LINE_HEIGHT), MapMode(MAP_APPFONT) ).getHeight(); +const int nFixedLeft = LogicToPixel( Size(FIXED_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); +const int nEditLeft = LogicToPixel( Size(EDIT_LEFT, 1), MapMode(MAP_APPFONT) ).getWidth(); -SizenFixedSize(FIXED_WIDTH, CTRL_HEIGHT ); -SizenEditSize(EDIT_WIDTH, CTRL_HEIGHT ); +SizenFixedSize(LogicToPixel( Size(FIXED_WIDTH, FIXED_HEIGHT), MapMode(MAP_APPFONT) )); +SizenEditSize(LogicToPixel( Size(EDIT_WIDTH, EDIT_HEIGHT), MapMode(MAP_APPFONT) )); aColLength = nEndCol - nStartCol + 1; @@ -185,13 +190,13 @@ ScDataFormDlg::ScDataFormDlg( Window* pParent, ScTabViewShell* pTabViewShellOri maFixedTexts[nIndex].SetSizePixel(nFixedSize); maEdits[nIndex].SetSizePixel(nEditSize); -maFixedTexts[nIndex].SetPosPixel(Point(FIXED_LEFT, nTop)); -maEdits[nIndex].SetPosPixel(Point(EDIT_LEFT, nTop)); +maFixedTexts[nIndex].SetPosPixel(Point(nFixedLeft, nTop + nOne)); +maEdits[nIndex].SetPosPixel(Point(nEditLeft, nTop)); maFixedTexts[nIndex].SetText(aFieldName); maFixedTexts[nIndex].Show(); maEdits[nIndex].Show(); -nTop += LINE_HEIGHT; +nTop += nLineHeight; } else { diff --git a/sc/source/ui/src/datafdlg.src b/sc/source/ui/src/datafdlg.src index 5c0ee6d..0b6d01f 100644 --- a/sc/source/ui/src/datafdlg.src +++ b/sc/source/ui/src/datafdlg.src @@ -26,67 +26,66 @@ */ #include datafdlg.hrc -//zhangyun, dataform ModalDialog RID_SCDLG_DATAFORM { OutputSize = TRUE ; SVLook = TRUE ; -Size = MAP_APPFONT ( 191 , 180 ) ; +Size = MAP_APPFONT ( 257 , 180 ) ; Text [ en-US ] = Data Form ; Moveable = TRUE ; Closeable = TRUE ; FixedText LAB_DATAFORM_RECORDNO { -Pos = MAP_APPFONT ( 136 , 6 ) ; -Size = MAP_APPFONT ( 50 , 12 ) ; -Text [ en-US ] = / ; +Pos = MAP_APPFONT ( 162 , 6 ) ; +Size = MAP_APPFONT ( 60 , 12 ) ; +Text = / ; //placeholder only }; PushButton BTN_DATAFORM_NEW { -Pos = MAP_APPFONT ( 135 , 23 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 23 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; DefButton = TRUE ; Text [ en-US ] = New ; }; PushButton BTN_DATAFORM_DELETE { -Pos = MAP_APPFONT ( 135 , 40 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 40 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop = TRUE ; Text [ en-US ] = Delete ; }; PushButton BTN_DATAFORM_RESTORE { -Pos = MAP_APPFONT ( 135 , 57 ) ; -Size = MAP_APPFONT ( 50 , 14 ) ; +Pos = MAP_APPFONT ( 161 , 57 ) ; +Size = MAP_APPFONT ( 90 , 14 ) ; TabStop
Re: [PUSHED 3-5][PUSHED 3-6] Data Form dialog layout (fdo#47947)
On Sun, 2012-07-15 at 21:23 +0200, Andras Timar wrote: Hi, There were two problems with this dialog. First, buttons on the right were not wide enough for some languages (French, German, etc.) Second, the original developer used hardcoded pixel coordinates instead of logical coordinates, and it resulted in suboptimal layout. http://cgit.freedesktop.org/libreoffice/core/commit/?id=c61e3c941d46fe1ae6066f31e01786100e39da56 pushed to 3-5 and 3-6. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - drawinglayer/source vcl/aqua
drawinglayer/source/dumper/XShapeDumper.cxx | 36 vcl/aqua/source/window/salframeview.mm |1 2 files changed, 1 insertion(+), 36 deletions(-) New commits: commit 5e21857cd4f81ccf0c87a3f399adf29aac3a68d6 Author: Stephan Bergmann sberg...@redhat.com Date: Sun Jul 15 23:14:54 2012 +0200 -Werror,-Wunused-function Change-Id: Ie0e37aae9be1c6fcf3f8c0b8d571dc3786f38205 diff --git a/drawinglayer/source/dumper/XShapeDumper.cxx b/drawinglayer/source/dumper/XShapeDumper.cxx index 3c3d3f2..eca83e0 100644 --- a/drawinglayer/source/dumper/XShapeDumper.cxx +++ b/drawinglayer/source/dumper/XShapeDumper.cxx @@ -65,10 +65,8 @@ void dumpFillTransparenceGradientNameAsAttribute(rtl::OUString sTranspGradName, void dumpFillTransparenceGradientAsElement(com::sun::star::awt::Gradient aTranspGrad, xmlTextWriterPtr xmlWriter); void dumpFillGradientNameAsAttribute(rtl::OUString sGradName, xmlTextWriterPtr xmlWriter); void dumpFillGradientAsElement(com::sun::star::awt::Gradient aGradient, xmlTextWriterPtr xmlWriter); -void dumpFillHatchNameAsAttribute(rtl::OUString sHatchName, xmlTextWriterPtr xmlWriter); void dumpFillHatchAsElement(com::sun::star::drawing::Hatch aHatch, xmlTextWriterPtr xmlWriter); void dumpFillBackgroundAsAttribute(sal_Bool bBackground, xmlTextWriterPtr xmlWriter); -void dumpFillBitmapNameAsAttribute(rtl::OUString sBitmapName, xmlTextWriterPtr xmlWriter); void dumpFillBitmapAsElement(com::sun::star::uno::Referencecom::sun::star::awt::XBitmap xBitmap, xmlTextWriterPtr xmlWriter); void dumpFillBitmapURLAsAttribute(rtl::OUString sBitmapURL, xmlTextWriterPtr xmlWriter); void dumpFillBitmapPositionOffsetXAsAttribute(sal_Int32 aBitmapPositionOffsetX, xmlTextWriterPtr xmlWriter); @@ -151,10 +149,6 @@ void dumpTransformationAsElement(com::sun::star::drawing::HomogenMatrix3 aTransf void dumpNavigationOrderAsAttribute(sal_Int32 aNavigationOrder, xmlTextWriterPtr xmlWriter); void dumpHyperlinkAsAttribute(rtl::OUString sHyperlink, xmlTextWriterPtr xmlWriter); -// PolyPolygonBezierDescriptor.idl -void dumpPolyPolygonBezierAsElement(com::sun::star::drawing::PolyPolygonBezierCoords aPolyPolygonBezier, xmlTextWriterPtr xmlWriter); -void dumpGeometryAsElement(com::sun::star::drawing::PolyPolygonBezierCoords aGeometry, xmlTextWriterPtr xmlWriter); - // CustomShape.idl void dumpCustomShapeEngineAsAttribute(rtl::OUString sCustomShapeEngine, xmlTextWriterPtr xmlWriter); void dumpCustomShapeDataAsAttribute(rtl::OUString sCustomShapeData, xmlTextWriterPtr xmlWriter); @@ -291,12 +285,6 @@ void dumpFillGradientAsElement(awt::Gradient aGradient, xmlTextWriterPtr xmlWrit xmlTextWriterEndElement( xmlWriter ); } -void dumpFillHatchNameAsAttribute(rtl::OUString sHatchName, xmlTextWriterPtr xmlWriter) -{ -xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST(fillHatchName), %s, -rtl::OUStringToOString(sHatchName, RTL_TEXTENCODING_UTF8).getStr()); -} - void dumpFillHatchAsElement(drawing::Hatch aHatch, xmlTextWriterPtr xmlWriter) { xmlTextWriterStartElement(xmlWriter, BAD_CAST( FillHatch )); @@ -328,12 +316,6 @@ void dumpFillBackgroundAsAttribute(sal_Bool bBackground, xmlTextWriterPtr xmlWri xmlTextWriterWriteFormatAttribute( xmlWriter, BAD_CAST(fillBackground), %s, false); } -void dumpFillBitmapNameAsAttribute(rtl::OUString sBitmapName, xmlTextWriterPtr xmlWriter) -{ -xmlTextWriterWriteFormatAttribute(xmlWriter, BAD_CAST(fillGradientName), %s, -rtl::OUStringToOString(sBitmapName, RTL_TEXTENCODING_UTF8).getStr()); -} - void dumpFillBitmapAsElement(uno::Referenceawt::XBitmap xBitmap, xmlTextWriterPtr xmlWriter) { xmlTextWriterStartElement(xmlWriter, BAD_CAST( FillBitmap )); @@ -1096,24 +1078,6 @@ void dumpShapeDescriptorAsAttribute( uno::Reference drawing::XShapeDescriptor rtl::OUStringToOString(xDescr-getShapeType(), RTL_TEXTENCODING_UTF8).getStr()); } -// - -// -- PolyPolygonBezierDescriptor.idl -- -// - - -void dumpPolyPolygonBezierAsElement(drawing::PolyPolygonBezierCoords aPolyPolygonBezier, xmlTextWriterPtr xmlWriter) -{ -xmlTextWriterStartElement(xmlWriter, BAD_CAST( PolyPolygonBezier )); -dumpPolyPolygonBezierCoords(aPolyPolygonBezier, xmlWriter); -xmlTextWriterEndElement( xmlWriter ); -} - -void dumpGeometryAsElement(drawing::PolyPolygonBezierCoords aGeometry, xmlTextWriterPtr xmlWriter) -{ -xmlTextWriterStartElement(xmlWriter, BAD_CAST( Geometry )); -dumpPolyPolygonBezierCoords(aGeometry, xmlWriter); -xmlTextWriterEndElement( xmlWriter ); -} - // - // -- CustomShape.idl -- // - commit 27b1aa88c00fc425f658aba8e64567f6d2bfbd0f Author: Stephan Bergmann sberg...@redhat.com Date: Sun Jul 15 23:08:46 2012 +0200 #include
[Libreoffice-commits] .: 2 commits - connectivity/inc connectivity/source svtools/inc svtools/source svx/source unusedcode.easy
connectivity/inc/connectivity/dbconversion.hxx |3 - connectivity/source/commontools/dbconversion.cxx | 23 - svtools/inc/svtools/svlbitm.hxx |1 svtools/source/contnr/svlbitm.cxx| 12 svx/source/dialog/compressgraphicdialog.cxx |7 -- unusedcode.easy | 56 +++ 6 files changed, 21 insertions(+), 81 deletions(-) New commits: commit afdb80205679937a4d7503dc3715f39a4774a201 Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 15 22:50:52 2012 +0100 WaE: unused variables and misordered initialization list Change-Id: I2f49383d5c9e097edf52776818db4e89497aca5c diff --git a/svx/source/dialog/compressgraphicdialog.cxx b/svx/source/dialog/compressgraphicdialog.cxx index 637af17..bc6afa6 100644 --- a/svx/source/dialog/compressgraphicdialog.cxx +++ b/svx/source/dialog/compressgraphicdialog.cxx @@ -56,10 +56,10 @@ CompressGraphicsDialog::CompressGraphicsDialog( Window* pParent, const Graphic m_aFixedTextDPI ( this,SVX_RES( FT_DPI ) ), m_aLosslessRB ( this,SVX_RES( RB_LOSSLESS_COMPRESSION ) ), m_aJpegCompRB ( this,SVX_RES( RB_JPEG_COMPRESSION ) ), -m_aCompressionMF( this,SVX_RES( MF_COMPRESSION_FACTOR ) ), m_aCompressionFT( this,SVX_RES( FT_COMPRESSION ) ), -m_aQualityMF( this,SVX_RES( MF_QUALITY_FACTOR ) ), +m_aCompressionMF( this,SVX_RES( MF_COMPRESSION_FACTOR ) ), m_aQualityFT( this,SVX_RES( FT_QUALITY ) ), +m_aQualityMF( this,SVX_RES( MF_QUALITY_FACTOR ) ), m_aCropCB ( this,SVX_RES( CB_CROP ) ), m_aBtnOK( this,SVX_RES( BUTTON_CG_OK ) ), m_aBtnCancel( this,SVX_RES( BUTTON_CG_CANCEL ) ), @@ -140,9 +140,6 @@ void CompressGraphicsDialog::Update() aViewSizeString += ( DPI ) ; m_aFixedText3.SetText(aViewSizeString); -int nPixelX = (sal_Int32)((double)MetricField::ConvertValue(m_aViewSize100mm.Width(), 2, MAP_100TH_MM, FUNIT_INCH) / 100 * m_dResolution ); -int nPixelY = (sal_Int32)((double)MetricField::ConvertValue(m_aViewSize100mm.Height(), 2, MAP_100TH_MM, FUNIT_INCH) / 100 * m_dResolution ); - SvMemoryStream aMemStream; aMemStream.SetVersion( SOFFICE_FILEFORMAT_CURRENT ); m_aGraphic.ExportNative(aMemStream); commit bfcaa777c4a803c21208c8aeb8f2674943b243fb Author: Caolán McNamara caol...@redhat.com Date: Sun Jul 15 22:27:46 2012 +0100 callcatcher: update unused code list Change-Id: I045ac2928d4b8cf99f9f76c20a9e489adc34ed66 diff --git a/connectivity/inc/connectivity/dbconversion.hxx b/connectivity/inc/connectivity/dbconversion.hxx index 0f16414..78df8d0 100644 --- a/connectivity/inc/connectivity/dbconversion.hxx +++ b/connectivity/inc/connectivity/dbconversion.hxx @@ -115,9 +115,6 @@ namespace dbtools static ::com::sun::star::util::DateTime toDateTime(const ::rtl::OUString _sSQLDate); -/** return the given DateTime as JDBC compliant 64 bit value -*/ -static sal_Int64 toINT64(const ::com::sun::star::util::DateTime rVal); static sal_Int32 getMsFromTime(const ::com::sun::star::util::Time rVal); static sal_Int32 toDays(const ::com::sun::star::util::Date _rVal, const ::com::sun::star::util::Date _rNullDate = getStandardDate()); diff --git a/connectivity/source/commontools/dbconversion.cxx b/connectivity/source/commontools/dbconversion.cxx index bed868c..087495d 100644 --- a/connectivity/source/commontools/dbconversion.cxx +++ b/connectivity/source/commontools/dbconversion.cxx @@ -137,29 +137,6 @@ namespace dbtools } //-- -sal_Int64 DBTypeConversion::toINT64(const DateTime rVal) -{ -// normalize time -sal_Int32 nSeconds = rVal.Seconds + rVal.HundredthSeconds / 100; -sal_Int32 nHundredthSeconds = rVal.HundredthSeconds % 100; -sal_Int32 nMinutes = rVal.Minutes + nSeconds / 60; -nSeconds= nSeconds % 60; -sal_Int32 nHours= rVal.Hours + nMinutes / 60; -nMinutes= nMinutes % 60; - -// assemble time -sal_Int32 nTime = (sal_Int32)(nHundredthSeconds + (nSeconds*100) + (nMinutes*1) + (nHours*100)); -sal_Int32 nDate = ((sal_Int32)(rVal.Day%100)) + (((sal_Int32)(rVal.Month%100))*100) + (((sal_Int32) rVal.Year%1)*1); -sal_Int64 nRet; - -nRet = (sal_Int64) nTime; -nRet = 32; -nRet += nDate; - -return nRet; -} - - //-- sal_Int32 DBTypeConversion::getMsFromTime(const Time rVal) { sal_Int32 nHour = rVal.Hours; diff --git
[PATCH] Undo Calc TabBar items native rendering
Hello, As my commit 17ea32a1a36d81a0a12df12adbe15e8eaf1c7c62 breaks tab coloring functionality, and there's no good enough way to fix it, plus it is likely to break Windows tabbar items look, this patch reverts that commit. Regards, Ruslan 0004-Revert-Make-bottom-tabbar-items-follow-native-theme.patch Description: Binary data ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: libmspub update, running out of virtual memory
On Sun, Jul 15, 2012 at 3:45 PM, Albert Thuswaldner albert.thuswald...@gmail.com wrote: On Fri, Jul 13, 2012 at 1:41 AM, Rafael Dominguez venccsra...@gmail.com wrote: After the update to libmspub-0.0.1 a day ago, my gcc terminates with the error running out of virtual memory when compiling the PolygonUtils.cpp file (i got 4GB ram), im using gcc 4.4.5 in Gentoo Linux. My build parameters are --enable-python=system --disable-epm --with-system-boost --enable-crashdump --with-system-zlib --with-system-stdlibs --with-system-openssl --with-system-db --with-system-curl --with-system-cppunit --without-ppds --with-system-cairo --with-junit=/home/ralph/Proyectos/junit-4.10.jar --enable-symbols --enable-werror Could it be possible because the file is too big??? Hmm, After upgrading master for the first time in a while, my build fails at the same spot. log for /home/thuswa/work/libo2/libmspub Compiling: libmspub/unxlngi6.pro/misc/build/libmspub-0.0.1/src/lib/PolygonUtils.cpp g++: Internal error: Killed (program cc1plus) Please submit a full bug report. See http://bugs.opensuse.org/ for instructions. dmake: Error code 1, while making '../../../../../../unxlngi6.pro/slo/PolygonUtils.obj' dmake: Error code 255, while making './unxlngi6.pro/misc/build/so_built_mspub' Does anyone know what's going on here? Thanks! /Albert Its fixed now, pull latest master ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[PATCH] fdo#50269: bitmap area fill pattern reversed in LO3.5.x
From Takeshi Abe t...@fixedpoint.jp: Takeshi Abe has uploaded a new change for review. Change subject: fdo#50269: bitmap area fill pattern reversed in LO3.5.x .. fdo#50269: bitmap area fill pattern reversed in LO3.5.x this partially reverted 619ea0c6d3b8fb4390bf5e82f1b44608c3cd878d in order to retain a hack for non-black background color Change-Id: I89d89cedb5e27e2a05b1ecc13569e4899d1743d2 --- M filter/source/msfilter/msdffimp.cxx 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://gerrit.libreoffice.org:29418/core refs/changes/18/318/1 -- To view, visit https://gerrit.libreoffice.org/318 To unsubscribe, visit https://gerrit.libreoffice.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89d89cedb5e27e2a05b1ecc13569e4899d1743d2 Gerrit-PatchSet: 1 Gerrit-Project: core Gerrit-Branch: master Gerrit-Owner: Takeshi Abe t...@fixedpoint.jp ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: gerrit for 3-6, LibreOffice gerrit bot wrong Merged status
Hi David, On Sun, Jul 15, 2012 at 10:53:42PM +0200, David Ostrovsky wrote: Huh?! What is that for? it makes no sense for me to simultaneously submit to gerrit and to push directly to master (and thus bypass gerrit). Yes, it does make sense. You can push to master directly and still do the (required) review for the release branch on gerrit. Note 2: in the long term (unsure how long, though ;-) there will be no way to push directly to master (and bypass gerrit) anyway. Thats not true. There will always be a way to push directly to master for Commiters. That might summon an instant forks-and-torches-mob in the future if by doing so you break master (while everyone else does not and is reasonably sure about that through means of gerrit), but it will still be possible. *or* to submit it only to gerrit (master or specific branch), wait for verification and once approved and merged, push it to all other branches (manually for now or even through gerrit later). That wont work with gerrit as gerrit will reject the change as I have already seen this one on any branch after that (which is the unfortunate behavior). So without patching gerrit, we need tooling to regenerate the Change-Id upon cherry-pick for review. Best, Bjoern ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [PUSHED 3-6] fdo#52013: Writer will crash when the undo-redoing if it contains dummy text in history
On Sun, 15 Jul 2012 21:15:42 +0100, Caolán McNamara caol...@redhat.com wrote: On Sun, 2012-07-15 at 19:00 +0900, Takeshi Abe wrote: Please push it to master, and do we need another ack for the 3.6 branch? Pushed to master, and pushed to 3-6 with your (forged) sign off :-) Thanks a lot :) Cheers, -- Takeshi Abe C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 2 commits - sc/source
sc/source/ui/condformat/colorformat.cxx |2 - sc/source/ui/condformat/condformatdlg.cxx | 40 ++ sc/source/ui/inc/condformatdlg.hxx|1 3 files changed, 42 insertions(+), 1 deletion(-) New commits: commit b85a2af72e3ce0a4111972d51c8f1d43599dee5e Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Jul 16 04:21:40 2012 +0200 disable edit field for min and max type, fdo#51834 Change-Id: Id77c58f333bfab5446cf96d24cd9ccfc18802862 diff --git a/sc/source/ui/condformat/condformatdlg.cxx b/sc/source/ui/condformat/condformatdlg.cxx index 2ec2dc7..f77fe37 100644 --- a/sc/source/ui/condformat/condformatdlg.cxx +++ b/sc/source/ui/condformat/condformatdlg.cxx @@ -173,6 +173,10 @@ ScCondFrmtEntry::ScCondFrmtEntry(Window* pParent, ScDocument* pDoc): SwitchToType(COLLAPSED); SetHeight(); SetCondType(); + +EntryTypeHdl(maLbEntryTypeMin); +EntryTypeHdl(maLbEntryTypeMiddle); +EntryTypeHdl(maLbEntryTypeMax); } ScCondFrmtEntry::ScCondFrmtEntry(Window* pParent, ScDocument* pDoc, const ScFormatEntry* pFormatEntry): @@ -297,6 +301,10 @@ ScCondFrmtEntry::ScCondFrmtEntry(Window* pParent, ScDocument* pDoc, const ScForm maClickHdl = LINK( pParent, ScCondFormatList, EntrySelectHdl ); SwitchToType(COLLAPSED); SetHeight(); + +EntryTypeHdl(maLbEntryTypeMin); +EntryTypeHdl(maLbEntryTypeMiddle); +EntryTypeHdl(maLbEntryTypeMax); } ScCondFrmtEntry::~ScCondFrmtEntry() @@ -307,6 +315,12 @@ void ScCondFrmtEntry::Init() { maLbType.SetSelectHdl( LINK( this, ScCondFrmtEntry, TypeListHdl ) ); maLbColorFormat.SetSelectHdl( LINK( this, ScCondFrmtEntry, ColFormatTypeHdl ) ); +maLbEntryTypeMin.SetSelectHdl( LINK( this, ScCondFrmtEntry, EntryTypeHdl ) ); +maLbEntryTypeMax.SetSelectHdl( LINK( this, ScCondFrmtEntry, EntryTypeHdl ) ); +maLbEntryTypeMiddle.SetSelectHdl( LINK( this, ScCondFrmtEntry, EntryTypeHdl ) ); + + + SfxStyleSheetIterator aStyleIter( mpDoc-GetStyleSheetPool(), SFX_STYLE_FAMILY_PARA ); for ( SfxStyleSheetBase* pStyle = aStyleIter.First(); pStyle; pStyle = aStyleIter.Next() ) { @@ -813,6 +827,31 @@ IMPL_LINK_NOARG(ScCondFrmtEntry, ColFormatTypeHdl) return 0; } +IMPL_LINK( ScCondFrmtEntry, EntryTypeHdl, ListBox*, pBox ) +{ +bool bEnableEdit = true; +sal_Int32 nPos = pBox-GetSelectEntryPos(); +if(nPos == 0 || nPos == 1) +{ +bEnableEdit = false; +} + +Edit* pEd = NULL; +if(pBox == maLbEntryTypeMin) +pEd = maEdMin; +else if(pBox == maLbEntryTypeMiddle) +pEd = maEdMiddle; +else if(pBox == maLbEntryTypeMax) +pEd = maEdMax; + +if(bEnableEdit) +pEd-Enable(); +else +pEd-Disable(); + +return 0; +} + IMPL_LINK_NOARG(ScCondFrmtEntry, StyleSelectHdl) { if(maLbStyle.GetSelectEntryPos() == 0) @@ -906,6 +945,7 @@ IMPL_LINK_NOARG( ScCondFrmtEntry, ConditionTypeSelectHdl ) { maEdVal2.Hide(); } + return 0; } diff --git a/sc/source/ui/inc/condformatdlg.hxx b/sc/source/ui/inc/condformatdlg.hxx index 2c53ab0..46938b9 100644 --- a/sc/source/ui/inc/condformatdlg.hxx +++ b/sc/source/ui/inc/condformatdlg.hxx @@ -124,6 +124,7 @@ private: DECL_LINK( OptionBtnHdl, void* ); DECL_LINK( DataBarTypeSelectHdl, void* ); DECL_LINK( ConditionTypeSelectHdl, void* ); +DECL_LINK( EntryTypeHdl, ListBox* ); public: ScCondFrmtEntry( Window* pParent, ScDocument* pDoc ); commit e11c88d999ad9cab8e309c87088d433fde0d4d9d Author: Markus Mohrhard markus.mohrh...@googlemail.com Date: Mon Jul 16 04:02:23 2012 +0200 use correct value to check for min and max, fdo#51831 Change-Id: I8a5412bc9c22048dd8f6618b38e5a522b7ea02c2 diff --git a/sc/source/ui/condformat/colorformat.cxx b/sc/source/ui/condformat/colorformat.cxx index 867f29f..daa14a8 100644 --- a/sc/source/ui/condformat/colorformat.cxx +++ b/sc/source/ui/condformat/colorformat.cxx @@ -288,7 +288,7 @@ IMPL_LINK_NOARG( ScDataBarSettingsDlg, OkBtnHdl ) mpNumberFormatter-IsNumberFormat(aMinString, nIndex, nMinValue); nIndex = 0; double nMaxValue = 0; -mpNumberFormatter-IsNumberFormat(aMaxString, nIndex, nMinValue); +mpNumberFormatter-IsNumberFormat(aMaxString, nIndex, nMaxValue); if(rtl::math::approxEqual(nMinValue, nMaxValue) || nMinValue nMaxValue) bWarn = true; } ___ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[REVIEW-3-6] fix for fdo#51834, disable edit field for min and max type
Hey, [1] prevents that the edit field is enabled as long as the selected type is min or max. For min and max the value is automatically calculated based on the selected range. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=b85a2af72e3ce0a4111972d51c8f1d43599dee5e ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[REVIEW-3-6] fix for fdo#51831, use correct entry to check for max value
Hey, [1] fixes a copypaste error that results in the max value not being correctly checked. The value has been applied correctly so that the bug only is visible in the case of min being = 0. Regards, Markus [1] http://cgit.freedesktop.org/libreoffice/core/commit/?id=e11c88d999ad9cab8e309c87088d433fde0d4d9d ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [REVIEW 3-6, 3-5] n#759210: Certain smartart drawings weren't imported
Hello all, On Tue, Jul 10, 2012 at 8:59 PM, Korrawit Pruegsanusak detective.conan.1...@gmail.com wrote: The commit 11c5699dad06fb0d7fc0e458550a1dac82f8ee5f also fix fdo#50907 on master, so I propose this review for the inclusion in both -3-6 and -3-5 branches. [snip] Last, sorry to say this, but I didn't have time to test if it could be build or even fix the problem. (I didn't test in both branches, but tested in master that this really fixes the problem, please see comment 11 in fdo bugzilla). I've tested a build in -3-6 branch, with the attached patch on top of http://cgit.freedesktop.org/libreoffice/core/commit/?h=libreoffice-3-6id=0054c76b0f3d5bdbaef73a696ce3cf930be9c16b and it really fix fdo#50907. I didn't test with other pptx files, nor in -3-5 branch. Best Regards, -- Korrawit Pruegsanusak ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice-commits] .: 3 commits - comphelper/inc comphelper/source .gitignore sc/source sfx2/Library_sfx.mk unusedcode.easy
.gitignore |3 - comphelper/inc/comphelper/SelectionMultiplex.hxx |5 - comphelper/source/misc/SelectionMultiplex.cxx| 10 --- sc/source/filter/inc/sheetdatabuffer.hxx | 45 - sc/source/filter/oox/sheetdatabuffer.cxx | 58 --- sfx2/Library_sfx.mk | 15 - unusedcode.easy |3 - 7 files changed, 2 insertions(+), 137 deletions(-) New commits: commit e9e3bd0659e761b5b9409d61ae831afc59b983cf Author: Matúš Kukan matus.ku...@gmail.com Date: Mon Jul 16 00:23:44 2012 +0200 do not hide .patch files to hide more, try git config --global core.excludesfile Change-Id: I1da4131b943a962797a1f389554139e87fe074bc diff --git a/.gitignore b/.gitignore index 45d72d0..c1aef58 100644 --- a/.gitignore +++ b/.gitignore @@ -130,6 +130,3 @@ test/user-template/user/psprint/pspfontcache # Somepeople love debugging gdbtrace.log valgrind.log - -#patches -*.patch commit 31b05fe9ffdc043211a6bd7216a809ab500b9691 Author: Matúš Kukan matus.ku...@gmail.com Date: Mon Jul 16 00:20:25 2012 +0200 unusedcode: drop CellBlock and one small method Change-Id: I7cad80ea59b4527193a35ea1b7cfdd56e07a0efe diff --git a/comphelper/inc/comphelper/SelectionMultiplex.hxx b/comphelper/inc/comphelper/SelectionMultiplex.hxx index 390b3ff..56e8375 100644 --- a/comphelper/inc/comphelper/SelectionMultiplex.hxx +++ b/comphelper/inc/comphelper/SelectionMultiplex.hxx @@ -56,11 +56,6 @@ namespace comphelper virtual void _disposing(const ::com::sun::star::lang::EventObject _rSource) throw( ::com::sun::star::uno::RuntimeException); protected: -/** If the derivee also owns the mutex which we know as reference, then call this within your -derivee's dtor. -*/ -voiddisposeAdapter(); - // pseudo-private. Making it private now could break compatibility voidsetAdapter( OSelectionChangeMultiplexer* _pAdapter ); }; diff --git a/comphelper/source/misc/SelectionMultiplex.cxx b/comphelper/source/misc/SelectionMultiplex.cxx index ca267e7..aa3092d 100644 --- a/comphelper/source/misc/SelectionMultiplex.cxx +++ b/comphelper/source/misc/SelectionMultiplex.cxx @@ -47,16 +47,6 @@ void OSelectionChangeListener::_disposing(const EventObject) throw( RuntimeExce } //-- -void OSelectionChangeListener::disposeAdapter() -{ -if ( m_pAdapter ) -m_pAdapter-dispose(); - -// will automatically set a new adapter -OSL_ENSURE( !m_pAdapter, OSelectionChangeListener::disposeAdapter: what did dispose do? ); -} - -//-- void OSelectionChangeListener::setAdapter(OSelectionChangeMultiplexer* pAdapter) { if (m_pAdapter) diff --git a/sc/source/filter/inc/sheetdatabuffer.hxx b/sc/source/filter/inc/sheetdatabuffer.hxx index 898d039..7c4e32e 100644 --- a/sc/source/filter/inc/sheetdatabuffer.hxx +++ b/sc/source/filter/inc/sheetdatabuffer.hxx @@ -90,48 +90,6 @@ struct DataTableModel // -/** Stores position and contents of a range of cells for optimized import. */ -class CellBlock : public WorksheetHelper -{ -public: -explicitCellBlock( const WorksheetHelper rHelper, const ValueRange rColSpan, sal_Int32 nRow ); - -/** Writes all buffered cells into the Calc sheet. */ -voidfinalizeImport(); - -private: -/** Fills unused cells before passed index with empty strings. */ -voidfillUnusedCells( sal_Int32 nIndex ); - -private: -/** Stores position and string data of a rich-string cell. */ -struct RichStringCell -{ -::com::sun::star::table::CellAddress -maCellAddr; /// The address of the rich-string cell. -RichStringRef mxString; /// The string with rich formatting. -const Font* mpFirstPortionFont; /// Font information from cell for first text portion. - -explicitRichStringCell( -const ::com::sun::star::table::CellAddress rCellAddr, -const RichStringRef rxString, -const Font* pFirstPortionFont ); -}; -typedef ::std::list RichStringCell RichStringCellList; - -::com::sun::star::table::CellRangeAddress -maRange;/// Cell range covered by this cell block. -RichStringCellList maRichStrings; /// Cached rich-string cells. -::com::sun::star::uno::Sequence ::com::sun::star::uno::Sequence ::com::sun::star::uno::Any -maCellArray;/// The array of cells of this cell block. -::com::sun::star::uno::Any* -
[Libreoffice-qa] Insulting comments in bug reports: what should we do?
Dear QA community, I have just stumbled over the first comment to https://bugs.freedesktop.org/show_bug.cgi?id=52066 FILEOPEN: RTF file opens with black boxes, ugly formatting In this comment, Urmas davian...@gmail.com wrote: So that clown vmiklos cannot grasp the concept of multilingual fonts in DOC/RTF after _more than a year_? Pathetic. Should we make a fundrasing to buy him a normal office suite so he could practice? Please don't get me wrong: I don't want to blame Urmas, maybe he had a bad day. But I am really concerned about what the original bug reporter will think about us (LibreOffice, the developers, the QA volunteers) when the first reply he gets to his report is a comment of this kind. Additionally, whatever one thinks about the new RTF filters, I consider it as completely inappropriate to tell a developer a clown and to insult him personally. And this is not the only strange comment by Urmas. See https://bugs.freedesktop.org/show_bug.cgi?id=52071 FILEOPEN: The Greek codepage in styles of a RTF file where Urmas claims: Still, RTF support in LO is completely broken. DON'T USE IT. which is IMHO (a) wrong -- RTF support works quite well for me, at least, it is not completely broken -- and (b) damages the image of LibreOffice. Additionally, in the same short comment, Urmas even manages to insult the original reporter, too: How the f..l is that Greek? Had you forgot physics lessons from 6th grade? First I wanted to write to Urmas, but I then I wanted to ask you first what you all think what we should do. It is always difficult to built a working QA community, but easy to disturb or even to distroy it by such comments. Again: what do you think? Best, Roman ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] Insulting comments in bug reports: what should we do?
On 07/15/2012 05:51 PM, Roman Eisele wrote: Dear Roman, In this comment, Urmas davian...@gmail.com wrote: First I wanted to write to Urmas, but I then I wanted to ask you first what you all think what we should do. It is always difficult to built a working QA community, but easy to disturb or even to distroy it by such comments. Again: what do you think? This is not an isolated incident from that person, and I was beginning to wonder myself whether he/she had other issues which might be coming to the surface through the comments made. Most of the ones I have seen from this person could be interpreted as highly aggressive and, yes, I would agree that some, especially the initial bug reporter, might take offence. What might be done, however, is a difficult question to answer : perhaps a friendly and encouraging word from others here, reminding him/her that this is a community and that as such we are ultimately trying to help people and determine, at least for the bug triaging process, whether the reported behaviour is indeed a bug. I would also agree that personal attacks are unwarranted, on other lists and forums, a person could be banned for that outright by the admins or moderators. I still feel it better to contact person directly, to try and understand why there is such apparent animosity, especially since we know nothing of their circumstances, and it is rather unfair to talk about what we should do in their absence (unless he/she is following this list). I have a concern, however, that approaching Urmas in the gentle way might just lead to more trolling which would ultimately get us nowhere... Alex ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 52104] With JRE7 links in LOCALHELP lead to WIKIHELP although help module is installed
https://bugs.freedesktop.org/show_bug.cgi?id=52104 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|All |Windows (All) Status|UNCONFIRMED |NEEDINFO CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 Summary|LOCALHELP: Help opens only |With JRE7 links in |on web, although help |LOCALHELP lead to WIKIHELP |module is installed |although help module is ||installed --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 06:02:48 UTC --- @Sergejs Ušakovs Unfortunately your step by step instruction ends where it becomes interesting. Open any help Topics is not useful I can't see whether LOCALHELP doesn't work at all or whether it appears, but then all links lead to WIKIHELP. Please contribute a detailled example and modify Summary line if necessary If possible: can you check what happens after you have activated JRE6? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52108] New: CRASH on any action for particular big .odt
https://bugs.freedesktop.org/show_bug.cgi?id=52108 Bug #: 52108 Summary: CRASH on any action for particular big .odt Classification: Unclassified Product: LibreOffice Version: 3.5.5.3 release Platform: Other OS/Version: Windows (All) Status: UNCONFIRMED Severity: major Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: libreoff...@bielefeldundbuss.de Steps how to reproduce with Server Installation of LibreOffice 3.6.0.1 rc German UI/Locale [Build-ID: 73f9fb6] on German WIN7 Home Premium (64bit): 0. Download sample document attachment 61925 of Bug 48932 1. Launch LibO 3.6 Start center appears 2. Menu 'File - Open - Sample document' 3. Menu 'Tools - Word count' As expected word count message box appears Bug: Crash In other attempts Crash already happens when I click Tools or do other smaller actions. With a little luck LigO will only hang for some seconds or minutes, but very very often I see a crash. Same with 3.5.5.3, other 3.5 not tested. Still [Reproducible] with parallel installation of Master LOdev 3.7.0.0.alpha0+ - WIN7 Home Premium (64bit) ENGLISH UI [Build ID: 25608fb] (tinderbox: 2008R2@20, pull time 2012-07-14 00:31:17) Works fine with LibreOffice 3.4.5 German UI [Build ID: OOO340m1 (Build:502)] parallel Server installation on German WIN7 Home Premium (64bit), so REGRESSION This one might be a DUP of Bug 52080, but currently that one is for Linux 7 3.6.0.1 rc, so I can't see whether we are talking about the same problem. Related bugs might be Bug 48932, Bug 48011 Of course 7000 pages are not a standard application, but we had this working with 3.4.5, so 3.5 MAB -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52108] CRASH on any action for particular big .odt
https://bugs.freedesktop.org/show_bug.cgi?id=52108 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 07:20:59 PDT --- Also unusable: LibreOffice 3.5.1.2 German UI/Locale [Build-ID: dc9775d-05ecbee-0851ad3-1586698-727bf66] on German WIN7 Home Premium (64bit) also crashes simply gambling in the menus. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52108] CRASH on any action for particular big .odt
https://bugs.freedesktop.org/show_bug.cgi?id=52108 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Version|3.5.5.3 release |3.5.1 release -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51756] problem viewing, printing with control formular
https://bugs.freedesktop.org/show_bug.cgi?id=51756 --- Comment #4 from choffardet pierre.choffar...@free.fr 2012-07-15 07:25:33 PDT --- Thank you trying to help me Yes, my English is ugly. English is not my native language I gave three files : With the first one, just open it. Make a print preview, and look at the differences. And print it and Look at the differences again. The second file, the pdf file, is the print result that I have with my computer I gave a third file, with contain a screen copy of calc, a screen copy of calc , and a screen copy of the pdf file with is the print result. On this file, I tried to show the differences. what is a cursor ? I don't now the English name of this. but on the first file, there are four of them. It is something from witch I can move the position of a square. When printing it, I can't see the square. Sometime the square is always at the beginning (when printing it) whatever position it is on calc I tried to do my best to be understood -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 --- Comment #346 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 07:29:05 UTC --- Add Bug 52108 - CRASH on any action for particular big .odt. 7000 pages document is nothing affecting many users, but we had it working in 3.4, and who can know whether we also have an increased vulnerability with some hundreds pages documents? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 31821] Writer ignores OpenType ligatures.
https://bugs.freedesktop.org/show_bug.cgi?id=31821 Caolán McNamara caol...@redhat.com changed: What|Removed |Added OS/Version|All |Linux (All) Status|NEW |RESOLVED Resolution||FIXED --- Comment #19 from Caolán McNamara caol...@redhat.com 2012-07-15 07:30:38 PDT --- original example works in master now under Linux, other platform's milage may differ -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52080] Large files become unresponsive since version 3.5.0
https://bugs.freedesktop.org/show_bug.cgi?id=52080 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|Linux (All) |All Severity|critical|major CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 07:32:20 PDT --- Fix for Bug 48932 - EDITING: Writer 3.5.2 slow typing in large documents did not solve user's problem. More or less [Reproducible] with reporter's sample and Server Installation of LibreOffice 3.6.0.1 rc German UI/Locale [Build-ID: 73f9fb6] on German WIN7 Home Premium (64bit). After small edits (delete first character) LibO stops responding for several seconds or minutes, sometimes even crashes with WIN error message. Because this one is reported as a 3.6 problem for hangs, I submitted Bug 52108 - CRASH on any action for particular big .odt for a CRASH problem, but I am pretty sure that that one has the same roots like this bug. No problem with 3.4.5 @David https://wiki.documentfoundation.org/QA-FAQ#How_to_use_attached_sample_documents_for_multiple_Bug_Reports -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52093] INSTALLATION: MSI issues
https://bugs.freedesktop.org/show_bug.cgi?id=52093 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 07:34:47 UTC --- @João Are there any visible consequences for users? If yes, what ones? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51756] problem viewing, printing with control formular
https://bugs.freedesktop.org/show_bug.cgi?id=51756 --- Comment #5 from choffardet pierre.choffar...@free.fr 2012-07-15 07:45:26 UTC --- I've downloaded an English version of LibreOffice I'm talking about scrollbar -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50868] Libvisio: Draw Crash/Freeze on loading MS Lync Server 2010 Topology Sample Visio Files
https://bugs.freedesktop.org/show_bug.cgi?id=50868 --- Comment #19 from Julien Nabet serval2...@yahoo.fr 2012-07-15 08:12:46 PDT --- There's a link about files bigger than 3MB, see here: http://wiki.documentfoundation.org/QA/Bugzilla-Attachments -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51924] Writer butchers Table of Contents in .doc
https://bugs.freedesktop.org/show_bug.cgi?id=51924 Julien Nabet serval2...@yahoo.fr changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de --- Comment #4 from Julien Nabet serval2...@yahoo.fr 2012-07-15 08:16:53 PDT --- Rainer: what do you think ? Should we put this RESOLVED/NOTOURBUG and create a new bugtracker for enhancement (take into account a kind of bug from Word) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 49832] PRINTING: Writer rasterizes SVG for output to a printer or into PDF, which leads to poor quality laser printing.
https://bugs.freedesktop.org/show_bug.cgi?id=49832 Roman Eisele b...@eikota.de changed: What|Removed |Added Version|3.6.0.1 rc |3.5.0 release --- Comment #13 from Roman Eisele b...@eikota.de 2012-07-15 08:40:22 PDT --- (In reply to comment #12) Still applies to 3.6.0.1 (RC1). Updating version accordingly. Thank you for testing with the newest version! However, please do not change the Version field: the Version field should always contain the FIRST version in which a bug is known to exist, and NOT the last one. The first one is (according to comment #8) 3.5.0 RC 3 = 3.5.0 release. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52108] CRASH on any action for particular big .odt
https://bugs.freedesktop.org/show_bug.cgi?id=52108 Roman Eisele b...@eikota.de changed: What|Removed |Added CC||b...@eikota.de --- Comment #2 from Roman Eisele b...@eikota.de 2012-07-15 08:48:47 PDT --- (In reply to comment #0) Of course 7000 pages are not a standard application, but we had this working with 3.4.5 Should we add the 'regression' keyword then? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50868] Libvisio: Draw Crash/Freeze on loading MS Lync Server 2010 Topology Sample Visio Files
https://bugs.freedesktop.org/show_bug.cgi?id=50868 John Smith lbalba...@gmail.com changed: What|Removed |Added URL|http://sites.google.com/sit |https://wiki.documentfounda |e/visioexamples/home/visofi |tion.org/QA/Bugzilla-Attach |les |ments --- Comment #20 from John Smith lbalba...@gmail.com 2012-07-15 08:52:02 PDT --- Uploaded files to the wiki, and changed URL accordingly. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 50868] Libvisio: Draw Crash/Freeze on loading MS Lync Server 2010 Topology Sample Visio Files
https://bugs.freedesktop.org/show_bug.cgi?id=50868 John Smith lbalba...@gmail.com changed: What|Removed |Added URL|https://wiki.documentfounda |https://wiki.documentfounda |tion.org/QA/Bugzilla-Attach |tion.org/QA/Bugzilla-Attach |ments |ments#Bug_fdo.2350868_-_Lib ||visio:_Draw_Crash.2FFreeze_ ||on_loading_MS_Lync_Server_2 ||010_Topology_Sample_Visio_F ||iles -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 44446] LibreOffice 3.6 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=6 Roman Eisele b...@eikota.de changed: What|Removed |Added Depends on||52028 --- Comment #42 from Roman Eisele b...@eikota.de 2012-07-15 09:03:23 PDT --- Add bug 52028 - Writer 3.6 creates and applies empty automatic styles everywhere, leading to needless file complexity and size. I don't know why nobody tries to confirm (or disprove) this bug, maybe my explanation is just too lengthy ;-), but if this bug is reproducible (even if it is just partially reproducible), this is an important regression which needs to get fixed soon. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52028] Writer 3.6 creates and applies empty automatic styles everywhere, leading to needless file complexity and size
https://bugs.freedesktop.org/show_bug.cgi?id=52028 Roman Eisele b...@eikota.de changed: What|Removed |Added Blocks||6 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52108] CRASH on any action for particular big .odt
https://bugs.freedesktop.org/show_bug.cgi?id=52108 --- Comment #3 from Roman Eisele b...@eikota.de 2012-07-15 09:19:53 UTC --- Created attachment 64227 -- https://bugs.freedesktop.org/attachment.cgi?id=64227 MacOS X log created when I had to force-quit LibO 3.5.5 On MacOS X 10.6.8 (Intel), I can't reproduce the crash for now, neither with LibO 3.5.5.3 nor with 3.6.0.1, both with German langpack installed ... Especially the word count dialog works for me without any problems, opening it is even the fastest (!) thing I can do with this document. So the crash may be specific to LibO for Windows, and someone else should confirm this. But I can confirm that even selection a single word or moving the cursor is incredible slow with this document; it freezes for seconds or even minutes. After some selecting and de-selecting, I tried (for the 3rd time or so) to select something from the format menu, and this time LibO *froze* forever; I had to force-quit it. Attached you find the log file created by MacOS X for this quit (however, I don't think that it will help much). But this freeze confirms that there is really something wrong with handling such big documents, not only on Windows, but also on MacOS. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 36977] Improved HTML5/XHTML Import
https://bugs.freedesktop.org/show_bug.cgi?id=36977 Caolán McNamara caol...@redhat.com changed: What|Removed |Added Attachment #47508|1 |0 is patch|| --- Comment #7 from Caolán McNamara caol...@redhat.com 2012-07-15 09:21:41 UTC --- Comment on attachment 47508 -- https://bugs.freedesktop.org/attachment.cgi?id=47508 XSLT 2.0 second iteration of XHTML import sample unsetting the patch flag on this patch, cause it's Vyacheslav Sedov's patch from http://qa.openoffice.org/issues/show_bug.cgi?id=83494 submitted to then OpenOffice.org rather than a patch directly contributed to LibreOffice -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51759] LibO 3.6 Beta builds fail to start any application
https://bugs.freedesktop.org/show_bug.cgi?id=51759 --- Comment #12 from OfficeUser bi...@gmx.de 2012-07-15 09:31:45 PDT --- Not sure. I have not deleted profile of stable builds. But I thought beta builds would use separate profile directory. Could you tell me please where stable and beta builds store their profiles? I cannot find a directory .libreoffice in home direoctory. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52109] New: EDITING: macro recorder not available
https://bugs.freedesktop.org/show_bug.cgi?id=52109 Bug #: 52109 Summary: EDITING: macro recorder not available Classification: Unclassified Product: LibreOffice Version: 3.5.5.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: f_cup...@hotmail.com Created attachment 64229 -- https://bugs.freedesktop.org/attachment.cgi?id=64229 According to Help in LO 3.5.5.3 an option macro recorder (in Dutch: macro opnemen) should be available in the Extra menu item for Libre Office Calc. No macro can be recorded without this option. Problem description: Macro recorder function is not available in LO 3.5.5.1. No option to activate this item can be found. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52111] New: EDITING: inserted text box in writter doesn't provide enough editing option like, Font colour / Bullets etc.
https://bugs.freedesktop.org/show_bug.cgi?id=52111 Bug #: 52111 Summary: EDITING: inserted text box in writter doesn't provide enough editing option like, Font colour / Bullets etc. Classification: Unclassified Product: LibreOffice Version: 3.5.5.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: pharman...@gmail.com Created attachment 64231 -- https://bugs.freedesktop.org/attachment.cgi?id=64231 text edit options those appear when text is entered directly on the page VS options those appear when text box is used Problem description: When Text box is inserted in writer, it doesn't provide enough options for text editing like (bullets , Numbers , Text Colour , Background Colour etc.) Steps to reproduce: 1. Insert text box in writer document 2. Type some text 3. Select the text Current behavior: Doesn't show up Text Edit options like bullets , Numbers , Text Colour , Background Colour etc. If we want to change the colous, we have to go long way ... right click on text -- Character -- Font effects -- font colour , then change the colour. If we want to change background of selected text only (Not entire text box) then I did not find any relevant option If we want to use any numbering / bullets inside a text box ... we have to manually assign the numbers or insert symbol for the bullets. Expected behavior: Text in text box should be easy free to edit as per the wish. Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 46891] CRASH when PDFEXPORT
https://bugs.freedesktop.org/show_bug.cgi?id=46891 --- Comment #4 from Roman Eisele b...@eikota.de 2012-07-15 10:31:05 PDT --- With some files, Writer crashes not only to export to PDF but simply when you print. @Christian MINARY: Could you please attach such an .odt file which makes LibreOffice crash when you try to print or export the file? This would allow us to reproduce the problem, if possible. Thank you very much! (To attach a file to this bug report, just click on Add an attachment right on this page.) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 35691] Table of contents does not fully appear when opening doc file
https://bugs.freedesktop.org/show_bug.cgi?id=35691 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||INVALID CC||LibreOffice@bielefeldundbus ||s.de --- Comment #5 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2012-07-15 10:34:43 PDT --- Sample document no longer available (?), so closed Might be the same as 51924 - Writer butchers Table of Contents in .doc -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51989] PDF export performance decreased in 3.6, exponentially depending on file size
https://bugs.freedesktop.org/show_bug.cgi?id=51989 Roman Eisele b...@eikota.de changed: What|Removed |Added Severity|normal |major Summary|PDF export performance |PDF export performance |decreased a bit in 3.6 |decreased in 3.6, ||exponentially depending on ||file size Keywords||regression --- Comment #6 from Roman Eisele b...@eikota.de 2012-07-15 10:36:24 PDT --- After additional testing (report and sample file coming soon), I have to increase the severity and to adapt the summary. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51754] UI: Resizing graph significantly beyond the size of the window causes infinite loop.
https://bugs.freedesktop.org/show_bug.cgi?id=51754 billh...@y7mail.com changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever Confirmed|0 |1 --- Comment #2 from billh...@y7mail.com 2012-07-15 10:53:38 PDT --- Could not reproduce on 3.5.5 Can you test this again on the latest stable version? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52112] New: UI: Borders doesn't have ready option for Thick Outside Border
https://bugs.freedesktop.org/show_bug.cgi?id=52112 Bug #: 52112 Summary: UI: Borders doesn't have ready option for Thick Outside Border Classification: Unclassified Product: LibreOffice Version: 3.5.5.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Spreadsheet AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: pharman...@gmail.com Problem description: In Cell borders shortcut option in editing toolbar, there is no option present for making Thick Borders. As any spreadsheet data always need to have some thick borders, if the option is available its very convenient for use. Steps to reproduce: 1. Click on border options 2. 3. Current behavior: Shows only thin line borders Expected behavior: Thick line options should be seen as well. (similar options are present in gnumeric / MS excel) Platform (if different from the browser): Browser: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:13.0) Gecko/20100101 Firefox/13.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52113] New: Navigator must show the Hyperlinks embedded in TOC separately
https://bugs.freedesktop.org/show_bug.cgi?id=52113 Bug #: 52113 Summary: Navigator must show the Hyperlinks embedded in TOC separately Classification: Unclassified Product: LibreOffice Version: 3.6.0.1 rc Platform: Other OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: narayana...@hotmail.com The very purpose of the Navigator is to navigate in the document. The hyperlinks section in the Navigator is supposed to give you all manually inserted hyperlinks, so that you can check out the from-to relationships. However, this purpose is defeated because the Navigator mixes up a large number of hyperlinks from the TOC to the manually created hyperlinks. There is a difference between hyperlinks inserted in TOC and hyperlinks inserted in the rest of the document: * A typical TOC will be built from all Headings 1-3 of the document. These headings are already available from the Headings section of the Navigator. * In the rest of the document, hyperlinks are used for cross-referencing. They are NOT related to the structure of the document, and these hyperlinks are not available anywhere else. Desired solution: Please provide a separate node for hyperlinks belonging to a TOC. That would allow the user to focus on the other non-TOC hyperlinks. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 51989] PDF export performance decreased in 3.6, exponentially depending on file size
https://bugs.freedesktop.org/show_bug.cgi?id=51989 --- Comment #7 from Roman Eisele b...@eikota.de 2012-07-15 11:10:44 PDT --- Created attachment 64232 -- https://bugs.freedesktop.org/attachment.cgi?id=64232 Big book sample (3222 pp. .odt file in book typography, German, no images, graphics or tables, fonts included) Update: The decrease in PDF export performance does NOT (only) depend on images/graphics, it is measurable even with .odt files containing formatted text only, and it does depend exponentially on the .odt file size (count of pages, etc.): when you export a big .odt file to PDF, you will notice an even bigger decrease of performance. Test: To test with a real text sample (I am a bit distrustful about the value of tests with mere placeholder texts), I created a 3222 pp. .odt sample file in book typography -- no images, no graphics, no tables, only much German text, some nice formatting with a bit of color, using (semi-)professional fonts and styles. (If you wonder which text is free of copyright, but 3222 pp. long: it is the Bible in Luther's original 1545 German translation ;-) The .odt file is 1.9 MB in size. You find it together with the (free) fonts attached to this bug report. To test I just open the file, do nothing else, do not even scroll, just select File Export as PDF..., leave most settings at default, just select * General: Export bookmarks * General: Export automatically inserted blank pages * General: Embed standard fonts * Links: Export bookmarks as named destinations but don't select General: Embed OpenDocument file, and click Export. Results: I distinguish three stages of PDF export. In stage I, the progress bar is not yet visible, but the cursor turns to the spinning cursor or watch (depending on your OS, I suppose). In stage II, the progress bar is visible, but does not work yet, i.e. does not show any progress. In stage III, the pogress bar shows the progress of export. To distinguish these stages is important, because it may reveal something about where the decrease of performance occurs. All values are in seconds and the mean value of several tests with each version. LibO 3.4.6LibO 3.5.53LibO 3.6.0.1 Export stage I 5052 50 (spinning cursor) Exporr stage II 5 5267 (!!!) (progress bar visible, but disabled) Export stage III 102 113140 (progress bar showing progress) Total 157 170457 (!!!) You see, we have a little decrease of performance in LibO 3.5.x as compared to 3.4.x, but a big decrease in LibO 3.6.0.1 as compared to both older versions. The decrease happens partially in stage III of the export, but mostly in stage II. This stage, which took only 5 seconds in LibO 3.4.x and 3.5.x, and is, with small documents, so short that you may not even notice it, takes 267 seconds now in LibreOffice 3.6.0.1. Wow! I already thought that LibO 3.6.0.1 freezed, and this is really bad user experience. It seems that the duration of this stage depends exponentially on file size, even without any graphics. So the question is: WHAT does LibreOffice do in stage II? Here is the place of the biggest regression of performance against LibreOffice 3.5.x, and here our developers should look how to get performance back. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52114] New: FORMATTING: Formatting from calc spreadsheet is not applied in writer serial letter
https://bugs.freedesktop.org/show_bug.cgi?id=52114 Bug #: 52114 Summary: FORMATTING: Formatting from calc spreadsheet is not applied in writer serial letter Classification: Unclassified Product: LibreOffice Version: 3.6.0.1 rc Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: v...@arcor.de Created attachment 64233 -- https://bugs.freedesktop.org/attachment.cgi?id=64233 my spreadsheet that was used as data source in writer Problem description: I have created an spreadsheet with calc and used it as data source to create a serial letter with writer. In my spreadsheet i have formated all the columns as needed, but writer applies the formating just for some of the columns not for all. Steps to reproduce: 1. see attached ods spreadsheet 2. see attached odt serial letter Current behavior: When printing the serial letter only the formatting of the column GuthabenNachzahlung is correct, but all the others columns Kosten, AbschlagAlt .. is missing. You can see the missing formatting also in the data source explorer (F4 shortcut). Expected behavior: All the formatting i define in calc spreadsheet should be automatically applied in the writer serial letter. Platform (if different from the browser): Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20100101 Firefox/13.0.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 52114] FORMATTING: Formatting from calc spreadsheet is not applied in writer serial letter
https://bugs.freedesktop.org/show_bug.cgi?id=52114 --- Comment #1 from v...@arcor.de 2012-07-15 11:14:23 PDT --- Created attachment 64234 -- https://bugs.freedesktop.org/attachment.cgi?id=64234 my serial letter created with writer -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs