[Libreoffice-bugs] [Bug 103030] [META] Navigator sidebar deck and floating window
https://bugs.documentfoundation.org/show_bug.cgi?id=103030 Bug 103030 depends on bug 98005, which changed state. Bug 98005 Summary: Show footnotes and endnotes in Navigator https://bugs.documentfoundation.org/show_bug.cgi?id=98005 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 103164] [META] Footnote and Endnote bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=103164 Bug 103164 depends on bug 98005, which changed state. Bug 98005 Summary: Show footnotes and endnotes in Navigator https://bugs.documentfoundation.org/show_bug.cgi?id=98005 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98005] Show footnotes and endnotes in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=98005 Buovjaga changed: What|Removed |Added Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #19 from Buovjaga --- *** This bug has been marked as a duplicate of bug 144788 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86297] Wrong Field reference when heading is in a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=86297 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 86297] Wrong Field reference when heading is in a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=86297 Buovjaga changed: What|Removed |Added CC||libreoffice-ux-advise@lists ||.freedesktop.org Keywords||needsUXEval -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148547] FILESAVE Saving CSV file(s) corrupt randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=148547 --- Comment #2 from Kiki --- (Small re-correction) Edit: All english contents remain on every files/devices and all other languages contents display as many "?" marks (checked multiple files and all devices: confirmed) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 107733] [META] Hyperlink bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=107733 --- Comment #10 from luna beth --- IJ Scan Utility is an application that allows users to scan documents, photos, and more quickly. Users can complete from scanning to storage at once by clicking on the corresponding icon in the IJ Scan Utility main screen. https://istartsetup.com/ij-scan-utility/ https://istartsetup.com/canon-com-ijsetup/ https://www.ijstartcan-on.org/ -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148239] Column width value in hover text depends on position of the cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=148239 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146653] Font rendering for localized "Source Han Sans CN" and "Source Han Serif CN" fonts (i.e. "思源黑体 CN" and "思源宋体 CN") is showing as bold rather than normal weight
https://bugs.documentfoundation.org/show_bug.cgi?id=146653 QA Administrators changed: What|Removed |Added Whiteboard| QA:needsComment|target:7.4.0 |target:7.4.0| -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148247] LO dark scheme: wrong text color and background in slide show and active text boxes
https://bugs.documentfoundation.org/show_bug.cgi?id=148247 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148210] Adding drawing object line to a chart in CALC makes chart size erratic
https://bugs.documentfoundation.org/show_bug.cgi?id=148210 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 113365] [META] RTF (text) image-related issues
https://bugs.documentfoundation.org/show_bug.cgi?id=113365 Bug 113365 depends on bug 135583, which changed state. Bug 135583 Summary: FILEOPEN RTF: Image jumps out of table when pressing arrow up (no free movement) https://bugs.documentfoundation.org/show_bug.cgi?id=135583 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135583] FILEOPEN RTF: Image jumps out of table when pressing arrow up (no free movement)
https://bugs.documentfoundation.org/show_bug.cgi?id=135583 QA Administrators changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |INSUFFICIENTDATA -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148087] Assertion failed when editing a cell with an OnSelectionChange macro breakpoint triggered
https://bugs.documentfoundation.org/show_bug.cgi?id=148087 QA Administrators changed: What|Removed |Added Whiteboard|| QA:needsComment -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 135583] FILEOPEN RTF: Image jumps out of table when pressing arrow up (no free movement)
https://bugs.documentfoundation.org/show_bug.cgi?id=135583 --- Comment #9 from QA Administrators --- Dear Telesto, Please read this message in its entirety before proceeding. Your bug report is being closed as INSUFFICIENTDATA due to inactivity and a lack of information which is needed in order to accurately reproduce and confirm the problem. We encourage you to retest your bug against the latest release. If the issue is still present in the latest stable release, we need the following information (please ignore any that you've already provided): a) Provide details of your system including your operating system and the latest version of LibreOffice that you have confirmed the bug to be present b) Provide easy to reproduce steps – the simpler the better c) Provide any test case(s) which will help us confirm the problem d) Provide screenshots of the problem if you think it might help e) Read all comments and provide any requested information Once all of this is done, please set the bug back to UNCONFIRMED and we will attempt to reproduce the issue. Please do not: a) respond via email b) update the version field in the bug or any of the other details on the top section of our bug tracker Warm Regards, QA Team MassPing-NeedInfo-FollowUp -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145145] table editing in libre writer
https://bugs.documentfoundation.org/show_bug.cgi?id=145145 --- Comment #2 from QA Administrators --- Dear rschramm, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145139] LibreOffice calc crashes when FORMATTING cell borders
https://bugs.documentfoundation.org/show_bug.cgi?id=145139 --- Comment #2 from QA Administrators --- Dear qd5jy6rx, This bug has been in NEEDINFO status with no change for at least 6 months. Please provide the requested information as soon as possible and mark the bug as UNCONFIRMED. Due to regular bug tracker maintenance, if the bug is still in NEEDINFO status with no change in 30 days the QA team will close the bug as INSUFFICIENTDATA due to lack of needed information. For more information about our NEEDINFO policy please read the wiki located here: https://wiki.documentfoundation.org/QA/Bugzilla/Fields/Status/NEEDINFO If you have already provided the requested information, please mark the bug as UNCONFIRMED so that the QA team knows that the bug is ready to be confirmed. Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-NeedInfo-Ping -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 90796] [META] HiDPI / Retina bugs
https://bugs.documentfoundation.org/show_bug.cgi?id=90796 Bug 90796 depends on bug 140900, which changed state. Bug 140900 Summary: [Feature Request] A setting to change the size of the font previews dropdown https://bugs.documentfoundation.org/show_bug.cgi?id=140900 What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101646] UI option "Scaling" was removed
https://bugs.documentfoundation.org/show_bug.cgi?id=101646 V Stuart Foote changed: What|Removed |Added CC||chameleonscales@protonmail. ||com --- Comment #78 from V Stuart Foote --- *** Bug 140900 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 140900] [Feature Request] A setting to change the size of the font previews dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=140900 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from V Stuart Foote --- (In reply to chameleonscales from comment #12) > Created attachment 179498 [details] > font previews comparison > > (In reply to Heiko Tietze from comment #11) > > And what exactly would you like to change? Is it too large? > > No, to me it looks too small (once more). > > > Do you mean the collapsed drodpown or the expanded list? > > Not sure what the question is. I mean the dropdown list we see in both our > screenshots. The listbox widget has two states--collapsed with a font selection (with or without a preview rendering), or the full expanded droplist of multiple fonts with their "sample" text (font name or representative string). > > > To enter a value for the size of one UI is probably not a solution to any > > problem. > > You say "one UI" as if this dropdown was like any other. GNOME's Font One UI widget within LibreOffice, obviously. Project made a dev decision to hand over widget controls to the os/DE, stripping out ability to scale some selection of "individual" widget elements. That was done to improve integration with emerging os/DE and their roll of consistent handling of HiDPI displays. Doing "other" things require an agreement to diverge from os/DE norms and the dev effort to work up a frame work to support it consistently cross platform. As explained in bug 101646, which this really is a duplicate to, some components of the UI benefit from ability to selectively scale compared to what os/DE provides. *** This bug has been marked as a duplicate of bug 101646 *** -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140900] [Feature Request] A setting to change the size of the font previews dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=140900 V Stuart Foote changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|--- |DUPLICATE --- Comment #13 from V Stuart Foote --- (In reply to chameleonscales from comment #12) > Created attachment 179498 [details] > font previews comparison > > (In reply to Heiko Tietze from comment #11) > > And what exactly would you like to change? Is it too large? > > No, to me it looks too small (once more). > > > Do you mean the collapsed drodpown or the expanded list? > > Not sure what the question is. I mean the dropdown list we see in both our > screenshots. The listbox widget has two states--collapsed with a font selection (with or without a preview rendering), or the full expanded droplist of multiple fonts with their "sample" text (font name or representative string). > > > To enter a value for the size of one UI is probably not a solution to any > > problem. > > You say "one UI" as if this dropdown was like any other. GNOME's Font One UI widget within LibreOffice, obviously. Project made a dev decision to hand over widget controls to the os/DE, stripping out ability to scale some selection of "individual" widget elements. That was done to improve integration with emerging os/DE and their roll of consistent handling of HiDPI displays. Doing "other" things require an agreement to diverge from os/DE norms and the dev effort to work up a frame work to support it consistently cross platform. As explained in bug 101646, which this really is a duplicate to, some components of the UI benefit from ability to selectively scale compared to what os/DE provides. *** This bug has been marked as a duplicate of bug 101646 *** -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 148548] Double Border Lines Removed After Excel Conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=148548 genericemail001002...@gmail.com changed: What|Removed |Added Ever confirmed|0 |1 Status|UNCONFIRMED |NEW CC||genericemail001002003@gmail ||.com Keywords||filter:ods, filter:xlsx -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148548] New: Double Border Lines Removed After Excel Conversion
https://bugs.documentfoundation.org/show_bug.cgi?id=148548 Bug ID: 148548 Summary: Double Border Lines Removed After Excel Conversion Product: LibreOffice Version: 7.3.2.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: genericemail001002...@gmail.com Description: After applying double border lines to some cells in .ods format, then "Save As" .xlsx format, the double cell border lines get replaced by single border lines after closing and opening the .xlsx document again. Steps to Reproduce: 1. Create Libre Calc document and save it as .ods format. 2. Add double border lines to any cell 3. Click "Save As" and save it as .xlsx format 4. Close document 5. Open .xlsx document 6. Double border lines are changed to single Actual Results: After saving it in another format, closing and returning to the document with the new format, the double border lines are replaced with single border lines. Expected Results: After saving it in another format, closing and returning to the document with the new format, the double border lines should remain where I applied them. Reproducible: Always User Profile Reset: No OpenGL enabled: Yes Additional Info: Version: 7.3.2.2 / LibreOffice Community Build ID: 30(Build:2) CPU threads: 2; OS: Linux 5.17; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US 7.3.2-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-ux-advise] [Bug 140900] [Feature Request] A setting to change the size of the font previews dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=140900 --- Comment #12 from chameleonsca...@protonmail.com --- Created attachment 179498 --> https://bugs.documentfoundation.org/attachment.cgi?id=179498=edit font previews comparison (In reply to Heiko Tietze from comment #11) > And what exactly would you like to change? Is it too large? No, to me it looks too small (once more). > Do you mean the collapsed drodpown or the expanded list? Not sure what the question is. I mean the dropdown list we see in both our screenshots. > To enter a value for the size of one UI is probably not a solution to any > problem. You say "one UI" as if this dropdown was like any other. GNOME's Font manager displays each font in all sizes at once to allow the user to preview a font at their desired size. Blender (my preferred way to preview fonts) shows resizeable previews which can get much larger than LO's dropdown (see attachment). I can certainly understand how developing such a feature can be complicated for performance or code rewriting reasons, but I don't understand the mindset that letting the user control how to preview fonts without affecting the rest of the interface is "not a solution" to the problem. -- You are receiving this mail because: You are on the CC list for the bug.
[Libreoffice-bugs] [Bug 140900] [Feature Request] A setting to change the size of the font previews dropdown
https://bugs.documentfoundation.org/show_bug.cgi?id=140900 --- Comment #12 from chameleonsca...@protonmail.com --- Created attachment 179498 --> https://bugs.documentfoundation.org/attachment.cgi?id=179498=edit font previews comparison (In reply to Heiko Tietze from comment #11) > And what exactly would you like to change? Is it too large? No, to me it looks too small (once more). > Do you mean the collapsed drodpown or the expanded list? Not sure what the question is. I mean the dropdown list we see in both our screenshots. > To enter a value for the size of one UI is probably not a solution to any > problem. You say "one UI" as if this dropdown was like any other. GNOME's Font manager displays each font in all sizes at once to allow the user to preview a font at their desired size. Blender (my preferred way to preview fonts) shows resizeable previews which can get much larger than LO's dropdown (see attachment). I can certainly understand how developing such a feature can be complicated for performance or code rewriting reasons, but I don't understand the mindset that letting the user control how to preview fonts without affecting the rest of the interface is "not a solution" to the problem. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139058] Selection kind easy extended to an large selection
https://bugs.documentfoundation.org/show_bug.cgi?id=139058 stragu changed: What|Removed |Added Assignee|libreoffice-b...@lists.free |stephane.guil...@member.fsf |desktop.org |.org Status|UNCONFIRMED |NEW CC||stephane.guil...@member.fsf ||.org Ever confirmed|0 |1 --- Comment #6 from stragu --- Created attachment 179497 --> https://bugs.documentfoundation.org/attachment.cgi?id=179497=edit same document with modified styles With this modified document, I would agree this is a bit unexpected. I have changed the styles so the Text body style has 1 cm of spacing below the paragraph, and the Heading 1 style has no spacing above it. a) With these styles, one would expect that selecting some of the Text body and shifting slighty below it wouldn't select the heading, as all this blank space is supposed to be part of the Text body style. b) For the same reason, selecting some of the Headinng 1 and shifting a fair bit up into the blank space could be expected to select some text above. I would agree with Telesto that this behaviour could be improved on, in particular for (a). I see two options: 1) Select the text only when the actual text is reached, or 2) Select the text when the space that belongs to the style is reached. Tested with: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148547] FILESAVE Saving CSV file(s) corrupt randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=148547 --- Comment #1 from Kiki --- Created attachment 179496 --> https://bugs.documentfoundation.org/attachment.cgi?id=179496=edit sample in texteditor -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148547] FILESAVE Saving CSV file(s) corrupt randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=148547 Kiki changed: What|Removed |Added Keywords||dataLoss -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148547] New: FILESAVE Saving CSV file(s) corrupt randomly
https://bugs.documentfoundation.org/show_bug.cgi?id=148547 Bug ID: 148547 Summary: FILESAVE Saving CSV file(s) corrupt randomly Product: LibreOffice Version: 6.4.7.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: r45xv...@protonmail.ch What happened? I cannot provide specific reproduce steps because it happens randomly but this make us serious upset about libreoffice when happen while work on large projects - Open a .csv file (e.g. received .csv file to you/company) - Work on it (only editing, no other changes, formatting, or else) - Every time save same as it (means sometimes calc pop-up to ask if necessary to continue save with .csv format) - E.g. Continue edit it everyday and saving then after 2-3 days or 8-10 days open it, then we notice files have corrupted (that's not on same (day) for every devices) and no way to recover them. I cannot provide sample files because it's not possible to expose and see screenshots Files contain: English, Korean, Japanese, Hindi, Sinhala etc contents (only 5%-10% percentage of english contents remain on every files/devices and all other languages contents display as many "?" marks) LibreOffice: 6.4.7.2 Operating system: Ubuntu 20.04.03 (all devices) I noticed several related issues but cannot accept. https://bugs.documentfoundation.org/show_bug.cgi?id=132691 https://bugs.documentfoundation.org/show_bug.cgi?id=117146 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 146171] Tracked changes with no date (0000-00-00) in .doc(x) documents are no longer tracked when converted to ODF format.
https://bugs.documentfoundation.org/show_bug.cgi?id=146171 --- Comment #17 from Aron Budea --- KevBurto, if you're still experiencing an issue, please open a separate bug report on it. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139673] EDITING: Selection of words by double click and mouse move in Calc comments
https://bugs.documentfoundation.org/show_bug.cgi?id=139673 --- Comment #4 from stragu --- (To clarify my comment above: Roman, maybe you tested the working multi-select behaviour in a Calc cell rather than in a Writer document, which is what Roland used to demonstrate the expected behaviour.) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139673] EDITING: Selection of words by double click and mouse move in Calc comments
https://bugs.documentfoundation.org/show_bug.cgi?id=139673 stragu changed: What|Removed |Added Status|UNCONFIRMED |NEW Version|unspecified |6.4.7.2 release Ever confirmed|0 |1 --- Comment #3 from stragu --- Roman, maybe you tested in Calc and not in Writer? Calc missing this feature is Bug 127183. I thing that bug definitely needs to be fixed before or at the same time as this bug here: would be weird to have this kind of selection supported in comments but not in the cell! Confirmed in: Version: 7.3.2.2 / LibreOffice Community Build ID: 49f2b1bff42cfccbd8f788c8dc32c1c309559be0 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: en-AU (en_AU.UTF-8); UI: en-US Calc: threaded and also: Version: 6.4.7.2 Build ID: 1:6.4.7-0ubuntu0.20.04.4 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded but I assume this is inherited from OOo. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 139634] Writer: Selection of words by double click and mouse move in comments
https://bugs.documentfoundation.org/show_bug.cgi?id=139634 stragu changed: What|Removed |Added Version|unspecified |6.4.7.2 release --- Comment #5 from stragu --- Also confirmed in: Version: 6.4.7.2 Build ID: 1:6.4.7-0ubuntu0.20.04.4 CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: gtk3; Locale: en-AU (en_AU.UTF-8); UI-Language: en-US Calc: threaded Changing the earliest version affected accordingly, but wouldn't be surprised if this is inherited from OOo. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145080] make sure cell selection colors use good contrast when following system highlight color on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=145080 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||8424 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148424] Border color of active, focused cell is hard to see on Ubuntu
https://bugs.documentfoundation.org/show_bug.cgi?id=148424 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||3733, ||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||5080 Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO Summary|Border color of active, |Border color of active, |focused cell is hard to |focused cell is hard to see |see.|on Ubuntu --- Comment #2 from stragu --- Hi Fazliddin Thanks for the report. Could you please: - Copy and paste the "Help > About" information in your affected version - Include a screenshot of the issue as an attachment here - Give us the version of LibreOffice used in Ubuntu 18.04, if you have it. I assume this is because of the fix for Bug 142121, now using the system colour for the selection/cursor. For me, on Ubuntu 20.04 with LO 7.3.2.2, the cursor is very evident with the default orange colour in dark mode. Here are some related bugs: - About improving the contrast, but macOS-specific: Bug 145080 - About making the border more obvious and placed more optimally, with a (partial?) fix in the 7.4 branch: Bug 143733 Added meta bug, see also bugs, and used more precise summary. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112182 stragu changed: What|Removed |Added Depends on||148424 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=148424 [Bug 148424] Border color of active, focused cell is hard to see. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148424] Border color of active, focused cell is hard to see.
https://bugs.documentfoundation.org/show_bug.cgi?id=148424 stragu changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||2121 Blocks||112182 --- Comment #1 from stragu --- Hi Fazliddin Thanks for the report. Could you please: - Copy and paste the "Help > About" information in your affected version - Include a screenshot of the issue as an attachment here - Give us the version of LibreOffice used in Ubuntu 18.04, if you have it. I assume this is because of the fix for Bug 142121, now using the system colour for the selection/cursor. For me, on Ubuntu 20.04 with LO 7.3.2.2, the cursor is very evident with the default orange colour in dark mode. Here are some related bugs: - About improving the contrast, but macOS-specific: 145080 - About making the border more obvious and placed more optimally, with a (partial?) fix in the 7.4 branch: Bug 143733 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=112182 [Bug 112182] [META] Text and object selection issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148546] New: Navigator not working on Pop OS
https://bugs.documentfoundation.org/show_bug.cgi?id=148546 Bug ID: 148546 Summary: Navigator not working on Pop OS Product: LibreOffice Version: 7.2.6.2 release Hardware: All OS: Linux (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: stephenaustinm...@gmail.com Description: When pressing F5 or View> Navigator, Navigator does not open as expected Steps to Reproduce: 1.Open an existing doc or a new doc 2. Press F5 / View/ Navigator 3. Nothing happens Actual Results: Nothing happens. Expected Results: Navigator should have opened Reproducible: Always User Profile Reset: Yes OpenGL enabled: Yes Additional Info: Version: 7.2.6.2 / LibreOffice Community Build ID: 20(Build:2) CPU threads: 4; OS: Linux 5.16; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Ubuntu package version: 1:7.2.6-0ubuntu0.21.10.1 Calc: threaded I also use Linux Mint and Windows - Navigator works fine on both of these platforms. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 112182] [META] Text and object selection issues
https://bugs.documentfoundation.org/show_bug.cgi?id=112182 stragu changed: What|Removed |Added Depends on||145080 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145080 [Bug 145080] make sure cell selection colors use good contrast when following system highlight color on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 101912] [META] Accessibility (a11y) bugs and enhancements
https://bugs.documentfoundation.org/show_bug.cgi?id=101912 stragu changed: What|Removed |Added Depends on||145080 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145080 [Bug 145080] make sure cell selection colors use good contrast when following system highlight color on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 42082] [META] Make LibreOffice shine and glow on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=42082 stragu changed: What|Removed |Added Depends on||145080 Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=145080 [Bug 145080] make sure cell selection colors use good contrast when following system highlight color on macOS -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 145080] make sure cell selection colors use good contrast when following system highlight color on macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=145080 stragu changed: What|Removed |Added Blocks||101912, 112182, 42082 Summary|make sure, cell selection |make sure cell selection |colors use good contrast|colors use good contrast |when following system |when following system |highlight color on macOS|highlight color on macOS CC||stephane.guil...@member.fsf ||.org --- Comment #24 from stragu --- Adding meta bugs. Referenced Bugs: https://bugs.documentfoundation.org/show_bug.cgi?id=42082 [Bug 42082] [META] Make LibreOffice shine and glow on macOS https://bugs.documentfoundation.org/show_bug.cgi?id=101912 [Bug 101912] [META] Accessibility (a11y) bugs and enhancements https://bugs.documentfoundation.org/show_bug.cgi?id=112182 [Bug 112182] [META] Text and object selection issues -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148545] Interaction between zoom and toggle formatting marks when displaying text
https://bugs.documentfoundation.org/show_bug.cgi?id=148545 --- Comment #1 from sdc.bla...@youmail.dk --- Forgot to mention, also tested in Safe Mode, with same results. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148545] New: Interaction between zoom and toggle formatting marks when displaying text
https://bugs.documentfoundation.org/show_bug.cgi?id=148545 Bug ID: 148545 Summary: Interaction between zoom and toggle formatting marks when displaying text Product: LibreOffice Version: 7.4.0.0 alpha0+ Master Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: sdc.bla...@youmail.dk Created attachment 179495 --> https://bugs.documentfoundation.org/attachment.cgi?id=179495=edit screenshots of problem 1. Open any text document with text in it. 2. Zoom up (e.g., 250%) 3. Toggle ON Formatting Marks (gives wrong display) 4. Toggle OFF Formatting Marks (looks like it should) Attached file shows screenshots when attempted with: Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL Additional Information 1. No problems with LO 7.2.6.2 2. Zooming in (e.g., 65%) with 7.4.0.0 also does not seem completely right, compared to 7.2.6.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - sc/source
sc/source/ui/dialogs/SparklineDialog.cxx |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 92e35ec9c8ecb2ba93d050a2b5aa838d71c82321 Author: Julien Nabet AuthorDate: Sun Apr 10 10:21:59 2022 +0200 Commit: Tomaž Vajngerl CommitDate: Wed Apr 13 01:35:21 2022 +0200 cid#1503834: copy-paste Change-Id: Ibc5cf10d4daf809e89693ac9d3fb82188ba1b311 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132767 Tested-by: Jenkins Reviewed-by: Julien Nabet (cherry picked from commit c1285d4d033a13667a942145db77e3aa38d3f953) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132925 Tested-by: Jenkins CollaboraOffice Reviewed-by: Tomaž Vajngerl diff --git a/sc/source/ui/dialogs/SparklineDialog.cxx b/sc/source/ui/dialogs/SparklineDialog.cxx index 4a7fa320a38e..0c5be765ef3c 100644 --- a/sc/source/ui/dialogs/SparklineDialog.cxx +++ b/sc/source/ui/dialogs/SparklineDialog.cxx @@ -253,7 +253,7 @@ void SparklineDialog::setupValues() break; case sc::AxisType::Custom: mxComboMaxAxisType->set_active(2); -if (maAttributes.getManualMin()) +if (maAttributes.getManualMax()) mxSpinCustomMax->GetFormatter().SetValue(*maAttributes.getManualMax()); break; }
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - officecfg/registry sc/inc sc/Library_sc.mk sc/qa sc/sdi sc/source sc/uiconfig sc/UIConfig_scalc.mk
officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu |8 sc/Library_sc.mk |2 sc/UIConfig_scalc.mk |1 sc/inc/globstr.hrc|1 sc/inc/sc.hrc |4 sc/qa/unit/SparklineTest.cxx | 64 +++ sc/sdi/cellsh.sdi |1 sc/sdi/scalc.sdi | 17 sc/source/ui/app/scdll.cxx|1 sc/source/ui/dialogs/SparklineDataRangeDialog.cxx | 202 ++ sc/source/ui/docshell/docfunc.cxx | 12 sc/source/ui/inc/SparklineDataRangeDialog.hxx | 66 +++ sc/source/ui/inc/docfunc.hxx |2 sc/source/ui/inc/gridwin.hxx |3 sc/source/ui/inc/reffact.hxx |7 sc/source/ui/inc/undo/UndoEditSparkline.hxx | 47 ++ sc/source/ui/undo/UndoEditSparkline.cxx | 63 +++ sc/source/ui/view/cellsh.cxx |6 sc/source/ui/view/cellsh1.cxx | 10 sc/source/ui/view/gridwin.cxx | 67 +++ sc/source/ui/view/tabvwsh.cxx |1 sc/source/ui/view/tabvwshc.cxx|6 sc/uiconfig/scalc/popupmenu/cell.xml |1 sc/uiconfig/scalc/ui/sparklinedatarangedialog.ui | 148 +++ 24 files changed, 738 insertions(+), 2 deletions(-) New commits: commit 3b8fd7dd69fd4d775e296cbbd3bf50c2efb41b39 Author: Tomaž Vajngerl AuthorDate: Sat Apr 9 14:30:22 2022 +0900 Commit: Tomaž Vajngerl CommitDate: Wed Apr 13 01:35:08 2022 +0200 sc: add UI, undo/redo and test to change sparkline data range This adds a "edit sparkline" action to the context menu and a dialog to change the data range of a sparkline. To change a sparkline using undo/redo, a new class UndoEditSparkline was added, which allows to change the attributes of a sparkline and revert back the old attributes when undoing. This is then used in the Dialog when setting the changed data range of a sparkline. To make sure that undo/redo works correctly, a simple unit tests was added. Change-Id: I08af1813fa288278bc0d33b0540660b325b17235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132748 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl (cherry picked from commit a08f9ed2341bc60faae6b86538661fea40417ace) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132924 Tested-by: Jenkins CollaboraOffice diff --git a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu index 55835e2b7c74..7f244744d2a7 100644 --- a/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu +++ b/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu @@ -1114,6 +1114,14 @@ 1 + + + Edit Sparkline... + + + 1 + + Edit Sparkline Group... diff --git a/sc/Library_sc.mk b/sc/Library_sc.mk index 0c32f743c44d..eb81a6817ab2 100644 --- a/sc/Library_sc.mk +++ b/sc/Library_sc.mk @@ -419,6 +419,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\ sc/source/ui/dbgui/validate \ sc/source/ui/dialogs/searchresults \ sc/source/ui/dialogs/SparklineDialog \ +sc/source/ui/dialogs/SparklineDataRangeDialog \ sc/source/ui/docshell/arealink \ sc/source/ui/docshell/autostyl \ sc/source/ui/docshell/datastream \ @@ -559,6 +560,7 @@ $(eval $(call gb_Library_add_exception_objects,sc,\ sc/source/ui/undo/UndoDeleteSparklineGroup \ sc/source/ui/undo/UndoUngroupSparklines \ sc/source/ui/undo/UndoGroupSparklines \ +sc/source/ui/undo/UndoEditSparkline \ sc/source/ui/unoobj/ChartRangeSelectionListener \ sc/source/ui/unoobj/addruno \ sc/source/ui/unoobj/afmtuno \ diff --git a/sc/UIConfig_scalc.mk b/sc/UIConfig_scalc.mk index 302f08ff3fb3..643645ee7432 100644 --- a/sc/UIConfig_scalc.mk +++ b/sc/UIConfig_scalc.mk @@ -245,6 +245,7 @@ $(eval $(call gb_UIConfig_add_uifiles,modules/scalc,\ sc/uiconfig/scalc/ui/sortoptionspage \ sc/uiconfig/scalc/ui/sortwarning \ sc/uiconfig/scalc/ui/sparklinedialog \ + sc/uiconfig/scalc/ui/sparklinedatarangedialog \ sc/uiconfig/scalc/ui/splitcolumnentry \ sc/uiconfig/scalc/ui/subtotaldialog \ sc/uiconfig/scalc/ui/subtotaloptionspage \ diff
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - sc/inc sc/source sc/uiconfig
sc/inc/table.hxx |1
sc/source/core/data/table4.cxx| 56 ++
sc/uiconfig/scalc/menubar/menubar.xml | 10 ++
3 files changed, 67 insertions(+)
New commits:
commit 2e11597a08b4540d632b1d2a2adfa1532190bbc1
Author: Tomaž Vajngerl
AuthorDate: Mon Apr 4 22:20:05 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 13 01:34:41 2022 +0200
sc: add sparklines commands to main menu
Change-Id: Ie69d78162fb0d845f8ffd181397569c3cd3276f1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132593
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132922
Tested-by: Tomaž Vajngerl
diff --git a/sc/uiconfig/scalc/menubar/menubar.xml
b/sc/uiconfig/scalc/menubar/menubar.xml
index bc1774817070..a0409522e372 100644
--- a/sc/uiconfig/scalc/menubar/menubar.xml
+++ b/sc/uiconfig/scalc/menubar/menubar.xml
@@ -571,6 +571,16 @@
+
+
+
+
+
+
+
+
+
+
commit 5eaa78dd96efa180f12e4ba3bbf4dddc7e47483c
Author: Tomaž Vajngerl
AuthorDate: Mon Apr 4 00:56:47 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 13 01:34:25 2022 +0200
sc: take sparklines into account with auto fill
Change-Id: I6bdb5f4291aece7ec02d8de0731b8f983b4f2bb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132592
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132921
Tested-by: Tomaž Vajngerl
diff --git a/sc/inc/table.hxx b/sc/inc/table.hxx
index 1c355c0d6ff9..9362fee910dd 100644
--- a/sc/inc/table.hxx
+++ b/sc/inc/table.hxx
@@ -482,6 +482,7 @@ public:
sc::SparklineList& GetSparklineList();
void CopySparklinesToTable(SCCOL nCol1, SCROW nRow1, SCCOL nCol2, SCROW
nRow2, ScTable* pDestTab);
+void FillSparkline(bool bVertical, SCCOLROW nFixed, SCCOLROW
nIteratingStart, SCCOLROW nIteratingEnd, SCCOLROW nFillStart, SCCOLROW
nFillEnd);
// Notes / Comments
std::unique_ptr ReleaseNote( SCCOL nCol, SCROW nRow );
diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx
index f420d01d6eae..43df3aef3220 100644
--- a/sc/source/core/data/table4.cxx
+++ b/sc/source/core/data/table4.cxx
@@ -1204,10 +1204,66 @@ void ScTable::FillAuto( SCCOL nCol1, SCROW nRow1, SCCOL
nCol2, SCROW nRow2,
nProgress = pProgress->GetState();
}
+if (bVertical)
+FillSparkline(bVertical, nCol, nRow1, nRow2, nIStart, nIEnd);
+else
+FillSparkline(bVertical, nRow, nCol1, nCol2, nIStart, nIEnd);
+
nActFormCnt += nMaxFormCnt;
}
}
+void ScTable::FillSparkline(bool bVertical, SCCOLROW nFixed,
+ SCCOLROW nStart, SCCOLROW nEnd,
+ SCCOLROW nFillStart, SCCOLROW nFillEnd)
+{
+bool bHasSparklines = false;
+std::vector> aSparklineSeries;
+
+for (SCROW nCurrent = nStart; nCurrent <= nEnd; nCurrent++)
+{
+auto pSparkline = bVertical ? GetSparkline(nFixed, nCurrent) :
GetSparkline(nCurrent, nFixed);
+bHasSparklines = bHasSparklines || bool(pSparkline);
+aSparklineSeries.push_back(pSparkline);
+}
+
+if (bHasSparklines)
+{
+for (SCCOLROW nCurrent = nFillStart; nCurrent <= nFillEnd; nCurrent++)
+{
+size_t nIndex = size_t(nFillStart - nCurrent) %
aSparklineSeries.size();
+if (auto& rpSparkline = aSparklineSeries[nIndex])
+{
+auto pGroup = rpSparkline->getSparklineGroup();
+
+auto* pNewSparkline = bVertical ? CreateSparkline(nFixed,
nCurrent, pGroup)
+: CreateSparkline(nCurrent,
nFixed, pGroup);
+if (pNewSparkline)
+{
+SCCOLROW nPosition = bVertical ? rpSparkline->getRow()
+ : rpSparkline->getColumn();
+SCCOLROW nDelta = nCurrent - nPosition;
+ScRangeList aRangeList(rpSparkline->getInputRange());
+for (ScRange& rRange : aRangeList)
+{
+if (bVertical)
+{
+rRange.aStart.IncRow(nDelta);
+rRange.aEnd.IncRow(nDelta);
+}
+else
+{
+rRange.aStart.IncCol(nDelta);
+rRange.aEnd.IncCol(nDelta);
+}
+}
+pNewSparkline->setInputRange(aRangeList);
+}
+}
+}
+}
+}
+
OUString ScTable::GetAutoFillPreview( const ScRange& rSource, SCCOL nEndX,
SCROW nEndY )
{
[Libreoffice-commits] core.git: Branch 'distro/collabora/co-22.05' - 2 commits - sc/inc sc/qa sc/source
sc/inc/SparklineList.hxx |1
sc/qa/unit/SparklineTest.cxx | 114 +++---
sc/source/core/data/column2.cxx | 38 +-
sc/source/core/data/document.cxx |3
sc/source/core/data/table2.cxx|2
sc/source/ui/sparklines/SparklineList.cxx | 27 ++-
6 files changed, 156 insertions(+), 29 deletions(-)
New commits:
commit 2370689d331b7f1a22cc2c7f285a288cecbe1b6c
Author: Tomaž Vajngerl
AuthorDate: Sun Apr 3 15:53:55 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 13 01:34:09 2022 +0200
sc: improve keeping track of sparklines in SparklineList
Issues can happen when saving a document with sparklines where a
sparkline is deleted and then undo-ed. The reason for this is
because the SparlineList wasn't correctly updated when deleting,
copying or adding sparklines. This change adds hooks when new
sparklines are created or when sparklines are deleted to report
this into SparlineList.
SparklineList garbage-collects itself but this is not enough when
we rely that the non-deleted weak pointers to the sparkline groups
contain the correct non-deleted weak pointers to the correct
sparklines.
Change-Id: I976cbe7e6168813d3dd5089c036cc7fe4e357fb2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132554
Tested-by: Tomaž Vajngerl
Reviewed-by: Tomaž Vajngerl
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132883
Tested-by: Jenkins CollaboraOffice
diff --git a/sc/inc/SparklineList.hxx b/sc/inc/SparklineList.hxx
index bab467a09469..e9ca8591237c 100644
--- a/sc/inc/SparklineList.hxx
+++ b/sc/inc/SparklineList.hxx
@@ -36,6 +36,7 @@ public:
SparklineList();
void addSparkline(std::shared_ptr const& pSparkline);
+void removeSparkline(std::shared_ptr const& pSparkline);
std::vector> getSparklineGroups();
diff --git a/sc/qa/unit/SparklineTest.cxx b/sc/qa/unit/SparklineTest.cxx
index 99efd55f8209..f8d07edc53e6 100644
--- a/sc/qa/unit/SparklineTest.cxx
+++ b/sc/qa/unit/SparklineTest.cxx
@@ -458,47 +458,109 @@ void
SparklineTest::testUndoRedoClearContentForSparkline()
insertTestData(rDocument);
// Sparkline range
-ScRange aRange(0, 6, 0, 0, 6, 0);
+ScRange aDataRange(0, 0, 0, 3, 5, 0); //A1:D6
+ScRange aRange(0, 6, 0, 3, 6, 0); // A7:D7
-// Check Sparkline at cell A7 doesn't exists
-auto pSparkline = rDocument.GetSparkline(aRange.aStart);
-CPPUNIT_ASSERT(!pSparkline);
+// Check Sparklines - none should exist
+{
+CPPUNIT_ASSERT(!rDocument.HasSparkline(ScAddress(0, 6, 0)));
+CPPUNIT_ASSERT(!rDocument.HasSparkline(ScAddress(1, 6, 0)));
+CPPUNIT_ASSERT(!rDocument.HasSparkline(ScAddress(2, 6, 0)));
+CPPUNIT_ASSERT(!rDocument.HasSparkline(ScAddress(3, 6, 0)));
+}
auto pSparklineGroup = std::make_shared();
-CPPUNIT_ASSERT(rDocFunc.InsertSparklines(ScRange(0, 0, 0, 0, 5, 0),
aRange, pSparklineGroup));
+CPPUNIT_ASSERT(rDocFunc.InsertSparklines(aDataRange, aRange,
pSparklineGroup));
-// Check Sparkline at cell A7 exists
-pSparkline = rDocument.GetSparkline(aRange.aStart);
-CPPUNIT_ASSERT(pSparkline);
-CPPUNIT_ASSERT_EQUAL(SCCOL(0), pSparkline->getColumn());
-CPPUNIT_ASSERT_EQUAL(SCROW(6), pSparkline->getRow());
+// Check Sparklines
+{
+CPPUNIT_ASSERT(rDocument.HasSparkline(ScAddress(0, 6, 0)));
+CPPUNIT_ASSERT(rDocument.HasSparkline(ScAddress(1, 6, 0)));
+CPPUNIT_ASSERT(rDocument.HasSparkline(ScAddress(2, 6, 0)));
+// D7 exists
+CPPUNIT_ASSERT(rDocument.HasSparkline(ScAddress(3, 6, 0)));
+
+// Check D7
+auto pSparkline = rDocument.GetSparkline(ScAddress(3, 6, 0));
+CPPUNIT_ASSERT_EQUAL(SCCOL(3), pSparkline->getColumn());
+CPPUNIT_ASSERT_EQUAL(SCROW(6), pSparkline->getRow());
+
+// Check collections
+auto* pSparklineList = rDocument.GetSparklineList(SCTAB(0));
+auto pSparklineGroups = pSparklineList->getSparklineGroups();
+CPPUNIT_ASSERT_EQUAL(size_t(1), pSparklineGroups.size());
-// Clear content - including sparkline
-ScMarkData aMark(rDocument.GetSheetLimits());
-aMark.SetMarkArea(aRange.aStart);
-rDocFunc.DeleteContents(aMark, InsertDeleteFlags::CONTENTS, true, true);
+auto pSparklines =
pSparklineList->getSparklinesFor(pSparklineGroups[0]);
+CPPUNIT_ASSERT_EQUAL(size_t(4), pSparklines.size());
+}
-// Check Sparkline at cell A7 doesn't exists
-pSparkline = rDocument.GetSparkline(aRange.aStart);
-CPPUNIT_ASSERT(!pSparkline);
+// Clear content of cell D7 - including sparkline
+{
+ScMarkData aMark(rDocument.GetSheetLimits());
+aMark.SetMarkArea(ScAddress(3, 6, 0));
+rDocFunc.DeleteContents(aMark, InsertDeleteFlags::CONTENTS, true,
true);
+}
+
+// Check Sparklines
+{
+
[Libreoffice-commits] core.git: vcl/inc vcl/Library_vclplug_gen.mk vcl/skia vcl/unx
vcl/Library_vclplug_gen.mk |1
vcl/inc/unx/salgdi.h| 97 ++
vcl/skia/x11/salvd.cxx |2
vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.cxx | 185 +
vcl/unx/generic/gdi/X11CairoSalGraphicsImpl.hxx | 97 ++
vcl/unx/generic/gdi/gdiimpl.cxx | 32 +-
vcl/unx/generic/gdi/gdiimpl.hxx |2
vcl/unx/generic/gdi/salgdi.cxx | 339 +++-
vcl/unx/generic/gdi/salvd.cxx |6
9 files changed, 394 insertions(+), 367 deletions(-)
New commits:
commit a98971ac975e19efa2336b608506eefa85ce2485
Author: Tomaž Vajngerl
AuthorDate: Mon Apr 11 23:31:50 2022 +0900
Commit: Tomaž Vajngerl
CommitDate: Wed Apr 13 01:20:31 2022 +0200
vcl: move X11 drawing that uses cairo into X11CairoSalGraphicsImpl
If cairo is available we override drawPolyPolygon and drawPolyLine
with an implementation that uses cairo to draw instead of X11.
This override was previously done in X11SalGraphics, but as we want
to have all the drawing in backends (SalGraphicsImpl children) this
also needs to be moved to one. In this case we can just derive
X11SalGraphicsImpl and implement specifics there. As there is some
common stuff now betwee X11SalGraphics and X11SalGraphicsImpl,
also add X11Common, which includes those.
Change-Id: Id1e0c5227506e03d3dd0f937e4ef50d69b17bb22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132827
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl
diff --git a/vcl/Library_vclplug_gen.mk b/vcl/Library_vclplug_gen.mk
index 73f5464d7362..2cefd3f76856 100644
--- a/vcl/Library_vclplug_gen.mk
+++ b/vcl/Library_vclplug_gen.mk
@@ -98,6 +98,7 @@ $(eval $(call gb_Library_add_exception_objects,vclplug_gen,\
vcl/unx/generic/dtrans/X11_transferable \
vcl/unx/generic/gdi/cairo_xlib_cairo \
vcl/unx/generic/gdi/x11cairotextrender \
+vcl/unx/generic/gdi/X11CairoSalGraphicsImpl \
vcl/unx/generic/gdi/gdiimpl \
vcl/unx/generic/gdi/salbmp \
vcl/unx/generic/gdi/salgdi2 \
diff --git a/vcl/inc/unx/salgdi.h b/vcl/inc/unx/salgdi.h
index 2d0e00800886..045a3848e20f 100644
--- a/vcl/inc/unx/salgdi.h
+++ b/vcl/inc/unx/salgdi.h
@@ -62,6 +62,29 @@ namespace basegfx {
class B2DTrapezoid;
}
+class X11Common
+{
+public:
+Drawable m_hDrawable;
+const SalColormap* m_pColormap;
+cairo_surface_t* m_pExternalSurface;
+
+X11Common();
+
+cairo_t* getCairoContext();
+
+static void releaseCairoContext(cairo_t* cr);
+
+bool SupportsCairo() const;
+
+const SalColormap& GetColormap() const { return *m_pColormap; }
+const SalDisplay* GetDisplay() const { return GetColormap().GetDisplay(); }
+const SalVisual& GetVisual() const { return GetColormap().GetVisual(); }
+Display* GetXDisplay() const { return GetColormap().GetXDisplay(); }
+Pixel GetPixel(Color nColor) const { return
GetColormap().GetPixel(nColor); }
+Drawable GetDrawable() const { return m_hDrawable; }
+};
+
class X11SalGraphics final : public SalGraphicsAutoDelegateToImpl
{
friend class X11SalGraphicsImpl;
@@ -78,18 +101,10 @@ public:
voidDeInit();
virtual SalGraphicsImpl*GetImpl() const override;
-inline const SalDisplay* GetDisplay() const;
-inline Display*GetXDisplay() const;
-inline const SalVisual&GetVisual() const;
SalGeometryProvider*GetGeometryProvider() const;
-DrawableGetDrawable() const { return hDrawable_; }
voidSetDrawable(Drawable d, cairo_surface_t*
surface, SalX11Screen nXScreen);
XRenderPictFormat* GetXRenderFormat() const;
voidSetXRenderFormat( XRenderPictFormat*
pXRenderFormat ) { m_pXRenderFormat = pXRenderFormat; }
-const SalColormap& GetColormap() const { return *m_pColormap; }
-
-using SalGraphics::GetPixel;
-inline Pixel GetPixel( Color nColor ) const;
const SalX11Screen& GetScreenNumber() const { return
m_nXScreen; }
@@ -98,15 +113,6 @@ public:
// override all pure virtual methods
virtual voidGetResolution( sal_Int32& rDPIX,
sal_Int32& rDPIY ) override;
-virtual voidResetClipRegion() override;
-virtual boolsetClipRegion( const vcl::Region& )
override;
-
-virtual voidSetLineColor() override;
-virtual voidSetLineColor( Color nColor ) override;
-virtual voidSetFillColor() override;
-
-virtual voidSetFillColor( Color nColor ) override;
-
virtual voidSetTextColor( Color nColor ) override;
virtual voidSetFont(LogicalFontInstance*, int
[Libreoffice-bugs] [Bug 148544] proposal-option to remove whitespace characters (other than space) in "paste special", "clear direct formatting", Format->Text and in import dialog box
https://bugs.documentfoundation.org/show_bug.cgi?id=148544 Eric Williamson changed: What|Removed |Added Summary|proposal-option to remove |proposal-option to remove |whitespace characters |whitespace characters |(other than space) in |(other than space) in |"paste special" and in |"paste special", "clear |Format-Text |direct formatting", ||Format->Text and in import ||dialog box -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148544] New: proposal-option to remove whitespace characters (other than space) in "paste special" and in Format-Text
https://bugs.documentfoundation.org/show_bug.cgi?id=148544 Bug ID: 148544 Summary: proposal-option to remove whitespace characters (other than space) in "paste special" and in Format-Text Product: LibreOffice Version: 7.2.6.2 release Hardware: All OS: All Status: UNCONFIRMED Severity: enhancement Priority: medium Component: LibreOffice Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: eriwi...@redhat.com Description: In Calc: 1. a tick box in Paste Special to remove "all whitespace" as a pasting feature 2. a menu option in Format -> Text. To do the same thing. --Since other formatting options like *case (UPPER/lower/etc) exist, it might also makes sense to have it here as well since whitespace characters affect the positioning and formatting. 3. Import data dialog box... same as #1 but in the import dialog box to allow whitespace removing while importing data. 4. (Optional) have it as part of the "Clear Direct Formatting" menu option. -Also a comparable feature in the other office suite programs. Actual Results: I cannot find the equivalent functionality, other than using cell formulas to accomplish the same task: =trim(clean(*cell*)) Expected Results: self explanatory.. Reproducible: Always User Profile Reset: No Additional Info: The proposal would be the equivalent of (in Calc): =trim(clean(*cell*)) & paste special -> text, then copy the new cell, over the old one. This would help when importing/copy & paste from databases, websites, pdf's, other spreadsheet programs, etc. For example, when a website has a built in grid/spreadsheet, white space characters often copy over with it. Same when copying data from a database. A lot of whitespace characters and unnecessary padding that meets the needs of the database column types, but not necessary for Calc users. Often when I do import and I find the current formatting annoying, I will do a "Clear Direct Formatting". Having it built into this functionality would also be beneficial since it serves no purpose (I can't think of a use case) for retaining those whitespaces after a "clear direct formatting" use. --I assume that other latin letter based character sets have the same whitespace problems. I am not sure if this is the case with non-latin (i.e. 16bit+ wide) character sets. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 98005] Show footnotes and endnotes in Navigator
https://bugs.documentfoundation.org/show_bug.cgi?id=98005 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #18 from sdc.bla...@youmail.dk --- I believe this ticket is now WFM (tested with 7.4.0.0.alpha0+) or FIXED (by bug 144788 and bug 145043) -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148543] New: Excess character format code embedded in Writer documents
https://bugs.documentfoundation.org/show_bug.cgi?id=148543 Bug ID: 148543 Summary: Excess character format code embedded in Writer documents Product: LibreOffice Version: 7.0.0.3 release Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: ern...@bywater.net.au Description: When editing a document several days after first writing and saving the document the new text entered is assigned its own format code which is embedded in the document instead of being left to have the paragraph style code applied to it. This results in the document being larger and causes issues when converting the finished document from .ODT to other formats. The way it SHOULD work is when I type a paragraph with an applied style all of the format code is stored within the document at the start of the paragraph and any later text entered into the paragraph should inherit the format of the paragraph. What IS happening is the initial text is saved as it should be, but a later edit has the new text entered with the characters of the new text being assigned their won format code which is embedded into the document as well. Thus instead of having the - < font type> < font size > < font color > then the general text - which is how the original text is saved the revised text is saved as - < font type> < font size > < font color > then the general < font type> < font size > < font color > revised text - another later revision would see - < font type> < font size > < font color > then the general < font type> < font size > < font color > revised text < font type> < font size > < font color > and more revised text . The brackets < > are used to show the type of format code that is saved with the document but not readily visible to the user in the .ODT format but does show up in other formats. Thus there are two or more sets of format code where only one is needed, but it all get transferred over when the document is changed from .ODT to other format like .HTML where such code is more easily visible. This problem ONLY appears where there has been edits made after the document had been saved and returned to later. Unedited paragraphs do not have the problem of the extra format code. I am now using a AMD with Linux, but have noticed the same problem with Intel systems using Windows. Not sure when it started but hae noticed with every version of LO 7 Steps to Reproduce: 1.Create an ODT document. 2.Save the document and close the file. 3.Reopene the document hours later and enter edits within the paragraphs previously typed. 4. Save the document as another format to make the hidden format code visible - most visible in html. Actual Results: Both James and John are fit and while their bags are big they aren't heavy. However, they're easy to carry on their backs by the leather straps they're using over their shoulders to hold the bags in place. Their long confident strides eat up the miles along the road. In the late afternoon or early evening they intend to find local inns to stay in for the night. There is a lot of day left when they dock so John and James start walking home. Expected Results: Both James and John are fit and while their bags are big they aren't heavy. However, they're easy to carry on their backs by the leather straps they're using over their shoulders to hold the bags in place. Their long confident strides eat up the miles along the road. In the late afternoon or early evening they intend to find local inns to stay in for the night. There is a lot of day left when they dock so John and James start walking home. Reproducible: Always User Profile Reset: Yes Additional Info: In the example above the original text last sentence was: There is half of the day left when they dock so John and James start walking home. This was edited to: There is a lot of the day left when they dock so John and James start walking home. The extra format code information was inserted and applied to the changed words instead of leaving them to inherit the format of the rest of the paragraph from its class style of 'western' - - - this is extremely troublesome to fix when converting to html and epub documents. This was NOT a problem in LO 3 or 4 or 5and I'm not sure about LO 6. Version: 7.3.1.3 / LibreOffice Community Build ID: 30(Build:3) CPU threads: 12; OS: Linux 5.15; UI render: default; VCL: kf5 (cairo+xcb) Locale: en-AU (en_AU.UTF-8); UI: en-US 7.3.1-1 Calc: threaded -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 86297] Wrong Field reference when heading is in a frame
https://bugs.documentfoundation.org/show_bug.cgi?id=86297 sdc.bla...@youmail.dk changed: What|Removed |Added CC||sdc.bla...@youmail.dk --- Comment #9 from sdc.bla...@youmail.dk --- Repro with attachment 142218 Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4 CPU threads: 8; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: da-DK (da_DK); UI: en-US Calc: CL There are many different issues in this ticket, but no evaluation of whether headings inside of Frames should participate in the outline structure of the document. Might be worth asking the Design Team to confirm that the expectations here are valid for Frames. To do that: Add 'needsUXEval' to Keywords and libreoffice-ux-adv...@lists.freedesktop.org to CC list -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147893] Embedded firebird extends size of CHAR() data field beyond set boundaries and invokes error message
https://bugs.documentfoundation.org/show_bug.cgi?id=147893 Andreas Heinisch changed: What|Removed |Added URL||https://github.com/Firebird ||SQL/firebird/issues/5854 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120640] FIREBIRD: CHAR() - Values not appearing in base listbox with value list
https://bugs.documentfoundation.org/show_bug.cgi?id=120640 Andreas Heinisch changed: What|Removed |Added URL||https://github.com/Firebird ||SQL/firebird/issues/5854 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148237] crossreference field for footnote and endnote in Navigator should identify the field as footnote or endnote
https://bugs.documentfoundation.org/show_bug.cgi?id=148237 sdc.bla...@youmail.dk changed: What|Removed |Added Ever confirmed|1 |0 Status|NEEDINFO|UNCONFIRMED --- Comment #2 from sdc.bla...@youmail.dk --- Thanks for the thorough evaluation Dieter. I suggest that the display in Navigator should be: crossreference - footnote - [number of footnote that appears in Selection listbox in Edit Fields dialog] crossreference - endnote - [number of endnote that appears in Selection listbox in Edit Fields dialog] Additional information: 1. In 7.2.6.2, actual display for Footnotes and Endnote is: crossreference - 2. In 7.4.0.0, Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4 In attachment, use Edit Fields on cross-reference to Footnote 1. Choose "1 Footnote 1" in Selection and "Above/Below" in "Refer using" Actual result: cross-reference - under - under 3. 21b5d6e0dce7c2034aded96d1499da27094e2781 might be relevant to this situation. 4. (slightly off-topic) In 7.4.0.0, Build ID: d34d1db55978bdcff082af1e0f75b18fa6fc94f4, inspired by bug 45048, insert several Field Statistics, with different Selections. Actual (nice) result: field - Statistics - Pages 2 field - Statistics - Paragraphs - 19 field - Statistics - Words - 83 (makes it possible to hide the fields in the text (or template), and follow the data in Navigator). -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: 2 commits - sc/inc sc/qa sc/source
sc/inc/attarray.hxx |1
sc/inc/column.hxx|6 ---
sc/inc/dociter.hxx |4 --
sc/inc/document.hxx |5 --
sc/inc/table.hxx |4 --
sc/qa/unit/ucalc.cxx | 66 ---
sc/source/core/data/attarray.cxx | 20 ---
sc/source/core/data/dociter.cxx | 61 +---
sc/source/core/data/table1.cxx | 15
9 files changed, 71 insertions(+), 111 deletions(-)
New commits:
commit 07745a031da255991c2d4c1533e916bb604d66c2
Author: Luboš Luňák
AuthorDate: Tue Apr 12 15:19:38 2022 +0200
Commit: Luboš Luňák
CommitDate: Tue Apr 12 23:10:29 2022 +0200
don't ignore GetDefPattern() in ScHorizontalAttrIterator
As said in the previous commit, the default pattern is the default
style that can be edited by the user, so it's principially incorrect
to simply ignore it. If needed for performance, then it needs
to be done explicitly. This change currently should not affect
anything, as ScHorizontalAttrIterator is used only in tests.
Change-Id: I31f153d427cdfd6e98a4d7a3584cfa89676d4c33
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132912
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 2aee6ac950c1..99ceb1e99972 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -499,8 +499,6 @@ public:
boolGetNext( double& rValue, FormulaError& rErr );
};
-// returns all areas with non-default formatting (horizontal)
-
class ScHorizontalAttrIterator
{
private:
@@ -518,11 +516,9 @@ private:
ppPatterns;
SCCOL nCol;
SCROW nRow;
-boolbRowEmpty;
SCROW nMinNextEnd;
void InitForNextRow(bool bInitialization);
-bool InitForNextAttr();
public:
ScHorizontalAttrIterator( ScDocument& rDocument, SCTAB nTable,
diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 020e43c6dbde..8da0c6132aee 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -117,6 +117,7 @@ public:
void testValueIterator();
void testHorizontalAttrIterator();
void testIteratorsUnallocatedColumnsAttributes();
+void testIteratorsDefPattern();
void testLastChangedColFlagsWidth();
/**
@@ -251,6 +252,7 @@ public:
CPPUNIT_TEST(testValueIterator);
CPPUNIT_TEST(testHorizontalAttrIterator);
CPPUNIT_TEST(testIteratorsUnallocatedColumnsAttributes);
+CPPUNIT_TEST(testIteratorsDefPattern);
CPPUNIT_TEST(testLastChangedColFlagsWidth);
CPPUNIT_TEST(testCellBroadcaster);
CPPUNIT_TEST(testFuncParam);
@@ -1394,12 +1396,15 @@ void Test::testHorizontalAttrIterator()
SCCOL nCol1, nCol2;
SCROW nRow;
size_t nCheckPos = 0;
-for (const ScPatternAttr* pAttr = aIter.GetNext(nCol1, nCol2, nRow);
pAttr; pAttr = aIter.GetNext(nCol1, nCol2, nRow), ++nCheckPos)
+for (const ScPatternAttr* pAttr = aIter.GetNext(nCol1, nCol2, nRow);
pAttr; pAttr = aIter.GetNext(nCol1, nCol2, nRow))
{
- CPPUNIT_ASSERT_MESSAGE("Iteration longer than expected.",
nCheckPos < nCheckLen);
- CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][0],
static_cast(nCol1));
- CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][1],
static_cast(nCol2));
- CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][2],
static_cast(nRow));
+if( pAttr == m_pDoc->GetDefPattern())
+continue;
+CPPUNIT_ASSERT_MESSAGE("Iteration longer than expected.",
nCheckPos < nCheckLen);
+CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][0],
static_cast(nCol1));
+CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][1],
static_cast(nCol2));
+CPPUNIT_ASSERT_EQUAL(aChecks[nCheckPos][2],
static_cast(nRow));
+++nCheckPos;
}
}
@@ -1458,6 +1463,57 @@ void Test::testIteratorsUnallocatedColumnsAttributes()
m_pDoc->DeleteTab(0);
}
+void Test::testIteratorsDefPattern()
+{
+m_pDoc->InsertTab(0, "Tab1");
+
+// The default pattern is the default style, which can be edited by the
user.
+// As such iterators should not ignore it by default, because it might
contain
+// some attributes set.
+
+// Set cells as bold, default allocated, bold, default unallocated.
+SCCOL firstCol = 100;
+SCCOL lastCol = 103;
+ScPatternAttr boldAttr(m_pDoc->GetPool());
+boldAttr.GetItemSet().Put(SvxWeightItem(WEIGHT_BOLD, ATTR_FONT_WEIGHT));
+m_pDoc->ApplyPattern(100, 0, 0, boldAttr);
+m_pDoc->ApplyPattern(102, 0, 0, boldAttr);
+
+CPPUNIT_ASSERT_EQUAL(SCCOL(102 + 1), m_pDoc->GetAllocatedColumnsCount(0));
+const ScPatternAttr* pattern = m_pDoc->GetPattern(100, 0, 0);
+const ScPatternAttr* defPattern = m_pDoc->GetDefPattern();
+
[Libreoffice-bugs] [Bug 148239] Column width value in hover text depends on position of the cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=148239 raal changed: What|Removed |Added OS|Windows (All) |All -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148239] Column width value in hover text depends on position of the cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=148239 --- Comment #2 from raal --- Created attachment 179494 --> https://bugs.documentfoundation.org/attachment.cgi?id=179494=edit video of the problem -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148239] Column width value in hover text depends on position of the cursor
https://bugs.documentfoundation.org/show_bug.cgi?id=148239 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||r...@post.cz Keywords||bibisectRequest, regression Ever confirmed|0 |1 --- Comment #1 from raal --- Confirm wit Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: ab8d141967111ca81f4607db3618bb09214e42db CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo I see no tooltip in Version: 7.0.0.0.alpha1+ Build ID: 574c57090642347980d2395e1e183cc7b5c171ad CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded adding tag bibisectrequest for bibisect where tooltip was made. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148265] Freeze when u want copy from one file to another opened file - macOS
https://bugs.documentfoundation.org/show_bug.cgi?id=148265 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added Status|UNCONFIRMED |NEEDINFO Ever confirmed|0 |1 --- Comment #4 from Roman Kuznetsov <79045_79...@mail.ru> --- Kamil, any news? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120640] FIREBIRD: CHAR() - Values not appearing in base listbox with value list
https://bugs.documentfoundation.org/show_bug.cgi?id=120640 --- Comment #8 from Andreas Heinisch --- However, in the length field in the edit table view, the correct length is show. Maybe during the creation of the table the spurious size will be added? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144515] Perf: slow operation on a Calc cell with huge text
https://bugs.documentfoundation.org/show_bug.cgi?id=144515 --- Comment #6 from Commit Notification --- Luboš Luňák committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/e3830b06a9886620ed432a011d2de2abbb7a3a12 don't FormatDoc() a whole long text if not necessary (tdf#144515) It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144515] Perf: slow operation on a Calc cell with huge text
https://bugs.documentfoundation.org/show_bug.cgi?id=144515 Commit Notification changed: What|Removed |Added Whiteboard||target:7.4.0 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 144515] Perf: slow operation on a Calc cell with huge text
https://bugs.documentfoundation.org/show_bug.cgi?id=144515 Luboš Luňák changed: What|Removed |Added Status|NEW |RESOLVED CC||l.lu...@collabora.com Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: editeng/source include/editeng sc/source
editeng/source/editeng/editeng.cxx |5 +
editeng/source/editeng/impedit.hxx |3 +++
editeng/source/editeng/impedit2.cxx |1 +
editeng/source/editeng/impedit3.cxx | 21 -
include/editeng/editeng.hxx |4
sc/source/ui/view/output2.cxx |5 +
6 files changed, 38 insertions(+), 1 deletion(-)
New commits:
commit e3830b06a9886620ed432a011d2de2abbb7a3a12
Author: Luboš Luňák
AuthorDate: Tue Apr 12 18:21:35 2022 +0200
Commit: Luboš Luňák
CommitDate: Tue Apr 12 22:16:05 2022 +0200
don't FormatDoc() a whole long text if not necessary (tdf#144515)
The testcase has a very long text in a cell that is really high
enough to hold only one line of text, yet EditEngine formats and
wraps the entire string. Which can be expensive because of calling
into text layout to find out width of a text portion, and this
is done repeatedly for the yet-unformatted text, so pretty much
O(N^2). For top-aligned text it's enough to format only as much
as will fit and ignore the rest, so implement that and add
EditEngine::EnableSkipOutsideFormat() to enable the optimization.
Change-Id: Ida87a1843737a368798ba2b3e60eedc99ee0f611
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132932
Tested-by: Jenkins
Reviewed-by: Luboš Luňák
diff --git a/editeng/source/editeng/editeng.cxx
b/editeng/source/editeng/editeng.cxx
index eb7d1ad5a6fa..237c78264e72 100644
--- a/editeng/source/editeng/editeng.cxx
+++ b/editeng/source/editeng/editeng.cxx
@@ -2856,6 +2856,11 @@ void EditEngine::DisableAttributeExpanding() {
pImpEditEngine->GetEditDoc().DisableAttributeExpanding();
}
+void EditEngine::EnableSkipOutsideFormat(bool set)
+{
+pImpEditEngine->EnableSkipOutsideFormat(set);
+}
+
void EditEngine::SetLOKSpecialPaperSize(const Size& rSize)
{
pImpEditEngine->SetLOKSpecialPaperSize(rSize);
diff --git a/editeng/source/editeng/impedit.hxx
b/editeng/source/editeng/impedit.hxx
index 894bb822f676..e66988d60e0c 100644
--- a/editeng/source/editeng/impedit.hxx
+++ b/editeng/source/editeng/impedit.hxx
@@ -604,6 +604,7 @@ private:
boolbFirstWordCapitalization:1; // specifies if
auto-correction should capitalize the first word or not
boolmbLastTryMerge:1;
boolmbReplaceLeadingSingleQuotationMark:1;
+boolmbSkipOutsideFormat:1;
boolmbNbspRunNext; // can't be a bitfield as it is passed as
bool&
@@ -1131,6 +1132,8 @@ public:
/** Whether last AutoCorrect inserted a NO-BREAK SPACE that may need to be
removed again. */
boolIsNbspRunNext() const { return mbNbspRunNext; }
+void EnableSkipOutsideFormat(bool set) { mbSkipOutsideFormat = set; }
+
void Dispose();
void SetLOKSpecialPaperSize(const Size& rSize) { aLOKSpecialPaperSize =
rSize; }
const Size& GetLOKSpecialPaperSize() const { return aLOKSpecialPaperSize; }
diff --git a/editeng/source/editeng/impedit2.cxx
b/editeng/source/editeng/impedit2.cxx
index 4b7b3490d138..94cc2d479b36 100644
--- a/editeng/source/editeng/impedit2.cxx
+++ b/editeng/source/editeng/impedit2.cxx
@@ -123,6 +123,7 @@ ImpEditEngine::ImpEditEngine( EditEngine* pEE, SfxItemPool*
pItemPool ) :
bFirstWordCapitalization(true),
mbLastTryMerge(false),
mbReplaceLeadingSingleQuotationMark(true),
+mbSkipOutsideFormat(false),
mbNbspRunNext(false)
{
aStatus.GetControlWord() = EEControlBits::USECHARATTRIBS |
EEControlBits::DOIDLEFORMAT |
diff --git a/editeng/source/editeng/impedit3.cxx
b/editeng/source/editeng/impedit3.cxx
index cdcc05100730..372237ff9c70 100644
--- a/editeng/source/editeng/impedit3.cxx
+++ b/editeng/source/editeng/impedit3.cxx
@@ -621,10 +621,18 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
return FinishCreateLines( );
}
+sal_Int64 nCurrentPosY = nStartPosY;
+// If we're allowed to skip parts outside and this cannot possibly fit in
the given height,
+// bail out to avoid possibly formatting a lot of text that will not be
used. For the first
+// paragraph still format at least a bit.
+if( mbSkipOutsideFormat && nPara != 0
+&& !aStatus.AutoPageHeight() && aPaperSize.Height() < nCurrentPosY )
+{
+return false;
+}
// Initialization...
-
// Always format for 100%:
bool bMapChanged = ImpCheckRefMapMode();
@@ -1607,6 +1615,7 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
// as nEnd points to the last
character!
sal_Int32 nEndPortion = pLine->GetEndPortion();
+nCurrentPosY += pLine->GetHeight();
// Next line or maybe a new line...
pLine = nullptr;
@@ -1617,6 +1626,16 @@ bool ImpEditEngine::CreateLines( sal_Int32 nPara,
sal_uInt32 nStartPosY )
nDelFromLine = nLine;
[Libreoffice-commits] core.git: sc/source
sc/source/ui/view/output2.cxx |5 + 1 file changed, 5 insertions(+) New commits: commit efb60b6fb5e11c31fecddf1e0502c1fe4feb7b57 Author: Luboš Luňák AuthorDate: Tue Apr 12 20:02:24 2022 +0200 Commit: Luboš Luňák CommitDate: Tue Apr 12 22:15:41 2022 +0200 treat Calc cells that don't fit as top-aligned rather than bottom For cells it normally looks better to align them to the bottom, but if the content doesn't fit, it looks better to align to top, because that shows the start rather than the end of the content, and it also logically goes together with the clip mark shown to the right of it. Change-Id: Iac51e9e59d5ab9f5c89374a3e638a4a572f8b1fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132931 Tested-by: Jenkins Reviewed-by: Luboš Luňák diff --git a/sc/source/ui/view/output2.cxx b/sc/source/ui/view/output2.cxx index ea35193dc24b..e7bed3f92790 100644 --- a/sc/source/ui/view/output2.cxx +++ b/sc/source/ui/view/output2.cxx @@ -3092,6 +3092,11 @@ void ScOutputData::DrawEditStandard(DrawEditParam& rParam) tools::Long nMarkPixel = static_cast( SC_CLIPMARK_SIZE * mnPPTX ); if ( aAreaParam.maClipRect.Right() - nMarkPixel > aAreaParam.maClipRect.Left() ) aAreaParam.maClipRect.AdjustRight( -nMarkPixel ); + +// Standard is normally treated as Bottom, but if text height is clipped, then +// Top looks better and also allows using EditEngine::EnableSkipOutsideFormat(). +if (rParam.meVerJust==SvxCellVerJustify::Standard) +rParam.meVerJust=SvxCellVerJustify::Top; } }
[Libreoffice-bugs] [Bug 148524] FILESAVE RTF Checkbox checked state is not retained
https://bugs.documentfoundation.org/show_bug.cgi?id=148524 raal changed: What|Removed |Added Status|UNCONFIRMED |NEW Ever confirmed|0 |1 CC||r...@post.cz --- Comment #1 from raal --- Confirm with Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: ab8d141967111ca81f4607db3618bb09214e42db CPU threads: 4; OS: Linux 5.13; UI render: default; VCL: gtk3 Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US Calc: threaded Jumbo -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 91476] FILEOPEN : XLSX sparkline is not imported in LO
https://bugs.documentfoundation.org/show_bug.cgi?id=91476 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru, ||qui...@gmail.com --- Comment #12 from Roman Kuznetsov <79045_79...@mail.ru> --- Tomaž, in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: 4d27d087de2922f918a76437a1385dc4a287afc3 CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Jumbo I still don't see the sparklines in the example from attach -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120640] FIREBIRD: CHAR() - Values not appearing in base listbox with value list
https://bugs.documentfoundation.org/show_bug.cgi?id=120640 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=14 ||7893 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 147893] Embedded firebird extends size of CHAR() data field beyond set boundaries and invokes error message
https://bugs.documentfoundation.org/show_bug.cgi?id=147893 Robert Großkopf changed: What|Removed |Added See Also||https://bugs.documentfounda ||tion.org/show_bug.cgi?id=12 ||0640 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148542] EDITING delete row - Crash in: ScBroadcastAreaSlot::DelBroadcastAreasInRange(ScRange const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=148542 Roman Kuznetsov <79045_79...@mail.ru> changed: What|Removed |Added CC||79045_79...@mail.ru Ever confirmed|0 |1 Status|UNCONFIRMED |NEEDINFO --- Comment #2 from Roman Kuznetsov <79045_79...@mail.ru> --- no repro in Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community Build ID: ccb78b98e0618cce365562fe326d018892b8104a CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: CL Jumbo possibly Win 11 only? Could you try reset your LibreOffice's user profile using Help->Restart in Safe mode dialog? -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 120640] FIREBIRD: CHAR() - Values not appearing in base listbox with value list
https://bugs.documentfoundation.org/show_bug.cgi?id=120640 Robert Großkopf changed: What|Removed |Added Summary|Values not appearing in |FIREBIRD: CHAR() - Values |base listbox with value |not appearing in base |list|listbox with value list CC||rob...@familiegrosskopf.de --- Comment #7 from Robert Großkopf --- Seems this is the same bug as https://bugs.documentfoundation.org/show_bug.cgi?id=147893. CHAR() will be set to the 4th length of the string, which is defined. So you could change the list fields by adding 9 spaces to each entry, because 9 spaces could also been seen in the table. This is a special Firebird bug. -- You are receiving this mail because: You are the assignee for the bug.
Re: Headless mail merge
Hi everybody, I've carefully read all of your suggestions and finally decided to go with odfpy instead. If you're curious, here's the implementation: https://git.libreoffice.org/infra/mc-tooling/+/8d1e2135704ba8cdbed7223458d49ebec84928b7%5E%21/#F0 Thanks again, All the best, Marco Il 06/04/22 12:47, Marco Marinello ha scritto: > Hi all, > > > what's the easiest way to perform a mail-merge with libreoffice by > passing arguments from an automated script? Should I use UNO? > > Do you have any reference? > > > Thanks in advance, > > Best, > > Marco > > >
[Libreoffice-commits] core.git: Changes to 'refs/tags/libreoffice-7.3.3.1'
Tag 'libreoffice-7.3.3.1' created by Christian Lohmaier at 2022-04-12 19:18 + Tag libreoffice-7.3.3.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmJV0JgACgkQ9DSh76/u rqP9rQ/8C0SnlstPFv2xObN3qTCqQdj+med6h1WLRNBkauTdQZ9HpZaHOscA2CMW bxCEum3qEqFAlUi/TcmagFJpZ6wFNjIICzaxI6M92pSJAfFLYa9WprHTqWZo0F8u DNvwu9dA8Q7VZ+wySmYHUltoUvyd7/INZMCjQjvOc6ltWmWOobgMbo75E4YudNqN 9qI1xXS/Z6H2UjYTm1fLBpaedw9gFs8v6guq7npGohdUQcmIZmk/AzSEPafCD3ow W0k/6aIRQ7qc0TZdwLh44ED7J39g9L67jN/KLpRyRjVDeGVLKb8ALSDPV61mVkLH oUzJa8lXazpFrFK9jDs4RJKkR00YAol2WEYH4/ozeu9G67nfYPelcGpPOL5ltezU c8Ts+CHdujuItqecreequNMpDMwEAv8WA0WGc9sIh2oBOPjpQfikAoUrQWQJ9y9+ pF/O1m8m2gebgwgLrE044u9Dxys1CdRreoy3fKh5IQjM5/5gxElflPGYdGiRiqOe rfuoQJh49wtusar1/v6x+zNRa9CkSMGqgITr1xt+XlcL/QVv8UNHcPPvxK1Yc2DY 52wkA/2xUzDsl70rEgCJYsjI/2xKY77VAcHIjGa3fme5DUvA7Ud0Ohls1l9WK17w OEQxxMtWzv7AV+wUAADKRx37G2c8t5x9wQ+BM86UGt53+fx4kVs= =/1l1 -END PGP SIGNATURE- Changes since co-22.05-branch-point-379: --- 0 files changed ---
[Libreoffice-commits] translations.git: Changes to 'refs/tags/libreoffice-7.3.3.1'
Tag 'libreoffice-7.3.3.1' created by Christian Lohmaier at 2022-04-12 19:18 + Tag libreoffice-7.3.3.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmJV0JgACgkQ9DSh76/u rqOvcRAAgViXKkD/6K8fQTYds2+vyXgIxuoZuO31/bKb1wz3XWtj5z8T8H4m3ptL k8XJUJHZdFjwVnEkyiXgflpRnr/D8OHT/l/mqU2GILwkdyuXr0QtZ06ONmOEy9+m rYbW/rm98RzchR2UjxANJgDoS6Jo3VtSwUSVHLn4/jkSnSV001wX7JRtu6s0CuXe WDTInLEPkLzHhsIZA4uPq5ooWB8SjKHnRLN85bntBh8m3fZoZZ8YlbJZgp/jjTtE U0ukhaXGgojXmmxwUvaEQInN5cdskuUi6d56bFSM+xT6TU+dfdGp9NgPcsMMVIBg smV7a+j+cyY/fTFwmmpCct8AuQCCFV7ZxmyLJ2Oivq/TQVU5C5f8L3IB/NDrO8HC TzSmePhWPBDesV1sfl534vKKWlKEwmxn2jO3T1txOpMpwzEiAsuMe0op1iH6zT8K I6FP+VvsuHQblSJ1GOB0DKwDYrqd/s3WThW+4d7bfuCgVL7F2FAoec1lQggnjbos kdrxurUsOw8dQCiYs6DgrUnSBSh7nEqH8aINnhicly6yJZWqH8FWms1tVaz539o6 nmDt3nGaMv66L6k3d4+0AvrzJyJY/Fizo20zw6mjQrwac4787HgOODiaIluRR/oy jsRE9Ekc9qlucWro9a3RUclZFlVezsequz1L5hvDAaxlolBIEkI= =HXi0 -END PGP SIGNATURE- Changes since co-22.05-branch-point-9: --- 0 files changed ---
[Libreoffice-commits] help.git: Changes to 'refs/tags/libreoffice-7.3.3.1'
Tag 'libreoffice-7.3.3.1' created by Christian Lohmaier at 2022-04-12 19:18 + Tag libreoffice-7.3.3.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmJV0JgACgkQ9DSh76/u rqMVShAAlsyryExZVIWKjc8y6ftWqwpiqGNgryIuHugdF5wOrrVOZdctnDY8DiVo R4z+oJedpbCzYU/lAUs0w4yKe9GITTGdbY4UiDrTA27+OI89ixA0MUTvk+tAFdn6 VhaBXli+XPKs3JBAeWbCtzNXEpSaIP4eTtBYyND/u6M+zQoAFhTEbATgaBsrCnfB /nT503C4SOZxrc1mTThHN0moPQZ1DEA+YNhN0WsmC8slIAmQ9yzhhT7srhkYsezb tiqkbSGBNxpOahSPBvZ/DS+9CB1oG+9mK/rGXk643s45dZ/mMZzi4Dr0865Kf/ye Now1xBCz0wRCBRsXq45UBVygfb2mWuGiIF7FaRLLnEgKlIl5ANB3iZR0IpdRvVca n1+++KEWYm6B+i6HodwI4TOLzkPp5EKTlKCJ7BqEYOAkt1CbMjCGSNyTxYyT5Ea7 QTon1o8gJJspSKIOZVx2SHrNlhzvudPWoC5wmHp13K4R6mJ9J1ziiRQni6IfB/eV Fo4hQ/iH7JwJbNPibVAvyLFEcdeJV6Ceoy4+6t4jLkQeffF6urGeIs7QHIxxps+q ITXux8vRr2jRRJnOaSRdj/jTM66q4U0p+ZqOBUwv3d0HNPZwWiSdFAZ6R0zk95cB qoBtJt3LisrjuhXCn09amS649SLNSGNJW5obw+53RNKQcoCADno= =n/La -END PGP SIGNATURE- Changes since co-22.05-branch-point-2: --- 0 files changed ---
[Libreoffice-commits] dictionaries.git: Changes to 'refs/tags/libreoffice-7.3.3.1'
Tag 'libreoffice-7.3.3.1' created by Christian Lohmaier at 2022-04-12 19:18 + Tag libreoffice-7.3.3.1 -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEwoOeytlAj76VMcPp9DSh76/urqMFAmJV0JQACgkQ9DSh76/u rqPgohAAqlK8bqOKd+AIwdO64byYlY3eLB/gCIKEyTcOfXoka9xZx0rwH52SdFTR +jHiPk8rJjsXzo1fJzDbbQedzvkOB5paIgssS6f63vlY+TcSDQs/zmOfZBhNGGAA aE0s+p8nqpI8ZQZ6qNTQRZFhtKDwva91fBcjg2QCKgZLpiLRdt0kywyPy0npTL7H YDC5YuoF+xUGdRvSi742W1LKhg8CNzIRVFGpB27gJj4MX+rHJexlRFBl9A2qqOhB emWCzQKKvhyG9VJa4iqXiEuYBQISJv2F+IQWOtPYEV2LBXY5P+6dHcF1hNvRUCtU Z+W6L1zyzEdDjF+Z1cRcm8NkRINnAstwDMB5jxgm6nTdBVBC5TZ2799apj8sSKkl 6fHeXLjrwt39xgRhQSI8ZfX5p5p14Qge4jB9F8OeI9KUblw0HThaZiQOs5ct+/ox 0ahdLtDzR9BRWVCc98ikUpxw5JWrROL2xrx3LVWO6Q+CkikVXfK9RLmyW46CllxS OX8kdKl4kEAixAJbaF59FxFPpVGC4vS7UqFynu8gyqLkDYgfN7xpv+9waeCGjZvO KZFwxAj+wBT3py7e4osNYKk4ruUawXI0+esnfqPM856ZL7XNwVTgV63+W0SsC74e 0cW9ZqByEZjHi5/GrdsGa7Bv0JYtuP2yZaLKz0PWdamx7Q1Gidk= =CpWA -END PGP SIGNATURE- Changes since co-22.05-branch-point-2: --- 0 files changed ---
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3-3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 698d31e2b47d7995ee91c87d421abecaae64700c Author: Christian Lohmaier AuthorDate: Tue Apr 12 21:19:22 2022 +0200 Commit: Christian Lohmaier CommitDate: Tue Apr 12 21:19:22 2022 +0200 bump product version to 7.3.3.1.0+ Change-Id: Ib0ec860bbdf4bf104bbbf6799f5c4aa631022fe2 diff --git a/configure.ac b/configure.ac index a1fe4c65b291..447bd40e7d32 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.3.3.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.3.3.1.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - configure.ac
configure.ac |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 36024e89023fe7be1510867790d5976459483330 Author: Christian Lohmaier AuthorDate: Tue Apr 12 21:16:37 2022 +0200 Commit: Christian Lohmaier CommitDate: Tue Apr 12 21:16:37 2022 +0200 bump product version to 7.3.4.0.0+ Change-Id: Iea02bb7e76ef5f6b0c7df0e2340785e48698a122 diff --git a/configure.ac b/configure.ac index a1fe4c65b291..dab4326616b0 100644 --- a/configure.ac +++ b/configure.ac @@ -9,7 +9,7 @@ dnl in order to create a configure script. # several non-alphanumeric characters, those are split off and used only for the # ABOUTBOXPRODUCTVERSIONSUFFIX in openoffice.lst. Why that is necessary, no idea. -AC_INIT([LibreOffice],[7.3.3.0.0+],[],[],[http://documentfoundation.org/]) +AC_INIT([LibreOffice],[7.3.4.0.0+],[],[],[http://documentfoundation.org/]) dnl libnumbertext needs autoconf 2.68, but that can pick up autoconf268 just fine if it is installed dnl whereas aclocal (as run by autogen.sh) insists on using autoconf and fails hard
[Libreoffice-commits] core.git: Changes to 'libreoffice-7-3-3'
New branch 'libreoffice-7-3-3' available with the following commits: commit 3032f3067dedc9bc5bb0b58a5e5c2d8933ac49da Author: Christian Lohmaier Date: Tue Apr 12 21:15:21 2022 +0200 Branch libreoffice-7-3-3 This is 'libreoffice-7-3-3' - the stable branch for the 7.3.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.3.x release, please use the 'libreoffice-7-3' branch. If you want to build something cool, unstable, and risky, use master.
[Libreoffice-commits] translations.git: Changes to 'libreoffice-7-3-3'
New branch 'libreoffice-7-3-3' available with the following commits: commit 328ea1aec6376c9abe87314daafee4fe19602f63 Author: Christian Lohmaier Date: Tue Apr 12 21:15:10 2022 +0200 Branch libreoffice-7-3-3 This is 'libreoffice-7-3-3' - the stable branch for the 7.3.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.3.x release, please use the 'libreoffice-7-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: I993af8e488d79febf4656dd1a7bce04b39de252d
[Libreoffice-commits] help.git: Changes to 'libreoffice-7-3-3'
New branch 'libreoffice-7-3-3' available with the following commits: commit b0db7fc2ebf03b869727d1d448f544e7e3b76761 Author: Christian Lohmaier Date: Tue Apr 12 21:15:10 2022 +0200 Branch libreoffice-7-3-3 This is 'libreoffice-7-3-3' - the stable branch for the 7.3.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.3.x release, please use the 'libreoffice-7-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Ia66c4e2bf4e6c53f78e5b3d313987820cab1f1fb
[Libreoffice-commits] dictionaries.git: Changes to 'libreoffice-7-3-3'
New branch 'libreoffice-7-3-3' available with the following commits: commit f84c0a2fc7387b76a707b367547855aa2782cba0 Author: Christian Lohmaier Date: Tue Apr 12 21:15:10 2022 +0200 Branch libreoffice-7-3-3 This is 'libreoffice-7-3-3' - the stable branch for the 7.3.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.3.x release, please use the 'libreoffice-7-3' branch. If you want to build something cool, unstable, and risky, use master. Change-Id: Idc9fb38646289867610c60dbc19cac826e529c66
[Libreoffice-bugs] [Bug 148542] EDITING delete row - Crash in: ScBroadcastAreaSlot::DelBroadcastAreasInRange(ScRange const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=148542 weryg...@centrum.cz changed: What|Removed |Added CC||weryg...@centrum.cz --- Comment #1 from weryg...@centrum.cz --- Tried safe mode - deleting the row does not cause any crash. Also tried to reproduce it on my Virtual Machine with LO 7.1.7.2, Windows 10.0 19043 in VMWare 1 - did not crash too. -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: comphelper/source include/comphelper
comphelper/source/property/propagg.cxx |6 --
include/comphelper/propagg.hxx |2 --
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit 8e02f081ab405fe0a51614a37acd32e743c01056
Author: Stephan Bergmann
AuthorDate: Tue Apr 12 17:46:06 2022 +0200
Commit: Stephan Bergmann
CommitDate: Tue Apr 12 21:03:10 2022 +0200
Remove need for OPropertyAccessor default ctor
Change-Id: Ia5ae4e28aa880600ce80bd284cde5183c49e4b40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132929
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann
diff --git a/comphelper/source/property/propagg.cxx
b/comphelper/source/property/propagg.cxx
index a93c82c98fae..d864450898d6 100644
--- a/comphelper/source/property/propagg.cxx
+++ b/comphelper/source/property/propagg.cxx
@@ -88,7 +88,8 @@
OPropertyArrayAggregationHelper::OPropertyArrayAggregationHelper(
auto = m_aProperties[ nMPLoop ];
if ( aDelegatorProps.find( prop.Name ) != aDelegatorProps.end() )
{
-m_aPropertyAccessors[ prop.Handle ] = OPropertyAccessor( -1,
nMPLoop, false );
+m_aPropertyAccessors.insert_or_assign(
+prop.Handle, OPropertyAccessor( -1, nMPLoop, false ));
existingHandles.insert( prop.Handle );
}
else
@@ -111,7 +112,8 @@
OPropertyArrayAggregationHelper::OPropertyArrayAggregationHelper(
}
// remember the accessor for this property
-m_aPropertyAccessors[ nHandle ] = OPropertyAccessor( prop.Handle,
nMPLoop, true );
+m_aPropertyAccessors.insert_or_assign(
+nHandle, OPropertyAccessor( prop.Handle, nMPLoop, true ));
prop.Handle = nHandle;
}
}
diff --git a/include/comphelper/propagg.hxx b/include/comphelper/propagg.hxx
index 4881b2a7c884..5be393be81e8 100644
--- a/include/comphelper/propagg.hxx
+++ b/include/comphelper/propagg.hxx
@@ -54,8 +54,6 @@ namespace internal
OPropertyAccessor(sal_Int32 _nOriginalHandle, sal_Int32 _nPos, bool
_bAggregate)
:nOriginalHandle(_nOriginalHandle) ,nPos(_nPos)
,bAggregate(_bAggregate) { }
-OPropertyAccessor()
-:nOriginalHandle(-1) ,nPos(-1) ,bAggregate(false) { }
bool operator==(const OPropertyAccessor& rOb) const { return nPos ==
rOb.nPos; }
bool operator <(const OPropertyAccessor& rOb) const { return nPos <
rOb.nPos; }
[Libreoffice-bugs] [Bug 148542] New: EDITING delete row - Crash in: ScBroadcastAreaSlot::DelBroadcastAreasInRange(ScRange const &)
https://bugs.documentfoundation.org/show_bug.cgi?id=148542 Bug ID: 148542 Summary: EDITING delete row - Crash in: ScBroadcastAreaSlot::DelBroadcastAreasInRange(ScRange const &) Product: LibreOffice Version: 7.2.6.2 release Hardware: x86-64 (AMD64) OS: Windows (All) Status: UNCONFIRMED Severity: normal Priority: medium Component: Calc Assignee: libreoffice-bugs@lists.freedesktop.org Reporter: weryg...@centrum.cz Created attachment 179493 --> https://bugs.documentfoundation.org/attachment.cgi?id=179493=edit concerned .ods file tracking my car total mileage This bug was filed from the crash reporting server and is br-7aeb1cc4-099c-438a-99e1-0a206878c202. = When attempting to delete an empty row between two populated rows in a Calc sheet, LO repeatedly crashes. It's a file that was not opened for approximately two years. It was saved on my personal OneDrive account. See the attachment. Windows 11 21H2 22000.593, LO 7.2.6.2 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx | 11 +++
vcl/unx/gtk4/surfacecellrenderer.cxx | 32 ++--
2 files changed, 33 insertions(+), 10 deletions(-)
New commits:
commit 01cb63b986d0879e10b58991959e0989b125b577
Author: Caolán McNamara
AuthorDate: Tue Apr 12 17:44:57 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:58:47 2022 +0200
gtk4: GtkCellRendererPixbuf no longer takes a surface
so use our own replacement when we want to continue to use a cairo_surface
Change-Id: I4a1a0e7f5a86d27a4290cf71c0719ea017be3f0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132930
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index a3449e02c3cb..4d6679a31ef7 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -19189,6 +19189,7 @@ public:
SAL_WARN_IF(!m_pMenuWindow, "vcl.gtk", "GtkInstanceComboBox: couldn't
find popup menu");
bool bHasEntry = gtk_combo_box_get_has_entry(m_pComboBox);
+bool bPixbufUsedSurface = gtk_tree_model_get_n_columns(m_pTreeModel)
== 4;
bool bFindButtonTextRenderer = !bHasEntry;
GtkCellLayout* pCellLayout = GTK_CELL_LAYOUT(m_pComboBox);
@@ -19206,6 +19207,16 @@ public:
}
}
+// Seeing as GtkCellRendererPixbuf no longer takes a surface, then
insert our own replacement
+// to render that instead here
+if (bPixbufUsedSurface)
+{
+GtkCellRenderer* pSurfaceRenderer = surface_cell_renderer_new();
+gtk_cell_layout_pack_start(pCellLayout, pSurfaceRenderer, false);
+gtk_cell_layout_reorder(pCellLayout, pSurfaceRenderer, 0);
+gtk_cell_layout_set_attributes(pCellLayout, pSurfaceRenderer,
"surface", 3, nullptr);
+}
+
if (bHasEntry)
{
m_bAutoComplete = true;
diff --git a/vcl/unx/gtk4/surfacecellrenderer.cxx
b/vcl/unx/gtk4/surfacecellrenderer.cxx
index f8015bb110b2..2ae0782b984c 100644
--- a/vcl/unx/gtk4/surfacecellrenderer.cxx
+++ b/vcl/unx/gtk4/surfacecellrenderer.cxx
@@ -165,6 +165,17 @@ GtkCellRenderer* surface_cell_renderer_new()
return GTK_CELL_RENDERER(g_object_new(SURFACE_TYPE_CELL_RENDERER,
nullptr));
}
+static void get_surface_size(cairo_surface_t* pSurface, int& rWidth, int&
rHeight)
+{
+double x1, x2, y1, y2;
+cairo_t* cr = cairo_create(pSurface);
+cairo_clip_extents(cr, , , , );
+cairo_destroy(cr);
+
+rWidth = x2 - x1;
+rHeight = y2 - y1;
+}
+
bool surface_cell_renderer_get_preferred_size(GtkCellRenderer* cell,
GtkOrientation orientation,
gint* minimum_size, gint*
natural_size)
{
@@ -174,15 +185,7 @@ bool
surface_cell_renderer_get_preferred_size(GtkCellRenderer* cell, GtkOrientat
int nHeight = 0;
if (cellsurface->surface)
-{
-double x1, x2, y1, y2;
-cairo_t* cr = cairo_create(cellsurface->surface);
-cairo_clip_extents(cr, , , , );
-cairo_destroy(cr);
-
-nWidth = x2 - x1;
-nHeight = y2 - y1;
-}
+get_surface_size(cellsurface->surface, nWidth, nHeight);
if (orientation == GTK_ORIENTATION_HORIZONTAL)
{
@@ -209,7 +212,16 @@ void surface_cell_renderer_render(GtkCellRenderer* cell,
cairo_t* cr, GtkWidget*
const GdkRectangle* cell_area,
GtkCellRendererState /*flags*/)
{
SurfaceCellRenderer* cellsurface = SURFACE_CELL_RENDERER(cell);
-cairo_set_source_surface(cr, cellsurface->surface, cell_area->x,
cell_area->y);
+if (!cellsurface->surface)
+return;
+
+int nWidth, nHeight;
+get_surface_size(cellsurface->surface, nWidth, nHeight);
+int nXOffset = (cell_area->width - nWidth) / 2;
+int nYOffset = (cell_area->height - nHeight) / 2;
+
+cairo_set_source_surface(cr, cellsurface->surface, cell_area->x + nXOffset,
+ cell_area->y + nYOffset);
cairo_paint(cr);
}
[Libreoffice-commits] core.git: sc/source
sc/source/core/data/documen4.cxx |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit cbf9f638807736e69a5863a19128ade085b1a187
Author: Caolán McNamara
AuthorDate: Tue Apr 12 12:45:20 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:52:53 2022 +0200
ofz#46352 Timeout
Change-Id: I4544c9c15ec26fb1c27ec0f28ef956320d06a149
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132900
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/sc/source/core/data/documen4.cxx b/sc/source/core/data/documen4.cxx
index cf8d2e4a1431..271e07619ef8 100644
--- a/sc/source/core/data/documen4.cxx
+++ b/sc/source/core/data/documen4.cxx
@@ -275,9 +275,9 @@ void ScDocument::InsertMatrixFormula(SCCOL nCol1, SCROW
nRow1,
if (utl::ConfigManager::IsFuzzing())
{
// just too slow
-if (nCol2 - nCol1 > 128)
+if (nCol2 - nCol1 > 64)
return;
-if (nRow2 - nRow1 > 128)
+if (nRow2 - nRow1 > 64)
return;
}
assert( ValidColRow( nCol1, nRow1) && ValidColRow( nCol2, nRow2));
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk3/gtkinst.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit e21fa6a5fdca05c49b4fcb9961690cfb6e240909
Author: Caolán McNamara
AuthorDate: Tue Apr 12 16:29:30 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:52:15 2022 +0200
[loplugin:stringview] pass a 'std::string_view'
Change-Id: If2e355729f051cd5be517fb05e8909844a24c7f6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132927
Tested-by: Jenkins
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk3/gtkinst.cxx b/vcl/unx/gtk3/gtkinst.cxx
index 6941df209dae..a3449e02c3cb 100644
--- a/vcl/unx/gtk3/gtkinst.cxx
+++ b/vcl/unx/gtk3/gtkinst.cxx
@@ -5213,7 +5213,7 @@ public:
char *id;
if (g_menu_model_get_item_attribute(pMenuModel, i, "action", "s",
))
{
-assert(OString(id).startsWith("menu."));
+assert(o3tl::starts_with(id, "menu."));
sAction = OString(id + 5);
[Libreoffice-commits] core.git: compilerplugins/clang vcl/Library_vclplug_gtk4.mk vcl/unx
compilerplugins/clang/reservedid.cxx |2
vcl/Library_vclplug_gtk4.mk |1
vcl/unx/gtk4/gtkinst.cxx |1
vcl/unx/gtk4/surfacecellrenderer.cxx | 229 +++
vcl/unx/gtk4/surfacecellrenderer.hxx | 42 ++
5 files changed, 275 insertions(+)
New commits:
commit 77bc0bcfb610b77a9191af2343f64eae36073540
Author: Caolán McNamara
AuthorDate: Mon Apr 11 15:26:40 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:51:47 2022 +0200
gtk4: add a surface_cell_renderer
to bridge our continuing usage of cairo and gtk4 GtkComboBox cell renderers
without dropping any existing hidpi wins
Change-Id: If5244766c13dd5d82445cb626ef4096e3c6ea244
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132926
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/compilerplugins/clang/reservedid.cxx
b/compilerplugins/clang/reservedid.cxx
index 2ef713916569..be0a2f209f71 100644
--- a/compilerplugins/clang/reservedid.cxx
+++ b/compilerplugins/clang/reservedid.cxx
@@ -215,6 +215,8 @@ bool ReservedId::VisitNamedDecl(NamedDecl const * decl) {
&& s != "_NotifyingLayout" // vcl/unx/gtk4/notifyinglayout.cxx
&& s != "_SurfacePaintable" // vcl/unx/gtk3/gtkinst.cxx
&& s != "_SurfacePaintableClass" // vcl/unx/gtk3/gtkinst.cxx
+&& s != "_SurfaceCellRenderer" //
vcl/unx/gtk4/surfacecellrenderer.cxx
+&& s != "_SurfaceCellRendererClass" //
vcl/unx/gtk4/surfacecellrenderer.cxx
&& s != "_TransferableContent" //
vcl/unx/gtk4/transferableprovider.cxx
&& s != "_TransferableContentClass" //
vcl/unx/gtk4/transferableprovider.cxx
&& s != "_XRegion" // vcl/unx/generic/gdi/x11cairotextrender.cxx
diff --git a/vcl/Library_vclplug_gtk4.mk b/vcl/Library_vclplug_gtk4.mk
index 83695a8c1c34..d9c19f5521b0 100644
--- a/vcl/Library_vclplug_gtk4.mk
+++ b/vcl/Library_vclplug_gtk4.mk
@@ -99,6 +99,7 @@ $(eval $(call gb_Library_add_exception_objects,vclplug_gtk4,\
vcl/unx/gtk4/gloactiongroup \
vcl/unx/gtk4/hudawareness \
vcl/unx/gtk4/notifyinglayout \
+vcl/unx/gtk4/surfacecellrenderer \
vcl/unx/gtk4/surfacepaintable \
vcl/unx/gtk4/transferableprovider \
))
diff --git a/vcl/unx/gtk4/gtkinst.cxx b/vcl/unx/gtk4/gtkinst.cxx
index 502eed2aa246..658c01233c84 100644
--- a/vcl/unx/gtk4/gtkinst.cxx
+++ b/vcl/unx/gtk4/gtkinst.cxx
@@ -12,6 +12,7 @@
#include "convert3to4.hxx"
#include "notifyinglayout.hxx"
+#include "surfacecellrenderer.hxx"
#include "surfacepaintable.hxx"
#include "transferableprovider.hxx"
diff --git a/vcl/unx/gtk4/surfacecellrenderer.cxx
b/vcl/unx/gtk4/surfacecellrenderer.cxx
new file mode 100644
index ..f8015bb110b2
--- /dev/null
+++ b/vcl/unx/gtk4/surfacecellrenderer.cxx
@@ -0,0 +1,229 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include
+#include "surfacecellrenderer.hxx"
+#include
+
+namespace
+{
+struct _SurfaceCellRendererClass : public GtkCellRendererClass
+{
+};
+
+enum
+{
+PROP_SURFACE = 1,
+};
+}
+
+G_DEFINE_TYPE(SurfaceCellRenderer, surface_cell_renderer,
GTK_TYPE_CELL_RENDERER)
+
+static void surface_cell_renderer_init(SurfaceCellRenderer* self)
+{
+self->surface = nullptr;
+// prevent loplugin:unreffun firing on macro generated function
+(void)surface_cell_renderer_get_instance_private(self);
+}
+
+static void surface_cell_renderer_get_property(GObject* object, guint
param_id, GValue* value,
+ GParamSpec* pspec)
+{
+SurfaceCellRenderer* cellsurface = SURFACE_CELL_RENDERER(object);
+
+switch (param_id)
+{
+case PROP_SURFACE:
+g_value_set_boxed(value, cellsurface->surface);
+break;
+default:
+G_OBJECT_CLASS(surface_cell_renderer_parent_class)
+->get_property(object, param_id, value, pspec);
+break;
+}
+}
+
+static void surface_cell_renderer_set_property(GObject* object, guint
param_id, const GValue* value,
+ GParamSpec* pspec)
+{
+SurfaceCellRenderer* cellsurface = SURFACE_CELL_RENDERER(object);
+
+switch (param_id)
+{
+case PROP_SURFACE:
+if (cellsurface->surface)
+cairo_surface_destroy(cellsurface->surface);
+cellsurface->surface =
static_cast(g_value_get_boxed(value));
+if (cellsurface->surface)
+cairo_surface_reference(cellsurface->surface);
+break;
+default:
+G_OBJECT_CLASS(surface_cell_renderer_parent_class)
+
[Libreoffice-commits] core.git: cui/uiconfig sd/uiconfig
cui/uiconfig/ui/lineendstabpage.ui| 147 sd/uiconfig/simpress/ui/sidebarslidebackground.ui | 197 +++--- 2 files changed, 175 insertions(+), 169 deletions(-) New commits: commit 8e0c19973726961d2099e541a74c9ff788f9df43 Author: Caolán McNamara AuthorDate: Mon Apr 11 09:15:22 2022 +0100 Commit: Caolán McNamara CommitDate: Tue Apr 12 20:51:15 2022 +0200 resave with latest glade Change-Id: Ib84f706deccc1f71810abc97a4208d5106826235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132901 Tested-by: Jenkins Reviewed-by: Caolán McNamara diff --git a/cui/uiconfig/ui/lineendstabpage.ui b/cui/uiconfig/ui/lineendstabpage.ui index c4597471c97e..2f63fcc1bec6 100644 --- a/cui/uiconfig/ui/lineendstabpage.ui +++ b/cui/uiconfig/ui/lineendstabpage.ui @@ -1,16 +1,16 @@ - + True -False -res/sc05501.png +False +res/sc05501.png True -False -res/sc05502.png +False +res/sc05502.png @@ -26,86 +26,86 @@ True -False +False True True -6 -0 -none +6 +0 +none True -False +False +12 +12 +6 True True vertical 6 -12 -6 -12 True -False +False True True 12 - + True -False +False True True -6 -12 +6 +12 True -False +False _Title: -True -EDT_NAME +True +EDT_NAME 0 -0 -0 +0 +0 True -False +False Arrow _style: -True +True 0 -0 -1 +0 +1 True -True +True start +30 True -30 -1 -0 +1 +0 True -False +False liststore4 -0 -1 +0 +1 @@ -114,25 +114,28 @@ + +3 + -1 -1 +1 +1 True -False +False end True Add a selected object to create new arrow styles. 0 -0 -2 +0 +2 2 @@ -146,18 +149,18 @@ True -False +False True vertical 6 -start +start _Add True -True -True -True +True +True +True False @@ -169,9 +172,9 @@ _Modify True -True -True -True +True +True +True False @@ -183,8 +186,8 @@
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/generic/gdi/cairotextrender.cxx |9 +
1 file changed, 9 insertions(+)
New commits:
commit 9c47425041eb8c610da2963bdbaa707a6d3ea1f9
Author: Caolán McNamara
AuthorDate: Tue Apr 12 10:26:40 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:50:39 2022 +0200
ofz#46632 Direct-leak
Change-Id: I01fe4ae8907fb95708d54a39d1cc78d89b4d6e64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132893
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/generic/gdi/cairotextrender.cxx
b/vcl/unx/generic/gdi/cairotextrender.cxx
index 9fd3ec8b4745..31c2a73c2eb4 100644
--- a/vcl/unx/generic/gdi/cairotextrender.cxx
+++ b/vcl/unx/generic/gdi/cairotextrender.cxx
@@ -152,6 +152,15 @@ void CairoTextRender::DrawTextLayout(const
GenericSalLayout& rLayout, const SalG
if (nWidth == 0 || nHeight == 0)
return;
+if (nHeight > SAL_MAX_UINT16)
+{
+// as seen with freetype 2.11.0, so cairo surface status is "fail"
+// ("error occurred in libfreetype") and no further operations are
+// executed, so this error then leads to later leaks
+SAL_WARN("vcl", "rendering text would fail with height: " << nHeight);
+return;
+}
+
int nRatio = nWidth * 10 / nHeight;
if (FreetypeFont::AlmostHorizontalDrainsRenderingPool(nRatio, rFSD))
return;
[Libreoffice-commits] core.git: vcl/unx
vcl/unx/gtk4/convert3to4.cxx | 14 ++
1 file changed, 14 insertions(+)
New commits:
commit f7fd2d4e3ec89afa524b3dac1c8533acafa9a015
Author: Caolán McNamara
AuthorDate: Tue Apr 12 16:01:33 2022 +0100
Commit: Caolán McNamara
CommitDate: Tue Apr 12 20:50:03 2022 +0200
gtk4: cairo_gobject_surface_get_type() needs to be called at least once
before "CairoSurface" can be resolved to its type, this worked in gtk3
because there was some fallback code which guessed what function name
was needed to call to get it, but that's not present in gtk4
Change-Id: I85a957ecd37e0e7a572578e8273152fbb19dac3c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132920
Tested-by: Caolán McNamara
Reviewed-by: Caolán McNamara
diff --git a/vcl/unx/gtk4/convert3to4.cxx b/vcl/unx/gtk4/convert3to4.cxx
index 747ea7553093..470b12de490a 100644
--- a/vcl/unx/gtk4/convert3to4.cxx
+++ b/vcl/unx/gtk4/convert3to4.cxx
@@ -15,6 +15,7 @@
#include
#include
#include
+#include
#include "convert3to4.hxx"
namespace
@@ -1502,6 +1503,17 @@ ConvertResult Convert3To4(const
css::uno::Reference& xNode
return ConvertResult(bChildCanFocus, bHasVisible, bHasIconSize,
bAlwaysShowImage, bUseUnderline,
bVertOrientation, bXAlign, eImagePos, xPropertyLabel,
xPropertyIconName);
}
+
+std::once_flag cairo_surface_type_flag;
+
+void ensure_cairo_surface_type()
+{
+// cairo_gobject_surface_get_type needs to be called at least once for
+// g_type_from_name to be able to resolve "CairoSurface". In gtk3 there
was fallback
+// mechanism to attempt to resolve such "missing" types which is not in
place for
+// gtk4 so ensure it can be found explicitly
+std::call_once(cairo_surface_type_flag, []() {
cairo_gobject_surface_get_type(); });
+}
}
void builder_add_from_gtk3_file(GtkBuilder* pBuilder, const OUString& rUri)
@@ -1533,6 +1545,8 @@ void builder_add_from_gtk3_file(GtkBuilder* pBuilder,
const OUString& rUri)
css::uno::Reference(xWriter,
css::uno::UNO_QUERY_THROW),
css::uno::Sequence());
+ensure_cairo_surface_type();
+
// feed it to GtkBuilder
css::uno::Reference xTempSeek(xTempStream,
css::uno::UNO_QUERY_THROW);
xTempSeek->seek(0);
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - basctl/source
basctl/source/basicide/baside3.cxx |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 161d51704e2c76034b5cc1413ca99df45df81ea4
Author: Samuel Mehrbrodt
AuthorDate: Fri Apr 8 15:59:11 2022 +0200
Commit: Christian Lohmaier
CommitDate: Tue Apr 12 20:46:21 2022 +0200
tdf#147876 Fix crash when cancelling Dialog import dlg
Regression from 9a55b97e980bbf2a0ce12841f6168f1f7545ac96
Change-Id: I3fc35981a0cb81e5b59236ec3b07450aec10541a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132737
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt
(cherry picked from commit 618d40799d25474c48d984ce1d52b0f08f220958)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132855
Reviewed-by: Christian Lohmaier
diff --git a/basctl/source/basicide/baside3.cxx
b/basctl/source/basicide/baside3.cxx
index 920e82da3d0a..7b7e5db43b89 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -851,7 +851,7 @@ bool implImportDialog(weld::Window* pWin, const
ScriptDocument& rDocument, const
xFP->appendFilter( IDEResId(RID_STR_FILTER_ALLFILES), FilterMask_All );
xFP->setCurrentFilter( aDialogStr );
-if( aDlg.Execute() != ERRCODE_NONE )
+if( aDlg.Execute() == ERRCODE_NONE )
{
Sequence< OUString > aPaths = xFP->getSelectedFiles();
[Libreoffice-commits] core.git: Branch 'libreoffice-7-3' - translations
translations |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 233bef275374f9c7f20710ab4ac0996e11535936 Author: Christian Lohmaier AuthorDate: Tue Apr 12 20:38:38 2022 +0200 Commit: Gerrit Code Review CommitDate: Tue Apr 12 20:38:38 2022 +0200 Update git submodules * Update translations from branch 'libreoffice-7-3' to d843f8419c9d76bad4700c70ed225ca3f8ce - update translations for 7.3.3 rc1 and force-fix errors using pocheck Change-Id: I6f710c70cb05b213a474cc705541d2558c2304dd diff --git a/translations b/translations index 6e640300395f..d843f8419c9d 16 --- a/translations +++ b/translations @@ -1 +1 @@ -Subproject commit 6e640300395f31da22a9b1a3d44c9cfa2fc91222 +Subproject commit d843f8419c9d76bad4700c70ed225ca3f8ce
[Libreoffice-commits] translations.git: Branch 'libreoffice-7-3' - source/an source/ar source/ast source/ca source/cs source/de source/dsb source/el source/eo source/es source/fr source/gl source/gug
source/an/cui/messages.po| 17 source/an/sc/messages.po | 12 source/an/sd/messages.po | 6 source/an/sfx2/messages.po | 6 source/an/shell/source/win32/shlxthandler/res.po | 9 source/an/svtools/messages.po| 12 source/an/svx/messages.po| 23 source/an/sw/messages.po | 10 source/ar/scaddins/messages.po | 8 source/ar/svx/messages.po| 18 source/ar/sw/messages.po | 8 source/ast/basctl/messages.po| 4 source/ast/extras/source/autocorr/emoji.po | 38 source/ast/helpcontent2/source/text/sbasic/shared.po | 4 source/ast/helpcontent2/source/text/scalc/01.po | 6 source/ast/helpcontent2/source/text/scalc/guide.po | 6 source/ast/helpcontent2/source/text/swriter/01.po| 4 source/ast/sc/messages.po| 6 source/ast/sfx2/messages.po | 11 source/ast/svx/messages.po | 24 source/ast/sw/messages.po| 29 source/ast/uui/messages.po | 6 source/ast/vcl/messages.po | 8 source/ca/cui/messages.po| 4 source/ca/helpcontent2/source/text/simpress/guide.po | 10 source/cs/helpcontent2/source/text/shared/guide.po | 6 source/de/helpcontent2/source/text/sbasic/shared/03.po | 624 ++--- source/dsb/chart2/messages.po| 8 source/dsb/cui/messages.po | 1234 +- source/dsb/sd/messages.po| 6 source/dsb/svx/messages.po | 6 source/el/helpcontent2/source/text/shared/01.po | 6 source/el/helpcontent2/source/text/shared/guide.po | 8 source/eo/sfx2/messages.po | 10 source/es/filter/messages.po | 8 source/es/helpcontent2/source/text/sbasic/guide.po | 6 source/es/helpcontent2/source/text/sbasic/shared.po | 4 source/es/helpcontent2/source/text/shared/01.po | 4 source/es/helpcontent2/source/text/shared/02.po | 4 source/es/helpcontent2/source/text/simpress/guide.po | 10 source/es/helpcontent2/source/text/smath/01.po | 10 source/es/helpcontent2/source/text/swriter/01.po | 10 source/es/svx/messages.po| 4 source/es/sw/messages.po | 20 source/fr/sw/messages.po | 8 source/gl/helpcontent2/source/auxiliary.po | 16 source/gl/helpcontent2/source/text/scalc/04.po | 34 source/gl/helpcontent2/source/text/scalc/05.po | 16 source/gl/helpcontent2/source/text/sdraw.po | 16 source/gl/helpcontent2/source/text/simpress/00.po| 16 source/gl/officecfg/registry/data/org/openoffice/Office/UI.po| 12 source/gug/helpcontent2/source/text/sbasic/guide.po | 6 source/gug/helpcontent2/source/text/sbasic/shared.po | 4 source/gug/helpcontent2/source/text/shared/01.po | 4 source/gug/helpcontent2/source/text/shared/02.po | 4 source/gug/helpcontent2/source/text/simpress/guide.po| 10 source/gug/helpcontent2/source/text/smath/01.po | 10 source/gug/helpcontent2/source/text/swriter/01.po| 10 source/hr/basic/messages.po | 10 source/hsb/cui/messages.po | 658
[Libreoffice-bugs] [Bug 120640] Values not appearing in base listbox with value list
https://bugs.documentfoundation.org/show_bug.cgi?id=120640 Andreas Heinisch changed: What|Removed |Added CC||andreas.heini...@yahoo.de --- Comment #6 from Andreas Heinisch --- In firebird::mallocSQLVAR [1] the string will be allocated. In the case of char (SQL_TEXT) the length is 12 even if the field only contains 3. In OResultSet::retrieveValue [2] the OUString will be created using that exact length. This leads to this error since the list box compares "ant" with "ant ". Could it be that retrieves the maximum size in bytes for a char? [1] https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/Util.cxx?r=3a88b513#296 [2] https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/firebird/ResultSet.cxx?r=a9c8ac36#584 -- You are receiving this mail because: You are the assignee for the bug.
[Libreoffice-bugs] [Bug 148435] LibreOffice on macOS hanges on using window snapping
https://bugs.documentfoundation.org/show_bug.cgi?id=148435 --- Comment #16 from Peter Hagen --- My pleasure. This bug is annoying me enough to hunt it down haha. And unfortunately I don't have any experience in LibreOffice development, else I would attempt to help find it. -- You are receiving this mail because: You are the assignee for the bug.
